obnox/wireshark/wip.git
19 years agoFix from Ralf Schneider to the IS Neighbor dissection.
guy [Tue, 28 Mar 2000 06:12:15 +0000 (06:12 +0000)]
Fix from Ralf Schneider to the IS Neighbor dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1754 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChange dissect_ppp() to accept offset.
gram [Mon, 27 Mar 2000 17:53:20 +0000 (17:53 +0000)]
Change dissect_ppp() to accept offset.
Change GRE dissector to call dissect_ppp() instead of dissect_payload_ppp().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1753 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd type tag values for the REAL and ENUMERATED types.
guy [Mon, 27 Mar 2000 08:51:05 +0000 (08:51 +0000)]
Add type tag values for the REAL and ENUMERATED types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1752 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNote that we may want to add support for the constructed encoding of
guy [Mon, 27 Mar 2000 08:26:23 +0000 (08:26 +0000)]
Note that we may want to add support for the constructed encoding of
octet strings, as well as the primitive encoding (if we ever run into a
protocol where the constructed encoding is allowed).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1751 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdding definitions of routines ... Will want to get rid of malloc and use
sharpe [Sun, 26 Mar 2000 07:59:47 +0000 (07:59 +0000)]
Adding definitions of routines ... Will want to get rid of malloc and use
the glib equivalents ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1750 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSet the per frame data pointer to NULL when a new frame is read in.
sharpe [Sun, 26 Mar 2000 07:03:52 +0000 (07:03 +0000)]
Set the per frame data pointer to NULL when a new frame is read in.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1749 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFirst pass at per frame proto data. Keep each proto block as a GSList list.
sharpe [Sun, 26 Mar 2000 06:57:41 +0000 (06:57 +0000)]
First pass at per frame proto data. Keep each proto block as a GSList list.

Use glib as far as possible. Currently have data structures and routines
defined ... Next will write the routines ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1748 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of some unnecessary variables.
guy [Thu, 23 Mar 2000 10:49:33 +0000 (10:49 +0000)]
Get rid of some unnecessary variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1747 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't use temporary buffers for strings; use the data in the packet
guy [Thu, 23 Mar 2000 10:25:38 +0000 (10:25 +0000)]
Don't use temporary buffers for strings; use the data in the packet
buffer directly.

Don't use "strlen()" to determine how much Telnet data there is; we have
the number of bytes of Telnet data in a variable, and using "strlen()"
makes it not correctly handle Telnet data with '\0' in it.

Correctly handle Telnet options we don't know about.

General cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1746 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRemove small memory leak when converting strings that represent
gram [Thu, 23 Mar 2000 05:43:57 +0000 (05:43 +0000)]
Remove small memory leak when converting strings that represent
byte sequences in display filters to byte arrays. This was caused
by a duplicate g_strdup() in my code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1745 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen dissecting an NFS file handle, show the raw bytes of the file
guy [Thu, 23 Mar 2000 00:38:11 +0000 (00:38 +0000)]
When dissecting an NFS file handle, show the raw bytes of the file
handle data (snoop does this, and it's somewhat convenient if you're
trying to see whether, say, an ACCESS call is acting on the file whose
file handle you got back from a previous MOUNT request).

Boost the maximum number of bytes worth of hex data shown by
"bytes_to_str()" from 10 to 16, so that we can show the file handle 16
bytes per line (as snoop does).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1744 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFlorian Lohoff's fixes to L2TP result and error code dissection.
guy [Wed, 22 Mar 2000 23:49:20 +0000 (23:49 +0000)]
Florian Lohoff's fixes to L2TP result and error code dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1743 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the previous checkin actually compile on big-endian machines.
guy [Wed, 22 Mar 2000 23:47:28 +0000 (23:47 +0000)]
Make the previous checkin actually compile on big-endian machines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1742 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoByte-swap the frame table on big-endian machines.
guy [Wed, 22 Mar 2000 09:52:21 +0000 (09:52 +0000)]
Byte-swap the frame table on big-endian machines.

Free it as soon as we're at the end of the sequential pass through the
file; that way, if we keep the capture file open with Wiretap even after
that's done (as I may do as part of some stuff I'm working on), we
at least aren't hanging on to the frame table memory after that point.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1741 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIn a Network Monitor capture file, get the starting offsets of frames
guy [Wed, 22 Mar 2000 07:06:59 +0000 (07:06 +0000)]
In a Network Monitor capture file, get the starting offsets of frames
from the frame table - Network Monitor 2.x, at least, doesn't always
write frame N+1 right after frame N.

To do that, we need to mallocate a big array to hold the frame table,
and free it when we close the capture file; this requires that we have
capture-file-type-specific close routines as well as
capture-file-type-specific read routines - we let it the pointer to that
routine be null if it's not needed.  Given that, we might as well get
rid of the switch statement in "wtap_close()", in favor of using
capture-file-type-specific close routines, as per the comment before
that switch statement.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1740 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSome cleanup of the RADIUS AVP output (Tunnel Tagging Tag), and a bit of
guy [Tue, 21 Mar 2000 19:20:41 +0000 (19:20 +0000)]
Some cleanup of the RADIUS AVP output (Tunnel Tagging Tag), and a bit of
Vendor-specific decoding (shows at least the Vendor), from Florian
Lohoff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1739 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAndreas Sikkema's patch to make the SMB dissector not blithely pass a
guy [Tue, 21 Mar 2000 10:15:50 +0000 (10:15 +0000)]
Andreas Sikkema's patch to make the SMB dissector not blithely pass a
null "request_val->last_transact_command" to "col_add_fstr()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1738 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPaul Welchinski's changes to, on Win32 systems:
guy [Tue, 21 Mar 2000 06:52:13 +0000 (06:52 +0000)]
Paul Welchinski's changes to, on Win32 systems:

properly handle ASCII vs. Unicode in the list of interfaces;

initialize Winsock before starting a capture, so that the code
in the Win32 libpcap to get the IP address and netmask by
translating the host name to an IP address works.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1737 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCreate the tree entry for resource records in DNS replies, and add the
guy [Tue, 21 Mar 2000 06:21:37 +0000 (06:21 +0000)]
Create the tree entry for resource records in DNS replies, and add the
record type to the info column, before parsing the reply; add the text
for the entry, and any additional information for the info column, in
the code that handles the reply.

Don't use stuff from the resource record if you ran past the end of the
packet.

Fix some bit-scanning code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1736 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd support for TXT and WKS records to the DNS dissector.
guy [Tue, 21 Mar 2000 05:15:12 +0000 (05:15 +0000)]
Add support for TXT and WKS records to the DNS dissector.

Add EIGRP and VINES to the list of protocols "ipprotostr()" knows about.

Get rid of the "proto_vals" table in "packet-ip.c" - it's not used, and
the two entries it had that weren't in the table in "ipproto.c" have
been moved there.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1735 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoJochen Friedrich's fix to IPv6 fragment handling.
guy [Tue, 21 Mar 2000 04:15:14 +0000 (04:15 +0000)]
Jochen Friedrich's fix to IPv6 fragment handling.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1734 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChange dfilter_init() to check for empty-string abbreviations and for
gram [Mon, 20 Mar 2000 22:52:48 +0000 (22:52 +0000)]
Change dfilter_init() to check for empty-string abbreviations and for
duplicate abbreviations. All mods to packet-*.c files are fixes to remove
those cases.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1733 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd fields tr.addr, fddi.addr, and isl.addr that act like eth.addr, matching
gram [Mon, 20 Mar 2000 22:22:45 +0000 (22:22 +0000)]
Add fields tr.addr, fddi.addr, and isl.addr that act like eth.addr, matching
either *.src or *.dst

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1732 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdded Novell option decoding patch from Fredrik Sorensson <fsn@volvo.se>.
gerald [Mon, 20 Mar 2000 21:39:00 +0000 (21:39 +0000)]
Added Novell option decoding patch from Fredrik Sorensson <fsn@volvo.se>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1731 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdded Jeff Foster's patch to add an eth.addr field.
gram [Mon, 20 Mar 2000 21:21:33 +0000 (21:21 +0000)]
Added Jeff Foster's patch to add an eth.addr field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1730 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFlorian Lohoff's changes for RADIUS tunnel attributes and for the
guy [Mon, 20 Mar 2000 18:30:59 +0000 (18:30 +0000)]
Florian Lohoff's changes for RADIUS tunnel attributes and for the
Internet Draft for RADIUS tunnel attribute tagging.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1729 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIn "add_packet_to_packet_list()", always use the "buf" argument to refer
guy [Mon, 20 Mar 2000 04:55:10 +0000 (04:55 +0000)]
In "add_packet_to_packet_list()", always use the "buf" argument to refer
to the raw packet data, don't use "cf->pd" - "cf->pd" doesn't contain
the packet data when the file is being read in, it only contains it when
we're re-reading packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1728 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChange the type of the "v120.control" protocol field from FT_STRING to
guy [Fri, 17 Mar 2000 05:21:48 +0000 (05:21 +0000)]
Change the type of the "v120.control" protocol field from FT_STRING to
FT_UINT16; the xDLC code requires control fields to be FT_UINTn, as it
uses "proto_tree_add_uint_format()" to add that field to the protocol
tree.

Always pass TRUE as the "is_extended" argument to
"dissect_xdlc_control()" - the V.120 spec says "The data link control
sublayer provides the procedures and formats of fields for data link
layer peer-to-peer communication.  ...  For formats and the elements of
procedures, see Recommendation Q.922", and Q.922 seems to at least allow
for modulo 128 operation; it also speaks of SABME, as does V.120, and I
*think* the "extended" in "Set asynchronous balanced mode extended"
means "modulo 128".

Dissect the terminal adaptation sublayer header field after dissecting
the control field, so that the V.120 tree shows the data in sequential
order.

Calculates the length of the V.120 header based on the control field
type (using the "XDLC_CONTROL_LEN()" macro) and the length of the
terminal adaptation sublayer header ("dissect_v120_header()" now returns
the length of what it dissects).

Call "dissect_data()" on the V.120 payload, so you at least know how
much data there is, and can click on an item to see it highlighted.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1727 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPut the EIGRP packet type into the INFO column in the packet list entry
guy [Thu, 16 Mar 2000 08:23:21 +0000 (08:23 +0000)]
Put the EIGRP packet type into the INFO column in the packet list entry
for an EIGRP packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1726 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChanged the type of the lapb.control protocol field from FT_STRING to
oabad [Wed, 15 Mar 2000 19:17:08 +0000 (19:17 +0000)]
Changed the type of the lapb.control protocol field from FT_STRING to
FT_UINT8.
The lapb dissector was broken by the changes to `proto_tree_add_uint_format'
in xdlc.c because of the type of this field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1725 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGive all the Ethereal APIs available to plugins their own function
guy [Wed, 15 Mar 2000 19:09:52 +0000 (19:09 +0000)]
Give all the Ethereal APIs available to plugins their own function
pointers, and call the APIs by calling through the function pointers -
the old technique of using wrappers didn't work, as the underlying
function they all called no longer exists.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1724 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRename the local variable "pi" to "ti" in several places - "pi" is also
guy [Wed, 15 Mar 2000 18:38:58 +0000 (18:38 +0000)]
Rename the local variable "pi" to "ti" in several places - "pi" is also
the name of the global variable containing packet information, and, on
platforms where dynamically-loaded code can't access global variables
and functions in the main program, we #define "pi" in plugins to be
"(*p_pi)", which causes problems even if a plugin with a local variable
named "pi" *isn't* accessing the global "pi".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1723 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGive the entry box in the "Find Frame" and "Go To Frame" dialog boxes
guy [Wed, 15 Mar 2000 08:54:24 +0000 (08:54 +0000)]
Give the entry box in the "Find Frame" and "Go To Frame" dialog boxes
the initial focus, so you can start typing immediately.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1722 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTreat the two integers after the request ID in a BulkPDU as
guy [Wed, 15 Mar 2000 07:12:55 +0000 (07:12 +0000)]
Treat the two integers after the request ID in a BulkPDU as
"non-repeaters" and "max-repetitions" rather than as "error status" and
"error index".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1721 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDietmar Petras' fix to the handling of SNMPv2 TRAP PDUs.
guy [Wed, 15 Mar 2000 07:05:10 +0000 (07:05 +0000)]
Dietmar Petras' fix to the handling of SNMPv2 TRAP PDUs.

Fix a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1720 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSigh. OpenBSD defines "HAVE_UNISTD_H" in the Makefile for zlib, so,
guy [Tue, 14 Mar 2000 18:27:44 +0000 (18:27 +0000)]
Sigh.  OpenBSD defines "HAVE_UNISTD_H" in the Makefile for zlib, so,
unlike FreeBSD and older versions of NetBSD, which give "gzseek()" and
"gztell()" signatures with "long" file-offset arguments, and thus, on
some versions, requires that "HAVE_UNISTD_H" *not* be defined before
including "zlib.h" if you want the functions declared with a signature
that matches what's actually in the library, it requires that it *be*
defined before including "zlib.h" if you want the functions declared
with a signature that matches what's actually in the library.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1719 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoOn Windows, when getting the user's home directory, don't look at the
guy [Tue, 14 Mar 2000 08:26:19 +0000 (08:26 +0000)]
On Windows, when getting the user's home directory, don't look at the
HOME environment variable; instead, look at HOMEDRIVE and HOMEPATH.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1718 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoConvert two instances of proto_tree_add_uint_format() to
gram [Tue, 14 Mar 2000 07:12:23 +0000 (07:12 +0000)]
Convert two instances of proto_tree_add_uint_format() to
proto_tree_add_protocol_format(). I had converted them incorrectly
when I changed them from their original proto_tree_add_item_format().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1717 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix some errors discovered by making GCC do format string/argument
guy [Tue, 14 Mar 2000 06:03:26 +0000 (06:03 +0000)]
Fix some errors discovered by making GCC do format string/argument
cross-checking, and by replacing "proto_tree_add_item_format()" by
multiple routines to add items of various types.

Make the arguments of "proto_tree_add_bytes_format()" and
"proto_tree_add_string_format()" that specify the bytes or the string be
"const" pointers, so that one can pass a "const" pointer without
complaints from the compiler.

Squelch a (bogus, but the compiler isn't in a position to know that)
complaint about an uninitialized variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1716 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRemove the proto_tree_add_text() and proto_tree_add_item_hidden() calls
gram [Mon, 13 Mar 2000 16:36:31 +0000 (16:36 +0000)]
Remove the proto_tree_add_text() and proto_tree_add_item_hidden() calls
for mpls.label and replace them with proto_tree_add_uint_format() and
proto_tree_add_item(). In the mpls proto_registration, associated
the val_string with mpls.label.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1715 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNew workaround for not using (ulong *) to dereference memory in RSVP.
ashokn [Mon, 13 Mar 2000 05:19:50 +0000 (05:19 +0000)]
New workaround for not using (ulong *) to dereference memory in RSVP.
Here's the email I wrote to Guy with info on this:

Subject: Re: [ethereal-dev] Checked in support for MPLS
From: Ashok Narayanan <ashokn@cisco.com>
To: gharris@flashcom.net
Cc: ethereal-dev@zing.org
Date: Mon, 13 Mar 2000 00:10:38 -0500
X-Mailer: Mew version 1.94.1 on XEmacs 21.1 (Biscayne)

Guy,

> The code in that was fetching some fields by casting pointers into the
> packet to "ulong *" and dereferencing the resulting pointer - this is
> bad for three reasons:
>
>  "ulong" is not a system-declared data type on all platforms
>  (it's not on FreeBSD 3.4, at least, for example);
>
>  casting an arbitrary pointer into a frame to point to something
>  longer than 1 byte, and dereferencing it, is dangerous, as
>  there's no guarantee that said pointer is properly aligned on
>  machines that require alignment (such as SPARC, Alpha, and MIPS,
>  and possibly at least some other RISC processors);

I agree with both these points.

>  the data in an RSVP packet is presumably big-endian in any case,
>  so you should use "pntohl()" to access it, rather than just
>  blithely dereferencing it;

This is the exact problem which a direct cast attempts to work
around. A tree of type FT_IPv4 apparently has a network-to-host
conversion built into the proto_tree_add_item call. When you added the
pntohl, you inserted a second network-to-host conversion - the result
is that all the IP addresses are reversed. Here's an excerpt from
tethereal....

1) ~/sniffer/test/ethereal> ./tethereal -n -r ../../sniffs/mpls_te.cap -R 'rsvp.path'
  3   8.024159     17.3.3.3 -> 16.2.2.2     RSVP PATH Message
 15  31.589751     17.3.3.3 -> 16.2.2.2     RSVP PATH Message
 22  47.072205     17.3.3.3 -> 16.2.2.2     RSVP PATH Message
<snip>

2) ~/sniffer/test/ethereal> ./tethereal -n -r ../../sniffs/mpls_te.cap -R 'rsvp.path' -V
Frame 3 (306 on wire, 306 captured)
<snip>
Ethernet II
<snip>
Internet Protocol
<snip>
    Source: 17.3.3.3 (17.3.3.3)
    Destination: 16.2.2.2 (16.2.2.2)          <======== Destination is 16.2.2.2
    Options: (4 bytes)
        Unknown (0x94) (4 bytes)
Resource ReserVation Protocol (RSVP)
    RSVP Header
        RSVP Version: 1
        Flags: 00
        Message Type: PATH Message (1)
        Message Checksum
        Sending TTL: 254
        Message length: 264
    SESSION: 1
        Length: 16
        Class number: 1 - SESSION object
        C-type: 7 - IPv4 LSP
        Destination address: 2.2.2.16 (2.2.2.16)  <======== Destination is reversed
        Tunnel ID: 1
        Extended tunnel ID: 285410051

I'm looking around in the filtering code (which I don't really
understand), to see if I can find a quick fix to the problem. If you
or Gilbert knows what's happening, you may want to fix it. But as it
stands now, using pntohl() in a proto_tree_add_item() call is broken.

A slightly better workaround is to do something like this:

  memcpy(&ip_addr, pd[offset2], 4);
  proto_tree_add_item(....., ip_addr);

but this is still ugly. I'll implement this workaround and check in
the code (since as it stands now, RSVP decoding is broken). However,
the underlying issue needs to be resolved.

-Ashok

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1714 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoBreak proto_tree_add_item_format() into multiple functions:
gram [Sun, 12 Mar 2000 04:48:32 +0000 (04:48 +0000)]
Break proto_tree_add_item_format() into multiple functions:
proto_tree_add_protocol_format()
proto_tree_add_uint_format()
proto_tree_add_ipxnet_format()
proto_tree_add_ipv4_format()
proto_tree_add_ipv6_format()
proto_tree_add_bytes_format()
proto_tree_add_string_format()
proto_tree_add_ether_format()
proto_tree_add_time_format()
proto_tree_add_double_format()
proto_tree_add_boolean_format()
If using GCC 2.x, we can check the print-format against the variable args
passed in. Regardless of compiler, we can now check at run-time that the
field type passed into the function corresponds to what that function
expects (FT_UINT, FT_BOOLEAN, etc.)

Note that proto_tree_add_protocol_format() does not require a value field,
since the value of a protocol is always NULL. It's more intuitive w/o the
vestigial argument.

Fixed a proto_tree_add_item_format-related bug in packet-isis-hello.c
Fixed a variable usage bug in packet-v120.c. (ett_* was used instead of hf_*)

Checked in Guy's fix for the function declearation for proto_tree_add_text()
and proto_tree_add_notext().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1713 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIn the TCP stream following code, we don't use the time stamp field in
guy [Sun, 12 Mar 2000 04:26:35 +0000 (04:26 +0000)]
In the TCP stream following code, we don't use the time stamp field in
the stuff we write to the temporary file, so don't bother writing it.

Keep track of the two sides of the TCP stream by keeping track of the
source address *and* port, so that we correctly handle connections
between two ports on the same machine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1712 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMaking the "frame_data" structure for a frame the data associated with
guy [Sun, 12 Mar 2000 03:13:58 +0000 (03:13 +0000)]
Making the "frame_data" structure for a frame the data associated with
the row for that frame, and using that to get the frame for the selected
row in "select_packet()", revives the crash caused by the GtkCList
selecting the first row added to the list as it's added, i.e. before we
get a chance to set the data for that row, in this case.

Introduce a workaround for this instance of that crash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1711 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix some typos.
guy [Fri, 10 Mar 2000 08:57:05 +0000 (08:57 +0000)]
Fix some typos.

Get rid of the paragraph about C++-style comments at the beginning of
the document, as it also appears in section 1.1.1 "Comments".

Add a section on how to extract data from packets, which explains the
"pd" and "offset" arguments to a dissector, and notes that you should
not just blithely cast pointers into the packet data to 2-byte or 4-byte
integral types and dereference them, as the pointer may not be aligned,
and the field may not have the same byte order as the processor on which
Ethereal is running (in fact, it's probably *guaranteed* not to on at
least one machine, as Ethereal runs on both big-endian and little-endian
platforms...).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1710 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago "ulong" is not a system-declared data type on all platforms;
guy [Fri, 10 Mar 2000 08:41:02 +0000 (08:41 +0000)]
"ulong" is not a system-declared data type on all platforms;

casting an arbitrary pointer into a frame to point to something
longer than 1 byte, and dereferencing it, is dangerous, as
there's no guarantee that said pointer is properly aligned on
machines that require alignment;

the data in an RSVP packet is presumably big-endian in any case,
so you should use "pntohl()" to access it, rather than just
blithely dereferencing it;

so use "pntohl()" to extract fields from an RSVP packet rather than
casting pointers to "ulong *" and dereferencing them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1709 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- Jeff Foster's documentation for conversations and coding style
oabad [Thu, 9 Mar 2000 19:32:31 +0000 (19:32 +0000)]
- Jeff Foster's documentation for conversations and coding style
- Documentation for plugins.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1708 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSupport for MultiProtocol Label Switching (MPLS). The following support
ashokn [Thu, 9 Mar 2000 18:31:51 +0000 (18:31 +0000)]
Support for MultiProtocol Label Switching (MPLS). The following support
is being added

- MPLS Traffic Engineering extensions for RSVP
- MPLS-encapsulated IP packets on Ethernet
- OSPF Extensions for MPLS (including generic opaque LSA
  support for OSPF)

THe following features will be committed at a later date (if I get around
to writing them :-)

- Label Distribution Protocol (LDP)
- IS-IS Extensions for MPLS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1707 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNew dissector functions for mount DUMP and EXPORT replies.
girlich [Thu, 9 Mar 2000 12:13:20 +0000 (12:13 +0000)]
New dissector functions for mount DUMP and EXPORT replies.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1706 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNew generic function dissect_rpc_list() for variable length RPC lists.
girlich [Thu, 9 Mar 2000 12:09:53 +0000 (12:09 +0000)]
New generic function dissect_rpc_list() for variable length RPC lists.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1705 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPrototype for new dissect_rpc_list() function.
girlich [Thu, 9 Mar 2000 12:05:32 +0000 (12:05 +0000)]
Prototype for new dissect_rpc_list() function.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1704 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWe already set the foreground and background color for every frame,
guy [Wed, 8 Mar 2000 06:48:01 +0000 (06:48 +0000)]
We already set the foreground and background color for every frame,
which means we're already doing a "do something to the last row in the
packet list" operation on every frame we add to the list, so adding a
call to "gtk_clist_set_row_data()" won't make matters worse.

In addition, we already set one column in a row on a "change time
format" operation, so finding the row for a frame by calling
"gtk_clist_find_row_from_data()" doesn't turn a constant-time operation
into a linear-time operation, it just cranks the proportionality
constant up - it was quadratic before, alas, and it's still quadratic.

Adding calls to "gtk_clist_find_row_from_data()" to the "Find Frame" and
"Go To Frame" code does add an extra linear operation there, but those
operations shouldn't be common - and "Go To Frame", going to the last
frame on an ~100,000-frame big capture file, was quick, at least on my
450 MHz Pentium II machine, so maybe it won't be too bad.

And "select_packet()" either has to search the frame table for the frame
with the specified row number, or has to call "gtk_clist_get_row_data()"
to do that - the first is linear in the position of the frame in the
frame table, and the latter is linear in its position in the CList, and
the latter is less than or equal to the former, so the only thing making
it worse would be a change in the proportionality constant.

So it probably won't hurt performance by much.

Furthermore, if we add the ability to sort the display on an arbitrary
column, or to delete frames from the display - both of which are in the
wish list - storing the row number of the frame in the "frame_data"
structure won't necessarily work, as the row number can change out from
under us.

Therefore, reinstate the old way of doing things, where we associate
with each row a pointer to the "frame_data" structure for the row, using
"gtk_clist_set_row_data()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1703 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNote that the "-T" flag doesn't cause "editcap" to translate link-layer
guy [Tue, 7 Mar 2000 23:50:32 +0000 (23:50 +0000)]
Note that the "-T" flag doesn't cause "editcap" to translate link-layer
headers, it just causes it to force the encapsulation type of the output
file to the specified type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1702 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix some "proto_tree_add_text()" calls.
guy [Tue, 7 Mar 2000 06:32:37 +0000 (06:32 +0000)]
Fix some "proto_tree_add_text()" calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1701 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake "name_length" and "value_length" universally "int"s - the values
guy [Tue, 7 Mar 2000 06:28:47 +0000 (06:28 +0000)]
Make "name_length" and "value_length" universally "int"s - the values
they get from the packets are 16-bit unsigned quantities, which fit
comfortable within an "int" on all platforms we support.  That
eliminates the some additional format/argument mismatches.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1700 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix some "proto_tree_add_text()" calls.
guy [Tue, 7 Mar 2000 05:57:13 +0000 (05:57 +0000)]
Fix some "proto_tree_add_text()" calls.

Use "proto_tree_add_notext()" and "proto_tree_set_text()" for some
resource records.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1699 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDeclare "proto_item_set_text()" in such a fashion as to make GCC 2.x and
guy [Tue, 7 Mar 2000 05:54:52 +0000 (05:54 +0000)]
Declare "proto_item_set_text()" in such a fashion as to make GCC 2.x and
later check the format string against the arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1698 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix some "proto_tree_add_text()" calls.
guy [Tue, 7 Mar 2000 05:30:37 +0000 (05:30 +0000)]
Fix some "proto_tree_add_text()" calls.

Reorganize "icqv5_cmd_send_text_code()" a bit so that it only puts an
item into the tree if it's present in the packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1697 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix some "proto_tree_add_text()" calls.
guy [Tue, 7 Mar 2000 05:28:39 +0000 (05:28 +0000)]
Fix some "proto_tree_add_text()" calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1696 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix some "proto_tree_add_text()" calls.
guy [Mon, 6 Mar 2000 20:04:53 +0000 (20:04 +0000)]
Fix some "proto_tree_add_text()" calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1695 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCorrectly dissect integer values, using the correct offset.
guy [Mon, 6 Mar 2000 19:53:44 +0000 (19:53 +0000)]
Correctly dissect integer values, using the correct offset.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1694 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a call to "proto_tree_add_text()", and declare "name_length" in such
guy [Mon, 6 Mar 2000 19:41:06 +0000 (19:41 +0000)]
Fix a call to "proto_tree_add_text()", and declare "name_length" in such
a fashion as not to cause GCC to whine about format/argument mismatches
if "proto.h" is tweaked to declare "proto_tree_add_text()" with an
"__attribute__((format (printf, ...))" clause.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1693 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix for reading toshiba trace files that were created by using the
gram [Sat, 4 Mar 2000 14:22:29 +0000 (14:22 +0000)]
Fix for reading toshiba trace files that were created by using the
"save session" feature in many Windows-based telnet apps. CRT, by VanDyke,
in particular, will put in newlines at 80 columns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1692 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd config.nmake and two Makefile.nmake's to the list of deliverables.
gram [Fri, 3 Mar 2000 12:01:22 +0000 (12:01 +0000)]
Add config.nmake and two Makefile.nmake's to the list of deliverables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1690 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a typo.
guy [Fri, 3 Mar 2000 07:06:13 +0000 (07:06 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1689 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDocument "proto_tree_add_notext()", "proto_item_set_len()", and
guy [Fri, 3 Mar 2000 06:58:28 +0000 (06:58 +0000)]
Document "proto_tree_add_notext()", "proto_item_set_len()", and
"proto_item_set_text()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1688 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPut in a discussion of "check_col()", "col_add_[f]str()", and
guy [Fri, 3 Mar 2000 06:39:10 +0000 (06:39 +0000)]
Put in a discussion of "check_col()", "col_add_[f]str()", and
"col_append_[f]str()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1687 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe developer's README now includes the stuff in Gilbert's "proto_tree"
guy [Fri, 3 Mar 2000 06:20:49 +0000 (06:20 +0000)]
The developer's README now includes the stuff in Gilbert's "proto_tree"
document.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1686 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPut in a note on updating "Makefile.am" and "Makefile.nmake".
guy [Fri, 3 Mar 2000 06:19:50 +0000 (06:19 +0000)]
Put in a note on updating "Makefile.am" and "Makefile.nmake".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1685 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMerge in Gilbert's "proto_tree" document.
guy [Fri, 3 Mar 2000 06:13:23 +0000 (06:13 +0000)]
Merge in Gilbert's "proto_tree" document.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1684 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAssorted fixes to the news items.
guy [Fri, 3 Mar 2000 05:40:15 +0000 (05:40 +0000)]
Assorted fixes to the news items.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1683 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove to version 0.8.4.
gram [Fri, 3 Mar 2000 03:53:08 +0000 (03:53 +0000)]
Move to version 0.8.4.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1682 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGCC doesn't mind
guy [Thu, 2 Mar 2000 08:59:36 +0000 (08:59 +0000)]
GCC doesn't mind

switch (xxx) {

...

default:
}

but Microsoft Visual C++ 6.0 insists that there be a statement following
the "default:" label, and other compilers may do the same - put in a
"break;" statement.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1681 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNote that C++-style comments shouldn't be used in dissectors.
guy [Thu, 2 Mar 2000 07:47:20 +0000 (07:47 +0000)]
Note that C++-style comments shouldn't be used in dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1680 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of C++-style comments, as they peeve some C compilers.
guy [Thu, 2 Mar 2000 07:38:02 +0000 (07:38 +0000)]
Get rid of C++-style comments, as they peeve some C compilers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1679 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoOops, forgot to include "packet-h1.h".
guy [Thu, 2 Mar 2000 07:27:56 +0000 (07:27 +0000)]
Oops, forgot to include "packet-h1.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1678 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGerrit Gehnen's dissector for the Sinec H1 protocol (Siemens Industrial
guy [Thu, 2 Mar 2000 07:27:05 +0000 (07:27 +0000)]
Gerrit Gehnen's dissector for the Sinec H1 protocol (Siemens Industrial
Ethernet; used for communication with Siemens S5 PLC's over Ethernet),
and his changes to display OSI COTP TSAPs that consist solely of
printable characters as text rather than as hex data and to decode the
version number resource in COTP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1677 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse GtkScrolledWindows to add scrollbars to the hex/ASCII panes and to
guy [Thu, 2 Mar 2000 07:05:57 +0000 (07:05 +0000)]
Use GtkScrolledWindows to add scrollbars to the hex/ASCII panes and to
the "Follow TCP Stream" displays; that means we can use the same GTK+
calls to set the scrollbar placement on them that is used to set it on
other widgets.

Keep a list of all the GtkScrolledWindows whose scrollbar placement we
control with the GUI preference item for that, and change them all when
the GUI preference item is changed (which means that the GUI preference
item now applies to the "Follow TCP Stream" window as well as to the
hex/ASCII panes).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1676 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe frame header in HP-UX 11 trace files is 4 octets longer (than HP-UX 9
oabad [Wed, 1 Mar 2000 10:25:14 +0000 (10:25 +0000)]
The frame header in HP-UX 11 trace files is 4 octets longer (than HP-UX 9
and 10 files). Add OS version detection to handle this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1675 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMerge in some information from Jeff Foster's developer's notes.
guy [Wed, 1 Mar 2000 08:05:49 +0000 (08:05 +0000)]
Merge in some information from Jeff Foster's developer's notes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1674 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoJames Coe's developer HOWTO.
guy [Wed, 1 Mar 2000 07:48:03 +0000 (07:48 +0000)]
James Coe's developer HOWTO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1673 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse the "destroy" signal on a packet popup window to find out when to
guy [Wed, 1 Mar 2000 06:50:18 +0000 (06:50 +0000)]
Use the "destroy" signal on a packet popup window to find out when to
destroy the data structure for that window, rather than doing so when
the "tree-unselect-row" signal catcher is unhooked from the tree view.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1672 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd "packet-dhis.obj" to the list of things to compile.
guy [Tue, 29 Feb 2000 09:00:36 +0000 (09:00 +0000)]
Add "packet-dhis.obj" to the list of things to compile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1671 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoJeff Foster's changes, with my additions, to allow the user to pop up a
guy [Tue, 29 Feb 2000 06:24:41 +0000 (06:24 +0000)]
Jeff Foster's changes, with my additions, to allow the user to pop up a
window showing the protocol tree and hex/ASCII data for the currently
selected packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1670 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFred Reimer's patch to put the TCP segment length in the TCP packet
guy [Mon, 28 Feb 2000 08:17:39 +0000 (08:17 +0000)]
Fred Reimer's patch to put the TCP segment length in the TCP packet
summary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1669 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd an RCS Id.
oabad [Wed, 23 Feb 2000 22:41:15 +0000 (22:41 +0000)]
Add an RCS Id.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1668 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNew dissector for DHIS (Dynamic Host Information Services) protocol.
oabad [Wed, 23 Feb 2000 22:28:50 +0000 (22:28 +0000)]
New dissector for DHIS (Dynamic Host Information Services) protocol.
This protocol is UDP based and uses ports 58800 and 58801.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1667 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"http_tree" doesn't need to be static; make it local to
guy [Wed, 23 Feb 2000 20:55:33 +0000 (20:55 +0000)]
"http_tree" doesn't need to be static; make it local to
"dissect_http()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1666 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix HTTP request & response.
deniel [Wed, 23 Feb 2000 19:47:14 +0000 (19:47 +0000)]
Fix HTTP request & response.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1665 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake "reinit_x25_hashtable()" static (it's not explicitly called from
guy [Tue, 22 Feb 2000 07:42:50 +0000 (07:42 +0000)]
Make "reinit_x25_hashtable()" static (it's not explicitly called from
outside "packet-x25.c", it's only registered as a protocol init
routine), and explicitly declare it as taking no arguments (GCC doesn't
complain about passing a pointer to a routine with an unspecified
argument list to "register_init_routine()", which expects a pointer to a
routine with no arguments, but Microsoft Visual C{++} 6.0 does complain
about it).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1664 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIn Tethereal, allow capture filters and read filters either to be
guy [Tue, 22 Feb 2000 07:07:55 +0000 (07:07 +0000)]
In Tethereal, allow capture filters and read filters either to be
specifies with "-f" and "-R" flags, respectively, or specified with
non-flag command-line arguments, as tcpdump and snoop allow.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1663 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSmall fix for Jeff Foster
sharpe [Mon, 21 Feb 2000 23:50:15 +0000 (23:50 +0000)]
Small fix for Jeff Foster

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1662 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFixing the GetDC response handling so it understands the short ones that
sharpe [Mon, 21 Feb 2000 23:40:33 +0000 (23:40 +0000)]
Fixing the GetDC response handling so it understands the short ones that
are sent in response to Win9X requests as well as the longer ones that
are sent to WinNT and above requests.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1661 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a bunch of notes from various "comp.sys.hp.hpux" threads about
guy [Mon, 21 Feb 2000 20:41:01 +0000 (20:41 +0000)]
Add a bunch of notes from various "comp.sys.hp.hpux" threads about
tweaking HP-UX so that DLPI (and thus Ethereal/Tethereal and tcpdump)
can see, when capturing on a given machine, packets sent by that
machine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1660 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't use a fixed-size line buffer for summary lines in the print code;
guy [Mon, 21 Feb 2000 08:18:00 +0000 (08:18 +0000)]
Don't use a fixed-size line buffer for summary lines in the print code;
mallocate the buffer and grow it as necessary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1659 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd "Resolve Name" item in detailed tree popup.
deniel [Sun, 20 Feb 2000 14:52:28 +0000 (14:52 +0000)]
Add "Resolve Name" item in detailed tree popup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1658 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUCD SNMP 4.1[.x] makes "snmp_set_full_objid()" a macro that calls
guy [Sun, 20 Feb 2000 03:32:29 +0000 (03:32 +0000)]
UCD SNMP 4.1[.x] makes "snmp_set_full_objid()" a macro that calls
"ds_set_boolean()" with the first two arguments being DS_LIBRARY_ID and
DS_LIB_PRINT_FULL_OID; this means that, when building with 4.1[.x]
(which we assume is the case if "snmp_set_full_objid" is defined, we
need to include <ucd-snmp/default_store.h>, to define those two values
and to declare "ds_set_boolean()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1657 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGive it an RCS ID.
guy [Sat, 19 Feb 2000 22:01:26 +0000 (22:01 +0000)]
Give it an RCS ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1656 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGive some README.<os> files RCS IDs; the other ones already have them.
guy [Sat, 19 Feb 2000 22:00:25 +0000 (22:00 +0000)]
Give some README.<os> files RCS IDs; the other ones already have them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1655 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd an RCS ID.
guy [Sat, 19 Feb 2000 21:58:39 +0000 (21:58 +0000)]
Add an RCS ID.

Note that the configure-script changes to make GLib buildable on AIX are
in GLib 1.2.7.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1654 f5534014-38df-0310-8fa8-9805f1628bb7