obnox/wireshark/wip.git
18 years agoAdd value for FCS (no decoding).
jmayer [Tue, 12 Jul 2005 17:06:09 +0000 (17:06 +0000)]
Add value for FCS (no decoding).
Fix a signedness warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14905 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRemove/replace SPACES at the beginning of Makefile.am/Makefile.common
jmayer [Tue, 12 Jul 2005 12:44:42 +0000 (12:44 +0000)]
Remove/replace SPACES at the beginning of Makefile.am/Makefile.common
files as not all make implementation work with this.

Found by running
grep '^ ' `find . -name "Makefile.am" -o -name "Makefile.common"`

Gerald: Maybe adding this to the buildbot would be a good idea after all.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14904 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix some more signed vs. unsigned warnings.
guy [Tue, 12 Jul 2005 01:01:19 +0000 (01:01 +0000)]
Fix some more signed vs. unsigned warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14903 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIn NTLMSP_AUTH messages, include the domain name and user name in the
guy [Mon, 11 Jul 2005 22:48:51 +0000 (22:48 +0000)]
In NTLMSP_AUTH messages, include the domain name and user name in the
Info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14902 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd Jeremy j Ouellette
etxrab [Mon, 11 Jul 2005 22:27:20 +0000 (22:27 +0000)]
Add Jeremy j Ouellette

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14901 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDIS dissection
etxrab [Mon, 11 Jul 2005 22:23:57 +0000 (22:23 +0000)]
DIS dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14900 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Jeremy j Ouellette:
etxrab [Mon, 11 Jul 2005 22:23:15 +0000 (22:23 +0000)]
From Jeremy j Ouellette:
DIS dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14899 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix a syntax error in the "Routing" rule, reported by Jeff Morriss
ulfl [Mon, 11 Jul 2005 20:14:43 +0000 (20:14 +0000)]
fix a syntax error in the "Routing" rule, reported by Jeff Morriss

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14898 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDissect some more fields
etxrab [Mon, 11 Jul 2005 19:25:25 +0000 (19:25 +0000)]
Dissect some more fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14897 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDissect some more fields
etxrab [Mon, 11 Jul 2005 19:24:30 +0000 (19:24 +0000)]
Dissect some more fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14896 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoJust pass &cfile to select_tcpip_session(); we don't need to pass
guy [Sun, 10 Jul 2005 18:29:43 +0000 (18:29 +0000)]
Just pass &cfile to select_tcpip_session(); we don't need to pass
cfile.current_frame to it separately.

Note that we shouldn't ever get a "Selected packet isn't a TCP segment"
error any more; we can now handle all link layers.

Give a little more detail in the message shown if there's *more than
one* TCP header in the packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14895 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix some comment typos.
guy [Sun, 10 Jul 2005 10:10:40 +0000 (10:10 +0000)]
Fix some comment typos.

Don't regenerate the packet list when generating the TCP stream graph -
it won't be changing; just redissect and run the tap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14894 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPut the data (print job contents) in LPD requests under the LPD protocol
guy [Sun, 10 Jul 2005 09:26:20 +0000 (09:26 +0000)]
Put the data (print job contents) in LPD requests under the LPD protocol
item, rather than making it a top-level item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14893 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of an unused argument.
guy [Sun, 10 Jul 2005 09:21:57 +0000 (09:21 +0000)]
Get rid of an unused argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14892 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAfter doing "make maintainer-clean", "svn status --no-ignore | grep ^I"
jmayer [Sun, 10 Jul 2005 08:04:27 +0000 (08:04 +0000)]
After doing "make maintainer-clean", "svn status --no-ignore | grep ^I"
returned quite a list of files. Add them to MAINTAINERCLEANFILES.

Whitespace changes (replace multiple spaces by TABs, in a few cases this
needed to be done at the beginning of Makefile lines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14891 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFor packets flagged as Retransmission
sahlberg [Sun, 10 Jul 2005 05:27:38 +0000 (05:27 +0000)]
For packets flagged as Retransmission

calculate RTO as the delta between the retransmitted frame and the last previous frame seen for this session (in the same direction).

while this is technically not the RTO  this delta is in most cases more important/useful than the tru RTO anyway since this measure represents the amount of thiime that the link went idle  while waiting for an RTO.

It would be nice with a statistics tap for TCP where one couls see, seeion by session :
Length in time of the session.
Total bytes transferred
Number of retransmissions
Time spent waiting for an RTO
Time spent waiting for an RTO in % of the total time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14890 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIt works reasonably well with extensive testing so here goes :
sahlberg [Sun, 10 Jul 2005 02:59:50 +0000 (02:59 +0000)]
It works reasonably well with extensive testing so here goes :

tcp-graph has been modified to extract tcp data from a TAP instead of reading and parsing directly from the capture file.

This makes tcp graph work for any type of capture and for any transport.

In the future someone with access to captures with TCP over something over TCP
to add a dialog where the user can specify WHICH of the multiple TCP sessions to graph.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14889 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMSVC: fix some guint64 related compiler errors
ulfl [Sat, 9 Jul 2005 11:28:13 +0000 (11:28 +0000)]
MSVC: fix some guint64 related compiler errors

strange enough, MSVC cannot convert from guint64 to float, so cast guint64 -> gint64 -> float

However, even gint64 might be big enough to prevent us from an overflow :-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14888 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMSVC: fix some guint64 related compiler warnings, could someone please review my...
ulfl [Sat, 9 Jul 2005 11:26:46 +0000 (11:26 +0000)]
MSVC: fix some guint64 related compiler warnings, could someone please review my comment(s), I don't think it's currently implemented correct

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14887 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake a bunch of items in encryption code arrays of guint8, and make some
guy [Sat, 9 Jul 2005 03:25:25 +0000 (03:25 +0000)]
Make a bunch of items in encryption code arrays of guint8, and make some
pointers either "void *" or "guint8 *", to reduce the level of compiler
warnings (the data in question is largely binary in those cases).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14886 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix up a bunch of arguments to "dissect_ber_identifier()" to match its
guy [Sat, 9 Jul 2005 02:58:07 +0000 (02:58 +0000)]
Fix up a bunch of arguments to "dissect_ber_identifier()" to match its
current signature ("class" is a "gint8 *", not a "guint8 *", and "tag"
is a "gint32 *", not a "guint32 *").  Re-generate the dissectors from
the ASN.1 and the .cnf files in the cases where the arguments were fixed
in a .cnf file.

Give some dissectors the right svn:keywords and svn:eol-style settings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14885 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSquelch various signed vs. unsigned warnings by:
guy [Sat, 9 Jul 2005 00:53:17 +0000 (00:53 +0000)]
Squelch various signed vs. unsigned warnings by:

making pointers to byte data be "guint8 *" rather than "char *",
and making buffers holding byte data arrays of "guint8" rather
than arrays of "char";

making pointers to text strings "char *" rather than "guchar *";

appropriately casting pointers (cast to "guint8 *" when passing
to routines expecting "guint8 *" or when assigning to "guint8
*");

making port-number preferences "guint";

making enum preferences "gint";

making hf_ variables "int".

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14884 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMAC addresses are arrays of bytes, not strings; make the destination MAC
guy [Sat, 9 Jul 2005 00:47:57 +0000 (00:47 +0000)]
MAC addresses are arrays of bytes, not strings; make the destination MAC
address an array of guint8 - that squelches some compiler warnings.

Use -1 rather than tvb_length(tvb) to make the item for LWAPP go to the
end of the tvbuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14883 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFind the BitTorrent dissector immediately after registering it, and save
guy [Sat, 9 Jul 2005 00:44:44 +0000 (00:44 +0000)]
Find the BitTorrent dissector immediately after registering it, and save
the handle, rather than finding it every time we need it.

Just make a guint8 array with the BitTorrent magic string length
followed by the string, and use "tvb_memeql()" to test against that - it
handles checking to make sure there's enough data in the tvbuff (if
not, it returns -1 as a "no match" indication) and then checks all of
the first 20 bytes in one operation.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14882 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUse "tvb_get_string()" rather than duplicating its functionality by
guy [Sat, 9 Jul 2005 00:35:13 +0000 (00:35 +0000)]
Use "tvb_get_string()" rather than duplicating its functionality by
hand.

Use "g_strdup()" rather than duplicating its functionality by hand.

Make the magic number an array of "guint8", as "tvb_memeql()" expects a
pointer to "guint8".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14881 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agochecksum messages: use "[correct]" instead of "(correct)" and other "alike" messages
ulfl [Fri, 8 Jul 2005 22:11:13 +0000 (22:11 +0000)]
checksum messages: use "[correct]" instead of "(correct)" and other "alike" messages

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14880 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate the EDG screenshots to reflect the latest Ethereal GUI changes
ulfl [Fri, 8 Jul 2005 22:04:35 +0000 (22:04 +0000)]
Update the EDG screenshots to reflect the latest Ethereal GUI changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14879 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some missing IMPLICIT tags, and use FN_PARS directive.
etxrab [Fri, 8 Jul 2005 20:01:11 +0000 (20:01 +0000)]
Add some missing IMPLICIT tags, and use FN_PARS directive.

Add disection of some RR elements and command Handover.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14878 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some missing IMPLICIT tags, and use FN_PARS directive.
etxrab [Fri, 8 Jul 2005 19:59:56 +0000 (19:59 +0000)]
Add some missing IMPLICIT tags, and use FN_PARS directive.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14877 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a crash reported by Jeff Morris.
tuexen [Fri, 8 Jul 2005 11:47:59 +0000 (11:47 +0000)]
Fix a crash reported by Jeff Morris.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14876 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake the counters in the summary 64-bit, so they don't overflow on
guy [Fri, 8 Jul 2005 09:12:11 +0000 (09:12 +0000)]
Make the counters in the summary 64-bit, so they don't overflow on
Really Big Captures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14875 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of most unused arguments and variables (including some that are
guy [Fri, 8 Jul 2005 02:31:45 +0000 (02:31 +0000)]
Get rid of most unused arguments and variables (including some that are
set but not used).  (Leave "pi" around so the warning acts as a reminder
that the tap structure stuff needs a cleanup - currently, the tap
structures aren't freed; perhaps the new memory allocation scheme
proposed by Ronnie could be used for tap structures.)

Have "ac_istrace()" return NOT_ACTRACE for apparently non-actrace
packets and return the packet type for actrace packets, so that we don't
need a global variable for the packet type.

Make "actrace_udp_port" unsigned to squelch a signed vs. unsigned
warning.

Use "col_set_str()" rather than "col_add_str()" when setting the
Protocol column.

We don't recognized packets as CAS packets unless they're 48 bytes long,
so we don't need to test whether they're 48 bytes long in the CAS packet
dissection code.

Use the reported length, not the captured length, when doing length
checks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14874 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake nettl file header items containing strings "gchar", to squelch
guy [Fri, 8 Jul 2005 02:21:16 +0000 (02:21 +0000)]
Make nettl file header items containing strings "gchar", to squelch
signed vs. unsigned compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14873 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomake the packets/bytes counters 64bit integers to not wrap when using really large...
sahlberg [Thu, 7 Jul 2005 22:24:28 +0000 (22:24 +0000)]
make the packets/bytes counters 64bit integers to not wrap when using really large captures.

setting packet counter to 64bit is overkill but makes it consistent with the very similar bytes counter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14872 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake sure "which" is present before we verify our tools. Add "env" to
gerald [Thu, 7 Jul 2005 21:26:09 +0000 (21:26 +0000)]
Make sure "which" is present before we verify our tools.  Add "env" to
the list of programs to check.  Make sure our python scripts start with
"#!/usr/bin/env python" as recommended at

  http://www.python.org/doc/faq/library.html#how-do-i-make-a-python-script-executable-on-unix

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14871 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd parlay.dll and tango.dll to the installer.
etxrab [Thu, 7 Jul 2005 19:48:06 +0000 (19:48 +0000)]
Add parlay.dll and tango.dll to the installer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14870 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoavoid few warnings from asn2eth compiler
kukosa [Thu, 7 Jul 2005 05:45:51 +0000 (05:45 +0000)]
avoid few warnings from asn2eth compiler

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14869 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSquelch a compiler pointer vs. integer warning - NULL is for pointers,
guy [Thu, 7 Jul 2005 04:05:01 +0000 (04:05 +0000)]
Squelch a compiler pointer vs.  integer warning - NULL is for pointers,
'\0' is for characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14868 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness"
guy [Thu, 7 Jul 2005 04:03:35 +0000 (04:03 +0000)]
Add a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness"
warnings.  Use SET_ADDRESS in the VOIP calls code, rather than
explicitly filling in "pstn_add".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14867 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoExplicitly initialize all the elements of a voip_calls_tapinfo_t, to
guy [Thu, 7 Jul 2005 03:20:43 +0000 (03:20 +0000)]
Explicitly initialize all the elements of a voip_calls_tapinfo_t, to
squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14866 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a spelling error.
guy [Wed, 6 Jul 2005 23:55:19 +0000 (23:55 +0000)]
Fix a spelling error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14865 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomore usage of #.FN_PARS directive and usage of DEFAULT_BODY parameter
kukosa [Wed, 6 Jul 2005 16:19:34 +0000 (16:19 +0000)]
more usage of #.FN_PARS directive and usage of DEFAULT_BODY parameter

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14864 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago- #.FN_PARS implemented for BOOLEAN
kukosa [Wed, 6 Jul 2005 16:15:12 +0000 (16:15 +0000)]
- #.FN_PARS implemented for BOOLEAN
- user defined body #.FN_BODY can be combined with default body using DEFAULT_BODY parameter (see e.g. H.225)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14863 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoReplace Chris Lydick by Robert Long as Author of the Sniffer 2.003 support patch
jmayer [Tue, 5 Jul 2005 22:58:00 +0000 (22:58 +0000)]
Replace Chris Lydick by Robert Long as Author of the Sniffer 2.003 support patch

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14862 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix *several* dissector bugs, found by private fuzz-tests
ulfl [Tue, 5 Jul 2005 22:33:22 +0000 (22:33 +0000)]
fix *several* dissector bugs, found by private fuzz-tests

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14861 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agonew directives #.PDU_NEW and #.REGISTER_NEW creating and registering PDU dissectors...
kukosa [Tue, 5 Jul 2005 21:42:13 +0000 (21:42 +0000)]
new directives #.PDU_NEW and #.REGISTER_NEW creating and registering PDU dissectors with new_dissector_t prototype

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14860 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall proto_tree_add_guid_hidden() for an FT_GUID value. Fixes bugs 274,
gerald [Tue, 5 Jul 2005 20:20:15 +0000 (20:20 +0000)]
Call proto_tree_add_guid_hidden() for an FT_GUID value.  Fixes bugs 274,
276, and 277.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14859 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDon't crash if we're handed a zero-length fragment. Fixes bug 272. Although
gerald [Tue, 5 Jul 2005 20:04:03 +0000 (20:04 +0000)]
Don't crash if we're handed a zero-length fragment.  Fixes bug 272.  Although
we don't crash now, we still don't handle zero-length fragments correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14858 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomore usage of #.FN_PARS
kukosa [Tue, 5 Jul 2005 19:53:38 +0000 (19:53 +0000)]
more usage of #.FN_PARS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14857 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago- #.FN_PARS support for ENUMERATED type
kukosa [Tue, 5 Jul 2005 19:47:04 +0000 (19:47 +0000)]
- #.FN_PARS support for ENUMERATED type
- cleanup unused parameters for some methods

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14856 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGUID lowercase form seems to be preferred
kukosa [Tue, 5 Jul 2005 18:55:17 +0000 (18:55 +0000)]
GUID lowercase form seems to be preferred

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14855 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd application/vnd.wv.csp.xml
etxrab [Tue, 5 Jul 2005 17:10:09 +0000 (17:10 +0000)]
Add application/vnd.wv.csp.xml

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14854 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd application/vnd.wv.csp.xml
etxrab [Tue, 5 Jul 2005 17:09:28 +0000 (17:09 +0000)]
Add application/vnd.wv.csp.xml

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14853 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Alejandro Vaquero
etxrab [Tue, 5 Jul 2005 05:16:28 +0000 (05:16 +0000)]
From Alejandro Vaquero

- avoid the clist of the calls dlg to be refreshed multiple times when
first appear.
- destroy the Graph window when the data is not valid anymore.
- fixes an H245 packet count error
- resizing the Graph windows when is displayed (up to 5 columns).
With a change to leave static voip_calls_tapinfo_t the_tapinfo_struct =
{0, NULL, 0, NULL, 0, 0, 0, 0, NULL, 0, 0, 0, 0, 0, 0, 0, 0, 0};
alone.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14852 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom : David Frascone
etxrab [Tue, 5 Jul 2005 04:32:32 +0000 (04:32 +0000)]
From : David Frascone

These minor changes fix some errors, and add some messages to the LWAPP dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14851 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Ainsley Pereira:
etxrab [Tue, 5 Jul 2005 04:30:59 +0000 (04:30 +0000)]
From Ainsley Pereira:

If you have an RTP stream in which the first packet is duplicated, and has the marker bit set, then the RTP stream analysis will try to pad silence into a temporary file from 0 upto whatever the RTP timestamp is (which is enough to fill up my disk...). The  patch fixes this misbehaviour.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14850 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.
etxrab [Mon, 4 Jul 2005 19:09:38 +0000 (19:09 +0000)]
Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14849 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.
etxrab [Mon, 4 Jul 2005 19:07:02 +0000 (19:07 +0000)]
Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14848 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agousage of FT_GUID field type in H.225 dissector
kukosa [Mon, 4 Jul 2005 13:19:58 +0000 (13:19 +0000)]
usage of FT_GUID field type in H.225 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14847 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoexport of proto_tree_add_guid...() functions
kukosa [Mon, 4 Jul 2005 13:13:07 +0000 (13:13 +0000)]
export of proto_tree_add_guid...() functions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14846 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agonew field type FT_GUID
kukosa [Mon, 4 Jul 2005 13:04:53 +0000 (13:04 +0000)]
new field type FT_GUID

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14845 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago- use tvb instead of offset and length in dissect_per_octet_string() for value returning
kukosa [Mon, 4 Jul 2005 09:35:25 +0000 (09:35 +0000)]
- use tvb instead of offset and length in dissect_per_octet_string() for value returning
- asn2eth: #.FN_PARS support for OCTET STRING
- usage of #.FN_PARS in h225 and h245
- h225: ParallelH245Control support
- h245: better support of NonStandardParameter
- usage of MAX_OID_STR_LEN constant
- all PER dissectors regenerated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14844 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd a link to special documentation
ulfl [Mon, 4 Jul 2005 07:03:04 +0000 (07:03 +0000)]
add a link to special documentation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14843 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMark stub data as such if no dissector claims it.
guy [Mon, 4 Jul 2005 03:45:29 +0000 (03:45 +0000)]
Mark stub data as such if no dissector claims it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14842 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofrom Jaap Keuter: some improvements to the custom PDF creation stylesheet
ulfl [Sun, 3 Jul 2005 22:53:11 +0000 (22:53 +0000)]
from Jaap Keuter: some improvements to the custom PDF creation stylesheet

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14841 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd an exported value string
etxrab [Sun, 3 Jul 2005 21:20:27 +0000 (21:20 +0000)]
Add an exported value string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14840 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd an exported value string
etxrab [Sun, 3 Jul 2005 21:19:49 +0000 (21:19 +0000)]
Add an exported value string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14839 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoChange gsm_a.c to use value strings in some places in preparation to use it from...
etxrab [Sun, 3 Jul 2005 20:33:06 +0000 (20:33 +0000)]
Change gsm_a.c to use value strings in some places in preparation to use it from packet-uma.c and gsm_map.
Some bug fixes to packet-uma.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14838 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd packet-mms.h
etxrab [Sun, 3 Jul 2005 12:01:11 +0000 (12:01 +0000)]
Add packet-mms.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14837 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNew protocol :
sahlberg [Sun, 3 Jul 2005 06:08:53 +0000 (06:08 +0000)]
New protocol :
MMS    Manufacturing Message Specification

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14836 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoexport a few more symbols from acse
sahlberg [Sun, 3 Jul 2005 05:28:12 +0000 (05:28 +0000)]
export a few more symbols from acse

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14835 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNote that the MPLS extension dissector will misdissect ICMP packets that
guy [Sun, 3 Jul 2005 00:52:08 +0000 (00:52 +0000)]
Note that the MPLS extension dissector will misdissect ICMP packets that
contain more than 128 bytes of the original datagram.  (Yes, RFC 1812
and the ICMP Extensions for MPLS draft collide here, as the draft in
question notes.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14834 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUse brackets instead of parentheses for the checksum info, which is generated.
tuexen [Sat, 2 Jul 2005 21:16:17 +0000 (21:16 +0000)]
Use brackets instead of parentheses for the checksum info, which is generated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14833 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoChris Lydick: Support for Sniffer 2.003 files.
jmayer [Sat, 2 Jul 2005 15:40:49 +0000 (15:40 +0000)]
Chris Lydick: Support for Sniffer 2.003 files.

Modified to match the current codebase.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14832 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoHave separate fields for NFSv2, NFSv3, and NFSv4 return statuses, using
guy [Sat, 2 Jul 2005 08:18:17 +0000 (08:18 +0000)]
Have separate fields for NFSv2, NFSv3, and NFSv4 return statuses, using
the names in the v2, v3, and v4 specs for values, so that they display
correctly and can be filtered on correctly.

Have "nfs.status" as a hidden field, with a name table giving just "OK"
and "ERR_" values, and having items for v2, v3, and v4 status values
(the only collision is that the v3 JUKEBOX error is the v4 DELAY error),
so that filters on "nfs.status" will still work, but will now be able to
filter symbolically on values from v2, v3, and v4.

Show 33 status values in the Info column and the summary entry using the
table of v3 status values and names, not the table of v2 status values
and names.

Fix some v3 dissectors to use the v3 return status field rather than the
v2 return status field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14831 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofixed various issues (two serious ones) found by "private" fuzz-testing
ulfl [Fri, 1 Jul 2005 21:04:13 +0000 (21:04 +0000)]
fixed various issues (two serious ones) found by "private" fuzz-testing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14830 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix #271: don't do:
ulfl [Fri, 1 Jul 2005 20:47:22 +0000 (20:47 +0000)]
fix #271: don't do:

g_free(bytes);

twice, probably a copy/paste error

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14829 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agobeter displaying of true/false strings in dissect_ber_bitstring()
kukosa [Fri, 1 Jul 2005 13:48:52 +0000 (13:48 +0000)]
beter displaying of true/false strings in dissect_ber_bitstring()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14828 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd some more information to the DCE/RPC packet details summary line
ulfl [Thu, 30 Jun 2005 22:51:17 +0000 (22:51 +0000)]
add some more information to the DCE/RPC packet details summary line

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14827 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd a new DCE/RPC related column, which contains the call_id for connection oriented...
ulfl [Thu, 30 Jun 2005 22:46:19 +0000 (22:46 +0000)]
add a new DCE/RPC related column, which contains the call_id for connection oriented packets or the sequence number for connectionless (datagram) packets.

This is extremely useful, to keep track of the corresponding request/response packets of a DCE/RPC call (which can be quite a lot packets if fragmentation is used).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14826 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd Karl Knoebl as an author.
etxrab [Thu, 30 Jun 2005 19:19:50 +0000 (19:19 +0000)]
Add Karl Knoebl as an author.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14825 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Karl Knoebl
etxrab [Thu, 30 Jun 2005 19:17:46 +0000 (19:17 +0000)]
From Karl Knoebl
Accept SP as separator and * provide info to COL_INFO and some "prettification"
 Cleaned up some comments as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14824 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix a bug in the conformance file for CMIP to make it compile again
sahlberg [Thu, 30 Jun 2005 07:48:25 +0000 (07:48 +0000)]
fix a bug in the conformance file for CMIP to make it compile again
(semi-recent changes to asn2eth and PARAM handling makes us have to use double %% in some BODY statements)

at the same time, regenerate it so it also benefit from bugfixes to handling of indefinite length

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14823 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomake reading of observer files work again
sahlberg [Thu, 30 Jun 2005 02:31:15 +0000 (02:31 +0000)]
make reading of observer files work again

for some reason we have forgotten to skip the initial (always 8?) bytes prior to the start of the frame.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14822 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIf only part of an entry in an object fits in the object, don't report
guy [Wed, 29 Jun 2005 23:19:21 +0000 (23:19 +0000)]
If only part of an entry in an object fits in the object, don't report
the stuff that didn't fit as a negative number of junk bytes.

The difference between two pointers isn't guaranteed to have a
particular size; cast it to "long" and display it with "%ld".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14821 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd the usual (minimal) protection against email address harvesting.
guy [Wed, 29 Jun 2005 22:39:36 +0000 (22:39 +0000)]
Add the usual (minimal) protection against email address harvesting.

Fix one entry to have tabs between the name and the address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14820 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd fix for bug 224
sahlberg [Wed, 29 Jun 2005 11:59:42 +0000 (11:59 +0000)]
add fix for bug 224

we now put generated items as top-level items in the decode pane so
we should not check and abort if such are found.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14819 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofrom
sahlberg [Wed, 29 Jun 2005 10:39:09 +0000 (10:39 +0000)]
from
Maria-Luiza Crivat and
Brice Augustin

ICMP MPLS extensions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14818 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix a typo for the name of a bit
sahlberg [Wed, 29 Jun 2005 08:11:23 +0000 (08:11 +0000)]
fix a typo for the name of a bit

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14817 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomake dissect_CBA_Connection_Data available for plugins
ulfl [Wed, 29 Jun 2005 08:06:07 +0000 (08:06 +0000)]
make dissect_CBA_Connection_Data available for plugins

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14816 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd references to the corresponding request of datagram ping and ack packets
ulfl [Wed, 29 Jun 2005 08:03:06 +0000 (08:03 +0000)]
add references to the corresponding request of datagram ping and ack packets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14815 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agobe more careful when attempting to dissect an unknown ber field not to read beyond...
sahlberg [Wed, 29 Jun 2005 08:00:55 +0000 (08:00 +0000)]
be more careful when attempting to dissect an unknown ber field not to read beyond the end and triggering a [malformed packet]

also prettify the error when finding "unknown" entries inside a SEQUENCE to make it easier to track down what went wrong.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14814 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSquelch a compiler warning.
guy [Tue, 28 Jun 2005 22:39:56 +0000 (22:39 +0000)]
Squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14813 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMore constification.
guy [Tue, 28 Jun 2005 22:15:12 +0000 (22:15 +0000)]
More constification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14812 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"Handle" a couple of cases in the switch statement by adding them to the
guy [Tue, 28 Jun 2005 22:01:18 +0000 (22:01 +0000)]
"Handle" a couple of cases in the switch statement by adding them to the
"not supported" case, to suppress compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14811 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"mtp3_sum_draw()" is never called with a null "table" argument - the
guy [Tue, 28 Jun 2005 21:43:24 +0000 (21:43 +0000)]
"mtp3_sum_draw()" is never called with a null "table" argument - the
code before the call would have blown up if "table" were null.  Remove
the check for a null pointer; this squelches some unset-variable
warnings you get from GCC4 because its dataflow analysis runs across
function boundaries.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14810 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDeclare "decrypt_krb5_data()" for use by the KINK dissector.
guy [Tue, 28 Jun 2005 21:25:56 +0000 (21:25 +0000)]
Declare "decrypt_krb5_data()" for use by the KINK dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14809 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix to SendAuthenticationInfoRes
etxrab [Tue, 28 Jun 2005 21:14:59 +0000 (21:14 +0000)]
Fix to SendAuthenticationInfoRes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14808 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix to SendAuthenticationInfoRes.
etxrab [Tue, 28 Jun 2005 21:14:09 +0000 (21:14 +0000)]
Fix to SendAuthenticationInfoRes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14807 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRegenerated Tango with the latest idl2eth and the tango.idl
etxrab [Tue, 28 Jun 2005 19:14:14 +0000 (19:14 +0000)]
Regenerated Tango with the latest idl2eth and the tango.idl

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14806 f5534014-38df-0310-8fa8-9805f1628bb7