18 years ago"col_format_to_pref_str()" is used only in "prefs.c", and knows about
guy [Sun, 22 Jul 2001 21:56:25 +0000 (21:56 +0000)]
"col_format_to_pref_str()" is used only in "prefs.c", and knows about
the format of string lists in a preferences file; rename it to
"put_string_list()", make it take the list as an argument rather than
working only on "prefs.col_list", and put it in "prefs.c".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3776 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCheck for valid column titles (non-zero-length) and valid column formats
guy [Sun, 22 Jul 2001 21:50:47 +0000 (21:50 +0000)]
Check for valid column titles (non-zero-length) and valid column formats
in preference settings.

In the process of doing that, fix a memory leak (we were handing a null
pointer, rather than a pointer to the list of strings in
"column.format", to "clear_string_list()").

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3775 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPut in a comment noting that the format of a preferences string is
guy [Sun, 22 Jul 2001 21:28:46 +0000 (21:28 +0000)]
Put in a comment noting that the format of a preferences string is
determined by the code in "prefs.c", so arguably
"col_format_to_pref_str()" belongs there.

Put in a comment noting that said format includes support for escaping
quotation marks in quoted strings, and that we should handle that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3774 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDon't require the strings in string lists to be quoted, just allow them
guy [Sun, 22 Jul 2001 21:27:54 +0000 (21:27 +0000)]
Don't require the strings in string lists to be quoted, just allow them
to be quoted.

Correctly handle backslash-quoting in string lists.

Return an error if the "get_string_list()" indicates that
"column.format" string list is syntactically invalid or if it doesn't
contain an even number of entries.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3773 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNote that we should supply a detailed explanation of syntax errors, so
guy [Sun, 22 Jul 2001 21:25:11 +0000 (21:25 +0000)]
Note that we should supply a detailed explanation of syntax errors, so
we can say more than just that there was a "Syntax error" in the
preferences file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3772 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate from Mark Burton.
guy [Sun, 22 Jul 2001 20:02:23 +0000 (20:02 +0000)]
Update from Mark Burton.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3771 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoQuake 3 Arena added for Uwe Girlich
girlich [Sun, 22 Jul 2001 19:07:50 +0000 (19:07 +0000)]
Quake 3 Arena added for Uwe Girlich

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3770 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomisleading comment changed on the byte ordering
girlich [Sun, 22 Jul 2001 19:04:20 +0000 (19:04 +0000)]
misleading comment changed on the byte ordering

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3769 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agonew file packet-quake3.c added
girlich [Sun, 22 Jul 2001 18:56:37 +0000 (18:56 +0000)]
new file packet-quake3.c added

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3768 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFirst working version of a Quake 3 Arena dissector.
girlich [Sun, 22 Jul 2001 18:54:16 +0000 (18:54 +0000)]
First working version of a Quake 3 Arena dissector.
Many things are missing but it is a start.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3767 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoBefore calling proto_tree_add_string, the correct proto_tree should
girlich [Sun, 22 Jul 2001 18:52:38 +0000 (18:52 +0000)]
Before calling proto_tree_add_string, the correct proto_tree should
be checked and not any upper proto_tree object.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3766 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDo __attribute__ stuff if the GCC version number is greater than or
guy [Sun, 22 Jul 2001 10:25:50 +0000 (10:25 +0000)]
Do __attribute__ stuff if the GCC version number is greater than or
equal to 2, not just if it's equal to 2 - GCC 3.0 makes it 3, not 2....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3765 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd a bunch of routines used by GIOP plugins to the plugin address
guy [Sun, 22 Jul 2001 10:12:11 +0000 (10:12 +0000)]
Add a bunch of routines used by GIOP plugins to the plugin address

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3764 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNew function added to dissect a infostring. I'll use it for other games too.
girlich [Sat, 21 Jul 2001 19:25:59 +0000 (19:25 +0000)]
New function added to dissect a infostring. I'll use it for other games too.
Connectionless packets are now better splitted in command and arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3763 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThe connect request (client to server) is now much more detailed.
girlich [Sat, 21 Jul 2001 15:34:44 +0000 (15:34 +0000)]
The connect request (client to server) is now much more detailed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3762 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThere is really no need to have the BGP dissector and the LDP dissector
guy [Sat, 21 Jul 2001 10:27:13 +0000 (10:27 +0000)]
There is really no need to have the BGP dissector and the LDP dissector
have two independent "value_string" tables mapping RFC 1700 address
family numbers to names, nor is there any need to have the BGP dissector
and the PIM dissector have two independent sets of #defines for RFC 1700
address family numbers; put a single "value_string" table in "afn.c" and
put a declaration of it, and #defines for the address family numbers,
into "afn.h", and have the dissectors use that.

Move the #define for PGM into "ipproto.h", and add an entry for it in
the "value_string" table in "ipproto.c".

Have the PGM dissector use the standard Ethereal mechanisms for
resolving addresses, and have it use "value_string" tables for mapping
option types, the OPX bits, and packet types to strings.  Use
"bytes_to_str()" to turn byte arrays into strings of hex digits.  Pass
the packet type string to "dissect_pgmopts()" as an argument, rather
than making it a global.  Don't use "proto_tree_add_XXX_format" routines
if you can possibly just use "proto_tree_add_XXX"; give various fields
the correct radix and type, and VALS() strings if necessary, to make
that happen (and to make filtering on them more pleasant).  Put the
type, length, and total length of the options into the protocol tree as
separate fields.  Don't have separate type, length, and OPX fields for
every type of option; one field will suffice.  Don't format a string
with "sprintf()" and then pass that string to "col_add_fstr()" with a
format of "%s" and the string as an argument - "col_add_fstr()" can
format strings itself (that's what the "f" stands for).  Don't byte-swap
and then un-byte-swap IPv4 address fields in the header, just leave them
network byte order to start with.  Use the correct fields for
"proto_tree_add_XXX", rather than using the same field multiple times.
Quit early if an address family identifier isn't AFNUM_INET, as that
means the structure we use to dissect the header doesn't match the
actual header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3761 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate .cvsignore.
guy [Sat, 21 Jul 2001 06:32:27 +0000 (06:32 +0000)]
Update .cvsignore.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3760 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoI guess some bridges take Netware Ethernet_802_3 frames, which are 802.3
guy [Sat, 21 Jul 2001 06:30:21 +0000 (06:30 +0000)]
I guess some bridges take Netware Ethernet_802_3 frames, which are 802.3
frames (with a length field rather than a type field, but with no 802.2
header in the payload), and just stick the payload into an 802.11 frame.
I've seen captures that show frames of that sort.

This means we have to do the same check for Netware 802.3 - or, if you
will, "Netware 802.11" - that we do in the Ethernet dissector, i.e.
checking for 0xffff as the first four bytes of the payload and, if we
find it, treating it as an IPX frame.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3759 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some more notes on What Not To Do when writing code for Ethereal, so
guy [Fri, 20 Jul 2001 23:38:30 +0000 (23:38 +0000)]
Add some more notes on What Not To Do when writing code for Ethereal, so
as not to end up with, for example, code that works fine with GCC but
fails to compile with other compilers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3758 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"inline" is an extension to C, not a standard part of C; don't declare
guy [Fri, 20 Jul 2001 23:21:33 +0000 (23:21 +0000)]
"inline" is an extension to C, not a standard part of C; don't declare
functions as "inline", use G_INLINE_FUNC (<glib.h> declares it

Put in a URL for the current PGM draft.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3757 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCosEventComm dissector, from Frank Singleton.
guy [Fri, 20 Jul 2001 20:56:18 +0000 (20:56 +0000)]
CosEventComm dissector, from Frank Singleton.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3756 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate from Frank Singleton to put the right file name in the
guy [Fri, 20 Jul 2001 20:36:31 +0000 (20:36 +0000)]
Update from Frank Singleton to put the right file name in the
introductory comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3755 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoTell people *NOT* to create zero-length "hf[]" arrays if they don't have
guy [Fri, 20 Jul 2001 09:55:08 +0000 (09:55 +0000)]
Tell people *NOT* to create zero-length "hf[]" arrays if they don't have
any fields to register.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3754 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of zero-length arrays.
guy [Fri, 20 Jul 2001 09:51:19 +0000 (09:51 +0000)]
Get rid of zero-length arrays.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3753 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDo not put zero-length arrays into the generated dissector; GCC may let
guy [Fri, 20 Jul 2001 09:50:08 +0000 (09:50 +0000)]
Do not put zero-length arrays into the generated dissector; GCC may let
you get away with them, but other compilers, e.g. Microsoft Visual C++,

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3752 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a comment.
guy [Fri, 20 Jul 2001 09:22:05 +0000 (09:22 +0000)]
Fix a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3751 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDon't base the WSP dissector's idea of whether it's running in
guy [Fri, 20 Jul 2001 09:10:16 +0000 (09:10 +0000)]
Don't base the WSP dissector's idea of whether it's running in
connectionless or connection-oriented mode on the server port; that
won't work with redirects.  Instead, base it on the protocol atop which
WSP is running - atop UDP, or directly atop WTLS, it's connectionless;
atop WTP, it's connection-oriented.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3750 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIf the HeadersLen field of a Post or Reply PDU is 0, don't try to
guy [Fri, 20 Jul 2001 08:40:54 +0000 (08:40 +0000)]
If the HeadersLen field of a Post or Reply PDU is 0, don't try to
dissect the ContentType or Headers fields, as they're not there.

If there's no header data left over after the ContentType field, don't
try to dissect the Headers field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3749 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAssume that Bearer-indication values are bearer types.
guy [Fri, 20 Jul 2001 08:16:11 +0000 (08:16 +0000)]
Assume that Bearer-indication values are bearer types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3748 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd bearer type names.
guy [Fri, 20 Jul 2001 08:04:11 +0000 (08:04 +0000)]
Add bearer type names.

Base the interpretation of the address in a Redirect PDU on the bearer
type, not the length of the address.

Add support for IPv6 addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3747 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoClean up a lot of stuff, and implement a bunch of missing stuff; a bunch
guy [Fri, 20 Jul 2001 07:25:34 +0000 (07:25 +0000)]
Clean up a lot of stuff, and implement a bunch of missing stuff; a bunch
of things showed up when dissecting one capture file once the WSP
dissector started creating conversations for redirections, and packets
started being dissected as WSP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3746 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of some unused variables.
guy [Fri, 20 Jul 2001 07:22:40 +0000 (07:22 +0000)]
Get rid of some unused variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3745 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of some unused variables.
guy [Fri, 20 Jul 2001 07:11:57 +0000 (07:11 +0000)]
Get rid of some unused variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3744 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDissect WSP redirects, and set up a conversation and conversation
guy [Fri, 20 Jul 2001 04:39:07 +0000 (04:39 +0000)]
Dissect WSP redirects, and set up a conversation and conversation
dissector so that the redirected traffic is dissected as WAP traffic.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3743 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdded .cvsignore
hagbard [Fri, 20 Jul 2001 03:29:25 +0000 (03:29 +0000)]
Added .cvsignore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3742 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSimplified the process of adding plugins to the toplevel
hagbard [Fri, 20 Jul 2001 02:40:42 +0000 (02:40 +0000)]
Simplified the process of adding plugins to the toplevel
Makefile.am.  Updated doc/README.plugins to reflect the change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3741 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGIOP CosNaming support, from Frank Singleton.
guy [Thu, 19 Jul 2001 21:30:17 +0000 (21:30 +0000)]
GIOP CosNaming support, from Frank Singleton.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3740 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago- get_x25_pkt_len() :
oabad [Wed, 18 Jul 2001 15:49:29 +0000 (15:49 +0000)]
- get_x25_pkt_len() :
In "call accept" packets, the address block is not mandatory.
Check the packet length before trying to read the addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3739 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate from Frank Singleton to use the name of the IDL file to generate
guy [Tue, 17 Jul 2001 18:36:46 +0000 (18:36 +0000)]
Update from Frank Singleton to use the name of the IDL file to generate
the long name, short name, and filter name for CORBA IDL-defined

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3738 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdded a "Mark Frame" option to the packet_list_menu_items
hagbard [Tue, 17 Jul 2001 05:44:58 +0000 (05:44 +0000)]
Added a "Mark Frame" option to the packet_list_menu_items
so that you can right click on a packet in the packet list
and mark it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3737 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdded a "Suppress Unmarked" option to the print dialog to
hagbard [Tue, 17 Jul 2001 05:32:44 +0000 (05:32 +0000)]
Added a "Suppress Unmarked" option to the print dialog to
allow you to suppress the printing of unmarked packets.
This allows a user to mark the packets they wish to print and
print ONLY those packets by suppressing all other unmarked packets.

This may seem like a bit of a convoluted way of expressing things,
as usually the desired behavior would be to print the marked packets.
However, we do NOT print marked packets that are not displayed under
the current filter.  To be maximally explicite I've expressed this
as suppressing unmarked frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3736 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPut "doc/Makefile.nmake", "doc/README.design", and "doc/README.plugins"
guy [Mon, 16 Jul 2001 21:04:12 +0000 (21:04 +0000)]
Put "doc/Makefile.nmake", "doc/README.design", and "doc/README.plugins"
in the list of files in the distribution.

Make "doc" one of the subdirectories; this lets us remove
"doc/Makefile.in" from EXTRA_DIST, and might also ensure that stuff gets
rebuilt in that directory when it changes (for example, I don't know
whether "make dist" would have automatically rebuilt "doc/Makefile.in"
without "doc" being in the SUBDIRS list; if not, that might explain why
"doc/Makefile.in" didn't include rules for the mergecap man page in the
0.8.19 tarball).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3735 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix indentation.
guy [Mon, 16 Jul 2001 20:58:23 +0000 (20:58 +0000)]
Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3734 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a typo.
guy [Mon, 16 Jul 2001 20:57:42 +0000 (20:57 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3733 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoChanges to generate plugins instead of standard dissectors.
oabad [Mon, 16 Jul 2001 20:44:28 +0000 (20:44 +0000)]
Changes to generate plugins instead of standard dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3732 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix Thierry Pelle's name.
guy [Mon, 16 Jul 2001 18:03:29 +0000 (18:03 +0000)]
Fix Thierry Pelle's name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3731 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDescribe the use of FT_NONE, FT_STRING and other string-of-character
guy [Mon, 16 Jul 2001 06:16:14 +0000 (06:16 +0000)]
Describe the use of FT_NONE, FT_STRING and other string-of-character
types, and FT_BYTES in more detail.

FT_TEXT_ONLY is gone; remove it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3730 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUse "proto_tree_add_item()", not "proto_tree_add_string()" with a
guy [Mon, 16 Jul 2001 06:09:02 +0000 (06:09 +0000)]
Use "proto_tree_add_item()", not "proto_tree_add_string()" with a
"tvb_get_ptr()" call using the same offset and length as the
"proto_tree_add_string()" call, to add FT_STRING fields to the tree.
(The value argument to "proto_tree_add_string()" must be
null-terminated, and there's no guarantee that the string you get from
the "tvb_get_ptr()" call will be null-terminated;
"proto_tree_add_item()" with an FT_STRING field, however, will
null-terminate the value.)

Fix the length argument in the call for the last item in the Yahoo
Messenger tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3729 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet the length of a null-terminated string with "tvb_strnlen()", not by
guy [Mon, 16 Jul 2001 06:06:06 +0000 (06:06 +0000)]
Get the length of a null-terminated string with "tvb_strnlen()", not by
getting a pointer to the first byte of the string with "tvb_get_ptr()"
and then assuming you can safely do a "strlen()" with that pointer
(it's not guaranteed that you can, as the terminating null byte might
not be in the tvbuff).

Add the resulting string with "proto_tree_add_item()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3728 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"Cipher", not "Cypher".
guy [Mon, 16 Jul 2001 05:17:30 +0000 (05:17 +0000)]
"Cipher", not "Cypher".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3727 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoConvert a bunch of "proto_tree_add_bytes(tree, hf, tvb, offset, length,
guy [Mon, 16 Jul 2001 05:16:58 +0000 (05:16 +0000)]
Convert a bunch of "proto_tree_add_bytes(tree, hf, tvb, offset, length,
tvb_get_ptr(tvb, offset, length))" calls to "proto_tree_add_item()"

Do the same, in "packet-iscsi.c" and "packet-mrdisc.c", for
"proto_tree_add_uint()" and "proto_tree_add_boolean()" calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3726 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPut back the protocol tree fields for items with subtrees - but as
guy [Mon, 16 Jul 2001 04:02:22 +0000 (04:02 +0000)]
Put back the protocol tree fields for items with subtrees - but as
FT_NONE, not FT_STRING, as they have no value assigned to them.

Don't use "hf_ssl_handshake_certificate" both for the collection of all
certificates and for individual certificates, add a new
"hf_ssl_handshake_certificates" FT_NONE field for the collection of all
certificates, as is done for other collections.

Properly pluralize the "N specs" in the item for the collection of
cipher specs.

Properly label the second "ssl.record" as "SSLv2 record data", not
"Length of SSLv2 record data".

Fix a typo in the field name of the field for the length of the
collection of certificates.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3725 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPut various length fields into the protocol tree.
guy [Mon, 16 Jul 2001 01:38:34 +0000 (01:38 +0000)]
Put various length fields into the protocol tree.

Opaque fields should be FT_BYTES, not FT_STRING; FT_STRING is for text

Don't supply a null value when putting an FT_BYTES field into the tree;
supply a pointer to the actual bytes.

For items with subtrees, use "proto_tree_add_text()" if the actual value
of all the stuff under the subtree, treated as a big array of bytes,
isn't interesting (e.g., if the individual items are put into the
protocol tree).  Also, make the items with subtrees refer to the same
data as all the items under them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3724 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoBefore setting the value of an string field, make sure it's not null.
guy [Sun, 15 Jul 2001 20:31:02 +0000 (20:31 +0000)]
Before setting the value of an string field, make sure it's not null.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3723 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFixes, from Scott Renfro, for some calls to "localtime()" that didn't
guy [Sun, 15 Jul 2001 19:14:03 +0000 (19:14 +0000)]
Fixes, from Scott Renfro, for some calls to "localtime()" that didn't
check whether the call succeeded (it doesn't always do so on Windows,
for example).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3722 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix from Scott Renfro - one field had a name beginning with "ss" rather
guy [Sun, 15 Jul 2001 19:09:07 +0000 (19:09 +0000)]
Fix from Scott Renfro - one field had a name beginning with "ss" rather
than "ssl".

Remove duplicate credits for Scott in the AUTHORS file and man page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3721 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Scott Renfro: correctly handle merging multiple files with
guy [Sat, 14 Jul 2001 19:28:11 +0000 (19:28 +0000)]
From Scott Renfro: correctly handle merging multiple files with
different encapsulation types (as best we can).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3720 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDissect more diagnostic codes.
oabad [Sat, 14 Jul 2001 09:30:01 +0000 (09:30 +0000)]
Dissect more diagnostic codes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3719 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate e-mail address for Ed Meaney.
guy [Sat, 14 Jul 2001 02:28:21 +0000 (02:28 +0000)]
Update e-mail address for Ed Meaney.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3718 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdated for release 0.8.19
jfoster [Fri, 13 Jul 2001 13:54:56 +0000 (13:54 +0000)]
Updated for release 0.8.19

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3716 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThe type pgm_t is also defined in /usr/include/sys/immu.h on SINIX-N systems.
girlich [Fri, 13 Jul 2001 11:42:44 +0000 (11:42 +0000)]
The type pgm_t is also defined in /usr/include/sys/immu.h on SINIX-N systems.
So I renamed it to pgm_type to remove the name-clash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3715 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate from Scott Renfro to allow mergecap to merge multiple capture
guy [Fri, 13 Jul 2001 08:16:16 +0000 (08:16 +0000)]
Update from Scott Renfro to allow mergecap to merge multiple capture
files into one capture file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3714 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd a new "cleanbld.bat" script, for Windows; it removes "config.h"
guy [Fri, 13 Jul 2001 08:14:03 +0000 (08:14 +0000)]
Add a new "cleanbld.bat" script, for Windows; it removes "config.h"
files that might be left over from a UNIX build, so that they'll be
reconstructed from the "config.h.win32" files on a Windows build.
(If you have "config.h" files left over from a UNIX build, the Windows
build will fail.)

Update "README.win32" to mention "cleanbld.bat", and to correctly list
the files generated using tools that don't come with Windows or MSVC++.
Also note that some of them can't be built on UNIX systems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3713 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Scott Renfro:
guy [Fri, 13 Jul 2001 07:55:13 +0000 (07:55 +0000)]
From Scott Renfro:

  - make a leading zero in the argument to -t optional;

  - includes the -t option in in the summary portion of of the editcap
    usage message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3712 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSet "pinfo->current_proto" in the browsser dissector.
guy [Fri, 13 Jul 2001 07:04:23 +0000 (07:04 +0000)]
Set "pinfo->current_proto" in the browsser dissector.

Set the protocol and info columns before fetching anything that might
cause an exception.

Add some more different fields for the different types of host names in
browser packets.

Force an exception to be thrown if there's no NUL terminator for a name
in the tvbuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3711 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCheck for IPv6 support, and check what type of IPv6 support we have, in
guy [Fri, 13 Jul 2001 01:34:13 +0000 (01:34 +0000)]
Check for IPv6 support, and check what type of IPv6 support we have, in
the "epan" directory, as well as the top-level directory, as there's
stuff in the "epan" directory that depends on that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3710 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Joerg Mayer:
guy [Fri, 13 Jul 2001 00:55:58 +0000 (00:55 +0000)]
From Joerg Mayer:

 * gcc 3.0 warning fixes:
  - text2pcap.c: The number of characters to scan should probably not be 0
  - wiretap/csids.c: using preincrement on a variable used on both
    sides of an assignment might be undefined by the C99(?) standard
 * turn on additional warnings for epan and wiretap too
  - epan/configure.in
  - wiretap/configure.in
 * Fix some warnings (missing includes, signed/unsigned, missing
    initializers) found by turning on the warnings
  - all other files :-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3709 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd a "time_msecs_to_str()" routine, to turn a time interval, expressed
guy [Fri, 13 Jul 2001 00:27:51 +0000 (00:27 +0000)]
Add a "time_msecs_to_str()" routine, to turn a time interval, expressed
as a 32-bit number of milliseconds, to a descriptive string.

Use that in the MS Browser dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3708 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThe 2 bytes in the middle of the election criteria field of an election
guy [Fri, 13 Jul 2001 00:01:35 +0000 (00:01 +0000)]
The 2 bytes in the middle of the election criteria field of an election
request are the major and minor versions of the browser protocol.

The 4 bytes that, in announcements other than domain/workgroup
announcements, are the major and minor versions of the browser protocol
and the signature constant, are something else mysterious in
domain/workgroup announcements; stuff them in as a "Mysterious Field"
for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3707 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoTvbuffified SMB BROWSER dissector, from Ronnie Sahlberg.
guy [Thu, 12 Jul 2001 23:37:48 +0000 (23:37 +0000)]
Tvbuffified SMB BROWSER dissector, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3706 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPackage mergecap.exe and its HTML documentation.
gram [Thu, 12 Jul 2001 22:45:23 +0000 (22:45 +0000)]
Package mergecap.exe and its HTML documentation.
Update NSIS syntax for newest NSIS. That fix from David O'Shea.
Set config.nmake to get non-cygwin version of Python.exe; cygwin version
is fouling up on me and I'm not sure why.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3705 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPragmatic General Multicast isn't RFC 2705.
guy [Thu, 12 Jul 2001 21:48:46 +0000 (21:48 +0000)]
Pragmatic General Multicast isn't RFC 2705.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3704 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Edward Meaney: include "mergecap.rc" in the list of things to be
guy [Thu, 12 Jul 2001 21:02:06 +0000 (21:02 +0000)]
From Edward Meaney: include "mergecap.rc" in the list of things to be

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3703 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPGM (Pragmatic General Multicast - RFC 2705) support, from Steve Dickson.
guy [Thu, 12 Jul 2001 20:16:29 +0000 (20:16 +0000)]
PGM (Pragmatic General Multicast - RFC 2705) support, from Steve Dickson.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3702 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMergecap utility for merging capture files, from Scott Renfro.
guy [Thu, 12 Jul 2001 19:59:41 +0000 (19:59 +0000)]
Mergecap utility for merging capture files, from Scott Renfro.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3701 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPatch to allow the creation of "User Exception decoding" code from
oabad [Thu, 12 Jul 2001 19:51:42 +0000 (19:51 +0000)]
Patch to allow the creation of "User Exception decoding" code from
Frank Singleton.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3700 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdditional filterable fields added, from Heikki Vatiainen.
guy [Thu, 12 Jul 2001 19:43:59 +0000 (19:43 +0000)]
Additional filterable fields added, from Heikki Vatiainen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3699 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFixes to "proto_tree_add_item()" calls, and replacement of
guy [Thu, 12 Jul 2001 19:42:57 +0000 (19:42 +0000)]
Fixes to "proto_tree_add_item()" calls, and replacement of
"proto_tree_add_ipv4()" and "proto_tree_add_uint()" calls with
"proto_tree_add_item()" calls, from Heikki Vatiainen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3698 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Heikki Vatiainen: fix to previous checkin (I guess some platforms
guy [Thu, 12 Jul 2001 08:52:59 +0000 (08:52 +0000)]
From Heikki Vatiainen: fix to previous checkin (I guess some platforms
allow the redefinition of "strlen", as it compiled on at least some

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3697 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"-t" flag for editcap, to adjust timestamps in frames, from Scott
guy [Thu, 12 Jul 2001 08:16:45 +0000 (08:16 +0000)]
"-t" flag for editcap, to adjust timestamps in frames, from Scott

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3696 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoInclude <string.h> to declare string functions that we use.
guy [Thu, 12 Jul 2001 07:06:25 +0000 (07:06 +0000)]
Include <string.h> to declare string functions that we use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3695 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoInclude "snprintf.h" if necessary, as we use "snprintf()".
guy [Thu, 12 Jul 2001 07:05:33 +0000 (07:05 +0000)]
Include "snprintf.h" if necessary, as we use "snprintf()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3694 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNCP-over-IP bug fix (it wasn't skipping the NCP-over-{TCP,UDP} header
guy [Thu, 12 Jul 2001 01:48:05 +0000 (01:48 +0000)]
NCP-over-IP bug fix (it wasn't skipping the NCP-over-{TCP,UDP} header
before passing the packet on to the request and reply dissectors), from
David Eisner.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3693 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSSL/TLS support, from Scott Renfro.
guy [Wed, 11 Jul 2001 18:19:16 +0000 (18:19 +0000)]
SSL/TLS support, from Scott Renfro.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3692 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoChange from Heikki Vatiainen - mark the columns non-writable before
guy [Wed, 11 Jul 2001 17:56:31 +0000 (17:56 +0000)]
Change from Heikki Vatiainen - mark the columns non-writable before
dissecting the encapsulated IPv4 packet, so that they reflect the MSDP
packet rather than the encapsulated packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3691 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPut the settings of the flags into the summary line for the TACACS+
guy [Wed, 11 Jul 2001 16:03:34 +0000 (16:03 +0000)]
Put the settings of the flags into the summary line for the TACACS+
flags field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3690 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake TACACS+ a separate protocol.
guy [Wed, 11 Jul 2001 07:03:45 +0000 (07:03 +0000)]
Make TACACS+ a separate protocol.

Use registered fields in both the TACACS and TACACS+ dissectors, and put
in Booleans for request vs. response in TACACS+, as it used to be there
(the request type determines that in TACACS).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3689 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"make-reg-dotc" was writing the "#include "register.h"" line to
guy [Wed, 11 Jul 2001 05:41:38 +0000 (05:41 +0000)]
"make-reg-dotc" was writing the "#include "register.h"" line to
"register.c-tmp", not "${outfile}-tmp"; fix that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3688 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd "register-static.c" to the list of files to ignore in CVS.
guy [Wed, 11 Jul 2001 05:25:43 +0000 (05:25 +0000)]
Add "register-static.c" to the list of files to ignore in CVS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3687 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPut some missing header files into noinst_HEADERS, so they are made part
guy [Wed, 11 Jul 2001 05:23:08 +0000 (05:23 +0000)]
Put some missing header files into noinst_HEADERS, so they are made part
of the source tarball.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3686 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNot all C compilers allow C++-style comments.
guy [Wed, 11 Jul 2001 04:49:34 +0000 (04:49 +0000)]
Not all C compilers allow C++-style comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3685 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Todd Sabin: cleaned up "get_column_format_matches()".
guy [Wed, 11 Jul 2001 04:44:58 +0000 (04:44 +0000)]
From Todd Sabin: cleaned up "get_column_format_matches()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3684 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd entries for traceroute requests and responses to the value_string
guy [Wed, 11 Jul 2001 04:24:34 +0000 (04:24 +0000)]
Add entries for traceroute requests and responses to the value_string
table for IGMP packet types (we treat requests as "Query or Request", as
the type doesn't say which it is).

Base the query vs. request decision on the reported length of the
packet, not the captured length.

Checksum the packet only if it's not fragmented and the captured length
is greater than or equal to the amount to be checksummed, and, for
requests where we don't wire in the length to be checksummed, base it on
the reported length of the packet, not the captured length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3683 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoJust add the "hf_type" field in a traceroute message with
guy [Wed, 11 Jul 2001 04:02:51 +0000 (04:02 +0000)]
Just add the "hf_type" field in a traceroute message with
"proto_tree_add_uint_format()", rather than adding it as a hidden field
and then adding a text entry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3682 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSupport for dissectors of protocols running atop DCE RPC registering
guy [Wed, 11 Jul 2001 01:25:45 +0000 (01:25 +0000)]
Support for dissectors of protocols running atop DCE RPC registering
themselves with the DCE RPC dissector, and support for some of the
protocols atop DCE RPC that are part of DCE RPC, from Todd Sabin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3681 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMSDP support, from Heikki Vatiainen.
guy [Wed, 11 Jul 2001 00:59:50 +0000 (00:59 +0000)]
MSDP support, from Heikki Vatiainen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3680 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Paul Ionescu: fleshed out TACACS/XTACACS/TACACS+ dissector.
guy [Tue, 10 Jul 2001 21:06:53 +0000 (21:06 +0000)]
From Paul Ionescu: fleshed out TACACS/XTACACS/TACACS+ dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3679 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some additional items to .cvsignore files, for new files built when
guy [Tue, 10 Jul 2001 20:58:42 +0000 (20:58 +0000)]
Add some additional items to .cvsignore files, for new files built when
compiling plugins for statically-linked binaries.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3678 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIGMP fixes and multicast traceroute support, from Heikki Vatiainen.
guy [Tue, 10 Jul 2001 20:55:54 +0000 (20:55 +0000)]
IGMP fixes and multicast traceroute support, from Heikki Vatiainen.

Assorted other fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3677 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFixed the make dist problem.
hagbard [Tue, 10 Jul 2001 13:18:43 +0000 (13:18 +0000)]
Fixed the make dist problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3676 f5534014-38df-0310-8fa8-9805f1628bb7