Add bandwidth figures to RLC stats (per-UE and per-channel).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34059 f5534014-38df-0310-8fa8-9805f1628bb7

Fix start offset and length handling in SEQUNCE OF (caused Gtk crash for sequences at the end of frame)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34058 f5534014-38df-0310-8fa8-9805f1628bb7

Increase maximum number of nodes to 40.
10 is in some situations too few.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34057 f5534014-38df-0310-8fa8-9805f1628bb7

Code cleanup: Remove Begin/End comments on each and every code block,
this only makes the code hard to read.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34056 f5534014-38df-0310-8fa8-9805f1628bb7

Check if using tree before adding the octet string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34055 f5534014-38df-0310-8fa8-9805f1628bb7

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34054 f5534014-38df-0310-8fa8-9805f1628bb7

Add doxygen coments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34053 f5534014-38df-0310-8fa8-9805f1628bb7

Add doxygen coments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34052 f5534014-38df-0310-8fa8-9805f1628bb7

Add a comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34051 f5534014-38df-0310-8fa8-9805f1628bb7

From Michael Lum:
ANSI-A dissector does not recognize service option 73
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5176

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34050 f5534014-38df-0310-8fa8-9805f1628bb7

From Michael Lum:
The EVRC dissector does not handle service option 73 (EVRC-NW).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5177

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34049 f5534014-38df-0310-8fa8-9805f1628bb7

Apply the quick fix from bug 2952.

And it's true, this dissector really needs an overhaul!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34048 f5534014-38df-0310-8fa8-9805f1628bb7

Add comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34047 f5534014-38df-0310-8fa8-9805f1628bb7

Introduce 2 new environment variables: WIRESHARK_EP_VERIFY_POINTERS and
WIRESHARK_SE_VERIFY_POINTERS that control whether or not we verify if a given
pointer is ep_ or se_ allocated, respectively.

Turn the behavior off by default for speed reasons (the speed difference isn't
huge, but...).

Turn the behavior on when fuzz testing.

Document these two new variables in the man pages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34046 f5534014-38df-0310-8fa8-9805f1628bb7

Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5173 :

Don't call col_set_str() on a string returned from val_to_str() (which may be
ep_ allocated).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34045 f5534014-38df-0310-8fa8-9805f1628bb7

Fix typo in comment: datat -> data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34044 f5534014-38df-0310-8fa8-9805f1628bb7

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34043 f5534014-38df-0310-8fa8-9805f1628bb7

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34042 f5534014-38df-0310-8fa8-9805f1628bb7

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34041 f5534014-38df-0310-8fa8-9805f1628bb7

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34040 f5534014-38df-0310-8fa8-9805f1628bb7

Ensure we always print the heading when dumping PSML and CSV.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34039 f5534014-38df-0310-8fa8-9805f1628bb7

1.4 version does not display the t.38 graph.
(init/remove tap_listener missing)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34038 f5534014-38df-0310-8fa8-9805f1628bb7

Expand and update comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34037 f5534014-38df-0310-8fa8-9805f1628bb7

From Jaap Keuter:
Fix Wireshark don't show mgcp calls in "Telephony" => "VoIP calls"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5167

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34036 f5534014-38df-0310-8fa8-9805f1628bb7

From Pascal Quantin:
Patch that allows the dissection of the Feature Group Indicators bit string. I tested it with our UE and it works fine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34035 f5534014-38df-0310-8fa8-9805f1628bb7

A GString has it's own length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34034 f5534014-38df-0310-8fa8-9805f1628bb7

Support space in list of hidden columns.

This fixes bug 5163.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34033 f5534014-38df-0310-8fa8-9805f1628bb7

Add stub code for future dissection of featureGroupIndicators.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34032 f5534014-38df-0310-8fa8-9805f1628bb7

Update the header length after dissecting the header.

This fixes bug 5162.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34031 f5534014-38df-0310-8fa8-9805f1628bb7

Ensure we always update the display filter when changing profile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34030 f5534014-38df-0310-8fa8-9805f1628bb7

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34029 f5534014-38df-0310-8fa8-9805f1628bb7

Add #include <stdio.h> for fprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34028 f5534014-38df-0310-8fa8-9805f1628bb7

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34027 f5534014-38df-0310-8fa8-9805f1628bb7

Switch to GTK UIManager.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34026 f5534014-38df-0310-8fa8-9805f1628bb7

Include stdio.h.  Fixup indent some.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34025 f5534014-38df-0310-8fa8-9805f1628bb7

Fix the crash reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5157 :

If get_unicode_or_ascii_string() returns a NULL pointer, return a pointer to an
empty string back to our caller.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34018 f5534014-38df-0310-8fa8-9805f1628bb7

Remove some unnecessary includes: a lot of things don't need globals.h and register.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34017 f5534014-38df-0310-8fa8-9805f1628bb7

Use the top-level isprint.h instead of redefining isprint ourselves.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34016 f5534014-38df-0310-8fa8-9805f1628bb7

Remove a redundant callback.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34015 f5534014-38df-0310-8fa8-9805f1628bb7

Convert to GTKUIManager

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34014 f5534014-38df-0310-8fa8-9805f1628bb7

Doxygen fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34013 f5534014-38df-0310-8fa8-9805f1628bb7

Call dfilter_macro_uat->post_update_cb instead of using cfile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34012 f5534014-38df-0310-8fa8-9805f1628bb7

Always update the display filter when changing a display filter macro
and when changing profile.  Not sure why I have to invalidate cfile.dfilter
in macro_update(), because this will be done in macros_post_update(),
but unless this we get a crash when renaming a macro...

This is a fix for bug 5002.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34011 f5534014-38df-0310-8fa8-9805f1628bb7

Always call post_update_cb() in uat_load_str().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34010 f5534014-38df-0310-8fa8-9805f1628bb7

Doxygen related changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34009 f5534014-38df-0310-8fa8-9805f1628bb7

Make a note about how to "activare" the filter popup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34008 f5534014-38df-0310-8fa8-9805f1628bb7

Various:
1. Re-arrange proto_reg_handoff... code to follow the "standard idiom" for init/set of port prefs;
2. Define all fcns as static (except proto_register and proto_reg_handoff);
3. ethereal --> Wireshark;
4. Remove some uneeded/unused prototypes;
5. Fix a few function description comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34006 f5534014-38df-0310-8fa8-9805f1628bb7

Switch to GTK UIManager.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34002 f5534014-38df-0310-8fa8-9805f1628bb7

Fix for Bug Packet details have errors when decode MAP V2 PRN_ACK msg
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5076

Use:
/*
 * Dissect Multiple Choice Message
 * This function is used to decode a message, when several encoding may be used.
 * For exemple, in the last MAP version, the Cancel Location is defined like this:
 * CancelLocationArg ::= [3] IMPLICIT SEQUENCE
 * But in the previous MAP version, it was a CHOICE between a SEQUENCE and an IMSI
 * As ASN1 encoders (or software) still uses the old encoding, this function allows
 * the decoding of both versions.
 * Moreover, some optimizations (or bad practice ?) in ASN1 encoder, removes the
 * SEQUENCE tag, when only one parameter is present in the SEQUENCE.
 * This explain why the function expects 3 parameters:
 * - a [3] SEQUENCE corresponding the recent ASN1 MAP encoding
 * - a SEQUENCE for old style
 * - and a single parameter, for old version or optimizations
 *
 * The analyze of the first ASN1 tag, indicate what kind of decoding should be used,
 * if the decoding function is provided (so not a NULL function)
 */

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34001 f5534014-38df-0310-8fa8-9805f1628bb7

From  Cal Turney (bug 5132):
TCP bytes_in flight becomes inflated with lost packets

This patch suspends Bytes-in-Flight calculation when missing packets are detected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33994 f5534014-38df-0310-8fa8-9805f1628bb7

Doxygen changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33993 f5534014-38df-0310-8fa8-9805f1628bb7

[Automatic manuf and enterprise-numbers update for 2010-08-29]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33992 f5534014-38df-0310-8fa8-9805f1628bb7

Doxygen changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33991 f5534014-38df-0310-8fa8-9805f1628bb7

Doxygen changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33990 f5534014-38df-0310-8fa8-9805f1628bb7

Display 6to4 gateway IPv4 addresses and SLA IDs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33984 f5534014-38df-0310-8fa8-9805f1628bb7

#inlude <emem.h> not req'd;
Use tvb_strncmp to compare for "ESIO" string in packet;
Use consistent indentation conforming to the "editor modelines";
Minor other whitespce cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33983 f5534014-38df-0310-8fa8-9805f1628bb7

De-obfuscate the Teredo client address and add a de-obfuscated port.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33982 f5534014-38df-0310-8fa8-9805f1628bb7

Doxygen changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33981 f5534014-38df-0310-8fa8-9805f1628bb7

As mentioned on the users-mailinglist[1], it could be useful to have groups read access to the ringbuffer that dumpcap creates. That way, a group of people can access the capture files without having to use root access.

[1]  http://www.wireshark.org/lists/wireshark-users/201008/msg00235.html

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33978 f5534014-38df-0310-8fa8-9805f1628bb7

We change the owner and group of the first file, so we also want to change owner and group of the rest of the files in the ringbuffer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33977 f5534014-38df-0310-8fa8-9805f1628bb7

Support for eMLPP Priority IE in BSSMAP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33971 f5534014-38df-0310-8fa8-9805f1628bb7

Update some links.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33969 f5534014-38df-0310-8fa8-9805f1628bb7

Added Owen Kirby as author

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33965 f5534014-38df-0310-8fa8-9805f1628bb7

Allow Dissect As... to select the Ethernet-without-FCS dissector for a
given UDP port; this is to handle the output for the Cisco CMTS "cable
intercept" command - it encapsulates Ethernet frames in UDP packets, but
the UDP port is user-defined.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33964 f5534014-38df-0310-8fa8-9805f1628bb7

MNC, SANC, ISPC lists updated up to OB 960

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33963 f5534014-38df-0310-8fa8-9805f1628bb7

From Owen Kirby via bug 5149:
Added a new dissector for SCoP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33962 f5534014-38df-0310-8fa8-9805f1628bb7

From Frank Lahm via bug 5136:
Correct volume flags for FPGetSrvrParms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33961 f5534014-38df-0310-8fa8-9805f1628bb7

Display Teredo encapsulated IPv4 server and client addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33959 f5534014-38df-0310-8fa8-9805f1628bb7

Forward-port r33953.

Move the SetDllDirectory calls to ws_init_dll_search_path. If
SetDllDirectory fails, pass the Wireshark program path to
SetCurrentDirectory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33958 f5534014-38df-0310-8fa8-9805f1628bb7

From Dirk via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5150 : remove Makefile.in from the asn1 directories when doing a maintainer-clean

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33955 f5534014-38df-0310-8fa8-9805f1628bb7

From Christian Durrer via bug 5155:
Added a new dissector for Ether-S-I/O protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33954 f5534014-38df-0310-8fa8-9805f1628bb7

From Matthieu Lochegnies via bug 5153:
Show multiples DRDA commands from the same frame.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33952 f5534014-38df-0310-8fa8-9805f1628bb7

(Trivial) Fix a typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33951 f5534014-38df-0310-8fa8-9805f1628bb7

Allow 3GPP release info to be displayed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33950 f5534014-38df-0310-8fa8-9805f1628bb7

Added a check for constructed octet string to avoid a loop.

This fixes bug 5154.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33949 f5534014-38df-0310-8fa8-9805f1628bb7

Take in updates from the TLS registery.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33948 f5534014-38df-0310-8fa8-9805f1628bb7

Make wireshark-dev depend on the right automake.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33947 f5534014-38df-0310-8fa8-9805f1628bb7

From Kirill A. Korinskiy:
Enumerated is derived from the Integer32 AVP Base Format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33946 f5534014-38df-0310-8fa8-9805f1628bb7

I suspect the changes to config.nmake committed in SVN #33942 were not intended.
Revert the changes (for now ?) so the Buildbot will run again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33945 f5534014-38df-0310-8fa8-9805f1628bb7

Doxygen fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33942 f5534014-38df-0310-8fa8-9805f1628bb7

Check input string in ps_clean_string().

This fixes bug 5148.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33941 f5534014-38df-0310-8fa8-9805f1628bb7

Fixed by running doxygen -u

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33939 f5534014-38df-0310-8fa8-9805f1628bb7

Fix doxygen errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33938 f5534014-38df-0310-8fa8-9805f1628bb7

Show a text string of the Windows version (if Windows 2000 or higher.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33936 f5534014-38df-0310-8fa8-9805f1628bb7

Add a newline. Fixup whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33933 f5534014-38df-0310-8fa8-9805f1628bb7

Fix a number of doxygen directives.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33930 f5534014-38df-0310-8fa8-9805f1628bb7

Fix a number of doxygen directives.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33929 f5534014-38df-0310-8fa8-9805f1628bb7

From Juha Siltanen via bug 5144:
Added support for payload dissecting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33928 f5534014-38df-0310-8fa8-9805f1628bb7

- Try to fix a couple of doxygen comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33927 f5534014-38df-0310-8fa8-9805f1628bb7

- Try to fix a couple of doxygen comments.
- whitspace changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33926 f5534014-38df-0310-8fa8-9805f1628bb7

Move Windows-specific material inside an appropriate #ifdef.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33925 f5534014-38df-0310-8fa8-9805f1628bb7

Add ws_load_library and ws_module_open, which respectively call
LoadLibrary and g_module_open only for the program directory and system
directory on Windows. Use them to replace a bunch of LoadLibrary and
g_module_open calls. Use the extension ".dll" for all the DLLs that we
load. Add comments about DLL loading in Python.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33924 f5534014-38df-0310-8fa8-9805f1628bb7

Update the WinPcap developer's pack to 4.1.2.  Update PCAP_VERSION to 4.1.2 on Win64 too (for consistency more than anything I think).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33923 f5534014-38df-0310-8fa8-9805f1628bb7

Use PCAP_VERSION (from config.nmake) instead of hard coding the WinPcap version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33922 f5534014-38df-0310-8fa8-9805f1628bb7

Change PCAP_VERSION to 4.1.2.  Hopefully this will cause the U3/PortableApps builds to pick up WinPcap again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33921 f5534014-38df-0310-8fa8-9805f1628bb7

Fix wrong length of CSeq Method parameter

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33920 f5534014-38df-0310-8fa8-9805f1628bb7

Let DCT2000 tree extend to end of ipprim or sctpprim bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33919 f5534014-38df-0310-8fa8-9805f1628bb7

Show (again?) MAC-d PDUs inside MAC-es PDUs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33918 f5534014-38df-0310-8fa8-9805f1628bb7

Fix !Windows compilation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33917 f5534014-38df-0310-8fa8-9805f1628bb7

Partial fix for bug 5133. On Windows, call SetDllDirectory at startup if
it's present in Wireshark and dumpcap. This takes care of the airpcap.dll
PoC but we need to load wpcap.dll from a full path. We might want to
call SetDllDirectory from our other executables as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33916 f5534014-38df-0310-8fa8-9805f1628bb7