martinm [Wed, 25 May 2011 09:08:27 +0000 (09:08 +0000)]
Allow longer field names in the advanced filter control.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37390
f5534014-38df-0310-8fa8-
9805f1628bb7
alagoutte [Wed, 25 May 2011 07:15:05 +0000 (07:15 +0000)]
From tschardt via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5949
802.11 IE tag number 61/62 still decoded to "Unknown"/Reserved tag Number
Remove inadvertently by me in rev36120
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37389
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 25 May 2011 05:33:00 +0000 (05:33 +0000)]
From Florian Fainelli:
Patch adding the Homeplug AV ethertype.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5943
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37388
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 25 May 2011 02:35:30 +0000 (02:35 +0000)]
One "-Warray-bounds" suffices; as we're including it in the default
options, no need to include it in the "extra warnings" options as well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37387
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 25 May 2011 01:44:13 +0000 (01:44 +0000)]
An Attribute Name with a '.' (Foundry-MAC-Authent-needs-802.1x) causes an access violation.
Change '802.1x' to '802-1x' in 2 places temporarily until I get a chance to see what's going on.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37386
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 25 May 2011 00:40:35 +0000 (00:40 +0000)]
Add new dictionary from freeradius.org: GIT 2.1.x branch.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37385
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 25 May 2011 00:30:09 +0000 (00:30 +0000)]
Use freeradius.org version [from the GIT 2.1.x branch]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37384
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 25 May 2011 00:07:37 +0000 (00:07 +0000)]
Tunnel related VALUEs are actually defined in dictionary.rfc2867.
Also: remove 3 "unassigned" entries to match the FreeRadius dictionary.rfc2866.
Note: This version (w/o the dup Acct-Status-Type) will be submitted upstream.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37383
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 24 May 2011 20:59:34 +0000 (20:59 +0000)]
Use latest version from FreeRadius 2.1.10 release.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37382
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 24 May 2011 19:20:59 +0000 (19:20 +0000)]
Remove blank line added by mistake ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37381
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 24 May 2011 19:13:04 +0000 (19:13 +0000)]
Update list of radius dictionary files to reflect adds/deletes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37380
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 24 May 2011 18:47:03 +0000 (18:47 +0000)]
Obsolete; See dictionary.rfc2868
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37379
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 24 May 2011 18:42:04 +0000 (18:42 +0000)]
Obsolete; See dictionary.erx
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37378
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 24 May 2011 18:24:29 +0000 (18:24 +0000)]
Updated dictionary files released as part of FreeRadius v2.1.7 thru v2.1.10
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37377
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 24 May 2011 17:18:34 +0000 (17:18 +0000)]
Some dictionary files added in FreeRadius v2.1.7 - 2.1.10.
(These aren't list in the dictionary file).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37376
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 24 May 2011 16:30:32 +0000 (16:30 +0000)]
Add new dictionary files from FreeRadius v2.1.7 thru 2.1.10
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37375
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 24 May 2011 16:17:43 +0000 (16:17 +0000)]
Don't print hidden columns.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37374
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 24 May 2011 00:07:56 +0000 (00:07 +0000)]
Move the Windows argument list conversion code to a common routine.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37372
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 18:04:45 +0000 (18:04 +0000)]
Fix various benign cases of Coverity [UNUSED]: 996,995,956,936,899,1133,1000
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37371
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 23 May 2011 17:53:51 +0000 (17:53 +0000)]
From Romain Fliedel via bug 5947: Fix the mask for extracting FMID.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37370
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 17:51:33 +0000 (17:51 +0000)]
Use the 'proto_tree *' (not the 'proto_item *') for a proto_tree_add_item(): Coverity 963 {UNUSED]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37369
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Mon, 23 May 2011 17:15:00 +0000 (17:15 +0000)]
Pass tap info into sequence analysis function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37368
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Mon, 23 May 2011 16:11:32 +0000 (16:11 +0000)]
Detect when padding non-final padding comes after other control subheaders.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37367
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 16:09:09 +0000 (16:09 +0000)]
(Trivial) Testing _MSC_FULL_VER can be done at compile time.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37366
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 23 May 2011 14:41:04 +0000 (14:41 +0000)]
Fix compilation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37365
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 14:34:59 +0000 (14:34 +0000)]
Remove an unneeded redundant line of code: Fixes Coverity 1001.
Also:
Use a separate ett variable for a subtree;
Convert what appears to be '4 space tabs' to '4 spaces'.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37364
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 14:30:00 +0000 (14:30 +0000)]
Use correct subtree in two cases: Fixes Coverity 920;
Also:
Remove a number of unneeded #include statements;
Do some whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37363
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 23 May 2011 14:28:02 +0000 (14:28 +0000)]
Fix compilation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37362
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 14:26:43 +0000 (14:26 +0000)]
Use correct subtree in a few cases: Fixes Coverity 921,894,878 & 1136;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37361
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 14:17:30 +0000 (14:17 +0000)]
Use correct subtree in several 'proto_tree_add_text(...)' statements: Fixes Coverity 938 [UNUSED].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37360
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 14:14:43 +0000 (14:14 +0000)]
Use correct subtree in 'call dissector(...)': Fixes Coverity 962 [UNUSED].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37359
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 14:13:03 +0000 (14:13 +0000)]
Add a missing line of code: Fixes Coverity 967 [UNUSED].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37358
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 23 May 2011 14:11:14 +0000 (14:11 +0000)]
Use correct subtree for proto_tree_add_item in several places: Coverity 1130 [UNUSED];
Also: Reformat a few lines and do some whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37357
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Mon, 23 May 2011 10:09:08 +0000 (10:09 +0000)]
Add missing braces.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37356
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 23 May 2011 08:54:47 +0000 (08:54 +0000)]
7.3.2.25 or 802.11-2007 gives an example of length 20, so it is unclear where the 24 came from (unintentionally fixes bug 5942)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37355
f5534014-38df-0310-8fa8-
9805f1628bb7
darkjames [Mon, 23 May 2011 08:03:50 +0000 (08:03 +0000)]
Clean duplicated contributors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37354
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 23 May 2011 00:32:40 +0000 (00:32 +0000)]
Delete unused header field entries found by running checkhf.pl.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37353
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 23 May 2011 00:05:07 +0000 (00:05 +0000)]
Added Michael Mann for his contributions to bug 2794.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37352
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 23 May 2011 00:00:53 +0000 (00:00 +0000)]
From Micheal Mann via bug 2794: Fix some display filter field names.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37351
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 22 May 2011 22:04:24 +0000 (22:04 +0000)]
From Yaniv Kaul: Some 'set but not used' compilation fixes;
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5858
From me: 2 corrections to the patch and sevral other minor changes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37350
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 22 May 2011 15:04:14 +0000 (15:04 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-05-22]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37346
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 22 May 2011 11:11:00 +0000 (11:11 +0000)]
Fix the case where you start with interfaces on the command line
(so using ifaces) and then using the GUI (which only deals with
iface).
These kind of problems will completely disappear when the
old strucuture components like iface have completely be
retired. This is the next thing we will work on.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37345
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sat, 21 May 2011 20:57:00 +0000 (20:57 +0000)]
Use appropriate temporary filename when capturing from multiple interfaces.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37344
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sat, 21 May 2011 18:51:25 +0000 (18:51 +0000)]
As suggested on the dev list: Use pcapng and threads
when capturing on multiple interfaces even if not specified
on the command line.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37343
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sat, 21 May 2011 13:22:38 +0000 (13:22 +0000)]
Fix the capturing from the GUI. Honor the iface variable.
The next step is to retire the iface variable and use
the ifaces array only. This should simplify things and
fix the cases, where you start wireshark with command
line arguments and also use the GUI.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37342
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 21 May 2011 00:10:57 +0000 (00:10 +0000)]
Pass a pcap_options * instead of a pcap_options **.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37341
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 20:41:23 +0000 (20:41 +0000)]
Don't assign to a variable which is then not referenced: Coverity 998 [UNUSED].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37340
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 20:29:19 +0000 (20:29 +0000)]
Don't assign to an unused variable: Fixes Coverity 874 [UNUSED].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37339
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 20:22:59 +0000 (20:22 +0000)]
Fix a typo ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37338
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 20:21:14 +0000 (20:21 +0000)]
Remove unneeded code: Fixes Coverity 890 [UNUSED].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37337
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 20:10:41 +0000 (20:10 +0000)]
Use (what appears to be) the correct tvb for a function call: Fixes Coverity 919 [UNUSED];
#include <stdlib.h> not req'd.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37336
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 20:00:16 +0000 (20:00 +0000)]
Remove unused code: Fixes Coverity 972 [UNUSED].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37335
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 19:00:09 +0000 (19:00 +0000)]
Add #include <stdlib.h> to files which reference fcns declared in stdlib.h;
(In many cases I previously incorrectly removed the #include <stdlib.h>).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37334
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 20 May 2011 17:02:20 +0000 (17:02 +0000)]
Add bugs 4985 and 5580 to the list of known problems.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37333
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 15:44:25 +0000 (15:44 +0000)]
Don't assign to a proto_item* if the value won't be used:
Fixes Coverity 903,935,968,985,997,999,1024,1025,1134;
Remove unneeded #includes;
Do whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37331
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 15:34:29 +0000 (15:34 +0000)]
Add to comment about using a heuristic; Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37330
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 15:22:58 +0000 (15:22 +0000)]
Use correct parent tree when creating a subtree: Fixes Coverity 902 [UNUSED];
Remove unneeded #includes;
Do some whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37329
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 15:19:26 +0000 (15:19 +0000)]
'#if 0' code related to already commented out code: Fixes Coverity 881.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37328
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 20 May 2011 14:21:02 +0000 (14:21 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 975 [UNUSED]
Remove unneeded prefs callback in prefs registration;
Remove 'if (!initialized)' test from proto_reg_handoff...();
Remove unneeded #include;
Do some whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37327
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 20 May 2011 13:55:21 +0000 (13:55 +0000)]
Prettify som 3GPP AVP:s
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37326
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 20 May 2011 11:58:00 +0000 (11:58 +0000)]
gtk_menu_item_set_label() is from gtk 2.16.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37325
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 20 May 2011 11:30:51 +0000 (11:30 +0000)]
Include the profile name in the Delete item in the profiles popup.
Fixed creating a new profile from the popup without setting a create from.
Removed some unneeded ep_strdup_printf.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37324
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 20 May 2011 03:22:27 +0000 (03:22 +0000)]
Copy data from the TVB into ep_alloc'd memory, rather than saving a pointer into the TVB.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37323
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 20 May 2011 03:20:20 +0000 (03:20 +0000)]
Use tvb_get_ephemeral_string() instead of tvb_get_ptr().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37322
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 20 May 2011 03:17:01 +0000 (03:17 +0000)]
Use tvb_bytes_to_str() instead of a homegrown version.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37321
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 20 May 2011 03:15:18 +0000 (03:15 +0000)]
Use TVB accessor functions instead of tvb_get_ptr()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37320
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 20 May 2011 03:12:56 +0000 (03:12 +0000)]
Use tvb_ether_to_str()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37319
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 20 May 2011 02:44:12 +0000 (02:44 +0000)]
Fix annoying typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37318
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 20 May 2011 02:42:14 +0000 (02:42 +0000)]
Use proto_tree_add_item() instead of proto_tree_add_xxx() with a pointer into
the TVB.
Introduce and start using tvb_get_manuf_name() and tvb_get_manuf_name_if_known()
which do the same as the non-tvb versions but take a tvb and an offset instead
of (commonly) a pointer into a TVB.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37317
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 20 May 2011 02:35:05 +0000 (02:35 +0000)]
In at least some versions of OS X SystemStarter gets cranky if the
startup item is group-writable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37316
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 19 May 2011 21:11:44 +0000 (21:11 +0000)]
Add pdml2html.xsl to the source tarball.
(Can we have a macro that has everything in pkgdata_DATA except for
COPYING, and use that macro in both the definition of pkgdata_DATA and
EXTRA_DIST?)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37314
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 19 May 2011 21:09:29 +0000 (21:09 +0000)]
Update the User's Guide.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37312
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 19 May 2011 20:48:58 +0000 (20:48 +0000)]
Drop privileges after opening all pcap devices, not after the first one...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37311
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 19 May 2011 20:37:36 +0000 (20:37 +0000)]
1.6 → 1.7.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37309
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 May 2011 20:21:08 +0000 (20:21 +0000)]
Don't assign to an unused 'proto item *': Coverity 1033 & 906
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37308
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 19 May 2011 20:20:35 +0000 (20:20 +0000)]
In case we have no interface information in the array, use the global value.
This fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5935.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37307
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 May 2011 20:16:10 +0000 (20:16 +0000)]
Create subtree under the correct parent tree: Coverity 1138.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37306
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 May 2011 20:13:54 +0000 (20:13 +0000)]
Don't assign a value which is never used to a 'proto item *': Covertiy 1135;
Remove some unneeded #includes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37305
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 19 May 2011 20:13:33 +0000 (20:13 +0000)]
Fix markup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37304
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 19 May 2011 19:52:56 +0000 (19:52 +0000)]
Update the version and command output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37303
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 May 2011 19:48:39 +0000 (19:48 +0000)]
#if 0 some not currently used code: Fixes Coverity 966 [UNUSED]
Convert apparent "4 space tabs" to "4 spaces".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37302
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 May 2011 19:22:49 +0000 (19:22 +0000)]
Remove unneeded variable and code; Rename a function arg; Fix usage of _U_: Fixes Coverity 1146 [UNUSED]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37301
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 19 May 2011 19:03:22 +0000 (19:03 +0000)]
FOP 0.95 → 1.0.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37300
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 19 May 2011 18:10:21 +0000 (18:10 +0000)]
From Dirk Jagdmann via bug 5875:
My attachment adds a link to a XSLT file to the preamble of the PDML.
The XSLT will transform the PDML to a HTML page, and the HTML page
features a look similar to Wireshark. See
http://cubic.org/~doj/ebay/a.pdml for an example.
The patch also contains a small perl program which converts the
Wireshark colortable into javascript code which is used in the XSLT
file. If you want to use a different color scheme you would execute the
perl program and insert the generated javascript function into your XSLT
file.
To view the HTML you could either place the PDML and XSLT file on your
webserver and verify that your webserver sends the PDML file as
"text/xml". Then your webbrowser will find the linked XSLT file,
download that as well and convert the PDML to HTML on the fly.
You could also use an XSLT processor like xsltproc to convert the PDML
and XSLT into a static HTML file.
From me:
Minor fixups.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37298
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 19 May 2011 16:22:21 +0000 (16:22 +0000)]
Give some routines used for info levels that appear both in set and get
names beginning with dissect_qspi_, and give some of them names with the
info level structure in them rather than the SNIA CIFS specification
section number.
Have separate routines for SMB_INFO_STANDARD and SMB_INFO_QUERY_EA_SIZE;
SMB_INFO_STANDARD is specified differently in the SNIA CIFS
specification and the MS-CIFS specification, and some captures have the
SNIA CIFS version, with the EA length and some have the MS-CIFS version
without it. The dissector for SMB_INFO_STANDARD will dissect it if it's
there and not say "this structure is truncated" if it's not there.
Rename dissect_qfi_SMB_FILE_ALTERNATE_NAME_INFO() to
dissect_qfi_SMB_FILE_NAME_INFO(), as it also dissects
SMB_QUERY_FILE_NAME_INFO.
Merge the dissectors for SMB_FILE_ALLOCATION_INFO and
SMB_SET_FILE_ALLOCATION_INFO, and for SMB_FILE_END_OF_FILE_INFO and
SMB_SET_FILE_END_OF_FILE_INFO, as the structures are the same.
Dissect some presumed "passthrough info levels" the same way the
corresponding official SMB infos are dissected.
Expand some comments for info level dissectors to give the MS-CIFS
section number and to give some other details.
If an info level is truncated, put in an expert info error.
If we don't know about a given info level, just dissect the body as
"Information level unknown", rather than having it dissected as an
"unknown information" trailer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37297
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 19 May 2011 16:11:02 +0000 (16:11 +0000)]
When capturing from multiple interface, indicate this in the main status bar.
This patch is, as all other patches related to capturing from multiple interfaces,
based on work of Irene Ruengeler.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37296
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 19 May 2011 15:38:44 +0000 (15:38 +0000)]
Fix compilation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37295
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 19 May 2011 15:23:19 +0000 (15:23 +0000)]
Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37294
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 May 2011 14:48:05 +0000 (14:48 +0000)]
Don't assign a value to a variable which is then not used: Coverity 1145
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37293
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 19 May 2011 14:41:58 +0000 (14:41 +0000)]
Subdissect 2 3GPP AVP:s that are actually text.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37292
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 May 2011 14:32:14 +0000 (14:32 +0000)]
Don't assign to an unused variable; remove variable definition: Coverity 1144.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37291
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 May 2011 14:11:01 +0000 (14:11 +0000)]
Don't assign a value to a variable which is then never used: Coverity 1160 [UNUSED]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37290
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 19 May 2011 12:19:03 +0000 (12:19 +0000)]
When capturing from multiple interfaces, indicate this in the window
title of the wireshark main window.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37289
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 19 May 2011 12:14:27 +0000 (12:14 +0000)]
Remove unused define.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37288
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 19 May 2011 11:58:18 +0000 (11:58 +0000)]
It is not an error (anymore) to specify multiple capture filters.
This was
wireshark -i lo0 -f sctp -i en0 -f udp -k
will work.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37287
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 19 May 2011 09:47:03 +0000 (09:47 +0000)]
The routines declared in packet-smb.h are defined in packet-smb.c;
include packet-smb.h in packet-smb.c so that we check the declarations
against the definitions.
In query ops, info level 2 is Query EA Size, not Query EAs From List.
In set ops, info level 2 is Set EAs, not Query EA Size.
Expand the constants for the Trans2 subcodes to 16 bits.
The tvb argument to dissect_find_file_unix_info2() is used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37286
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 19 May 2011 05:51:52 +0000 (05:51 +0000)]
Actually use the defaults from the last commit message.
... and switch off debug output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37285
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Thu, 19 May 2011 05:49:46 +0000 (05:49 +0000)]
Add a queue and byte limit to the capture queue. Current default
values: 1000 packets, 1 MB. Should be made configurable via
command line options.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37284
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 19 May 2011 05:46:07 +0000 (05:46 +0000)]
Fix warnings about unused variables in UI_MANAGER code.
Move gsm_a_stat.c back to clean dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37283
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 19 May 2011 05:44:32 +0000 (05:44 +0000)]
Fix two warning in case of UIMANAGER:
- Unused variable
- ‘graph_type’ may be used uninitialized
Is the second part of the patch (added inside the else clause)
correct?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37282
f5534014-38df-0310-8fa8-
9805f1628bb7