obnox/wireshark/wip.git
13 years agoFrom Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3301 :
morriss [Wed, 1 Dec 2010 23:26:07 +0000 (23:26 +0000)]
From Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3301 :

The information which is used to determine which sub-dissector to use for the
various Data messages within an SCCP connection is only present within the
initial Connection Request, so even with connection tracking on, unless the
trace contains the Connection Request no sub-dissector is called. It is common
for traces to only contain a single carried protocol anyway - e.g. RANAP.

The supplied patch adds a user preference for a "default payload"
sub-dissector, which is called in preference to the Data dissector if nothing
else has claimed the packet first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35098 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3301 :
morriss [Wed, 1 Dec 2010 23:12:46 +0000 (23:12 +0000)]
From Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3301 :

The packet-sccp.c has a bug in the declared valid ranges of the SSN and DPC
values in the user table used to match to a subdissector. The SSN range is 16
bits rather than 8 (not really an issue) but the DPC range is 16 bits rather
than 24 - so many traces cannot be matched by this table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35097 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd details to the table of Microsoft Visual C++ compilers (Win32 native tool chain...
sfisher [Wed, 1 Dec 2010 21:42:19 +0000 (21:42 +0000)]
Add details to the table of Microsoft Visual C++ compilers (Win32 native tool chain) for Visual C++ 2010 Express and Professional.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35096 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoChange underscore to dash to show correct docbook-xml42 package in Cygwin.
sfisher [Wed, 1 Dec 2010 21:21:33 +0000 (21:21 +0000)]
Change underscore to dash to show correct docbook-xml42 package in Cygwin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35095 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoNow the Microsoft Visual C++ 2010 redistributable for x86 (32-bit) brings up a confus...
sfisher [Wed, 1 Dec 2010 20:48:44 +0000 (20:48 +0000)]
Now the Microsoft Visual C++ 2010 redistributable for x86 (32-bit) brings up a confusing dialog asking the user to repair or remove it if it's already installed.  Change it to (re-)install quietly (/q command-line option) like we do with the 64-bit version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35094 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd extern "C" to more header files.
sfisher [Wed, 1 Dec 2010 18:25:18 +0000 (18:25 +0000)]
Add extern "C" to more header files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35093 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd #ifndef __PRIVILEGES_H__ / #define / #endif logic to prevent multiple
sfisher [Wed, 1 Dec 2010 18:16:41 +0000 (18:16 +0000)]
Add #ifndef __PRIVILEGES_H__ / #define / #endif logic to prevent multiple
inclusions of privileges.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35092 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDelegated-IPv6-Prefix(123) is shown incorrect as X-Ascend-Call-Attempt-Limit(123)
etxrab [Wed, 1 Dec 2010 17:34:26 +0000 (17:34 +0000)]
Delegated-IPv6-Prefix(123) is shown incorrect as X-Ascend-Call-Attempt-Limit(123)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5455

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35091 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix bug #5453 "Help->About Wireshark mis-reports OS" (again) without the help of...
sfisher [Wed, 1 Dec 2010 16:39:28 +0000 (16:39 +0000)]
Fix bug #5453 "Help->About Wireshark mis-reports OS" (again) without the help of MSDN code fragments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35090 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdded Alex Badea for his contribution via bug #4149.
cmaynard [Wed, 1 Dec 2010 15:48:45 +0000 (15:48 +0000)]
Added Alex Badea for his contribution via bug #4149.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35089 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Alex Badea via bug #4149: IPcomp: decompress deflated payloads.
cmaynard [Wed, 1 Dec 2010 15:45:24 +0000 (15:45 +0000)]
From Alex Badea via bug #4149: IPcomp: decompress deflated payloads.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35088 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix a GCC error.
wmeier [Wed, 1 Dec 2010 02:18:01 +0000 (02:18 +0000)]
Fix a GCC error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35087 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoOn Windows: convert _tzname[] strings from the system charset to UTF8 before use.
wmeier [Wed, 1 Dec 2010 01:31:49 +0000 (01:31 +0000)]
On Windows: convert _tzname[] strings from the system charset to UTF8 before use.

 In the Windows C Runtime the strings in the global array _tzname[]
   are encoded using the "system default ansi code page".
   They must be converted to UTF8 before use by Wireshark/GTK.
   (See comment in the code for details).

   Fixes Bug #5421 (I hope).
   https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5421

Also: Fix bug: when the timezone name is not available from the system
      ?ST was used when ?DT should have been used (and vice-versa).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35086 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoBack out r35084 since it contains code fragments from MSDN, which are covered
sfisher [Wed, 1 Dec 2010 00:42:48 +0000 (00:42 +0000)]
Back out r35084 since it contains code fragments from MSDN, which are covered
under the "Microsoft Limited Public License" apparently.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35085 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix bug #5453: Use GetSystemNativeInfo() function if found on the machine running...
sfisher [Tue, 30 Nov 2010 23:42:47 +0000 (23:42 +0000)]
Fix bug #5453: Use GetSystemNativeInfo() function if found on the  machine running Wireshark instead of GetSystemInfo(), so that we obtain the machine's actual architecture even when running under WOW64 x86 emulation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35084 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate the manuf file (ahead of this weekend's auto-update) to reflect rev 35082...
morriss [Tue, 30 Nov 2010 22:33:29 +0000 (22:33 +0000)]
Update the manuf file (ahead of this weekend's auto-update) to reflect rev 35082's change to make-manuf.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35083 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4102 :
morriss [Tue, 30 Nov 2010 22:28:34 +0000 (22:28 +0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4102 :

Limit the length of manuf names to 8 characters in make-manuf (this matches
the (old) limit in addr_resolv.c).

Dynamically allocate memory to store the manuf name in epan/addr_resolv.c so
that we don't end up corrupting the UTF-8 if/when we need to truncate the
string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35082 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoConvert the .c file names to .obj before putting them in WIRESHARK_GTK_OBJECTS.
morriss [Tue, 30 Nov 2010 21:32:04 +0000 (21:32 +0000)]
Convert the .c file names to .obj before putting them in WIRESHARK_GTK_OBJECTS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35081 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMove the port audio source into a separate variable which is not run through checkapi.
morriss [Tue, 30 Nov 2010 20:57:43 +0000 (20:57 +0000)]
Move the port audio source into a separate variable which is not run through checkapi.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35080 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoWe don't include a comprehensive display filter reference; don't say we
gerald [Tue, 30 Nov 2010 17:46:09 +0000 (17:46 +0000)]
We don't include a comprehensive display filter reference; don't say we
do.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35079 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRename conflicting draft v2 and v8 display filter fields. Fixes bug 4059.
cmaynard [Tue, 30 Nov 2010 17:08:37 +0000 (17:08 +0000)]
Rename conflicting draft v2 and v8 display filter fields.  Fixes bug 4059.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35078 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Toralf Foerster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5432 :
morriss [Tue, 30 Nov 2010 17:06:13 +0000 (17:06 +0000)]
From Toralf Foerster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5432 :

The attached patch against that dissector contains :

FIX:
- counting statistics over encrypted packages (line 610 ff)

NEW:
- tag sametime message type 0x0025 as known

MISC:
- better comment
- new line clean ups

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35077 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Pascal Quantin:
martinm [Tue, 30 Nov 2010 15:10:17 +0000 (15:10 +0000)]
From Pascal Quantin:

I just found a small bug in LTE PDCP dissector with current top of tree.
If global preference global_pdcp_dissect_user_plane_as_ip is set to true, the dissector will try to decode an IP frame even with signalling plane.
PDCP-LTE
    ...0 0000 = Seq Num: 0
    Signalling Data: 0800183aa808
    MAC: 0x00000000 (0)
[Malformed Packet: IP]
    [Expert Info (Error/Malformed): Malformed Packet (Exception occurred)]

With the attached patch, I get the correct output for both signalling and user plane PDUs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35076 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoOh yeah, there's a reason we don't put targets in Makefile.common: the first target...
morriss [Tue, 30 Nov 2010 02:04:55 +0000 (02:04 +0000)]
Oh yeah, there's a reason we don't put targets in Makefile.common: the first target in a makefile is what you get when you just run make (without a target).  Revert 35073 and 35069.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35075 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix "colorize with filter" functionality that got broken with the new_packet_list.
sake [Mon, 29 Nov 2010 22:50:21 +0000 (22:50 +0000)]
Fix "colorize with filter" functionality that got broken with the new_packet_list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35074 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMove some checkapi targets into Makefile.common
morriss [Mon, 29 Nov 2010 22:34:04 +0000 (22:34 +0000)]
Move some checkapi targets into Makefile.common

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35073 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove a no-longer-used variable.
morriss [Mon, 29 Nov 2010 22:11:39 +0000 (22:11 +0000)]
Remove a no-longer-used variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35072 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix the checkapi target.
morriss [Mon, 29 Nov 2010 21:46:53 +0000 (21:46 +0000)]
Fix the checkapi target.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35071 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoChange SIP TCP port preference to a range preference.
etxrab [Mon, 29 Nov 2010 21:40:49 +0000 (21:40 +0000)]
Change SIP TCP port preference to a range preference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35070 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMove the checkapi targes to Makefile.common. Rename Makefile.nmake's WIRESHARK_GTK_S...
morriss [Mon, 29 Nov 2010 20:53:22 +0000 (20:53 +0000)]
Move the checkapi targes to Makefile.common.  Rename Makefile.nmake's WIRESHARK_GTK_SRC to WIRESHARK_GTK_ALL_SRC to avoid reusing the variable of the same name from Makefile.common; Put DIRTY_GENERATED_C_FILES back in that variable since checkapi is no longer run on it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35069 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd "Length" as a new default column on a trial basis between the protocol
sfisher [Mon, 29 Nov 2010 20:43:24 +0000 (20:43 +0000)]
Add "Length" as a new default column on a trial basis between the protocol
and info columns per discussion on -dev list:

    http://www.wireshark.org/lists/wireshark-dev/201011/msg00151.html

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35068 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove DIRTY_GENERATED_C_FILES from WIRESHARK_GTK_SRC so we don't run checkapi on...
morriss [Mon, 29 Nov 2010 20:37:24 +0000 (20:37 +0000)]
Remove DIRTY_GENERATED_C_FILES from WIRESHARK_GTK_SRC so we don't run checkapi on it.  Also remove capture_if_details_dlg_win32.c from the checkapi list since it's in WIRESHARK_GTK_SRC (which is in the list of files checkapi is run against).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35067 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove file_dlg_win32.c and print_win32.c from the checkapi target.
morriss [Mon, 29 Nov 2010 20:09:09 +0000 (20:09 +0000)]
Remove file_dlg_win32.c and print_win32.c from the checkapi target.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35066 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd DIRTY_GENERATED_C_FILES to GENERATED_FILES (so they get cleaned up by distclean).
morriss [Mon, 29 Nov 2010 20:07:43 +0000 (20:07 +0000)]
Add DIRTY_GENERATED_C_FILES to GENERATED_FILES (so they get cleaned up by distclean).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35065 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Andrei Emeltchenko:
etxrab [Mon, 29 Nov 2010 18:15:09 +0000 (18:15 +0000)]
From Andrei Emeltchenko:
Wrong link type in a packet(bluethouth).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5449

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35064 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix typos.
cmaynard [Mon, 29 Nov 2010 17:22:05 +0000 (17:22 +0000)]
Fix typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35063 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Vincent Helfre:
etxrab [Mon, 29 Nov 2010 13:27:00 +0000 (13:27 +0000)]
From Vincent Helfre:
Make it possible to dissect NAS EPS messages without security header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35062 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Vincent Helfre:
etxrab [Mon, 29 Nov 2010 13:12:35 +0000 (13:12 +0000)]
From Vincent Helfre:
I have fixed some issue in the measurement information decoding in packet-gsm_a_rr.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35061 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to fix Buildbot crash output: fuzz-2010-11-28-11164.pcap
etxrab [Mon, 29 Nov 2010 13:02:31 +0000 (13:02 +0000)]
Try to fix Buildbot crash output: fuzz-2010-11-28-11164.pcap
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5448

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35060 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAllow DCT error strings containing given subsets to be filtered upon.
martinm [Mon, 29 Nov 2010 12:09:18 +0000 (12:09 +0000)]
Allow DCT error strings containing given subsets to be filtered upon.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35059 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake the Primary name element filterable in response records.
jmayer [Sun, 28 Nov 2010 21:45:15 +0000 (21:45 +0000)]
Make the Primary name element filterable in response records.
Same for Nameserver names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35058 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agou3.c has moved.
jmayer [Sun, 28 Nov 2010 21:44:06 +0000 (21:44 +0000)]
u3.c has moved.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35057 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Slava:
etxrab [Sun, 28 Nov 2010 21:08:03 +0000 (21:08 +0000)]
From Slava:
Bug with RWH parsing in Infiniband dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5444

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35056 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Robert Groenenberg:
etxrab [Sun, 28 Nov 2010 21:03:43 +0000 (21:03 +0000)]
From Robert Groenenberg:
Assert when using ASN.1 dissector with loading a 'type table'
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5447

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35055 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Alex Badea:
etxrab [Sun, 28 Nov 2010 20:58:26 +0000 (20:58 +0000)]
From Alex Badea:
gsm_a_rr: System Information Type 4 / CBCH mobile allocation dissected incorrectly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5436

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35054 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago[Automatic manuf, services and enterprise-numbers update for 2010-11-28]
gerald [Sun, 28 Nov 2010 16:03:43 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-11-28]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35051 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix calling of LTE RRC dissector for "rrc_lte_r8" frames.
martinm [Sun, 28 Nov 2010 15:37:40 +0000 (15:37 +0000)]
Fix calling of LTE RRC dissector for "rrc_lte_r8" frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35050 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPartially clean up white space.
guy [Sun, 28 Nov 2010 00:53:23 +0000 (00:53 +0000)]
Partially clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35049 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoClean up white space.
guy [Sun, 28 Nov 2010 00:41:47 +0000 (00:41 +0000)]
Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35048 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoClean up white space.
guy [Sun, 28 Nov 2010 00:19:49 +0000 (00:19 +0000)]
Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35047 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMove u3 code to top-level directory since it's not GTK specific
sfisher [Sun, 28 Nov 2010 00:15:21 +0000 (00:15 +0000)]
Move u3 code to top-level directory since it's not GTK specific

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35046 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDon't report an error twice.
guy [Sun, 28 Nov 2010 00:13:38 +0000 (00:13 +0000)]
Don't report an error twice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35045 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd GCC-style printf annotation to the routines that now take a format
guy [Sun, 28 Nov 2010 00:02:39 +0000 (00:02 +0000)]
Add GCC-style printf annotation to the routines that now take a format
string and format arguments, and fix issues warned about by that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35044 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoClean up white space.
guy [Sun, 28 Nov 2010 00:00:58 +0000 (00:00 +0000)]
Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35043 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake some other statusbar routines take a format string and format args,
guy [Sat, 27 Nov 2010 23:06:14 +0000 (23:06 +0000)]
Make some other statusbar routines take a format string and format args,
and get rid of an unnecessary string pointer.

Make the argument to welcome_header_push_msg() a const pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35042 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMove main_statusbar.h to the top-level directory; none of its routines
guy [Sat, 27 Nov 2010 21:50:49 +0000 (21:50 +0000)]
Move main_statusbar.h to the top-level directory; none of its routines
use GTK+ data types, so, at least in theory, it could be implemented
atop another toolkit.

Make statusbar_push_temporary_msg() take a format string and format
arguments.  Use it instead of simple_status(), and change one call to
just take a format string and arguments rather than to take the result
of using that format string and arguments with g_strdup_printf() and
passing the result to statusbar_push_temporary_msg().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35041 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove "not tested" note on MSVC 2010's vcredist instructions
sfisher [Sat, 27 Nov 2010 18:52:02 +0000 (18:52 +0000)]
Remove "not tested" note on MSVC 2010's vcredist instructions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35040 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd svn:keywords & svn:eol-style properties.
wmeier [Sat, 27 Nov 2010 18:00:21 +0000 (18:00 +0000)]
Add svn:keywords & svn:eol-style properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35039 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom OKANO Takayoshi via bug #5442: Fix typos in documentation
sfisher [Sat, 27 Nov 2010 16:51:24 +0000 (16:51 +0000)]
From OKANO Takayoshi via bug #5442: Fix typos in documentation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35038 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix typo in comment
sfisher [Sat, 27 Nov 2010 01:13:25 +0000 (01:13 +0000)]
Fix typo in comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35037 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDefine HAVE_GTK in config.h when compiling with GTK for the GUI
sfisher [Fri, 26 Nov 2010 23:50:56 +0000 (23:50 +0000)]
Define HAVE_GTK in config.h when compiling with GTK for the GUI

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35036 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMention SSHv2 RFCs
sfisher [Fri, 26 Nov 2010 23:33:05 +0000 (23:33 +0000)]
Mention SSHv2 RFCs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35035 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix the rest of the include paths after the move of native win32 code to win32 and...
sfisher [Fri, 26 Nov 2010 20:57:46 +0000 (20:57 +0000)]
Fix the rest of the include paths after the move of native win32 code to win32 and out of the gtk directory in r35032

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35034 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix the Windows buildbot after r35032
sfisher [Fri, 26 Nov 2010 20:13:00 +0000 (20:13 +0000)]
Fix the Windows buildbot after r35032

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35033 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMove native Win32 code to its own directory and out of gtk directory (hopefully witho...
sfisher [Fri, 26 Nov 2010 19:16:06 +0000 (19:16 +0000)]
Move native Win32 code to its own directory and out of gtk directory (hopefully without breaking any builds)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35032 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove comment stating that Microsoft Visual Studio 2010 doesn't work since the expre...
sfisher [Fri, 26 Nov 2010 17:54:45 +0000 (17:54 +0000)]
Remove comment stating that Microsoft Visual Studio 2010 doesn't work since the express edition does (and presumably the full edition does also)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35031 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd libtool version info to libwsutil.
rbalint [Thu, 25 Nov 2010 23:00:16 +0000 (23:00 +0000)]
Add libtool version info to libwsutil.
From Eloy Paris <peloy@debian.org>
http://svn.debian.org/wsvn/collab-maint/ext-maint/wireshark/branches/wireshark-1.4.x%2Blibseparation/debian/patches/25_libwsutil-version.patch

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35030 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug 5435:
jake [Thu, 25 Nov 2010 19:59:19 +0000 (19:59 +0000)]
Fix for bug 5435:
Add support for dissecting SLL type 0x17 frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35029 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate comments to point to the previous commit to enhance traceabillity.
etxrab [Thu, 25 Nov 2010 15:21:24 +0000 (15:21 +0000)]
Update comments to point to the previous commit to enhance traceabillity.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35028 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove threading of tap update.
etxrab [Thu, 25 Nov 2010 13:56:29 +0000 (13:56 +0000)]
Remove threading of tap update.
See http://www.wireshark.org/lists/wireshark-dev/200611/msg00199.html

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35027 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoCreate proper Help reference.
jake [Thu, 25 Nov 2010 07:01:39 +0000 (07:01 +0000)]
Create proper Help reference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35026 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd support for USB isochronous. From Marton Nemeth via bug #5370.
cmaynard [Wed, 24 Nov 2010 17:33:58 +0000 (17:33 +0000)]
Add support for USB isochronous.  From Marton Nemeth via bug #5370.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35025 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAttempt to fix warnings not previously seen with VS2008EE.
cmaynard [Wed, 24 Nov 2010 17:10:48 +0000 (17:10 +0000)]
Attempt to fix warnings not previously seen with VS2008EE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35024 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Johannes Lange:
etxrab [Wed, 24 Nov 2010 16:35:23 +0000 (16:35 +0000)]
From Johannes Lange:
Function dissect_per_bit_string_display might read more bytes than available (PER dissector).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5394

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35023 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoWhen listing encapsulation types with -T or file types with -F, sort them.
cmaynard [Wed, 24 Nov 2010 16:24:44 +0000 (16:24 +0000)]
When listing encapsulation types with -T or file types with -F, sort them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35022 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Johannes Lange:
etxrab [Wed, 24 Nov 2010 16:21:04 +0000 (16:21 +0000)]
From Johannes Lange:
Bug 5393 - Wrong length calculation in new_octet_aligned_subset_bits() (PER dissector) .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5393

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35021 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTighten the heuristic.
etxrab [Wed, 24 Nov 2010 15:15:28 +0000 (15:15 +0000)]
Tighten the heuristic.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35020 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to fix dummy header settings alignment.
jake [Wed, 24 Nov 2010 08:41:22 +0000 (08:41 +0000)]
Try to fix dummy header settings alignment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35019 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoWhitespace cleanup;
wmeier [Wed, 24 Nov 2010 03:43:09 +0000 (03:43 +0000)]
Whitespace cleanup;
Add some braces;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35018 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTighten up code dissecting message header.
wmeier [Wed, 24 Nov 2010 02:11:43 +0000 (02:11 +0000)]
Tighten up code dissecting message header.

This corrects the specific issue reported in Bug #3317
wherein the dissector decided there was a valid but unknown
header when dissecting a binary (non text) message with a ":"
as the last byte.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3317

Note that a larger issue remains: the IMF dissector
presumably shouldn't really even try to dissect a
binary payload (which is proably encrypted text).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35017 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove Supported Channels lenght check fixes
etxrab [Tue, 23 Nov 2010 19:42:11 +0000 (19:42 +0000)]
Remove Supported Channels lenght check fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5430

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35016 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Vincent Helfre:
etxrab [Tue, 23 Nov 2010 17:33:57 +0000 (17:33 +0000)]
From Vincent Helfre:
Bug in tvb_get_bits32(), The last bitshift is too large, which causes the least significant bits to be 0 all the time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35015 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoBased on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391#c11 : put some...
morriss [Tue, 23 Nov 2010 15:27:18 +0000 (15:27 +0000)]
Based on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391#c11 : put some DISSECTOR_ASSERTs and THROW's back in.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35014 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoCheck the DDI while dissecting the header.
martinm [Tue, 23 Nov 2010 11:01:48 +0000 (11:01 +0000)]
Check the DDI while dissecting the header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35013 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse g_path_get_dirname in init_progfile_dir on Windows. Leave the
gerald [Mon, 22 Nov 2010 21:05:55 +0000 (21:05 +0000)]
Use g_path_get_dirname in init_progfile_dir on Windows. Leave the
non-Windows code alone since it needs to check for a libtool-ized path.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35012 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoInitialize no_assoc.app_info=0.
stig [Mon, 22 Nov 2010 21:05:49 +0000 (21:05 +0000)]
Initialize no_assoc.app_info=0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35011 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake sure we pass a directory path and not a file path to
gerald [Mon, 22 Nov 2010 20:43:22 +0000 (20:43 +0000)]
Make sure we pass a directory path and not a file path to
SetCurrentDirectory.  Should fix bug 5420.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35010 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Mike Morrin:
etxrab [Mon, 22 Nov 2010 20:24:12 +0000 (20:24 +0000)]
From Mike Morrin:
In bssmap, track L3 handover target (GSM or UMTS) between PDUs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5294

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35009 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove print_update_dynamic() decl from file_dlg_win32.h since only used in [...].c
wmeier [Mon, 22 Nov 2010 19:45:03 +0000 (19:45 +0000)]
Remove print_update_dynamic() decl from file_dlg_win32.h since only used in [...].c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35008 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Emil Wojak via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391 :
morriss [Mon, 22 Nov 2010 18:48:54 +0000 (18:48 +0000)]
From Emil Wojak via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391 :

I'd like to share my enhancements to the TDS dissector with everyone.
The list of improvements follows:
- nearly complete dissection of RPC calls,
- detection and dissection of the ALL_HEADERS rule,
- corrected some existing proto_tree fields to support filters,
- other minor fixes where the interpretation of data conflicted with the
  official documentation from MS.

I tested the new code on a variety of different TDS captures with many diverse
RPC calls. The code compiles and works on 32-bit Linux, I didn't check those
changes on other platforms though.

From me:

- terminate all value_strings
- change ++*offset to *offset += 1 (I think that's more readable)
- replace all the dissector assertions which could be caused by malformed
  packets with expert infos
- Don't throw ReportedBoundsError when the packets have unexpected data in
  them, just report an expert info and continue on

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35007 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPrevent "MS-DOS style path detected" messages for several commands (when "nodosfilewa...
wmeier [Mon, 22 Nov 2010 17:17:46 +0000 (17:17 +0000)]
Prevent "MS-DOS style path detected" messages for several commands (when "nodosfilewarning" not set).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35006 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 :
morriss [Mon, 22 Nov 2010 16:19:39 +0000 (16:19 +0000)]
From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 :

This is a dissector for reload framed message:
ReLOAD packets can be inserted in frame message, as described in
draft-ietf-p2psip-base-10

From me: remove some unnecessary includes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35005 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove faulty return, probably forgotten during test.
etxrab [Mon, 22 Nov 2010 15:02:06 +0000 (15:02 +0000)]
Remove faulty return, probably forgotten during test.
Fixing dissection on Via header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35004 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove 'keywords' property.
wmeier [Mon, 22 Nov 2010 14:59:33 +0000 (14:59 +0000)]
Remove 'keywords' property.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35003 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove 'keywords' property from a few files.
wmeier [Mon, 22 Nov 2010 14:57:58 +0000 (14:57 +0000)]
Remove 'keywords' property from a few files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35002 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd another (unsupported) channel type identifier.
martinm [Mon, 22 Nov 2010 13:37:13 +0000 (13:37 +0000)]
Add another (unsupported) channel type identifier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35001 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd sequence analysis for PDCP, based upon RLC/UM.
martinm [Mon, 22 Nov 2010 13:28:49 +0000 (13:28 +0000)]
Add sequence analysis for PDCP, based upon RLC/UM.
For now, only enable it for logged PDCP frames, i.e. not for PDCP found inside RLC (that won't work properly until RLC re-assembly is implemented).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35000 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd new files to cmake as well
jmayer [Mon, 22 Nov 2010 12:03:28 +0000 (12:03 +0000)]
Add new files to cmake as well

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34999 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDisplay priority and protocol, even in the case of WCCP2_SERVICE_STANDARD, but
cmaynard [Mon, 22 Nov 2010 05:09:57 +0000 (05:09 +0000)]
Display priority and protocol, even in the case of WCCP2_SERVICE_STANDARD, but
indicate that these fields are unused in this case and must be zero.
Furthermore, if the value is non-zero, add an expert info warning about it.
Fixes bug 3631.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34998 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix properties.
wmeier [Sun, 21 Nov 2010 19:33:46 +0000 (19:33 +0000)]
Fix properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34997 f5534014-38df-0310-8fa8-9805f1628bb7