obnox/wireshark/wip.git
8 years agoSharpen the description of preference names.
jake [Wed, 26 Jan 2011 21:20:09 +0000 (21:20 +0000)]
Sharpen the description of preference names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35671 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd MS-SMB2 to the list of URLs to reference for this protocol.
sfisher [Wed, 26 Jan 2011 21:00:06 +0000 (21:00 +0000)]
Add MS-SMB2 to the list of URLs to reference for this protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35670 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoImprove display of names and descriptions of SMB2 share flags and
sfisher [Wed, 26 Jan 2011 20:58:26 +0000 (20:58 +0000)]
Improve display of names and descriptions of SMB2 share flags and
share capabilities including adding two new flags with the help of
the MS-SMB2 specification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35669 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMinor changs to NetBIOS Session Service code:
sfisher [Wed, 26 Jan 2011 20:29:44 +0000 (20:29 +0000)]
Minor changs to NetBIOS Session Service code:

 - Simplify a proto_tree_add_uint() call into proto_tree_add_item()
 - Mention RFC 1002 in comment above message type definitions
 - Expand field descriptions for length field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35668 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd references to Windows 7 where appropriate; Add temp file info for Windows 7/Vista.
wmeier [Wed, 26 Jan 2011 20:23:18 +0000 (20:23 +0000)]
Add references to Windows 7 where appropriate; Add temp file info for Windows 7/Vista.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35667 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDissect PS-HANDOVER-REQUEST.
etxrab [Wed, 26 Jan 2011 19:44:23 +0000 (19:44 +0000)]
Dissect PS-HANDOVER-REQUEST.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35666 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd 10.5.1.14 NAS container for PS HO.
etxrab [Wed, 26 Jan 2011 19:37:30 +0000 (19:37 +0000)]
Add 10.5.1.14 NAS container for PS HO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35665 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd tfs_allowed_not_allowed.
etxrab [Wed, 26 Jan 2011 19:36:00 +0000 (19:36 +0000)]
Add tfs_allowed_not_allowed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35664 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMinor changes to SMB2 Share Type value string: rename values and change
sfisher [Wed, 26 Jan 2011 19:01:10 +0000 (19:01 +0000)]
Minor changes to SMB2 Share Type value string: rename values and change
from 2 bytes to 1 byte (the next byte is reserved) according to MS-SMB2
specification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35663 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Irene Ruengeler: Double check that the interface specified in the
tuexen [Wed, 26 Jan 2011 15:15:20 +0000 (15:15 +0000)]
From Irene Ruengeler: Double check that the interface specified in the
preferences still exists. If not, don't use it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35659 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCorrected entry for packet-lisp-data.c
stig [Wed, 26 Jan 2011 09:37:35 +0000 (09:37 +0000)]
Corrected entry for packet-lisp-data.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35658 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agopacket-ocsp-template.c:47: warning: type defaults to 'int' in declaration of 'proto_ocsp'
etxrab [Wed, 26 Jan 2011 09:07:11 +0000 (09:07 +0000)]
packet-ocsp-template.c:47: warning: type defaults to 'int' in declaration of 'proto_ocsp'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35657 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Kaspar Brand:
etxrab [Wed, 26 Jan 2011 08:57:26 +0000 (08:57 +0000)]
From Kaspar Brand:
(Part II)
SSL/TLS dissector: add support for "Certificate Status" messages (aka OCSP stapling)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5503

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35656 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Kaspar Brand:
etxrab [Wed, 26 Jan 2011 08:49:06 +0000 (08:49 +0000)]
From Kaspar Brand:
SSL/TLS dissector: add support for "Certificate Status" messages (aka OCSP stapling)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5503

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35655 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte:
etxrab [Wed, 26 Jan 2011 07:47:31 +0000 (07:47 +0000)]
From Alexis La Goutte:
Cleanup 802.11 Dissector : Header Field begin by hf_...
Patch 4 - 6
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5609

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35654 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Brian Ginsbach:
jake [Wed, 26 Jan 2011 07:24:06 +0000 (07:24 +0000)]
From Brian Ginsbach:
Patch to add a new dissector for Realm Specific IP (RSIP) as defined by
RFC 3102, RFC 3103, and RFC 3104.
This is a very basic dissector.  It could be extended to do addtional RSIP
protocol violation testing.  The dissector is written such that it should be
easy to add later.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35653 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago(Trivial) Fix a typo.
wmeier [Wed, 26 Jan 2011 00:15:01 +0000 (00:15 +0000)]
(Trivial) Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35652 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix fo bug 5616:
jake [Tue, 25 Jan 2011 22:11:59 +0000 (22:11 +0000)]
Fix fo bug 5616:
Remove the filters on IPv6 Link Local and Multicast addresses, since
these _can_ be resolved through the hosts file and manual entry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35651 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix gcc compilation.
gerald [Tue, 25 Jan 2011 18:43:43 +0000 (18:43 +0000)]
Fix gcc compilation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35650 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoSwitch more messages over to the "gsm dissector style".
etxrab [Tue, 25 Jan 2011 16:41:59 +0000 (16:41 +0000)]
Switch more messages over to the "gsm dissector style".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35649 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agopacket-windows-common.c:1492: warning: 'wkwn_sid2_len' may be used uninitialized...
etxrab [Tue, 25 Jan 2011 15:34:52 +0000 (15:34 +0000)]
packet-windows-common.c:1492: warning: 'wkwn_sid2_len' may be used uninitialized in this function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35648 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix:
etxrab [Tue, 25 Jan 2011 15:33:36 +0000 (15:33 +0000)]
Fix:
Error: the blurb for field "Well-known SID" ("nt.sid.wkwn") matches the field name in packet-windows-common.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35647 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoExport de_emm_trac_area_id.
etxrab [Tue, 25 Jan 2011 13:57:59 +0000 (13:57 +0000)]
Export de_emm_trac_area_id.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35646 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoExport Global-ENB-ID.
etxrab [Tue, 25 Jan 2011 13:56:15 +0000 (13:56 +0000)]
Export Global-ENB-ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35645 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd tfs_reliable_not_reliable.
etxrab [Tue, 25 Jan 2011 13:55:20 +0000 (13:55 +0000)]
Add tfs_reliable_not_reliable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35644 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Cal Turney:
etxrab [Tue, 25 Jan 2011 13:53:35 +0000 (13:53 +0000)]
From Cal Turney:
 Enhancements to SID dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5613

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35643 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Jouni Malinen:
jake [Mon, 24 Jan 2011 22:04:43 +0000 (22:04 +0000)]
From Jouni Malinen:
Allow TDLS Setup Response/Confirm to not include optional fields

Verifying whether non-zero status code is used and use explicit validation of
the remaining length and an expert info instead of implicit failure by an
exception.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35642 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago From Alexis La Goutte:
wmeier [Mon, 24 Jan 2011 20:54:20 +0000 (20:54 +0000)]
 From Alexis La Goutte:
 Some patch to cleanup the 802.11 Dissector.
 Part 3:  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5609

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35641 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoPrint "0 seconds" when time_val==0 in functions converting seconds to string.
stig [Mon, 24 Jan 2011 19:33:36 +0000 (19:33 +0000)]
Print "0 seconds" when time_val==0 in functions converting seconds to string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35640 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago1.5.0 → 1.5.1.
gerald [Mon, 24 Jan 2011 19:27:38 +0000 (19:27 +0000)]
1.5.0 → 1.5.1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35639 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix crash when doing File ! Export ! Objects ! SMB.
wmeier [Mon, 24 Jan 2011 18:59:26 +0000 (18:59 +0000)]
Fix crash when doing File ! Export ! Objects ! SMB.
[Essentially: simplify the code used to test for duplicate packets].
Fixes Bug #5337: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5337

Also:
- Fix "divide by 0" which caused garbage for display of a percent value;
- Remove some unneeded #includes;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35638 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoBuild 1.5.0.
gerald [Mon, 24 Jan 2011 18:37:24 +0000 (18:37 +0000)]
Build 1.5.0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35637 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoExport UE-EUTRA-Capability.
etxrab [Sun, 23 Jan 2011 23:45:36 +0000 (23:45 +0000)]
Export UE-EUTRA-Capability.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35634 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix a crash which can occur if a user hits "Capture:Options" immediately followed...
wmeier [Sun, 23 Jan 2011 20:59:12 +0000 (20:59 +0000)]
Fix a crash which can occur if a user hits "Capture:Options" immediately followed by "Capture:Start"

Fixes Bug #4645: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4645

Essentially: The "Capture Start" code "interrupted" the "Capture Options" code and attempted
 to use not yet initialized "Capture Options" state.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35633 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte:
jake [Sun, 23 Jan 2011 20:15:31 +0000 (20:15 +0000)]
From Alexis La Goutte:
Some patch to cleanup the 802.11 Dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35632 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte:
jake [Sun, 23 Jan 2011 20:11:08 +0000 (20:11 +0000)]
From Alexis La Goutte:
Some patch to cleanup the 802.11 Dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35631 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoReword some text about the accuracy of the dislayed values.
wmeier [Sun, 23 Jan 2011 17:29:06 +0000 (17:29 +0000)]
Reword some text about the accuracy of the dislayed values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35629 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago[Automatic manuf, services and enterprise-numbers update for 2011-01-23]
gerald [Sun, 23 Jan 2011 16:03:54 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-01-23]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35627 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoEnsure we keep the pkg_data pointer for the init routine to cleanup correctly,
stig [Sat, 22 Jan 2011 18:07:28 +0000 (18:07 +0000)]
Ensure we keep the pkg_data pointer for the init routine to cleanup correctly,
because the ep memory is cleared before the init routine is called.

Fixed the variable name for the no_yes true_false_string.
Update reference to protocol description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35626 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoResolve bug #2520 by moving the follow stream direction combo box above the
sfisher [Sat, 22 Jan 2011 17:42:40 +0000 (17:42 +0000)]
Resolve bug #2520 by moving the follow stream direction combo box above the
buttons to make more room for hostnames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35625 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd Loránd Jakab; Add two missing left-braces;
wmeier [Sat, 22 Jan 2011 17:01:47 +0000 (17:01 +0000)]
Add Loránd Jakab; Add two missing left-braces;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35624 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRemove unneeded #includes: <stdio>,<stdlib>,<string>; Add emacs editor modelines
wmeier [Sat, 22 Jan 2011 16:48:02 +0000 (16:48 +0000)]
Remove unneeded #includes: <stdio>,<stdlib>,<string>; Add emacs editor modelines

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35623 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse nstime_set_zero() to initialize nstime_t's.
morriss [Sat, 22 Jan 2011 15:35:34 +0000 (15:35 +0000)]
Use nstime_set_zero() to initialize nstime_t's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35622 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Johannes Lange via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5606 :
morriss [Sat, 22 Jan 2011 15:15:51 +0000 (15:15 +0000)]
From Johannes Lange  via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5606 :

In semcheck.c the display filter string of an expression is checked against the
header_field_info.display value BASE_CUSTOM. But the value of BASE_CUSTOM is
applied as bitmask while the actual type is an enum (BASE_CUSTOM = 6).

With this BASE_DEC, BASE_DEC_HEX and BASE_HEX_DEC are also matching and are not
accepted as filter expression.

Actually: BASE_DEC works but not BASE_HEX.  And the problem only shows up when
trying to match a field in one of these bases against a string (from a
value_string).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35621 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoSet active combo_box entry before connecting the changed signal
stig [Sat, 22 Jan 2011 14:02:38 +0000 (14:02 +0000)]
Set active combo_box entry before connecting the changed signal
to avoid a crash when opening the Import window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35620 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoClose dir opened by ws_dir_open().
stig [Sat, 22 Jan 2011 13:44:06 +0000 (13:44 +0000)]
Close dir opened by ws_dir_open().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35619 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoClose dir opened by ws_dir_open().
stig [Sat, 22 Jan 2011 13:43:54 +0000 (13:43 +0000)]
Close dir opened by ws_dir_open().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35618 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoInsert and update tshark and dumpcap help information.
jake [Sat, 22 Jan 2011 10:38:10 +0000 (10:38 +0000)]
Insert and update tshark and dumpcap help information.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35617 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd buttons to allow filtering only UL or DL on selected UE.
martinm [Sat, 22 Jan 2011 03:49:23 +0000 (03:49 +0000)]
Add buttons to allow filtering only UL or DL on selected UE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35616 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Loránd Jakab:
jake [Sat, 22 Jan 2011 00:18:03 +0000 (00:18 +0000)]
From Loránd Jakab:
The patch I am attaching here is for dissecting LISP data packets.

From me:
Minor cleanups.
Showing the reserved field.
Adding to all makefiles and release notes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35615 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUpdate the User Interface chapter of the User's Guide.
jake [Fri, 21 Jan 2011 23:37:46 +0000 (23:37 +0000)]
Update the User Interface chapter of the User's Guide.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35614 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRe-arrange help menu a bit to group website and wiki links.
jake [Fri, 21 Jan 2011 23:24:08 +0000 (23:24 +0000)]
Re-arrange help menu a bit to group website and wiki links.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35613 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoStart update for 1.5 version of User's Guide.
jake [Fri, 21 Jan 2011 20:57:24 +0000 (20:57 +0000)]
Start update for 1.5 version of User's Guide.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35612 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5604 :
morriss [Fri, 21 Jan 2011 17:12:02 +0000 (17:12 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5604 :

A small patch to add color rules for ICMPv6 Error (some error as ICMP(v4)..)

With this patch, Wireshark is ready for IPv6 Day ;)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35611 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5603 :
morriss [Fri, 21 Jan 2011 17:08:35 +0000 (17:08 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5603 :

Following the discussion on the dev mailing list about ett_ value in subtree
http://www.wireshark.org/lists/wireshark-dev/201101/msg00039.html

a small to update the Readme Developer Guide !

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35610 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago- Wrong element type used.
etxrab [Fri, 21 Jan 2011 14:03:42 +0000 (14:03 +0000)]
- Wrong element type used.
- Use match_strval_idx_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35609 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse EXTRANEOUS_DATA_CHECK_EXPERT
etxrab [Fri, 21 Jan 2011 09:31:25 +0000 (09:31 +0000)]
Use EXTRANEOUS_DATA_CHECK_EXPERT

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35608 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMove sgsap_elem_idx_t to packet-gsm_a_common.h
etxrab [Fri, 21 Jan 2011 09:26:29 +0000 (09:26 +0000)]
Move sgsap_elem_idx_t to packet-gsm_a_common.h
Dissect Global-CN-Id

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35607 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCN-Id is two bytes.
etxrab [Fri, 21 Jan 2011 09:24:43 +0000 (09:24 +0000)]
CN-Id is two bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35606 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Tobias Klauser:
etxrab [Fri, 21 Jan 2011 06:30:55 +0000 (06:30 +0000)]
From Tobias Klauser:
Fix standard to IEC62439 Part 3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5599

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35605 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix typos
etxrab [Fri, 21 Jan 2011 06:27:08 +0000 (06:27 +0000)]
Fix typos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35604 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoThere's no need to pass the result of tvb_get_ptr() as the 'value' in
morriss [Fri, 21 Jan 2011 03:00:31 +0000 (03:00 +0000)]
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35603 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoIntroduce, and start using, tvb_eth_to_str().
morriss [Fri, 21 Jan 2011 02:48:55 +0000 (02:48 +0000)]
Introduce, and start using, tvb_eth_to_str().

Export tvb_*_to_str() and put them in alphabetical order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35602 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse tvb_ip_to_str()
morriss [Fri, 21 Jan 2011 02:25:30 +0000 (02:25 +0000)]
Use tvb_ip_to_str()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35601 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdress => Address corrections (also in comments).
sake [Fri, 21 Jan 2011 00:19:03 +0000 (00:19 +0000)]
Adress => Address corrections (also in comments).

(see bug 5600)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35600 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAllow presentation of Gauge32 values larger than 0x7FFFFFFF.
jake [Thu, 20 Jan 2011 20:04:39 +0000 (20:04 +0000)]
Allow presentation of Gauge32 values larger than 0x7FFFFFFF.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35599 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix the dead initialization warnings found by clang's static analysis
sfisher [Thu, 20 Jan 2011 18:56:11 +0000 (18:56 +0000)]
Fix the dead initialization warnings found by clang's static analysis
("Value stored to 'xxx' during its initialization is never read")

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35598 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix typos
etxrab [Thu, 20 Jan 2011 14:03:13 +0000 (14:03 +0000)]
Fix typos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35597 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUpdate a comment.
etxrab [Thu, 20 Jan 2011 13:19:26 +0000 (13:19 +0000)]
Update a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35596 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoIn MM context the container contains IE:s not a complete
etxrab [Thu, 20 Jan 2011 13:05:17 +0000 (13:05 +0000)]
In MM context the container contains IE:s not a complete
DTAP message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5598

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35595 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAllow for expert items to be actually attached somewhere.
jake [Thu, 20 Jan 2011 08:58:03 +0000 (08:58 +0000)]
Allow for expert items to be actually attached somewhere.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35594 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRoll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (instead
morriss [Thu, 20 Jan 2011 03:49:44 +0000 (03:49 +0000)]
Roll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (instead
of going through a temporary variable).  This just makes it more obvious which
add_bytes_format() calls are or are not being given pointers into the TVB.

Use tvb_ip_to_str() and tvb_ip6_to_str() in a couple spots.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35593 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd a note to the top about r35589's change of the ADDCARRY(x) macro.
sfisher [Wed, 19 Jan 2011 22:57:19 +0000 (22:57 +0000)]
Add a note to the top about r35589's change of the ADDCARRY(x) macro.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35592 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't stop calling subdissectors when there's no tree.
jake [Wed, 19 Jan 2011 22:55:53 +0000 (22:55 +0000)]
Don't stop calling subdissectors when there's no tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35591 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse Wireshark standard marking for unused parameters.
jake [Wed, 19 Jan 2011 22:53:46 +0000 (22:53 +0000)]
Use Wireshark standard marking for unused parameters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35590 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoChange the ADDCARRY(x) macro to eliminate clang warning about unused
sfisher [Wed, 19 Jan 2011 22:53:38 +0000 (22:53 +0000)]
Change the ADDCARRY(x) macro to eliminate clang warning about unused
result from the ADDCARRY portion of the REDUCE macro.

-#define ADDCARRY(x)  (x > 65535 ? x -= 65535 : x)
+#define ADDCARRY(x)  {if ((x) > 65535) (x) -= 65535;}

The new code is from in_cksum.c in the Tahoe/CGI port of 4.4BSD-Lite2 (we're
using the "Portable Version" copy otherwise).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35589 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoSimply this:
sfisher [Wed, 19 Jan 2011 21:51:30 +0000 (21:51 +0000)]
Simply this:

    #define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN ((gint)strlen (SIP2_HDR))

To this:

    #define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN 7

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35588 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix warning found by clang...
sfisher [Wed, 19 Jan 2011 21:45:54 +0000 (21:45 +0000)]
Fix warning found by clang...

packet-dcerpc.c:4056:19: error: comparison of integers of different signs:
      'guint32' (aka 'unsigned int') and 'int' [-Wsign-compare]
    for (i = 0; i < (int) commands_nb; ++i) {
                ~ ^ ~~~~~~~~~~~~~~~~~

... by removing the "(int)" cast

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35587 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte:
jake [Wed, 19 Jan 2011 20:57:39 +0000 (20:57 +0000)]
From Alexis La Goutte:
A patch to enhance the ICMPv6 dissector
- Make ICMP Type (sub)field filterable
- Add Inverse Neighbor Discovery (RFC 3122)
- Remove dependency to packet-ipv6.h
- Cleanup packet-ipv6.h
- Update RFC Draft to draft-ietf-roll-rpl-17 (with make a sub dissector
  for RPL Control and add Secure RPL...)
- Replace tvb_get_ipv6/ip6_to_str by new function tvb_ip6_to_str
- and other enchancements.....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35586 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCast the returned value from strlen() to an int to make the Windows 64-bit
sfisher [Wed, 19 Jan 2011 19:42:00 +0000 (19:42 +0000)]
Cast the returned value from strlen() to an int to make the Windows 64-bit
buildbot happy.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35585 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Cal Turney via enhancement bug #5587: In hex or string searches of the
sfisher [Wed, 19 Jan 2011 18:21:21 +0000 (18:21 +0000)]
From Cal Turney via enhancement bug #5587: In hex or string searches of the
packet data highlight the target rather than the entire field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35584 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Cal Turney via bug #5585: When searching in packet bytes, the field and
sfisher [Wed, 19 Jan 2011 17:58:53 +0000 (17:58 +0000)]
From Cal Turney via bug #5585: When searching in packet bytes, the field and
bytes are not immediately shown.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35583 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix the broken Edit Menu when UImanager is used.
etxrab [Wed, 19 Jan 2011 14:55:15 +0000 (14:55 +0000)]
Fix the broken Edit Menu when UImanager is used.
(UnmarkAllDisplayedPackets)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35582 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agopacket-bssgp.c:6916: warning: 'bssgp_tree' may be used uninitialized in this function
etxrab [Wed, 19 Jan 2011 09:49:36 +0000 (09:49 +0000)]
packet-bssgp.c:6916: warning: 'bssgp_tree' may be used uninitialized in this function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35581 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCleaned up splitt between old and new dissection style.
etxrab [Wed, 19 Jan 2011 09:35:34 +0000 (09:35 +0000)]
Cleaned up splitt between old and new dissection style.
A lot of conversion still needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35580 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd the RAI value to "add_string"
etxrab [Wed, 19 Jan 2011 06:43:28 +0000 (06:43 +0000)]
Add the RAI value to "add_string"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35579 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoTry to enhance output at ValueError to ease debugging.
etxrab [Wed, 19 Jan 2011 06:33:33 +0000 (06:33 +0000)]
Try to enhance output at ValueError to ease debugging.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35578 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUpdated to OMA-TS-ULP-V2_0-20100806-D
etxrab [Wed, 19 Jan 2011 06:27:50 +0000 (06:27 +0000)]
Updated to OMA-TS-ULP-V2_0-20100806-D
with asn1 files from eyimjia.
Files hand edited to pass as2wrs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5593
(Does not fix the bug)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35577 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoIntroduce EXTRANEOUS_DATA_CHECK_EXPERT
etxrab [Tue, 18 Jan 2011 20:16:56 +0000 (20:16 +0000)]
Introduce EXTRANEOUS_DATA_CHECK_EXPERT
which adds an expert item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35576 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agodumpcap failed to link - add glib2 and wsutil libraries to fix this.
jmayer [Tue, 18 Jan 2011 17:49:41 +0000 (17:49 +0000)]
dumpcap failed to link - add glib2 and wsutil libraries to fix this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35575 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd another item.
gerald [Mon, 17 Jan 2011 22:23:35 +0000 (22:23 +0000)]
Add another item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35574 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoHandle two length octets correctly in TELV.
etxrab [Mon, 17 Jan 2011 21:12:30 +0000 (21:12 +0000)]
Handle two length octets correctly in TELV.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35573 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago- append TLLI value.
etxrab [Mon, 17 Jan 2011 21:10:54 +0000 (21:10 +0000)]
- append TLLI value.
- Whitespace changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35572 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago(Until Anders comletes work): use #if 0 instead of //; init a variable;
wmeier [Mon, 17 Jan 2011 16:51:31 +0000 (16:51 +0000)]
(Until Anders comletes work): use #if 0 instead of //; init a variable;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35571 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRemove redundant test for a non-null pointer;
wmeier [Mon, 17 Jan 2011 16:36:52 +0000 (16:36 +0000)]
Remove redundant test for a non-null pointer;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35570 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoActually use proto_tree_add_item() instead of proto_tree_add_ether(). I hope I didn...
morriss [Mon, 17 Jan 2011 15:22:11 +0000 (15:22 +0000)]
Actually use proto_tree_add_item() instead of proto_tree_add_ether().  I hope I didn't miss more of these...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35569 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago- Use correct data pointer during a comparison.
martinm [Mon, 17 Jan 2011 15:01:22 +0000 (15:01 +0000)]
- Use correct data pointer during a comparison.
- Add expert info to show when DRX command is received
- Get rid of some tabs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35568 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRestore dissection of Mobile Identity(revert the code).
etxrab [Mon, 17 Jan 2011 14:18:54 +0000 (14:18 +0000)]
Restore dissection of Mobile Identity(revert the code).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35567 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago- Remove debug printout.
etxrab [Mon, 17 Jan 2011 13:09:08 +0000 (13:09 +0000)]
- Remove debug printout.
- Enhance dissection a bit.
- add new true_false_strings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35566 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDo Windows compile with /WX flag: treat warnings as errors.
wmeier [Sun, 16 Jan 2011 23:47:05 +0000 (23:47 +0000)]
Do Windows compile with /WX flag: treat warnings as errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35565 f5534014-38df-0310-8fa8-9805f1628bb7