ulfl [Fri, 5 Aug 2005 09:20:48 +0000 (09:20 +0000)]
note that calling distclean target should be done first
add the MSVC tools to the verify_tools target, add some explanation of common problems
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15221
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 5 Aug 2005 08:34:47 +0000 (08:34 +0000)]
verify_tools:
- not only look for the cygwin tools, but also check the MSVC tools required like cl.exe, link.exe and nmake.exe
- I don't know why we should use /usr/bin/find but simply find, check for it instead. If there's a reason to use /usr/bin/find, we should use $(FIND) instead but I currently don't see a reason for this
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15220
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 5 Aug 2005 00:29:34 +0000 (00:29 +0000)]
Add eol-style and keywords properties
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15219
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 5 Aug 2005 00:23:22 +0000 (00:23 +0000)]
More char -> const char warning fixes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15218
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 5 Aug 2005 00:23:08 +0000 (00:23 +0000)]
Add unix makefile for work in progress GSM-SS dissector
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15217
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 4 Aug 2005 22:54:04 +0000 (22:54 +0000)]
Separate declaration from initialization with non-static values
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15216
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 4 Aug 2005 22:37:49 +0000 (22:37 +0000)]
Note that if you're building from a source tarball, before the first
build you must do "nmake -f makefile.make distclean".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15215
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 4 Aug 2005 22:22:53 +0000 (22:22 +0000)]
Put in comments explaining why we're removing some generated files with
"make distclean", even though they come with the distribution, and
make the one in plugins/xml/Makefile.nmake match the one in some other
files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15214
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 4 Aug 2005 22:13:33 +0000 (22:13 +0000)]
Delete some new Flex-generated files, and put in a comment explaining
that we're doing that and explaining why we're doing it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15213
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 4 Aug 2005 21:54:00 +0000 (21:54 +0000)]
Forgot to remove gdebug.h from Makefile.common too
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15212
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 4 Aug 2005 21:40:58 +0000 (21:40 +0000)]
Don't initialize variables in their declaration with non-constant
values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15211
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 4 Aug 2005 21:31:40 +0000 (21:31 +0000)]
Albert Chin:
uses of some C99'isms which prevent compilation on
IRIX 6.5 with the SGI C compiler.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15210
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 4 Aug 2005 21:09:08 +0000 (21:09 +0000)]
Albert Chin:
Don't include epan/gdebug.h
Now that epan/gdebug.h is unused: remove it
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15209
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 4 Aug 2005 20:41:52 +0000 (20:41 +0000)]
Albert Chin:
"config.h" should always be included first. However, lemon
includes <stdio.h> first.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15208
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 4 Aug 2005 17:14:19 +0000 (17:14 +0000)]
Add items for the recent FC-FCS and RSVP bug fixes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15207
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 4 Aug 2005 17:11:32 +0000 (17:11 +0000)]
Increase the size of some variables, so that we don't overflow them. Fixes
the infinite loops in bugs 311 and 314.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15206
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 4 Aug 2005 13:54:46 +0000 (13:54 +0000)]
Exception handling fixes, and a fix to packet-frame.c,
from Richard van der Hoff.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15205
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 4 Aug 2005 10:24:33 +0000 (10:24 +0000)]
When processing records, advance the offset.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15204
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 3 Aug 2005 20:51:54 +0000 (20:51 +0000)]
Use the new fn_par functions, fix of a bug and export functions used by gsm_ss.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15203
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 3 Aug 2005 20:49:52 +0000 (20:49 +0000)]
First checkin of asn2eth generated gsm ss dissector - work in progress not ready to replace the existing
dissector yet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15202
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 3 Aug 2005 20:37:28 +0000 (20:37 +0000)]
From Richard van der Hoff:
Among the improvements are:
- fixes to call-tracking (it's now less likely to confuse two separate
calls, for instance)
- improvements to Information Element dissection (clearer dissection,
dissects more IE types, easier to extend)
- you can now filter on the content of DTMF packets
- Analysis of timestamps (calculation of absolute timestamp, and packet
lateness).
- fixed a couple of assertion failures in subtle corner-cases.
negative relative times:
- get_timedelta()
- addtime()
- ftype-time.c:relative_val_from_unparsed()
I've also moved get_timedelta() and addtime() out of calldata.c into a
new file, epan/nstime.c, as I needed to use them in a dissector I'm
working on (and they therefore needed to go into libethereal).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15201
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 3 Aug 2005 17:32:00 +0000 (17:32 +0000)]
Don't assume ints are 32 bits. Fixes a recent Buildbot error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15200
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 2 Aug 2005 21:16:56 +0000 (21:16 +0000)]
Fix "tvb_fake_unicode takes the lengt in number of guint16's not guint8's" fix up indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15199
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 2 Aug 2005 18:26:31 +0000 (18:26 +0000)]
After reading through the code again, the LPD
dissector wasn't susceptible to a crash. The patch at
http://cvs.fedora.redhat.com/viewcvs/rpms/ethereal/FC-4/ is unneccessary.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15198
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 2 Aug 2005 17:34:14 +0000 (17:34 +0000)]
ememify the tvb_get_string call in mmse.
the strings mmse got from tvb_get_string were never released anyway
so this would resolve significant memory leakage in mmse.
there are still memleaks in mmse but one step at a time
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15197
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 2 Aug 2005 17:24:26 +0000 (17:24 +0000)]
ememify packet-rpc call to tvb_get_string()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15196
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 2 Aug 2005 17:15:56 +0000 (17:15 +0000)]
remove a pointless g_strdup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15195
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 2 Aug 2005 15:25:41 +0000 (15:25 +0000)]
Clean up after ourselves so that we pass "distcheck" again.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15194
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 2 Aug 2005 08:42:02 +0000 (08:42 +0000)]
Explain the BoundsError and ReportedBoundsError errors a bit more, as
per Ulf Lamping's request.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15193
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 08:37:53 +0000 (08:37 +0000)]
Include .libs in svn:ignore
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15192
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 08:30:33 +0000 (08:30 +0000)]
Last set of trivial fixes for "no previous declaration" warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15191
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 2 Aug 2005 07:30:38 +0000 (07:30 +0000)]
add some comments, has to be extended
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15190
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 2 Aug 2005 07:29:15 +0000 (07:29 +0000)]
add some minor comments around the GTK main loop
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15189
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 2 Aug 2005 07:26:57 +0000 (07:26 +0000)]
bugfix: in an attepmt to fix a crash while doing reassemling of connection oriented packets, some weeks ago I've added some tvb_ensure_bytes_exist() calls to test the case that the alloc_hint value is bogus (found in private fuzz testing).
Unfortunately, this is *very* safe now as it will mark a lot of DCE/RPC packets as malformed, thus the reassembling code won't work with most packets :-(
I've replaced this with the correct check and used THROW(ReportedBoundsError) instead which is hopefully the right error in this case.
BTW: could someone please add a description of the ReportedBoundsError vs. BoundsError to the code as I still don't get it.
In addition: Use a toplevel tree item to display the DCE/RPC defragmentation just as it's done in the TCP desegmentation code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15188
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 07:03:46 +0000 (07:03 +0000)]
Make aclocal-flags executable again (hopefully fixes buildbot fc4)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15187
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 06:44:18 +0000 (06:44 +0000)]
Fix svn properties where needed:
Add svn:eol-style
Add svn:keywords
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15186
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 06:39:04 +0000 (06:39 +0000)]
Fix svn properties where needed:
Remove svn:executable
Add svn:executable
Add svn:eol-style
Add svn:keywords
Add mime-type
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15185
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 06:29:49 +0000 (06:29 +0000)]
Fix svn properties where needed:
Remove svn:executable
Add svn:executable
Add svn:eol-style
Add svn:keywords
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15184
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 06:15:02 +0000 (06:15 +0000)]
Fix svn properties where needed:
Remove svn:executable
Add svn:executable
Add svn:eol-style
Add svn:keywords
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15183
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 05:58:15 +0000 (05:58 +0000)]
Fix svn properties where needed:
Remove svn:executable
Add svn:executable
Add svn:eol-style
Add svn:keywords
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15182
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 05:51:38 +0000 (05:51 +0000)]
Fix svn properties where needed:
Remove svn:executable
Add svn:eol-style
Add svn:keywords
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15181
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 05:46:16 +0000 (05:46 +0000)]
Remove svn:executable
Add svn:eol-style native
Add svn:keywords Id
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15180
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 05:39:45 +0000 (05:39 +0000)]
Some warning fixes for "no previous declaration"
Remove svn:executable
Add svn:eol-style native
Add svn:keywords Id
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15179
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 05:21:19 +0000 (05:21 +0000)]
Fix svn properties where needed:
Remove svn:executable
Add svn:eol-style
Add svn:keywords
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15178
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 05:17:00 +0000 (05:17 +0000)]
set svn:eol-style and svn:keywords
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15177
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 05:12:23 +0000 (05:12 +0000)]
It's svn:eol-style, not eol-style
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15176
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 05:09:41 +0000 (05:09 +0000)]
Fix "no previous declaration" warnings
Remove trailing ^M (cr) from some files
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15175
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 04:57:58 +0000 (04:57 +0000)]
Fix more "no previous declaration" warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15174
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 04:47:15 +0000 (04:47 +0000)]
Fix more "no previous declaration" warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15173
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 04:35:40 +0000 (04:35 +0000)]
Fix more "no previous declaration" warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15172
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 04:34:35 +0000 (04:34 +0000)]
Fix more "no previous declaration" warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15171
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 04:32:33 +0000 (04:32 +0000)]
Fix more "no previous declaration" warnings - the forgotten files
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15170
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 04:31:42 +0000 (04:31 +0000)]
Fix more "no previous declaration" warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15169
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 2 Aug 2005 04:23:39 +0000 (04:23 +0000)]
Include the .h files into the .c files. That way we
a) get rid of warnings of type "no previous declaration" and
b) make sure that declaration and implementation are in sync.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15168
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 1 Aug 2005 21:09:34 +0000 (21:09 +0000)]
Make sure "lemon" exists before we try to use it. This can happen if we
run "make dist" before running "make".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15167
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 1 Aug 2005 19:51:06 +0000 (19:51 +0000)]
The .spec file now refers to "ethereal.desktop". Link to it when we
create our RPMs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15166
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 1 Aug 2005 18:04:37 +0000 (18:04 +0000)]
Update RPM builds.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15165
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 1 Aug 2005 13:53:50 +0000 (13:53 +0000)]
Add notes about the LPD and ISAKMP bugs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15164
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 1 Aug 2005 13:52:22 +0000 (13:52 +0000)]
Break out of a loop before we exhaust system memory.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15163
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Mon, 1 Aug 2005 08:46:09 +0000 (08:46 +0000)]
- update ftam.cnf for new asn2eth compiler
- usage of #.FN_PARS in h225 and h245 dissectors
- PER dissectors regenerated
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15162
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Mon, 1 Aug 2005 08:40:13 +0000 (08:40 +0000)]
- fix name handling of imported types
- #.FN_PARS implemented for TypeRef, SET, SEQUENCE, CHOICE
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15161
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 31 Jul 2005 20:42:48 +0000 (20:42 +0000)]
From Martin Mathieson
- Makes more of the header fields filterable
- Rationalises a bit the way header lines are parsed
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15160
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 31 Jul 2005 20:36:59 +0000 (20:36 +0000)]
From Martin Mathieson:
This update:
- adds more command parameter details
- doesn't clutter the tree with unknown fields
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15159
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 30 Jul 2005 16:34:38 +0000 (16:34 +0000)]
More char -> const char fixes
Declare some functions static
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15158
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 30 Jul 2005 16:28:00 +0000 (16:28 +0000)]
Include .h into .c to make sure declarations match.
Fix a copy/paste in the .h surrounding ifndef.
One char -> const char fix.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15157
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 30 Jul 2005 16:15:23 +0000 (16:15 +0000)]
Stefan Rompf:
Fix warnings of type:
proto.c:2219: warning: ISO C forbids conditional expr with only one void side
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15156
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 30 Jul 2005 07:13:27 +0000 (07:13 +0000)]
More char -> const char warning fixes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15155
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 30 Jul 2005 07:08:04 +0000 (07:08 +0000)]
Create packet-dcom-cba-acco.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15154
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 30 Jul 2005 02:44:20 +0000 (02:44 +0000)]
Make dissect_CBA_Connection_Data again available for plugins (although
it should be declared in a header file, so that the plugins can #include
the header file rather than using a possibly-out-of-date private
declaration, and so that it's clearer that it shouldn't be static).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15153
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 30 Jul 2005 02:30:05 +0000 (02:30 +0000)]
Fix 'isn't prototype' warning
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15152
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 30 Jul 2005 02:22:22 +0000 (02:22 +0000)]
Clean up some more const issues.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15151
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 30 Jul 2005 02:20:59 +0000 (02:20 +0000)]
Get rid of another unused variable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15150
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 30 Jul 2005 02:09:59 +0000 (02:09 +0000)]
Widen a variable, as a guint16 value is assigned to it; the upper 8 bits
might be irrelevant in this case, but we might as well not throw them
out.
Clean up some code that sets "cdata->flags".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15149
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 30 Jul 2005 02:07:36 +0000 (02:07 +0000)]
Get rid of some unused variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15148
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 30 Jul 2005 02:06:13 +0000 (02:06 +0000)]
Declare the value_string tables as arrays of value_strings, not of
pointers to same, and make them "const" while we're at it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15147
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 30 Jul 2005 01:01:02 +0000 (01:01 +0000)]
Make some funtions static. More char -> const char warning fixes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15146
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 30 Jul 2005 00:59:08 +0000 (00:59 +0000)]
Remove packet-fcse.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15145
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 30 Jul 2005 00:55:30 +0000 (00:55 +0000)]
Declare many functions static, move the #defines from packet-fcse.h to
packet-fcse.c and remove packet-fcse.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15144
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 29 Jul 2005 21:55:45 +0000 (21:55 +0000)]
Pick up some fixes and enhancements from
http://cvs.fedora.redhat.com/viewcvs/rpms/ethereal/FC-4/:
In the LPD dissector, make lpd_client_code a value_string so that we
don't segfault. Do the same for lpd_server_code, although it's not
strictly necessary.
Check to see if htmlview is installed, and use it as our HTML viewer.
The Fedora RPM has other patches, but I'm not sure if they should
be applied.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15143
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 29 Jul 2005 10:00:37 +0000 (10:00 +0000)]
some more ememification of tvb_get_string()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15142
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jul 2005 07:35:43 +0000 (07:35 +0000)]
Suggest that perhaps displaying chunks in the chunked encoding with the
data dissector might be overkill, as it causes each of those chunks to
be dumped in hex in Tethereal output - along with whatever's done with
the data reassembled from those chunks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15141
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jul 2005 07:28:07 +0000 (07:28 +0000)]
Use "PROTO_ITEM_SET_GENERATED()" to mark generated items as such; it
takes care of the square brackets, etc..
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15140
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jul 2005 07:14:32 +0000 (07:14 +0000)]
If we do reassembly and hand the packet to the dissector, and the
dissector says "sorry, I need even more data in this packet", don't flag
that packet as being reassembled in that frame. Indicate that we should
perhaps do all the "partial reassembly" stuff in
"fragment_set_partial_assembly()", which would obviate the need for the
hack in the TCP dissector.
Clean up indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15139
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jul 2005 03:49:23 +0000 (03:49 +0000)]
Constify some variables, functions, and structure members to squelch
compiler warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15138
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jul 2005 03:48:03 +0000 (03:48 +0000)]
Constify some variables and arguments to squelch compiler warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15137
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jul 2005 03:47:12 +0000 (03:47 +0000)]
Include <epan/emem.h> to declare ep_alloc().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15136
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jul 2005 03:27:59 +0000 (03:27 +0000)]
Cast away some (otherwise unremovable, and harmless, in this case)
warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15135
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 28 Jul 2005 14:29:19 +0000 (14:29 +0000)]
Add release notes. The content still needs to be filled in.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15134
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 28 Jul 2005 10:05:37 +0000 (10:05 +0000)]
more emeification of tvb_get_string()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15133
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 28 Jul 2005 09:56:19 +0000 (09:56 +0000)]
ememify some more calls to tvb_get_string()
this fixes an obvious memleak in ms-mms
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15132
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 28 Jul 2005 09:47:28 +0000 (09:47 +0000)]
some more memification of tvb_get_string() no obvious memleaks fixed this time :-(
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15131
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 28 Jul 2005 09:35:27 +0000 (09:35 +0000)]
ememify some more tvb_get_string() calls
one memleak in vnc related to tvb_get_string() closed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15130
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 28 Jul 2005 09:20:56 +0000 (09:20 +0000)]
ememify the tvb_get_string() and tvb_fake_unicode() calls in tds
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15129
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 28 Jul 2005 08:55:11 +0000 (08:55 +0000)]
add an ep version of tvb_fake_unicode()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15128
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 28 Jul 2005 08:18:18 +0000 (08:18 +0000)]
packet_ber has for some time been doing sanity checking of the BER Length fields
that they are not longer than the reported length of the tvb.
this triggers some bugs since in packet-ber we are a bit too lax in setting reported_length of the tvb_new_subset() tvb.
this cause short kerberos packets to not be decoded at all and the same for other short asn based packets as well.
fix some of these instances.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15127
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 28 Jul 2005 07:53:38 +0000 (07:53 +0000)]
char -> const char warning fixes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15126
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 28 Jul 2005 07:51:52 +0000 (07:51 +0000)]
Warning fixes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15125
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 28 Jul 2005 07:50:31 +0000 (07:50 +0000)]
Updated Ankur Aggarwal's entry
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15124
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 28 Jul 2005 07:49:55 +0000 (07:49 +0000)]
Add Extreme stuff
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15123
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 27 Jul 2005 18:38:35 +0000 (18:38 +0000)]
Squelch another qualifier warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15122
f5534014-38df-0310-8fa8-
9805f1628bb7