obnox/wireshark/wip.git
11 years agoIf we have pcap_open, call it instead of pcap_open_live, otherwise we might
gerald [Mon, 12 May 2008 19:41:32 +0000 (19:41 +0000)]
If we have pcap_open, call it instead of pcap_open_live, otherwise we might
crash. The changes to trigcap.c haven't been tested, but _should_ work.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25279 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate to WpdPack 4.0.2 and NASM 2.02
kukosa [Mon, 12 May 2008 19:13:55 +0000 (19:13 +0000)]
Update to WpdPack 4.0.2 and NASM 2.02

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25278 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoHS-DSCH type 2 bug fix + prettification.
martinm [Mon, 12 May 2008 16:25:49 +0000 (16:25 +0000)]
HS-DSCH type 2 bug fix + prettification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25277 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agog_string_sprintf --> g_string_printf and g_string_sprintfa --> g_string_append_printf
wmeier [Sun, 11 May 2008 18:33:49 +0000 (18:33 +0000)]
g_string_sprintf --> g_string_printf and g_string_sprintfa --> g_string_append_printf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25276 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSort list before thaw to avoid flicker when doing capture.
stig [Sun, 11 May 2008 18:03:22 +0000 (18:03 +0000)]
Sort list before thaw to avoid flicker when doing capture.
Save pane size in recent.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25275 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix some of the Errors/warnings detected by checkapi
wmeier [Sun, 11 May 2008 17:27:41 +0000 (17:27 +0000)]
Fix some of the Errors/warnings detected by checkapi

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25274 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoConvert C++ style comments ...
wmeier [Sun, 11 May 2008 17:18:59 +0000 (17:18 +0000)]
Convert C++ style comments ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25273 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd define for new channel type.
martinm [Sun, 11 May 2008 01:09:30 +0000 (01:09 +0000)]
Add define for new channel type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25272 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded HS-DSCH data frame type 2 (currently only compile-tested).
martinm [Sun, 11 May 2008 00:46:25 +0000 (00:46 +0000)]
Added HS-DSCH data frame type 2 (currently only compile-tested).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25271 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Hans-Peter Bock:
jake [Sat, 10 May 2008 14:44:32 +0000 (14:44 +0000)]
From Hans-Peter Bock:
Attached to this post you find a patch for integration into wireshark that adds
a dissector for SERCOS III, ethertype 0x88cd.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25270 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Steve Karg:
jake [Sat, 10 May 2008 06:25:07 +0000 (06:25 +0000)]
From Steve Karg:
Corrected decode of a BACnet ReadRange request with no range specified (i.e. all)
which showed â€˜malformed packet’ in the decoder.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25269 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRedo the loops a bit; that fixes an uninitialized variable, and moves
guy [Fri, 9 May 2008 18:45:22 +0000 (18:45 +0000)]
Redo the loops a bit; that fixes an uninitialized variable, and moves
the increments a bit closer to the point of use.

(XXX - is there more than one place where we turn a sequence of hex
digits into a string?  If so, we should make it a common utility.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25268 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd a couple of missing HS-DSCH data frame fields.
martinm [Fri, 9 May 2008 17:46:45 +0000 (17:46 +0000)]
Add a couple of missing HS-DSCH data frame fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25267 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoNull-terminate the hex-to-text-converted string.
guy [Fri, 9 May 2008 16:30:05 +0000 (16:30 +0000)]
Null-terminate the hex-to-text-converted string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25266 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agosprintf() and strtoul() are massive overkill for turning a string of hex
guy [Fri, 9 May 2008 16:15:22 +0000 (16:15 +0000)]
sprintf() and strtoul() are massive overkill for turning a string of hex
digits into a string of characters; use g_ascii_xdigit_value() to
convert individual hex digit characters to their hex value - and check
whether it succeeds or not, so we catch invalid hex digits! - and just
append the resulting byte value to the string.

Handle the case where compute_ascii_key() fails.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25265 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix some of the Errors/warnings detected by checkapi.
etxrab [Fri, 9 May 2008 13:59:10 +0000 (13:59 +0000)]
Fix some of the Errors/warnings detected by checkapi.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25264 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix a typo: strl -> strlen
stig [Fri, 9 May 2008 12:55:37 +0000 (12:55 +0000)]
Fix a typo: strl -> strlen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25263 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInclude string.h
stig [Fri, 9 May 2008 12:54:49 +0000 (12:54 +0000)]
Include string.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25262 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix some of the Errors/warnings detected by checkapi.
etxrab [Fri, 9 May 2008 11:59:44 +0000 (11:59 +0000)]
Fix some of the Errors/warnings detected by checkapi.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25261 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUse PROTO_ITEM_SET_HIDDEN().
etxrab [Fri, 9 May 2008 07:07:50 +0000 (07:07 +0000)]
Use PROTO_ITEM_SET_HIDDEN().
Fix ID marking
Add checkapi to makefiles

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25260 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRun checkAPI in plugins dir.
etxrab [Thu, 8 May 2008 18:24:08 +0000 (18:24 +0000)]
Run checkAPI in plugins dir.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25259 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoStop using deprecated functions identified by checkAPIs script.
martinm [Thu, 8 May 2008 14:01:31 +0000 (14:01 +0000)]
Stop using deprecated functions identified by checkAPIs script.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25258 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Anders: Checkapi enabled for wiretap and more functions converted.
martinm [Thu, 8 May 2008 09:37:11 +0000 (09:37 +0000)]
From Anders:  Checkapi enabled for wiretap and more functions converted.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25257 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUse g_strlcpy() rather than strcpy(), strncpy().
martinm [Thu, 8 May 2008 09:17:04 +0000 (09:17 +0000)]
Use g_strlcpy() rather than strcpy(), strncpy().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25256 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUse PROTO_ITEM_SET_HIDDEN().
etxrab [Thu, 8 May 2008 05:42:59 +0000 (05:42 +0000)]
Use PROTO_ITEM_SET_HIDDEN().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25255 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agostrncpy -> g_strlcpy
etxrab [Thu, 8 May 2008 05:16:33 +0000 (05:16 +0000)]
strncpy -> g_strlcpy

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25254 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix a few typos ....
wmeier [Wed, 7 May 2008 17:57:45 +0000 (17:57 +0000)]
Fix a few typos ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25253 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoEnable PCAP_REMOTE by default
kukosa [Wed, 7 May 2008 13:15:24 +0000 (13:15 +0000)]
Enable PCAP_REMOTE by default

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25252 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSelect correct bytes range for Algorithms tree.
martinm [Wed, 7 May 2008 10:22:48 +0000 (10:22 +0000)]
Select correct bytes range for Algorithms tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25251 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoComment out condition which is always true (based on the
tuexen [Wed, 7 May 2008 06:23:03 +0000 (06:23 +0000)]
Comment out condition which is always true (based on the
choosen data types).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25250 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Peter Kjellerstedt:
jake [Wed, 7 May 2008 05:58:42 +0000 (05:58 +0000)]
From Peter Kjellerstedt:
For some reason only the first eight interleaved RTSP channels are supported by
epan/dissectors/packet-rtsp.c. This is a problem for us as one of our servers use
the channel numbers in a round robin fashion and will thus use all 256 channels.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25249 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix some of the Errors/warnings detected by checkapi.
etxrab [Wed, 7 May 2008 05:26:40 +0000 (05:26 +0000)]
Fix some of the Errors/warnings detected by checkapi.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25248 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoved an unused break.
stig [Tue, 6 May 2008 15:12:45 +0000 (15:12 +0000)]
Removed an unused break.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25247 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Peter Kjellerstedt (bug 2521):
stig [Tue, 6 May 2008 09:08:52 +0000 (09:08 +0000)]
From Peter Kjellerstedt (bug 2521):
Add MARKER_COM to vals_marker[].

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25246 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd checkapi target.
etxrab [Tue, 6 May 2008 06:18:26 +0000 (06:18 +0000)]
Add checkapi target.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25245 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix some of the Errors/warnings detected by checkapi.
etxrab [Tue, 6 May 2008 05:50:31 +0000 (05:50 +0000)]
Fix some of the Errors/warnings detected by checkapi.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25244 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRequire GLib 2.4 or later.
guy [Mon, 5 May 2008 22:47:32 +0000 (22:47 +0000)]
Require GLib 2.4 or later.

That means that G_GINT64_MODIFIER will be defined, so don't check
whether it's defined.

We don't use the PRI[douxX]64 macros, as we use the GLib print routines
and thus use G_GINT64_MODIFIER instead.  Get rid of the checks for
whether inttypes.h defines PRI[douxX]64; just check whether it exists at
all.

That means we don't set INTTYPES_H_DEFINES_FORMATS, so don't check for
it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25243 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoBoost the automake version required to 1.9.
guy [Mon, 5 May 2008 22:01:34 +0000 (22:01 +0000)]
Boost the automake version required to 1.9.

(Currently, configure.in also specifies the minimum autoconf and
automake versions, but the check for the automake version doesn't
produce an immediate failure - instead, you might get a flood of

configure.in:16: option `tar-ustar' not recognized

errors *after*

configure.in:16: require version 1.9, but have 1.x.x

and the diagnostic isn't as clear.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25242 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRequire automake 1.9 or later; earlier versions don't support the
guy [Mon, 5 May 2008 21:48:32 +0000 (21:48 +0000)]
Require automake 1.9 or later; earlier versions don't support the
"tar-ustar" option.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25241 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix some of the Errors/warnings detected by checkapi,
etxrab [Mon, 5 May 2008 20:38:27 +0000 (20:38 +0000)]
Fix some of the Errors/warnings detected by checkapi,
make non ASCII char a warning for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25240 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoChange depreciated function g_tree_traverse -> g_tree_foreach
etxrab [Mon, 5 May 2008 20:03:15 +0000 (20:03 +0000)]
Change depreciated function g_tree_traverse -> g_tree_foreach

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25239 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemove depreciated functions g_string_sprint, g_string_sprintfa.
etxrab [Mon, 5 May 2008 19:52:59 +0000 (19:52 +0000)]
Remove depreciated functions g_string_sprint, g_string_sprintfa.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25238 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoHandle SSID as binary in WLAN Traffic Statistics.
stig [Mon, 5 May 2008 19:35:16 +0000 (19:35 +0000)]
Handle SSID as binary in WLAN Traffic Statistics.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25237 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd Id tag.
etxrab [Mon, 5 May 2008 19:06:31 +0000 (19:06 +0000)]
Add Id tag.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25236 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDon't use proto_tree_add_item_hidden().
etxrab [Mon, 5 May 2008 18:58:53 +0000 (18:58 +0000)]
Don't use proto_tree_add_item_hidden().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25235 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemove gtk/isprint.h as it's not in use.
stig [Mon, 5 May 2008 18:37:20 +0000 (18:37 +0000)]
Remove gtk/isprint.h as it's not in use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25234 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDount use proto_tree_add_item_hidden().
etxrab [Mon, 5 May 2008 17:19:51 +0000 (17:19 +0000)]
Dount use proto_tree_add_item_hidden().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25233 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoHave autoconf generate "ustar" tar files by default. This should let us have
gerald [Mon, 5 May 2008 17:03:22 +0000 (17:03 +0000)]
Have autoconf generate "ustar" tar files by default. This should let us have
paths longer than 99 characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25232 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake it possible to run checkapi on all plugins trough makefile.nmake
etxrab [Mon, 5 May 2008 16:55:19 +0000 (16:55 +0000)]
Make it possible to run checkapi on all plugins trough makefile.nmake
Note: Commented out in the plugins giving errors for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25231 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd depreceated glib API:s
etxrab [Mon, 5 May 2008 06:27:15 +0000 (06:27 +0000)]
Add depreceated glib API:s

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25230 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Gerhard Olsson :
etxrab [Mon, 5 May 2008 05:58:45 +0000 (05:58 +0000)]
From   Gerhard Olsson :
X25 reassembly when presenting out of order packets
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2091

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25229 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReplace leading spaces by a TAB
jmayer [Mon, 5 May 2008 00:41:30 +0000 (00:41 +0000)]
Replace leading spaces by a TAB

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25228 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix a tpyo
jmayer [Mon, 5 May 2008 00:39:47 +0000 (00:39 +0000)]
Fix a tpyo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25227 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoImproved the WLAN Traffic Statistics:
stig [Sun, 4 May 2008 22:37:05 +0000 (22:37 +0000)]
Improved the WLAN Traffic Statistics:
- Added details for each network
- Added context menu for adding a filter
- Keep the selected network when capturing
- Show probe requests with broadcast ssid
- Print '.' for non-printable characters in ssid

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25226 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCorrected some unused arguments in case someone starts using them,
stig [Sun, 4 May 2008 22:29:41 +0000 (22:29 +0000)]
Corrected some unused arguments in case someone starts using them,
or just copy the code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25225 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded a hidden SSID (wlan_mgt.ssid) to be able to filter on the ssid.
stig [Sun, 4 May 2008 22:20:58 +0000 (22:20 +0000)]
Added a hidden SSID (wlan_mgt.ssid) to be able to filter on the ssid.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25224 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug #2518: 'tshark -Tfields -e data' Omits Last Character of Data
wmeier [Sat, 3 May 2008 22:33:51 +0000 (22:33 +0000)]
Fix for bug #2518: 'tshark -Tfields -e data' Omits Last Character of Data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25223 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Abhik Sarkar:
jake [Sat, 3 May 2008 09:49:10 +0000 (09:49 +0000)]
From Abhik Sarkar:
This patch adds basic support for stats to the UCP dissector using the Stats Tree API.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25222 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Steve Karg:
jake [Sat, 3 May 2008 08:31:50 +0000 (08:31 +0000)]
From Steve Karg:
Corrected packet-bvlc.c dissector which was not decoding BACnet BVLC NAK result
code text correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25221 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInitialise variable.
martinm [Fri, 2 May 2008 21:38:49 +0000 (21:38 +0000)]
Initialise variable.
(sorry about the build breakage, these new message formats will be tested soon
and it looks like I forgot to compile-test the last change I made...).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25220 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix (what I presume to be) a typo to prevent compile error.
wmeier [Fri, 2 May 2008 19:18:08 +0000 (19:18 +0000)]
Fix (what I presume to be) a typo to prevent compile error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25219 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix crash in Bug #2410: restore saved 'packet_info.private_data' for two fail returns
wmeier [Fri, 2 May 2008 19:03:00 +0000 (19:03 +0000)]
Fix crash in Bug #2410: restore saved 'packet_info.private_data' for two fail returns

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25218 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMore R7 additions.
martinm [Fri, 2 May 2008 15:27:00 +0000 (15:27 +0000)]
More R7 additions.
Main missing part is new HSDSCH data frame type 2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25217 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdated common control messages to R7.
martinm [Fri, 2 May 2008 14:50:23 +0000 (14:50 +0000)]
Updated common control messages to R7.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25216 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoEnsure wireshark-filter doc rebuilt when tshark changes; optimize rebuild slightly
wmeier [Fri, 2 May 2008 12:58:15 +0000 (12:58 +0000)]
Ensure wireshark-filter doc rebuilt when tshark changes; optimize rebuild slightly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25215 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Shinsuke SUZUKI:
jake [Fri, 2 May 2008 08:23:21 +0000 (08:23 +0000)]
From Shinsuke SUZUKI:
Since this leads to a compilation failure (Warning C4819: unexpected character
in the current code page) on non-european Windows, I'd like you to avoid using
non-ASCII characters in Wireshark code (even in comment).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25214 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoved a debug printf line.
stig [Thu, 1 May 2008 21:20:49 +0000 (21:20 +0000)]
Removed a debug printf line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25213 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoForce foreground when background is forced in RTP analysis and VOIP calls.
stig [Thu, 1 May 2008 18:26:01 +0000 (18:26 +0000)]
Force foreground when background is forced in RTP analysis and VOIP calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25212 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoForce foreground when background is forced in expert info dialogs.
stig [Thu, 1 May 2008 18:03:46 +0000 (18:03 +0000)]
Force foreground when background is forced in expert info dialogs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25211 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoIgnore generated (on OSX) rdps.dSYM directory.
stig [Thu, 1 May 2008 17:47:48 +0000 (17:47 +0000)]
Ignore generated (on OSX) rdps.dSYM directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25210 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWhile playing with a dark theme I found it much nicer to use the
stig [Thu, 1 May 2008 17:46:03 +0000 (17:46 +0000)]
While playing with a dark theme I found it much nicer to use the
selected background color from the packet list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25209 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoTry to track SIP responses back to their requests.
martinm [Thu, 1 May 2008 15:23:54 +0000 (15:23 +0000)]
Try to track SIP responses back to their requests.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25208 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Frederic Peters (bug 1735):
stig [Thu, 1 May 2008 11:02:14 +0000 (11:02 +0000)]
From Frederic Peters (bug 1735):
Force foreground when background is forced.

From me:
Do the same for expert info's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25207 f5534014-38df-0310-8fa8-9805f1628bb7

11 years ago...but not with a comment inside a comment, as that might cause a
guy [Thu, 1 May 2008 07:21:15 +0000 (07:21 +0000)]
...but not with a comment inside a comment, as that might cause a
warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25206 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of C++/C99 comment.
guy [Thu, 1 May 2008 07:18:58 +0000 (07:18 +0000)]
Get rid of C++/C99 comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25205 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoNow with EAP dissector safety valve.
jake [Wed, 30 Apr 2008 10:59:48 +0000 (10:59 +0000)]
Now with EAP dissector safety valve.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25204 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom cfreeer:
jake [Wed, 30 Apr 2008 09:15:50 +0000 (09:15 +0000)]
From cfreeer:
There is no EAP decoder to decode EAP messages packed in Wimax PKM messages.
I called the EAP decoder found in the Wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25203 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of extra blank lines at the end of the file.
guy [Wed, 30 Apr 2008 07:59:26 +0000 (07:59 +0000)]
Get rid of extra blank lines at the end of the file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25202 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUse report_failure() to report failures in capture_sync.c; that will do
guy [Wed, 30 Apr 2008 07:58:57 +0000 (07:58 +0000)]
Use report_failure() to report failures in capture_sync.c; that will do
the right thing in Wireshark and TShark, as both of them call
epan_init() to set the appropriate "report an error" function.

That obviates the need to have TShark have its own private version of
simple_dialog().

Have cmdarg_err() just call failure_message() instead of duplicating the
code in failure_message().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25201 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoadd some cygwin clarifications
ulfl [Wed, 30 Apr 2008 07:35:25 +0000 (07:35 +0000)]
add some cygwin clarifications

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25200 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoChange an option menu (deprecated in GTK+ 2.4) to a combo box (GTK+ 2.4+).
sfisher [Tue, 29 Apr 2008 19:14:44 +0000 (19:14 +0000)]
Change an option menu (deprecated in GTK+ 2.4) to a combo box (GTK+ 2.4+).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25199 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReplace an option menu (deprecated as of GTK+ 2.4) with a combo box
sfisher [Tue, 29 Apr 2008 18:46:10 +0000 (18:46 +0000)]
Replace an option menu (deprecated as of GTK+ 2.4) with a combo box
(GTK+ 2.4+).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25198 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAll versions of GLib 2.x come with g_ascii_strcasecmp(), and we require
guy [Tue, 29 Apr 2008 16:24:22 +0000 (16:24 +0000)]
All versions of GLib 2.x come with g_ascii_strcasecmp(), and we require
GLib 2.x; we don't have to check for its presence and supply a
replacement if it's missing.

Get rid of an unremoved reference in epan/dtd_parse.l.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25197 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCall se_free_all() in epan_cleanup() so that we will detect per-session (se_)
morriss [Tue, 29 Apr 2008 15:29:02 +0000 (15:29 +0000)]
Call se_free_all() in epan_cleanup() so that we will detect per-session (se_)
memory corruption in tshark (and Wireshark when exiting the program instead
of loading a new file?).

Why this wasn't always here I don't know.

This may give us a pile of buildbot fuzz failures but that's a Good Thing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25196 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1513 : don't tvb_memcpy()...
morriss [Tue, 29 Apr 2008 15:20:19 +0000 (15:20 +0000)]
Fix bugs.wireshark.org/bugzilla/show_bug.cgi?id=1513 : don't tvb_memcpy() more bytes than are in the (se_alloc()'d) buffer.  tvb_memcpy()ing more bytes than are the TVB is okay (it'll except out).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25195 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Abhik Sarkar, fixed bug #2477.
martinm [Tue, 29 Apr 2008 14:24:16 +0000 (14:24 +0000)]
From Abhik Sarkar, fixed bug #2477.
Change ftype of ssh-padding-string to FT_BYTES.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25194 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMove minimum byte count test from dissect_scsi_smc_element() up into the calling...
morriss [Tue, 29 Apr 2008 12:27:32 +0000 (12:27 +0000)]
Move minimum byte count test from dissect_scsi_smc_element() up into the calling dissect_scsi_smc_elements() so we can break out of the loop if we're not advancing through the packet.  This fixes the infinite loop reported in bugs.wireshark.org/bugzilla/show_bug.cgi?id=2508

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25193 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of old GLib 1.2[.x] stuff, as we now require GLib 2.x.
guy [Tue, 29 Apr 2008 08:44:57 +0000 (08:44 +0000)]
Get rid of old GLib 1.2[.x] stuff, as we now require GLib 2.x.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25192 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoHave the error for not finding GTK+ indicate that we require GTK+ 2.4 or
guy [Tue, 29 Apr 2008 08:30:39 +0000 (08:30 +0000)]
Have the error for not finding GTK+ indicate that we require GTK+ 2.4 or
later.  Do the same for the GLib error messages, having them indicate
that we require GLib 2.x.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25191 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCorrect AVP name.
etxrab [Tue, 29 Apr 2008 05:51:22 +0000 (05:51 +0000)]
Correct AVP name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25190 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix minor typo in comment
wmeier [Mon, 28 Apr 2008 20:32:06 +0000 (20:32 +0000)]
Fix minor typo in comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25189 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded flag i new recent file to determine where to get values now
stig [Mon, 28 Apr 2008 13:27:25 +0000 (13:27 +0000)]
Added flag i new recent file to determine where to get values now
moved to recent_common.  This will convert old recent file to new.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25188 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReopen the recent file when reading older common settings.
stig [Mon, 28 Apr 2008 13:00:49 +0000 (13:00 +0000)]
Reopen the recent file when reading older common settings.
This will be optimized later.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25187 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSplit the recent file in two, one for the configuration profile
stig [Mon, 28 Apr 2008 12:35:03 +0000 (12:35 +0000)]
Split the recent file in two, one for the configuration profile
and one common for all profiles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25186 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix test for unlimited credits value in new alloc format.
martinm [Mon, 28 Apr 2008 10:23:25 +0000 (10:23 +0000)]
Fix test for unlimited credits value in new alloc format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25185 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Alon Tal:
jake [Sun, 27 Apr 2008 11:10:57 +0000 (11:10 +0000)]
From Alon Tal:
RTP header extensions that are longer than 4 bytes (rtp.ext.len > 1)
get dissected incorrectly. The first 4 bytes of the header extension are
repeated rtp.ext.len times, and the remaining bytes are ignored.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25184 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd adns_dll.dep and adns_dll.rc to the tarball, as requested by Sake
stig [Sun, 27 Apr 2008 10:54:25 +0000 (10:54 +0000)]
Add adns_dll.dep and adns_dll.rc to the tarball, as requested by Sake
and indicated by Anders.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25183 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemove all GTK+ < 2.4 code and minimum version checks.
sfisher [Sun, 27 Apr 2008 07:01:58 +0000 (07:01 +0000)]
Remove all GTK+ < 2.4 code and minimum version checks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25182 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoChanged to display NCP connection, as in conversations.
stig [Fri, 25 Apr 2008 19:42:27 +0000 (19:42 +0000)]
Changed to display NCP connection, as in conversations.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25181 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRegister dissector by name.
stig [Fri, 25 Apr 2008 19:25:49 +0000 (19:25 +0000)]
Register dissector by name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25180 f5534014-38df-0310-8fa8-9805f1628bb7