obnox/wireshark/wip.git
13 years agoFrom Mike Morrin:
etxrab [Mon, 22 Nov 2010 20:24:12 +0000 (20:24 +0000)]
From Mike Morrin:
In bssmap, track L3 handover target (GSM or UMTS) between PDUs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5294

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35009 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove print_update_dynamic() decl from file_dlg_win32.h since only used in [...].c
wmeier [Mon, 22 Nov 2010 19:45:03 +0000 (19:45 +0000)]
Remove print_update_dynamic() decl from file_dlg_win32.h since only used in [...].c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35008 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Emil Wojak via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391 :
morriss [Mon, 22 Nov 2010 18:48:54 +0000 (18:48 +0000)]
From Emil Wojak via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391 :

I'd like to share my enhancements to the TDS dissector with everyone.
The list of improvements follows:
- nearly complete dissection of RPC calls,
- detection and dissection of the ALL_HEADERS rule,
- corrected some existing proto_tree fields to support filters,
- other minor fixes where the interpretation of data conflicted with the
  official documentation from MS.

I tested the new code on a variety of different TDS captures with many diverse
RPC calls. The code compiles and works on 32-bit Linux, I didn't check those
changes on other platforms though.

From me:

- terminate all value_strings
- change ++*offset to *offset += 1 (I think that's more readable)
- replace all the dissector assertions which could be caused by malformed
  packets with expert infos
- Don't throw ReportedBoundsError when the packets have unexpected data in
  them, just report an expert info and continue on

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35007 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPrevent "MS-DOS style path detected" messages for several commands (when "nodosfilewa...
wmeier [Mon, 22 Nov 2010 17:17:46 +0000 (17:17 +0000)]
Prevent "MS-DOS style path detected" messages for several commands (when "nodosfilewarning" not set).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35006 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 :
morriss [Mon, 22 Nov 2010 16:19:39 +0000 (16:19 +0000)]
From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 :

This is a dissector for reload framed message:
ReLOAD packets can be inserted in frame message, as described in
draft-ietf-p2psip-base-10

From me: remove some unnecessary includes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35005 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove faulty return, probably forgotten during test.
etxrab [Mon, 22 Nov 2010 15:02:06 +0000 (15:02 +0000)]
Remove faulty return, probably forgotten during test.
Fixing dissection on Via header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35004 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove 'keywords' property.
wmeier [Mon, 22 Nov 2010 14:59:33 +0000 (14:59 +0000)]
Remove 'keywords' property.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35003 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove 'keywords' property from a few files.
wmeier [Mon, 22 Nov 2010 14:57:58 +0000 (14:57 +0000)]
Remove 'keywords' property from a few files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35002 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd another (unsupported) channel type identifier.
martinm [Mon, 22 Nov 2010 13:37:13 +0000 (13:37 +0000)]
Add another (unsupported) channel type identifier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35001 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd sequence analysis for PDCP, based upon RLC/UM.
martinm [Mon, 22 Nov 2010 13:28:49 +0000 (13:28 +0000)]
Add sequence analysis for PDCP, based upon RLC/UM.
For now, only enable it for logged PDCP frames, i.e. not for PDCP found inside RLC (that won't work properly until RLC re-assembly is implemented).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35000 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd new files to cmake as well
jmayer [Mon, 22 Nov 2010 12:03:28 +0000 (12:03 +0000)]
Add new files to cmake as well

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34999 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDisplay priority and protocol, even in the case of WCCP2_SERVICE_STANDARD, but
cmaynard [Mon, 22 Nov 2010 05:09:57 +0000 (05:09 +0000)]
Display priority and protocol, even in the case of WCCP2_SERVICE_STANDARD, but
indicate that these fields are unused in this case and must be zero.
Furthermore, if the value is non-zero, add an expert info warning about it.
Fixes bug 3631.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34998 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix properties.
wmeier [Sun, 21 Nov 2010 19:33:46 +0000 (19:33 +0000)]
Fix properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34997 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd $Id$; Fix some properties.
wmeier [Sun, 21 Nov 2010 19:03:17 +0000 (19:03 +0000)]
Add $Id$; Fix some properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34996 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd $Id$
wmeier [Sun, 21 Nov 2010 18:57:21 +0000 (18:57 +0000)]
Add $Id$

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34995 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago[Automatic manuf, services and enterprise-numbers update for 2010-11-21]
gerald [Sun, 21 Nov 2010 16:03:40 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-11-21]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34992 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug 5425:
jake [Sun, 21 Nov 2010 12:36:24 +0000 (12:36 +0000)]
Fix for bug 5425:
Add support for dissecting SLL type 0x0C frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34991 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemoved unused route_preference.
stig [Sun, 21 Nov 2010 11:28:42 +0000 (11:28 +0000)]
Removed unused route_preference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34990 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Jakub Zawadzki via Alexander Koeppe.
etxrab [Sun, 21 Nov 2010 10:41:01 +0000 (10:41 +0000)]
From Jakub Zawadzki via Alexander Koeppe.
Improvement of checking available length highlighting byteview data.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5383

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34989 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Alexis La Goutte:
etxrab [Sun, 21 Nov 2010 10:30:35 +0000 (10:30 +0000)]
From Alexis La Goutte:
ICMPv6 Enhancements : make ICMP option filterable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5424

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34988 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug 5422:
jake [Sat, 20 Nov 2010 18:14:30 +0000 (18:14 +0000)]
Fix for bug 5422:
Add support for dissecting SLL type 0x03 frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34987 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd missing update of user-guide.xml for revision 34983.
jake [Sat, 20 Nov 2010 16:14:30 +0000 (16:14 +0000)]
Add missing update of user-guide.xml for revision 34983.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34986 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove svn:executable and svn:keywords properties.
wmeier [Sat, 20 Nov 2010 15:33:09 +0000 (15:33 +0000)]
Remove svn:executable and svn:keywords properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34985 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRepair copy (summary and as filter) functionality in the packet-list context menu...
sake [Sat, 20 Nov 2010 14:55:02 +0000 (14:55 +0000)]
Repair copy (summary and as filter) functionality in the packet-list context menu. It got broken in the bulk of work required to move to the UImanager.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34984 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd description of File|Import option.
jake [Sat, 20 Nov 2010 13:41:04 +0000 (13:41 +0000)]
Add description of File|Import option.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34983 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoClean up blurbs a bit. Not much we can do about "Description" - what is
guy [Fri, 19 Nov 2010 19:02:08 +0000 (19:02 +0000)]
Clean up blurbs a bit.  Not much we can do about "Description" - what is
it a description *of*?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34978 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoVerify the number of rectangles, sub-rectangles, the number of bytes of cut
morriss [Fri, 19 Nov 2010 18:54:19 +0000 (18:54 +0000)]
Verify the number of rectangles, sub-rectangles, the number of bytes of cut
text, etc. are "sane" before:
1) requesting enough bytes (from reassembly) to dissect them all
2) (and) attempting to add them all to the tree

Request all the bytes we'll need to dissect all those rectangles/sub-rectangles
before starting dissection rather than checking before dissecting each
rectangle/sub-rectangle.

Use tvb_get_ephemeral_string().

Use _U_ to mark unused arguments.

Fix up some indentation.

Get rid of one more DISSECTOR_ASSERT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34977 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5366 :
morriss [Fri, 19 Nov 2010 18:53:40 +0000 (18:53 +0000)]
From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5366 :

Several fixes that make Tight VNC negotiation properly parsed.
It was not parsed correctly previously, for multiple reasons.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34976 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove comments used when editing.
etxrab [Fri, 19 Nov 2010 16:34:51 +0000 (16:34 +0000)]
Remove comments used when editing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34975 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMark a parameter as unused.
etxrab [Fri, 19 Nov 2010 16:33:12 +0000 (16:33 +0000)]
Mark a parameter as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34974 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a missing piece of the commit:
etxrab [Fri, 19 Nov 2010 15:44:49 +0000 (15:44 +0000)]
Add a missing piece of the commit:
From Taras Kotov:
Add RADIUS dictionary for vendor Eltex.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5415

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34973 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPretify dissection of H.248 Annex C.11 SDP equivalents.
etxrab [Fri, 19 Nov 2010 15:43:35 +0000 (15:43 +0000)]
Pretify dissection of H.248 Annex C.11 SDP equivalents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34972 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove a check_col();
wmeier [Fri, 19 Nov 2010 15:26:27 +0000 (15:26 +0000)]
Remove a check_col();
Fix a typo;
Minor whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34971 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access certain value_string arrays.
wmeier [Fri, 19 Nov 2010 15:21:40 +0000 (15:21 +0000)]
Use value_string_ext fcns to access certain value_string arrays.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34970 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove some unnecessary includes.
morriss [Fri, 19 Nov 2010 13:35:24 +0000 (13:35 +0000)]
Remove some unnecessary includes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34969 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd Stéphane Bryant (RELOAD dissector). Since this file accepts UTF-8, put the o...
morriss [Fri, 19 Nov 2010 13:33:32 +0000 (13:33 +0000)]
Add Stéphane Bryant (RELOAD dissector).  Since this file accepts UTF-8, put the o-umlaut back in Toralf Förster's name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34968 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoReserve not-yet-supported channel type IDs.
martinm [Fri, 19 Nov 2010 11:42:05 +0000 (11:42 +0000)]
Reserve not-yet-supported channel type IDs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34967 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5412 :
morriss [Fri, 19 Nov 2010 02:32:42 +0000 (02:32 +0000)]
From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5412 :

Update ReLOAD dissector to reflect draft-ietf-p2psip-base-12

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34966 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 :
morriss [Fri, 19 Nov 2010 02:12:19 +0000 (02:12 +0000)]
From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 :

Fix the dissection of the length of the option field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34965 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake some updates to describe the newer features.
jake [Fri, 19 Nov 2010 00:05:38 +0000 (00:05 +0000)]
Make some updates to describe the newer features.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34964 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles.
wmeier [Thu, 18 Nov 2010 23:02:20 +0000 (23:02 +0000)]
Fix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34963 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles.
wmeier [Thu, 18 Nov 2010 22:55:18 +0000 (22:55 +0000)]
Fix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34962 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agostats_tree_register() need be called only once (and not each time a port pref is...
wmeier [Thu, 18 Nov 2010 21:56:25 +0000 (21:56 +0000)]
stats_tree_register() need be called only once (and not each time a port pref is changed);
(Minor) use tvb_reported_length_remaining() rather than tvb_length_remaining() in a number of places;
Add a comment to get_sametime_message_len() about the minimum length of the tvb when the fcn is called.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34961 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Jon Ellch via bug #5175: Add PPI-GPS protocol dissector patch
sfisher [Thu, 18 Nov 2010 20:54:14 +0000 (20:54 +0000)]
From Jon Ellch via bug #5175: Add PPI-GPS protocol dissector patch

Minor changes by me as detailed in the bug's comment #8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34956 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access a number of value_string arrays;
wmeier [Thu, 18 Nov 2010 19:37:22 +0000 (19:37 +0000)]
Use value_string_ext fcns to access a number of value_string arrays;
Sort several value_arrays in ascending order by value;
Localize a global variable to proto_reg_handoff().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34955 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTighten up TLV processing a bit to prevent a potential loop.
wmeier [Thu, 18 Nov 2010 19:25:11 +0000 (19:25 +0000)]
Tighten up TLV processing a bit to prevent a potential loop.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34954 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a comment about the pipe read timeout on Windows.
gerald [Thu, 18 Nov 2010 17:29:02 +0000 (17:29 +0000)]
Add a comment about the pipe read timeout on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34947 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTweak the display of the header.
etxrab [Thu, 18 Nov 2010 16:01:39 +0000 (16:01 +0000)]
Tweak the display of the header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34946 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago[UImanager]Add missing GO to frame, and copy paste errors.
etxrab [Thu, 18 Nov 2010 15:57:12 +0000 (15:57 +0000)]
[UImanager]Add missing GO to frame, and copy paste errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34945 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRADIUS: Acc-Status-Type value 3 identified as "Alive" instead of "Interim-Update"
etxrab [Thu, 18 Nov 2010 11:40:06 +0000 (11:40 +0000)]
RADIUS: Acc-Status-Type value 3 identified as "Alive" instead of "Interim-Update"
Updte the dictionaries to reflect IANA entries.
http://www.iana.org/assignments/radius-types/radius-types.xml#radius-types-10
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5418

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34944 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Taras Kotov:
etxrab [Thu, 18 Nov 2010 09:51:50 +0000 (09:51 +0000)]
From Taras Kotov:
Add RADIUS dictionary for vendor Eltex.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5415

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34943 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSet the pipe read timeout to 100 milliseconds instead of 100 microseconds.
gerald [Wed, 17 Nov 2010 23:51:31 +0000 (23:51 +0000)]
Set the pipe read timeout to 100 milliseconds instead of 100 microseconds.
Should fix bug 5309.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34938 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago"Fill" value_strings.
etxrab [Wed, 17 Nov 2010 21:58:35 +0000 (21:58 +0000)]
"Fill" value_strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34935 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5411
etxrab [Wed, 17 Nov 2010 21:58:06 +0000 (21:58 +0000)]
Fix bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5411
Acct-Session-Id -> OctetString.
Also fix assorted Enums.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34934 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value-string_ext fcns to access value_string array;
wmeier [Wed, 17 Nov 2010 21:40:21 +0000 (21:40 +0000)]
Use value-string_ext fcns to access value_string array;
Sort value_string_array in ascending order by value;
Reformat display of tag info to be more readable;
Rework TLV processing;
Remove unneeded variable;
Minor whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34933 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agovalue_string_ext fixes.
etxrab [Wed, 17 Nov 2010 16:56:51 +0000 (16:56 +0000)]
value_string_ext fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34932 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove unneeded stuff from the Copyright notice. Use ENC_BIG_ENDIAN and ENC_NA.
morriss [Wed, 17 Nov 2010 16:52:20 +0000 (16:52 +0000)]
Remove unneeded stuff from the Copyright notice.  Use ENC_BIG_ENDIAN and ENC_NA.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34931 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Toralf Foerster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5376 :
morriss [Wed, 17 Nov 2010 16:47:03 +0000 (16:47 +0000)]
From Toralf Foerster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5376 :

A dissector for the SAMETIME protocol.

From me: no need to include gmodule.h, use only ASCII in the author's name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34930 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago- Update to 3GPP TS 25.413 V9.4.0 (2010-09).
etxrab [Wed, 17 Nov 2010 16:23:10 +0000 (16:23 +0000)]
- Update to 3GPP TS 25.413 V9.4.0 (2010-09).
- Fill the value_strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34929 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago- Update to 3GPP TS 25.413 V9.4.0 (2010-09).
etxrab [Wed, 17 Nov 2010 15:36:53 +0000 (15:36 +0000)]
- Update to 3GPP TS 25.413 V9.4.0 (2010-09).
- Fill the value_strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34928 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUser value_string_ext fcns to access several value_string arrays;
wmeier [Wed, 17 Nov 2010 14:59:08 +0000 (14:59 +0000)]
User value_string_ext fcns to access several value_string arrays;
Minor reformatting and whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34927 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAllow <interval> to be successfully sscanf'd no matter the locale for the
cmaynard [Wed, 17 Nov 2010 14:26:38 +0000 (14:26 +0000)]
Allow <interval> to be successfully sscanf'd no matter the locale for the
decimal symbol.  Fixes bug 2880.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34926 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago- Update to 3GPP TS 25.413 V9.4.0 (2010-09).
etxrab [Wed, 17 Nov 2010 11:48:17 +0000 (11:48 +0000)]
- Update to 3GPP TS 25.413 V9.4.0 (2010-09).
- Fill the value_strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34925 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago- Use SABP:s SCTP ppid.
etxrab [Wed, 17 Nov 2010 08:18:30 +0000 (08:18 +0000)]
- Use SABP:s SCTP ppid.
- Use value_string_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34924 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSeparate out/update comment block.
jake [Wed, 17 Nov 2010 07:42:32 +0000 (07:42 +0000)]
Separate out/update comment block.
Update IANA assignments.
Use available checksum routines.
Some cleanup and use of convenience macros.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34922 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSmall clarification.
jake [Wed, 17 Nov 2010 07:29:40 +0000 (07:29 +0000)]
Small clarification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34921 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoQuote all fields when exporting to CSV. Fixes bug 2811.
cmaynard [Wed, 17 Nov 2010 03:29:12 +0000 (03:29 +0000)]
Quote all fields when exporting to CSV.  Fixes bug 2811.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34920 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom David Katz via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5166 :
morriss [Wed, 17 Nov 2010 03:16:30 +0000 (03:16 +0000)]
From David Katz via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5166 :

Add a configuration parameter of the NWG version for WiMAX ASN CP dissector.
The format and meaning of TLVs, as well as function types  and messages changed
between the different NWG versions.
Added support for the version number of TLVs in the dictionary xml, its parser,
and of course in the packet itself.
Added support for the version number of function-types and message-types by
extending the value_string structure to contain also a "since" version number.

Successfully tested with a live capture and capture file, containing WiMAX ASN
packets (full Network entry).
Also fuzzed 500 passes successfully.

The XML doesn't contain all existing NWG versions, only selected ones. This is
a little tedious work to go over all TLVs of each version, so I'll add some
newer versions later on. can add a short how-to of adding a new version, for
others to use, if needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34919 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Slava via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5335 :
morriss [Wed, 17 Nov 2010 02:57:22 +0000 (02:57 +0000)]
From Slava via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5335 :

This patch adds to Wireshark the ability to dissect Infiniband SDP (Socket
Direct Protocol) and CM MADs traffic.

It also contains various other bug-fixes and enhancements. SDP traffic can be
identified automatically (analyzing SDP CM MADs) or manually.

SDP, or Sockets Direct Protocol, is a protocol developed by the Infiniband
Trade Association which enables existing socket-based applications to
transparently utilize the Infiniband capabilities.

This patch is submitted on behalf of Mellanox Technologies Ltd.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34918 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoIf pcap_geterr() returns "read error: PacketReceivePacket failed", report that
cmaynard [Tue, 16 Nov 2010 21:08:08 +0000 (21:08 +0000)]
If pcap_geterr() returns "read error: PacketReceivePacket failed", report that
the "network adapter on which the capture was being done is no longer running".
Fixes bug 2623 reported by Anthony Coulter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34915 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe IPv6 "element" in PDN address information element is a 8 byte
etxrab [Tue, 16 Nov 2010 20:46:21 +0000 (20:46 +0000)]
The IPv6 "element" in PDN address information element is a 8 byte
IPv6 interface identifier.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5408

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34914 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake editcap -B work like expected: output no packets after the stop time.
sake [Tue, 16 Nov 2010 20:22:20 +0000 (20:22 +0000)]
Make editcap -B work like expected: output no packets after the stop time.
Old behavior was to include a packet with a timestamp of 12:00:00.934 if -B "YYYY-MM-DD 12:00:00" was used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34913 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSplit libui into libui and libui_dirty. The latter contains (only)
morriss [Tue, 16 Nov 2010 20:13:26 +0000 (20:13 +0000)]
Split libui into libui and libui_dirty.  The latter contains (only)
text_import_scanner.c (which is generated and not by us so we can't guarantee
that it's clean).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34912 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a cast to fix:
etxrab [Tue, 16 Nov 2010 20:08:31 +0000 (20:08 +0000)]
Add a cast to fix:
tempfile.c(202) : warning C4267: '=' : conversion from 'size_t' to 'unsigned long'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34911 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAccounting-Session-Id should be an UTF8String.
etxrab [Tue, 16 Nov 2010 17:52:57 +0000 (17:52 +0000)]
Accounting-Session-Id should be an UTF8String.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34910 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agovalue_string_ext fixes.
etxrab [Tue, 16 Nov 2010 17:31:29 +0000 (17:31 +0000)]
value_string_ext fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34908 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5410 :
morriss [Tue, 16 Nov 2010 17:00:50 +0000 (17:00 +0000)]
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5410 :

This patch adds support for displaying OPC UA ExtensionObjects.

An ExtensionObject is a mechanism to transport user defined structures as
serialized blobs. Some types of ExtensionObjects are already defined by the OPC
Foundation's OPC UA Specifications.
These types can be implemented by this dissector, because they are well-known.

Real user-defined or vendor-defined types are unlikely to be implemented by a
passive dissector, because this would require browsing of the UA server's
address space to retrieve the type information.

Currently only the following types are supported:

 * DataChangeNotification
 * EventNotification

Others OPC defined types will follow.

From me: fix warnings: "format not a string literal and no format arguments"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34906 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5409 :
morriss [Tue, 16 Nov 2010 16:45:22 +0000 (16:45 +0000)]
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5409 :

This patch fixes displaying OPCUA Strings and ByteStrings.

From me: fix warnings: "format not a string literal and no format arguments"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34905 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix warning.
cmaynard [Tue, 16 Nov 2010 16:40:16 +0000 (16:40 +0000)]
Fix warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34904 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate the description of the temporary file name.
cmaynard [Tue, 16 Nov 2010 16:15:04 +0000 (16:15 +0000)]
Update the description of the temporary file name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34903 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse more meaningful temp file name. Fixes bug 1882.
cmaynard [Tue, 16 Nov 2010 15:37:37 +0000 (15:37 +0000)]
Use more meaningful temp file name.  Fixes bug 1882.
Template chosen is: wireshark_<iface>_YYYYmmddHHMMSS_XXXXXX ... where
    <iface> is the interface name (or UUID part of the interface if applicable)
    YYYYmmddHHMMSS are as described in "man strftime".
    XXXXXX is a template filled in with random characters.  See "man mkstemp".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34902 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoModify 'compare_files' target: ignore #line changes; compare from epan\dissectors...
wmeier [Tue, 16 Nov 2010 15:24:51 +0000 (15:24 +0000)]
Modify 'compare_files' target: ignore #line changes; compare from epan\dissectors to asn1\...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34901 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access several value_string arrays;
wmeier [Tue, 16 Nov 2010 15:20:33 +0000 (15:20 +0000)]
Use value_string_ext fcns to access several value_string arrays;
Minor whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34900 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5400 :
morriss [Tue, 16 Nov 2010 15:01:43 +0000 (15:01 +0000)]
From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5400 :

The attached patch adds many more DAAP codes to be parsed properly by the DAAP
dissector.
In addition, it fixes some prints.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34899 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to clean up the makefile a bit.
etxrab [Tue, 16 Nov 2010 09:15:15 +0000 (09:15 +0000)]
Try to clean up the makefile a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34898 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAccomodate older flex versions.
jake [Tue, 16 Nov 2010 06:46:12 +0000 (06:46 +0000)]
Accomodate older flex versions.
Make scanner compilation more environment agnostic.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34897 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFirst try to install docbook stuff as well - not yet working
jmayer [Tue, 16 Nov 2010 00:20:31 +0000 (00:20 +0000)]
First try to install docbook stuff as well - not yet working

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34896 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAnother unused function with MAIN_MENU_USE_UIMANAGER
jmayer [Tue, 16 Nov 2010 00:18:54 +0000 (00:18 +0000)]
Another unused function with MAIN_MENU_USE_UIMANAGER

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34895 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access several value_string arrays.
wmeier [Mon, 15 Nov 2010 23:53:25 +0000 (23:53 +0000)]
Use value_string_ext fcns to access several value_string arrays.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34894 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAssert was firing while working out sequence length for user plane frames.
martinm [Mon, 15 Nov 2010 23:32:34 +0000 (23:32 +0000)]
Assert was firing while working out sequence length for user plane frames.
Treat signalling plane case separately.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34893 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access several value_string arrays.
wmeier [Mon, 15 Nov 2010 22:37:35 +0000 (22:37 +0000)]
Use value_string_ext fcns to access several value_string arrays.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34891 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access several value_string arrays.
wmeier [Mon, 15 Nov 2010 22:00:33 +0000 (22:00 +0000)]
Use value_string_ext fcns to access several value_string arrays.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34890 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago"Fill" value_strings.
etxrab [Mon, 15 Nov 2010 21:32:27 +0000 (21:32 +0000)]
"Fill" value_strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34888 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string ext for address family.
etxrab [Mon, 15 Nov 2010 21:05:03 +0000 (21:05 +0000)]
Use value_string ext for address family.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34887 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5395 :
morriss [Mon, 15 Nov 2010 20:52:41 +0000 (20:52 +0000)]
From Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5395 :

The ZigBee security dissector was not recording the short to long address
mappings in Security Headers, preventing the decryption of some payloads. This
patch eliminates the Undecoded warnings in packets 1 and 19 in this test
capture: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5457

The keys to decrypt these packets are listed in the bug.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34886 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agocmake stuff:
jmayer [Mon, 15 Nov 2010 20:25:28 +0000 (20:25 +0000)]
cmake stuff:
- Fix fallout from gtk/text_import_scanner.l patch: Wireshark will
  build with cmake again.
- Update README.cmake a bit
- Running "cmake -DUI_MANAGER=ON" will give you the new ui-manager.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34885 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access a value_string array.
wmeier [Mon, 15 Nov 2010 19:46:07 +0000 (19:46 +0000)]
Use value_string_ext fcns to access a value_string array.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34884 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access a value_string array.
wmeier [Mon, 15 Nov 2010 19:15:34 +0000 (19:15 +0000)]
Use value_string_ext fcns to access a value_string array.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34883 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access certain value_string arrays;
wmeier [Mon, 15 Nov 2010 19:08:12 +0000 (19:08 +0000)]
Use value_string_ext fcns to access certain value_string arrays;
Whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34882 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate package_name_vals[] value_string array:
wmeier [Mon, 15 Nov 2010 19:00:16 +0000 (19:00 +0000)]
Update package_name_vals[] value_string array:
- Add new entries based on: http://www.iana.org/assignments/megaco-h248 last updated 2010-10-01;
- Fix a typo (incorrect value for an entry);
- Switch values between two entries to match the IANA list;
- Switch two entries so list is in ascending order by value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34881 f5534014-38df-0310-8fa8-9805f1628bb7