etxrab [Thu, 29 Jun 2006 20:39:53 +0000 (20:39 +0000)]
Add a heuristic table to SUA (SUA and SCCP should share the same table) to heuristically
dissect RANAP ower SUA.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18616
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 29 Jun 2006 19:46:51 +0000 (19:46 +0000)]
add various enhancements to the CBA-ACCO dissector, including an added profinet_type field to the packet_info struct
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18615
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 29 Jun 2006 19:04:33 +0000 (19:04 +0000)]
If the user sets a time reference and the time display format is currently not "Seconds Since Beginning of Capture", ask him if Wireshark should switch to that format. It's the only display format where a time reference makes sense.
It's just annoying to set a time reference without seeing a reasonable result on the screen.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18614
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 29 Jun 2006 18:51:30 +0000 (18:51 +0000)]
keep the (optional) Object UUID in the call value
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18613
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Thu, 29 Jun 2006 15:26:41 +0000 (15:26 +0000)]
use "type function" instead of "field function" in PER CHOICE and SEQUENCE tables
it matches asn2wrs approach and makes generated dissectors source shorter
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18612
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Thu, 29 Jun 2006 13:49:56 +0000 (13:49 +0000)]
Some improvements to the Lua plugin:
- Makefile.am fix: elua_register.h generation + checking serialized
- ProtoField.new(..) parameter parsing fix and changes
- enabling gui_enabled() function in Lua (typo fix, thanks to Tamas Regos)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18611
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 29 Jun 2006 09:53:12 +0000 (09:53 +0000)]
Fix description of EAPOL Key Descriptor Version values, as per mail from
Michael Stevens.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18610
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 29 Jun 2006 09:06:41 +0000 (09:06 +0000)]
ssl update register protocols with a decryption key with the protocol name instead of a "tunneled protocol" fake port thing.
this break old preference settings but as we havent shipped any win32 version with this feature yet it shouldnt be any drama
see wiki for updates on the new format
(we still need many many updates and cleanups to the code but the non-backward compatible preference change must go in asap)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18609
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 29 Jun 2006 08:31:38 +0000 (08:31 +0000)]
make these two protocols (that are commonly transported atop SSL) register themself with their name so the new SSL preference parsing will be able to find them
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18608
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 29 Jun 2006 08:16:57 +0000 (08:16 +0000)]
remove a "differ in signedness" warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18607
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 29 Jun 2006 08:15:07 +0000 (08:15 +0000)]
remove some "unused parameter" warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18606
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 29 Jun 2006 08:08:36 +0000 (08:08 +0000)]
the drep parameter of dissect_dcerpc_uuid_t() should be guint8 * instead of char * (just like all the other dissect_dcerpc_...() functions).
This should fix some "differ in signedness" warnings (and maybe will raise new ones, which should be fixed at the calling places then)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18605
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 29 Jun 2006 07:31:52 +0000 (07:31 +0000)]
make the three decryption preferences only be visible IF wireshark is compiled for ssl decryption (==with libgcrypt and gnutls)
this makes it easier for users to determine whether their versaion of wireshark can or can not decrypt ssl traffic
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18604
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 29 Jun 2006 06:32:21 +0000 (06:32 +0000)]
Update a reference and a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18603
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 29 Jun 2006 06:27:57 +0000 (06:27 +0000)]
From Martin Peylo:
Bug 978 TIPC: Malformed Packet when valid "Cluster Internal Connection Based Non-Routed Message
Bug 979 TIPC: descriptions switched in dissected package
Bug 980 TIPC: "Source Droppable" bit is missing in dissected message
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18602
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 28 Jun 2006 22:07:23 +0000 (22:07 +0000)]
Reset ldm_tree to NULL each time we dissect an LDAP packet. This should
fix a current Buildbot crash. Fix up whitespace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18601
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 28 Jun 2006 20:30:42 +0000 (20:30 +0000)]
Pass tvb_format_text() through a format string, in case it returns any
"%" characters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18600
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Wed, 28 Jun 2006 19:31:49 +0000 (19:31 +0000)]
Support for the acp127-notification-request extension.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18599
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Wed, 28 Jun 2006 19:07:10 +0000 (19:07 +0000)]
Support for the message-token, proof-of-delivery and recipient-certificate p1 envelope extensions.
Patch for unknown built-in content type.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18598
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 28 Jun 2006 18:54:19 +0000 (18:54 +0000)]
add dissection of the RemoteCreateInstance method (as far as known)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18597
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 28 Jun 2006 18:51:24 +0000 (18:51 +0000)]
add dissection of custom marshalled OBJREF's (as far as known)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18596
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Wed, 28 Jun 2006 14:19:08 +0000 (14:19 +0000)]
remove functions register_ber_oid_name() and get_ber_oid_name() from packet-ber.c, they were only OID but not BER related
use add_oid_str_name() and get_oid_str_name() instead of them
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18595
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 28 Jun 2006 07:51:31 +0000 (07:51 +0000)]
coverity 200 remove redundant null tests for pinfo->fd
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18594
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 28 Jun 2006 07:44:47 +0000 (07:44 +0000)]
coverity 199 remove a pointless test for NULL for something that can never be null.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18593
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 28 Jun 2006 07:37:54 +0000 (07:37 +0000)]
coverity 198
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18592
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Wed, 28 Jun 2006 07:01:15 +0000 (07:01 +0000)]
export functions from oid-resolv.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18591
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Wed, 28 Jun 2006 06:50:39 +0000 (06:50 +0000)]
few OID names
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18590
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 27 Jun 2006 22:04:35 +0000 (22:04 +0000)]
From Martin Mathieson:
Fix Bug 976
Looking at frame 170 in the trace, it looks like
tvb_get_ephemeral_text() struggles with the null character in the middle
of the 4th parameter (in the WWW-Authenticate header) and returns NULL.
The attached patch uses tvb_format_text() instead which also does a
better job of showing the string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18589
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 27 Jun 2006 21:44:07 +0000 (21:44 +0000)]
From Alejandro Vaquero:
The "listen_rtp" plugin that allows to listen audio RTP
conversations.
The plugin is integrated to the "Voip Calls" feature. There is a new
"listen" button in the "Voip Calls" that once the calls are selected and
the "listen" is clicked, a new window will open. In this window you can
change the simulated jitter buffer to be used for decoding the RTP
packets. In this first implementation, only a static jitter buffer can
be simulated. Then pressing "decode" will decode all the RTP and
generate the graphical view of the audio channels. From there you can
select up to two channels at the same time (to be played in the left and
right channels) and then play, pause, stop,etc.....ok, the attached
screenshot it is self explanatory (hopefully).
The only codecs available from now are G711u and G711a law.
The PortAudio (www.portaudio.com) library is used to play audio.
This is an open source cross-platform Audio library. I have tested this
on Windows XP and in a linux FC4.
NOTE: only the plugin soure files checked in at this time.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18588
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 27 Jun 2006 19:16:38 +0000 (19:16 +0000)]
From Neil Piercy:
Just to add dissector name registration to the main IETF AMR dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18587
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 27 Jun 2006 19:15:43 +0000 (19:15 +0000)]
From Neil Piercy:
The patch avoids the crash for unknown messages, adds the Common Id
message dissection which caused it, and also add dissector name
registration for the 2 other protocols which this file can provide.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18586
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 27 Jun 2006 16:50:28 +0000 (16:50 +0000)]
MSVC doesn't like the conversion from guint64 to double, use gint64 instead (should be safe if I understand the implementation correct)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18585
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 27 Jun 2006 16:41:32 +0000 (16:41 +0000)]
#include <epan/value_string.h> must be done, even if HAVE_LIBGNUTLS isn't defined
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18584
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 27 Jun 2006 13:51:13 +0000 (13:51 +0000)]
make the called subdissectors create their protocol expansion at the first level of the tree and not deep inside the SSL layer
makes the traces much more readable
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18583
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 27 Jun 2006 13:36:10 +0000 (13:36 +0000)]
from Authesserre Samuel
SSL updates and DTLS support
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18582
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Tue, 27 Jun 2006 12:40:53 +0000 (12:40 +0000)]
the 1st very simple attempt to support RFC 2198 Redundant Audio Data
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18581
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 27 Jun 2006 12:12:31 +0000 (12:12 +0000)]
fix a tiny memory leak where wireshark would lose a few kb once upon startup if there was no radius directory
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18580
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 27 Jun 2006 12:05:05 +0000 (12:05 +0000)]
fix a tiny memory leak where we would lose a few kbyte once when wireshark is starting up
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18579
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 26 Jun 2006 20:46:15 +0000 (20:46 +0000)]
add a new column DCE/RPC context ID
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18578
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 26 Jun 2006 19:49:27 +0000 (19:49 +0000)]
Use a more uniform name for the output files (which makes it easier to
write wrapper scripts).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18577
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 26 Jun 2006 13:18:37 +0000 (13:18 +0000)]
From Irene Ruengeler: Add context menu for SCTP analysis.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18576
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 26 Jun 2006 08:47:26 +0000 (08:47 +0000)]
coverity 170
remove some dead code
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18575
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 25 Jun 2006 12:15:35 +0000 (12:15 +0000)]
Fix Ethereal bug 1004. Make UDP dissector work on top of IPv6 by filling in pinfo fields correctly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18574
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 24 Jun 2006 12:03:24 +0000 (12:03 +0000)]
restore display of optional field names when the optional bit is displayed in the tree
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18573
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 24 Jun 2006 11:50:47 +0000 (11:50 +0000)]
coverity 197 dead code
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18572
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 24 Jun 2006 05:45:06 +0000 (05:45 +0000)]
coverity 149 dead code
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18571
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 24 Jun 2006 05:39:38 +0000 (05:39 +0000)]
change a parenthesis
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18570
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 24 Jun 2006 03:39:54 +0000 (03:39 +0000)]
coverity 169 dead code
finish the removal of "hex" state that was begun in svn 5798
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18569
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 24 Jun 2006 02:41:25 +0000 (02:41 +0000)]
Put the sequence number in for a response, if present.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18568
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 24 Jun 2006 00:01:33 +0000 (00:01 +0000)]
remove some dead code coverity 17
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18567
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 23 Jun 2006 23:51:55 +0000 (23:51 +0000)]
change a comment to #if to make it clearer the code is disabled
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18566
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 23 Jun 2006 23:44:17 +0000 (23:44 +0000)]
coverity 172
remove a dead code condition
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18565
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 23 Jun 2006 20:39:51 +0000 (20:39 +0000)]
Let the user set the working directory and number of passes from the command
line. An upcoming Buildbot step will use these.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18564
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 23 Jun 2006 18:29:48 +0000 (18:29 +0000)]
use file name information from wiretap instead of "build in" values
remove "double combobox" from the save dialog
append the default file extension to the save file name, if the user didn't added one
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18563
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 23 Jun 2006 18:20:34 +0000 (18:20 +0000)]
add file extension information (filter "*.pcap;*.cap" and default extension ".pcap") to wiretap
sort file types in alphabetical order, but keep the libpcap like entries at the start
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18562
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 23 Jun 2006 18:06:54 +0000 (18:06 +0000)]
fix the reading of UUID's from the Win32 registry, it was broken as we switched to UNICODE compilation
I thought there was a bugzilla entry about this, but couldn't find it
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18561
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 23 Jun 2006 18:03:40 +0000 (18:03 +0000)]
squelch some compiler warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18560
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Fri, 23 Jun 2006 15:22:12 +0000 (15:22 +0000)]
Make SSRC display (among others) unsigned. Fixes Ethereal bug 1002.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18559
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 23 Jun 2006 12:04:00 +0000 (12:04 +0000)]
coverity 174
ifdef out a few lines of dead code for a feature that is not yet finished
remove two compiler warnings about uninitialized variables (they are not uninitialized, just gcc being dumb)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18558
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 23 Jun 2006 09:27:17 +0000 (09:27 +0000)]
coverity 190
remove some dead code
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18557
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 23 Jun 2006 09:15:20 +0000 (09:15 +0000)]
remove some dead code
coverity 191
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18556
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 23 Jun 2006 09:02:54 +0000 (09:02 +0000)]
coverity warning 177 deadcode
replace overly convoluted code with much simpler code.
stateid is a simple 16 byte structure and there is no need to make it more complex than it is.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18555
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Fri, 23 Jun 2006 06:38:46 +0000 (06:38 +0000)]
One warning from GCC:
packet-sbus.c:634: warning: 'sbus_web_seq' is used uninitialized in this function
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18554
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Fri, 23 Jun 2006 06:14:30 +0000 (06:14 +0000)]
Various corrections and updates
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18553
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 23 Jun 2006 02:43:59 +0000 (02:43 +0000)]
Set svn:ignore appropriately.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18552
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 23 Jun 2006 02:42:40 +0000 (02:42 +0000)]
Remove definition of catapult_dct2000_board_ports_only, as per mail from
Martin Mathieson.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18551
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 22 Jun 2006 21:55:24 +0000 (21:55 +0000)]
The joys of the C switch statement - you have to remember to use
"break;" between cases except in those rare situations where you *want*
fallthrough.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18550
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 22 Jun 2006 19:19:41 +0000 (19:19 +0000)]
add another PROFINET specific subtype (5:CHASSIS_MAC)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18549
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 22 Jun 2006 19:17:43 +0000 (19:17 +0000)]
fix a (correct) compiler warning
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18548
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 22 Jun 2006 19:16:40 +0000 (19:16 +0000)]
bugfix: saving the user specified packet range text must be utf8'ed, otherwise only the first char will be used
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18547
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Thu, 22 Jun 2006 12:02:05 +0000 (12:02 +0000)]
fix bug introduced with last change
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18545
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 22 Jun 2006 11:43:18 +0000 (11:43 +0000)]
add check that string is non-null before we dereference and gfree it
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18544
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 22 Jun 2006 11:23:26 +0000 (11:23 +0000)]
coverity 187
i dont think this can trigger in the current code but better safe than sorry and it safeguards against future changes that might break this requirement.
dereferencing a nullpointer would cause crash of wireshark in case a new bug is introduced making it possible for this variuable to be null.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18543
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 22 Jun 2006 11:08:35 +0000 (11:08 +0000)]
coverity 194
this is actually a false positive in coverity and can not trigger since htis pointer can not be null here
but verifying this before the varialbe is dereferenced does not hurt in case
the file is changed and this contract is broken.
checking the
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18542
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 22 Jun 2006 10:30:35 +0000 (10:30 +0000)]
hopefully, the win32 buildbot will compile again :-(
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18541
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 22 Jun 2006 10:29:49 +0000 (10:29 +0000)]
the dissector for AssertionValue that is implemented in the template file
did not check the implicit_tag flag and caused extensiblematch filters to show up as malformed packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18540
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 22 Jun 2006 00:07:46 +0000 (00:07 +0000)]
Initial fix for bug 974. It does implement RSP header decoding, it lacks RSP trailer decoding. ASF 2.0 messages added to ASF decoder .
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18539
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 21 Jun 2006 20:51:55 +0000 (20:51 +0000)]
Put the correct IE names in GTPv1 messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18538
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 21 Jun 2006 20:34:28 +0000 (20:34 +0000)]
comment out the "catapult_dct2000_board_ports_only" part, so the Win32 buildbot has at least a chance to compile again
This is really not the preferred solution, but the current situation is even more ugly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18537
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 21 Jun 2006 20:10:38 +0000 (20:10 +0000)]
add various new dissections, enhancements to the existing dissections and update things to current spec, ...
Still incomplete, but a lot better than before :-)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18536
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 21 Jun 2006 19:33:05 +0000 (19:33 +0000)]
Stricter wording for PROTOABBREV
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18535
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 21 Jun 2006 18:35:39 +0000 (18:35 +0000)]
add an expert info if a capture file contains some (yet) undecoded portions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18534
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 21 Jun 2006 18:31:34 +0000 (18:31 +0000)]
explain the capture file contents a bit and add a warning to the save dialog that some information will be lost after saving (e.g. packet drop count)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18533
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 21 Jun 2006 18:29:38 +0000 (18:29 +0000)]
Clean any zip files we might create.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18532
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 21 Jun 2006 17:57:10 +0000 (17:57 +0000)]
Somewhat improve heuristic when SIP is encapsulated in another protocol.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18531
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 21 Jun 2006 09:45:50 +0000 (09:45 +0000)]
two things have irritated me immensly with nfs filehandles
1, (minor) the heuristics are too weak and everyting is always decoded either as netapp filehandles or one of the others even when just capturing ibetween say two classic unix boxens
2, (major) you can not filter on specific subfields of the filehandle
observation: 5 people or less in the world care about implementation specific storage of data inside an opaque blob.
remove the too weak heuristics for nfs filehandles.
make decoding of filehandles accorrding to specific implementations controlled by a preference setting.
default this setting to "unknown"
display unknown filehandles using proto_tree_add_item() FT_BYTES/BASE_HEX to make it fitlerable instead of a useless proto_tree_add_text()
wiki needs to be updated tomorrow
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18530
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 21 Jun 2006 07:30:11 +0000 (07:30 +0000)]
update PROFINET port2/3 status text
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18529
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 21 Jun 2006 07:28:56 +0000 (07:28 +0000)]
detect the PROFINET OUI correct if the multicast bit is set
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18528
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 21 Jun 2006 07:26:39 +0000 (07:26 +0000)]
fix a comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18527
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 21 Jun 2006 06:31:06 +0000 (06:31 +0000)]
From Christian Durrer:
I hope this is the right place to send a patch for a new dissector
plugin. The telegram it dissects are for the communication between PLCs
(Programmable logic controller) from the company Saia Burgess Controls
Ltd. (http://www.start-controls.com, http://www.saia-burgess.com or
http://www.sbc-support.ch). The protocol is named Ether-S-Bus (the PLCs
are called PCD2, PCD3, PCD4).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18526
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Tue, 20 Jun 2006 19:54:28 +0000 (19:54 +0000)]
- change ETH_VAR to WS_VAR
- preparation for tagged type support
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18525
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 20 Jun 2006 18:30:54 +0000 (18:30 +0000)]
Change ETH_VAR_IMPORT to WS_VAR_IMPORT. Try to fix a duplicate variable
definition in the Catapult DCT2000 code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18524
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 20 Jun 2006 13:16:50 +0000 (13:16 +0000)]
for iscsi traces where there is a lot of packetloss the dissector frequently gets out of sync
and the weak heuristics often cause wireshark to mistake some segment containing read/write data to be iscsi.
make the heuristics to check that a packet really is iscsi much stronger
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18523
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 20 Jun 2006 05:59:55 +0000 (05:59 +0000)]
From Albert Chin:
This fixes a redefine of AF_INET6 on AIX 4.3.3. We pull in <sys/socket.h> so the OS can define it first, nullifying the #define in epan/inet_v6defs.h.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18522
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 20 Jun 2006 05:57:29 +0000 (05:57 +0000)]
From Albert Chin:
Fix some C++ comments in C source files and fixes some non-constant initializations.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18521
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 19 Jun 2006 15:54:13 +0000 (15:54 +0000)]
Fix Ethereal bug 994 in Wireshark:
MIP Advertisement reverse tunneling flag not dissected
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18520
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 19 Jun 2006 15:53:03 +0000 (15:53 +0000)]
New rutine tvb_format_text_wsp() which will change "whiite space" characters to space
before output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18519
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 19 Jun 2006 15:43:17 +0000 (15:43 +0000)]
From Eugene Tarlovskij:
After synchronization with wireshark repository I see that the patch is applied in the incorrect way.
I send you another patch to fix this issue.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18518
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 19 Jun 2006 10:18:42 +0000 (10:18 +0000)]
coverity 195
remove a redundant check for str==NULL
since str can never be NULL here
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18517
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 19 Jun 2006 09:44:15 +0000 (09:44 +0000)]
add tracking of TID -> sharenames
reuse the recent structure for fid->filename mappings since the problemspace is virtually the same
(go to tired of trying to find the sharename in 10mpacket traces with 1000s of shares)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18516
f5534014-38df-0310-8fa8-
9805f1628bb7