obnox/wireshark/wip.git
9 years agoFrom Vincent Helfre:
etxrab [Mon, 29 Nov 2010 13:27:00 +0000 (13:27 +0000)]
From Vincent Helfre:
Make it possible to dissect NAS EPS messages without security header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35062 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Vincent Helfre:
etxrab [Mon, 29 Nov 2010 13:12:35 +0000 (13:12 +0000)]
From Vincent Helfre:
I have fixed some issue in the measurement information decoding in packet-gsm_a_rr.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35061 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoTry to fix Buildbot crash output: fuzz-2010-11-28-11164.pcap
etxrab [Mon, 29 Nov 2010 13:02:31 +0000 (13:02 +0000)]
Try to fix Buildbot crash output: fuzz-2010-11-28-11164.pcap
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5448

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35060 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAllow DCT error strings containing given subsets to be filtered upon.
martinm [Mon, 29 Nov 2010 12:09:18 +0000 (12:09 +0000)]
Allow DCT error strings containing given subsets to be filtered upon.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35059 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoMake the Primary name element filterable in response records.
jmayer [Sun, 28 Nov 2010 21:45:15 +0000 (21:45 +0000)]
Make the Primary name element filterable in response records.
Same for Nameserver names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35058 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agou3.c has moved.
jmayer [Sun, 28 Nov 2010 21:44:06 +0000 (21:44 +0000)]
u3.c has moved.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35057 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Slava:
etxrab [Sun, 28 Nov 2010 21:08:03 +0000 (21:08 +0000)]
From Slava:
Bug with RWH parsing in Infiniband dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5444

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35056 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Robert Groenenberg:
etxrab [Sun, 28 Nov 2010 21:03:43 +0000 (21:03 +0000)]
From Robert Groenenberg:
Assert when using ASN.1 dissector with loading a 'type table'
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5447

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35055 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Alex Badea:
etxrab [Sun, 28 Nov 2010 20:58:26 +0000 (20:58 +0000)]
From Alex Badea:
gsm_a_rr: System Information Type 4 / CBCH mobile allocation dissected incorrectly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5436

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35054 f5534014-38df-0310-8fa8-9805f1628bb7

9 years ago[Automatic manuf, services and enterprise-numbers update for 2010-11-28]
gerald [Sun, 28 Nov 2010 16:03:43 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-11-28]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35051 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix calling of LTE RRC dissector for "rrc_lte_r8" frames.
martinm [Sun, 28 Nov 2010 15:37:40 +0000 (15:37 +0000)]
Fix calling of LTE RRC dissector for "rrc_lte_r8" frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35050 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoPartially clean up white space.
guy [Sun, 28 Nov 2010 00:53:23 +0000 (00:53 +0000)]
Partially clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35049 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoClean up white space.
guy [Sun, 28 Nov 2010 00:41:47 +0000 (00:41 +0000)]
Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35048 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoClean up white space.
guy [Sun, 28 Nov 2010 00:19:49 +0000 (00:19 +0000)]
Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35047 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoMove u3 code to top-level directory since it's not GTK specific
sfisher [Sun, 28 Nov 2010 00:15:21 +0000 (00:15 +0000)]
Move u3 code to top-level directory since it's not GTK specific

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35046 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoDon't report an error twice.
guy [Sun, 28 Nov 2010 00:13:38 +0000 (00:13 +0000)]
Don't report an error twice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35045 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd GCC-style printf annotation to the routines that now take a format
guy [Sun, 28 Nov 2010 00:02:39 +0000 (00:02 +0000)]
Add GCC-style printf annotation to the routines that now take a format
string and format arguments, and fix issues warned about by that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35044 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoClean up white space.
guy [Sun, 28 Nov 2010 00:00:58 +0000 (00:00 +0000)]
Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35043 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoMake some other statusbar routines take a format string and format args,
guy [Sat, 27 Nov 2010 23:06:14 +0000 (23:06 +0000)]
Make some other statusbar routines take a format string and format args,
and get rid of an unnecessary string pointer.

Make the argument to welcome_header_push_msg() a const pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35042 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoMove main_statusbar.h to the top-level directory; none of its routines
guy [Sat, 27 Nov 2010 21:50:49 +0000 (21:50 +0000)]
Move main_statusbar.h to the top-level directory; none of its routines
use GTK+ data types, so, at least in theory, it could be implemented
atop another toolkit.

Make statusbar_push_temporary_msg() take a format string and format
arguments.  Use it instead of simple_status(), and change one call to
just take a format string and arguments rather than to take the result
of using that format string and arguments with g_strdup_printf() and
passing the result to statusbar_push_temporary_msg().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35041 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove "not tested" note on MSVC 2010's vcredist instructions
sfisher [Sat, 27 Nov 2010 18:52:02 +0000 (18:52 +0000)]
Remove "not tested" note on MSVC 2010's vcredist instructions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35040 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd svn:keywords & svn:eol-style properties.
wmeier [Sat, 27 Nov 2010 18:00:21 +0000 (18:00 +0000)]
Add svn:keywords & svn:eol-style properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35039 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom OKANO Takayoshi via bug #5442: Fix typos in documentation
sfisher [Sat, 27 Nov 2010 16:51:24 +0000 (16:51 +0000)]
From OKANO Takayoshi via bug #5442: Fix typos in documentation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35038 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix typo in comment
sfisher [Sat, 27 Nov 2010 01:13:25 +0000 (01:13 +0000)]
Fix typo in comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35037 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoDefine HAVE_GTK in config.h when compiling with GTK for the GUI
sfisher [Fri, 26 Nov 2010 23:50:56 +0000 (23:50 +0000)]
Define HAVE_GTK in config.h when compiling with GTK for the GUI

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35036 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoMention SSHv2 RFCs
sfisher [Fri, 26 Nov 2010 23:33:05 +0000 (23:33 +0000)]
Mention SSHv2 RFCs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35035 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix the rest of the include paths after the move of native win32 code to win32 and...
sfisher [Fri, 26 Nov 2010 20:57:46 +0000 (20:57 +0000)]
Fix the rest of the include paths after the move of native win32 code to win32 and out of the gtk directory in r35032

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35034 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix the Windows buildbot after r35032
sfisher [Fri, 26 Nov 2010 20:13:00 +0000 (20:13 +0000)]
Fix the Windows buildbot after r35032

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35033 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoMove native Win32 code to its own directory and out of gtk directory (hopefully witho...
sfisher [Fri, 26 Nov 2010 19:16:06 +0000 (19:16 +0000)]
Move native Win32 code to its own directory and out of gtk directory (hopefully without breaking any builds)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35032 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove comment stating that Microsoft Visual Studio 2010 doesn't work since the expre...
sfisher [Fri, 26 Nov 2010 17:54:45 +0000 (17:54 +0000)]
Remove comment stating that Microsoft Visual Studio 2010 doesn't work since the express edition does (and presumably the full edition does also)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35031 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd libtool version info to libwsutil.
rbalint [Thu, 25 Nov 2010 23:00:16 +0000 (23:00 +0000)]
Add libtool version info to libwsutil.
From Eloy Paris <peloy@debian.org>
http://svn.debian.org/wsvn/collab-maint/ext-maint/wireshark/branches/wireshark-1.4.x%2Blibseparation/debian/patches/25_libwsutil-version.patch

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35030 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix for bug 5435:
jake [Thu, 25 Nov 2010 19:59:19 +0000 (19:59 +0000)]
Fix for bug 5435:
Add support for dissecting SLL type 0x17 frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35029 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoUpdate comments to point to the previous commit to enhance traceabillity.
etxrab [Thu, 25 Nov 2010 15:21:24 +0000 (15:21 +0000)]
Update comments to point to the previous commit to enhance traceabillity.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35028 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove threading of tap update.
etxrab [Thu, 25 Nov 2010 13:56:29 +0000 (13:56 +0000)]
Remove threading of tap update.
See http://www.wireshark.org/lists/wireshark-dev/200611/msg00199.html

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35027 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoCreate proper Help reference.
jake [Thu, 25 Nov 2010 07:01:39 +0000 (07:01 +0000)]
Create proper Help reference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35026 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd support for USB isochronous. From Marton Nemeth via bug #5370.
cmaynard [Wed, 24 Nov 2010 17:33:58 +0000 (17:33 +0000)]
Add support for USB isochronous.  From Marton Nemeth via bug #5370.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35025 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAttempt to fix warnings not previously seen with VS2008EE.
cmaynard [Wed, 24 Nov 2010 17:10:48 +0000 (17:10 +0000)]
Attempt to fix warnings not previously seen with VS2008EE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35024 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Johannes Lange:
etxrab [Wed, 24 Nov 2010 16:35:23 +0000 (16:35 +0000)]
From Johannes Lange:
Function dissect_per_bit_string_display might read more bytes than available (PER dissector).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5394

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35023 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoWhen listing encapsulation types with -T or file types with -F, sort them.
cmaynard [Wed, 24 Nov 2010 16:24:44 +0000 (16:24 +0000)]
When listing encapsulation types with -T or file types with -F, sort them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35022 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Johannes Lange:
etxrab [Wed, 24 Nov 2010 16:21:04 +0000 (16:21 +0000)]
From Johannes Lange:
Bug 5393 - Wrong length calculation in new_octet_aligned_subset_bits() (PER dissector) .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5393

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35021 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoTighten the heuristic.
etxrab [Wed, 24 Nov 2010 15:15:28 +0000 (15:15 +0000)]
Tighten the heuristic.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35020 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoTry to fix dummy header settings alignment.
jake [Wed, 24 Nov 2010 08:41:22 +0000 (08:41 +0000)]
Try to fix dummy header settings alignment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35019 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoWhitespace cleanup;
wmeier [Wed, 24 Nov 2010 03:43:09 +0000 (03:43 +0000)]
Whitespace cleanup;
Add some braces;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35018 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoTighten up code dissecting message header.
wmeier [Wed, 24 Nov 2010 02:11:43 +0000 (02:11 +0000)]
Tighten up code dissecting message header.

This corrects the specific issue reported in Bug #3317
wherein the dissector decided there was a valid but unknown
header when dissecting a binary (non text) message with a ":"
as the last byte.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3317

Note that a larger issue remains: the IMF dissector
presumably shouldn't really even try to dissect a
binary payload (which is proably encrypted text).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35017 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove Supported Channels lenght check fixes
etxrab [Tue, 23 Nov 2010 19:42:11 +0000 (19:42 +0000)]
Remove Supported Channels lenght check fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5430

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35016 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Vincent Helfre:
etxrab [Tue, 23 Nov 2010 17:33:57 +0000 (17:33 +0000)]
From Vincent Helfre:
Bug in tvb_get_bits32(), The last bitshift is too large, which causes the least significant bits to be 0 all the time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35015 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoBased on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391#c11 : put some...
morriss [Tue, 23 Nov 2010 15:27:18 +0000 (15:27 +0000)]
Based on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391#c11 : put some DISSECTOR_ASSERTs and THROW's back in.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35014 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoCheck the DDI while dissecting the header.
martinm [Tue, 23 Nov 2010 11:01:48 +0000 (11:01 +0000)]
Check the DDI while dissecting the header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35013 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoUse g_path_get_dirname in init_progfile_dir on Windows. Leave the
gerald [Mon, 22 Nov 2010 21:05:55 +0000 (21:05 +0000)]
Use g_path_get_dirname in init_progfile_dir on Windows. Leave the
non-Windows code alone since it needs to check for a libtool-ized path.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35012 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoInitialize no_assoc.app_info=0.
stig [Mon, 22 Nov 2010 21:05:49 +0000 (21:05 +0000)]
Initialize no_assoc.app_info=0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35011 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoMake sure we pass a directory path and not a file path to
gerald [Mon, 22 Nov 2010 20:43:22 +0000 (20:43 +0000)]
Make sure we pass a directory path and not a file path to
SetCurrentDirectory.  Should fix bug 5420.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35010 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Mike Morrin:
etxrab [Mon, 22 Nov 2010 20:24:12 +0000 (20:24 +0000)]
From Mike Morrin:
In bssmap, track L3 handover target (GSM or UMTS) between PDUs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5294

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35009 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove print_update_dynamic() decl from file_dlg_win32.h since only used in [...].c
wmeier [Mon, 22 Nov 2010 19:45:03 +0000 (19:45 +0000)]
Remove print_update_dynamic() decl from file_dlg_win32.h since only used in [...].c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35008 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Emil Wojak via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391 :
morriss [Mon, 22 Nov 2010 18:48:54 +0000 (18:48 +0000)]
From Emil Wojak via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391 :

I'd like to share my enhancements to the TDS dissector with everyone.
The list of improvements follows:
- nearly complete dissection of RPC calls,
- detection and dissection of the ALL_HEADERS rule,
- corrected some existing proto_tree fields to support filters,
- other minor fixes where the interpretation of data conflicted with the
  official documentation from MS.

I tested the new code on a variety of different TDS captures with many diverse
RPC calls. The code compiles and works on 32-bit Linux, I didn't check those
changes on other platforms though.

From me:

- terminate all value_strings
- change ++*offset to *offset += 1 (I think that's more readable)
- replace all the dissector assertions which could be caused by malformed
  packets with expert infos
- Don't throw ReportedBoundsError when the packets have unexpected data in
  them, just report an expert info and continue on

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35007 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoPrevent "MS-DOS style path detected" messages for several commands (when "nodosfilewa...
wmeier [Mon, 22 Nov 2010 17:17:46 +0000 (17:17 +0000)]
Prevent "MS-DOS style path detected" messages for several commands (when "nodosfilewarning" not set).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35006 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 :
morriss [Mon, 22 Nov 2010 16:19:39 +0000 (16:19 +0000)]
From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 :

This is a dissector for reload framed message:
ReLOAD packets can be inserted in frame message, as described in
draft-ietf-p2psip-base-10

From me: remove some unnecessary includes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35005 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove faulty return, probably forgotten during test.
etxrab [Mon, 22 Nov 2010 15:02:06 +0000 (15:02 +0000)]
Remove faulty return, probably forgotten during test.
Fixing dissection on Via header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35004 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove 'keywords' property.
wmeier [Mon, 22 Nov 2010 14:59:33 +0000 (14:59 +0000)]
Remove 'keywords' property.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35003 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove 'keywords' property from a few files.
wmeier [Mon, 22 Nov 2010 14:57:58 +0000 (14:57 +0000)]
Remove 'keywords' property from a few files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35002 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd another (unsupported) channel type identifier.
martinm [Mon, 22 Nov 2010 13:37:13 +0000 (13:37 +0000)]
Add another (unsupported) channel type identifier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35001 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd sequence analysis for PDCP, based upon RLC/UM.
martinm [Mon, 22 Nov 2010 13:28:49 +0000 (13:28 +0000)]
Add sequence analysis for PDCP, based upon RLC/UM.
For now, only enable it for logged PDCP frames, i.e. not for PDCP found inside RLC (that won't work properly until RLC re-assembly is implemented).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35000 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd new files to cmake as well
jmayer [Mon, 22 Nov 2010 12:03:28 +0000 (12:03 +0000)]
Add new files to cmake as well

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34999 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoDisplay priority and protocol, even in the case of WCCP2_SERVICE_STANDARD, but
cmaynard [Mon, 22 Nov 2010 05:09:57 +0000 (05:09 +0000)]
Display priority and protocol, even in the case of WCCP2_SERVICE_STANDARD, but
indicate that these fields are unused in this case and must be zero.
Furthermore, if the value is non-zero, add an expert info warning about it.
Fixes bug 3631.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34998 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix properties.
wmeier [Sun, 21 Nov 2010 19:33:46 +0000 (19:33 +0000)]
Fix properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34997 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd $Id$; Fix some properties.
wmeier [Sun, 21 Nov 2010 19:03:17 +0000 (19:03 +0000)]
Add $Id$; Fix some properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34996 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd $Id$
wmeier [Sun, 21 Nov 2010 18:57:21 +0000 (18:57 +0000)]
Add $Id$

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34995 f5534014-38df-0310-8fa8-9805f1628bb7

9 years ago[Automatic manuf, services and enterprise-numbers update for 2010-11-21]
gerald [Sun, 21 Nov 2010 16:03:40 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-11-21]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34992 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix for bug 5425:
jake [Sun, 21 Nov 2010 12:36:24 +0000 (12:36 +0000)]
Fix for bug 5425:
Add support for dissecting SLL type 0x0C frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34991 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemoved unused route_preference.
stig [Sun, 21 Nov 2010 11:28:42 +0000 (11:28 +0000)]
Removed unused route_preference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34990 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Jakub Zawadzki via Alexander Koeppe.
etxrab [Sun, 21 Nov 2010 10:41:01 +0000 (10:41 +0000)]
From Jakub Zawadzki via Alexander Koeppe.
Improvement of checking available length highlighting byteview data.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5383

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34989 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Alexis La Goutte:
etxrab [Sun, 21 Nov 2010 10:30:35 +0000 (10:30 +0000)]
From Alexis La Goutte:
ICMPv6 Enhancements : make ICMP option filterable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5424

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34988 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix for bug 5422:
jake [Sat, 20 Nov 2010 18:14:30 +0000 (18:14 +0000)]
Fix for bug 5422:
Add support for dissecting SLL type 0x03 frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34987 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd missing update of user-guide.xml for revision 34983.
jake [Sat, 20 Nov 2010 16:14:30 +0000 (16:14 +0000)]
Add missing update of user-guide.xml for revision 34983.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34986 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove svn:executable and svn:keywords properties.
wmeier [Sat, 20 Nov 2010 15:33:09 +0000 (15:33 +0000)]
Remove svn:executable and svn:keywords properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34985 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRepair copy (summary and as filter) functionality in the packet-list context menu...
sake [Sat, 20 Nov 2010 14:55:02 +0000 (14:55 +0000)]
Repair copy (summary and as filter) functionality in the packet-list context menu. It got broken in the bulk of work required to move to the UImanager.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34984 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd description of File|Import option.
jake [Sat, 20 Nov 2010 13:41:04 +0000 (13:41 +0000)]
Add description of File|Import option.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34983 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoClean up blurbs a bit. Not much we can do about "Description" - what is
guy [Fri, 19 Nov 2010 19:02:08 +0000 (19:02 +0000)]
Clean up blurbs a bit.  Not much we can do about "Description" - what is
it a description *of*?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34978 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoVerify the number of rectangles, sub-rectangles, the number of bytes of cut
morriss [Fri, 19 Nov 2010 18:54:19 +0000 (18:54 +0000)]
Verify the number of rectangles, sub-rectangles, the number of bytes of cut
text, etc. are "sane" before:
1) requesting enough bytes (from reassembly) to dissect them all
2) (and) attempting to add them all to the tree

Request all the bytes we'll need to dissect all those rectangles/sub-rectangles
before starting dissection rather than checking before dissecting each
rectangle/sub-rectangle.

Use tvb_get_ephemeral_string().

Use _U_ to mark unused arguments.

Fix up some indentation.

Get rid of one more DISSECTOR_ASSERT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34977 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5366 :
morriss [Fri, 19 Nov 2010 18:53:40 +0000 (18:53 +0000)]
From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5366 :

Several fixes that make Tight VNC negotiation properly parsed.
It was not parsed correctly previously, for multiple reasons.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34976 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove comments used when editing.
etxrab [Fri, 19 Nov 2010 16:34:51 +0000 (16:34 +0000)]
Remove comments used when editing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34975 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoMark a parameter as unused.
etxrab [Fri, 19 Nov 2010 16:33:12 +0000 (16:33 +0000)]
Mark a parameter as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34974 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd a missing piece of the commit:
etxrab [Fri, 19 Nov 2010 15:44:49 +0000 (15:44 +0000)]
Add a missing piece of the commit:
From Taras Kotov:
Add RADIUS dictionary for vendor Eltex.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5415

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34973 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoPretify dissection of H.248 Annex C.11 SDP equivalents.
etxrab [Fri, 19 Nov 2010 15:43:35 +0000 (15:43 +0000)]
Pretify dissection of H.248 Annex C.11 SDP equivalents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34972 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove a check_col();
wmeier [Fri, 19 Nov 2010 15:26:27 +0000 (15:26 +0000)]
Remove a check_col();
Fix a typo;
Minor whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34971 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoUse value_string_ext fcns to access certain value_string arrays.
wmeier [Fri, 19 Nov 2010 15:21:40 +0000 (15:21 +0000)]
Use value_string_ext fcns to access certain value_string arrays.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34970 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoRemove some unnecessary includes.
morriss [Fri, 19 Nov 2010 13:35:24 +0000 (13:35 +0000)]
Remove some unnecessary includes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34969 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd Stéphane Bryant (RELOAD dissector). Since this file accepts UTF-8, put the o...
morriss [Fri, 19 Nov 2010 13:33:32 +0000 (13:33 +0000)]
Add Stéphane Bryant (RELOAD dissector).  Since this file accepts UTF-8, put the o-umlaut back in Toralf Förster's name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34968 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoReserve not-yet-supported channel type IDs.
martinm [Fri, 19 Nov 2010 11:42:05 +0000 (11:42 +0000)]
Reserve not-yet-supported channel type IDs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34967 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5412 :
morriss [Fri, 19 Nov 2010 02:32:42 +0000 (02:32 +0000)]
From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5412 :

Update ReLOAD dissector to reflect draft-ietf-p2psip-base-12

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34966 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 :
morriss [Fri, 19 Nov 2010 02:12:19 +0000 (02:12 +0000)]
From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 :

Fix the dissection of the length of the option field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34965 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoMake some updates to describe the newer features.
jake [Fri, 19 Nov 2010 00:05:38 +0000 (00:05 +0000)]
Make some updates to describe the newer features.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34964 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles.
wmeier [Thu, 18 Nov 2010 23:02:20 +0000 (23:02 +0000)]
Fix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34963 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles.
wmeier [Thu, 18 Nov 2010 22:55:18 +0000 (22:55 +0000)]
Fix compilation errors: Use FT_DOUBLE and proto_tree_add_double for gdoubles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34962 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agostats_tree_register() need be called only once (and not each time a port pref is...
wmeier [Thu, 18 Nov 2010 21:56:25 +0000 (21:56 +0000)]
stats_tree_register() need be called only once (and not each time a port pref is changed);
(Minor) use tvb_reported_length_remaining() rather than tvb_length_remaining() in a number of places;
Add a comment to get_sametime_message_len() about the minimum length of the tvb when the fcn is called.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34961 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoFrom Jon Ellch via bug #5175: Add PPI-GPS protocol dissector patch
sfisher [Thu, 18 Nov 2010 20:54:14 +0000 (20:54 +0000)]
From Jon Ellch via bug #5175: Add PPI-GPS protocol dissector patch

Minor changes by me as detailed in the bug's comment #8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34956 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoUse value_string_ext fcns to access a number of value_string arrays;
wmeier [Thu, 18 Nov 2010 19:37:22 +0000 (19:37 +0000)]
Use value_string_ext fcns to access a number of value_string arrays;
Sort several value_arrays in ascending order by value;
Localize a global variable to proto_reg_handoff().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34955 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoTighten up TLV processing a bit to prevent a potential loop.
wmeier [Thu, 18 Nov 2010 19:25:11 +0000 (19:25 +0000)]
Tighten up TLV processing a bit to prevent a potential loop.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34954 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoAdd a comment about the pipe read timeout on Windows.
gerald [Thu, 18 Nov 2010 17:29:02 +0000 (17:29 +0000)]
Add a comment about the pipe read timeout on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34947 f5534014-38df-0310-8fa8-9805f1628bb7

9 years agoTweak the display of the header.
etxrab [Thu, 18 Nov 2010 16:01:39 +0000 (16:01 +0000)]
Tweak the display of the header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34946 f5534014-38df-0310-8fa8-9805f1628bb7

9 years ago[UImanager]Add missing GO to frame, and copy paste errors.
etxrab [Thu, 18 Nov 2010 15:57:12 +0000 (15:57 +0000)]
[UImanager]Add missing GO to frame, and copy paste errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34945 f5534014-38df-0310-8fa8-9805f1628bb7