sfisher [Tue, 22 Mar 2011 16:43:16 +0000 (16:43 +0000)]
From Dirk via bug #5771: Add heuristic dissector for images and HTTP
Also add to AUTHORS file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36253
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 22 Mar 2011 16:33:39 +0000 (16:33 +0000)]
We have to initialize the elements of the fdata->col_text array to null
pointers, as there's code that assumes that if they're not set to null
pointers, they're set correctly, and doesn't bother setting them to the
right value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36252
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 22 Mar 2011 16:05:12 +0000 (16:05 +0000)]
Copy expert_tapdata_t here so that expert_dlg.h is no longer needed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36251
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 22 Mar 2011 14:39:02 +0000 (14:39 +0000)]
There can be up to 15 DL HARQ processes (depending upon TDD config index).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36250
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 22 Mar 2011 13:49:07 +0000 (13:49 +0000)]
Fix a typo
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36249
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 12:12:04 +0000 (12:12 +0000)]
Pass pointers to structs instead of struct values to create_ntlmssp_v2_key.
Coverity 567.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36248
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 11:46:19 +0000 (11:46 +0000)]
Allocate space for null termination in make_basename.
Coverity 710.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36247
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 11:40:15 +0000 (11:40 +0000)]
Close fp in error case in ssl_parse_key_list to avoid leakage.
Coverity 597.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36246
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 11:25:12 +0000 (11:25 +0000)]
Rewrote error reporting to avoid using a 2048 bytes stack buffer.
Coverity 726.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36245
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 10:12:07 +0000 (10:12 +0000)]
Corrected hack for TAPA by checking for "not IPv4".
Coverity 343.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36244
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 22 Mar 2011 09:55:33 +0000 (09:55 +0000)]
Coverity 1167
Dont assign tlv_item unless we need to dereference it.
Also push the variable deeper into the scope where it is used isntead of function wide scope.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36243
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 22 Mar 2011 09:47:34 +0000 (09:47 +0000)]
Coverity 1168
Create the items for 33_ARS under the subtree we create for this type and not under the parent node in the tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36242
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 22 Mar 2011 09:35:26 +0000 (09:35 +0000)]
Coverity 512
Check if we ran out of bytes in the tvb and return NULL
instead of trying to pass it to the decryption routines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36241
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 22 Mar 2011 09:12:57 +0000 (09:12 +0000)]
Coverity 323
Use strdup to copy a string literal we will free() later on.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36240
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2011 09:06:42 +0000 (09:06 +0000)]
- Add 9.4.5 IMEISV IE dissection
- UE Time Zone is TLV
- Cell Global Identity PDU type is SGSAP_PDU_TYPE
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36239
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 22 Mar 2011 09:05:26 +0000 (09:05 +0000)]
Coverity 420
Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach.
change a if(x)g_free(x) to a g_free(x)
since g_free(NULL) is just a nop.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36238
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 22 Mar 2011 07:42:45 +0000 (07:42 +0000)]
Use the same style in netscreen_seek_read() that we use in
netscreen_read(), checking the return value of
parse_netscreen_hex_dump() against -1 and explicitly returning FALSE if
it's -1, otherwise driving on.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36237
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 22 Mar 2011 07:24:14 +0000 (07:24 +0000)]
Make expert_tapdata_t opaque to its clients; define the structure only
in gtk/expert_comp_dlg.c.
Don't declare now-static functions in gtk/expert_dlg.h.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36236
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2011 06:17:20 +0000 (06:17 +0000)]
Remove the Exper info dialogue.
(Leave the fies for a while).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36235
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 22 Mar 2011 03:56:39 +0000 (03:56 +0000)]
When we allocate the col_text array, initialize it to a bunch of
pointers to null strings, rather than a bunch of null pointers, so that
if an exception is thrown before we set any of the columns, or some
other problem occurs, we don't end up with null pointers that could
later cause a crash.
Fix indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36234
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 22 Mar 2011 00:38:55 +0000 (00:38 +0000)]
Re-arrange code so Coverity Prevent doesn't falsely report several INFINITE_LOOPs: Coverity 427-429 (run 617)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36233
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Mon, 21 Mar 2011 22:04:22 +0000 (22:04 +0000)]
Fix for bug 5762, wireshark asserts on reading juniper snoop output when no hex data is present (snoop detail off).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36232
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 21 Mar 2011 19:33:19 +0000 (19:33 +0000)]
Fix an "infinite loop" defect reported by Coverity Prevent (Coverity 430 (run 616)).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36231
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 21 Mar 2011 18:58:48 +0000 (18:58 +0000)]
Corrected decoding of oid values with length 5.
This fixes coverity 340.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36230
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 21 Mar 2011 18:54:10 +0000 (18:54 +0000)]
Re-arrange code slightly to remove a false positive Coverity Prevent "Forward Null" defect report.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36229
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 21 Mar 2011 18:33:18 +0000 (18:33 +0000)]
Added some casts to fix coverity 325.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36228
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 21 Mar 2011 17:34:58 +0000 (17:34 +0000)]
Add a comment re a "suspicious" sizeof() reported by Coverity Prevent.
(The report seems correct but I'm not altogether sure).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36227
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 21 Mar 2011 17:07:18 +0000 (17:07 +0000)]
Don't close file handle if a file write error; (caller does the close)
Fixes "USE_AFTER_FREE" defect reported by Coverity Prevent.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36226
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 21 Mar 2011 16:57:11 +0000 (16:57 +0000)]
Fix a comment; Use consistent indentatation & formatting.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36225
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 21 Mar 2011 14:52:54 +0000 (14:52 +0000)]
#if out another unused routine.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36224
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 21 Mar 2011 13:28:20 +0000 (13:28 +0000)]
From Jakub Zawadzki via wireshark-dev: Fix comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36223
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 21 Mar 2011 08:21:51 +0000 (08:21 +0000)]
#if 0-out an unused routine.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36222
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 20 Mar 2011 23:09:36 +0000 (23:09 +0000)]
Add Python 3 support via 2to3.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36221
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 20 Mar 2011 22:36:57 +0000 (22:36 +0000)]
expert_dlg.c:603: warning: 'expert_dlg_cb' defined but not used
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36220
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 20 Mar 2011 19:33:07 +0000 (19:33 +0000)]
Don't register the Exper info dialogue as a first step of removal.
Should the common routines be moved into expet_comp_dlg.[ch]?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36219
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 20 Mar 2011 15:03:47 +0000 (15:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-03-20]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36216
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 20 Mar 2011 12:38:31 +0000 (12:38 +0000)]
Added a configure message when having c-ares instead of adns.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36215
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2011 00:47:18 +0000 (00:47 +0000)]
From Roland Knall <rknall [AT] gmail.com>: allow heuristic subdissectors
for SERCOS III packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36214
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2011 00:05:39 +0000 (00:05 +0000)]
Clean up indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36213
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 19 Mar 2011 11:09:03 +0000 (11:09 +0000)]
From James Deucker via bug 5766:
Mark some unused arguments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36212
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 18 Mar 2011 20:02:45 +0000 (20:02 +0000)]
From Alexis La Goutte submitted in bug 5759: Use ENC_NA where appropriate.
From me: Remove unused header fields found by checkhf.pl. One more ENC_NA.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36211
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 17 Mar 2011 20:17:09 +0000 (20:17 +0000)]
All fields are little-endian. Fixes bug 5759 reported by Tang Fulin.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36210
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 17 Mar 2011 19:53:28 +0000 (19:53 +0000)]
Don't clobber the capinfos data if we have a valid capture file. This
should let the original file information show up in bug reports.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36209
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Thu, 17 Mar 2011 16:00:13 +0000 (16:00 +0000)]
Respond to most of the clang warnings for this dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36208
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 17 Mar 2011 15:37:28 +0000 (15:37 +0000)]
From Jakub Zawadzki: Simpler patch to resolve bug 5755 to properly display all
strings in dissect_octet_string() without having to allocate extra memory.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36207
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 17 Mar 2011 13:27:23 +0000 (13:27 +0000)]
As per bug 5751, these header files are no longer needed/used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36206
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 17 Mar 2011 13:18:27 +0000 (13:18 +0000)]
Add README.heuristic to the source distribution
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36205
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 16 Mar 2011 23:18:59 +0000 (23:18 +0000)]
Avoid some unnecessary assignments (as reported by clang).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36204
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 16 Mar 2011 23:01:33 +0000 (23:01 +0000)]
Don't increment after reading last outheader value (as reported by clang).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36203
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 16 Mar 2011 22:53:41 +0000 (22:53 +0000)]
Avoid having large buffers on the stack (as noted in VS Code Analyzer warnings).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36202
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 16 Mar 2011 22:51:45 +0000 (22:51 +0000)]
2 VS Code Analyzer warnings were bogus. Avoid one and add a comment about the second one.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36201
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 16 Mar 2011 20:32:53 +0000 (20:32 +0000)]
From Jakub Zawadzki: Annotate Jakub as the author of the JSON dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36200
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 16 Mar 2011 14:51:53 +0000 (14:51 +0000)]
From Fulko Hew via bug 5755: Fix dissect_octet_string() so it properly displays
strings of any length.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36199
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 16 Mar 2011 06:21:56 +0000 (06:21 +0000)]
From Roland Knall:
Patch, which removes both EPL and EPLv1 .h files, as well as adding a heuristic dissector hook to EPL (v1 is nearly nowhere in use anymore, therefore not needed)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5751
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36198
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 15 Mar 2011 22:55:53 +0000 (22:55 +0000)]
Try to fix checkApi script.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36197
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 15 Mar 2011 17:30:00 +0000 (17:30 +0000)]
Fix calling of LTE dissectors for R9 DCT protocols.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36196
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 15 Mar 2011 06:03:58 +0000 (06:03 +0000)]
Add dissection of
- MBMS-SESSION-STOP-REQUEST
- MBMS-SESSION-STOP-RESPONSE
- MBMS-SESSION-UPDATE-REQUEST
- MBMS-SESSION-UPDATE-RESPONSE
- PS-HANDOVER-COMPLETE
- PS-HANDOVER-CANCEL
- PS-HANDOVER-COMPLETE-ACK
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36195
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 14 Mar 2011 22:01:49 +0000 (22:01 +0000)]
Add expert info to UDP dissector for showing possible (Unix-style)
traceroute packets: if the port number range is 33434 to 33434 + 30.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36194
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 14 Mar 2011 19:58:02 +0000 (19:58 +0000)]
Don't verify the checksum of an ICMP packet when it the payload of an
error packet (pinfo->in_error_pkt), such as an ICMP destination
unreachable, because we probably don't have the whole original packet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36193
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 14 Mar 2011 16:00:51 +0000 (16:00 +0000)]
Properly initialize our filter counters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36190
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 14 Mar 2011 14:05:51 +0000 (14:05 +0000)]
Export
tvb_new_composite
tvb_composite_finalize
tvb_composite_append
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36188
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Mon, 14 Mar 2011 07:49:05 +0000 (07:49 +0000)]
Fix for bug 3933:
Decode TCP port 2443 as Secure Skinny (SCCPS).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36187
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 14 Mar 2011 07:15:25 +0000 (07:15 +0000)]
Add dissection of
- MBMS-SESSION-START-REQUEST
- MBMS-SESSION-START-RESPONSE
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36186
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 13 Mar 2011 15:03:43 +0000 (15:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-03-13]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36183
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 13 Mar 2011 09:33:45 +0000 (09:33 +0000)]
../../../epan/dissectors/packet-gtp.c:5607: error: unused variable ‘length’
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36182
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 12 Mar 2011 23:26:55 +0000 (23:26 +0000)]
Add sub dissection of AVP MBMS Service Area.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36181
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sat, 12 Mar 2011 19:02:24 +0000 (19:02 +0000)]
Fix bug #5189: Wireshark crashes when cancelling a large sort operation.
Essentially: Don't try to sort if the pre-requisite "columnization" step is stopped
via the progressbar dialog window before the step completes.
Also: Fix a (very) minor bug wherein the sort-indicator not always cleared on the
"previous column" when "No Sorting" was selected from a column context menu.
Also: Do minor code, comments & whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36180
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 12 Mar 2011 12:09:52 +0000 (12:09 +0000)]
Use TRUE/FALSE for encoding_info to make it build.
Added packet-mndp.c to Makefile build.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36179
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Sat, 12 Mar 2011 02:06:25 +0000 (02:06 +0000)]
Improve r36177 per Guy's suggestion at bug #5746 to always call the
PPP-over-HDLC dissector since it will do the check for us to see if
the HDLC framing is present or not.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36178
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Sat, 12 Mar 2011 01:32:35 +0000 (01:32 +0000)]
Handle PPP in HDLC framing. Fixes bug 5746.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36177
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 9 Mar 2011 17:20:29 +0000 (17:20 +0000)]
Add emem_tree_lookup32_array_le. Resolves bug 5744.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36176
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Wed, 9 Mar 2011 13:27:13 +0000 (13:27 +0000)]
Update/correct some TLVs
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36175
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 9 Mar 2011 00:43:49 +0000 (00:43 +0000)]
Check that imported private key is RSA; Prevents a crash.
Fixes Bug #5662
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5662
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36174
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 8 Mar 2011 21:21:48 +0000 (21:21 +0000)]
Display a console warning instead of a simple_dialog for invalid color filters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36173
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Tue, 8 Mar 2011 20:23:48 +0000 (20:23 +0000)]
A little more old packet list cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36172
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 8 Mar 2011 19:55:22 +0000 (19:55 +0000)]
W -> E for g_clist funktions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36171
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 8 Mar 2011 19:10:46 +0000 (19:10 +0000)]
Add support for Mikrotiks Neigbor Discovery Protocol (MNDP).
Sample capture at
http://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=mndp.pcap
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36170
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 8 Mar 2011 18:52:12 +0000 (18:52 +0000)]
Don't bother creating/finding conversations if we're encapsulated within an
error packet, such as an ICMP destination unreachable. Prior to this change,
I had captures that showed such encapsulated requests with responses indicated
in other frames, which obviously can't be true.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36169
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 8 Mar 2011 18:33:45 +0000 (18:33 +0000)]
Conversation tracking must be handled whether "tree" is NULL or not.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36168
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 8 Mar 2011 18:29:30 +0000 (18:29 +0000)]
Add support for the pre-rfc DAE port 1700
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36167
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 8 Mar 2011 14:57:38 +0000 (14:57 +0000)]
Allow <variance> to be successfully sscanf'd no matter the locale for the
decimal symbol. Same change and reason as for revision 36160.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36166
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 8 Mar 2011 14:55:07 +0000 (14:55 +0000)]
Remove the 'NEW_PACKET_LIST' defines & etc (since the code no longer supports the old packet list)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36165
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 8 Mar 2011 14:41:12 +0000 (14:41 +0000)]
Remove the --enable-new-packet-list option (since the code no longer supports the old packet list)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36164
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 8 Mar 2011 13:52:16 +0000 (13:52 +0000)]
From Martin Kaiser: initialize hdr_tag with NO_TAG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36163
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Tue, 8 Mar 2011 11:26:34 +0000 (11:26 +0000)]
Fix for bug 5743 : tshark incorrectly calculates tcp stream for SYN packets when port numbers are re-used
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36162
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Tue, 8 Mar 2011 01:52:25 +0000 (01:52 +0000)]
Removal of the old packet-list in favor of the new packet list.
It compiles with "./configure without options" on my Mac. Let's see what the buildbots have to say about it :-)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36161
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 7 Mar 2011 21:58:30 +0000 (21:58 +0000)]
Allow <interval> to be successfully sscanf'd no matter the locale for the
decimal symbol. Similar to the fix made to tap-iostat.c to resolve bug 2880.
Motivated by the discussion started from this thread on the user list:
http://www.wireshark.org/lists/wireshark-users/201103/msg00018.html
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36160
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 7 Mar 2011 19:23:55 +0000 (19:23 +0000)]
Don't pass retransmitted chunks to subdissectors. Instead just mark them as
retranmissions (in COL_INFO). (Obviously this only works if TSN analysis is
enabled.)
This should make it more obvious to users which chunks are retransmissions and
will help avoid confusing the subdissector(s).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36159
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 7 Mar 2011 17:46:30 +0000 (17:46 +0000)]
From Alexis La Goutte:
enhance tag Power Constraint/Capability, TPC Request/Report, Supported Channel, csa
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5660
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36158
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 7 Mar 2011 17:01:55 +0000 (17:01 +0000)]
Squelch compiler warning:
packet-dvbci.c: In function 'dissect_dvbci_lpdu':
packet-dvbci.c:1153: warning: 'hdr_tag' may be used uninitialized in this function
packet-dvbci.c:1153: note: 'hdr_tag' was declared here
By setting hdr_tag = 0, but see question on bug #5654 on whether 0 is a
good default value or not.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36157
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 7 Mar 2011 16:43:55 +0000 (16:43 +0000)]
From Stefan Metzmacher: smb2 multi-credit / large mtu support
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5729
From me: Update a comment re the "epoch" field: It's now called "credit charge".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36156
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 7 Mar 2011 12:31:49 +0000 (12:31 +0000)]
Remove a no longer needed struct.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36155
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 7 Mar 2011 11:56:21 +0000 (11:56 +0000)]
Remove more obsolete code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36154
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 7 Mar 2011 10:01:24 +0000 (10:01 +0000)]
Fix packet-bssgp.c:125: warning: 'hf_bssgp_tmsi_ptmsi' defined but not used
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36153
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 7 Mar 2011 09:36:24 +0000 (09:36 +0000)]
Remove the old code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36152
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 7 Mar 2011 03:10:51 +0000 (03:10 +0000)]
Fix compiler error on Windows 64: cast strlen() to (int);
Also: Apparently the length of an address of type AT_STRINGZ must include the NULL.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36151
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 7 Mar 2011 02:44:38 +0000 (02:44 +0000)]
Set properties
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36150
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 7 Mar 2011 02:22:48 +0000 (02:22 +0000)]
From Martin Kaiser: dissector for DVB-CI (Common Interface)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654
From me:
- Entry for DVBCI added to wtap.c encap_table_base[];
- Some code simplification with respect to the use of col_...() for COL_INFO;
- Certain tests for "enough bytes available" not really needed;
- (Other minor tweaks);
- #include<stdio.h> not req'd;
- Minor reformatting and whitespace cleanup;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36149
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Sun, 6 Mar 2011 23:10:28 +0000 (23:10 +0000)]
Remove some instances of _U_ where the parameter is now used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36148
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Sun, 6 Mar 2011 22:52:33 +0000 (22:52 +0000)]
Improve expert info output when detect Scheduling Request 'state machine' problem.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36147
f5534014-38df-0310-8fa8-
9805f1628bb7