obnox/wireshark/wip.git
14 years agoUpdate references to the WinPcap Web site.
guy [Sat, 11 Jun 2005 19:02:31 +0000 (19:02 +0000)]
Update references to the WinPcap Web site.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14615 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd missing #include "webbrowser.h" from previous commit
ulfl [Sat, 11 Jun 2005 16:50:18 +0000 (16:50 +0000)]
add missing #include "webbrowser.h" from previous commit

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14614 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd Angelo Bannack as an author.
etxrab [Sat, 11 Jun 2005 16:03:24 +0000 (16:03 +0000)]
Add Angelo Bannack as an author.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14613 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Angelo Bannack,
etxrab [Sat, 11 Jun 2005 15:58:01 +0000 (15:58 +0000)]
From Angelo Bannack,
 A CSM_ENCAPS dissector to use with ethereal.
The CSM_ENCAPS is a protocol used by MindSpeed to communicate with your products, and configure VoIP channels.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14612 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd help button pointing to the wiki page
ulfl [Sat, 11 Jun 2005 12:12:12 +0000 (12:12 +0000)]
add help button pointing to the wiki page

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14611 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothis is an attempt, please report problems:
ulfl [Fri, 10 Jun 2005 19:09:49 +0000 (19:09 +0000)]
this is an attempt, please report problems:

after asking the devlist if this would break things and got no negative response, try to scan command line parameters twice, trying to "rewind" the getopt settings

this way, fixing #135

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14610 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't call g_assert_not_reached() for an unknown port type
ulfl [Fri, 10 Jun 2005 18:30:33 +0000 (18:30 +0000)]
don't call g_assert_not_reached() for an unknown port type

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14609 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agojust to get things straight: a dissector should *never* do any g_assert() calls!
ulfl [Fri, 10 Jun 2005 18:28:22 +0000 (18:28 +0000)]
just to get things straight: a dissector should *never* do any g_assert() calls!

in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED()

this will replace application crash by showing a dissector bug, which is the desired behaviour

there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too

one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14608 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFixed indentation and removed control characters, in an attempt to understand why...
lego [Fri, 10 Jun 2005 16:23:22 +0000 (16:23 +0000)]
Fixed indentation and removed control characters, in an attempt to understand why windows fail to compile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14607 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInitial checkin of the 32 bit tektronix k12 binary format (rf5)
lego [Fri, 10 Jun 2005 16:01:16 +0000 (16:01 +0000)]
Initial checkin of the 32 bit tektronix k12 binary format (rf5)

There is still much to do, but at the very least it can import files allowing the user to choose which protocols handle the diferent sources.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14606 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd Julian Onions
ulfl [Thu, 9 Jun 2005 22:49:08 +0000 (22:49 +0000)]
add Julian Onions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14605 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Julian Onions: add more about protocol dissection to the developer's guide
ulfl [Thu, 9 Jun 2005 22:46:41 +0000 (22:46 +0000)]
from Julian Onions: add more about protocol dissection to the developer's guide

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14604 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoraise plugin version from 0.1.0 to 0.1.1 as some bugs were found using fuzz-test...
ulfl [Thu, 9 Jun 2005 20:08:39 +0000 (20:08 +0000)]
raise plugin version from 0.1.0 to 0.1.1 as some bugs were found using fuzz-test.sh since the last Ethereal release

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14603 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix positions of create_console()/destroy_console() calls for help and version output
ulfl [Thu, 9 Jun 2005 19:58:02 +0000 (19:58 +0000)]
fix positions of create_console()/destroy_console() calls for help and version output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14602 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobugfix: don't crash, if cf->filename is NULL (which happens if an invalid capture...
ulfl [Thu, 9 Jun 2005 19:55:55 +0000 (19:55 +0000)]
bugfix: don't crash, if cf->filename is NULL (which happens if an invalid capture filter is entered)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14601 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd some more details of the RT protocols frame ID's
ulfl [Thu, 9 Jun 2005 19:52:10 +0000 (19:52 +0000)]
add some more details of the RT protocols frame ID's

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14600 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd some more details to the files section
ulfl [Thu, 9 Jun 2005 19:49:56 +0000 (19:49 +0000)]
add some more details to the files section

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14599 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange "colorfilter" to "colorfilters". Fix up whitespace.
gerald [Thu, 9 Jun 2005 18:24:55 +0000 (18:24 +0000)]
Change "colorfilter" to "colorfilters".  Fix up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14598 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd dissection of parlay
etxrab [Thu, 9 Jun 2005 17:25:40 +0000 (17:25 +0000)]
Add dissection of parlay
www.parlay.org

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14597 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowe possibly have global cfilters/dfilters files now
ulfl [Thu, 9 Jun 2005 08:03:34 +0000 (08:03 +0000)]
we possibly have global cfilters/dfilters files now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14596 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoprovide global default files for cfilters/colorfilters/dfilters
ulfl [Thu, 9 Jun 2005 07:43:32 +0000 (07:43 +0000)]
provide global default files for cfilters/colorfilters/dfilters

at least the colorfilters file needs some more "finetuning"

NSIS (Win32): install these files into the Ethereal Program dir, but don't overwrite existing ones

makefile.am: I've added the three files to EXTRA_DIST and pkgdata_DATA, which *seems* to be the right places

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14595 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to read the "cfilters"/"dfilters" config files from the global path (program...
ulfl [Thu, 9 Jun 2005 06:58:03 +0000 (06:58 +0000)]
Try to read the "cfilters"/"dfilters" config files from the global path (program dir), if no personal versions of these files are available.

This is the same behaviour, as we do it for the colorfilters/preferences/... files already.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14594 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou
etxrab [Thu, 9 Jun 2005 05:40:26 +0000 (05:40 +0000)]
From Mike Duigou
Minor corrections to README.developer and README.tapping

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14593 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Tim Endean:
etxrab [Thu, 9 Jun 2005 04:28:13 +0000 (04:28 +0000)]
From Tim Endean:
Check for tvb.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14592 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Olivier Jacques,
etxrab [Wed, 8 Jun 2005 18:53:11 +0000 (18:53 +0000)]
From Olivier Jacques,
- beautify TCAP decoding without upper dissector associated.
With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14591 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Olivier Jacques,
etxrab [Wed, 8 Jun 2005 18:52:34 +0000 (18:52 +0000)]
From Olivier Jacques,
- beautify TCAP decoding without upper dissector associated.
With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14590 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBreak out of an infinite loop. Fixes bug 232.
gerald [Wed, 8 Jun 2005 15:32:00 +0000 (15:32 +0000)]
Break out of an infinite loop.  Fixes bug 232.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14589 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a problem if the tools have a space char in their path
ulfl [Wed, 8 Jun 2005 06:40:17 +0000 (06:40 +0000)]
fix a problem if the tools have a space char in their path

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14588 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd some general and some cygwin related comments
ulfl [Wed, 8 Jun 2005 06:33:49 +0000 (06:33 +0000)]
add some general and some cygwin related comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14587 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCahnge ssn range
etxrab [Wed, 8 Jun 2005 05:06:30 +0000 (05:06 +0000)]
Cahnge ssn range

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14586 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Tim Endean:
etxrab [Wed, 8 Jun 2005 05:04:26 +0000 (05:04 +0000)]
From Tim Endean:
Fix ssn range

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14585 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a typo.
etxrab [Wed, 8 Jun 2005 05:03:36 +0000 (05:03 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14584 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom: Martin Mathieson
lego [Tue, 7 Jun 2005 23:25:46 +0000 (23:25 +0000)]
From: Martin Mathieson

fix cases where %d has been used instead of %u...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14583 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomake sure that colifo gets set and put some other useful info there
lego [Tue, 7 Jun 2005 23:22:37 +0000 (23:22 +0000)]
make sure that colifo gets set and put some other useful info there

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14582 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some ethertypes
etxrab [Tue, 7 Jun 2005 20:57:27 +0000 (20:57 +0000)]
Add some ethertypes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14581 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some ethertypes
etxrab [Tue, 7 Jun 2005 20:56:54 +0000 (20:56 +0000)]
Add some ethertypes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14580 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSome fixes from Tim Endean
etxrab [Tue, 7 Jun 2005 20:30:04 +0000 (20:30 +0000)]
Some fixes from Tim Endean

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14579 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSome fixes from Tim Endean
etxrab [Tue, 7 Jun 2005 20:29:23 +0000 (20:29 +0000)]
Some fixes from Tim Endean

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14578 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alejandro Vaquero:
etxrab [Tue, 7 Jun 2005 15:21:22 +0000 (15:21 +0000)]
From Alejandro Vaquero:
glib-object.h is is glib2 only.
 graph_analysis.c:47:25: glib-object.h: No such file or directory
 a patch for ths issue and also to correct the "first_item"
issue reported in "RE: [Ethereal-dev] Voip graph analysis "Save as" button"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14577 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUsage of new #.FN_PARS directive instead of #.FN_BODY
kukosa [Tue, 7 Jun 2005 12:05:03 +0000 (12:05 +0000)]
Usage of new #.FN_PARS directive instead of #.FN_BODY

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14576 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- usage of dissect_per_null() and dissect_ber_null()
kukosa [Tue, 7 Jun 2005 11:58:22 +0000 (11:58 +0000)]
- usage of dissect_per_null() and dissect_ber_null()
- new #.FN_PARS directive (implemented only for OCTET STRING and INTEGER now)
- set true value strings for named bits

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14575 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Tim Endean:
etxrab [Tue, 7 Jun 2005 05:50:28 +0000 (05:50 +0000)]
From Tim Endean:

- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14574 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Tim Endean:
etxrab [Tue, 7 Jun 2005 05:49:57 +0000 (05:49 +0000)]
From Tim Endean:

- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14573 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Tim Endean:
etxrab [Tue, 7 Jun 2005 05:49:06 +0000 (05:49 +0000)]
From Tim Endean:

- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14572 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLet the sub dissector use the top tree.
etxrab [Mon, 6 Jun 2005 20:42:18 +0000 (20:42 +0000)]
Let the sub dissector use the top tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14571 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Julian Onions: add a devel section about start writing a dissector
ulfl [Mon, 6 Jun 2005 20:32:08 +0000 (20:32 +0000)]
from Julian Onions: add a devel section about start writing a dissector

some editing by me ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14570 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoregister the dissector so that it can be found
lego [Mon, 6 Jun 2005 18:53:43 +0000 (18:53 +0000)]
register the dissector so that it can be found

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14569 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- add an hf entry I forgot
lego [Mon, 6 Jun 2005 18:52:54 +0000 (18:52 +0000)]
- add an hf entry I forgot
- get the STAT/USTAT PDU list straight

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14568 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- make sure there's something to add to colinfo.
lego [Mon, 6 Jun 2005 18:51:05 +0000 (18:51 +0000)]
- make sure there's something to add to colinfo.
- auditValueRequest is a request too

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14567 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothe trailer's offset and len were not ok.
lego [Mon, 6 Jun 2005 18:45:47 +0000 (18:45 +0000)]
the trailer's offset and len were not ok.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14566 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDissector for ISUP over TCP.
etxrab [Mon, 6 Jun 2005 18:01:58 +0000 (18:01 +0000)]
Dissector for ISUP over TCP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14565 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd makefile.nmake
etxrab [Mon, 6 Jun 2005 17:40:07 +0000 (17:40 +0000)]
Add makefile.nmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14564 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd an ifdef and "dont apply patch twice".
etxrab [Mon, 6 Jun 2005 17:08:37 +0000 (17:08 +0000)]
Add an ifdef and "dont apply patch twice".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14563 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a typo and add an ifdef
etxrab [Mon, 6 Jun 2005 17:07:04 +0000 (17:07 +0000)]
Fix a typo and add an ifdef

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14562 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd the asn2eth generated TCAP dissector made by Tim Endean to the SVN tree.
etxrab [Mon, 6 Jun 2005 15:39:20 +0000 (15:39 +0000)]
Add the asn2eth generated TCAP dissector made by Tim Endean to the SVN tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14561 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd the asn2eth genereated TCAP dissector to SVN
etxrab [Mon, 6 Jun 2005 15:37:12 +0000 (15:37 +0000)]
Add the asn2eth genereated TCAP dissector to SVN

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14560 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Mon, 6 Jun 2005 15:22:17 +0000 (15:22 +0000)]
From Mike Duigou:
 a patch which adds support for displaying jxta
conversations and endpoints from the 'Statistics' menu. Also adds :

  - a generated field to Welcome messages to indicate whether this
welcome is from the initiator or the receiver. You can filter on this
field with 'jxta.welcome.initiator==[0|1]'

  - Marks the source and destination fields of message added in the last
patch as generated fields. (Saw it being done for some other protocol).

  - Cleans up dissection of Message which used to assume it would
dissected more than one set of hdr/message per tvbuff. Now it only
attempts to dissect one.

- Uses GMemChunk for tap info and for conversation data rather than
g_malloc() There's still a major leakage of g_malloc()ed the c-strings
which are used in jxta addresses. Any suggestions for how these can be
allocated such that they can be freed re-init is called would be
appreciated. For address objects whose data ptr doesn't point into a
tvbuff it's not clear what the lifecyle of an address object is.

  - Fixes a bug with filling in the of the transport layer conversation
data. >= vs. >

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14559 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Mon, 6 Jun 2005 15:20:10 +0000 (15:20 +0000)]
From Mike Duigou:
 a patch which adds support for displaying jxta
conversations and endpoints from the 'Statistics' menu. Also adds :

  - a generated field to Welcome messages to indicate whether this
welcome is from the initiator or the receiver. You can filter on this
field with 'jxta.welcome.initiator==[0|1]'

  - Marks the source and destination fields of message added in the last
patch as generated fields. (Saw it being done for some other protocol).

  - Cleans up dissection of Message which used to assume it would
dissected more than one set of hdr/message per tvbuff. Now it only
attempts to dissect one.

- Uses GMemChunk for tap info and for conversation data rather than
g_malloc() There's still a major leakage of g_malloc()ed the c-strings
which are used in jxta addresses. Any suggestions for how these can be
allocated such that they can be freed re-init is called would be
appreciated. For address objects whose data ptr doesn't point into a
tvbuff it's not clear what the lifecyle of an address object is.

  - Fixes a bug with filling in the of the transport layer conversation
data. >= vs. >

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14558 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Mon, 6 Jun 2005 15:17:41 +0000 (15:17 +0000)]
From Mike Duigou:

 a patch to to_str.c which adds support for printing
AT_STRINGZ address type. Amazing that this wasn't there!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14557 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alejandro Vaquero:
etxrab [Mon, 6 Jun 2005 14:01:04 +0000 (14:01 +0000)]
From Alejandro Vaquero:

- Add a pane to contain  the main graph and the comments to be able to
split them
- Change the main graph area to be a scrolled_window
- Change the look of the selected item to be blue with white text color
- Gray color the title area
- Change the conversations color to more "soft" colors (it was difficult
to read in some cases before)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14556 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Richard Rabbat:
etxrab [Mon, 6 Jun 2005 13:55:47 +0000 (13:55 +0000)]
From Richard Rabbat:
a patch for a couple of fixes to rsvp sub-objects.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14555 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoif some PER errors has to be put to the stderr, give at least info where it's coming...
ulfl [Sat, 4 Jun 2005 22:05:50 +0000 (22:05 +0000)]
if some PER errors has to be put to the stderr, give at least info where it's coming from (__FILE__ and __LINE__)

BTW: time for something like a "NotImplementedException"?!?, this seems to be a common mechanism, if a dissector hasn't implemented all protocol elemements (yet)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14554 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some more leaks in error returns from open routines (if the open can
guy [Sat, 4 Jun 2005 21:58:55 +0000 (21:58 +0000)]
Fix some more leaks in error returns from open routines (if the open can
fail after the private data is allocated, you have to free the private
data).

The file header in nettl files is 128 bytes - use a #define for it, and
also a #define for the magic number size.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14553 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #225-#231: the enum lmp_filter_keys contained holes, so the logic to detect the...
ulfl [Sat, 4 Jun 2005 21:39:36 +0000 (21:39 +0000)]
fix #225-#231: the enum lmp_filter_keys contained holes, so the logic to detect the field type failed, resulting in the bug

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14552 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGive the user the ability to decide how to decode USER DLTs
lego [Sat, 4 Jun 2005 19:22:39 +0000 (19:22 +0000)]
Give the user the ability to decide how to decode USER DLTs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14551 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #201 second part: adapt the string length of the unformatted text, so it won...
ulfl [Sat, 4 Jun 2005 11:47:38 +0000 (11:47 +0000)]
fix #201 second part: adapt the string length of the unformatted text, so it won't show \000 and beyond

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14550 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #224: hierarchy stats had problems with the new generated toplevel desegmentation...
ulfl [Sat, 4 Jun 2005 10:23:10 +0000 (10:23 +0000)]
fix #224: hierarchy stats had problems with the new generated toplevel desegmentation items "[Reassembled TCP Segments]"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14549 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoupdate to changes done in the menu
ulfl [Sat, 4 Jun 2005 04:57:10 +0000 (04:57 +0000)]
update to changes done in the menu

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14548 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomake a complete redesign of the files section
ulfl [Sat, 4 Jun 2005 04:14:02 +0000 (04:14 +0000)]
make a complete redesign of the files section

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14547 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #220: the automatic display of the vertical scrollbar at the packet list doesn...
ulfl [Sat, 4 Jun 2005 02:06:16 +0000 (02:06 +0000)]
fix #220: the automatic display of the vertical scrollbar at the packet list doesn't seem to work in all cases (not shown although scrolling would be necessary)

as I don't see a way to fix this (and it just don't really hurt, as this scrollbar is usually shown anyway if some more packets have to be display) just show it always

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14546 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoupdate usage output and manual pages for both Ethereal and Tethereal to reflect the...
ulfl [Sat, 4 Jun 2005 01:29:14 +0000 (01:29 +0000)]
update usage output and manual pages for both Ethereal and Tethereal to reflect the latest changes in the command line.

clarifications of some command line parameter descriptions in the manual pages

this also fixes #221

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14545 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix the PDU list, and put it at the bottom
lego [Fri, 3 Jun 2005 14:02:06 +0000 (14:02 +0000)]
fix the PDU list, and put it at the bottom

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14544 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agokeywords and eol-style
lego [Fri, 3 Jun 2005 13:54:34 +0000 (13:54 +0000)]
keywords and eol-style

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14543 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- add a way to call the sscop dissector with an arbitrary handle\
lego [Fri, 3 Jun 2005 13:50:30 +0000 (13:50 +0000)]
- add a way to call the sscop dissector with an arbitrary handle\
- make most fields "filterable"
- dissect stat and ustat pdu lists

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14542 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRegister the ISUP dissector to make it callable through
etxrab [Fri, 3 Jun 2005 09:56:03 +0000 (09:56 +0000)]
Register the ISUP dissector to make it callable through
call_dissector()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14541 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate URLs and domain names that refer to the WinPcap site.
guy [Fri, 3 Jun 2005 09:55:28 +0000 (09:55 +0000)]
Update URLs and domain names that refer to the WinPcap site.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14540 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Fri, 3 Jun 2005 06:37:05 +0000 (06:37 +0000)]
From  Mike Duigou:
Fixes a problem with the RPM spec which prevents it from
working with current versions of rpmbuild.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14539 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Fri, 3 Jun 2005 06:36:07 +0000 (06:36 +0000)]
From  Mike Duigou:
A few doxygen updates and an improved section on
writing dissectors that don't use tcp_dissect_pdus().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14538 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Fri, 3 Jun 2005 06:35:44 +0000 (06:35 +0000)]
From  Mike Duigou:
A few doxygen updates and an improved section on
writing dissectors that don't use tcp_dissect_pdus().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14537 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Fri, 3 Jun 2005 06:34:35 +0000 (06:34 +0000)]
From Mike Duigou:
A few doxygen updates and an improved section on
writing dissectors that don't use tcp_dissect_pdus().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14536 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Fri, 3 Jun 2005 06:31:58 +0000 (06:31 +0000)]
From Mike Duigou:
 A minor change to the prototype of tcp_dissect_pdus()
which uses the function pointer type from packet.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14535 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Fri, 3 Jun 2005 06:29:25 +0000 (06:29 +0000)]
From Mike Duigou:

Extends the jxta dissector to add higher level conversation
tracking, improved display, tapping and fixes a bug which caused some
conversations to get lost.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14534 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdated LMP to handle the latest protocol. Removed old protocol values
ashokn [Thu, 2 Jun 2005 22:49:59 +0000 (22:49 +0000)]
Updated LMP to handle the latest protocol. Removed old protocol values
since they are no longer useful.

Manu Pathak <mapathak@cisco.com> contributed these changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14533 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix call to show_fragment_seq_tree() reported by buildbot
ulfl [Thu, 2 Jun 2005 22:11:22 +0000 (22:11 +0000)]
fix call to show_fragment_seq_tree() reported by buildbot

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14532 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a generated toplevel line between the connectionless DCE/RPC protocol and the...
ulfl [Thu, 2 Jun 2005 20:55:58 +0000 (20:55 +0000)]
add a generated toplevel line between the connectionless DCE/RPC protocol and the defragmented DCE/RPC content, to better understand what's going on if defragmentation is done.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14531 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agouse [] not () brackets to indicate [correct] UDP checksum, as this is a generated...
ulfl [Thu, 2 Jun 2005 20:52:13 +0000 (20:52 +0000)]
use [] not () brackets to indicate [correct] UDP checksum, as this is a generated field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14530 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd length information to "Content-encoded entity body"
ulfl [Thu, 2 Jun 2005 20:03:15 +0000 (20:03 +0000)]
add length information to "Content-encoded entity body"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14529 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #223: add another tvb_ensure_bytes_exist() call
ulfl [Thu, 2 Jun 2005 19:31:16 +0000 (19:31 +0000)]
fix #223: add another tvb_ensure_bytes_exist() call

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14528 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a generated toplevel line between the TCP protocol and the desegmented content...
ulfl [Thu, 2 Jun 2005 18:52:55 +0000 (18:52 +0000)]
add a generated toplevel line between the TCP protocol and the desegmented content, to better understand what's going on while desegmenting.

We'll have to add similar mechanisms for other protocols as well...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14527 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobugfix (fuzz_tested): t2i can be zero, test at all places before using it
ulfl [Thu, 2 Jun 2005 18:44:17 +0000 (18:44 +0000)]
bugfix (fuzz_tested): t2i can be zero, test at all places before using it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14526 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobugfix (fuzz_tested): add tvb_ensure_bytes_exist() before adding a fragment at two...
ulfl [Thu, 2 Jun 2005 18:39:45 +0000 (18:39 +0000)]
bugfix (fuzz_tested): add tvb_ensure_bytes_exist() before adding a fragment at two places, otherwise we get an access violation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14525 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd new function proto_tree_move_item(), which will move an already existing proto_it...
ulfl [Thu, 2 Jun 2005 18:35:20 +0000 (18:35 +0000)]
add new function proto_tree_move_item(), which will move an already existing proto_item inside the tree (but it can't be moved to a different "tree level")

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14524 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoshow Ethernet and IPX addresses the same way as we do with other fields as well ...
ulfl [Thu, 2 Jun 2005 18:29:29 +0000 (18:29 +0000)]
show Ethernet and IPX addresses the same way as we do with other fields as well (e.g. IP addresses), first the converted value (e.g. IP address or manufaturer name) and then in brackets the "raw data"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14523 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobugfix: don't use match_strval() in combination with format strings (as it may return...
ulfl [Thu, 2 Jun 2005 07:29:24 +0000 (07:29 +0000)]
bugfix: don't use match_strval() in combination with format strings (as it may return NULL) but val_to_str()

I don't know if the output as hex is appropriate, someone with more WBXML knowledge might have a look (however, it's done for unknown values only)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14522 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoNote that this is *not* what you use if you're building from Subversion.
guy [Thu, 2 Jun 2005 07:17:08 +0000 (07:17 +0000)]
Note that this is *not* what you use if you're building from Subversion.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14521 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd the resolved Ethernet addresses to the "Ethernet II" summary line
ulfl [Thu, 2 Jun 2005 00:28:38 +0000 (00:28 +0000)]
add the resolved Ethernet addresses to the "Ethernet II" summary line

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14520 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a reference to the corresponding RFC's of the Differentiated Services field pref...
ulfl [Wed, 1 Jun 2005 23:47:55 +0000 (23:47 +0000)]
add a reference to the corresponding RFC's of the Differentiated Services field pref setting

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14519 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd some hidden fields to be able to filter on the resolved hostname "ip.host" /...
ulfl [Wed, 1 Jun 2005 23:44:24 +0000 (23:44 +0000)]
add some hidden fields to be able to filter on the resolved hostname "ip.host" / "ip.src_host" / "ip.dst_host", this was formerly not possible.

replace some deprecated proto_tree_add_..._hidden() calls by seperate calls by proto_tree_add_...() and PROTO_ITEM_SET_HIDDEN()

some other cosmetic changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14518 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomark some fields as generated and clarify some field descriptions
ulfl [Wed, 1 Jun 2005 21:28:40 +0000 (21:28 +0000)]
mark some fields as generated and clarify some field descriptions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14517 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoprevent "Dissector Bug": prevent a string processing of length 0
ulfl [Wed, 1 Jun 2005 19:19:40 +0000 (19:19 +0000)]
prevent "Dissector Bug": prevent a string processing of length 0

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14516 f5534014-38df-0310-8fa8-9805f1628bb7