jmayer [Tue, 16 Aug 2005 06:45:17 +0000 (06:45 +0000)]
Move SVNVERSION handling into version_info. That way, we won't have
to recompile tethereal.o etc each time the svn version has changed,
relinking is sufficient.
I'm not sure what to do about mergecap, as it currently doesn't link
against version_info, so it's "overhead" either way.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15371
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 16 Aug 2005 06:09:39 +0000 (06:09 +0000)]
Change to match more closely the way I read 802.11h, at least; I'm just
guessing about the "17" indicator for "management notification" frames -
I'm not sure whether, after paying USD 60 to get the current 802.11e
draft, Preview on my Mac could even decrypt it.
802.11h seems to say in 7.2.3.12 and 7.3.1.11 that the body of an Action
frame has a 1-byte Category field, with a value of 0 meaning "Spectrum
management", followed by, for Spectrum management, a 1-byte Action
field, with 0=Measurement Request, 1=Measurement Report, 2=TPC Request,
3=TPC Report, and 4=Channel Switch Announcement, followed by:
for all but Channel Switch Announcement, a 1-byte Dialog Token
followed by some tagged parameters;
for the Channel Switch announcement, some tagged parameters.
Show some fields given in decimal in various 802.11 specs in decimal,
not hex.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15370
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 16 Aug 2005 05:58:50 +0000 (05:58 +0000)]
From Peter Johansson: add an option to decode the client information,
and check the validity of messages a bit more carefully.
Reformat a bit so not as much code is missed by those of us who like
narrow editor windows.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15369
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 16 Aug 2005 02:04:02 +0000 (02:04 +0000)]
The real problem is that iTunes requests gzipped data and responds with
it, so unless you're reassembling headers and bodies the DAAP dissector
will see the gzipped crap. The HTTP dissector should perhaps not bother
handing gzipped or otherwise unusually-encoded bodies to subdissectors
if it's not undoing the encoding.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15368
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 16 Aug 2005 01:34:44 +0000 (01:34 +0000)]
gcc4 gets confused by the break statements, and I guess it thinks you
can reach them, and thus thinks you can fall off the end of
"fc_get_ftype()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15367
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 16 Aug 2005 01:24:19 +0000 (01:24 +0000)]
Note where a table comes from, and that we don't use it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15366
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Tue, 16 Aug 2005 01:01:17 +0000 (01:01 +0000)]
se_alloc not ep_alloc!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15365
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Tue, 16 Aug 2005 00:55:08 +0000 (00:55 +0000)]
more allocators se_alloc0() se_memdups() se_strdup() se_strndup() se_strdup_printf()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15364
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 15 Aug 2005 21:06:09 +0000 (21:06 +0000)]
- Update manuf
- Add some Extreme MAC addresses to wka.tmpl
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15363
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 15 Aug 2005 20:31:57 +0000 (20:31 +0000)]
- Change $1 to $@
- Don't exit if we can't find the scripts - try to continue anyway,
as they might be installed in some preconfigured system directory.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15362
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 15 Aug 2005 20:28:04 +0000 (20:28 +0000)]
When we create a new tvb, make sure the memory is freed at some point.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15361
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 15 Aug 2005 19:35:09 +0000 (19:35 +0000)]
TP-PI (TP-Parameter-Indicator) is optional.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15360
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 15 Aug 2005 15:50:25 +0000 (15:50 +0000)]
Properly dissect vlan flags
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15359
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 15 Aug 2005 12:41:08 +0000 (12:41 +0000)]
- Documentation update
- The slot and port numbers printed on the chassis are off by
one when compared to the transmitted values (reported by
Jim Young).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15358
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 15 Aug 2005 12:04:15 +0000 (12:04 +0000)]
ememify g_malloc() calls
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15357
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 15 Aug 2005 11:53:57 +0000 (11:53 +0000)]
ememify g_malloc() calls
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15356
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sun, 14 Aug 2005 23:25:20 +0000 (23:25 +0000)]
Some 'no previous declararion' warning fixes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15355
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 06:00:20 +0000 (06:00 +0000)]
ememify sip and at the same plug a memleak
every single time the sip dissector was called a 32byte or larger blob was g_malloced and never freed.
this not only leaks 32+ bytes + g_malloc bookkeeping overhead but also fragments memory so the real leak of memory is likely much bigger.
fix bad memleak
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15354
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 05:54:54 +0000 (05:54 +0000)]
ememify cip
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15353
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 05:50:14 +0000 (05:50 +0000)]
change a g_malloc() that was never released into ep_alloc()
this function would always leak memory when called.
this fixes a memleak in dcm
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15352
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 05:37:12 +0000 (05:37 +0000)]
ememify packet-x11
plug a memleak for ...].strptr that is alloced by g_malloc() but never released.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15351
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 01:48:43 +0000 (01:48 +0000)]
giop allocates only and never releases the memory from the gmemchunk so replace it with equivalen g_malloc() calls and get rid of the gmemchunks
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15350
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 01:41:55 +0000 (01:41 +0000)]
the tds dissector were only using a GMemChunk as a simple way to prevent memleaks in case of an exception. (reset the gmemchunk at the start of each packet)
replace this gmemchunk with ep_alloc()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15349
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 01:26:34 +0000 (01:26 +0000)]
remove two more GMemChunks
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15348
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 00:37:05 +0000 (00:37 +0000)]
get rid of another two GMemChunks
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15347
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 00:26:56 +0000 (00:26 +0000)]
Data sources have a lifetime spanning a single packet
so instead for g-alloc and g_free data
just use ep_alloc() that is automatically freed instead.
this also gets rid of one more GMemChunk
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15346
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 14 Aug 2005 00:10:41 +0000 (00:10 +0000)]
add dissection of two more SSC commands
add 4 commands from SMC to the SSC tables.
the fallback for missing commands/i.e. commands defined outside the SSC
only handles SPC I.e. If a command for SSC is missing in the SSC tables, assume it might be imported from SPC instead.
This fallback only works with opcodes imported from SPC.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15345
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 13 Aug 2005 22:35:50 +0000 (22:35 +0000)]
Use gboolean for Booleans.
Use "proto_tree_add_item()" whenever possible.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15344
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 13 Aug 2005 22:34:44 +0000 (22:34 +0000)]
Construct the tvbuff for the payload of an 802.3 packet to have the
appropriate length (min(reported length, captured data present)).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15343
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 13 Aug 2005 22:08:22 +0000 (22:08 +0000)]
Properly terminate the string generated for string items.
Use "format_text()" to handle non-printable characters in the display
string for those items.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15342
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 13 Aug 2005 22:05:01 +0000 (22:05 +0000)]
Get rid of unused variables.
Use "tvb_format_text()" and friends to format strings for display.
Don't throw an exception on errors if we can keep dissecting.
Use "PROTO_ITEM_SET_GENERATED()" to mark items as generated.
If an item covers real data, it's not generated.
Dissect WRITE FILEMARKS (6) (we already had a dissector, but it wasn't
being used).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15341
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 13 Aug 2005 18:52:41 +0000 (18:52 +0000)]
Add an item for CSM_ENCAPS.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15340
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 13 Aug 2005 18:49:57 +0000 (18:49 +0000)]
Fix another infinite loop found by randpkt.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15339
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 13 Aug 2005 10:17:20 +0000 (10:17 +0000)]
Get rid of an unused variable, don't include tcap.h and remove some redundant code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15338
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 13 Aug 2005 10:11:23 +0000 (10:11 +0000)]
From Peter Johansson:
mnc>>4; Should be replaced with mnc = mnc>>4;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15337
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 13 Aug 2005 08:10:12 +0000 (08:10 +0000)]
"fi" comes before "fr" in alphabetical order. (This also makes it match
the main "ethereal.desktop" file.)
Expand the RCS ID.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15336
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 13 Aug 2005 07:30:57 +0000 (07:30 +0000)]
Do the sequence number analysis *before* dissecting the payload, so we
don't have to worry about catching exceptions in the payload dissection
and doing the sequence number analysis - we weren't doing so in one
place. That also puts the sequence number analysis *before* the "TCP
payload" entry for payload being reassembled into a later packet.
XXX - should we do the tapping before dissecting the payload, too, so
that it gets done even if we throw an exception?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15335
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 13 Aug 2005 06:42:19 +0000 (06:42 +0000)]
Small optimization
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15334
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 13 Aug 2005 06:29:09 +0000 (06:29 +0000)]
Additions from current Suse and Debian
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15333
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 13 Aug 2005 06:21:37 +0000 (06:21 +0000)]
get rid of one more gmemchunk
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15332
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 13 Aug 2005 05:55:06 +0000 (05:55 +0000)]
Aplly those parts of ethereal_0.10.12-3.diff.gz
from Debian, that change debian/
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15331
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 13 Aug 2005 02:24:11 +0000 (02:24 +0000)]
more gmemchunk -> se_alloc() conversions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15330
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 13 Aug 2005 02:19:03 +0000 (02:19 +0000)]
start converting gmemchunk into se_alloc() in /epan
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15329
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 13 Aug 2005 01:29:31 +0000 (01:29 +0000)]
some more gmemchunk -> se_alloc() updates
there are only 5 gmemchunks left but they have different litetime for their allocations than the 100+ ones that have been removed.
The remaining 5 should be converted some other way.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15328
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 13 Aug 2005 00:03:12 +0000 (00:03 +0000)]
gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15327
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 23:57:01 +0000 (23:57 +0000)]
gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15326
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 23:46:46 +0000 (23:46 +0000)]
some gmemchunk -> se_alloc() improvements for tcp
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15325
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 23:34:59 +0000 (23:34 +0000)]
gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15324
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 23:29:19 +0000 (23:29 +0000)]
gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15323
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 23:17:30 +0000 (23:17 +0000)]
gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15322
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 23:00:01 +0000 (23:00 +0000)]
more gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15321
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 12 Aug 2005 22:55:58 +0000 (22:55 +0000)]
Fix dissector bug on last element of ESRP
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15320
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 22:12:32 +0000 (22:12 +0000)]
more gmemchunk->se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15319
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 21:29:06 +0000 (21:29 +0000)]
gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15318
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 21:21:49 +0000 (21:21 +0000)]
gmemchunk -> se_alloc() updates
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15317
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 12 Aug 2005 21:08:02 +0000 (21:08 +0000)]
From Hannes Gredler
- add support for Multi-Link Frame-Relay (FRF.15) captures
taken on Juniper ML-, LS-, AS- PICs.
- rework of the common juniper header dissector:
test the extension flag (0x80) which indicates that there are
meta-information like interface-index, interface-name etc.
present
- minor bugfix (LSQ L3-proto masks, direction masks were broken)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15316
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 12 Aug 2005 16:32:28 +0000 (16:32 +0000)]
Don't try to allocate more than ITEM_LABEL_LENGTH bytes for something we're
adding to the tree. Fixes bugs 349 and 352.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15315
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 12 Aug 2005 15:27:11 +0000 (15:27 +0000)]
Fix the length that we pass to proto_tree_add_uint_format() so that we don't
throw a dissector error. Fixes bug 348.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15314
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 12 Aug 2005 14:05:38 +0000 (14:05 +0000)]
- Bug fix: Show ip-addresses with correct endianess.
- Show version properly
- VLAN ID was at a different place than expected.
- Add some documentation infos
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15313
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 10:50:55 +0000 (10:50 +0000)]
more gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15312
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 10:41:22 +0000 (10:41 +0000)]
more gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15311
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 10:29:09 +0000 (10:29 +0000)]
more gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15310
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 10:21:14 +0000 (10:21 +0000)]
some more gmemchunk -> se_alloc() improvements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15309
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 10:03:17 +0000 (10:03 +0000)]
remove some unused variables from scsi
change two gmemchunks in smtp to se_alloc() and remove one now redundant init routine.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15308
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 09:56:28 +0000 (09:56 +0000)]
add missing include to scsi
change two gmemchunks to se_alloc() for msproxy
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15307
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 12 Aug 2005 09:56:13 +0000 (09:56 +0000)]
EDS/EAPS/EPRS mostly finished - several fixmes remain
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15306
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 09:47:33 +0000 (09:47 +0000)]
add some symbols to libethereal.def
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15305
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 09:31:07 +0000 (09:31 +0000)]
oops forgot to delete a variable
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15304
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 09:30:24 +0000 (09:30 +0000)]
get rid of some unnessecary GMemChunks.
These GMemChunks are used here because :
1, GMemChunks are cheap to allocate and cheap to free
2, We always unconditionally free the entire chunk When and only when we load a new capture.
==>
se_alloc() does exactly the same thing but with significantly less code
==>
se_alloc() is a much better fit to out allocation requirements and useage than GMemChunks
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15303
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Fri, 12 Aug 2005 09:16:51 +0000 (09:16 +0000)]
Fix handling of ASAP_ENDPOINT_KEEP_ALIVE message.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15302
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 12 Aug 2005 08:51:08 +0000 (08:51 +0000)]
Add beginning of seasonal allocation in addition to the existing ephemeral ones.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15301
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 12 Aug 2005 07:47:27 +0000 (07:47 +0000)]
In an "address" structure, "data" is a pointer; dereferencing "&data"
doesn't give you the address value, it gives a pointer to the address
value.
Don't assume that pointer is aligned on a 32-bit boundary.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15300
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 12 Aug 2005 04:06:04 +0000 (04:06 +0000)]
Beginnings of a EDP, ESRP and EAPS dissector
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15299
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Thu, 11 Aug 2005 23:51:35 +0000 (23:51 +0000)]
avoid throwing a malformed packet
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15298
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 11 Aug 2005 23:18:46 +0000 (23:18 +0000)]
Add Extreme OUI, reorder alphabetically
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15297
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 11 Aug 2005 20:47:09 +0000 (20:47 +0000)]
From Rene Pilz:
The MCC/MNC in de_gmm_rai is not correct decoded
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15296
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 11 Aug 2005 20:14:41 +0000 (20:14 +0000)]
From W. Borgert:
three trivial corrections for the GIOP dissector:
- allow filtering GIOP exceptions, e.g. "giop.replystatus = 2"
or "giop.exceptionid matches MyError", older patch at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314835
- show IDLs sequence<octet> more compact, not one line per
octet, older patch at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314836
- decode _is_a requests and replies, older patch at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314871
With a change to not create a malformed packet in the "stub data".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15295
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Thu, 11 Aug 2005 18:21:23 +0000 (18:21 +0000)]
Change a switch into an "if else if else if else" that fixes the "too large for switch" in HP-UX 10.20 .
The generated file has a lot of indentation changes due probably to a change in asn2eth.
The underlying reason for which I added this code (dissect_ber_integer() would not add as a "filterable" field if it is larger than 4 bytes, should be handled in dissect_ber_integer() ) remains there.
Should we change dissect_ber_integer() itself to make sure that a 5 byte unsigned integer which fits in 4 bytes gets added to the tree as "filterable"?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15294
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 11 Aug 2005 16:24:12 +0000 (16:24 +0000)]
Add notes about SCSI, BER, and ONC RPC bugs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15293
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 11 Aug 2005 15:35:17 +0000 (15:35 +0000)]
Add checks for infinite loops. Fixes recent Buildbot failures.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15292
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 11 Aug 2005 10:08:45 +0000 (10:08 +0000)]
Fix for bug 342
If we encounter a frame we have already seen (i.e. visited==1) but we can not fing the ISCSI command inside the _matched table, this just means there were no response pdu nor any data pdu with the S bit set.
So, then just pick the cdata structure up from the _unmatched table instead.
The SCSI CDB dissector really really want a real CDATA structure passed to it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15291
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 11 Aug 2005 09:20:23 +0000 (09:20 +0000)]
We use heuristics to detect what MIGHT be onc-rpc packets.
as heuristics they are not 100% perfect, else they would not be heuristics.
IF the preference option "Dissect unknown RPC program numbers" are enabled,
add a sanity check to see that program_version is <=10
(no one uses versions >10 ?)
to avoid trying to add 2 bilion different versions to the program->version linked list
in case we mistook the packet for ONC-RPC and the "version" field contains a huge random number.
This bug would only trigger a hang/crash IFF the option above is enabled.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15290
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 11 Aug 2005 08:15:52 +0000 (08:15 +0000)]
fix several bugs where we might dereference a null pointer
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15289
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 11 Aug 2005 07:44:38 +0000 (07:44 +0000)]
some more tcv_get_stringz() to tvb_get_ephemeral_stringz() conversions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15288
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 10 Aug 2005 20:17:53 +0000 (20:17 +0000)]
Add bug IDs to the list of bugs fixed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15287
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 10 Aug 2005 19:49:45 +0000 (19:49 +0000)]
removed tons of MSVC const related warnings.
This might at some places interfere with the changes for gcc4, we might have to negotiate in that case :-)
Please note that a lot of these warnings were GTK1.x related only!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15286
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 10 Aug 2005 19:38:04 +0000 (19:38 +0000)]
Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15285
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 10 Aug 2005 19:37:29 +0000 (19:37 +0000)]
more snprintf() -> g_snprintf() replacements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15284
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 10 Aug 2005 19:34:09 +0000 (19:34 +0000)]
don't warn the user about the WinPcap 3.1 release version as being unknown
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15283
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 10 Aug 2005 19:31:21 +0000 (19:31 +0000)]
Remove proprietary information at the author's request.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15282
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 10 Aug 2005 19:28:08 +0000 (19:28 +0000)]
ep_tvb_get_string -> tvb_get_ephemeral_string
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15281
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 10 Aug 2005 18:54:30 +0000 (18:54 +0000)]
Add an item for the SLIMP3 overflow.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15280
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 10 Aug 2005 18:50:36 +0000 (18:50 +0000)]
Don't overflow a buffer. This might fix bug 327.
Don't print non-pritable characters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15279
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 10 Aug 2005 16:05:50 +0000 (16:05 +0000)]
When we receive junk data, mark it as a malformed packet instead of
a dissector bug. This keeps buildbot from opening unnecessary bugs
during fuzz testing.
When we create a new scsi_task_data_t struct make sure all of its
members are initialized.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15278
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 10 Aug 2005 15:58:26 +0000 (15:58 +0000)]
ep_tvb_get_string() -> tvb_get_ephemeral_string().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15277
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 10 Aug 2005 14:37:52 +0000 (14:37 +0000)]
tvb_get_stringz() to tvb_get_ephemeral_stringz() conversion
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15276
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 10 Aug 2005 14:35:24 +0000 (14:35 +0000)]
tvb_get_stringz() to tvb_get_ephemeral_stringz() conversion.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15275
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 10 Aug 2005 14:28:18 +0000 (14:28 +0000)]
convert to tvb_get_ephemeral_stringz() and fix an obvious memleak
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15274
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 10 Aug 2005 14:25:59 +0000 (14:25 +0000)]
add new function tvb_get_ephemeral_stringz()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15273
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 10 Aug 2005 14:17:27 +0000 (14:17 +0000)]
convert some tvb_fake_unicode() to tvb_get_ephemeral_faked_unicode()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15272
f5534014-38df-0310-8fa8-
9805f1628bb7