obnox/wireshark/wip.git
14 years agoFrom Nicolas Dichtel:
jake [Thu, 2 Nov 2006 16:47:13 +0000 (16:47 +0000)]
From Nicolas Dichtel:
here is a patch that transforms "valid lifetime" and "prefered lifetime" in a prefix option (in RA)
in human readable format. Following the RFC2461 Section 4.6.2, if the value is 0xffffffff, this means lifetime
is infinity.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19779 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't try to report -ve roundtrip delays
martinm [Thu, 2 Nov 2006 11:51:09 +0000 (11:51 +0000)]
Don't try to report -ve roundtrip delays

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19778 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrederic Heem:
jmayer [Thu, 2 Nov 2006 09:45:12 +0000 (09:45 +0000)]
Frederic Heem:
 Fix some memleaks and overflows.

I haven't committed the changes that are not bug fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19777 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowe don't support 95/98/ME any longer, and indeed WS doesn't work on these versions.
ulfl [Thu, 2 Nov 2006 09:36:47 +0000 (09:36 +0000)]
we don't support 95/98/ME any longer, and indeed WS doesn't work on these versions.

Give a hint that the last known working version was Ethereal 0.99.0 and quit the installer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19776 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd idl2wrs.sh to svn:ignore
jmayer [Thu, 2 Nov 2006 09:30:12 +0000 (09:30 +0000)]
add idl2wrs.sh to svn:ignore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19775 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoZhu Yi:
jmayer [Thu, 2 Nov 2006 09:26:38 +0000 (09:26 +0000)]
Zhu Yi:

ieee80211e dissect patch
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1191

Me:
Fix signedness warnings regarding ssid and ccode.
(in the old code, not in the 11e code)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19774 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to fix bug 1043.
jmayer [Thu, 2 Nov 2006 08:52:25 +0000 (08:52 +0000)]
Try to fix bug 1043.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19773 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBug 1053: New SNMP filtering is broken
kukosa [Thu, 2 Nov 2006 08:48:58 +0000 (08:48 +0000)]
Bug 1053: New SNMP filtering is broken
Do not try to parse OID as hexbytes string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19772 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a warning: "airpcap_loader.c(2287) : warning C4700: local variable 'ad' used...
ulfl [Wed, 1 Nov 2006 23:22:13 +0000 (23:22 +0000)]
fix a warning: "airpcap_loader.c(2287) : warning C4700: local variable 'ad' used without having been initialized"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19771 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd h324_muxtbl_out
etxrab [Wed, 1 Nov 2006 23:01:14 +0000 (23:01 +0000)]
Add h324_muxtbl_out

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19770 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHandle RFC 3267 Bandwidth-efficient mode.
etxrab [Wed, 1 Nov 2006 22:58:41 +0000 (22:58 +0000)]
Handle RFC 3267 Bandwidth-efficient mode.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19769 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd same license info as in Check64BitFormat.cmake
jmayer [Wed, 1 Nov 2006 22:22:27 +0000 (22:22 +0000)]
Add same license info as in Check64BitFormat.cmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19768 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThrow an exception if we try to add more than a million items to the tree.
gerald [Wed, 1 Nov 2006 20:32:23 +0000 (20:32 +0000)]
Throw an exception if we try to add more than a million items to the tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19767 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoupdate the list of defined application classes and list all the official ones from...
sahlberg [Wed, 1 Nov 2006 09:54:48 +0000 (09:54 +0000)]
update the list of defined application classes and list all the official ones from usb.org

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19766 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoconsole.lua missing from the svn tarball preventing making a package. I hope this
etxrab [Tue, 31 Oct 2006 22:28:50 +0000 (22:28 +0000)]
console.lua missing from the svn tarball preventing making a package. I hope this
is the right way to fix it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19764 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen processing '-G fields', ignore the "proto_tree_add_text"
gram [Tue, 31 Oct 2006 22:00:41 +0000 (22:00 +0000)]
When processing '-G fields', ignore the "proto_tree_add_text"
pseudo-field by looking at the ID for hf_text_only. Apparently
some fields really don't have 'name' fields, but we still want
their info to be dumped out.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19763 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agovalue_string arrays need to be terminated with a {0, NULL}.
gram [Tue, 31 Oct 2006 21:43:48 +0000 (21:43 +0000)]
value_string arrays need to be terminated with a {0, NULL}.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19762 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoProvide field names for fields with true/false values so they
gram [Tue, 31 Oct 2006 21:29:34 +0000 (21:29 +0000)]
Provide field names for fields with true/false values so they
can be searched on.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19761 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoshow "Disconnect request" in the info column for disconnects
sahlberg [Tue, 31 Oct 2006 21:25:31 +0000 (21:25 +0000)]
show "Disconnect request" in the info column for disconnects

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19760 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe protocol must be registered before its fields, so that
gram [Tue, 31 Oct 2006 21:15:38 +0000 (21:15 +0000)]
The protocol must be registered before its fields, so that
proto_registrar_dump_fields() knows the relationship.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19759 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoprettify the info column and add a generated item for the type (read/write) to respon...
sahlberg [Tue, 31 Oct 2006 21:13:46 +0000 (21:13 +0000)]
prettify the info column and add a generated item for the type (read/write) to response packets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19758 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix another typowq
jmayer [Tue, 31 Oct 2006 14:49:11 +0000 (14:49 +0000)]
Fix another typowq

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19756 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRepeat after me: Test submission before sending.
jmayer [Tue, 31 Oct 2006 14:47:34 +0000 (14:47 +0000)]
Repeat after me: Test submission before sending.
Repeat after me: Test patches before committing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19755 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOrder ethertypes by number - no other changes
jmayer [Tue, 31 Oct 2006 14:36:32 +0000 (14:36 +0000)]
Order ethertypes by number - no other changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19754 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRobert Schwebel:
jmayer [Tue, 31 Oct 2006 11:35:55 +0000 (11:35 +0000)]
Robert Schwebel:
  Fix for http://bugs.wireshark.org/bugzilla/attachment.cgi?id=419&action=view
  cross compilation fails

With the following change: Use only AC_CANONICAL_TARGET

From the autoconf manual:
     The user is encouraged to use either `AC_CANONICAL_BUILD', or
     `AC_CANONICAL_HOST', or `AC_CANONICAL_TARGET', depending on the
     needs.  Using `AC_CANONICAL_TARGET' is enough to run the two other
     macros.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19753 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago new protocol NBD NetworkBlockDevice
sahlberg [Tue, 31 Oct 2006 11:16:01 +0000 (11:16 +0000)]
 new protocol NBD   NetworkBlockDevice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19752 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange the signature for the get_pdu_len() function pointer passed to tcp_dissect_pdu...
sahlberg [Tue, 31 Oct 2006 09:29:07 +0000 (09:29 +0000)]
change the signature for the get_pdu_len() function pointer passed to tcp_dissect_pdus() to also include a packet_info pointer.

there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19751 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoEscape non-ASCII characters in the client and server protocol version strings.
gerald [Tue, 31 Oct 2006 01:46:59 +0000 (01:46 +0000)]
Escape non-ASCII characters in the client and server protocol version strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19748 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Giorgio Tino: Add a "Don't show this message again" option to an
gerald [Tue, 31 Oct 2006 01:44:11 +0000 (01:44 +0000)]
From Giorgio Tino:  Add a "Don't show this message again" option to an
AirPcap warning dialog.  Fix a callback bug in simple_dialog.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19747 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake sure we round up to the nearest 4-byte boundary before trying to process
gerald [Tue, 31 Oct 2006 01:28:29 +0000 (01:28 +0000)]
Make sure we round up to the nearest 4-byte boundary before trying to process
the FCS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19746 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrederic heem:
jmayer [Mon, 30 Oct 2006 18:38:14 +0000 (18:38 +0000)]
frederic heem:

Please find the patch that adds copyrights.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19744 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gennady Feldman:
jake [Mon, 30 Oct 2006 18:25:44 +0000 (18:25 +0000)]
From Gennady Feldman:
Here is an updated patch. Should be pretty safe. Just added a couple of constants and changed some strings to be cleaner and easier to read.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19743 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agocarsten.prescher@eads.com:
jmayer [Mon, 30 Oct 2006 18:17:10 +0000 (18:17 +0000)]
carsten.prescher@eads.com:

Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1114
@SHELL@ not replaced in idl2wrs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19742 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 1164 from Stephen Fisher: In the coloring rules edit dialog, set
gerald [Mon, 30 Oct 2006 16:01:40 +0000 (16:01 +0000)]
Fix for bug 1164 from Stephen Fisher: In the coloring rules edit dialog, set
the foreground color correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19740 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoA little prettifying:
martinm [Mon, 30 Oct 2006 15:36:40 +0000 (15:36 +0000)]
A little prettifying:
- Most Router Advertisement fields are now properly filterable
- Option tree has improved label, length set, fixed fields filterable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19739 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agostart splitting the monolitic scsi dissector up into commandset dissectors
sahlberg [Mon, 30 Oct 2006 12:18:29 +0000 (12:18 +0000)]
start splitting the monolitic scsi dissector up into commandset dissectors

split the MMC commandset out of the main scsi dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19738 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for (already-closed) bug 1180
martinm [Mon, 30 Oct 2006 09:50:39 +0000 (09:50 +0000)]
Fix for (already-closed) bug 1180

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19737 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Giorgio Tino: Add support for version 2.0 of the AirPcap driver,
gerald [Mon, 30 Oct 2006 06:34:31 +0000 (06:34 +0000)]
From Giorgio Tino: Add support for version 2.0 of the AirPcap driver,
which has an updated API for WEP key handling.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19736 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #1159 from Jim Young (should go into 0.99.4):
ulfl [Mon, 30 Oct 2006 02:09:59 +0000 (02:09 +0000)]
fix #1159 from Jim Young (should go into 0.99.4):
I think I have a fix for this problem.   The procedure
packet_list_set_selected_row()would do a clist freeze but not a corresponding
clist thaw if the list was empty.  A one line fix to gtk/packet_list.c appears
to fix this problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19735 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom sake blok
sahlberg [Sun, 29 Oct 2006 21:01:57 +0000 (21:01 +0000)]
from sake blok

Hi,

The attached file is a patch to packet-bpdu.c so that Wireshark is
able to dissect the Cisco MST BPDU's that I encountered last week.

Cheers,

Sake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19734 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Stephen fischer
sahlberg [Sun, 29 Oct 2006 20:56:00 +0000 (20:56 +0000)]
from Stephen fischer

Attached is a patch to fix bug #1163: "Dissector bug. ISO8073 COTP
protocol."  The SES dissector was incorrectly believing it had PDUs
within the COTP PDUs.  I added an additional heuristic check to see if
the length of the SES PDU is 0, then return false since it can't be zero
length.

Thanks,
  Steve

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19733 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a typo in the recent change to the hhc.exe command line, so the chm files compile...
ulfl [Sun, 29 Oct 2006 19:47:59 +0000 (19:47 +0000)]
fix a typo in the recent change to the hhc.exe command line, so the chm files compile again - took me more than an hour to find out and reproduce :-(

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19732 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Roger Gottsponer:
jake [Sun, 29 Oct 2006 19:14:31 +0000 (19:14 +0000)]
From Roger Gottsponer:
During troubleshooting an ARP problem, I found an issue with wireshark
to properly recognise Gratuitous ARP packets. Gratuitous ARP packets
can be made with ARP request or ARP reply packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19731 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoput every python script name into "" so the call won't fail on Win32 native python.
ulfl [Sun, 29 Oct 2006 17:19:52 +0000 (17:19 +0000)]
put every python script name into "" so the call won't fail on Win32 native python.

The problem is the slash in e.g.:

 @$(PYTHON) ../../tools/make-dissector-reg.py

is interpreted as an option instead of being part of the path.

I didn't wanted to use backslashes as this might introduce new problems with cygwin's python port.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19730 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Sake Blok:
ulfl [Sun, 29 Oct 2006 17:14:13 +0000 (17:14 +0000)]
from Sake Blok:

While I was reading the development guide I noticed a few typo's.
The attached patch fixes them (the patch is against revision 19724).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19729 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange the default GTK version from GTK2.6 to GTK2.8
ulfl [Sun, 29 Oct 2006 14:41:16 +0000 (14:41 +0000)]
change the default GTK version from GTK2.6 to GTK2.8

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19728 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomake the checksum fields visible for TCP and UDP
ulfl [Sun, 29 Oct 2006 13:53:07 +0000 (13:53 +0000)]
make the checksum fields visible for TCP and UDP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19727 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #1188: scroll the packet list to the bottom (in a running capture) *after* thawin...
ulfl [Sun, 29 Oct 2006 12:51:15 +0000 (12:51 +0000)]
fix #1188: scroll the packet list to the bottom (in a running capture) *after* thawing the list - otherwise the scrolling won't be done correctly

this one should go into 0.99.4 IMHO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19726 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher:
jake [Sun, 29 Oct 2006 11:50:30 +0000 (11:50 +0000)]
From Stephen Fisher:
Attached is a patch to allow the disabling of the UDP/UDPlite checksum
verification for cards that offload it and report it incorrectly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19725 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a glossy highlight.
gerald [Sun, 29 Oct 2006 05:55:04 +0000 (05:55 +0000)]
Add a glossy highlight.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19724 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe TCP options data is a byte array, not a character string.
guy [Sun, 29 Oct 2006 00:06:02 +0000 (00:06 +0000)]
The TCP options data is a byte array, not a character string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19723 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBased on RFC3488. This is a setup for RGMP dissection, a simple protocol bolted on...
jake [Sat, 28 Oct 2006 21:52:38 +0000 (21:52 +0000)]
Based on RFC3488. This is a setup for RGMP dissection, a simple protocol bolted on IGMP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19722 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Pierre Juhen:
jake [Sat, 28 Oct 2006 21:32:38 +0000 (21:32 +0000)]
From Pierre Juhen:
I would like to have a tcp.options field with a name for PMDL output;
I include a patch to packet-tcp.c to provide that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19721 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet AirpcapLoaded to TRUE if we've successfully loaded our DLL and obtained
gerald [Fri, 27 Oct 2006 20:33:19 +0000 (20:33 +0000)]
Set AirpcapLoaded to TRUE if we've successfully loaded our DLL and obtained
our addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19720 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAllow each program called by the Docbook Makefile to be specified using
gerald [Fri, 27 Oct 2006 19:15:57 +0000 (19:15 +0000)]
Allow each program called by the Docbook Makefile to be specified using
the environment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19719 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCast away most remaining warnings.
martinm [Fri, 27 Oct 2006 14:36:48 +0000 (14:36 +0000)]
Cast away most remaining warnings.
2 will remain, because the 'needle' arg in tvb_pbrk_guint8() isn't const...  Should it be?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19717 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore warnings
martinm [Fri, 27 Oct 2006 13:03:38 +0000 (13:03 +0000)]
More warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19716 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix the GTK-WIMP paths for GTK2.8 - both source and destination paths completely...
ulfl [Fri, 27 Oct 2006 12:06:13 +0000 (12:06 +0000)]
fix the GTK-WIMP paths for GTK2.8 - both source and destination paths completely changed from 2.6 to 2.8 due to the integration of Wimp into the main GTK repository

remove settings for GTK2.2 and 2.4 in config.nmake - as no one uses it IMHO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19715 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen key length wrong, show expected value.
martinm [Fri, 27 Oct 2006 10:16:22 +0000 (10:16 +0000)]
When key length wrong, show expected value.
Fix Preference label where %d was missing from specifier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19714 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a lot of sanity checks, particularly to get_airpcap_interface_list(),
gerald [Thu, 26 Oct 2006 21:53:30 +0000 (21:53 +0000)]
Add a lot of sanity checks, particularly to get_airpcap_interface_list(),
which should fix bug 1176.  Fix up whitespace and indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19712 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix more Ubuntu warnings.
etxrab [Thu, 26 Oct 2006 21:31:48 +0000 (21:31 +0000)]
Fix more Ubuntu warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19711 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore warnings...
martinm [Thu, 26 Oct 2006 17:03:45 +0000 (17:03 +0000)]
More warnings...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19710 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to declare and cast away warnings
martinm [Thu, 26 Oct 2006 16:52:55 +0000 (16:52 +0000)]
Try to declare and cast away warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19709 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOnly include the license text and not the rest of the source file
jmayer [Thu, 26 Oct 2006 16:39:34 +0000 (16:39 +0000)]
Only include the license text and not the rest of the source file
it was copied from as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19708 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrederic.heem:
jmayer [Thu, 26 Oct 2006 15:36:50 +0000 (15:36 +0000)]
frederic.heem:
  Update/Add FindPCAP.cmake CMakeInstallDirs.cmake CMakeLists.txt

me:
  Fix a typo, change gcc flags to mimic the behaviour of autofoo
  stuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19707 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't include /usr/local if usage of /usr/local has been disabled via
jmayer [Thu, 26 Oct 2006 14:50:03 +0000 (14:50 +0000)]
Don't include /usr/local if usage of /usr/local has been disabled via
configure option.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19706 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Xiaoguang Liu
jake [Thu, 26 Oct 2006 14:36:09 +0000 (14:36 +0000)]
From Xiaoguang Liu
In wireshark a NTP field is displayed as "clock dispersion".
But should it be called "root dispersion" as per RFC 1305?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19705 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCast away remaining warnings seen on buildbot
martinm [Thu, 26 Oct 2006 12:45:14 +0000 (12:45 +0000)]
Cast away remaining warnings seen on buildbot

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19704 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMention the 64-bit-integer accessors.
guy [Thu, 26 Oct 2006 10:27:16 +0000 (10:27 +0000)]
Mention the 64-bit-integer accessors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19703 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHopefully zap some warnings
martinm [Thu, 26 Oct 2006 10:11:09 +0000 (10:11 +0000)]
Hopefully zap some warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19702 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobreak request/response matching to track transactions out from the CONTROL handler...
sahlberg [Thu, 26 Oct 2006 08:37:39 +0000 (08:37 +0000)]
break request/response matching to track transactions out from the CONTROL handler to use the same code for ALL pdu types

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19701 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoslightly improve info column output
ulfl [Thu, 26 Oct 2006 08:08:13 +0000 (08:08 +0000)]
slightly improve info column output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19700 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoput python script name in brackets
ulfl [Thu, 26 Oct 2006 08:07:13 +0000 (08:07 +0000)]
put python script name in brackets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19699 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom stephen f fix for 1040
sahlberg [Thu, 26 Oct 2006 07:45:01 +0000 (07:45 +0000)]
from stephen f    fix for 1040

Attached is a patch to fix bug #1040: "imap packet: not all infos are
displayed."  It has been tested against the capture file the user
provided as well as my own capture of an imap session.

Thanks,
  Steve

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19698 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoupdate of shaun j's detains
sahlberg [Thu, 26 Oct 2006 07:34:22 +0000 (07:34 +0000)]
update of shaun j's detains

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19697 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMissed a change.
etxrab [Thu, 26 Oct 2006 07:34:10 +0000 (07:34 +0000)]
Missed a change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19696 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPreparations for using the latest GTK 2.8 files for now only gettext is updated.
etxrab [Thu, 26 Oct 2006 07:25:07 +0000 (07:25 +0000)]
Preparations for using the latest GTK 2.8 files for now only gettext is updated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19695 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't use custom build buttons for standard tasks like: Ok, Apply, Cancel.
ulfl [Thu, 26 Oct 2006 00:39:05 +0000 (00:39 +0000)]
don't use custom build buttons for standard tasks like: Ok, Apply, Cancel.

It might be a good idea to add tooltips to the various GUI elements - this makes understanding the GUI *much* faster.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19694 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothe labels of the airpcap toolbar, e.g. "Not a valid Wireless Interface" are pretty...
ulfl [Wed, 25 Oct 2006 23:54:56 +0000 (23:54 +0000)]
the labels of the airpcap toolbar, e.g. "Not a valid Wireless Interface" are pretty misleading. I've changed it to "AirPcap interface: Not selected" which might be more helpful

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19693 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove some unused asn1 code(not in spec) to get rid of some Ubuntu warnings.
etxrab [Wed, 25 Oct 2006 22:09:48 +0000 (22:09 +0000)]
Remove some unused asn1 code(not in spec) to get rid of some Ubuntu warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19688 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUnreffing rci->cursor_pixbuf should cause the pixbuf to be released, so
guy [Wed, 25 Oct 2006 19:48:54 +0000 (19:48 +0000)]
Unreffing rci->cursor_pixbuf should cause the pixbuf to be released, so
null out the pointer to it.  This prevents a freed pixbuf from being
used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19687 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix Id marking
etxrab [Wed, 25 Oct 2006 19:26:58 +0000 (19:26 +0000)]
Fix Id marking

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19686 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInclude the top-level header for CoreFoundation, to see whether it'll
guy [Wed, 25 Oct 2006 18:25:17 +0000 (18:25 +0000)]
Include the top-level header for CoreFoundation, to see whether it'll
fix a build failure I've seen on L**p*rd.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19685 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd more paranoid pointer checks. Fixes CID 219.
gerald [Wed, 25 Oct 2006 17:00:33 +0000 (17:00 +0000)]
Add more paranoid pointer checks.  Fixes CID 219.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19684 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAllow DCT2000 support to find a couple of more protocols.
martinm [Wed, 25 Oct 2006 16:46:27 +0000 (16:46 +0000)]
Allow DCT2000 support to find a couple of more protocols.
Try to squash some warnings seen on the ubuntu buildbot log

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19683 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch Coverity CID 220. Fix up whitespace.
gerald [Wed, 25 Oct 2006 16:39:19 +0000 (16:39 +0000)]
Squelch Coverity CID 220.  Fix up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19682 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher
jake [Wed, 25 Oct 2006 15:22:39 +0000 (15:22 +0000)]
From Stephen Fisher
Attached is a patch to fix bug #1170: "Wireshark interpretation of WBXML
does not comply with Spec."  This has been verified with the sample
capture the user provided.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19681 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix bug 1085 -- handle the various ways that a radiotap frame can
gram [Wed, 25 Oct 2006 15:16:49 +0000 (15:16 +0000)]
Fix bug 1085 --  handle the various ways that a radiotap frame can
have an FCS. Also, clean up the parsing and presentation of the various
flags, and show some that aren't already shown.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19680 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoClean up some compiler warnings.
guy [Wed, 25 Oct 2006 03:03:53 +0000 (03:03 +0000)]
Clean up some compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19679 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAttempt to squelch Coverity CID 221.
gerald [Wed, 25 Oct 2006 00:49:36 +0000 (00:49 +0000)]
Attempt to squelch Coverity CID 221.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19678 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAttempt to get compilation working under Windows.
gerald [Wed, 25 Oct 2006 00:17:28 +0000 (00:17 +0000)]
Attempt to get compilation working under Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19677 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Reinhard Speyerer:
etxrab [Tue, 24 Oct 2006 22:06:34 +0000 (22:06 +0000)]
From Reinhard Speyerer:
Fixes the incorrect decoding of the CC-SETUP CLIR suppression and invoke info elements (which seem to have been copied from the location update accept PDU).

and added some info from a later spec.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19675 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPut a trailing ellipsis behind the wireless toolbar buttons since they open
gerald [Tue, 24 Oct 2006 21:07:05 +0000 (21:07 +0000)]
Put a trailing ellipsis behind the wireless toolbar buttons since they open
a new window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19673 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoParts of http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1179
jmayer [Tue, 24 Oct 2006 17:39:32 +0000 (17:39 +0000)]
Parts of bugs.wireshark.org/bugzilla/show_bug.cgi?id=1179

Frederic Heem:
* More cmake system checks. It compiles dumpcap without running configure,

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19672 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoImprove the documentation generators
lego [Tue, 24 Oct 2006 17:34:17 +0000 (17:34 +0000)]
Improve the documentation generators
add some docs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19671 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHave Lua disabled by default.
lego [Tue, 24 Oct 2006 13:16:57 +0000 (13:16 +0000)]
Have Lua disabled by default.

Add more documentation to the code.
change make-dco.pl so that it creates more readable docbook output.

This should be copied over to 0.99.4

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19670 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoby popular request
sahlberg [Tue, 24 Oct 2006 07:27:32 +0000 (07:27 +0000)]
by popular request
reintroducing the ACK_RTT   measurement how long it took to ACK a data segment

Gerald   this is a trivially correct patch   can you apply it to the release branch?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19669 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alejandro Vaquero:
etxrab [Tue, 24 Oct 2006 05:21:00 +0000 (05:21 +0000)]
From Alejandro Vaquero:
For the Radius dissector to add statistics
 in the "Service Response Time" menu and the tshark stats.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19668 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alejandro Vaquero:
jake [Tue, 24 Oct 2006 05:17:49 +0000 (05:17 +0000)]
From Alejandro Vaquero:
Find attached a patch for this bug. The problem was actually in the "Voip Calls" logic, when the first RTP packet was after the last signaling packet (e.g. a call connected and the release not captured), that caused the RTP to not be added to the graph list and therefor to the player.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19667 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 1178. Allow FT_?INT24 BASE_DEC VALs in the expression selection dialog.
jake [Mon, 23 Oct 2006 22:43:11 +0000 (22:43 +0000)]
Fix for bug 1178. Allow FT_?INT24 BASE_DEC VALs in the expression selection dialog.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19666 f5534014-38df-0310-8fa8-9805f1628bb7