obnox/wireshark/wip.git
11 years agosnprintf -> g_snprintf
stig [Sun, 3 Feb 2008 16:03:33 +0000 (16:03 +0000)]
snprintf -> g_snprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24260 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUps, fix a typo from last checkin.
stig [Sun, 3 Feb 2008 15:49:22 +0000 (15:49 +0000)]
Ups, fix a typo from last checkin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24259 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMore rewrite of prohibited APIs (sprintf, strcpy, strcat).
stig [Sun, 3 Feb 2008 15:38:20 +0000 (15:38 +0000)]
More rewrite of prohibited APIs (sprintf, strcpy, strcat).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24258 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoved C++ style comments.
stig [Sun, 3 Feb 2008 14:44:21 +0000 (14:44 +0000)]
Removed C++ style comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24257 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate asn1 files to 3GPP TS 25.433 V7.7.0 (2007-12)
etxrab [Sun, 3 Feb 2008 13:47:50 +0000 (13:47 +0000)]
Update asn1 files to 3GPP TS 25.433 V7.7.0 (2007-12)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24256 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGive it an RCS ID.
guy [Sun, 3 Feb 2008 13:13:17 +0000 (13:13 +0000)]
Give it an RCS ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24255 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoOne more missing file from Balint Reczey's patch for bug 2233.
guy [Sun, 3 Feb 2008 13:12:43 +0000 (13:12 +0000)]
One more missing file from Balint Reczey's patch for bug 2233.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24254 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd the missing files from Balint Reczey's patch for bug 2233.
guy [Sun, 3 Feb 2008 12:36:37 +0000 (12:36 +0000)]
Add the missing files from Balint Reczey's patch for bug 2233.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24253 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Balint Reczey (bug 2233):
sake [Sun, 3 Feb 2008 10:31:55 +0000 (10:31 +0000)]
From Balint Reczey (bug 2233):

The attached patch makes the Statistics -> RTP -> Show All Streams feature of
wireshark accessible via tshark.

I found it helpful in dealing with tons of RTP captures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24252 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of some warnings.
etxrab [Sun, 3 Feb 2008 10:07:42 +0000 (10:07 +0000)]
Get rid of some warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24251 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate asn1 files to GPP TS 25.413 V7.8.0 (2008-01).
etxrab [Sun, 3 Feb 2008 09:51:57 +0000 (09:51 +0000)]
Update asn1 files to GPP TS 25.413 V7.8.0 (2008-01).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24250 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
stig [Sat, 2 Feb 2008 17:25:40 +0000 (17:25 +0000)]
Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24249 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed a possible buffer overflow in dissect_fmp_flushCmd() when cmd has
stig [Sat, 2 Feb 2008 17:17:16 +0000 (17:17 +0000)]
Fixed a possible buffer overflow in dissect_fmp_flushCmd() when cmd has
all bits set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24248 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRewrote strcat -> strncat, and fixed to show more than the last remaining
stig [Sat, 2 Feb 2008 17:13:30 +0000 (17:13 +0000)]
Rewrote strcat -> strncat, and fixed to show more than the last remaining
Cmd_Argv value for Remote Command.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24247 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Peter Kjellerstedt:
jake [Sat, 2 Feb 2008 16:41:12 +0000 (16:41 +0000)]
From Peter Kjellerstedt:
I was capturing an RTP stream the other day which contained JPEG images
streamed according to RFC 2435. However, Wireshark reported them as malformed.
After some debugging of the Wireshark code it turned out that the decoding of
JPEG images which contain a quantization table was incorrect. I have attached a
patch to correct the decoding.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24246 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Alan McBride:
jake [Sat, 2 Feb 2008 16:30:46 +0000 (16:30 +0000)]
From Alan McBride:
The decoding of a SubscribeCOVProperty packet is not properly decoding the
Monitored Property Identifier field. It leaves a number of decoded bytes at the
end as data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24245 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2202, when an ethernet frame with padding is encountered, the
sake [Sat, 2 Feb 2008 09:21:09 +0000 (09:21 +0000)]
Fix for bug 2202, when an ethernet frame with padding is encountered, the
reported length is 46, so there was a one-off error in the code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24244 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDisallow ending space was not such a good idea, chop it of before save instead.
stig [Fri, 1 Feb 2008 18:42:59 +0000 (18:42 +0000)]
Disallow ending space was not such a good idea, chop it of before save instead.
Also disallow '/' in profilename for !win32.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24243 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed a problem with renaming a profile after hitting apply.
stig [Fri, 1 Feb 2008 16:49:34 +0000 (16:49 +0000)]
Fixed a problem with renaming a profile after hitting apply.
Profile name cannot start or end with space, and on win32 it cannot contain
any of this characters: \ / : * ? " < > |
Added a tooltip to the profile name text box.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24242 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded tooltip description for yellow filter background.
stig [Fri, 1 Feb 2008 10:02:19 +0000 (10:02 +0000)]
Added tooltip description for yellow filter background.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24241 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdated various misleading examples.
jake [Fri, 1 Feb 2008 06:47:12 +0000 (06:47 +0000)]
Updated various misleading examples.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24240 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).
stig [Fri, 1 Feb 2008 01:07:58 +0000 (01:07 +0000)]
Rewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24239 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoHmmm. Second try to fix the const problems.
stig [Thu, 31 Jan 2008 23:10:09 +0000 (23:10 +0000)]
Hmmm.  Second try to fix the const problems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24238 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoved a const to make it compile.
stig [Thu, 31 Jan 2008 22:31:01 +0000 (22:31 +0000)]
Removed a const to make it compile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24237 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSplit out the Gmb application AVP:s to at least make it simpler to handle the
etxrab [Thu, 31 Jan 2008 21:53:26 +0000 (21:53 +0000)]
Split out the Gmb application AVP:s to at least make it simpler to handle the
AVP "collision".
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1494

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24236 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSplit out the Gmb application AVP:s to at least make it simpler to handle the
etxrab [Thu, 31 Jan 2008 21:52:47 +0000 (21:52 +0000)]
Split out the Gmb application AVP:s to at least make it simpler to handle the
AVP "collision".
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1494

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24235 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake the "!="/"ne" change compile under Windows.
gerald [Thu, 31 Jan 2008 20:18:07 +0000 (20:18 +0000)]
Make the "!="/"ne" change compile under Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24234 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded missing space in front of new statusbar messages.
stig [Thu, 31 Jan 2008 20:00:45 +0000 (20:00 +0000)]
Added missing space in front of new statusbar messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24233 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoIf "!=" or "ne" are used in a display filter, warn the user that the results
gerald [Thu, 31 Jan 2008 19:50:38 +0000 (19:50 +0000)]
If "!=" or "ne" are used in a display filter, warn the user that the results
may be unexpected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24232 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoHide hidden devices in "Capture Interfaces" dialog.
stig [Thu, 31 Jan 2008 16:47:05 +0000 (16:47 +0000)]
Hide hidden devices in "Capture Interfaces" dialog.

Added a function to check for hidden devices, which also work correctly
for plumbed devices on solaris.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24231 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd missing g_object_unref for treeview models;
wmeier [Thu, 31 Jan 2008 16:37:56 +0000 (16:37 +0000)]
Add missing g_object_unref for treeview models;
Remove not needed set_tree_model (stats_tree_stat.c)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24230 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd Luis' uat_get_table_by_name() to fetch SMI uat tables.
stig [Wed, 30 Jan 2008 22:50:55 +0000 (22:50 +0000)]
Add Luis' uat_get_table_by_name() to fetch SMI uat tables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24229 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDissect the FLUTE "data".
etxrab [Wed, 30 Jan 2008 22:34:17 +0000 (22:34 +0000)]
Dissect the FLUTE "data".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24228 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMove glib-2 specific code out of gsmmap.cnf (where we can't #ifdef around
morriss [Wed, 30 Jan 2008 17:11:06 +0000 (17:11 +0000)]
Move glib-2 specific code out of gsmmap.cnf (where we can't #ifdef around
it--asn2wrs doesn't understand #ifdef's) to packet-gsm-template.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24227 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded missing space in front of some statusbar messages.
stig [Wed, 30 Jan 2008 15:16:21 +0000 (15:16 +0000)]
Added missing space in front of some statusbar messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24226 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate my email address.
bondolo [Tue, 29 Jan 2008 23:30:27 +0000 (23:30 +0000)]
Update my email address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24225 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agocleanup initial comment. fix urls and email addresses.
bondolo [Tue, 29 Jan 2008 23:28:10 +0000 (23:28 +0000)]
cleanup initial comment. fix urls and email addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24224 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd missing 'static int' for dissect_diameter_3gpp_tmgi(...)
wmeier [Tue, 29 Jan 2008 20:33:43 +0000 (20:33 +0000)]
Add missing 'static int' for dissect_diameter_3gpp_tmgi(...)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24223 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDissect 3GPP AVP Code: 900 TMGI
etxrab [Tue, 29 Jan 2008 20:05:02 +0000 (20:05 +0000)]
Dissect 3GPP AVP Code: 900 TMGI

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24222 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFor Windows: Update to use Gtk+ 2.12.6; Use latest Glib 2.14.5 again;
wmeier [Tue, 29 Jan 2008 18:55:28 +0000 (18:55 +0000)]
For Windows: Update to use Gtk+ 2.12.6; Use latest Glib 2.14.5 again;
Gtk 2.12.6 fixes bugzilla.gnome.org bug #503326 which thus means that
Wireshark no longer needs a work-around for Wireshark bug #2066.
(See svn #24219).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24221 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWhen having more than one matching item in a frame the MAX and MIN calculation
stig [Tue, 29 Jan 2008 14:27:02 +0000 (14:27 +0000)]
When having more than one matching item in a frame the MAX and MIN calculation
could return an invalid value.  Also fixed AVG calculation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24220 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRevert GTK+/GLIB to GTK+ 2.12.1 with GLib 2.14.3 for Windows installs
sake [Tue, 29 Jan 2008 10:48:53 +0000 (10:48 +0000)]
Revert GTK+/GLIB to GTK+ 2.12.1 with GLib 2.14.3 for Windows installs
as a workaround for bug 2066. We should stick to these versions until
bug report #503326 on bugzilla.gnome.org has been fixed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24219 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSSI dBm signal is signed.
stig [Tue, 29 Jan 2008 09:56:11 +0000 (09:56 +0000)]
SSI dBm signal is signed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24218 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUse the new gettext-runtime.
stig [Mon, 28 Jan 2008 20:23:08 +0000 (20:23 +0000)]
Use the new gettext-runtime.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24217 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDissect Vendor id and Auth-application Id.
etxrab [Mon, 28 Jan 2008 19:55:20 +0000 (19:55 +0000)]
Dissect Vendor id and Auth-application Id.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24216 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agocleanup code (remove some collapsed conditions)
kukosa [Mon, 28 Jan 2008 17:34:38 +0000 (17:34 +0000)]
cleanup code (remove some collapsed conditions)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24215 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdding Thomas Morin
jake [Mon, 28 Jan 2008 17:27:22 +0000 (17:27 +0000)]
Adding Thomas Morin

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24214 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake use of an unused value.
stig [Sun, 27 Jan 2008 23:33:09 +0000 (23:33 +0000)]
Make use of an unused value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24213 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd the forgotten file.
etxrab [Sun, 27 Jan 2008 23:18:57 +0000 (23:18 +0000)]
Add the forgotten file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24212 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake it possible to do subdissection of Diameter AVP:s and add dissection
etxrab [Sun, 27 Jan 2008 21:06:33 +0000 (21:06 +0000)]
Make it possible to do subdissection of Diameter AVP:s and add dissection
of some 3GPP AVP:s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24211 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWhen having more than one matching item in a frame the AVG calculation
stig [Sun, 27 Jan 2008 18:19:40 +0000 (18:19 +0000)]
When having more than one matching item in a frame the AVG calculation
did not return a correct value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24210 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoExpand the Protocol column instead of the last column on window resize.
stig [Sun, 27 Jan 2008 15:54:15 +0000 (15:54 +0000)]
Expand the Protocol column instead of the last column on window resize.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24209 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDo not change profile if directory creation failed, and change to default
stig [Sun, 27 Jan 2008 14:45:31 +0000 (14:45 +0000)]
Do not change profile if directory creation failed, and change to default
profile if existing profile was deleted.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24208 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUncomplete code change.
etxrab [Sun, 27 Jan 2008 14:27:11 +0000 (14:27 +0000)]
Uncomplete code change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24207 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoNew gettext-runtime
etxrab [Sun, 27 Jan 2008 14:26:11 +0000 (14:26 +0000)]
New gettext-runtime

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24206 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix reassembly.
etxrab [Sun, 27 Jan 2008 11:03:56 +0000 (11:03 +0000)]
Fix reassembly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24205 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAlso destroy the window when failure to export/import color filters.
stig [Sat, 26 Jan 2008 17:04:49 +0000 (17:04 +0000)]
Also destroy the window when failure to export/import color filters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24204 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDestroy the open window after open failure to avoid having an unusable
stig [Sat, 26 Jan 2008 16:50:08 +0000 (16:50 +0000)]
Destroy the open window after open failure to avoid having an unusable
open dialog when using GTK >= 2.4.

This fixes bug 1986.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24203 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDestroy the save window after canceling a save to an existing file, so
stig [Sat, 26 Jan 2008 16:45:29 +0000 (16:45 +0000)]
Destroy the save window after canceling a save to an existing file, so
the user is able to save again without having a hidden save window which
will not open.

Older GTK versions will show the hidden window after failure.

This fixes bug 1896.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24202 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoadd *.user to the ignore list
ulfl [Sat, 26 Jan 2008 16:34:14 +0000 (16:34 +0000)]
add *.user to the ignore list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24201 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoadd *.user to the ignore list
ulfl [Sat, 26 Jan 2008 16:28:21 +0000 (16:28 +0000)]
add *.user to the ignore list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24200 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Peter (bug 2224):
stig [Sat, 26 Jan 2008 15:28:37 +0000 (15:28 +0000)]
From Peter (bug 2224):
Patch to fix compile with glib-1.2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24199 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agog_warning -> pcapng_debug and "switch it off" as default, so normal users won't be...
ulfl [Sat, 26 Jan 2008 14:08:51 +0000 (14:08 +0000)]
g_warning -> pcapng_debug and "switch it off" as default, so normal users won't be annoyed by debug messages

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24198 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUse the standard X.402 module as a separate file rather than as cut/paste into the...
gal [Sat, 26 Jan 2008 10:18:10 +0000 (10:18 +0000)]
Use the standard X.402 module as a separate file rather than as cut/paste into the ACP133 module.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24197 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemove "LDAP over SSL" registration as now handled by the LDAP dissector.
gal [Sat, 26 Jan 2008 10:14:26 +0000 (10:14 +0000)]
Remove "LDAP over SSL" registration as now handled by the LDAP dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24196 f5534014-38df-0310-8fa8-9805f1628bb7

11 years ago1) Support for configurable LDAP over SSL port
gal [Sat, 26 Jan 2008 10:12:22 +0000 (10:12 +0000)]
1) Support for configurable LDAP over SSL port
2) Support for RFC 3909 - cancelRequest extendedOperation
3) Support for RFC 3062 - passwordModify extendedOperation
4) Column information for ExtendedRequest, SearchResultRef and AbandonRequest
5) Column information for multiple LDAP operations in the same packet (uses " | " separator)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24195 f5534014-38df-0310-8fa8-9805f1628bb7

11 years ago1) Correct attribute name.
gal [Sat, 26 Jan 2008 10:05:13 +0000 (10:05 +0000)]
1) Correct attribute name.
2) Add subtreespecification attribute.
3) Label each attribute in the tree with the attribute type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24194 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Bill Florac:
jake [Fri, 25 Jan 2008 21:31:50 +0000 (21:31 +0000)]
From Bill Florac:
Corrected ATTRRPLY dissection.
Removed a few unnecessary semi-colons.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24193 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDecode som more MBMS elements. Diameter XML fixes.
etxrab [Fri, 25 Jan 2008 17:27:54 +0000 (17:27 +0000)]
Decode som more MBMS elements. Diameter XML fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24192 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd tvb_free (as per the request in http://bugs.wireshark.org/bugzilla/show_bug.cgi...
morriss [Fri, 25 Jan 2008 15:34:55 +0000 (15:34 +0000)]
Add tvb_free (as per the request in bugs.wireshark.org/bugzilla/show_bug.cgi?id=2219)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24191 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Thomas Morin:
jake [Fri, 25 Jan 2008 06:32:53 +0000 (06:32 +0000)]
From Thomas Morin:
I have written the attached patch to improve the userfriendly-ness of the
summary displayed in the last column of the packet list for IGMP packets.

The current code only tells the user the type of packet (REPORT, LEAVE, QUERY),
but doesn't include any information about what multicast group is joined to or
left.   Worse, for IGMPv3 Reports the user cannot tell quickly if the multicast
group is joined-to or left, without having to look at the inside of the packet
to know the type of report (include all, include none, exlude none, exclude
all, etc.).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24190 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Bill Florac::
jake [Fri, 25 Jan 2008 06:23:28 +0000 (06:23 +0000)]
From Bill Florac::
Corrected display of attributes from previous patch (24165)
For V2, if field length was 0, do not display the empty field. This makes it
easier to read. I only did V2 as I do not have means to test V1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24189 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed some strcpy -> strncpy/g_snprintf cleanups.
stig [Thu, 24 Jan 2008 23:01:37 +0000 (23:01 +0000)]
Fixed some strcpy -> strncpy/g_snprintf cleanups.
Removed a debug printout in t38.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24188 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded some parantheses to avoid a warning.
stig [Thu, 24 Jan 2008 22:51:17 +0000 (22:51 +0000)]
Added some parantheses to avoid a warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24187 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoved even more C++ style comments.
stig [Thu, 24 Jan 2008 22:33:49 +0000 (22:33 +0000)]
Removed even more C++ style comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24186 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix various small memory leaks & 1 invalid g_free (airpcap_gui_utils.c)
wmeier [Thu, 24 Jan 2008 22:26:05 +0000 (22:26 +0000)]
Fix various small memory leaks & 1 invalid g_free (airpcap_gui_utils.c)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24185 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDecode som MBMS elements.
etxrab [Thu, 24 Jan 2008 22:21:13 +0000 (22:21 +0000)]
Decode som MBMS elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24184 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoChange "Found no match" to "No match found"
wmeier [Thu, 24 Jan 2008 22:12:10 +0000 (22:12 +0000)]
Change "Found no match" to "No match found"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24183 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWarn if we find %ll in the source
morriss [Thu, 24 Jan 2008 22:02:55 +0000 (22:02 +0000)]
Warn if we find %ll in the source

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24182 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agos/%ll/%" G_GINT64_MODIFIER "/g
morriss [Thu, 24 Jan 2008 21:57:13 +0000 (21:57 +0000)]
s/%ll/%" G_GINT64_MODIFIER "/g

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24181 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed some more malloc -> g_malloc, free -> g_free, strdup -> g_strdup.
stig [Thu, 24 Jan 2008 19:30:43 +0000 (19:30 +0000)]
Fixed some more malloc -> g_malloc, free -> g_free, strdup -> g_strdup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24180 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed some malloc -> g_malloc, free -> g_free, strdup -> g_strdup.
stig [Thu, 24 Jan 2008 19:09:30 +0000 (19:09 +0000)]
Fixed some malloc -> g_malloc, free -> g_free, strdup -> g_strdup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24179 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoved C++ style comment.
stig [Thu, 24 Jan 2008 18:51:54 +0000 (18:51 +0000)]
Removed C++ style comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24178 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd check for non-ASCII characters (defined, for now, as any whose value is > 0x80...
morriss [Thu, 24 Jan 2008 18:18:28 +0000 (18:18 +0000)]
Add check for non-ASCII characters (defined, for now, as any whose value is > 0x80) anywhere in the source files (as per discussion on -dev).  Amazingly, this does not appear to slow the tool down too much.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24177 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReplace a handful of tabs with spaces.
martinm [Thu, 24 Jan 2008 17:14:01 +0000 (17:14 +0000)]
Replace a handful of tabs with spaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24176 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAlways return a valid profile name from get_profile_name().
stig [Thu, 24 Jan 2008 17:06:22 +0000 (17:06 +0000)]
Always return a valid profile name from get_profile_name().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24175 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoOne of fixes in SVN #24173 incomplete; Undo it for now
wmeier [Thu, 24 Jan 2008 05:39:48 +0000 (05:39 +0000)]
One of fixes in SVN #24173 incomplete; Undo it for now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24174 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix two very minor memory leaks
wmeier [Thu, 24 Jan 2008 04:20:07 +0000 (04:20 +0000)]
Fix two very minor memory leaks

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24173 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoArrange things so that if '-o "capture.auto_scroll: FALSE"' is passed to
gerald [Thu, 24 Jan 2008 01:23:19 +0000 (01:23 +0000)]
Arrange things so that if '-o "capture.auto_scroll: FALSE"' is passed to
Wireshark on the command line, auto-scroll is actually disabled.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24172 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of non-ASCII characters.
guy [Wed, 23 Jan 2008 20:15:13 +0000 (20:15 +0000)]
Get rid of non-ASCII characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24171 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of non-ASCII characters.
guy [Wed, 23 Jan 2008 20:12:23 +0000 (20:12 +0000)]
Get rid of non-ASCII characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24170 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of non-ASCII characters.
guy [Wed, 23 Jan 2008 19:47:40 +0000 (19:47 +0000)]
Get rid of non-ASCII characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24169 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix a minor memory leak; Remove some unused variables
wmeier [Wed, 23 Jan 2008 14:07:40 +0000 (14:07 +0000)]
Fix a minor memory leak; Remove some unused variables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24168 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix minor memory leak
wmeier [Wed, 23 Jan 2008 14:05:22 +0000 (14:05 +0000)]
Fix minor memory leak

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24167 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUnpack FindProcDLL.dll into $(WIRESHARK_LIBS\nsis-plugins, and tell NSIS
gerald [Wed, 23 Jan 2008 01:23:06 +0000 (01:23 +0000)]
Unpack FindProcDLL.dll into $(WIRESHARK_LIBS\nsis-plugins, and tell NSIS
where it is using "!addplugindir".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24166 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Bill Florac:
jake [Tue, 22 Jan 2008 18:20:00 +0000 (18:20 +0000)]
From Bill Florac:
Patch in revision 24163 is missing same fix needed for "case SRVREG", at line 1156.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24165 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDon't update COL_INFO at all if not claiming the packet as CMPP. Add a (guessed)...
morriss [Tue, 22 Jan 2008 18:05:45 +0000 (18:05 +0000)]
Don't update COL_INFO at all if not claiming the packet as CMPP. Add a (guessed) upper-size limit on the heuristics and take out a check that the tvb length matches the protocol length--that would essentially disable TCP reassembly of this protocol

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24164 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Bill Florac:
jake [Tue, 22 Jan 2008 07:36:33 +0000 (07:36 +0000)]
From Bill Florac:
The displaying of attribute-lists in an "Attribute Reply" (ATTRRPLY) seems to
be written to display some special non-conforming attributes.  Conforming
attributes are either displayed wrong or not displayed at all.

When displaying an attributes-list in a "Service Registration" (SRVREG), the
attribute list is only displayed as a single string (and usually truncated).
While this is not wrong, it should be broken up into the comma separated
attributes as "Attribute Requests" tries to do.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24163 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Bill Florac:
jake [Tue, 22 Jan 2008 06:49:49 +0000 (06:49 +0000)]
From Bill Florac:
When dissecting any message containing a "transport layer address", if the
address was NULL (which is valid), the offset pointer was not incremented by 1
and the remaining fields would not be dissected correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24162 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoClean up indentation.
guy [Tue, 22 Jan 2008 04:59:59 +0000 (04:59 +0000)]
Clean up indentation.

Move some comments to make it a bit clearer what each branch of the if
handles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24161 f5534014-38df-0310-8fa8-9805f1628bb7