obnox/wireshark/wip.git
14 years agoThe time stamp in a Wiretap packet header is now a wtap_nstime, not a
guy [Wed, 24 Aug 2005 23:53:40 +0000 (23:53 +0000)]
The time stamp in a Wiretap packet header is now a wtap_nstime, not a
"struct timeval".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15522 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix usec -> nsec translation
ulfl [Wed, 24 Aug 2005 22:27:21 +0000 (22:27 +0000)]
fix usec -> nsec translation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15521 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoEVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!
ulfl [Wed, 24 Aug 2005 21:31:56 +0000 (21:31 +0000)]
EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!

I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...

What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.

As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.

Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...

As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15520 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoProperly initialize our hf_ arrays. Make hf_rtcp_app_poc1_conn_session_type
gerald [Wed, 24 Aug 2005 20:34:15 +0000 (20:34 +0000)]
Properly initialize our hf_ arrays.  Make hf_rtcp_app_poc1_conn_session_type
an FT_UINT8 instead of an FT_BOOLEAN.  This keeps the Solaris builder from
crashing while running "-G values".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15519 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a comment typo
ulfl [Wed, 24 Aug 2005 18:35:54 +0000 (18:35 +0000)]
fix a comment typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15518 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Graeme Hewson
sahlberg [Wed, 24 Aug 2005 07:28:28 +0000 (07:28 +0000)]
From Graeme Hewson

Fix for infinite loop of configure events that were present for early GTK 2.4 in addition to 2.2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15517 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe name in a Display TLV is null-terminated (or padded with a null byte
guy [Tue, 23 Aug 2005 08:49:57 +0000 (08:49 +0000)]
The name in a Display TLV is null-terminated (or padded with a null byte
and extra crud).

Don't bother with length checking on the VLAN name item - if it's
zero-length, so be it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15516 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse "format_text()" and "tvb_format_text()" when displaying strings.
guy [Tue, 23 Aug 2005 08:34:19 +0000 (08:34 +0000)]
Use "format_text()" and "tvb_format_text()" when displaying strings.
(It's not necessary, or desirable, to use them when fetching strings.)

When processing a VLAN TLV, check the length of the TLV, so we don't end
up running past the end of the TLV and getting a negative remaining
length.  Append to the protocol tree item for the TLV, and the Info
column, as we dissect the VLAN ID and VLAN name fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15515 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix the parenthesization of an expression.
guy [Tue, 23 Aug 2005 08:01:46 +0000 (08:01 +0000)]
Fix the parenthesization of an expression.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15514 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTwo fixes to tektronix k12 import:
lego [Mon, 22 Aug 2005 23:11:48 +0000 (23:11 +0000)]
Two fixes to tektronix k12 import:

- it appears that there are more packet record types other than 0x00010020.
     accept anything matching 0x00010020/28 as a packet record.

- make the stack filename lowercase before comparing it so that capitalization is not an issue.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15513 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLength of string == lengt of element - headerlength
jmayer [Mon, 22 Aug 2005 17:48:17 +0000 (17:48 +0000)]
Length of string == lengt of element - headerlength

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15512 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Timo Metsala:
etxrab [Mon, 22 Aug 2005 16:26:29 +0000 (16:26 +0000)]
From Timo Metsala:
Updates the  PoC floor control parsing to comply to the latest version of the
specification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15511 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix decoding of sendIdentificationArg/Res and ProvideSubscriberLocation
etxrab [Mon, 22 Aug 2005 16:19:31 +0000 (16:19 +0000)]
Fix decoding of sendIdentificationArg/Res and ProvideSubscriberLocation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15510 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a "time_stat_init()" routine to initialize the fields of a
guy [Mon, 22 Aug 2005 07:12:20 +0000 (07:12 +0000)]
Add a "time_stat_init()" routine to initialize the fields of a
"timestat_t".

Move "nstime_to_msec()" to "epan/nstime.c", as it has nothing to do with
a "timestat_t".

Use structure assignment when possible.

Fix the "addtime()" macro and use it in "time_stat_update()".

Use "timestat_t"s, and the routines to manipulate them, in the service
response time table code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15509 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Graeme Lunt:
etxrab [Mon, 22 Aug 2005 05:49:09 +0000 (05:49 +0000)]
From Graeme Lunt:
 Zero length elements (e.g. an empty SET) the logic is slightly wrong in get_ber_length().

Make SET work.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15508 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExport get_timesum().
guy [Sun, 21 Aug 2005 23:24:20 +0000 (23:24 +0000)]
Export get_timesum().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15507 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse "g_strdup_printf()" rather than formatting into a fixed-length
guy [Sun, 21 Aug 2005 21:50:49 +0000 (21:50 +0000)]
Use "g_strdup_printf()" rather than formatting into a fixed-length
buffer and "g_strdup()"ing it.

Use the nstime.c routines to compute time deltas and to add up times.

Don't add rows to the CList until a procedure gets a non-zero call
count, so only the ones with non-zero call counts are displayed (and
especially so that procedure numbers not corresponding to real
procedures aren't displayed!).

Ethereal requires 64-bit integer support, so don't bother checking
whether we have it.

Use the right format for 64-bit integers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15506 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Make it possible to filter on eap.null, eap.info, eap.unknown etc
jmayer [Sun, 21 Aug 2005 21:32:19 +0000 (21:32 +0000)]
- Make it possible to filter on eap.null, eap.info, eap.unknown etc
- Display "Info" instead of "System" in packet summary
- Make the Null element look like the other elements.
- Small element summary formatting changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15505 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse the tap_dfilter_dlg mechanism.
guy [Sun, 21 Aug 2005 20:24:59 +0000 (20:24 +0000)]
Use the tap_dfilter_dlg mechanism.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15504 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse the tap_dfilter_dlg code.
guy [Sun, 21 Aug 2005 20:16:12 +0000 (20:16 +0000)]
Use the tap_dfilter_dlg code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15503 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- In the info summary, port# and slot# were exchanged
jmayer [Sun, 21 Aug 2005 19:25:45 +0000 (19:25 +0000)]
- In the info summary, port# and slot# were exchanged
- In the Display element, the length of the display string
  was 4 too long
- Display the Vlan id in the packet summary, not just "Vlan"
- Remove trailing whitespace

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15502 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAs per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so
guy [Sun, 21 Aug 2005 19:24:11 +0000 (19:24 +0000)]
As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so
that it doesn't appear to be part of GTK+.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15501 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Duigou:
etxrab [Sun, 21 Aug 2005 18:42:54 +0000 (18:42 +0000)]
From Mike Duigou:

A patch to the JXTA dissector. It's purpose is to improve
the behaviour of the dissector when dissecting captures that do not
include the whole conversation.

The dissector is now more capable of isolating a conversation without
seeing the beginning of the conversation. It's still not always able to
pick up all conversations (suggestions, patches and hints welcome).

improved some of the doxygen docs and comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15500 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe protocol item in the protocol tree will have a gray background now, which makes...
ulfl [Sun, 21 Aug 2005 15:23:48 +0000 (15:23 +0000)]
The protocol item in the protocol tree will have a gray background now, which makes it much better visible.

Add some more optional flags to the protocol items, so more "special cases" can be marked in the protocol tree.

New flags:
/** The protocol field has a bad checksum */
FI_CHECKSUM_ERROR
/** The protocol field has an unusual sequence (e.g. TCP window is zero) */
FI_SEQUENCE_WARNING
/** The protocol field has a bad sequence (e.g. TCP segment is lost) */
FI_SEQUENCE_ERROR

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15499 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoas discussed some time ago: don't add bad checksum fields conditionally but use a...
ulfl [Sun, 21 Aug 2005 15:13:47 +0000 (15:13 +0000)]
as discussed some time ago: don't add bad checksum fields conditionally but use a subtree and use boolean flags instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15498 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove sprintf from gsm_a
etxrab [Sun, 21 Aug 2005 13:52:33 +0000 (13:52 +0000)]
remove sprintf from gsm_a

Do the update for the .cnf file too.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15497 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago"gtk_tap_dfilter_dlg_cb()" is no longer used outside
guy [Sun, 21 Aug 2005 11:09:36 +0000 (11:09 +0000)]
"gtk_tap_dfilter_dlg_cb()" is no longer used outside
gtk/tap_dfilter_dlg.c; don't export it.

That means that gtk/tap_dfilter_dlg.h is no longer useful; get rid of
it.

Rename "gtk_tap_dfilter_dlg_cb()" to "tap_dfilter_dlg_cb()", as it's
inside GTK+-specific code, so there's no need to distinguish it from
non-GTK+ callbacks.

Update some comments to reflect the name change and the new API for
registering tap_dfilter_dlg stats.

Make the AFP and SMB stats use the gtk/tap_dfilter_dlg.c stuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15496 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHave "register_dfilter_stat()" add "..." to the menu item, as all menu
guy [Sun, 21 Aug 2005 10:29:47 +0000 (10:29 +0000)]
Have "register_dfilter_stat()" add "..." to the menu item, as all menu
items registered with it pop up a dialog box before displaying the stat.
Don't pass a name with "..." to it.

Put "..." into other menu items that pop up a dialog box before
displaying the stat; remove "..." from other menu items that don't.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15495 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet properties.
guy [Sun, 21 Aug 2005 10:00:56 +0000 (10:00 +0000)]
Set properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15494 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a "register_dfilter_stat()", to register stats that take a display
guy [Sun, 21 Aug 2005 09:48:27 +0000 (09:48 +0000)]
Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".

Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.

Get rid of headers not declaring any functions not being used in the
module.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15493 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove sprintf from gsm_a
sahlberg [Sun, 21 Aug 2005 01:52:09 +0000 (01:52 +0000)]
remove sprintf from gsm_a

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15492 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove gmalloc and sprintf
sahlberg [Sun, 21 Aug 2005 01:14:43 +0000 (01:14 +0000)]
remove gmalloc and sprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15491 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove sprintf
sahlberg [Sun, 21 Aug 2005 00:55:46 +0000 (00:55 +0000)]
remove sprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15490 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe routines registered with "register_stat_cmd_arg()" *are* called if
guy [Sat, 20 Aug 2005 22:28:49 +0000 (22:28 +0000)]
The routines registered with "register_stat_cmd_arg()" *are* called if
you use the "-z" command-line options for them; make them pop up the
appropriate windows.

Move the calls to "register_stat_cmd_arg()" after the code to register
the tap, just as the calls to "register_stat_menu_item()" are done after
registering the tap.

Use "g_strdup_printf()" rather than formatting into a fixed-length
buffer and "g_strdup()"ing that buffer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15489 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWe already have a tap that registers as a command-line stat under the
guy [Sat, 20 Aug 2005 22:26:32 +0000 (22:26 +0000)]
We already have a tap that registers as a command-line stat under the
name "rtp"; we don't need another one, especially given that
"rtp_stream.c" doesn't directly implement a stat (note that it doesn't
register a menu item).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15488 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agocapture_sync.c(290) : warning C4090: 'function' : different 'const' qualifiers
ulfl [Sat, 20 Aug 2005 22:16:12 +0000 (22:16 +0000)]
capture_sync.c(290) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(290) : warning C4022: 'g_realloc' : pointer mismatch for actual parameter 1
capture_sync.c(431) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(431) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1
capture_sync.c(442) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(442) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1
capture_sync.c(549) : warning C4090: 'function' : different 'const' qualifiers
capture_sync.c(549) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15487 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove sprintf
sahlberg [Sat, 20 Aug 2005 22:15:39 +0000 (22:15 +0000)]
remove sprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15486 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoradius_dict.l(216) : warning C4090: 'function' : different 'const' qualifiers
ulfl [Sat, 20 Aug 2005 22:08:35 +0000 (22:08 +0000)]
radius_dict.l(216) : warning C4090: 'function' : different 'const' qualifiers
radius_dict.l(216) : warning C4022: 'g_hash_table_insert' : pointer mismatch for actual parameter 2
radius_dict.l(268) : warning C4090: 'function' : different 'const' qualifiers
radius_dict.l(268) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15485 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremoval of sprintf
sahlberg [Sat, 20 Aug 2005 22:06:31 +0000 (22:06 +0000)]
removal of sprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15484 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRename epan/stat.[ch] to epan/stat_cmd_args.[ch] - it only deals with
guy [Sat, 20 Aug 2005 20:06:05 +0000 (20:06 +0000)]
Rename epan/stat.[ch] to epan/stat_cmd_args.[ch] - it only deals with
implementing the "-z" command-line arguments, it doesn't deal with *all*
issues for stats.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15483 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExplain in more detail the split between the stuff in ui_util.h and in
guy [Sat, 20 Aug 2005 19:49:22 +0000 (19:49 +0000)]
Explain in more detail the split between the stuff in ui_util.h and in
gtk/gui_utils.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15482 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExplain in more detail what this file is for.
guy [Sat, 20 Aug 2005 19:45:53 +0000 (19:45 +0000)]
Explain in more detail what this file is for.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15481 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThere's no longer a need to individually remove items from
guy [Sat, 20 Aug 2005 18:17:36 +0000 (18:17 +0000)]
There's no longer a need to individually remove items from
acse_ctx_oid_table - destroying the hash table will destroy the hash
table items, and the destroy function no longer has any work to do
because the OID strings are now allocated with se_strdup() (and thus get
freed when the capture is closed).

Regenerate packet-acse.c, which also regenerates acse-exp.cnf.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15480 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFlag the "add_string" parameter as unused if it is - and don't flag it
guy [Sat, 20 Aug 2005 18:01:07 +0000 (18:01 +0000)]
Flag the "add_string" parameter as unused if it is - and don't flag it
as such if it *is* used. Get rid of the "add_string" parameter to
"param_digits_basic", as that function *isn't* called through a pointer.

Don't flag arguments in declarations as unused; you only do that in
definitions.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15479 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago"ascend-grammar.h" is generated by Bison with a copy of the definition
guy [Sat, 20 Aug 2005 17:49:58 +0000 (17:49 +0000)]
"ascend-grammar.h" is generated by Bison with a copy of the definition
of the YYSTYPE structure in "ascend-grammar.c"; the intent is that other
files include "ascend-grammar.h" if they need that structure, but that
"ascend-grammar.c" not itself include "ascend-grammar.h".  If it *does*
include it, the compiler complains about YYSTYPE being redefined (even
though the two structures are identical).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15478 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAnd if we add a file, add it to Makefile.am as well
jmayer [Sat, 20 Aug 2005 16:30:23 +0000 (16:30 +0000)]
And if we add a file, add it to Makefile.am as well

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15477 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf we delete a file, don't forget to remove it from Makefile.common
jmayer [Sat, 20 Aug 2005 16:24:35 +0000 (16:24 +0000)]
If we delete a file, don't forget to remove it from Makefile.common

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15476 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Include the .h files in their .c files.
jmayer [Sat, 20 Aug 2005 16:19:22 +0000 (16:19 +0000)]
- Include the .h files in their .c files.
- Remove epan/dissectors/packet-sna.h, it isn't used anywhere.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15475 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremoved MSVC warnings:
ulfl [Sat, 20 Aug 2005 15:58:42 +0000 (15:58 +0000)]
removed MSVC warnings:

packet-camel.c(6829) : warning C4101: 'version_str' : unreferenced local variable
packet-quakeworld.c(172) : warning C4090: 'return' : different 'const' qualifiers
packet-smb.c(10859) : warning C4101: 'target_name_len' : unreferenced local variable
packet-smb.c(10860) : warning C4101: 'fn_len' : unreferenced local variable
packet-smb.c(10858) : warning C4101: 'fn' : unreferenced local variable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15474 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWin32: exported DATA must be declared with ETH_VAR_IMPORT to be available from outsid...
ulfl [Sat, 20 Aug 2005 15:19:31 +0000 (15:19 +0000)]
Win32: exported DATA must be declared with ETH_VAR_IMPORT to be available from outside the lib

fixes current Win32 buildbot problem

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15473 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOne file missed in last checkin
jmayer [Sat, 20 Aug 2005 14:08:53 +0000 (14:08 +0000)]
One file missed in last checkin

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15472 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Declare some functions static
jmayer [Sat, 20 Aug 2005 14:02:00 +0000 (14:02 +0000)]
- Declare some functions static
- Add plugins_dlg.h
- Include .h files in their respective .c files
- Include .h and remove extern declarations in .c files
- set eol-style and keywords on gui_utils.[hc]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15471 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some comments on the originating files of the declarations
jmayer [Sat, 20 Aug 2005 13:21:09 +0000 (13:21 +0000)]
Add some comments on the originating files of the declarations

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15470 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomore sprintf updates
sahlberg [Sat, 20 Aug 2005 13:02:08 +0000 (13:02 +0000)]
more sprintf updates

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15469 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Include ../ui_util.h into files that implement functions declard in
jmayer [Sat, 20 Aug 2005 12:57:52 +0000 (12:57 +0000)]
- Include ../ui_util.h into files that implement functions declard in
  ui_util.h
- Replace one instance of ui_util.h by gui_utils.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15468 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove sprintf
sahlberg [Sat, 20 Aug 2005 12:38:45 +0000 (12:38 +0000)]
remove sprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15467 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoget rid of a whole chunk of sprintfs
sahlberg [Sat, 20 Aug 2005 12:28:16 +0000 (12:28 +0000)]
get rid of a whole chunk of sprintfs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15466 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agorenamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named...
ulfl [Sat, 20 Aug 2005 12:09:48 +0000 (12:09 +0000)]
renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15465 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gisle Vanem: export get_timedelta() for use by AFP and SMB taps.
guy [Sat, 20 Aug 2005 10:03:07 +0000 (10:03 +0000)]
From Gisle Vanem: export get_timedelta() for use by AFP and SMB taps.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15464 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe order in which arguments to a function are evaluated isn't defined
guy [Sat, 20 Aug 2005 09:35:55 +0000 (09:35 +0000)]
The order in which arguments to a function are evaluated isn't defined
by C.  Do decrements of arguments before passing them to a function.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15463 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWiden some variables so the code in question can handle large files if,
guy [Sat, 20 Aug 2005 09:08:24 +0000 (09:08 +0000)]
Widen some variables so the code in question can handle large files if,
as, and when Wiretap can handle them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15462 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExport AFP's CommandCode_vals for use by the AFP taps.
guy [Sat, 20 Aug 2005 08:15:21 +0000 (08:15 +0000)]
Export AFP's CommandCode_vals for use by the AFP taps.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15461 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosprintf elimination
sahlberg [Sat, 20 Aug 2005 05:37:08 +0000 (05:37 +0000)]
sprintf elimination

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15460 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosprintf removals
sahlberg [Sat, 20 Aug 2005 05:31:36 +0000 (05:31 +0000)]
sprintf removals

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15459 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove some more sprintf
sahlberg [Sat, 20 Aug 2005 02:51:13 +0000 (02:51 +0000)]
remove some more sprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15458 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremoval of even more sprintf
sahlberg [Sat, 20 Aug 2005 02:33:33 +0000 (02:33 +0000)]
removal of even more sprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15457 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFor AFP requests, add in the frame with the (last part of the) reply, if
guy [Sat, 20 Aug 2005 02:19:37 +0000 (02:19 +0000)]
For AFP requests, add in the frame with the (last part of the) reply, if
possible, and, for AFP replies, add in the frame with the request and
the time between those two frames.

Have AFP per-request-type RTT statistics, similar to SMB's statistics.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15456 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse get_timedelta() to get the difference between two times.
guy [Sat, 20 Aug 2005 02:15:02 +0000 (02:15 +0000)]
Use get_timedelta() to get the difference between two times.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15455 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of f_len field in capture_file structure - we can just keep
guy [Sat, 20 Aug 2005 02:14:01 +0000 (02:14 +0000)]
Get rid of f_len field in capture_file structure - we can just keep
the length locally. within cf_read().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15454 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd -Wmissing-declarations -Wwrite-strings to extra-gcc-flags
jmayer [Sat, 20 Aug 2005 02:05:02 +0000 (02:05 +0000)]
Add  -Wmissing-declarations -Wwrite-strings to extra-gcc-flags

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15453 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTrivial warning fixes
jmayer [Sat, 20 Aug 2005 02:03:40 +0000 (02:03 +0000)]
Trivial warning fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15452 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove sprintf from mtp3
sahlberg [Sat, 20 Aug 2005 01:24:23 +0000 (01:24 +0000)]
remove sprintf from mtp3

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15451 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove sprintf from pgm and x11
sahlberg [Sat, 20 Aug 2005 01:10:40 +0000 (01:10 +0000)]
remove sprintf from pgm and x11

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15450 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove sprintf from v120 and wccp
sahlberg [Sat, 20 Aug 2005 00:33:08 +0000 (00:33 +0000)]
remove sprintf from v120 and wccp

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15449 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove sprintf from rpc
sahlberg [Sat, 20 Aug 2005 00:27:46 +0000 (00:27 +0000)]
remove sprintf from rpc

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15448 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix buffer handling and remove sprintf
sahlberg [Sat, 20 Aug 2005 00:07:20 +0000 (00:07 +0000)]
fix buffer  handling and remove sprintf

there was at least one instance where an ip address was printed in dotted decimal to a 10 byte array on the stack.
I.e. a guaranteed buffer overrun for a stack object.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15447 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomore sprintf removals,
sahlberg [Fri, 19 Aug 2005 23:28:23 +0000 (23:28 +0000)]
more  sprintf removals,
replace some char arrays on the stack to ep_alloc()ed memory

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15446 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove a gmalloc and al sprintf from spnego
sahlberg [Fri, 19 Aug 2005 23:03:56 +0000 (23:03 +0000)]
remove a gmalloc and al sprintf  from spnego

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15445 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agono more g_malloc or sprintf in snmp
sahlberg [Fri, 19 Aug 2005 22:44:56 +0000 (22:44 +0000)]
no more g_malloc  or sprintf   in snmp

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15444 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomore gmalloc sprintf removals
sahlberg [Fri, 19 Aug 2005 22:34:28 +0000 (22:34 +0000)]
more gmalloc sprintf removals

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15443 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove two gmalloc and some sprintf
sahlberg [Fri, 19 Aug 2005 22:26:10 +0000 (22:26 +0000)]
remove two gmalloc and some sprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15442 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Jeff Snyder
sahlberg [Fri, 19 Aug 2005 21:19:49 +0000 (21:19 +0000)]
from Jeff Snyder

H245 updates
make multiple pdus/frame work

update to have nu limit on the max number of tappable pdus per frame

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15441 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #357: increment ring buffer "file names" (again?)
ulfl [Fri, 19 Aug 2005 21:13:49 +0000 (21:13 +0000)]
fix #357: increment ring buffer "file names" (again?)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15440 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoas the WinPcap installation is now longer really needed (it has become part of the...
ulfl [Fri, 19 Aug 2005 21:09:38 +0000 (21:09 +0000)]
as the WinPcap installation is now longer really needed (it has become part of the main Ethereal installer) clarify things about installation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15439 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWe've changed the Wiretap ABI (removed one routine), so bump the library
guy [Fri, 19 Aug 2005 19:44:21 +0000 (19:44 +0000)]
We've changed the Wiretap ABI (removed one routine), so bump the library
version number.

WinPcap 3.1 is no longer in alpha.  (Should we make WINPCAP_VERSION 3.1,
so we default to assuming WinPcap 3.1?)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15438 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd APIs to Wiretap to return the file of the size as supplied by the OS
guy [Fri, 19 Aug 2005 19:40:00 +0000 (19:40 +0000)]
Add APIs to Wiretap to return the file of the size as supplied by the OS
(so if the file's gzipped, it's *NOT* the size of the file after
uncompressing), and an approximation of the amount of that data read
sequentially so far.

Use those for various progress bars and the like.

Make the fstat() in the Ascend trace reader directly use wth->fd, as
it's inside Wiretap; that gets rid of the last caller of wtap_fd() (as
we're no longer directly using fstat() or lseek() in Ethereal), so get
rid of wtap_fd().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15437 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd information about unsupported/fresh windows versions
ulfl [Fri, 19 Aug 2005 19:29:29 +0000 (19:29 +0000)]
add information about unsupported/fresh windows versions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15436 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRestore pinfo->private_data after calling another dissector, in case it gets
gerald [Fri, 19 Aug 2005 18:28:50 +0000 (18:28 +0000)]
Restore pinfo->private_data after calling another dissector, in case it gets
overwritten.  Fixes bug 367.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15435 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd packet-alcap.h to the Makefiles.
lego [Fri, 19 Aug 2005 16:46:46 +0000 (16:46 +0000)]
Add packet-alcap.h to the Makefiles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15434 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosome ememification
lego [Fri, 19 Aug 2005 15:50:48 +0000 (15:50 +0000)]
some ememification

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15433 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd the $Id:$
lego [Fri, 19 Aug 2005 15:46:39 +0000 (15:46 +0000)]
add the $Id:$

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15432 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosome ememification
lego [Fri, 19 Aug 2005 15:35:42 +0000 (15:35 +0000)]
some ememification

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15431 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoKeep information about the call-leg so that all the messages of a leg can be filtered...
lego [Fri, 19 Aug 2005 11:53:39 +0000 (11:53 +0000)]
Keep information about the call-leg so that all the messages of a leg can be filtered given a parameter of it.
Create the header to export the structures thyat hold that info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15430 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove the stats.[ch] stuff into epan, so plugins can use it.
guy [Fri, 19 Aug 2005 10:00:14 +0000 (10:00 +0000)]
Move the stats.[ch] stuff into epan, so plugins can use it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15429 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Matthias Drochner:
sahlberg [Fri, 19 Aug 2005 09:47:11 +0000 (09:47 +0000)]
From Matthias Drochner:
I'll attach a patch which fixes the decoding of authenticated
LDAP bind replies. The SASL credentials are always "context
specific" in terms of ASN.1.
I've tested the fix with DIGEST-MD5 authentication.
(Without the patch, ethereal complains about a wrong type
because it expects an ASN.a octet string.)
(You might also consider a stricter check of the ASN.1 header
type for the GSSAPI and GSS-SPNEGO cases, but I can't test this.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15428 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove the APIs for registering and processing "-z" command-line arguments
guy [Fri, 19 Aug 2005 09:29:41 +0000 (09:29 +0000)]
Move the APIs for registering and processing "-z" command-line arguments
and "Statistics" menu items into "stat.h" and "stat.c", to separate them
from the core tapping APIs.  A tap could conceivably not register as a
"-z" command-line argument or "Statistics" menu item, and a stat could
conceivably not be implemented as a tap, and dissectors that implement
tapping points don't need the UI-related stuff from "stat.h", they just
want the tap-related stuff in <epan/tap.h>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15427 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Markus Seehofer
sahlberg [Fri, 19 Aug 2005 09:28:58 +0000 (09:28 +0000)]
From Markus Seehofer

PTP updates

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15426 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Michael Lum:
sahlberg [Fri, 19 Aug 2005 08:43:58 +0000 (08:43 +0000)]
From Michael Lum:

Statistics data structure was not being passed to the draw routine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15425 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Michael Lum:
sahlberg [Fri, 19 Aug 2005 08:39:19 +0000 (08:39 +0000)]
From Michael Lum:
Fixed quite a few parameter IDs based on TIA-41-E (originally my mistakes).
Added support for filtering by DN, MIN, etc.
Moved where embedded 'Bearer Data' parameter is sub-dissected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15424 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Michael Lum
sahlberg [Fri, 19 Aug 2005 08:36:38 +0000 (08:36 +0000)]
From Michael Lum

Slight modification to allow a protocol beneath SCCP (i.e. MTP3)
specify how the SCCP message should be dissected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15423 f5534014-38df-0310-8fa8-9805f1628bb7