18 years agoMore updates from Hannes Gredler.
guy [Thu, 7 Jun 2001 19:13:35 +0000 (19:13 +0000)]
More updates from Hannes Gredler.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3522 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdates from Martin Held.
guy [Wed, 6 Jun 2001 18:53:27 +0000 (18:53 +0000)]
Updates from Martin Held.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3521 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGnutella support, from B. Johannessen.
guy [Wed, 6 Jun 2001 01:30:30 +0000 (01:30 +0000)]
Gnutella support, from B. Johannessen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3520 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a comment.
guy [Wed, 6 Jun 2001 01:29:17 +0000 (01:29 +0000)]
Fix a comment.

Split some lines differently.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3519 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a typo.
guy [Tue, 5 Jun 2001 23:40:34 +0000 (23:40 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3518 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agohmac-md5 authentication support for IS-IS, from Hannes Gredler.
guy [Tue, 5 Jun 2001 21:23:32 +0000 (21:23 +0000)]
hmac-md5 authentication support for IS-IS, from Hannes Gredler.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3517 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoJuniper Networks vendor ID in RADIUS dissector, from Hannes Gredler.
guy [Tue, 5 Jun 2001 21:21:38 +0000 (21:21 +0000)]
Juniper Networks vendor ID in RADIUS dissector, from Hannes Gredler.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3516 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCompensate better for invalid (at least for IPv4) prefix lengths in
guy [Tue, 5 Jun 2001 21:00:17 +0000 (21:00 +0000)]
Compensate better for invalid (at least for IPv4) prefix lengths in

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3515 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCorrectly compute the OSI checksum.
guy [Tue, 5 Jun 2001 09:06:19 +0000 (09:06 +0000)]
Correctly compute the OSI checksum.

Have "calc_checksum()" just return an indication of the status of the

Check the CLNP header checksum, and put display its status.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3514 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoEnable "Match Selected" only if there's a field selected *and* we can do
guy [Tue, 5 Jun 2001 07:39:31 +0000 (07:39 +0000)]
Enable "Match Selected" only if there's a field selected *and* we can do
a "Match Selected" on it - we can't do a "Match Selected" if the field
has no value (e.g., FT_NULL) and has a length of 0.

If we unselect the current packet, we don't have a protocol tree, so we
don't have a currently selected field - clear the "Match Selected" menu
item and the display in the status line of information about the
currently selected field.

Move the low-level statusbar manipulation into "gtk/main.c", in routines
whose API doesn't expose anything GTK+-ish.

"close_cap_file()" calls one of those routines to clear out the status
bar, so it doesn't need to take a pointer to the statusbar widget as an

"clear_tree_and_hex_views()" is purely a display-manipulating routine;
move it to "gtk/proto_draw.c".

Extract from "tree_view_unselect_row_cb()" an "unselect_field()" routine
to do all the work that needs to be done if the currently selected
protocol tree row is unselected, and call it if the currently selected
packet list row is unselected (if it's unselected, there *is* no
protocol tree, so no row can be selected), as well as from

Before pushing a new field-description message onto the statusbar, pop
the old one off.

Get rid of an unused variable (set, but not used).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3513 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThere is no string value assigned to the "ip.fragment.error",
guy [Tue, 5 Jun 2001 05:54:14 +0000 (05:54 +0000)]
There is no string value assigned to the "ip.fragment.error",
"ip.fragment", and "ip.fragments" fields, so make them FT_NONE, not
FT_STRING.  (Otherwise, if you try to do a "Match Selected" on them, we
dump core because the value is a null pointer and we try to dereference

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3512 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake Ethereal default to promiscuous-mode captures, the way it did
guy [Mon, 4 Jun 2001 08:07:34 +0000 (08:07 +0000)]
Make Ethereal default to promiscuous-mode captures, the way it did
before promiscuous-vs-non-promiscuous was made a preference in the
preferences file (I suspect at least some of the problems people are
seeing with captures on Windows not seeing all the traffic they expect
to see might be due to the captures not being done in promiscuous mode -
and the default behavior shouldn't have changed in any case).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3511 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDefine a "COPY_ADDRESS()" macro, which copies the data in one address to
guy [Mon, 4 Jun 2001 07:27:50 +0000 (07:27 +0000)]
Define a "COPY_ADDRESS()" macro, which copies the data in one address to
another (copying the data to a mallocated array) in
"epan/packet_info.h", and use it in the conversation code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3510 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd an "ADDRESSES_EQUAL()" macro, taking pointers to two "address"
guy [Mon, 4 Jun 2001 06:46:07 +0000 (06:46 +0000)]
Add an "ADDRESSES_EQUAL()" macro, taking pointers to two "address"
structures as arguments, that evaluates to "true" if the two addresses
are equal and "false" if they're not equal.  Use that macro in the
conversation code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3509 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdates from Mark Burton.
guy [Mon, 4 Jun 2001 05:32:52 +0000 (05:32 +0000)]
Updates from Mark Burton.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3508 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCorrect the values for sna_rh_ru_category_vals, thanks to
gram [Sat, 2 Jun 2001 22:18:17 +0000 (22:18 +0000)]
Correct the values for sna_rh_ru_category_vals, thanks to
Edgar Iglesias <edgar.iglesias@axis.com>
Also fix a few more places where I accidentally used hex instead
of binary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3507 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"old_dissector_delete()" is no longer used; remove it.
guy [Sat, 2 Jun 2001 08:23:10 +0000 (08:23 +0000)]
"old_dissector_delete()" is no longer used; remove it.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3506 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoHandoff registration routines must be named "proto_reg_handoff_XXX()",
guy [Sat, 2 Jun 2001 08:15:57 +0000 (08:15 +0000)]
Handoff registration routines must be named "proto_reg_handoff_XXX()",
not "proto_register_handoff_xxx()"; otherwise, the Python
"register.c"-generation script will think it's a protocol registration
routine not a handoff registration routine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3505 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoOn Windows, "min" apparently gets defined or declared in such a fashion
guy [Sat, 2 Jun 2001 08:13:04 +0000 (08:13 +0000)]
On Windows, "min" apparently gets defined or declared in such a fashion
that declaring our own static function "min()" doesn't work; rename it
"iscsi_min()" to get rid of the problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3504 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNot all platforms have u_int32_t (for example, Windows+MSVC doesn't), so
guy [Sat, 2 Jun 2001 08:10:02 +0000 (08:10 +0000)]
Not all platforms have u_int32_t (for example, Windows+MSVC doesn't), so
use "guint32" instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3503 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoWindows+MSVC lacks "strptime()", so we need to include "strptime.h" to
guy [Sat, 2 Jun 2001 08:07:47 +0000 (08:07 +0000)]
Windows+MSVC lacks "strptime()", so we need to include "strptime.h" to
declare our version of it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3502 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoChanges to structure initializations not to initialize some but not all
guy [Sat, 2 Jun 2001 06:26:54 +0000 (06:26 +0000)]
Changes to structure initializations not to initialize some but not all
members, from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3501 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoWindows and the MSVC++ 6.0 library don't have "strptime()", so pull in
guy [Sat, 2 Jun 2001 06:21:14 +0000 (06:21 +0000)]
Windows and the MSVC++ 6.0 library don't have "strptime()", so pull in
the glibc "strptime()" (modified so it doesn't require the rest of
glibc), set up the configure script to check for it, and set up
Makefile.am and Makefile.nmake to use it.

Get rid of NEED_MKSTEMP - nothing uses it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3500 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCreate the tree for an ICMPv6 optionn before putting something in it.
guy [Sat, 2 Jun 2001 06:10:08 +0000 (06:10 +0000)]
Create the tree for an ICMPv6 optionn before putting something in it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3499 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThe Cisco 802.11 bridges used 0000F8, i.e. OUI_CISCO_90, not 000078;
guy [Sat, 2 Jun 2001 03:04:12 +0000 (03:04 +0000)]
The Cisco 802.11 bridges used 0000F8, i.e. OUI_CISCO_90, not 000078;
various Cisco documents indicate that 0000F8 is used on at least some
Cisco boxes for bridging Ethernet frames onto 802.x+LLC frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3498 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agodraft-draves-ipngwg-router-selection-01 support.
itojun [Fri, 1 Jun 2001 23:53:49 +0000 (23:53 +0000)]
draft-draves-ipngwg-router-selection-01 support.
fix icmp6 homeagent info option decoding (convert to tvb framework).
plug a memory leak.
sync some of mobile-ip6 #define symbol names with draft-ietf-ipngwg-2292bis-02.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3497 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSome Cisco 802.11 bridges apparently change the OUI of packets from
guy [Fri, 1 Jun 2001 23:04:37 +0000 (23:04 +0000)]
Some Cisco 802.11 bridges apparently change the OUI of packets from
000000 to 000078, so treat LLC packets with that OUI the same way we
treat LLC packets with 000000.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3496 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdates from Martin Held.
guy [Fri, 1 Jun 2001 21:00:13 +0000 (21:00 +0000)]
Updates from Martin Held.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3495 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoBug fixes, and WEP support, from Javier Achirica.
guy [Fri, 1 Jun 2001 01:15:29 +0000 (01:15 +0000)]
Bug fixes, and WEP support, from Javier Achirica.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3494 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSupport for leading LWS in RTSP headers, from Robert Tsai.
guy [Thu, 31 May 2001 20:40:29 +0000 (20:40 +0000)]
Support for leading LWS in RTSP headers, from Robert Tsai.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3493 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdates from Mark Burton.
guy [Thu, 31 May 2001 19:20:41 +0000 (19:20 +0000)]
Updates from Mark Burton.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3492 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDon'tcramallthewordsinapreference'snametogether;
guy [Thu, 31 May 2001 08:54:17 +0000 (08:54 +0000)]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3491 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake the "short name" of MTP Level 3 just "MTP3", matching what we put
guy [Thu, 31 May 2001 08:51:29 +0000 (08:51 +0000)]
Make the "short name" of MTP Level 3 just "MTP3", matching what we put
in the Protocol column, and make the "filter name" "mtp3", as filter
names are supposed to be all-lower-case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3490 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSupport for "-N" flag enabling selected forms of name resolution, from
guy [Thu, 31 May 2001 08:36:46 +0000 (08:36 +0000)]
Support for "-N" flag enabling selected forms of name resolution, from
Joerg Meyer.

Support for saving to the preferences file the settings for all types of
name resolution.

Do a case-insensitive check for "true" and "false" in Boolean preference

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3489 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd support for "Match Selected" on FT_ABSOLUTE_TIME and
guy [Thu, 31 May 2001 07:15:23 +0000 (07:15 +0000)]
Add support for "Match Selected" on FT_ABSOLUTE_TIME and

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3488 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDisplay all the digits of the microsecond field of an absolute time
guy [Thu, 31 May 2001 06:48:00 +0000 (06:48 +0000)]
Display all the digits of the microsecond field of an absolute time

Check that the microseconds field of an absolute time is valid, if it's

Set "tm_isdst" in the "struct tm" handed to "mktime()" to -1, so that
"mktime()" will attempt to figure out whether the time is daylight
savings time or not.

Check that "mktime()" was able to convert the time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3487 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDon't require both the seconds and microseconds parts of a relative time
guy [Thu, 31 May 2001 06:20:10 +0000 (06:20 +0000)]
Don't require both the seconds and microseconds parts of a relative time
to be present - "1" is just as good as "1.0", and ".1" is just as good
as "1.1".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3486 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFree the string you "g_strdup()"ed, rather than handing "g_free()" the
guy [Thu, 31 May 2001 05:33:15 +0000 (05:33 +0000)]
Free the string you "g_strdup()"ed, rather than handing "g_free()" the
null pointer that provoked you to free the string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3485 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSupport for filtering on absolute and relative time fields, from Ronnie
guy [Thu, 31 May 2001 05:01:06 +0000 (05:01 +0000)]
Support for filtering on absolute and relative time fields, from Ronnie

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3484 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdates from Johan Jorgensen.
guy [Wed, 30 May 2001 19:17:31 +0000 (19:17 +0000)]
Updates from Johan Jorgensen.

Don't use "pinfo->captured_len" to check the length of the packet -
that's the length of the *entire* frame, not the length of the portion
that belongs to the 802.11 dissector (there are currently no dissectors
for protocols in which 802.11 is encapsulated, so it doesn't currently
make a difference, but dissectors should use "tvb_length()" and so on to
get that information for the tvbuff they were handed).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3483 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoiSCSI support, from Mark Burton.
guy [Wed, 30 May 2001 18:52:38 +0000 (18:52 +0000)]
iSCSI support, from Mark Burton.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3482 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMSVC++ doesn't define "uint"; use "guint" instead.
guy [Wed, 30 May 2001 08:49:23 +0000 (08:49 +0000)]
MSVC++ doesn't define "uint"; use "guint" instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3481 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of some unnecessary settings of "pinfo->current_proto" - if the
guy [Wed, 30 May 2001 07:48:23 +0000 (07:48 +0000)]
Get rid of some unnecessary settings of "pinfo->current_proto" - if the
dissector is called only through a handle or dissector table, the code
that handles those calls sets it for you.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3480 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall the Vines IP dissector through a handle, and call the Vines SPP
guy [Wed, 30 May 2001 07:41:18 +0000 (07:41 +0000)]
Call the Vines IP dissector through a handle, and call the Vines SPP
dissector through a handoff table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3479 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNo old-style dissectors call "old_dissector_try_port()", so get rid of
guy [Wed, 30 May 2001 06:41:08 +0000 (06:41 +0000)]
No old-style dissectors call "old_dissector_try_port()", so get rid of

There are no longer any old-style heuristic or conversation dissectors,
so get rid of "old_heur_dissector_add()" and "old_conv_dissector_add()"
and the data-structure members that support old-style heuristic and
conversation dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3478 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThere are no more old-style (non-tvbuffified) ONC RPC dissectors, so get
guy [Wed, 30 May 2001 06:01:02 +0000 (06:01 +0000)]
There are no more old-style (non-tvbuffified) ONC RPC dissectors, so get
rid of support for them, and remove the "_tvb" from the end of the names
of RPC type dissection routines.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3477 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoTvbuffified NFS dissector, from Mike Frisch, plus some registered-field
guy [Wed, 30 May 2001 04:40:27 +0000 (04:40 +0000)]
Tvbuffified NFS dissector, from Mike Frisch, plus some registered-field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3476 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a typo.
guy [Mon, 28 May 2001 20:18:08 +0000 (20:18 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3475 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoWe now might print four IP addresses on a protocol tree line, so make
guy [Mon, 28 May 2001 20:12:30 +0000 (20:12 +0000)]
We now might print four IP addresses on a protocol tree line, so make
"ip_to_str()" capable of producing up to four separate strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3474 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix the copyright notice to reflect the fact that Gerald holds the
guy [Sun, 27 May 2001 21:38:46 +0000 (21:38 +0000)]
Fix the copyright notice to reflect the fact that Gerald holds the
copyright on Ethereal as a whole.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3473 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoWe can't use a single static buffer for decrypted ICQ data - you might
guy [Sun, 27 May 2001 21:37:23 +0000 (21:37 +0000)]
We can't use a single static buffer for decrypted ICQ data - you might
have more than one decrypted ICQ packet visible at a time, as you might
have popped up additional single-packet windows for those packets.
Allocate the buffer for the decrypted data when you decrypt, and arrange
that it be freed when the tvbuff that refers to it is freed.

Fix the copyright notice to reflect the fact that Gerald holds the
copyright on Ethereal as a whole.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3472 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a comment, and update Gerald's e-mail address.
guy [Sun, 27 May 2001 21:34:05 +0000 (21:34 +0000)]
Fix a comment, and update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3471 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPlug a memory leak (we weren't freeing the "epan_dissect_t" pointed to
guy [Sun, 27 May 2001 21:33:16 +0000 (21:33 +0000)]
Plug a memory leak (we weren't freeing the "epan_dissect_t" pointed to
by the "edt" member of a "capture_file" structure if we were selecting a
new frame, we were just overwriting that pointer).

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3470 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDon't use END_OF_FRAME - or otherwise refer to "pi" - in tvbuffified
guy [Sun, 27 May 2001 09:15:14 +0000 (09:15 +0000)]
Don't use END_OF_FRAME - or otherwise refer to "pi" - in tvbuffified

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3469 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDon't use END_OF_FRAME in tvbuffified dissectors.
guy [Sun, 27 May 2001 08:45:51 +0000 (08:45 +0000)]
Don't use END_OF_FRAME in tvbuffified dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3468 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"END_OF_FRAME" should not be used in tvbuffified dissectors.
guy [Sun, 27 May 2001 08:09:49 +0000 (08:09 +0000)]
"END_OF_FRAME" should not be used in tvbuffified dissectors.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3467 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGive protocol tree windows a horizontal scrollbar - yes, sometimes
guy [Sun, 27 May 2001 07:50:28 +0000 (07:50 +0000)]
Give protocol tree windows a horizontal scrollbar - yes, sometimes
protocol tree lines can be long enough that you might want, or even
need, one (consider really long names for SNMP OIDs, for example).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3466 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall the LANE dissector through a handle.
guy [Sun, 27 May 2001 07:46:57 +0000 (07:46 +0000)]
Call the LANE dissector through a handle.

Create an ILMI dissector and call it through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3465 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall the H.261 dissector through a handle.
guy [Sun, 27 May 2001 07:37:46 +0000 (07:37 +0000)]
Call the H.261 dissector through a handle.

Set the reported length of the tvbuff we hand to the H.261 dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3464 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNo need to include "packet-q931.h" any more, as we're calling the Q.931
guy [Sun, 27 May 2001 07:28:00 +0000 (07:28 +0000)]
No need to include "packet-q931.h" any more, as we're calling the Q.931
dissector through a handle.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3463 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall the Q.931 dissector through a handle.
guy [Sun, 27 May 2001 07:27:21 +0000 (07:27 +0000)]
Call the Q.931 dissector through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3462 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThe Q.2931 dissector is only called through a handle, so it doesn't need
guy [Sun, 27 May 2001 07:18:08 +0000 (07:18 +0000)]
The Q.2931 dissector is only called through a handle, so it doesn't need
to check whether the protocol is enabled and doesn't need to set

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3461 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall the Q.2931 dissector through a handle.
guy [Sun, 27 May 2001 07:15:26 +0000 (07:15 +0000)]
Call the Q.2931 dissector through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3460 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall the GVRP dissector through a handle.
guy [Sun, 27 May 2001 07:07:34 +0000 (07:07 +0000)]
Call the GVRP dissector through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3459 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall the AFS dissector through a handle.
guy [Sun, 27 May 2001 05:00:17 +0000 (05:00 +0000)]
Call the AFS dissector through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3458 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall the SSCOP dissector through a handle. That lets us get rid of the
guy [Sun, 27 May 2001 04:50:51 +0000 (04:50 +0000)]
Call the SSCOP dissector through a handle.  That lets us get rid of the
CHECK_DISPLAY_AS_DATA call and code to set "pinfo->current_proto", as
"call_dissector()" does that for us.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3457 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIn the ICMPv6 and OSI CLNP dissectors, when calling the IPv6 or CLNP
guy [Sun, 27 May 2001 04:14:53 +0000 (04:14 +0000)]
In the ICMPv6 and OSI CLNP dissectors, when calling the IPv6 or CLNP
dissector to dissect the datagram inside an error report datagram, save
the current values of the source and destination addresses, and restore
them after the subdissector returns, so that all address columns in the
summary pane will reflect the error datagram, not the datagram that
provoked the error.

Set the Protocol and Info columns upon entry to the ICMPv6 dissector, so
that if we throw an exception they don't reflect the protocol above

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3456 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIn the IPv6 dissector, don't bother with the "CHECK_DISPLAY_AS_DATA()",
guy [Sun, 27 May 2001 02:16:32 +0000 (02:16 +0000)]
In the IPv6 dissector, don't bother with the "CHECK_DISPLAY_AS_DATA()",
as it's called only through a handle or a dissector table, and the code
that handles those calls does the check.

Also, set the Protocol and Info columns before fetching anything from
the packet, so they're set if we throw an exception.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3455 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRX and AFS dissectors tvbuffified, and bugs fixed, by Ronnie Sahlberg.
guy [Sun, 27 May 2001 01:48:25 +0000 (01:48 +0000)]
RX and AFS dissectors tvbuffified, and bugs fixed, by Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3454 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAUTH_DES support, from Mike Frisch.
guy [Fri, 25 May 2001 20:13:04 +0000 (20:13 +0000)]
AUTH_DES support, from Mike Frisch.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3453 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate Gerald's e-mail address.
guy [Fri, 25 May 2001 18:44:01 +0000 (18:44 +0000)]
Update Gerald's e-mail address.

Use "col_add_fstr()" to set the Info column, rather than "sprintf()"ing
to a buffer and using "col_add_str()".

Add a routine that dissects unknown types of IGMP messages, and use it
for all IGMP messages for which we don't have a dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3452 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix Gerald's e-mail address.
guy [Fri, 25 May 2001 16:19:31 +0000 (16:19 +0000)]
Fix Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3451 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoISUP support, from Martina Obermeier.
guy [Fri, 25 May 2001 16:17:45 +0000 (16:17 +0000)]
ISUP support, from Martina Obermeier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3450 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoWe always have to make one pass over the BOOTP options to see if the
guy [Fri, 25 May 2001 06:56:53 +0000 (06:56 +0000)]
We always have to make one pass over the BOOTP options to see if the
packet is BOOTP or DHCP; have "bootp_option()" take a flag indicating
whether it's the first pass or the second and, in the first pass, don't
put anything in the protocol tree - just return, through pointers, the
DHCP packet type and the vendor class ID.  On the second pass, don't
modify what those pointers point to, just use them as appropriate.

Make the vendor class ID pointer local to "dissect_bootp()", and have
"dissect_bootp()" do the first pass, set the Protocol and Info columns
appropriately if the packet is DHCP, and then, if a protocol tree is to
be built, make a second pass, handing "bootp_option()" the DHCP packet
type and vendor class ID we found.

If the vendor class ID is null, don't try to compare it with Intel's PXE
client indicator.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3449 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPut in limited support for some messages that appeared in the old
guy [Fri, 25 May 2001 06:47:02 +0000 (06:47 +0000)]
Put in limited support for some messages that appeared in the old
dissector and that appear in tcpdump's IGMP dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3448 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix to TCP reassembly code for retransmitted data, from Edgar Iglesias.
guy [Thu, 24 May 2001 23:07:41 +0000 (23:07 +0000)]
Fix to TCP reassembly code for retransmitted data, from Edgar Iglesias.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3447 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAppletalk Data Stream Interface (used by AFP-over-TCP) support, from
guy [Thu, 24 May 2001 20:25:25 +0000 (20:25 +0000)]
Appletalk Data Stream Interface (used by AFP-over-TCP) support, from
Randy McEoin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3446 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDHCP support for Intel PXEclient DHCP requests, from Joerg Mayer.
guy [Thu, 24 May 2001 19:21:15 +0000 (19:21 +0000)]
DHCP support for Intel PXEclient DHCP requests, from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3445 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMTP3 support, from Michael Tuexen.
guy [Thu, 24 May 2001 08:13:56 +0000 (08:13 +0000)]
MTP3 support, from Michael Tuexen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3444 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIf you call AC_MSG_CHECKING, you should always call AC_MSG_RESULT.
guy [Thu, 24 May 2001 04:04:42 +0000 (04:04 +0000)]
If you call AC_MSG_CHECKING, you should always call AC_MSG_RESULT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3443 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdated SSL tests, from Andy Hood.
guy [Wed, 23 May 2001 19:38:07 +0000 (19:38 +0000)]
Updated SSL tests, from Andy Hood.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3442 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIf you put an item into the protocol tree with "dissect_rpc_data_tvb()",
guy [Wed, 23 May 2001 19:29:45 +0000 (19:29 +0000)]
If you put an item into the protocol tree with "dissect_rpc_data_tvb()",
it must be FT_BYTES, not FT_STRING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3441 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIf you put an item into the protocol tree with "dissect_rpc_data()",
guy [Wed, 23 May 2001 19:13:37 +0000 (19:13 +0000)]
If you put an item into the protocol tree with "dissect_rpc_data()",
it must be FT_BYTES, not FT_STRING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3440 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIf you put an item into the protocol tree with "dissect_rpc_data_tvb()",
guy [Wed, 23 May 2001 19:06:55 +0000 (19:06 +0000)]
If you put an item into the protocol tree with "dissect_rpc_data_tvb()",
it must be FT_BYTES, not FT_STRING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3439 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of an extra colon on a field name, and display that field using
guy [Wed, 23 May 2001 18:52:54 +0000 (18:52 +0000)]
Get rid of an extra colon on a field name, and display that field using
that name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3438 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of extra colons, and fix up the display of default metrics, from
guy [Wed, 23 May 2001 18:44:59 +0000 (18:44 +0000)]
Get rid of extra colons, and fix up the display of default metrics, from
Jean-Christian Pennetier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3437 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd tree summary information similar to what's in packet-tcp.c.
gerald [Wed, 23 May 2001 03:33:59 +0000 (03:33 +0000)]
Add tree summary information similar to what's in packet-tcp.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3436 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoWin32: build text2pcap doco and package it.
gram [Tue, 22 May 2001 16:19:45 +0000 (16:19 +0000)]
Win32: build text2pcap doco and package it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3435 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAccording to the autoconf documentation, you're not supposed to use
guy [Tue, 22 May 2001 06:43:24 +0000 (06:43 +0000)]
According to the autoconf documentation, you're not supposed to use

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3434 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCleanups to the "--with-ssl" configuration option, and changes to add
guy [Tue, 22 May 2001 06:33:06 +0000 (06:33 +0000)]
Cleanups to the "--with-ssl" configuration option, and changes to add
compiler flags on Solaris with GCC to cope with X11 header file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3433 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a typo in the "product name", and fix the "internal name".
guy [Mon, 21 May 2001 11:01:56 +0000 (11:01 +0000)]
Fix a typo in the "product name", and fix the "internal name".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3432 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix to LDP prefix FEC dissection for IPv4, from Eran Mann.
guy [Mon, 21 May 2001 10:14:37 +0000 (10:14 +0000)]
Fix to LDP prefix FEC dissection for IPv4, from Eran Mann.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3431 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIf an RPC opaque datum isn't a string, don't use
guy [Mon, 21 May 2001 08:52:17 +0000 (08:52 +0000)]
If an RPC opaque datum isn't a string, don't use
"proto_tree_add_string_format()" to put in the protocol tree item for
the data, use "proto_tree_add_bytes_format()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3430 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd resource stuff for text2pcap.
guy [Mon, 21 May 2001 05:04:49 +0000 (05:04 +0000)]
Add resource stuff for text2pcap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3429 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoBuild text2pcap on Windows.
guy [Mon, 21 May 2001 03:17:14 +0000 (03:17 +0000)]
Build text2pcap on Windows.

Fix text2pcap.c so that it can be compiled with Microsoft Visual C++

protect some includes with #ifdefs, as not all the header files
in question exist in the MSVC++ build environment;

include <winsock.h> if we have it, to declare "ntohs()" and the

include "getopt.h" if we need it, to declare stuff for

include "config.h" if we have it, so we know whether the header
files in question exist or are needed;

rename "BYTE" to "READ_BYTE", as <winsock.h> defines BYTE as
well, and that definition causes a conflict;

get rid of references to "__FUNCTION__", as MSVC++ doesn't
define it (I suspect at least some UNIX compilers don't define
it, either).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3428 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix up a cast so that it properly sign-extends the server time zone;
guy [Sun, 20 May 2001 22:26:14 +0000 (22:26 +0000)]
Fix up a cast so that it properly sign-extends the server time zone;
from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3427 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRewritten IGMP dissector, from Ronnie Sahlberg.
guy [Sun, 20 May 2001 22:20:33 +0000 (22:20 +0000)]
Rewritten IGMP dissector, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3426 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd the text2pcap generated files to .cvsignore.
guy [Sun, 20 May 2001 22:06:04 +0000 (22:06 +0000)]
Add the text2pcap generated files to .cvsignore.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3425 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDeclare "yylex()" in "text2pcap.h", so that there's a prototype in scope
guy [Thu, 17 May 2001 00:11:37 +0000 (00:11 +0000)]
Declare "yylex()" in "text2pcap.h", so that there's a prototype in scope
when it's used by "text2pcap.c" - and so that the *same* prototype is in
scope when it's defined by "text2pcap-scanner.c".

Define "YY_NO_UNPUT" in "text2pcap.h", so we don't define "yyunput()" in
"text2pcap-scanner.c"; it's not used, so some compilers whine about it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3424 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDocumentation fix to generalize 'text2pcap -e' for all L3 packets instead of just IP.
ashokn [Wed, 16 May 2001 22:50:36 +0000 (22:50 +0000)]
Documentation fix to generalize 'text2pcap -e' for all L3 packets instead of just IP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3423 f5534014-38df-0310-8fa8-9805f1628bb7