obnox/wireshark/wip.git
14 years agoBump development version.
etxrab [Thu, 29 Oct 2009 06:15:52 +0000 (06:15 +0000)]
Bump development version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30750 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCheck if selected packet is already selected before doing any updates.
stig [Wed, 28 Oct 2009 22:17:18 +0000 (22:17 +0000)]
Check if selected packet is already selected before doing any updates.
This was originally added in r26803 for the old packet list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30749 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFlag errors with expert info.
martinm [Wed, 28 Oct 2009 19:00:41 +0000 (19:00 +0000)]
Flag errors with expert info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30748 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nemeth Marton: in an example of a valid (at least at the C language
guy [Wed, 28 Oct 2009 18:19:54 +0000 (18:19 +0000)]
From Nemeth Marton: in an example of a valid (at least at the C language
level) way to handle passing the result of strlen() to a routine
expecting a int-sized value, mark it as "OK", not "Compiler warning".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30747 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Remove check_col.
etxrab [Wed, 28 Oct 2009 06:18:05 +0000 (06:18 +0000)]
- Remove check_col.
- Make x2ap work.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30746 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMissed an #include...
etxrab [Wed, 28 Oct 2009 05:13:31 +0000 (05:13 +0000)]
Missed an #include...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30745 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate SCTP ppids, fix a faulty #define.
etxrab [Wed, 28 Oct 2009 05:09:32 +0000 (05:09 +0000)]
Update SCTP ppids, fix a faulty #define.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30744 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSimplify the download text as recommended by Ulf.
gerald [Tue, 27 Oct 2009 22:05:09 +0000 (22:05 +0000)]
Simplify the download text as recommended by Ulf.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30741 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of deprecated GTK functions.
etxrab [Tue, 27 Oct 2009 20:12:37 +0000 (20:12 +0000)]
Get rid of deprecated GTK functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30734 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSwitch back to normal versioning.
gerald [Tue, 27 Oct 2009 19:36:31 +0000 (19:36 +0000)]
Switch back to normal versioning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30733 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a missing file.
gerald [Tue, 27 Oct 2009 19:35:40 +0000 (19:35 +0000)]
Add a missing file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30732 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Fred Fierling:
etxrab [Tue, 27 Oct 2009 19:13:57 +0000 (19:13 +0000)]
From   Fred Fierling:
Fixes bugs in dissection of write attributes, read reporting configuration, and
configure reporting clusters in the ZigBee Cluster Library.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4113

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30731 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse correct default value in tick interval combo box.
stig [Tue, 27 Oct 2009 13:59:05 +0000 (13:59 +0000)]
Use correct default value in tick interval combo box.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30729 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoved an unneeded cast.
stig [Tue, 27 Oct 2009 09:58:57 +0000 (09:58 +0000)]
Removed an unneeded cast.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30728 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Francesco Fondelli:
etxrab [Tue, 27 Oct 2009 06:05:02 +0000 (06:05 +0000)]
From   Francesco Fondelli:
RSVP extensions for G.709 Optical Transport Networks Control, RFC 4328
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4148

With some changes from me:
-(readme.developer:" Furthermore, 'display' field must be ORed with 'BASE_RANGE_STRING' (e.g. BASE_DEC|BASE_RANGE_STRING)."
- Prefix headerfields with hf_
- Remove check_col

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30727 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Herbert Lischka:
etxrab [Tue, 27 Oct 2009 05:20:19 +0000 (05:20 +0000)]
From Herbert Lischka:
Minor changes to dissector packet-bacapp.c to solve some strange
views to ReadPropertyMultiple-Acknowledge frames.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4161

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30726 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Tue, 27 Oct 2009 05:11:52 +0000 (05:11 +0000)]
From Jakub Zawadzki:
Don't duplicate empty string in col_text

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30725 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBuild 1.3.1.
gerald [Tue, 27 Oct 2009 00:10:52 +0000 (00:10 +0000)]
Build 1.3.1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30724 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoReflect the current status of Windows pipes.
gerald [Tue, 27 Oct 2009 00:10:36 +0000 (00:10 +0000)]
Reflect the current status of Windows pipes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30723 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoNote in comments that the dct2000_file_externals_t structure is used for
guy [Mon, 26 Oct 2009 19:20:50 +0000 (19:20 +0000)]
Note in comments that the dct2000_file_externals_t structure is used for
more than just dumping, indicate what stuff is used for dumping, and
note that it probably shouldn't be used for that (one should not have to
have a Catapult 2000 input file in order to write a Catapult 2000 output
file).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30719 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate URL for LANalyzer file format.
guy [Mon, 26 Oct 2009 18:41:54 +0000 (18:41 +0000)]
Update URL for LANalyzer file format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30717 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a preference to control whether or not comment strings are scanned for oob LTE...
martinm [Mon, 26 Oct 2009 16:40:57 +0000 (16:40 +0000)]
Add a preference to control whether or not comment strings are scanned for oob LTE MAC messages. Scanning them is probably quite slow.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30713 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange a filter string for consistency.
martinm [Mon, 26 Oct 2009 16:39:46 +0000 (16:39 +0000)]
Change a filter string for consistency.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30712 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd support for displaying/filtering some LTE MAC out-of-band events.
martinm [Mon, 26 Oct 2009 15:39:00 +0000 (15:39 +0000)]
Add support for displaying/filtering some LTE MAC out-of-band events.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30711 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRelocationRequired incorrectly dissected.
etxrab [Mon, 26 Oct 2009 15:12:32 +0000 (15:12 +0000)]
RelocationRequired incorrectly dissected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30710 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to fix win64 buildbot. Both fgets() and gzgets() take an int for the length.
martinm [Mon, 26 Oct 2009 13:38:23 +0000 (13:38 +0000)]
Try to fix win64 buildbot.  Both fgets() and gzgets() take an int for the length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30709 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of capture.catapult_dct2000, move start time of capture into file_externals...
martinm [Mon, 26 Oct 2009 12:17:11 +0000 (12:17 +0000)]
Get rid of capture.catapult_dct2000, move start time of capture into file_externals instead.

Thanks Guy for helping to simplify this file!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30708 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGlobal variables considered harmful - we don't want to rule out two
guy [Mon, 26 Oct 2009 09:36:53 +0000 (09:36 +0000)]
Global variables considered harmful - we don't want to rule out two
threads reading from two different wtap_t's in different threads.

file_externals_table considered unnecessary - a wtap_t has a member
specifically intended to point to private data.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30707 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe stats_tree plugin deserves a version number other than "0.0".
stig [Mon, 26 Oct 2009 09:29:46 +0000 (09:29 +0000)]
The stats_tree plugin deserves a version number other than "0.0".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30706 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to parse unparsed token in accordance with fieldtype of all fileds with the same...
kukosa [Mon, 26 Oct 2009 09:06:45 +0000 (09:06 +0000)]
Try to parse unparsed token in accordance with fieldtype of all fileds with the same name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30705 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFormatting changes only.
martinm [Mon, 26 Oct 2009 07:57:38 +0000 (07:57 +0000)]
Formatting changes only.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30704 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jochen Bartl:
jake [Mon, 26 Oct 2009 07:00:15 +0000 (07:00 +0000)]
From Jochen Bartl:
This patch fixes the display filter for the prefix length of IPv6 external
route updates and the length calculation of the destination address in
IPv6 route updates.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30703 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Mon, 26 Oct 2009 05:55:07 +0000 (05:55 +0000)]
From Jakub Zawadzki:
Fix memleaks while creating kademlia hash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30702 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix:
etxrab [Mon, 26 Oct 2009 05:50:05 +0000 (05:50 +0000)]
Fix:
Error: Found prohibited APIs in catapult_dct2000.c: sprintf,strcpy

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30701 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd support for showing/filtering/resaving logged LTE strings.
martinm [Mon, 26 Oct 2009 00:04:27 +0000 (00:04 +0000)]
Add support for showing/filtering/resaving logged LTE strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30700 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLabel a short BSR as "short"
martinm [Sun, 25 Oct 2009 23:03:11 +0000 (23:03 +0000)]
Label a short BSR as "short"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30699 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jim Young via bug 4162:
gerald [Sun, 25 Oct 2009 20:18:24 +0000 (20:18 +0000)]
From Jim Young via bug 4162:

This patch limits the number of fractional digits used to calculate the
fractional component of editcap's -t and -w options.

Specifically this patch truncates the fractional component (if any) of the -t
and -w options to 6 and 9 respectively.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30698 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDecode DSL Forum TR-101 PPPoE tags.
rbalint [Sun, 25 Oct 2009 20:11:47 +0000 (20:11 +0000)]
Decode DSL Forum TR-101 PPPoE tags.
This fixes bug 3113.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30697 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore fixes from John T. Haller via bug 4158, with some cleanups from me.
gerald [Sun, 25 Oct 2009 19:33:36 +0000 (19:33 +0000)]
More fixes from John T. Haller via bug 4158, with some cleanups from me.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30696 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOption 2 (Time Offset) is signed.
gerald [Sun, 25 Oct 2009 17:05:08 +0000 (17:05 +0000)]
Option 2 (Time Offset) is signed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30695 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago[Automatic manuf and enterprise-numbers update for 2009-10-25]
gerald [Sun, 25 Oct 2009 15:03:39 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-10-25]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30692 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Sun, 25 Oct 2009 11:43:30 +0000 (11:43 +0000)]
From Jakub Zawadzki:
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30691 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Marton Nemeth via bug 4163:
stig [Sun, 25 Oct 2009 10:45:15 +0000 (10:45 +0000)]
From Marton Nemeth via bug 4163:
Add support for input URBs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30690 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove an obsolete comment
jmayer [Sun, 25 Oct 2009 10:33:10 +0000 (10:33 +0000)]
Remove an obsolete comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30689 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gerasimos Dimitriadis:
etxrab [Sun, 25 Oct 2009 10:14:47 +0000 (10:14 +0000)]
From Gerasimos Dimitriadis:
DTAP: MAP component of indefinite length within Facility IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4157

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30688 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse pango 1.26
etxrab [Sun, 25 Oct 2009 09:59:40 +0000 (09:59 +0000)]
Use pango 1.26

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30687 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoNo point passing a global pointer as a function argument.
stig [Sat, 24 Oct 2009 16:30:11 +0000 (16:30 +0000)]
No point passing a global pointer as a function argument.
Made check_ndmp_rm() and check_ndmp_hdr() static.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30686 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki via bug 3764:
stig [Sat, 24 Oct 2009 15:51:10 +0000 (15:51 +0000)]
From Jakub Zawadzki via bug 3764:
Don't call strcmp() when pointers are the same.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30685 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Robert Simac via bug 3470:
stig [Sat, 24 Oct 2009 15:40:35 +0000 (15:40 +0000)]
From Robert Simac via bug 3470:
Add the missing ndmp v4 messages, namely the:
 NDMP_CONFIG_GET_EXT_LIST
 NDMP_CONFIG_SET_EXT_LIST

This may serve as the 1st step into actual extensions (Snapvault etc)
dissector implementation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30684 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLoad lua scripts from subdirectories in the plugins folders.
stig [Sat, 24 Oct 2009 13:36:16 +0000 (13:36 +0000)]
Load lua scripts from subdirectories in the plugins folders.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30683 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mithun Roy:
jake [Sat, 24 Oct 2009 11:19:23 +0000 (11:19 +0000)]
From Mithun Roy:
The primary header in bundle protocol contains some offset values(destination
scheme offset, destination ssp offset, source scheme offset, source ssp offset,
etc). These are the offsets within the dictionary if the length of the
dictionary length is greater than 0. But if the dictionary length is 0, then
these offset refer to node number and service number respectively(according to
compressed bundle header encoding). For example if destination scheme offset is
2 and the destination ssp offset is 1, then the destination
EID(<node_number>.<service_number>) is 2.1.

Currently the dtn dissector will consider these offsets to be actual offsets in
the dictionary even if the dictionary length is 0. So the values for the
EID's(destination, source, report, custodian) and their schemes are junk
values. For example if the destination scheme offset is 2 and the destination
ssp offset is 1 and the dictionary length is 0(which means the dictionary is
empty), then the destination scheme is 2 bytes after the beginning of the
metadata block(field after dictionary) and destination is 1 byte after the
beginning of the metadata block.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30682 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd updates from bug 4158.
gerald [Fri, 23 Oct 2009 21:38:38 +0000 (21:38 +0000)]
Add updates from bug 4158.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30681 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a comment about using memcpy for scrubbing.
gerald [Fri, 23 Oct 2009 21:07:28 +0000 (21:07 +0000)]
Add a comment about using memcpy for scrubbing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30680 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded init_wslua.h
stig [Fri, 23 Oct 2009 18:00:57 +0000 (18:00 +0000)]
Added init_wslua.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30676 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLoad lua scripts in the plugins directory, both global and personal.
stig [Fri, 23 Oct 2009 17:52:18 +0000 (17:52 +0000)]
Load lua scripts in the plugins directory, both global and personal.
List loaded lua scripts in Help->About->Plugins.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30675 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix building debian-package target, broken by r28784.
jake [Fri, 23 Oct 2009 16:48:23 +0000 (16:48 +0000)]
Fix building debian-package target, broken by r28784.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30674 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodissect_udp_bundle(): check if dissect_payload_header() or
morriss [Fri, 23 Oct 2009 15:55:39 +0000 (15:55 +0000)]
dissect_udp_bundle(): check if dissect_payload_header() or
display_metadata_block() return 0 (meaning they failed to decode something and
the offset was not incremented) rather than checking if the resulting offset
is 0.

This fixes the infinite loop reported in:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4156

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30672 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoForgot to remove IA5_7BIT_decode(unsigned char * dest, const unsigned char* src,...
etxrab [Fri, 23 Oct 2009 05:32:15 +0000 (05:32 +0000)]
Forgot to remove IA5_7BIT_decode(unsigned char * dest, const unsigned char* src, int len);

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30671 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gerasimos Dimitriadis:
etxrab [Fri, 23 Oct 2009 02:12:39 +0000 (02:12 +0000)]
From Gerasimos Dimitriadis:
DTAP: Decoding of subaddress information.
sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4150

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30670 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove IA5_7BIT_decode to strutil.c
etxrab [Fri, 23 Oct 2009 01:56:09 +0000 (01:56 +0000)]
Move IA5_7BIT_decode to strutil.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30669 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake the new packet list the default on Win64.
gerald [Fri, 23 Oct 2009 00:16:34 +0000 (00:16 +0000)]
Make the new packet list the default on Win64.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30668 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Lars Ruoff:
jake [Thu, 22 Oct 2009 19:40:15 +0000 (19:40 +0000)]
From Lars Ruoff:
Do not make dialog windows transient to the Wireshark top level window on
WIN32, since this causes some strange behaviour on Windows.
See http://www.wireshark.org/lists/wireshark-dev/200909/msg00184.html

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30667 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExpert error if (non-padded) PDU is shorter than reported.
martinm [Thu, 22 Oct 2009 17:22:27 +0000 (17:22 +0000)]
Expert error if (non-padded) PDU is shorter than reported.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30666 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix the WpdPack version on Win64.
gerald [Thu, 22 Oct 2009 17:00:26 +0000 (17:00 +0000)]
Fix the WpdPack version on Win64.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30665 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore long BSR fixes.
martinm [Thu, 22 Oct 2009 11:45:40 +0000 (11:45 +0000)]
More long BSR fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30664 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix issues with long BSR format, and attach expert info for non-zero RAR TA to correc...
martinm [Thu, 22 Oct 2009 10:31:13 +0000 (10:31 +0000)]
Fix issues with long BSR format, and attach expert info for non-zero RAR TA to correct item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30663 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Greg Schwendimann:
jake [Thu, 22 Oct 2009 07:10:05 +0000 (07:10 +0000)]
From Greg Schwendimann:
The 802.3at Power Via MDI TLV dissector is incomplete as it does not decode the
last three bytes.  I have attached a patch that decodes the type/source/priority,
PD requested power value, and PSE allocated power value fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30662 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gerasimos Dimitriadis:
etxrab [Thu, 22 Oct 2009 05:28:53 +0000 (05:28 +0000)]
From Gerasimos Dimitriadis:
DTAP: Progress description depends on coding standard.
Changed to export value strings trough .h file
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4146

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30661 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove non-ASCII characters
morriss [Wed, 21 Oct 2009 12:56:28 +0000 (12:56 +0000)]
Remove non-ASCII characters

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30656 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gerasimos Dimitriadis:
etxrab [Wed, 21 Oct 2009 09:38:51 +0000 (09:38 +0000)]
From Gerasimos Dimitriadis:
DTAP: Call state depends on coding standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4145

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30655 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Joe Eykholt:
jake [Wed, 21 Oct 2009 08:01:35 +0000 (08:01 +0000)]
From Joe Eykholt:
The Fibre-Channel Extended Link Service request REC (Read Exchange Concise)
is used in error recovery.  It is currently identified as REC but not completely
dissected (the payload is shown as data).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30654 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse 2.22.2-1
etxrab [Wed, 21 Oct 2009 06:01:36 +0000 (06:01 +0000)]
Use 2.22.2-1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30653 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate WinPcap and the developer's pack to 4.1.1.
gerald [Wed, 21 Oct 2009 03:13:42 +0000 (03:13 +0000)]
Update WinPcap and the developer's pack to 4.1.1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30652 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago... and emem_init isn't (it is called directly by reassemble_test).
morriss [Wed, 21 Oct 2009 00:12:36 +0000 (00:12 +0000)]
... and emem_init isn't (it is called directly by reassemble_test).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30651 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoep_init_chunk() and se_init_chunk() are static.
guy [Tue, 20 Oct 2009 23:50:31 +0000 (23:50 +0000)]
ep_init_chunk() and se_init_chunk() are static.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30650 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agos/#if HAVE_KERBEROS/#ifdef HAVE_KERBEROS/
morriss [Tue, 20 Oct 2009 20:26:51 +0000 (20:26 +0000)]
s/#if HAVE_KERBEROS/#ifdef HAVE_KERBEROS/

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30649 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTake a stab at adding a section on environment variables that affect *shark's behavio...
morriss [Tue, 20 Oct 2009 20:14:23 +0000 (20:14 +0000)]
Take a stab at adding a section on environment variables that affect *shark's behavior.  So far, all the emem variables are included.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30648 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix broken link.
guy [Tue, 20 Oct 2009 18:17:32 +0000 (18:17 +0000)]
Fix broken link.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30647 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd emem_init() which initializes both the ep_ and se_ allocators; have all
morriss [Tue, 20 Oct 2009 17:43:05 +0000 (17:43 +0000)]
Add emem_init() which initializes both the ep_ and se_ allocators; have all
callers use that instead of initializing each allocator individually.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30646 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake sure no one calls PROTO_ITEM_SET_*(proto_tree_add_*) by forcing a compile error...
morriss [Tue, 20 Oct 2009 17:39:22 +0000 (17:39 +0000)]
Make sure no one calls PROTO_ITEM_SET_*(proto_tree_add_*) by forcing a compile error if they do.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30645 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't call xx_init_chunk() in ep_free_all() and se_free_all() if we're not
morriss [Tue, 20 Oct 2009 17:16:40 +0000 (17:16 +0000)]
Don't call xx_init_chunk() in ep_free_all() and se_free_all() if we're not
using chunks.  With this change, xx_init_chunk() are only called once at
startup (as their comments imply).

Instead, set free_list to NULL in emem_free_all() (if we're not using chunks).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30644 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate the Windows requirements section.
gerald [Tue, 20 Oct 2009 16:48:52 +0000 (16:48 +0000)]
Update the Windows requirements section.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30642 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAnother, more sensible, attempt to fix the Win64 build.
morriss [Tue, 20 Oct 2009 16:40:00 +0000 (16:40 +0000)]
Another, more sensible, attempt to fix the Win64 build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30641 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate the WinPcap installer to 4.1. The WinPcap installer now enables
gerald [Tue, 20 Oct 2009 16:22:14 +0000 (16:22 +0000)]
Update the WinPcap installer to 4.1. The WinPcap installer now enables
NPF at startp, so remove the checkbox and associated code from the
Wireshark installer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30640 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet a mem_chunk to NULL after we destroy it. This should fix the Solaris
gerald [Tue, 20 Oct 2009 15:43:40 +0000 (15:43 +0000)]
Set a mem_chunk to NULL after we destroy it. This should fix the Solaris
buildbot test failures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30639 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInitialize se_ memory, too (since it is used by the reassembly code). Reindent a...
morriss [Tue, 20 Oct 2009 15:07:22 +0000 (15:07 +0000)]
Initialize se_ memory, too (since it is used by the reassembly code).  Reindent a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30638 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gerasimos Dimitriadis:
etxrab [Tue, 20 Oct 2009 14:42:58 +0000 (14:42 +0000)]
From Gerasimos Dimitriadis:
DTAP: Expert info warning when BCD number malformed
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4143

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30637 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to get it compiling on Win64
morriss [Tue, 20 Oct 2009 14:12:41 +0000 (14:12 +0000)]
Try to get it compiling on Win64

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30636 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't call PROTO_ITEM_SET_GENERATED(proto_tree_add[...]): that will end up adding...
morriss [Tue, 20 Oct 2009 14:03:00 +0000 (14:03 +0000)]
Don't call PROTO_ITEM_SET_GENERATED(proto_tree_add[...]): that will end up adding the item to the tree multiple times.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30635 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
stig [Tue, 20 Oct 2009 10:20:14 +0000 (10:20 +0000)]
From Jakub Zawadzki:
Make it compile without kerberos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30634 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExtern declare hf_nt_cs_len and hf_nt_cs_size.
stig [Tue, 20 Oct 2009 10:03:55 +0000 (10:03 +0000)]
Extern declare hf_nt_cs_len and hf_nt_cs_size.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30633 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoved some redundant prototypes and some shadowed variables.
stig [Tue, 20 Oct 2009 09:31:07 +0000 (09:31 +0000)]
Removed some redundant prototypes and some shadowed variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30632 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Matthieu Patou
sahlberg [Tue, 20 Oct 2009 08:44:26 +0000 (08:44 +0000)]
From Matthieu Patou

schannel decryption

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30631 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoved some unused prototypes.
stig [Tue, 20 Oct 2009 08:27:25 +0000 (08:27 +0000)]
Removed some unused prototypes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30630 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix higlight the correct hex value and add a value_string.
etxrab [Tue, 20 Oct 2009 07:42:27 +0000 (07:42 +0000)]
Fix higlight the correct hex value and add a value_string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30629 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gerasimos Dimitriadis:
etxrab [Tue, 20 Oct 2009 07:33:01 +0000 (07:33 +0000)]
From Gerasimos Dimitriadis:
DTAP: Various enhancements.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4142

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30628 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdated decoding of GMM Cause to V8.6.0, i.e. added cause code 0x19 - "Not authorized...
etxrab [Tue, 20 Oct 2009 03:13:56 +0000 (03:13 +0000)]
Updated decoding of GMM Cause to V8.6.0, i.e. added cause code 0x19 - "Not authorized for this CSG". Changed to use a range_string.
Based on
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4132

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30627 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd packet-omron-fins.c
jmayer [Tue, 20 Oct 2009 00:44:08 +0000 (00:44 +0000)]
Add packet-omron-fins.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30626 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Matt Watchinski: OMRON-FINS dissector
wmeier [Tue, 20 Oct 2009 00:12:09 +0000 (00:12 +0000)]
From Matt Watchinski: OMRON-FINS dissector
(with some restructuring and cleanup by me).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3226

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30625 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140 :
morriss [Mon, 19 Oct 2009 22:31:08 +0000 (22:31 +0000)]
From Jakub Zawadzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140 :

There is emem_header_t struct, so IMHO is better to use struct instead of
global variables.

Split emem_alloc() into two functions: emem_alloc_chunk and emem_alloc_glib.
Current allocator is available in emem_header_t.memory_alloc

It should be easier to develop new memory allocator and maintain current.
It might also give some speedup (we don't need to check mem->debug_use_chunks
every time :)

From me:

Initialize emem_header_t.trees.  Some indentation cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30624 f5534014-38df-0310-8fa8-9805f1628bb7