obnox/wireshark/wip.git
19 years agoFix "packet-netbios.h" to match the new "packet-netbios.c", so that it
guy [Fri, 10 Nov 2000 21:09:49 +0000 (21:09 +0000)]
Fix "packet-netbios.h" to match the new "packet-netbios.c", so that it
compiles.

Doing so reveals that the NBIPX dissector needs to be fixed, as it calls
routines in "packet-netbios.c" whose calling sequence changed; doing so
involves tvbuffifying it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2602 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agotvbuffification by Jeff Foster.
gram [Fri, 10 Nov 2000 15:44:11 +0000 (15:44 +0000)]
tvbuffification by Jeff Foster.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2601 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't use "pi" in the TFTP dissector, now that it's a new-style
guy [Fri, 10 Nov 2000 09:22:46 +0000 (09:22 +0000)]
Don't use "pi" in the TFTP dissector, now that it's a new-style
dissector; use "pinfo" instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2600 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTvbuffify the TFTP dissector, and make heavier use of registered fields
guy [Fri, 10 Nov 2000 09:17:10 +0000 (09:17 +0000)]
Tvbuffify the TFTP dissector, and make heavier use of registered fields
and "value_string" tables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2599 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAllow "tvb_find_guint8()", "tvb_pbrk_guint8()", and "tvb_strnlen()" to
guy [Fri, 10 Nov 2000 09:15:57 +0000 (09:15 +0000)]
Allow "tvb_find_guint8()", "tvb_pbrk_guint8()", and "tvb_strnlen()" to
take -1 as a "maxlength" value, meaning "to the end of the tvbuff".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2598 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTvbuffify the FTP and POP dissectors.
guy [Fri, 10 Nov 2000 08:02:34 +0000 (08:02 +0000)]
Tvbuffify the FTP and POP dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2597 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoYet Another .cvsignore file.
guy [Fri, 10 Nov 2000 06:53:14 +0000 (06:53 +0000)]
Yet Another .cvsignore file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2596 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTvbuffify the SAP and SDP dissectors.
guy [Fri, 10 Nov 2000 06:50:37 +0000 (06:50 +0000)]
Tvbuffify the SAP and SDP dissectors.

Add "tvb_find_line_end_unquoted()" for the benefit of the SDP dissector;
get rid of "find_line_end_unquoted()" as nobody uses it any more.

Add "tvb_pbrk_guint8()" for the benefit of
"tvb_find_line_end_unquoted()"; it searches for any of a number of
characters, unlike "tvb_find_guint8()" which searches for only one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2595 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMGCP updates from Ed Warnicke.
guy [Fri, 10 Nov 2000 04:58:29 +0000 (04:58 +0000)]
MGCP updates from Ed Warnicke.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2594 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a "proto_tree_add_text()" call.
guy [Thu, 9 Nov 2000 21:57:35 +0000 (21:57 +0000)]
Fix a "proto_tree_add_text()" call.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2593 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosupport match-prefix and use-prefix decoding for router renumbering protocol
itojun [Thu, 9 Nov 2000 16:39:59 +0000 (16:39 +0000)]
support match-prefix and use-prefix decoding for router renumbering protocol

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2592 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agocorrect IPv6 router renumbering dissector.
itojun [Thu, 9 Nov 2000 14:09:41 +0000 (14:09 +0000)]
correct IPv6 router renumbering dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2591 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTvbuffify the HTTP, NNTP, RSH, RTSP, and Telnet dissectors.
guy [Thu, 9 Nov 2000 10:56:33 +0000 (10:56 +0000)]
Tvbuffify the HTTP, NNTP, RSH, RTSP, and Telnet dissectors.

Add "tvb_find_line_end()", to find a CR and/or LF-terminated line in a
tvbuff and return its length and the offset of the character after the
line end, for the use of those dissectors.

Add "tvb_strncaseeql()", which is like "tvb_strneql()" except that it
does a case-insensitive comparison.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2590 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "%u", not "%d", to print unsigned integral quantities.
guy [Thu, 9 Nov 2000 10:50:59 +0000 (10:50 +0000)]
Use "%u", not "%d", to print unsigned integral quantities.

The GIOP reply status is 4 bytes long, not 1 byte long.

Dissect the reply body for exceptions; the GIOP dissector used to do
that.

Add to the Info column the stuff that the GIOP dissector used to add
(request ID, etc.).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2589 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd MGCP dissector plugin from Ed Warnicke <hagbard@physics.rutgers.edu>.
gram [Thu, 9 Nov 2000 10:04:48 +0000 (10:04 +0000)]
Add MGCP dissector plugin from Ed Warnicke <hagbard@physics.rutgers.edu>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2588 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf the packet doesn't have at least GIOP_HEADER_SIZE worth of data
guy [Thu, 9 Nov 2000 09:15:40 +0000 (09:15 +0000)]
If the packet doesn't have at least GIOP_HEADER_SIZE worth of data
available, don't try to create a tvbuff for the GIOP header - that'll
throw an exception before we even get to look at the packet to see if
it's a GIOP packet.  Instead, just return FALSE, as we don't have enough
data to determine whether it's a GIOP packet or not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2587 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove a "putchar('\n')" that caused an extra newline to be printed after
guy [Thu, 9 Nov 2000 07:29:59 +0000 (07:29 +0000)]
Move a "putchar('\n')" that caused an extra newline to be printed after
the protocol tree was printed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2586 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNew EIGRP dissector, from Paul Ionescu.
guy [Thu, 9 Nov 2000 05:16:19 +0000 (05:16 +0000)]
New EIGRP dissector, from Paul Ionescu.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2585 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSupport for embedded newlines in SDP fields, from Robert Tsai.
guy [Thu, 9 Nov 2000 02:42:33 +0000 (02:42 +0000)]
Support for embedded newlines in SDP fields, from Robert Tsai.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2584 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNever hand a "char" or a "gchar" to any of the ctype.h macros; "char"
guy [Wed, 8 Nov 2000 22:18:04 +0000 (22:18 +0000)]
Never hand a "char" or a "gchar" to any of the ctype.h macros; "char"
and "gchar" may be (and probably are) signed, meaning that if the
character has the 8th bit set (e.g., accented letters in ISO 8859/1),
they will get sign-extended when handed to an "is*" macro, and will thus
give bogus answers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2583 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNote that the current CVS version of libpcap from tcpdump.org doesn't
guy [Wed, 8 Nov 2000 21:33:33 +0000 (21:33 +0000)]
Note that the current CVS version of libpcap from tcpdump.org doesn't
have, doesn't require, an "install-incl" Make target.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2582 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of carriage returns; Windows compilers don't require them, and
guy [Wed, 8 Nov 2000 21:27:27 +0000 (21:27 +0000)]
Get rid of carriage returns; Windows compilers don't require them, and
some UNIX compilers don't like them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2581 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of carriage returns; Windows compilers don't require them, and
guy [Wed, 8 Nov 2000 19:57:39 +0000 (19:57 +0000)]
Get rid of carriage returns; Windows compilers don't require them, and
some UNIX compilers don't like them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2580 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix type checking for the "i386" platform.
gerald [Wed, 8 Nov 2000 03:54:12 +0000 (03:54 +0000)]
Fix type checking for the "i386" platform.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2579 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChange zing.org addresses to ethereal.com.
gerald [Tue, 7 Nov 2000 19:54:53 +0000 (19:54 +0000)]
Change zing.org addresses to ethereal.com.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2578 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGIOP 1.2 support and other GIOP enhancements, from Craig Rodrigues.
guy [Tue, 7 Nov 2000 07:46:22 +0000 (07:46 +0000)]
GIOP 1.2 support and other GIOP enhancements, from Craig Rodrigues.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2577 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoforget to commit change w/ afs headers
nneul [Mon, 6 Nov 2000 14:14:01 +0000 (14:14 +0000)]
forget to commit change w/ afs headers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2576 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdate to reflect the new style for plugin dissectors.
guy [Mon, 6 Nov 2000 09:56:10 +0000 (09:56 +0000)]
Update to reflect the new style for plugin dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2575 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a typo.
guy [Mon, 6 Nov 2000 09:49:43 +0000 (09:49 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2574 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIn Tethereal, when printing summary lines, print the fields specified in
guy [Mon, 6 Nov 2000 09:28:43 +0000 (09:28 +0000)]
In Tethereal, when printing summary lines, print the fields specified in
the preferences file, don't just print a wired-in list of fields.
Always print the time stamp.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2573 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"plugin_reg_handoff()" is a symbol in the plugin that Ethereal has to
guy [Mon, 6 Nov 2000 08:44:05 +0000 (08:44 +0000)]
"plugin_reg_handoff()" is a symbol in the plugin that Ethereal has to
access, so it must be declared with DLLEXPORT so that it's exported on
Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2572 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAIM/OSCAR dissector, from Ralf Holzer.
guy [Mon, 6 Nov 2000 00:07:04 +0000 (00:07 +0000)]
AIM/OSCAR dissector, from Ralf Holzer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2571 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAIM/OSCAR dissector, from Ralf Holzer.
guy [Sun, 5 Nov 2000 23:45:59 +0000 (23:45 +0000)]
AIM/OSCAR dissector, from Ralf Holzer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2570 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAllow a plugin to specify several underlying protocols (i.e. tcp and udp).
oabad [Sun, 5 Nov 2000 09:40:18 +0000 (09:40 +0000)]
Allow a plugin to specify several underlying protocols (i.e. tcp and udp).

The protocol constant definition in the plugin must be :
DLLEXPORT const gchar protocol[] = "tcp udp";

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2569 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the RTCP, RTP, WSP, and WTP dissectors check whether their
guy [Sun, 5 Nov 2000 09:30:11 +0000 (09:30 +0000)]
Make the RTCP, RTP, WSP, and WTP dissectors check whether their
protocols have been disabled.

Get rid of the "no tvbuff" dissectors for WSP and WTP - they're not used
(and shouldn't ever be used).

Make "dissect_wtp()" static, as it's not used outside "packet-wtp.c".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2568 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAllow a plugin to specify several underlying protocols (i.e. tcp and udp).
oabad [Sun, 5 Nov 2000 09:26:47 +0000 (09:26 +0000)]
Allow a plugin to specify several underlying protocols (i.e. tcp and udp).

The protocol constant definition in the plugin must be :
DLLEXPORT const gchar protocol[] = "tcp udp";

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2567 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNew-style plugins don't require a "desc" variable.
guy [Sun, 5 Nov 2000 09:09:29 +0000 (09:09 +0000)]
New-style plugins don't require a "desc" variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2566 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAllow plugins to have, instead of "protocol" and "filter_string"
guy [Sun, 5 Nov 2000 09:05:00 +0000 (09:05 +0000)]
Allow plugins to have, instead of "protocol" and "filter_string"
variables and a "dissector" routine, a "plugin_reg_handoff()" routine,
which will act just like the "reg_handoff()" routine of a non-plugin
dissector, registering the dissector with handoff tables.

This lets them plug into both TCP and UDP, or plug into protocols other
than TCP or UDP.

Those new-style plugin are enabled and disabled using the standard
"Edit->Protocols" mechanism (and thus should use
"OLD_CHECK_DISPLAY_AS_DATA()" or "CHECK_DISPLAY_AS_DATA()"); they don't
show up in the list of plugins, aren't enabled or disabled from that
list, and, as they don't have a filter, can't have the filter changed
from that list - instead, they should register preferences for port
numbers and the like if they should be configurable to use different
ports.

Make the Gryphon protocol a new-style plugin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2565 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPatch from Craig Rodrigues to fix a call to "check_col()".
guy [Sun, 5 Nov 2000 07:14:40 +0000 (07:14 +0000)]
Patch from Craig Rodrigues to fix a call to "check_col()".

Fix a typo in a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2564 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFixing packet-ftp so we can search on ftp-data! To make it intuitive, the
sharpe [Sun, 5 Nov 2000 05:49:02 +0000 (05:49 +0000)]
Fixing packet-ftp so we can search on ftp-data! To make it intuitive, the
protocol column lists the protocol as FTP-DATA.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2563 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSIP dissector, from Heikki Vatiainen.
guy [Sat, 4 Nov 2000 07:50:47 +0000 (07:50 +0000)]
SIP dissector, from Heikki Vatiainen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2562 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix the beginning comment to give the right file name.
guy [Sat, 4 Nov 2000 07:39:16 +0000 (07:39 +0000)]
Fix the beginning comment to give the right file name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2561 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMicrosoft Visual C++, unlike GCC, doesn't like it if you have no
guy [Sat, 4 Nov 2000 07:38:19 +0000 (07:38 +0000)]
Microsoft Visual C++, unlike GCC, doesn't like it if you have no
statements whatsoever in a "case" or "default" clause; add a "break"
statement to keep it happy.  (Other compilers may also be less forgiving
than GCC.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2560 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoOne of the header files included by "packet-wsp.c", or one of the header
guy [Sat, 4 Nov 2000 07:35:17 +0000 (07:35 +0000)]
One of the header files included by "packet-wsp.c", or one of the header
files one of those header files includes (compute transitive closure
here), appears to define DELETE, on Windows, in a fashion that causes
"packet-wsp.c" not to compile.  Undefine DELETE before using it as a
name for an enum value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2559 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWAP support, from Neil Hunter.
guy [Sat, 4 Nov 2000 03:30:41 +0000 (03:30 +0000)]
WAP support, from Neil Hunter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2558 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosmall fixes
nneul [Fri, 3 Nov 2000 22:38:07 +0000 (22:38 +0000)]
small fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2557 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomore decoding of afs bos traffic
nneul [Fri, 3 Nov 2000 22:11:36 +0000 (22:11 +0000)]
more decoding of afs bos traffic

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2556 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofinished up afs fs requests, more macros implemented
nneul [Fri, 3 Nov 2000 19:27:11 +0000 (19:27 +0000)]
finished up afs fs requests, more macros implemented

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2555 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofinished up structure for fs replies, though macros still need implemented
nneul [Fri, 3 Nov 2000 18:37:24 +0000 (18:37 +0000)]
finished up structure for fs replies, though macros still need implemented

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2554 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSplit into a separate files. Started adding a bunch more decoding of
nneul [Fri, 3 Nov 2000 17:32:51 +0000 (17:32 +0000)]
Split into a separate files. Started adding a bunch more decoding of
structures. Renamed decoding macros to get them more consistent and in
line with AFS data types wherever possible.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2553 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCorrected BASE_OCT support for display formats. Note - it probably isn't
nneul [Fri, 3 Nov 2000 17:26:47 +0000 (17:26 +0000)]
Corrected BASE_OCT support for display formats. Note - it probably isn't
correct to display ints.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2552 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadded backup,rmtsys,update opcodes
nneul [Thu, 2 Nov 2000 18:45:15 +0000 (18:45 +0000)]
added backup,rmtsys,update opcodes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2551 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomore cleanup of opcodes
nneul [Thu, 2 Nov 2000 16:59:29 +0000 (16:59 +0000)]
more cleanup of opcodes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2550 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadded entry, fixed couple of typos
nneul [Thu, 2 Nov 2000 16:15:53 +0000 (16:15 +0000)]
added entry, fixed couple of typos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2549 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdates from Jeff Foster.
gram [Thu, 2 Nov 2000 15:47:16 +0000 (15:47 +0000)]
Updates from Jeff Foster.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2548 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a fourth choice of time format in the packet list display, which
guy [Wed, 1 Nov 2000 08:31:36 +0000 (08:31 +0000)]
Add a fourth choice of time format in the packet list display, which
shows the date (in YYYY-MM-DD format) as well as the time of day when
the packet arrived.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2547 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoInstead of failing if we can't find a netmask for the interface on which
guy [Wed, 1 Nov 2000 07:38:54 +0000 (07:38 +0000)]
Instead of failing if we can't find a netmask for the interface on which
we're capturing, just use a netmask of 0, and warn the user in Tethereal
(doing it in Ethereal would be more disruptive, and doing so only once
per interface in a session is a bit of work, as, in an "Update list of
packets in real time" capture the child process would have to tell the
parent that it couldn't get the netmask).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2546 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdates from Steve Limkemann.
guy [Wed, 1 Nov 2000 00:16:18 +0000 (00:16 +0000)]
Updates from Steve Limkemann.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2545 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoA small fix to display SAM Response User Unknown responses correctly.
sharpe [Tue, 31 Oct 2000 09:41:07 +0000 (09:41 +0000)]
A small fix to display SAM Response User Unknown responses correctly.

The Cmd variable was being clamped below that value ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2544 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of a statement that should've been deleted when we started using
guy [Tue, 31 Oct 2000 08:15:26 +0000 (08:15 +0000)]
Get rid of a statement that should've been deleted when we started using
"compute_timestamp_diff()" to compute the difference betwen time stamps
but that wasn't deleted, causing the time difference between a frame and
the previous frame to be computed incorrectly in Tethereal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2543 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove declaration of wsaData (for Win32) out of HAVE_LIBPCAP #ifdef block.
gram [Fri, 27 Oct 2000 17:19:23 +0000 (17:19 +0000)]
Move declaration of wsaData (for Win32) out of HAVE_LIBPCAP #ifdef block.
It's needed for both capture and non-capture variants of Win32 builds.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2542 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove to 0.8.13
gram [Fri, 27 Oct 2000 02:24:08 +0000 (02:24 +0000)]
Move to 0.8.13

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2540 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove to version 0.8.13.
gram [Fri, 27 Oct 2000 02:22:08 +0000 (02:22 +0000)]
Move to version 0.8.13.
Mention IGRP dissector in NEWS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2539 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdded some autoconf- and automake-generated files to .cvsignore.
gram [Fri, 27 Oct 2000 02:11:09 +0000 (02:11 +0000)]
Added some autoconf- and automake-generated files to .cvsignore.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2538 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake new version 0.8.13, not 0.9.0.
gram [Thu, 26 Oct 2000 19:11:41 +0000 (19:11 +0000)]
Make new version 0.8.13, not 0.9.0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2537 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCisco IGRP support, from Paul Ionescu.
guy [Thu, 26 Oct 2000 09:14:28 +0000 (09:14 +0000)]
Cisco IGRP support, from Paul Ionescu.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2536 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix typos, and give credit to Jason Lango for the original RTCP time
guy [Thu, 26 Oct 2000 09:03:35 +0000 (09:03 +0000)]
Fix typos, and give credit to Jason Lango for the original RTCP time
stamp Band-Aid(TM).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2535 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoList of changes for this next release, which I'll probably call 0.9.0.
gram [Wed, 25 Oct 2000 16:08:30 +0000 (16:08 +0000)]
List of changes for this next release, which I'll probably call 0.9.0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2534 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThis patch adds two things:
gram [Wed, 25 Oct 2000 16:06:50 +0000 (16:06 +0000)]
This patch adds two things:

        - Pressing Esc key will cause the filter selection dialog to
          "Cancel"

        - Double-clicking on a list item in filter selection dialog is
          equivalent to single-click followed by "OK"

Santeri Paavolainen <santtu@ssh.com>

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2533 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFixing a small bug that Guy Harris noticed.
sharpe [Tue, 24 Oct 2000 20:23:16 +0000 (20:23 +0000)]
Fixing a small bug that Guy Harris noticed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2532 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the routines used for the hash table static - they're not used
guy [Mon, 23 Oct 2000 04:26:55 +0000 (04:26 +0000)]
Make the routines used for the hash table static - they're not used
outside "packet-afs.c".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2531 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen looking for definitions of "proto_register" and "proto_reg_handoff"
guy [Sun, 22 Oct 2000 20:01:14 +0000 (20:01 +0000)]
When looking for definitions of "proto_register" and "proto_reg_handoff"
routines, throw out lines containing semicolons, so that we don't see
*declarations* of those routines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2530 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen checking whether we should build the list of flag names to put in
guy [Sun, 22 Oct 2000 09:05:12 +0000 (09:05 +0000)]
When checking whether we should build the list of flag names to put in
the COL_INFO column, check COL_INFO, not COL_PROTOCOL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2529 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen checking whether we should set the COL_INFO column, check COL_INFO,
guy [Sun, 22 Oct 2000 07:54:04 +0000 (07:54 +0000)]
When checking whether we should set the COL_INFO column, check COL_INFO,
not COL_PROTOCOL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2528 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "H.261", not "H261", as the short name for the protocol.
guy [Sun, 22 Oct 2000 07:53:19 +0000 (07:53 +0000)]
Use "H.261", not "H261", as the short name for the protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2527 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't require that all SNMP packets go to or from the SNMP port - the
guy [Sat, 21 Oct 2000 18:52:17 +0000 (18:52 +0000)]
Don't require that all SNMP packets go to or from the SNMP port - the
SNMP request would, but an SNMP reply can come back from another port.
Instead, when an SNMP request is seen, create a conversation with a
wildcard port, if one doesn't already exist, and make its dissector the
SNMP dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2526 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWildcard matching is tricky - you have to try wildcarding both the
guy [Sat, 21 Oct 2000 09:54:12 +0000 (09:54 +0000)]
Wildcard matching is tricky - you have to try wildcarding both the
source *and* destination port and/or both the source *and* destination
address passed to "find_conversation()", because the packet for which
you're trying to find the conversation may be going in the opposite
direction to the packet for which the conversation was originally
created.

Create different hash tables for wildcarded conversations, to reduce the
number of "is this a wildcard?" tests done when doing hash lookups.

This is sufficient to allow the TFTP dissector to use conversations
rather than being special-cased in the UDP dissector, and may also be
sufficient to handle a similar problem with SMTP (request goes from
client IP X port Y to server IP Z's well-known port, reply comes back
from some other port on server Z to client IP X port Y), but further use
may reveal other changes that should be made.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2525 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix error in code that '\0'-terminates a string - it was putting the
guy [Sat, 21 Oct 2000 09:46:21 +0000 (09:46 +0000)]
Fix error in code that '\0'-terminates a string - it was putting the
'\0' one byte *past* the end of the buffer, rather than in the last byte
of the buffer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2524 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSupport for conversations with "wildcard" destination addresses, from
guy [Sat, 21 Oct 2000 05:52:28 +0000 (05:52 +0000)]
Support for conversations with "wildcard" destination addresses, from
Jeff Foster.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2523 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCheck ICMP checksum. XXX - won't work if the ICMP packet is inside a
guy [Sat, 21 Oct 2000 04:34:47 +0000 (04:34 +0000)]
Check ICMP checksum.  XXX - won't work if the ICMP packet is inside a
fragmented IP datagram, although that's probably extremely unlikely.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2522 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCapture statistics box improvements from Santeri Paavolainen.
guy [Sat, 21 Oct 2000 04:20:07 +0000 (04:20 +0000)]
Capture statistics box improvements from Santeri Paavolainen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2521 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdates from David Frascone.
guy [Sat, 21 Oct 2000 03:24:37 +0000 (03:24 +0000)]
Updates from David Frascone.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2520 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRemove #include "gtk/colors.h" from file.h, which keep the GTK+ header
gram [Fri, 20 Oct 2000 04:26:40 +0000 (04:26 +0000)]
Remove #include "gtk/colors.h" from file.h, which keep the GTK+ header
files from being #included in epan/packet.c.
Fix the other files that need either "gtk/colors.h" or <gtk/gtk.h> #included
as a result of not pulling in gtk/colors.h automatically because of file.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2519 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix some typos.
guy [Thu, 19 Oct 2000 23:11:45 +0000 (23:11 +0000)]
Fix some typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2518 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove the declaration of "g_resolving_actif" from the top-level
guy [Thu, 19 Oct 2000 22:59:24 +0000 (22:59 +0000)]
Move the declaration of "g_resolving_actif" from the top-level
"globals.h" file to "epan/resolv.h", as it's exported by
"epan/resolv.c", have files that use "g_resolving_actif" include
"resolv.h", and don't have "epan/resolv.c" include "globals.h" so that
it doesn't drag in, for example, headers that, in turn, drag in GTK+
headers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2517 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDissect the allegedly-NTP time stamp in a Sender Report packet as two
guy [Thu, 19 Oct 2000 08:17:45 +0000 (08:17 +0000)]
Dissect the allegedly-NTP time stamp in a Sender Report packet as two
32-bit integers, until we figure out what it really is.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2516 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPatch from Isaac Wilcox to do case-sensitive checks for HTTP methods and
guy [Thu, 19 Oct 2000 07:38:01 +0000 (07:38 +0000)]
Patch from Isaac Wilcox to do case-sensitive checks for HTTP methods and
to look for a space after the method name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2515 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThere's no "exception.h" header file in "epan", but there is
guy [Thu, 19 Oct 2000 07:18:19 +0000 (07:18 +0000)]
There's no "exception.h" header file in "epan", but there is
"exceptions.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2514 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"tvbtest.c" is now in the "epan" subdirectory, so don't put it in
guy [Thu, 19 Oct 2000 07:17:38 +0000 (07:17 +0000)]
"tvbtest.c" is now in the "epan" subdirectory, so don't put it in
EXTRA_DIST in the top-level Makefile.am.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2513 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNote that we might not want the dissector for Q.931-inside-TPKT to be
guy [Thu, 19 Oct 2000 07:01:32 +0000 (07:01 +0000)]
Note that we might not want the dissector for Q.931-inside-TPKT to be
heuristic - we may just want to make port 1720 be Q.931-inside-TPKT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2512 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAndreas Sikkema's new H.261 and TPKT dissectors, replacement RTCP and
guy [Thu, 19 Oct 2000 06:45:11 +0000 (06:45 +0000)]
Andreas Sikkema's new H.261 and TPKT dissectors, replacement RTCP and
RTP dissectors, and changes to the Q.931 dissector for use with H.323.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2511 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of extra declaration of HAVE_DIRECT_H; one is enough.
guy [Wed, 18 Oct 2000 09:34:10 +0000 (09:34 +0000)]
Get rid of extra declaration of HAVE_DIRECT_H; one is enough.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2510 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix from Per Flock to A6 RR decoding.
guy [Wed, 18 Oct 2000 00:37:54 +0000 (00:37 +0000)]
Fix from Per Flock to A6 RR decoding.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2509 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd initial support for "type 12" frames. I have no documentation for
gerald [Tue, 17 Oct 2000 18:07:52 +0000 (18:07 +0000)]
Add initial support for "type 12" frames.  I have no documentation for
these other than a trace file a client sent me.  The header appears to
be similar to frame2 and frame4 records, but with extra bytes at the end.
The trace file also contains record types 13 - 17 which appear to contain
metainformation such as retransmit counts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2508 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoBetter heuristic for detecting Linux mangling of TR header.
gram [Tue, 17 Oct 2000 11:05:23 +0000 (11:05 +0000)]
Better heuristic for detecting Linux mangling of TR header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2507 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe Session Announcement Protocol version 2 is now RFC 2974. Since
gram [Tue, 17 Oct 2000 11:03:24 +0000 (11:03 +0000)]
The Session Announcement Protocol version 2 is now RFC 2974. Since
draft-ietf-mmusic-sap-v2-03.txt, the only change that concerns a
dissector seems to be that the optional timeout field no longer
exists.
Heikki Vatiainen <hessu@cs.tut.fi>

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2506 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdding the magicpoint presentation I am doing for LinuxWorld Malaysia
sharpe [Tue, 17 Oct 2000 09:32:46 +0000 (09:32 +0000)]
Adding the magicpoint presentation I am doing for LinuxWorld Malaysia

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2505 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the top-level "config.h.win32" more closely resemble the top-level
guy [Tue, 17 Oct 2000 09:25:37 +0000 (09:25 +0000)]
Make the top-level "config.h.win32" more closely resemble the top-level
"config.h", and update it to include stuff added to "config.h" and
remove stuff removed from "config.h".

Give libethereal a "config.h.win32" and make its "Makefile.nmake" file
copy it to "config.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2504 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAlas, we have to set HAVE_PLUGINS in the top-level configure script as
guy [Tue, 17 Oct 2000 09:21:51 +0000 (09:21 +0000)]
Alas, we have to set HAVE_PLUGINS in the top-level configure script as
well as in the libethereal configure script.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2503 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPatch from Heikki Vatiainen to make "tvb_strnlen()" return the length of
guy [Tue, 17 Oct 2000 08:50:57 +0000 (08:50 +0000)]
Patch from Heikki Vatiainen to make "tvb_strnlen()" return the length of
the string rather than the offset of the end of the string, plus a patch
to "tvb_get_nstringz()" to treat the return value of "tvb_strnlen()" as
a length rather than an end offset.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2502 f5534014-38df-0310-8fa8-9805f1628bb7