obnox/wireshark/wip.git
19 years agoadd details for doxygen
ulfl [Fri, 4 Jun 2004 20:04:34 +0000 (20:04 +0000)]
add details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11109 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoupdate DOXYGEN setting and add new HHC (MS html help compiler) setting
ulfl [Fri, 4 Jun 2004 17:31:11 +0000 (17:31 +0000)]
update DOXYGEN setting and add new HHC (MS html help compiler) setting

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11108 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd more details for doxygen
ulfl [Fri, 4 Jun 2004 17:19:01 +0000 (17:19 +0000)]
add more details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11107 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agouse the dot tool
ulfl [Fri, 4 Jun 2004 17:18:39 +0000 (17:18 +0000)]
use the dot tool

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11106 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoget rid of a compiler warning
sahlberg [Fri, 4 Jun 2004 11:35:14 +0000 (11:35 +0000)]
get rid of a compiler warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11105 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTomas updates to H235 and the ASN2ETH compiler
sahlberg [Fri, 4 Jun 2004 11:28:04 +0000 (11:28 +0000)]
Tomas updates to H235 and the ASN2ETH compiler

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11104 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Devin Heitmueller: Fix some compilation warnings.
gerald [Fri, 4 Jun 2004 03:58:25 +0000 (03:58 +0000)]
From Devin Heitmueller: Fix some compilation warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11103 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAs Mark Corley pointed out, win32-setup.sh should be part of the distribution.
gerald [Fri, 4 Jun 2004 03:25:35 +0000 (03:25 +0000)]
As Mark Corley pointed out, win32-setup.sh should be part of the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11102 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a mechanism where one can provide callbacks to the kerbgeros dissector
sahlberg [Fri, 4 Jun 2004 01:56:25 +0000 (01:56 +0000)]
Add a mechanism where one can provide callbacks to the kerbgeros dissector
to pass back dissection of application specific fields (octet strings)

This can later be used to pick up session keys by dcerpc and similar.
Currently it will initially be used by packetcable.

PacketCable additions by Thomas Anders

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11101 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix crash bug in sid snooping if we don't have a policy name for a
tpot [Fri, 4 Jun 2004 00:15:55 +0000 (00:15 +0000)]
Fix crash bug in sid snooping if we don't have a policy name for a
handle in a samr_query_dispinfo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11100 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNew protocol : DNP
sahlberg [Fri, 4 Jun 2004 00:12:12 +0000 (00:12 +0000)]
New protocol : DNP
From Graham Bloice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11099 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix bug to do with renaming lsa.domain_sid to nt.domain_sid to get
tpot [Fri, 4 Jun 2004 00:05:56 +0000 (00:05 +0000)]
Fix bug to do with renaming lsa.domain_sid to nt.domain_sid to get
sid snooping working again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11098 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd dissection of the ms rap netserverenum3 function
sahlberg [Thu, 3 Jun 2004 23:55:57 +0000 (23:55 +0000)]
add dissection of the ms rap netserverenum3 function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11097 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake static some routines and variables not used outside the source file
guy [Thu, 3 Jun 2004 21:46:27 +0000 (21:46 +0000)]
Make static some routines and variables not used outside the source file
defining them.

Move declarations of some callbacks outside the source files using them
into the appropriate header, and arrange that the appropriate header is
included by those source files.

Move the SAT_E definition into a "sat.h" file, included both by
"endpoint_talkers_table.h" and "hostlist_table.h", so that both of the
latter headers can be included by the same file ("menu.c" has to include
both, as per the change in the previous paragraph).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11096 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"gtk_file_selection_set_filename()" doesn't work with a GtkFileChooser,
guy [Thu, 3 Jun 2004 21:17:06 +0000 (21:17 +0000)]
"gtk_file_selection_set_filename()" doesn't work with a GtkFileChooser,
and "gtk_file_chooser_set_filename()" requires an absolute path, so ""
isn't valid.  Get rid of the "gtk_file_selection_set_filename()" call in
"file_selection_new()".

Put in a comment asking why we're using
"gtk_file_selection_set_filename()" at all.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11095 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRe-generate from the updated asn2eth script and h235.cnf files.
guy [Thu, 3 Jun 2004 19:07:05 +0000 (19:07 +0000)]
Re-generate from the updated asn2eth script and h235.cnf files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11094 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomonthly update
jmayer [Thu, 3 Jun 2004 16:35:57 +0000 (16:35 +0000)]
monthly update

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11093 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Lars Roland: Add have_tap_listeners() and rtp_payload_type_vals
gerald [Thu, 3 Jun 2004 16:29:39 +0000 (16:29 +0000)]
From Lars Roland: Add have_tap_listeners() and rtp_payload_type_vals
to libethereal.def.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11092 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoenable chm file generation for doxygen,
ulfl [Thu, 3 Jun 2004 14:57:23 +0000 (14:57 +0000)]
enable chm file generation for doxygen,
move chm filename setting to module specific config file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11091 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen
ulfl [Thu, 3 Jun 2004 14:54:26 +0000 (14:54 +0000)]
add details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11090 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Tomas Kukosa: unnecessary types are excluded with NO_EMIT
guy [Thu, 3 Jun 2004 08:35:44 +0000 (08:35 +0000)]
From Tomas Kukosa: unnecessary types are excluded with NO_EMIT
directive.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11089 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Tomas Kukosa:
guy [Thu, 3 Jun 2004 08:33:29 +0000 (08:33 +0000)]
From Tomas Kukosa:

  - limits for dissect_per_constrained_integer() are passed as unsigned
    if possible
  - new directive NO_EMIT in conformation file - avoids emitting
    function body (or vals or both) into packet-xxxx-fn.c file
  - new directive USER_DEFINED in conformation file - emitting of
    function body (or vals or both) in the packet-xxxx-fn.c file is
    replaced with external declaration
  - support for SET OF type for BER
  - flag WITH_VALS is default for EXPORTS, USER_DEFINED, NO_EMIT
    directives
  - the _U_ attribute is used for pinfo parameters
  - the offset parameters and return codes are changed from guint32 to
    int

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11088 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Yaniv Kaul: add SOCKS v4a support.
guy [Thu, 3 Jun 2004 08:04:07 +0000 (08:04 +0000)]
From Yaniv Kaul: add SOCKS v4a support.

Clean up handling of null-terminated strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11087 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Graeme Hewson:
guy [Thu, 3 Jun 2004 07:37:49 +0000 (07:37 +0000)]
From Graeme Hewson:

     Remove reference to negative slice lengths.

     Clean and polish.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11086 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Graeme Hewson:
guy [Thu, 3 Jun 2004 07:36:25 +0000 (07:36 +0000)]
From Graeme Hewson:

     Use gint32 instead of guint32 for node data.

Fix up some other signed-vs-unsigned issues in the display filter
parser and lexical analyzer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11085 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Graeme Hewson:
guy [Thu, 3 Jun 2004 07:34:49 +0000 (07:34 +0000)]
From Graeme Hewson:

     Fix assertion failure when absolute value of negative slice
     offset > field length.

     Remove code for handling negative slice lengths.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11084 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Graeme Hewson:
guy [Thu, 3 Jun 2004 07:33:46 +0000 (07:33 +0000)]
From Graeme Hewson:

     Check slice lengths as well as offsets.  Disallow negative/zero
     lengths.

     Range on RHS of display filter expression wasn't being checked in
     every case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11083 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Graeme Hewson:
guy [Thu, 3 Jun 2004 07:17:24 +0000 (07:17 +0000)]
From Graeme Hewson:

     Use gint32 instead of guint32 and strtol() instead of strtoul()
     for signed integers.

     Pathological slice specifications could cause Flex default rule
     to be invoked, echoing characters to stdout.
     Example: frame[0foo]==1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11082 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Devin Heitmueller: improve decoding of outgoing and incoming
guy [Thu, 3 Jun 2004 04:19:38 +0000 (04:19 +0000)]
From Devin Heitmueller: improve decoding of outgoing and incoming
message blocks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11081 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Mike Frisch:
guy [Thu, 3 Jun 2004 04:13:24 +0000 (04:13 +0000)]
From Mike Frisch:

- fixed tree display of NFSv4 change_info type;
- add OPEN4_RESULT_LOCKTYPE_POSIX to OPEN result (reply) flags;
- fixed open_delegation4 dissector;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11080 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the definition of "register_tap_menu_item()" match its declaration.
guy [Thu, 3 Jun 2004 02:14:50 +0000 (02:14 +0000)]
Make the definition of "register_tap_menu_item()" match its declaration.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11079 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a typo.
guy [Thu, 3 Jun 2004 02:14:14 +0000 (02:14 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11078 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen
ulfl [Wed, 2 Jun 2004 22:13:04 +0000 (22:13 +0000)]
add details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11077 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen
ulfl [Wed, 2 Jun 2004 20:14:51 +0000 (20:14 +0000)]
add details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11076 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf, when rotating capture files, the attempt to close the current file
guy [Wed, 2 Jun 2004 18:49:40 +0000 (18:49 +0000)]
If, when rotating capture files, the attempt to close the current file
fails, set "rb_data.pdh" to NULL, so we know it's not open (if
"wtap_dump_close()" fails, the wtap_dumper_t is still closed - and the
file descriptor for it is probably closed, too, as, if "close()" fails,
the FD is probably closed; the Single UNIX Specification Version 3 says
the state of the FD is unspecified, but in practice most OSes probably
still close it).

If we try to close the current file, first check to make sure it's open,
i.e. that "rb_data.pdh" is non-null.  (Or perhaps we should avoid trying
to close it if the open *or* the most recent attempt to rotate the
capture files failed.)

Note that if "wtap_dump_close()" fails we might not need to close the
underlying file descriptor (and, even if we do, there's no guarantee
that attempt won't also fail and leave the FD still open - which is why
I suspect that a failed "close()" leaves the FD closed on most OSes).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11075 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen
ulfl [Wed, 2 Jun 2004 18:44:10 +0000 (18:44 +0000)]
add details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11074 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomove "extern GtkWidget *main_display_filter_widget" from
ulfl [Wed, 2 Jun 2004 07:12:11 +0000 (07:12 +0000)]
move "extern GtkWidget *main_display_filter_widget" from
various stats files to gtkglobals.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11073 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of the #if 0'ed out "rtp_payload_type_vals[]" table - we should
guy [Wed, 2 Jun 2004 07:01:04 +0000 (07:01 +0000)]
Get rid of the #if 0'ed out "rtp_payload_type_vals[]" table - we should
be using the one from libethereal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11072 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Mike Frisch:
guy [Wed, 2 Jun 2004 06:50:28 +0000 (06:50 +0000)]
From Mike Frisch:

add support for NFSv4 RELEASE_LOCKOWNER and ILLEGAL operations;

minor modification to the NFSv4 NULLPROC dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11071 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofix a doxygen comment
ulfl [Wed, 2 Jun 2004 06:44:40 +0000 (06:44 +0000)]
fix a doxygen comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11070 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Yaniv Kaul: HKP is HTTP-based and runs on port 11371.
guy [Wed, 2 Jun 2004 06:35:57 +0000 (06:35 +0000)]
From Yaniv Kaul: HKP is HTTP-based and runs on port 11371.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11069 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Magnus Hansson: add more information to the Info column.
guy [Wed, 2 Jun 2004 06:30:15 +0000 (06:30 +0000)]
From Magnus Hansson: add more information to the Info column.

Use "tvb_format_stringzpad()" to put a zero-padded string into the
protocol tree and Info column, so that we 1) don't use a fixed-length
buffer that we might overflow and 2) we handle non-printable bytes in
the string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11068 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't define data variables in header files included by more than one
guy [Tue, 1 Jun 2004 23:08:00 +0000 (23:08 +0000)]
Don't define data variables in header files included by more than one
file - that keeps the variable from being shared, and also produces
compiler warnings if the variable isn't used by all the files that
include the header in question.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11067 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the definition of "add_hostlist_table_data()" match its
guy [Tue, 1 Jun 2004 23:00:24 +0000 (23:00 +0000)]
Make the definition of "add_hostlist_table_data()" match its
declaration.

Give the address and port arguments to "add_hostlist_table_data()"
appropriate names and Doxygen comments (they're not a source address and
port, they're just an address and port), and do the same for the address
and port members of a "hostlist_talker_t".

Get rid of extra unnecessary variables in "add_hostlist_table_data()".

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11066 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfix: don't double define rtp_payload_type_vals
ulfl [Tue, 1 Jun 2004 22:12:37 +0000 (22:12 +0000)]
bugfix: don't double define rtp_payload_type_vals

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11065 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agominor bugfix from previous check in
ulfl [Tue, 1 Jun 2004 22:00:22 +0000 (22:00 +0000)]
minor bugfix from previous check in

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11064 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Thomas Anders: MGCP sub-parameter dissection
etxrab [Tue, 1 Jun 2004 21:56:44 +0000 (21:56 +0000)]
From Thomas Anders: MGCP sub-parameter dissection

Anders Broman: BICC,SIP-T dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11063 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen, various code cleanups as a result of this
ulfl [Tue, 1 Jun 2004 21:56:04 +0000 (21:56 +0000)]
add details for doxygen, various code cleanups as a result of this

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11062 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRevert previous checkin made by mistake *sigh
etxrab [Tue, 1 Jun 2004 21:45:40 +0000 (21:45 +0000)]
Revert previous checkin made by mistake *sigh

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11061 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Thomas Anders dissects the RTP Payload Type (if media protocol is RTP/AVP)
etxrab [Tue, 1 Jun 2004 21:40:41 +0000 (21:40 +0000)]
From Thomas Anders dissects the RTP Payload Type (if media protocol is RTP/AVP)
with its descriptive name rather than the raw value string,
much like packet-rtp.c does already.
To avoid duplicate definitions,  the existing rtp_payload_type_vals[] definition is  moved
from packet-rtp.c and gtk/rtp_stream_dlg.c to rtp_pt.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11060 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the definition of "add_ett_table_data()" match its declaration.
guy [Tue, 1 Jun 2004 21:29:50 +0000 (21:29 +0000)]
Make the definition of "add_ett_table_data()" match its declaration.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11059 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agominor bugfix from previous check in
ulfl [Tue, 1 Jun 2004 20:37:09 +0000 (20:37 +0000)]
minor bugfix from previous check in

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11058 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen, various code cleanups as a result of this
ulfl [Tue, 1 Jun 2004 20:28:05 +0000 (20:28 +0000)]
add details for doxygen, various code cleanups as a result of this

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11057 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a typo.
guy [Tue, 1 Jun 2004 18:58:04 +0000 (18:58 +0000)]
Fix a typo.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11056 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoInterpret the sampling mode values.
guy [Tue, 1 Jun 2004 18:43:30 +0000 (18:43 +0000)]
Interpret the sampling mode values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11055 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAs Motonori Shindo nodes, the sampling rate and mode in a Netflow V5
guy [Tue, 1 Jun 2004 18:39:13 +0000 (18:39 +0000)]
As Motonori Shindo nodes, the sampling rate and mode in a Netflow V5
header is 2 bits of sampling mode and 14 bits of sample rate, not 16
bits of sample rate.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11054 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agovarious code cleanups
ulfl [Tue, 1 Jun 2004 17:37:10 +0000 (17:37 +0000)]
various code cleanups

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11053 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen, various code cleanups as a result of this
ulfl [Tue, 1 Jun 2004 17:33:37 +0000 (17:33 +0000)]
add details for doxygen, various code cleanups as a result of this

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11052 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Yaniv Kaul: PCT support.
guy [Tue, 1 Jun 2004 01:03:49 +0000 (01:03 +0000)]
From Yaniv Kaul: PCT support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11051 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoEliminate a no-longer-used routine.
guy [Tue, 1 Jun 2004 01:01:31 +0000 (01:01 +0000)]
Eliminate a no-longer-used routine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11050 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIt really helps when you change the default from gtk1 -> gtk2 in the top
jmayer [Tue, 1 Jun 2004 00:15:38 +0000 (00:15 +0000)]
It really helps when you change the default from gtk1 -> gtk2 in the top
level configure.in to mirror that change in wiretap. Otherwise people who
have both versions of glib/gtk installed may see crashes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11049 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd dissection of application PoC1 data
etxrab [Mon, 31 May 2004 19:35:53 +0000 (19:35 +0000)]
Add dissection of application PoC1 data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11048 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Thomas Anders fix some memory leaks
etxrab [Mon, 31 May 2004 19:31:14 +0000 (19:31 +0000)]
From Thomas Anders fix some memory leaks

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11047 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen
ulfl [Mon, 31 May 2004 15:47:34 +0000 (15:47 +0000)]
add details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11046 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen
ulfl [Mon, 31 May 2004 13:42:58 +0000 (13:42 +0000)]
add details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11045 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosplit doxygen.cfg into common Ethereal things and module specifics
ulfl [Mon, 31 May 2004 13:42:17 +0000 (13:42 +0000)]
split doxygen.cfg into common Ethereal things and module specifics

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11044 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfix: don't try to destroy a dialog twice
ulfl [Mon, 31 May 2004 13:35:49 +0000 (13:35 +0000)]
bugfix: don't try to destroy a dialog twice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11043 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agodirectly use the file selection dialog instead of using an additional custom dialog
ulfl [Mon, 31 May 2004 12:06:28 +0000 (12:06 +0000)]
directly use the file selection dialog instead of using an additional custom dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11042 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosome more dialog redesign and code cleanup
ulfl [Mon, 31 May 2004 11:22:58 +0000 (11:22 +0000)]
some more dialog redesign and code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11041 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a routine that indicates where there are any tap listeners
guy [Mon, 31 May 2004 09:53:21 +0000 (09:53 +0000)]
Add a routine that indicates where there are any tap listeners
registered (not whether there are any tap *filters* registered).

Do dissection in Tethereal iff:

we're printing information about each packet;

we're using a read filter on the packets;

there are any tap listeners registered (even if there are no tap
filters registered - not all taps use filters).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11040 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agointerface options preference dialog: remove confusing second interface clist,
ulfl [Mon, 31 May 2004 09:23:14 +0000 (09:23 +0000)]
interface options preference dialog: remove confusing second interface clist,
fix a bug making garbage of user supplied interface description

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11039 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake "-q" suppress packet printing when you're reading a capture file
guy [Mon, 31 May 2004 08:41:32 +0000 (08:41 +0000)]
Make "-q" suppress packet printing when you're reading a capture file
and not writing to another capture file, for use with "-z" options.

Note that "-z proto" *doesn't* print statistics at the end - it modifies
the packet summary output.

Note that on at least some BSDs the "status" character is set to "off"
by default, so you have to set it explicitly in order to be able to ^T
an application such as Tethereal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11038 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove the packet counting, dissecting, and filtering out of the "write
guy [Mon, 31 May 2004 07:52:27 +0000 (07:52 +0000)]
Move the packet counting, dissecting, and filtering out of the "write
packet" and "print packet" callbacks into a common routine, so that we
don't count packets twice if we're counting and dissecting.

Print the packet count with ^T iff we're not updating a displayed packet
count as packets arrive, regardless of whether we're printing packet
information, saving packets to a file, or both (tcpdump prints it
regardless of whether it's printing packet information or saving packets
to a file).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11037 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe "key" argument to "write_recent_geom()" is required (as it's called
guy [Mon, 31 May 2004 02:42:39 +0000 (02:42 +0000)]
The "key" argument to "write_recent_geom()" is required (as it's called
through a pointer), but isn't used - mark it as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11036 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd support for Exif decoding (initial framework).
obiot [Mon, 31 May 2004 01:24:03 +0000 (01:24 +0000)]
Add support for Exif decoding (initial framework).
Still lots of work to do here :)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11035 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosort saved preference settings by appearance in dialog
ulfl [Sun, 30 May 2004 18:27:52 +0000 (18:27 +0000)]
sort saved preference settings by appearance in dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11034 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Thomas Anders patch adds sub parameter dissection to the MGCP plugin
etxrab [Sun, 30 May 2004 17:58:35 +0000 (17:58 +0000)]
From Thomas Anders patch adds sub parameter dissection to the MGCP plugin
(plugins/mgcp/packet-mgcp.c), initially for the ConnectionParameters(P),
and updates/adds some specification references.

This patch makes the sub parameter values filterable as numbers and
may allow for improved MGCP statistics in the future.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11033 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosave window position/size/maximized state into recent file
ulfl [Sun, 30 May 2004 11:54:37 +0000 (11:54 +0000)]
save window position/size/maximized state into recent file
(only help dialog for now)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11032 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen we create a tvbuff for a security blob, set its reported length to
guy [Sat, 29 May 2004 06:55:52 +0000 (06:55 +0000)]
When we create a tvbuff for a security blob, set its reported length to
the reported length of the blob, not the amount of data available from
the blob.

Use "tvb_strneql()" when checking for strings, so that we don't throw an
exception if there's less data in the tvbuff than there are bytes in the
string, we just say "not equal".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11031 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Nathan Alger: update the VSA attributes for Juniper and
guy [Sat, 29 May 2004 04:41:25 +0000 (04:41 +0000)]
From Nathan Alger: update the VSA attributes for Juniper and
Juniper/Unisphere routers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11030 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSquelch a compiler warning by removing a "/*" from the middle of a
guy [Sat, 29 May 2004 04:34:51 +0000 (04:34 +0000)]
Squelch a compiler warning by removing a "/*" from the middle of a
comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11029 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agocheck in Thomas Anders patch to SNMP to allow ethereal to dissect
sahlberg [Sat, 29 May 2004 01:00:59 +0000 (01:00 +0000)]
check in Thomas Anders patch to SNMP to allow ethereal to dissect
properly COUNTER64 objects that are not spanning a full 64 bit on the wire

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11028 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoconnectionless cancel PDU's don't have a dg_server_accepting_cancels field
ulfl [Fri, 28 May 2004 20:59:56 +0000 (20:59 +0000)]
connectionless cancel PDU's don't have a dg_server_accepting_cancels field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11027 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoenable postcript printing if selected in prefs,
ulfl [Thu, 27 May 2004 23:09:09 +0000 (23:09 +0000)]
enable postcript printing if selected in prefs,
correctly remove temporary file on close dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11026 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfixes: fixed printing on win32,
ulfl [Thu, 27 May 2004 21:55:59 +0000 (21:55 +0000)]
bugfixes: fixed printing on win32,
and convert none printable characters, so printing will work on binary output as well
(like in the GUI output)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11025 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agowin_printer is gboolean, not an int
ulfl [Thu, 27 May 2004 21:52:07 +0000 (21:52 +0000)]
win_printer is gboolean, not an int

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11024 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadded a small comment
ulfl [Thu, 27 May 2004 21:48:10 +0000 (21:48 +0000)]
added a small comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11023 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTag the "has_child" argument to "prefs_tree_page_add()" as unused when
guy [Thu, 27 May 2004 21:42:54 +0000 (21:42 +0000)]
Tag the "has_child" argument to "prefs_tree_page_add()" as unused when
building with GTK+ 2.x or later, as it's only needed and only used for
1.2[.x].

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11022 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agouse gtk_window_set_default_size() instead of WIDGET_SET_SIZE() for the dialogs,
ulfl [Thu, 27 May 2004 19:59:50 +0000 (19:59 +0000)]
use gtk_window_set_default_size() instead of WIDGET_SET_SIZE() for the dialogs,
as WIDGET_SET_SIZE() will prevent the user from shrinking the dialog,
and gtk_window_set_default_size() will not

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11021 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of an unused variable.
guy [Thu, 27 May 2004 18:12:58 +0000 (18:12 +0000)]
Get rid of an unused variable.

Mark as unused a required argument that's unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11020 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadded a small comment
ulfl [Thu, 27 May 2004 17:26:46 +0000 (17:26 +0000)]
added a small comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11019 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfix: don't try to destroy a window, when it's already being destroyed
ulfl [Thu, 27 May 2004 17:08:50 +0000 (17:08 +0000)]
bugfix: don't try to destroy a window, when it's already being destroyed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11018 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoa lot of code cleanup
ulfl [Thu, 27 May 2004 16:50:16 +0000 (16:50 +0000)]
a lot of code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11017 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfix: don't try to destroy a window, when it's already being destroyed
ulfl [Thu, 27 May 2004 16:48:36 +0000 (16:48 +0000)]
bugfix: don't try to destroy a window, when it's already being destroyed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11016 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadded some tooltips
ulfl [Thu, 27 May 2004 16:43:01 +0000 (16:43 +0000)]
added some tooltips

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11015 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't point to the manpage for the list of authors, it's in the about dialog now
ulfl [Thu, 27 May 2004 16:41:33 +0000 (16:41 +0000)]
Don't point to the manpage for the list of authors, it's in the about dialog now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11014 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agothe isns timestamp is in fact a 64 bit integer and not a 32 bit integer.
sahlberg [Thu, 27 May 2004 08:33:22 +0000 (08:33 +0000)]
the isns timestamp is in fact a 64 bit integer and not a 32 bit integer.

declaring it properly will make ethereal dissect it properly as well
instead of crashing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11013 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomake KRB_SAFE more consistent with the other PDUs by removing the SAFE expansion.
sahlberg [Thu, 27 May 2004 08:22:04 +0000 (08:22 +0000)]
make KRB_SAFE more consistent with the other PDUs by removing the SAFE expansion.

cosmetic: Put the application type on the kerberos subtree

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11012 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't compile in "follow_save_as_destroy_cb()" for GTK+ 2.4 and later,
guy [Wed, 26 May 2004 21:23:20 +0000 (21:23 +0000)]
Don't compile in "follow_save_as_destroy_cb()" for GTK+ 2.4 and later,
as it's not used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11011 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake gtk2 the default. Use --disable-gtk2 to use glib1/gtk1 instead
jmayer [Wed, 26 May 2004 12:08:15 +0000 (12:08 +0000)]
Make gtk2 the default. Use --disable-gtk2 to use glib1/gtk1 instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11010 f5534014-38df-0310-8fa8-9805f1628bb7