git.samba.org - obnox/wireshark/wip.git/log

git.samba.org / obnox / wireshark / wip.git / log

krj [Sat, 29 Aug 2009 07:53:48 +0000 (07:53 +0000)]

Revert r29614 until I figure out why buildbot doesn't like it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29615 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sat, 29 Aug 2009 06:42:23 +0000 (06:42 +0000)]

Use G_STRINGIFY/G_PASTE

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29614 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sat, 29 Aug 2009 05:46:45 +0000 (05:46 +0000)]

Simplify logic wrt. PANGO_INST_VERSION

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29613 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sat, 29 Aug 2009 05:39:33 +0000 (05:39 +0000)]

Simplify logic wrt. GTK_INST_VERSION

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29612 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sat, 29 Aug 2009 05:35:50 +0000 (05:35 +0000)]

Remove GCC_GLIB_CFLAGS. It isn't being used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29611 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sat, 29 Aug 2009 04:47:28 +0000 (04:47 +0000)]

Use NB_RTPMUX as protocol short name

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29610 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sat, 29 Aug 2009 04:43:52 +0000 (04:43 +0000)]

We need to handoff even when we don't have a tree

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29609 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sat, 29 Aug 2009 04:39:59 +0000 (04:39 +0000)]

Indent comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29608 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Sat, 29 Aug 2009 02:32:33 +0000 (02:32 +0000)]

Note what the 3GPP spec is for this protocol.

Suggest a possible less-weak heuristic.

Note that we're not checking the T bit and handling RTP header
compression.

At least as I read TS 29.414, the length indicator isn't supposed to be
zero; however, a length indicator of 0 doesn't keep us from dissecting
further, so just don't bother dissecting the payload. We should,
perhaps, add an expert info for this.

We should perhaps also catch exceptions thrown when dissecting the RTP
packet, so a malformed RTP packet will still let us continue dissecting
the rest of the Nb packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29607 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Sat, 29 Aug 2009 02:25:04 +0000 (02:25 +0000)]

Replace "repeated blurb" by NULL in two cases;
Reformat a long line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29606 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Sat, 29 Aug 2009 02:22:28 +0000 (02:22 +0000)]

Replace "" by NULL in blurbs; Cleanup indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29605 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Sat, 29 Aug 2009 01:46:42 +0000 (01:46 +0000)]

Cleanup:
- proto_reg_handoff: 'if (!inited)' not req'd;
- Remove unneeded #includes;
- Use NULL instead of " for 'blurbs';
- Remove unneeded foward reference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29604 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Sat, 29 Aug 2009 01:08:31 +0000 (01:08 +0000)]

Note that the "heuristic" is fatally weak, and must be strengthened or
eliminated.

Fix indentation.

Use tvb_reported_length(), so we throw an exception for packets cut
short by a snapshot length.

Don't bother showing or dissecting the payload if there isn't any.

Don't show an item with a zero-length payload as going to the end of the
packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29603 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 28 Aug 2009 21:34:59 +0000 (21:34 +0000)]

From Neil Piercy:
Add new protocol for 3GPP 29.414 (Nb interface RTP Mux).

- Don't use C++-style comments (comments beginning with "//")
- Don't declare variables in the middle of executable code; not all C
compilers support that.
- Dont register preferences when none present.
- Removed CHECK_COL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29602 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Fri, 28 Aug 2009 19:15:43 +0000 (19:15 +0000)]

Fix code which could access uninitialized variables and display incorrect text in COL_INFO.
(Found by clang scan-build).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29601 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Fri, 28 Aug 2009 18:37:53 +0000 (18:37 +0000)]

Fix if test in fcn rs11():
return if either (as opposed to both) of the required sparameters is not present;
(Found by clang scan-build).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29600 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Fri, 28 Aug 2009 16:52:05 +0000 (16:52 +0000)]

Fix possible memmove with a NULL poiunter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29599 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Fri, 28 Aug 2009 16:36:24 +0000 (16:36 +0000)]

Don't coerce a possibly unaligned ptr to a (guint32 *);
Also: Calculate the same template hash whether on a LE or BE machine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29598 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Fri, 28 Aug 2009 16:08:27 +0000 (16:08 +0000)]

Add an example for generating CSV output.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29597 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Fri, 28 Aug 2009 15:59:20 +0000 (15:59 +0000)]

Indicate where the some of the macros are used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29596 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Fri, 28 Aug 2009 13:52:52 +0000 (13:52 +0000)]

Validate a function parameter

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29595 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jmayer [Fri, 28 Aug 2009 09:38:34 +0000 (09:38 +0000)]

After asking on the list and receiving no feedback, I'll
just commit this:

Change the checks for type FT_IPv6 to no longer require
a lenght of exaclty 16 bytes, but something between
0 and 16 bytes. That way, we can filter on prefixes
that do not provide the whole length of 16 bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29594 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 28 Aug 2009 06:21:16 +0000 (06:21 +0000)]

Use GTK+ 2.16.5 and Glib 2.20.4.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29593 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 28 Aug 2009 05:19:52 +0000 (05:19 +0000)]

Compute the loading time and show it in the main status bar.
(Modified code from Didier Gautheron).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29592 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 28 Aug 2009 05:17:14 +0000 (05:17 +0000)]

Make the windows build compile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29591 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Thu, 27 Aug 2009 23:55:48 +0000 (23:55 +0000)]

Properly set our file descriptor when we're capturing from a pipe on
non-Windows systems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29590 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Thu, 27 Aug 2009 16:11:16 +0000 (16:11 +0000)]

We require CMake >= 2.6 so we don't have to repeat the expressions in endif() + friends

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29589 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Thu, 27 Aug 2009 15:55:58 +0000 (15:55 +0000)]

Remove zlib from the set of mandatory packages (it isn't)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29588 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Thu, 27 Aug 2009 15:46:53 +0000 (15:46 +0000)]

Check for INVALID_HANDLE_VALUE instead of NULL on Windows. This keeps
us from feeding a NULL pointer to pcap_compile if we can't open our
pipe. Fix up a couple of error messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29587 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Thu, 27 Aug 2009 15:35:33 +0000 (15:35 +0000)]

Add ConfigureChecks.cmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29586 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Thu, 27 Aug 2009 15:32:57 +0000 (15:32 +0000)]

Move configure checks to ConfigureChecks.cmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29585 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Thu, 27 Aug 2009 11:58:03 +0000 (11:58 +0000)]

Remove the three dots in the menu item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29584 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 27 Aug 2009 06:57:53 +0000 (06:57 +0000)]

make the columns sortable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29583 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 27 Aug 2009 05:34:06 +0000 (05:34 +0000)]

Don't copy const strings, store the pointer in the list store instead,
saves memory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29582 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Thu, 27 Aug 2009 05:17:40 +0000 (05:17 +0000)]

Add #include <stdio.h>

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29581 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Thu, 27 Aug 2009 05:04:29 +0000 (05:04 +0000)]

Windows: remove all references to ICONV_DIR, because we use the statically linked win-iconv instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29580 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Thu, 27 Aug 2009 05:04:05 +0000 (05:04 +0000)]

Add #include <stdio.h>

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29579 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Thu, 27 Aug 2009 04:47:28 +0000 (04:47 +0000)]

Add #include <stdio.h> in a few more places ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29578 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Thu, 27 Aug 2009 03:54:57 +0000 (03:54 +0000)]

Add #include <stdio.h> in a few more places for Solaris.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29577 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Thu, 27 Aug 2009 02:53:13 +0000 (02:53 +0000)]

Add #include <stdio.h> in a few places for Solaris

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29576 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Aug 2009 23:24:22 +0000 (23:24 +0000)]

Add #include <stdio.h> to print.h; Undo the previous change to about_dlg.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29575 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Wed, 26 Aug 2009 23:16:37 +0000 (23:16 +0000)]

Add a compile-time option to use a separate thread for reading from
pipes. Enable this by default on Windows. Remove code that tried to
use WaitForSingleObject on a pipe (which Windows doesn't support). Use
native file handles and system calls on Windows (which fixes a problem
with partial reads I ran into during testing).

This should fix bug 1759.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29574 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Aug 2009 22:45:07 +0000 (22:45 +0000)]

Keep Solaris buildbot happy ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29573 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Wed, 26 Aug 2009 22:31:06 +0000 (22:31 +0000)]

Show correct time value for "Time since previous displayed frame".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29572 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Wed, 26 Aug 2009 19:58:23 +0000 (19:58 +0000)]

Add another theme candidate.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29571 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Aug 2009 19:30:44 +0000 (19:30 +0000)]

Reformat some long lines for readability....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29570 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Aug 2009 19:28:20 +0000 (19:28 +0000)]

#include <stdio.h> no longer req'd.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29569 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Aug 2009 19:27:49 +0000 (19:27 +0000)]

(FWIW) One step towards including stdio.h & stdlib.h only when req'd.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29568 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Wed, 26 Aug 2009 19:17:25 +0000 (19:17 +0000)]

Note that we might want to look at some other themes, to see if any are
more like OS X (especially more like Leopard).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29567 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Aug 2009 17:26:26 +0000 (17:26 +0000)]

From Didier Gautheron:
expert info clean up,
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3948

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29566 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Aug 2009 16:39:34 +0000 (16:39 +0000)]

From dragonlinux AT gmail.com: Fix incorrect location of a right brace;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29565 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

kukosa [Wed, 26 Aug 2009 15:10:31 +0000 (15:10 +0000)]

export t38_add_address, prefer destination port for T.38 conversation searching

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29564 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Aug 2009 13:58:17 +0000 (13:58 +0000)]

Fix some indentation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29563 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Wed, 26 Aug 2009 09:13:14 +0000 (09:13 +0000)]

Make UL grant size a (generated) field of its own (for easier use as a custom column or IO graph filter).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29562 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Wed, 26 Aug 2009 07:26:17 +0000 (07:26 +0000)]

From Thierry Andry via bug 3941:
Added preference to set radius request TTL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29561 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Wed, 26 Aug 2009 07:05:50 +0000 (07:05 +0000)]

Reorder so that mandatory requirements appear in succession

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29560 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Wed, 26 Aug 2009 06:54:48 +0000 (06:54 +0000)]

win-iconv is statically linked as part of Glib >= 2.14.5, so remove it from config.nmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29559 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Aug 2009 05:10:12 +0000 (05:10 +0000)]

From dragonlinux:
Add QNX OS VER 6's qnet ethernet protocol number.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3934

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29558 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Aug 2009 04:37:08 +0000 (04:37 +0000)]

Make it possible to close and reactivate the window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29557 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Aug 2009 04:36:14 +0000 (04:36 +0000)]

From swapnil:
Bug in Traffic Aggregate Description (TAD) IE in Packet-gtpv2.c fixed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3940

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29556 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Aug 2009 02:06:39 +0000 (02:06 +0000)]

Add missing prototype ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29555 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Tue, 25 Aug 2009 23:03:10 +0000 (23:03 +0000)]

Rework code slightly to prevent several GCC "breaking strict-aliasing rules" warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29554 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Tue, 25 Aug 2009 23:01:03 +0000 (23:01 +0000)]

Add missing semicolon.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29553 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Tue, 25 Aug 2009 21:54:12 +0000 (21:54 +0000)]

Init two struct members so gcc 4.1.4 doesn't complain about "may be used uninitialized";
Also: use gboolean for a true/false variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29552 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Aug 2009 21:10:35 +0000 (21:10 +0000)]

From Didier Gautheron:
move custom col set from proto_tree_set_xxx() to
epan_dissect_fill_in_columns().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3930

I'v added the new functions to the .h files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29551 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Tue, 25 Aug 2009 17:55:55 +0000 (17:55 +0000)]

Add more information to the comments at the top of the files we generate.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29550 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Aug 2009 17:22:32 +0000 (17:22 +0000)]

From Mike Morrin:
Minor errors in gsm rr dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3889

Modified accoring to comments from Pascal Quantin(I hope I got it right).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29549 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Tue, 25 Aug 2009 11:01:51 +0000 (11:01 +0000)]

Show CRC errors for RARs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29548 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Tue, 25 Aug 2009 06:11:57 +0000 (06:11 +0000)]

Note in dlist[] that COL_BSSGP_TLLI is deprecated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29547 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Aug 2009 05:42:14 +0000 (05:42 +0000)]

Custom columnfication:

* Deprecate COL_BSSGP_TLLI (GPRS BSSGP IE TLLI). Use bssgp.tlli

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29546 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Tue, 25 Aug 2009 01:01:55 +0000 (01:01 +0000)]

Fix another typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29545 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Mon, 24 Aug 2009 21:38:57 +0000 (21:38 +0000)]

Fix typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29544 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 24 Aug 2009 20:54:25 +0000 (20:54 +0000)]

Make it possible to use bssgp.tlli as custom column.
Remove COL_BSSGP_TLLI and CHECK_COL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29543 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 24 Aug 2009 20:33:49 +0000 (20:33 +0000)]

From Didier Gautheron:
Speed up expert info composite.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3935

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29542 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 24 Aug 2009 18:45:01 +0000 (18:45 +0000)]

Use our own version of gdk_color_to_string if GTK < 2.12

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29541 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Mon, 24 Aug 2009 18:20:20 +0000 (18:20 +0000)]

We no longer need the "ascending arrow" and "descending arrow" images
for clists, as we're not using a clist.

Clean up white space, and use C89 comments rather than C99/C++ comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29540 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 24 Aug 2009 16:11:00 +0000 (16:11 +0000)]

Use list_store isf deprecated clist.
Try to optimize expert_comp_table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29539 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Mon, 24 Aug 2009 15:17:58 +0000 (15:17 +0000)]

Remove unneeded #includes; Clean up indentation; Comment a few "closing braces".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29538 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Mon, 24 Aug 2009 14:30:55 +0000 (14:30 +0000)]

Rework code slightly to prevent a GCC 'breaking strict-aliasing rules' warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29537 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 24 Aug 2009 09:29:05 +0000 (09:29 +0000)]

packet-tcp.c:1551: warning: 'cleared_writable' may be used uninitialized in this function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29536 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 24 Aug 2009 09:05:23 +0000 (09:05 +0000)]

From: : " Michael"

packet-tcp marks a row as unwritable if there is more
than 1 PDU in a packet to prevent overwriting of the
protocol column.

However this breaks the proto,colinfo tap which checks
rows are writable or dies EVEN if it doesn't alter anything.

Suggested patch attached to restore the initial value
after all PDUs have been processed.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3675

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29535 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

kukosa [Mon, 24 Aug 2009 09:05:15 +0000 (09:05 +0000)]

Expert info for undecoded Q.932 and H.450 operations

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29534 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Mon, 24 Aug 2009 08:00:39 +0000 (08:00 +0000)]

From Ivan Sy via bug 3931:
Added ND Proxy Flag for IPv6 RA flag.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29533 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Sun, 23 Aug 2009 23:52:40 +0000 (23:52 +0000)]

Rework code slightly to prevent a GCC 'strict-aliasing' warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29532 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Sun, 23 Aug 2009 19:16:35 +0000 (19:16 +0000)]

From kahou:
Add Fibre Channel Delimiter Dissector for Fibre Channel FC2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29531 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 18:32:29 +0000 (18:32 +0000)]

From Didier gautheron via bug 3929:

* Expert Info / Expert Info Composite requires a full protocol tree.
* Delay tree NULL pointer check in bootp dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29530 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 18:13:03 +0000 (18:13 +0000)]

From Didier gautheron via bug 3929:

* Don't use g_string_chunk_clear(). It is only defined if GLib >= 2.14

From me:

* Whitespace fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29529 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Sun, 23 Aug 2009 17:18:29 +0000 (17:18 +0000)]

From Ivan Sy:
Per RFC 3810 - Multicast Listener Discovery Version 2 (MLDv2) for IPv6,
Add Number of Sources. Also to show Record Type's numeric value and not
just its equivalent.

Cleaned up presentation and included record number as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29528 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Sun, 23 Aug 2009 15:03:28 +0000 (15:03 +0000)]

[Automatic manuf and enterprise-numbers update for 2009-08-23]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29525 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 12:30:48 +0000 (12:30 +0000)]

Custom columnfication:

* Deprecate COL_DELTA_CONV_TIME (Delta time (conversation)). Use tcp.time_delta

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29524 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 12:24:14 +0000 (12:24 +0000)]

Custom columnfication:

* Deprecate COL_REL_CONV_TIME (Relative time (conversation)). Use tcp.time_relative

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29523 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 12:16:10 +0000 (12:16 +0000)]

Custom columnfication:

* Deprecate COL_FR_DLCI (Frame Relay DLCI). Use fr.dlci

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29522 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 11:35:53 +0000 (11:35 +0000)]

Avoid signed/unsigned comparison

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29521 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

tuexen [Sun, 23 Aug 2009 11:30:54 +0000 (11:30 +0000)]

Update list of PPIDs.
This fixes bug 3928.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29520 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 11:13:53 +0000 (11:13 +0000)]

#if 0 col_set_circuit_id(). It isn't being used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29519 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 11:12:12 +0000 (11:12 +0000)]

Custom columfication:

* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29518 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 10:25:51 +0000 (10:25 +0000)]

Custom columfication:

* Deprecate COL_HPUX_DEVID (HP-UX Device ID). Use nettl.devid

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29517 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 10:20:42 +0000 (10:20 +0000)]

Custom columfication:

* Deprecate COL_HPUX_SUBSYS (HP-UX Nettl Subsystem). Use nettl.subsys

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29516 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 09:52:57 +0000 (09:52 +0000)]

Custom columfication:

* Deprecate COL_CIRCUIT_ID (Circuit ID). Use iax2.call

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29515 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

krj [Sun, 23 Aug 2009 09:16:58 +0000 (09:16 +0000)]

Add initial code to handle the migration to custom columns by mapping the deprecated columns into their custom column counterparts when we read the preference file.

There are still many todos in this area:

1) We need to either warn the user that he/she needs to click "Save" in the preference dialog so we can "flush" the old predefined column or apply this change ourself silently.
2) The predefined columns need to be removed from the "Columns" UI.
3) ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29514 f5534014-38df-0310-8fa8-9805f1628bb7

git mirror of the wireshark svn

RSS Atom