14 years agoscsi: unusual scsi protocols can request multiple AHS fields for iscsi so decode...
sahlberg [Sun, 8 Oct 2006 04:13:18 +0000 (04:13 +0000)]
scsi: unusual scsi protocols can request multiple AHS fields for iscsi   so decode the AHS properly instead of assuming at most one field is present

scsi-osd   add dissection of  LIST data pdus  and  CREATE cdb

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19449 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't crash, if airpcap.dll isn't available
ulfl [Sat, 7 Oct 2006 22:41:17 +0000 (22:41 +0000)]
don't crash, if airpcap.dll isn't available

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19448 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoStephen Fisher:
jmayer [Sat, 7 Oct 2006 14:48:04 +0000 (14:48 +0000)]
Stephen Fisher:
packet-cisco-wireless.c is actually trying to dissect WLCCP:

I have attached a dissector I wrote from scratch for the
frames that I'm seeing.  It has #defines for the field offsets and
lengths so it should be easier to merge.  I also attached a sample
capture with one of the frames that I'm seeing.  There are more fields
in the frame I haven't yet figured out, hopefully your dissector has
those that I'm missing.

Me: - Commented in wlccp over udp as well, it works most of the time.
    - Leave the file packet-cisco-wireless.c in for the time being to
      copy over knowledge until no usable info is left in the file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19447 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAlejandro Vaquero:
jmayer [Sat, 7 Oct 2006 14:24:32 +0000 (14:24 +0000)]
Alejandro Vaquero:
Add portaudio v19 support in addition to v18:

   Here is a patch using the API 2 (v19). I tested it only in Windows.
Attached also the Windows v19 zip file used. I did not modify the
Makefile.nmake to download this new version (when running the "setup"),
because Windows v18 it is still good.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19446 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a few packages and fix dissecton of a_codecs and handle the case when
etxrab [Fri, 6 Oct 2006 19:48:00 +0000 (19:48 +0000)]
Add a few packages and fix dissecton of a_codecs and handle the case when
hf_param = -1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19445 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Aaron Campbell:
jake [Fri, 6 Oct 2006 19:18:55 +0000 (19:18 +0000)]
From Aaron Campbell:
The expression (BGP_OSPF_RTYPE_EXT ||BGP_OSPF_RTYPE_NSSA) will always
evaluate to 1.  As well, neither of these constants are defined as flag
values, so a bitwise op was probably not intended either.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19444 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd the u3 packaging directory to the distribution.
gerald [Fri, 6 Oct 2006 17:50:51 +0000 (17:50 +0000)]
Add the u3 packaging directory to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19443 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd airpcap.h to the distribution.
gerald [Fri, 6 Oct 2006 17:39:39 +0000 (17:39 +0000)]
Add airpcap.h to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19442 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove entries for the lua plugin as it's not used any more.
etxrab [Thu, 5 Oct 2006 21:37:45 +0000 (21:37 +0000)]
Remove entries for the lua plugin as it's not used any more.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19441 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agohave the funnel client passing the destructors for btn data structures to the funnel.
lego [Thu, 5 Oct 2006 16:25:13 +0000 (16:25 +0000)]
have the funnel client passing the destructors for btn data structures to the funnel.
Although useless in practice, it is better to implement it this way... the funnel mini gui might be used by other modules in the future.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19440 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake IPPrim based addresses filterable (mirroring ip/udp/tcp filter names).
martinm [Thu, 5 Oct 2006 14:10:10 +0000 (14:10 +0000)]
Make IPPrim based addresses filterable (mirroring ip/udp/tcp filter names).
Add some if (tree) tests to try to avoid doing extra work (large FP captures can be very slow to load).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19439 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPatch in bug 1149, adds DCE-style flag for gss-api
jake [Thu, 5 Oct 2006 11:35:41 +0000 (11:35 +0000)]
Patch in bug 1149, adds DCE-style flag for gss-api

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19438 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoStart to make the output from the dissector more like the actual
etxrab [Wed, 4 Oct 2006 22:49:40 +0000 (22:49 +0000)]
Start to make the output from the dissector more like the actual

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19437 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded the possibillity of Statistic pkg as well.
etxrab [Wed, 4 Oct 2006 22:43:38 +0000 (22:43 +0000)]
Added the possibillity of Statistic pkg as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19436 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake provisional ETHERTYPE dependant on registered ETHERTYPE
jake [Wed, 4 Oct 2006 22:01:58 +0000 (22:01 +0000)]
Make provisional ETHERTYPE dependant on registered ETHERTYPE
Remove preferences stuff
Use stringz for variable length names
Media address size independant
Removed generated item
Set actual length of packet
Make info column work without coloring rules or filters

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19435 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPut back the bugfixes froim Revision 19190/19356
etxrab [Wed, 4 Oct 2006 21:52:35 +0000 (21:52 +0000)]
Put back the bugfixes froim Revision 19190/19356
Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1091

"h248_handle was declared localy, udp port was not added at register.

Added a few more packagenames."

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19434 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix the version.
gerald [Wed, 4 Oct 2006 20:53:18 +0000 (20:53 +0000)]
Fix the version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19433 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMisterious bug with cf_read() solved... had nothing to do with cf_read :)
lego [Wed, 4 Oct 2006 18:45:26 +0000 (18:45 +0000)]
Misterious bug with cf_read() solved... had nothing to do with cf_read :)

the callback data for TextWindow buttons was ep_allocated!
after cf_read() it was reused and so it was rewritten...

fix that making it g_malloced instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19432 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPatch for clean, distclean and maintainer-clean targets for U3 packaging.
gal [Wed, 4 Oct 2006 18:08:51 +0000 (18:08 +0000)]
Patch for clean, distclean and maintainer-clean targets for U3 packaging.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19431 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Martin Peylo:
etxrab [Wed, 4 Oct 2006 18:00:32 +0000 (18:00 +0000)]
From Martin Peylo:

dissector for Enea's LINX protocol?

A protocol spec is available at <http://www.enea.com/templates/Extension____8947.aspx>. The source of the kernel module could be obtained from Enea by sending a request to "linx at enea dot com".

Currently they use ethertype 0x9999 which is not registered at IEEE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19430 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nicolas DICHTEL:
etxrab [Wed, 4 Oct 2006 17:43:52 +0000 (17:43 +0000)]
From Nicolas DICHTEL:
M flag isn't for MCOA, but for HMIP (RFC4140 Section 4.1).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19429 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Martin Warnes:
etxrab [Wed, 4 Oct 2006 17:36:40 +0000 (17:36 +0000)]
From Martin Warnes:
The patch addresses issues with higher precision packet
timings on top end iSeries hardware and should enable the iseries wiretap to handle timings in both micro and nano seconds.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19428 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFinally got it to complie.
etxrab [Wed, 4 Oct 2006 16:02:59 +0000 (16:02 +0000)]
Finally got it to complie.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19427 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomore cleanup... almost there...
lego [Wed, 4 Oct 2006 15:31:31 +0000 (15:31 +0000)]
more cleanup... almost there...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19426 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- wslua_util.c: replace Lua's loadfile and dofile for versions that will try to...
lego [Wed, 4 Oct 2006 14:37:46 +0000 (14:37 +0000)]
- wslua_util.c:  replace Lua's loadfile and dofile for versions that will try to open the file in perscofdir then  dataconfdir if there's no such file in cwd
- wslua_field.c: avoid FieldInfo:__tostring() crashing when the ftype has no val_to_string_repr
- init.lua: inform the user that a packet has been disabled, intead of a cryptic "attemt to call nil"
- Makefile.am: add register_wslua.c and declare_wslua.h to MAINTAINERCLEANFILES
- wslua_gui.c: fix a typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19425 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGot rid of some errors but 1 remains:
etxrab [Wed, 4 Oct 2006 07:18:58 +0000 (07:18 +0000)]
Got rid of some errors but 1 remains:
libui.lib(camel_srt.obj) : error LNK2001: unresolved external symbol _camelSRTt
wireshark.exe : fatal error LNK1120: 1 unresolved externals
NMAKE : fatal error U1077: 'link' : return code '0x460'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19424 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoan attempt to fix the Ubuntu buildbot:
ulfl [Tue, 3 Oct 2006 23:32:51 +0000 (23:32 +0000)]
an attempt to fix the Ubuntu buildbot:

ERROR: files left in build directory after distclean:

Louis, could you have a look - I might have produced a mess :-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19423 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix the memory leak problem mentioned lately by adding and using color_filters_cleanup()
ulfl [Tue, 3 Oct 2006 23:24:48 +0000 (23:24 +0000)]
fix the memory leak problem mentioned lately by adding and using color_filters_cleanup()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19422 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochanges of the coloring rules sometimes crashed as dissection keeps pointers to the...
ulfl [Tue, 3 Oct 2006 22:32:03 +0000 (22:32 +0000)]
changes of the coloring rules sometimes crashed as dissection keeps pointers to the color_filter for later reference -> simply deleting the filters leave the pointers invalid  -> crash.

for now, don't delete the filters but keep them floating around in memory (leaking) -> at least better than crashing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19421 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Florent.Drouin@alcatel.fr:
etxrab [Tue, 3 Oct 2006 22:12:47 +0000 (22:12 +0000)]
From Florent.Drouin@alcatel.fr:
Please find two new TAP for Camel Statistics.
The first one updates  counters related to camel operations. It is located in the GSM submenu. The second one , named Camel Service Response Time, gives the time ellapsed between a couple of camel specifics operations. (For example InitialDP/Continue or InitialDP GPRS/Continue GPRS). With Wireshark, you can have the Min/Max/Mean delay time for your traces files, and with Tshark, you have the additional information for percentile (1%,95% 99% etc )

To enable the use of the Camel statistics, you have 2 new parameters in the preferences,
- SRT, enable the service Response Time calculation.
- persistentSRT, keep the data in a context, even after the  camel session has been closed. This is mandatory with Wireshark, to have a clean display of the stats.

Only the new files checked in for now because of include problems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19420 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago"saying your preferences once ..." -> "applying your preferences once ..."
ulfl [Tue, 3 Oct 2006 21:25:16 +0000 (21:25 +0000)]
"saying your preferences once ..." -> "applying your preferences once ..."

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19419 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAs Stephen Fisher noted, the Apply button should also save the changed settings ...
ulfl [Tue, 3 Oct 2006 21:03:08 +0000 (21:03 +0000)]
As Stephen Fisher noted, the Apply button should also save the changed settings (if the Save button is disabled)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19418 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a bug in the export function
ulfl [Tue, 3 Oct 2006 20:11:08 +0000 (20:11 +0000)]
fix a bug in the export function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19417 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothe whole ARGUMENT_CL mimic isn't required any longer - remove it. This should fix...
ulfl [Tue, 3 Oct 2006 20:01:39 +0000 (20:01 +0000)]
the whole ARGUMENT_CL mimic isn't required any longer - remove it. This should fix compile problems under Unix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19416 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agonow: Don't have a Save button in the following settings dialogs:
ulfl [Tue, 3 Oct 2006 19:53:10 +0000 (19:53 +0000)]
now: Don't have a Save button in the following settings dialogs:

- Edit/Preferences
- View/Coloring Rules
- Capture/Capture Filters
- Analyze/Display Filters
- Analyze/Enabled Protocols

The settings will be automatically saved when pressing the Ok button.

If someone really wants the explicit Save buttons as before - you can get them back at the Edit/Preferences/User Interface page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19415 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Florent.Drouin@alcatel.fr:
etxrab [Tue, 3 Oct 2006 19:24:22 +0000 (19:24 +0000)]
From Florent.Drouin@alcatel.fr:
I did improve the OID management in the tcap dissector.
Now, when a tcap message is reveived, without upper layer, the ACN is saved in the TCAP context, and can be used for the next messages of the dialogue. It is used only when the upper layer session is opened with Tcap only messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19414 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoImplement a real "Cancel" button for the coloring rules dialog - this was a hard...
ulfl [Tue, 3 Oct 2006 18:39:36 +0000 (18:39 +0000)]
Implement a real "Cancel" button for the coloring rules dialog - this was a hard one! It seems to be working without bugs and as designed now.

As this was a huge internal change, new bugs are very probable - please report.

The implementation isn't still perfect, a new dialog internal list could possibly be removed again.

However, I want to check in at this condition, just in case I make things worse - again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19413 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet it to compile...
lego [Tue, 3 Oct 2006 18:38:04 +0000 (18:38 +0000)]
Get it to compile...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19412 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate nmakefile to latest changes.
lego [Tue, 3 Oct 2006 18:24:08 +0000 (18:24 +0000)]
Update nmakefile to latest changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19411 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom David Richards:
etxrab [Tue, 3 Oct 2006 18:11:55 +0000 (18:11 +0000)]
From  David Richards:
numerous changes, most notably:

1) BACnetStatusFlags is bit string, not enum, in NotificationParameters
2) Fixes many places where enclosing context tags were not handled properly.
3) Simplify tag decoding logic.  Change to explicit decoding in many
instances rather
    than read tags in a loop and do a switch based on tag number.  Looping
    ignores out-of-order and other types of tagging errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19410 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMSVCC does not like mixing code and variable declarations
lego [Tue, 3 Oct 2006 18:07:31 +0000 (18:07 +0000)]
MSVCC does not like mixing code and variable declarations

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19409 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd application/media_control+xml
etxrab [Tue, 3 Oct 2006 18:04:15 +0000 (18:04 +0000)]
Add application/media_control+xml

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19408 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoH.248 packages...
lego [Tue, 3 Oct 2006 17:24:28 +0000 (17:24 +0000)]
H.248 packages...

few things to be fixed:
- // comments,
- not every hf_xxx used might be registered

some packages from the current h248 dissector are still missing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19407 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Make sure that the registration files are created whenever there's a change
lego [Tue, 3 Oct 2006 14:27:45 +0000 (14:27 +0000)]
- Make sure that the registration files are created whenever there's a change
- get rid of 5.0.2 stuff
- add the apply_filter() API

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19406 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Add special case for reading strange encoding of ATM CID field
martinm [Tue, 3 Oct 2006 14:21:07 +0000 (14:21 +0000)]
- Add special case for reading strange encoding of ATM CID field
- Indicate direction of DCH Data in info column
- Assume EDCH payload CRC if 2 bytes are left over (previous test was broken)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19405 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomore Lua APIs:
lego [Tue, 3 Oct 2006 12:07:10 +0000 (12:07 +0000)]
more Lua APIs:
- set_filter() : sets the main window filter
- reload() : reloads the current capture file
- copy_to_clipboard() : copies its first arfg to the clipboard
- open_capture_file() : opens a capture file for viewing (still broken)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19404 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher:
etxrab [Tue, 3 Oct 2006 05:50:28 +0000 (05:50 +0000)]
From Stephen Fisher:
always register
itself on the port from the preferences (defaults to 0) upon launch.
This allows the user to right-click and use decode as.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19403 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher:
etxrab [Tue, 3 Oct 2006 05:48:47 +0000 (05:48 +0000)]
From Stephen Fisher:
Modifie the VNC dissector to desegment
the "server cut text" message type for cases where the cut text is in
the next tcp segment from the first part of the message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19402 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix WEP key bug in the AirPcap code that could cause a crash. Enable
gerald [Mon, 2 Oct 2006 23:44:10 +0000 (23:44 +0000)]
Fix WEP key bug in the AirPcap code that could cause a crash.  Enable
AirPcap by default. Add initial support for the "Any" device in AirPcap
(more to come).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19401 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomissing mark -> select changes
ulfl [Mon, 2 Oct 2006 23:11:55 +0000 (23:11 +0000)]
missing mark -> select changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19400 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofurther code cleanup: don't use the term "marked" for the color filters, the right...
ulfl [Mon, 2 Oct 2006 23:01:33 +0000 (23:01 +0000)]
further code cleanup: don't use the term "marked" for the color filters, the right term is "selected". That caused me "concerns" wether the marked feature of the packet list was involved - which is actually not

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19399 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agorefactor apply_color_filter() as it was a bit confusing - it will also be a bit faste...
ulfl [Mon, 2 Oct 2006 21:55:26 +0000 (21:55 +0000)]
refactor apply_color_filter() as it was a bit confusing - it will also be a bit faster now -
and some other minor code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19398 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoinstead of reverting the whole changes by the *first* cancelled dialog box, revert...
ulfl [Mon, 2 Oct 2006 20:59:38 +0000 (20:59 +0000)]
instead of reverting the whole changes by the *first* cancelled dialog box, revert them by clicking "Cancel" on the *last* dialog - this behaviour just makes more sense.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19397 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDo not show the Windows specific message on non-Windows systems.
tuexen [Mon, 2 Oct 2006 19:26:53 +0000 (19:26 +0000)]
Do not show the Windows specific message on non-Windows systems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19396 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoas noted by Anders Broman: the Win2000 version of copy don't like the /d switch
ulfl [Mon, 2 Oct 2006 19:07:01 +0000 (19:07 +0000)]
as noted by Anders Broman: the Win2000 version of copy don't like the /d switch

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19395 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't show Tools menu at all if Lua not present
martinm [Mon, 2 Oct 2006 13:38:13 +0000 (13:38 +0000)]
Don't show Tools menu at all if Lua not present

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19394 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet correct length for extensions root
martinm [Mon, 2 Oct 2006 10:49:57 +0000 (10:49 +0000)]
Set correct length for extensions root

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19393 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agovarious (huge) code cleanup incl. splitting of the coloring dialog and the actual...
ulfl [Mon, 2 Oct 2006 00:13:14 +0000 (00:13 +0000)]
various (huge) code cleanup incl. splitting of the coloring dialog and the actual color rule edit dialog into two files - this makes the things much more clearer now (at least for me)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19392 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf the Cancel button was clicked and another filter dialog is still open - yes that...
ulfl [Sun, 1 Oct 2006 19:34:03 +0000 (19:34 +0000)]
If the Cancel button was clicked and another filter dialog is still open - yes that's possible - reverse the changes on it as well to reflect the current internal list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19391 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange the filter dialog (capture and display filters), so it has a real Cancel butto...
ulfl [Sun, 1 Oct 2006 17:59:30 +0000 (17:59 +0000)]
Change the filter dialog (capture and display filters), so it has a real Cancel button now - the former Close button didn't reverted the changes done.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19390 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix for header digest detection being broken when AHS is used.
sahlberg [Sat, 30 Sep 2006 21:49:11 +0000 (21:49 +0000)]
fix for header digest detection being broken when AHS is used.

we simply forgot to account for the AHS when testing to calculate the crc

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19389 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd dissection of the cdb for service action LIST
sahlberg [Sat, 30 Sep 2006 21:08:27 +0000 (21:08 +0000)]
add dissection of the cdb for service action LIST
(but no decoding of the data in yet)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19388 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothe ahs length inside the AHS for an extended cdb includes the reserved byte before...
sahlberg [Sat, 30 Sep 2006 20:40:04 +0000 (20:40 +0000)]
the ahs length inside the AHS for an extended cdb includes the reserved byte before the start of cdb data

account for this extra reserved byte in the ahs length so that the reconstructed cdb has the correct length and does not contain one extra byte at the end

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19387 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a typo
ulfl [Sat, 30 Sep 2006 18:30:43 +0000 (18:30 +0000)]
fix a typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19386 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Reinhard Speyerer:
etxrab [Sat, 30 Sep 2006 15:50:38 +0000 (15:50 +0000)]
From Reinhard Speyerer:
Update asn1/umts_rrc*/Makefile
for the renamed asn2eth.py -> asn2wrs.py.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19385 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a missing #include
ulfl [Sat, 30 Sep 2006 14:57:50 +0000 (14:57 +0000)]
add a missing #include

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19384 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoA new field information flag, FI_URL, to indicate a field contains a URL.
gal [Sat, 30 Sep 2006 14:37:09 +0000 (14:37 +0000)]
A new field information flag, FI_URL, to indicate a field contains a URL.
This is used to display the field underlined and to allow the user to double-click on it (like FT_FRAMENUM) to open the URL in the configured browser.
Example usage in the x509ce and logotype certificate extensions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19383 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove compiler warnings
ulfl [Sat, 30 Sep 2006 13:40:36 +0000 (13:40 +0000)]
remove compiler warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19382 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowe don't need to .. the dirs for the clean targets here
ulfl [Sat, 30 Sep 2006 13:25:05 +0000 (13:25 +0000)]
we don't need to .. the dirs for the clean targets here

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19381 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate for latest lua changes.
gal [Sat, 30 Sep 2006 12:58:52 +0000 (12:58 +0000)]
Update for latest lua changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19380 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago add dissection of SCSI OSD CREATE PARTITION
sahlberg [Sat, 30 Sep 2006 10:24:23 +0000 (10:24 +0000)]
 add dissection of SCSI OSD CREATE PARTITION

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19379 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofinish off the remainder of FORMAT OSD for scsi osd dissector
sahlberg [Sat, 30 Sep 2006 10:08:43 +0000 (10:08 +0000)]
finish off the remainder of FORMAT OSD   for scsi osd dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19378 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago"Pluggable custom makefile"
ulfl [Sat, 30 Sep 2006 09:45:51 +0000 (09:45 +0000)]
"Pluggable custom makefile"
A custom plugin (not yet to be released to the public) can be added to Makefile.nmake easily. But this has a drawback:
The modified Makefile.nmake appears as a modified file in the commit list and in generated patches (this annoyed me for years).

To solve this I've added a plugin like mechanism which calls a Custom.nmake file for each target (if the file is existing). I've also added a Custom.nmake.example for a quick start.

I don't know how to do this for the Makefile.am, so I leave this as an exercise for the interested reader ;-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19377 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoscsi osd updates
sahlberg [Sat, 30 Sep 2006 09:34:58 +0000 (09:34 +0000)]
scsi osd updates

iscsi: when iscsi transfers a cdb that is alrger than 16 bytes,  the first 16 bytes are transferred in the normal place in the header and ther remainder of the cdb is transported inside the AHS.

reassemble these cdb into a proper tvb before passing it to the scsi dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19376 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove a warning
ulfl [Sat, 30 Sep 2006 09:15:15 +0000 (09:15 +0000)]
remove a warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19375 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd an extra_data pointer to the itlq structure where specific commandsets/cdbs can...
sahlberg [Sat, 30 Sep 2006 04:10:28 +0000 (04:10 +0000)]
add an extra_data pointer to the itlq structure where specific commandsets/cdbs can hang additional data that are unique to that commandset/cdb

make the scsi osd service action and getsetattributetype use this facility

furhter enhancements to scsi osd

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19374 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoscsi opcode 0x7f is variable length so dont clamp the cdb length to 16 bytes
sahlberg [Sat, 30 Sep 2006 01:01:57 +0000 (01:01 +0000)]
scsi opcode 0x7f is variable length   so dont clamp the cdb length to 16 bytes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19373 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothat wasn't a typo, xcopy can't rename files that way
ulfl [Sat, 30 Sep 2006 00:45:03 +0000 (00:45 +0000)]
that wasn't a typo, xcopy can't rename files that way

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19372 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoscsi osd additions
sahlberg [Sat, 30 Sep 2006 00:31:36 +0000 (00:31 +0000)]
scsi osd additions

we also need to track the serviceaction in the itlq structure so we can decode the data in/out properly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19371 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Stephen Fisher:
ulfl [Fri, 29 Sep 2006 22:48:38 +0000 (22:48 +0000)]
from Stephen Fisher:

Attached is a patch for consideration that changes the title in the
preferences notebook to be the full description of the preference (but
leaves the short name in the preferences list on the left).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19370 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix the context menu "Protocol Preferences" bug AGAIN (bug introduced again in 19291)
ulfl [Fri, 29 Sep 2006 22:40:55 +0000 (22:40 +0000)]
fix the context menu "Protocol Preferences" bug AGAIN (bug introduced again in 19291)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19369 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMSVC doesn't like empty array inits
ulfl [Fri, 29 Sep 2006 21:53:54 +0000 (21:53 +0000)]
MSVC doesn't like empty array inits

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19368 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse #defines from packet-ber.h rather than asn1.h change default ports to Zero.
etxrab [Fri, 29 Sep 2006 21:27:58 +0000 (21:27 +0000)]
Use #defines from packet-ber.h rather than asn1.h change default ports to Zero.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19367 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate Diamater and Radius AVP:s
etxrab [Fri, 29 Sep 2006 21:26:27 +0000 (21:26 +0000)]
Update Diamater and Radius AVP:s

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19366 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 1133:
jake [Fri, 29 Sep 2006 19:39:40 +0000 (19:39 +0000)]
Fix for bug 1133:
add a test for (length > 0) in the dissector (dissect_xot_pdu), to avoid to
allocate a new tvb when the XOT decoded length is null.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19365 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDissect Via header
martinm [Fri, 29 Sep 2006 17:35:23 +0000 (17:35 +0000)]
Dissect Via header

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19364 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nicolas DICHTEL:
jake [Fri, 29 Sep 2006 16:31:52 +0000 (16:31 +0000)]
From Nicolas DICHTEL:
Please find enclosed a patch about Mobile Network Prefix option in NEMO.
Following RFC3963 Section 4.3, lenght of this option is 18, not 16.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19363 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a missing heuristic to acept a NOP_IN packet and correct a broken heuristic that...
sahlberg [Fri, 29 Sep 2006 11:12:18 +0000 (11:12 +0000)]
add a missing heuristic to acept a NOP_IN packet and correct a broken heuristic that would refuse all NOP_OUT pdus as non-iscsi

it is absolutely amazing that none of the iscsi implementors and users of wireshark had noticed this breakage and reported it.   they apparently do not use wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19362 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Reinhard Speyerer:
kukosa [Fri, 29 Sep 2006 11:09:17 +0000 (11:09 +0000)]
From Reinhard Speyerer:
patch fixes a small typo in epan/dissectors/packet-per.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19361 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd initial scsi osd dissector but only dissect sdbs that are impoerted from SPC
sahlberg [Fri, 29 Sep 2006 10:40:51 +0000 (10:40 +0000)]
add initial scsi osd dissector  but only dissect sdbs that are impoerted from SPC

various changes to the existing scsi dissector to start allowing different commandsets to be implemented in their own dissector files to prevent the scsi dissector to become as huge as the parlay dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19360 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomove the defines for SPC command opcode values to the headerfile
sahlberg [Fri, 29 Sep 2006 09:24:51 +0000 (09:24 +0000)]
move the defines for SPC command opcode values to the headerfile

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19359 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom: Rolf Fiedler
jake [Fri, 29 Sep 2006 08:47:51 +0000 (08:47 +0000)]
From: Rolf Fiedler
So far Wireshark complained about channel 129, now it gets a little further
and then complains about channel 128.

Solution: Open up all channel from 128 up.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19358 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFixa a typo copy -> xcopy
etxrab [Fri, 29 Sep 2006 05:53:47 +0000 (05:53 +0000)]
Fixa a typo copy -> xcopy

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19357 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some more package names.
etxrab [Fri, 29 Sep 2006 05:52:41 +0000 (05:52 +0000)]
Add some more package names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19356 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate some value_strings
etxrab [Fri, 29 Sep 2006 05:51:44 +0000 (05:51 +0000)]
Update some value_strings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19355 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Martin Peylo:
etxrab [Fri, 29 Sep 2006 05:50:41 +0000 (05:50 +0000)]
From Martin Peylo:

- dissection of TIPCv2 internal messages now shows
  all fields used according to the protocol spec
- there should be no issues with the current protocol
  spec anymore
- the info column is more concise and gives more
- some code beautifications

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19354 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Rolf Fiedler:
jake [Thu, 28 Sep 2006 20:28:26 +0000 (20:28 +0000)]
From Rolf Fiedler:
I am the author of the eyesdn wiretap module. Recently we added ATM
support to our trace format. We used channel id 129 for that, so far
only 0 for D channel and 1-30 for bearer channels had been in use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19353 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Stephen Fisher:
ulfl [Thu, 28 Sep 2006 19:53:11 +0000 (19:53 +0000)]
from Stephen Fisher:

Attached is a patch to fix some spelling mistakes in the Wireshark
User's Guide.  I also fixed the author's email addresses as the
addresses did not match the right names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19352 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nicolas DICHTEL:
jake [Thu, 28 Sep 2006 16:30:20 +0000 (16:30 +0000)]
From Nicolas DICHTEL:
I've two patchs for FMIPv6:
- FBU encapsulated in FNA are not correctly parsed;
- there is an error when parsing LLA Option.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19351 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom stephen fisher:
sahlberg [Thu, 28 Sep 2006 16:29:18 +0000 (16:29 +0000)]
From stephen fisher:

I have figured out one of the fields in the MAPI
EcRRegisterPushNotification packet.  The field is a UDP port number that
the client wants the Exchange server to send new mail notifications on.
These notifications are on a port > 1023 and are always 8 bytes long.

It looks like I would add the function name to the
dcerpc_mapi_dissectors[] for the register push notification.  What would
my new function need to do besides display the field?



Here is a patch to add this functionality.  It displays the notification
port and the notification payload (not sure what the payload itself
means yet).  It also dynamically registers each notification port found
with a new dissector (that I called newmail for lack of a better name -
I'm open to suggestions) that displays the notification payload.  This
is all undocumented by Microsoft in their usual fashion.

I also changed the code to always display the mapi.opnum field;
currently, the mapi.opnum is only displayed when the
dcerpc_mapi_dissector is null.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19350 f5534014-38df-0310-8fa8-9805f1628bb7