14 years agoFrom Roger Gottsponer:
jake [Sun, 29 Oct 2006 19:14:31 +0000 (19:14 +0000)]
From Roger Gottsponer:
During troubleshooting an ARP problem, I found an issue with wireshark
to properly recognise Gratuitous ARP packets. Gratuitous ARP packets
can be made with ARP request or ARP reply packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19731 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoput every python script name into "" so the call won't fail on Win32 native python.
ulfl [Sun, 29 Oct 2006 17:19:52 +0000 (17:19 +0000)]
put every python script name into "" so the call won't fail on Win32 native python.

The problem is the slash in e.g.:

 @$(PYTHON) ../../tools/make-dissector-reg.py

is interpreted as an option instead of being part of the path.

I didn't wanted to use backslashes as this might introduce new problems with cygwin's python port.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19730 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Sake Blok:
ulfl [Sun, 29 Oct 2006 17:14:13 +0000 (17:14 +0000)]
from Sake Blok:

While I was reading the development guide I noticed a few typo's.
The attached patch fixes them (the patch is against revision 19724).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19729 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange the default GTK version from GTK2.6 to GTK2.8
ulfl [Sun, 29 Oct 2006 14:41:16 +0000 (14:41 +0000)]
change the default GTK version from GTK2.6 to GTK2.8

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19728 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomake the checksum fields visible for TCP and UDP
ulfl [Sun, 29 Oct 2006 13:53:07 +0000 (13:53 +0000)]
make the checksum fields visible for TCP and UDP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19727 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #1188: scroll the packet list to the bottom (in a running capture) *after* thawin...
ulfl [Sun, 29 Oct 2006 12:51:15 +0000 (12:51 +0000)]
fix #1188: scroll the packet list to the bottom (in a running capture) *after* thawing the list - otherwise the scrolling won't be done correctly

this one should go into 0.99.4 IMHO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19726 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher:
jake [Sun, 29 Oct 2006 11:50:30 +0000 (11:50 +0000)]
From Stephen Fisher:
Attached is a patch to allow the disabling of the UDP/UDPlite checksum
verification for cards that offload it and report it incorrectly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19725 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a glossy highlight.
gerald [Sun, 29 Oct 2006 05:55:04 +0000 (05:55 +0000)]
Add a glossy highlight.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19724 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe TCP options data is a byte array, not a character string.
guy [Sun, 29 Oct 2006 00:06:02 +0000 (00:06 +0000)]
The TCP options data is a byte array, not a character string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19723 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBased on RFC3488. This is a setup for RGMP dissection, a simple protocol bolted on...
jake [Sat, 28 Oct 2006 21:52:38 +0000 (21:52 +0000)]
Based on RFC3488. This is a setup for RGMP dissection, a simple protocol bolted on IGMP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19722 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Pierre Juhen:
jake [Sat, 28 Oct 2006 21:32:38 +0000 (21:32 +0000)]
From Pierre Juhen:
I would like to have a tcp.options field with a name for PMDL output;
I include a patch to packet-tcp.c to provide that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19721 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet AirpcapLoaded to TRUE if we've successfully loaded our DLL and obtained
gerald [Fri, 27 Oct 2006 20:33:19 +0000 (20:33 +0000)]
Set AirpcapLoaded to TRUE if we've successfully loaded our DLL and obtained
our addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19720 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAllow each program called by the Docbook Makefile to be specified using
gerald [Fri, 27 Oct 2006 19:15:57 +0000 (19:15 +0000)]
Allow each program called by the Docbook Makefile to be specified using
the environment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19719 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCast away most remaining warnings.
martinm [Fri, 27 Oct 2006 14:36:48 +0000 (14:36 +0000)]
Cast away most remaining warnings.
2 will remain, because the 'needle' arg in tvb_pbrk_guint8() isn't const...  Should it be?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19717 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore warnings
martinm [Fri, 27 Oct 2006 13:03:38 +0000 (13:03 +0000)]
More warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19716 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix the GTK-WIMP paths for GTK2.8 - both source and destination paths completely...
ulfl [Fri, 27 Oct 2006 12:06:13 +0000 (12:06 +0000)]
fix the GTK-WIMP paths for GTK2.8 - both source and destination paths completely changed from 2.6 to 2.8 due to the integration of Wimp into the main GTK repository

remove settings for GTK2.2 and 2.4 in config.nmake - as no one uses it IMHO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19715 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen key length wrong, show expected value.
martinm [Fri, 27 Oct 2006 10:16:22 +0000 (10:16 +0000)]
When key length wrong, show expected value.
Fix Preference label where %d was missing from specifier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19714 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a lot of sanity checks, particularly to get_airpcap_interface_list(),
gerald [Thu, 26 Oct 2006 21:53:30 +0000 (21:53 +0000)]
Add a lot of sanity checks, particularly to get_airpcap_interface_list(),
which should fix bug 1176.  Fix up whitespace and indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19712 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix more Ubuntu warnings.
etxrab [Thu, 26 Oct 2006 21:31:48 +0000 (21:31 +0000)]
Fix more Ubuntu warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19711 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore warnings...
martinm [Thu, 26 Oct 2006 17:03:45 +0000 (17:03 +0000)]
More warnings...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19710 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to declare and cast away warnings
martinm [Thu, 26 Oct 2006 16:52:55 +0000 (16:52 +0000)]
Try to declare and cast away warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19709 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOnly include the license text and not the rest of the source file
jmayer [Thu, 26 Oct 2006 16:39:34 +0000 (16:39 +0000)]
Only include the license text and not the rest of the source file
it was copied from as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19708 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrederic.heem:
jmayer [Thu, 26 Oct 2006 15:36:50 +0000 (15:36 +0000)]
  Update/Add FindPCAP.cmake CMakeInstallDirs.cmake CMakeLists.txt

  Fix a typo, change gcc flags to mimic the behaviour of autofoo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19707 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't include /usr/local if usage of /usr/local has been disabled via
jmayer [Thu, 26 Oct 2006 14:50:03 +0000 (14:50 +0000)]
Don't include /usr/local if usage of /usr/local has been disabled via
configure option.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19706 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Xiaoguang Liu
jake [Thu, 26 Oct 2006 14:36:09 +0000 (14:36 +0000)]
From Xiaoguang Liu
In wireshark a NTP field is displayed as "clock dispersion".
But should it be called "root dispersion" as per RFC 1305?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19705 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCast away remaining warnings seen on buildbot
martinm [Thu, 26 Oct 2006 12:45:14 +0000 (12:45 +0000)]
Cast away remaining warnings seen on buildbot

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19704 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMention the 64-bit-integer accessors.
guy [Thu, 26 Oct 2006 10:27:16 +0000 (10:27 +0000)]
Mention the 64-bit-integer accessors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19703 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHopefully zap some warnings
martinm [Thu, 26 Oct 2006 10:11:09 +0000 (10:11 +0000)]
Hopefully zap some warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19702 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobreak request/response matching to track transactions out from the CONTROL handler...
sahlberg [Thu, 26 Oct 2006 08:37:39 +0000 (08:37 +0000)]
break request/response matching to track transactions out from the CONTROL handler to use the same code for ALL pdu types

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19701 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoslightly improve info column output
ulfl [Thu, 26 Oct 2006 08:08:13 +0000 (08:08 +0000)]
slightly improve info column output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19700 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoput python script name in brackets
ulfl [Thu, 26 Oct 2006 08:07:13 +0000 (08:07 +0000)]
put python script name in brackets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19699 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom stephen f fix for 1040
sahlberg [Thu, 26 Oct 2006 07:45:01 +0000 (07:45 +0000)]
from stephen f    fix for 1040

Attached is a patch to fix bug #1040: "imap packet: not all infos are
displayed."  It has been tested against the capture file the user
provided as well as my own capture of an imap session.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19698 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoupdate of shaun j's detains
sahlberg [Thu, 26 Oct 2006 07:34:22 +0000 (07:34 +0000)]
update of shaun j's detains

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19697 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMissed a change.
etxrab [Thu, 26 Oct 2006 07:34:10 +0000 (07:34 +0000)]
Missed a change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19696 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPreparations for using the latest GTK 2.8 files for now only gettext is updated.
etxrab [Thu, 26 Oct 2006 07:25:07 +0000 (07:25 +0000)]
Preparations for using the latest GTK 2.8 files for now only gettext is updated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19695 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't use custom build buttons for standard tasks like: Ok, Apply, Cancel.
ulfl [Thu, 26 Oct 2006 00:39:05 +0000 (00:39 +0000)]
don't use custom build buttons for standard tasks like: Ok, Apply, Cancel.

It might be a good idea to add tooltips to the various GUI elements - this makes understanding the GUI *much* faster.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19694 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothe labels of the airpcap toolbar, e.g. "Not a valid Wireless Interface" are pretty...
ulfl [Wed, 25 Oct 2006 23:54:56 +0000 (23:54 +0000)]
the labels of the airpcap toolbar, e.g. "Not a valid Wireless Interface" are pretty misleading. I've changed it to "AirPcap interface: Not selected" which might be more helpful

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19693 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove some unused asn1 code(not in spec) to get rid of some Ubuntu warnings.
etxrab [Wed, 25 Oct 2006 22:09:48 +0000 (22:09 +0000)]
Remove some unused asn1 code(not in spec) to get rid of some Ubuntu warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19688 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUnreffing rci->cursor_pixbuf should cause the pixbuf to be released, so
guy [Wed, 25 Oct 2006 19:48:54 +0000 (19:48 +0000)]
Unreffing rci->cursor_pixbuf should cause the pixbuf to be released, so
null out the pointer to it.  This prevents a freed pixbuf from being

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19687 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix Id marking
etxrab [Wed, 25 Oct 2006 19:26:58 +0000 (19:26 +0000)]
Fix Id marking

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19686 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInclude the top-level header for CoreFoundation, to see whether it'll
guy [Wed, 25 Oct 2006 18:25:17 +0000 (18:25 +0000)]
Include the top-level header for CoreFoundation, to see whether it'll
fix a build failure I've seen on L**p*rd.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19685 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd more paranoid pointer checks. Fixes CID 219.
gerald [Wed, 25 Oct 2006 17:00:33 +0000 (17:00 +0000)]
Add more paranoid pointer checks.  Fixes CID 219.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19684 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAllow DCT2000 support to find a couple of more protocols.
martinm [Wed, 25 Oct 2006 16:46:27 +0000 (16:46 +0000)]
Allow DCT2000 support to find a couple of more protocols.
Try to squash some warnings seen on the ubuntu buildbot log

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19683 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch Coverity CID 220. Fix up whitespace.
gerald [Wed, 25 Oct 2006 16:39:19 +0000 (16:39 +0000)]
Squelch Coverity CID 220.  Fix up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19682 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher
jake [Wed, 25 Oct 2006 15:22:39 +0000 (15:22 +0000)]
From Stephen Fisher
Attached is a patch to fix bug #1170: "Wireshark interpretation of WBXML
does not comply with Spec."  This has been verified with the sample
capture the user provided.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19681 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix bug 1085 -- handle the various ways that a radiotap frame can
gram [Wed, 25 Oct 2006 15:16:49 +0000 (15:16 +0000)]
Fix bug 1085 --  handle the various ways that a radiotap frame can
have an FCS. Also, clean up the parsing and presentation of the various
flags, and show some that aren't already shown.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19680 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoClean up some compiler warnings.
guy [Wed, 25 Oct 2006 03:03:53 +0000 (03:03 +0000)]
Clean up some compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19679 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAttempt to squelch Coverity CID 221.
gerald [Wed, 25 Oct 2006 00:49:36 +0000 (00:49 +0000)]
Attempt to squelch Coverity CID 221.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19678 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAttempt to get compilation working under Windows.
gerald [Wed, 25 Oct 2006 00:17:28 +0000 (00:17 +0000)]
Attempt to get compilation working under Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19677 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Reinhard Speyerer:
etxrab [Tue, 24 Oct 2006 22:06:34 +0000 (22:06 +0000)]
From Reinhard Speyerer:
Fixes the incorrect decoding of the CC-SETUP CLIR suppression and invoke info elements (which seem to have been copied from the location update accept PDU).

and added some info from a later spec.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19675 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPut a trailing ellipsis behind the wireless toolbar buttons since they open
gerald [Tue, 24 Oct 2006 21:07:05 +0000 (21:07 +0000)]
Put a trailing ellipsis behind the wireless toolbar buttons since they open
a new window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19673 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoParts of http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1179
jmayer [Tue, 24 Oct 2006 17:39:32 +0000 (17:39 +0000)]
Parts of bugs.wireshark.org/bugzilla/show_bug.cgi?id=1179

Frederic Heem:
* More cmake system checks. It compiles dumpcap without running configure,

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19672 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoImprove the documentation generators
lego [Tue, 24 Oct 2006 17:34:17 +0000 (17:34 +0000)]
Improve the documentation generators
add some docs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19671 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHave Lua disabled by default.
lego [Tue, 24 Oct 2006 13:16:57 +0000 (13:16 +0000)]
Have Lua disabled by default.

Add more documentation to the code.
change make-dco.pl so that it creates more readable docbook output.

This should be copied over to 0.99.4

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19670 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoby popular request
sahlberg [Tue, 24 Oct 2006 07:27:32 +0000 (07:27 +0000)]
by popular request
reintroducing the ACK_RTT   measurement how long it took to ACK a data segment

Gerald   this is a trivially correct patch   can you apply it to the release branch?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19669 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alejandro Vaquero:
etxrab [Tue, 24 Oct 2006 05:21:00 +0000 (05:21 +0000)]
From Alejandro Vaquero:
For the Radius dissector to add statistics
 in the "Service Response Time" menu and the tshark stats.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19668 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alejandro Vaquero:
jake [Tue, 24 Oct 2006 05:17:49 +0000 (05:17 +0000)]
From Alejandro Vaquero:
Find attached a patch for this bug. The problem was actually in the "Voip Calls" logic, when the first RTP packet was after the last signaling packet (e.g. a call connected and the release not captured), that caused the RTP to not be added to the graph list and therefor to the player.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19667 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 1178. Allow FT_?INT24 BASE_DEC VALs in the expression selection dialog.
jake [Mon, 23 Oct 2006 22:43:11 +0000 (22:43 +0000)]
Fix for bug 1178. Allow FT_?INT24 BASE_DEC VALs in the expression selection dialog.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19666 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd support for dissecting RSVP E2E IGNORE proto packets (RFC3175)
ashokn [Mon, 23 Oct 2006 17:32:15 +0000 (17:32 +0000)]
Add support for dissecting RSVP E2E IGNORE proto packets (RFC3175)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19665 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Fix problems with parsing sctpprim headers
martinm [Mon, 23 Oct 2006 17:22:20 +0000 (17:22 +0000)]
- Fix problems with parsing sctpprim headers
- Add dissection of nbap (as encap or inside sctp primitive)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19664 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse G_GINT64_CONSTANT to handle 64-bit constants in the code.
tuexen [Mon, 23 Oct 2006 17:12:48 +0000 (17:12 +0000)]
Use G_GINT64_CONSTANT to handle 64-bit constants in the code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19663 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAs proposed by Tim Furlong:
lego [Mon, 23 Oct 2006 14:57:54 +0000 (14:57 +0000)]
As proposed by Tim Furlong:
set starttm.tm_isdst to -1 to have mktime() propperly interpret DST.
Might fix Bug 1158

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19662 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher:
jake [Mon, 23 Oct 2006 05:30:37 +0000 (05:30 +0000)]
From Stephen Fisher:
Here is a patch to make a few small fixes to packet-wlccp.c:

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19661 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix bug 1173, remove the space after the comma in CSV lines
jake [Sun, 22 Oct 2006 14:28:54 +0000 (14:28 +0000)]
Fix bug 1173, remove the space after the comma in CSV lines

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19660 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a dissector table for class specific control input/output pdus
sahlberg [Sun, 22 Oct 2006 11:49:23 +0000 (11:49 +0000)]
add a dissector table for class specific control input/output pdus

implement class specific control commands : reset and getmaxlun for mass storage

now with a better understanding of the problem space for usb and device classes we can start cleaning the code up and make it nice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19659 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd tracking of interface class for CONTROL_INPUT as well as existing support for...
sahlberg [Sun, 22 Oct 2006 09:38:59 +0000 (09:38 +0000)]
add tracking of interface class for CONTROL_INPUT as well as existing support for BULK INPUT/OUTPUT

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19658 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix some endianess issues
sahlberg [Sun, 22 Oct 2006 05:21:37 +0000 (05:21 +0000)]
fix some endianess issues

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19657 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodissect the individual bits in the CONFIDURATION descriptor field for the endpoint...
sahlberg [Sun, 22 Oct 2006 01:21:20 +0000 (01:21 +0000)]
dissect the individual bits in the CONFIDURATION descriptor field for the endpoint address

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19656 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a tcp_tree field to packet_info so that we can access the tree from tcp_dissect_p...
sahlberg [Sun, 22 Oct 2006 00:21:40 +0000 (00:21 +0000)]
add a tcp_tree field to packet_info so that we can access the tree from tcp_dissect_pdus() (and others if need be)

in tcp_dissect_pdus()  add a field ( tcp.pdu.size ) to the tree that displays the pdu size.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19655 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoteach the http header dissector how to handle integer fields instead of just assuming...
sahlberg [Sat, 21 Oct 2006 22:17:43 +0000 (22:17 +0000)]
teach the http header dissector how to handle integer fields instead of just assuming everything is a string field

change http.content_length to be FT_UINT32

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19654 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPut the ", " before the PortAudio item regardless of whether we have
guy [Sat, 21 Oct 2006 17:48:45 +0000 (17:48 +0000)]
Put the ", " before the PortAudio item regardless of whether we have
PortAudio or not; this fixes 1174.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19653 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothe text in the about box license page was hard to read because of line breaks at...
ulfl [Sat, 21 Oct 2006 12:06:26 +0000 (12:06 +0000)]
the text in the about box license page was hard to read because of line breaks at the wrong places.

set the minimum size of the widget to 600 pixels - this is working well on my machine. If anyone has problems even with this width (e.g. because of using a larger font) we might increase the size even further.

Of course, this increases the overall size of the about dialog, but the other tabs seem to be working well with it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19652 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove two packaging warnings - could this be applied to 0.99.4?
ulfl [Sat, 21 Oct 2006 09:40:18 +0000 (09:40 +0000)]
remove two packaging warnings - could this be applied to 0.99.4?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19651 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothe flags are FT_BOOLEAN not FT_UINT8
sahlberg [Sat, 21 Oct 2006 05:07:48 +0000 (05:07 +0000)]
the flags are FT_BOOLEAN not FT_UINT8

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19650 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoprettify the flags field and power consumption for CONFIGURATION DESCRIPTOR
sahlberg [Sat, 21 Oct 2006 04:57:12 +0000 (04:57 +0000)]
prettify the flags field and power consumption for CONFIGURATION DESCRIPTOR

dissect the self-powered and the remote-wakeup flags
show the powerconsumption in mA

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19649 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAirPcap fixes from Giorgio Tino:
gerald [Fri, 20 Oct 2006 23:22:53 +0000 (23:22 +0000)]
AirPcap fixes from Giorgio Tino:

1) When choosing to Merge, Import or Keep decryption keys,  key lists will be saved to the preferences file AND into the registry.

2) Now if you check/uncheck the WEP deccryption checkbox in the Preferences..., the AirPcap toolbar will be modified as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19646 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMS usually calls this a build number, not a patch (e.g. see the system version info)
ulfl [Fri, 20 Oct 2006 20:21:52 +0000 (20:21 +0000)]
MS usually calls this a build number, not a patch (e.g. see the system version info)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19643 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't fail to create an installer if LUA_DIR or NET_SNMP_DIR are not defined (both...
ulfl [Fri, 20 Oct 2006 20:06:44 +0000 (20:06 +0000)]
don't fail to create an installer if LUA_DIR or NET_SNMP_DIR are not defined (both optional)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19642 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't display the Play button if we're not built with the RTP player.
guy [Fri, 20 Oct 2006 20:05:27 +0000 (20:05 +0000)]
Don't display the Play button if we're not built with the RTP player.

In tests for whether we're built with the RTP player, test
HAVE_LIBPORTAUDIO first - hopefully we can eventually get rid of the
test for the GTK+ version number.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19641 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCatch an infinite loop. Fixes bug 1172.
gerald [Fri, 20 Oct 2006 19:37:11 +0000 (19:37 +0000)]
Catch an infinite loop.  Fixes bug 1172.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19640 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher: put a newline at the end, to squelch warnings.
guy [Fri, 20 Oct 2006 19:29:41 +0000 (19:29 +0000)]
From Stephen Fisher: put a newline at the end, to squelch warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19639 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOne more Ethereal -> Wireshark name change
jake [Fri, 20 Oct 2006 19:19:33 +0000 (19:19 +0000)]
One more Ethereal -> Wireshark name change

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19638 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLine up the colons in the list of configure options.
guy [Fri, 20 Oct 2006 18:51:51 +0000 (18:51 +0000)]
Line up the colons in the list of configure options.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19637 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of a duplicate call.
guy [Fri, 20 Oct 2006 18:49:02 +0000 (18:49 +0000)]
Get rid of a duplicate call.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19636 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPut the period into ITU-T Recommendation names.
guy [Fri, 20 Oct 2006 18:41:40 +0000 (18:41 +0000)]
Put the period into ITU-T Recommendation names.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19635 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd #defines for the column numbers, and use them.
guy [Fri, 20 Oct 2006 18:36:42 +0000 (18:36 +0000)]
Add #defines for the column numbers, and use them.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19634 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoClean up indentation.
guy [Fri, 20 Oct 2006 18:18:50 +0000 (18:18 +0000)]
Clean up indentation.

Fix typos.

Null out "pa_stream" when the stream is closed; this appears to prevent
some crashes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19633 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't destroy something if it doesn't exist.
guy [Fri, 20 Oct 2006 17:56:21 +0000 (17:56 +0000)]
Don't destroy something if it doesn't exist.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19632 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't pass an uninitialized string to gtk_widget_create_pango_layout();
guy [Fri, 20 Oct 2006 17:47:28 +0000 (17:47 +0000)]
Don't pass an uninitialized string to gtk_widget_create_pango_layout();
it supports NULL for "no text".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19631 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't do things with the RTP channels hash table if it hasn't been
guy [Fri, 20 Oct 2006 17:30:27 +0000 (17:30 +0000)]
Don't do things with the RTP channels hash table if it hasn't been
created yet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19630 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix the progress bars.
guy [Fri, 20 Oct 2006 17:12:52 +0000 (17:12 +0000)]
Fix the progress bars.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19629 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd an expert item for detecting ARP request packet storms. The time period and...
martinm [Fri, 20 Oct 2006 14:20:22 +0000 (14:20 +0000)]
Add an expert item for detecting ARP request packet storms.  The time period and number of requests needed are configurable.  I've turned the preference to do the detection off, because I'm not sure what might be sensible defaults for the other fields...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19628 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoReport roundtrip delay as expert item
martinm [Fri, 20 Oct 2006 14:05:18 +0000 (14:05 +0000)]
Report roundtrip delay as expert item

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19627 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMinor info column formatting + improved hf long text entries
martinm [Fri, 20 Oct 2006 14:03:28 +0000 (14:03 +0000)]
Minor info column formatting + improved hf long text entries

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19626 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDo the word-wrapping in end_string(), once the string is completely
guy [Fri, 20 Oct 2006 09:06:24 +0000 (09:06 +0000)]
Do the word-wrapping in end_string(), once the string is completely
constructed.  Clean up the insertion of ", ".

Put the runtime libpcap version into the runtime version info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19625 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake dumpcap complile again and other minor improvements.
jake [Fri, 20 Oct 2006 06:24:56 +0000 (06:24 +0000)]
Make dumpcap complile again and other minor improvements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19624 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFixes bug 1166, adds DNET decoding to I-Could-Be-Router-To-Network message.
jake [Fri, 20 Oct 2006 05:56:56 +0000 (05:56 +0000)]
Fixes bug 1166, adds DNET decoding to I-Could-Be-Router-To-Network message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19623 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix 'save' to store hi-order 32 bits of time offset for each pkt; fixes bug 1168
wmeier [Fri, 20 Oct 2006 01:17:17 +0000 (01:17 +0000)]
fix 'save' to store hi-order 32 bits of time offset for each pkt; fixes bug 1168

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19622 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove an extra space.
gerald [Thu, 19 Oct 2006 23:57:46 +0000 (23:57 +0000)]
Remove an extra space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19621 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRename get_epan_and_portaudio_version_info() to get_gui_compiled_info()
gerald [Thu, 19 Oct 2006 22:43:38 +0000 (22:43 +0000)]
Rename get_epan_and_portaudio_version_info() to get_gui_compiled_info()
and add version info for AirPcap.  Add a corresponding
get_gui_runtime_info().  Fix up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19620 f5534014-38df-0310-8fa8-9805f1628bb7