obnox/wireshark/wip.git
12 years agoMake it possible to run checkapi on all plugins trough makefile.nmake
etxrab [Mon, 5 May 2008 16:55:19 +0000 (16:55 +0000)]
Make it possible to run checkapi on all plugins trough makefile.nmake
Note: Commented out in the plugins giving errors for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25231 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd depreceated glib API:s
etxrab [Mon, 5 May 2008 06:27:15 +0000 (06:27 +0000)]
Add depreceated glib API:s

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25230 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Gerhard Olsson :
etxrab [Mon, 5 May 2008 05:58:45 +0000 (05:58 +0000)]
From   Gerhard Olsson :
X25 reassembly when presenting out of order packets
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2091

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25229 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoReplace leading spaces by a TAB
jmayer [Mon, 5 May 2008 00:41:30 +0000 (00:41 +0000)]
Replace leading spaces by a TAB

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25228 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix a tpyo
jmayer [Mon, 5 May 2008 00:39:47 +0000 (00:39 +0000)]
Fix a tpyo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25227 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoImproved the WLAN Traffic Statistics:
stig [Sun, 4 May 2008 22:37:05 +0000 (22:37 +0000)]
Improved the WLAN Traffic Statistics:
- Added details for each network
- Added context menu for adding a filter
- Keep the selected network when capturing
- Show probe requests with broadcast ssid
- Print '.' for non-printable characters in ssid

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25226 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoCorrected some unused arguments in case someone starts using them,
stig [Sun, 4 May 2008 22:29:41 +0000 (22:29 +0000)]
Corrected some unused arguments in case someone starts using them,
or just copy the code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25225 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdded a hidden SSID (wlan_mgt.ssid) to be able to filter on the ssid.
stig [Sun, 4 May 2008 22:20:58 +0000 (22:20 +0000)]
Added a hidden SSID (wlan_mgt.ssid) to be able to filter on the ssid.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25224 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix for bug #2518: 'tshark -Tfields -e data' Omits Last Character of Data
wmeier [Sat, 3 May 2008 22:33:51 +0000 (22:33 +0000)]
Fix for bug #2518: 'tshark -Tfields -e data' Omits Last Character of Data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25223 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Abhik Sarkar:
jake [Sat, 3 May 2008 09:49:10 +0000 (09:49 +0000)]
From Abhik Sarkar:
This patch adds basic support for stats to the UCP dissector using the Stats Tree API.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25222 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Steve Karg:
jake [Sat, 3 May 2008 08:31:50 +0000 (08:31 +0000)]
From Steve Karg:
Corrected packet-bvlc.c dissector which was not decoding BACnet BVLC NAK result
code text correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25221 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoInitialise variable.
martinm [Fri, 2 May 2008 21:38:49 +0000 (21:38 +0000)]
Initialise variable.
(sorry about the build breakage, these new message formats will be tested soon
and it looks like I forgot to compile-test the last change I made...).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25220 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix (what I presume to be) a typo to prevent compile error.
wmeier [Fri, 2 May 2008 19:18:08 +0000 (19:18 +0000)]
Fix (what I presume to be) a typo to prevent compile error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25219 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix crash in Bug #2410: restore saved 'packet_info.private_data' for two fail returns
wmeier [Fri, 2 May 2008 19:03:00 +0000 (19:03 +0000)]
Fix crash in Bug #2410: restore saved 'packet_info.private_data' for two fail returns

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25218 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoMore R7 additions.
martinm [Fri, 2 May 2008 15:27:00 +0000 (15:27 +0000)]
More R7 additions.
Main missing part is new HSDSCH data frame type 2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25217 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUpdated common control messages to R7.
martinm [Fri, 2 May 2008 14:50:23 +0000 (14:50 +0000)]
Updated common control messages to R7.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25216 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoEnsure wireshark-filter doc rebuilt when tshark changes; optimize rebuild slightly
wmeier [Fri, 2 May 2008 12:58:15 +0000 (12:58 +0000)]
Ensure wireshark-filter doc rebuilt when tshark changes; optimize rebuild slightly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25215 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Shinsuke SUZUKI:
jake [Fri, 2 May 2008 08:23:21 +0000 (08:23 +0000)]
From Shinsuke SUZUKI:
Since this leads to a compilation failure (Warning C4819: unexpected character
in the current code page) on non-european Windows, I'd like you to avoid using
non-ASCII characters in Wireshark code (even in comment).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25214 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoRemoved a debug printf line.
stig [Thu, 1 May 2008 21:20:49 +0000 (21:20 +0000)]
Removed a debug printf line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25213 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoForce foreground when background is forced in RTP analysis and VOIP calls.
stig [Thu, 1 May 2008 18:26:01 +0000 (18:26 +0000)]
Force foreground when background is forced in RTP analysis and VOIP calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25212 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoForce foreground when background is forced in expert info dialogs.
stig [Thu, 1 May 2008 18:03:46 +0000 (18:03 +0000)]
Force foreground when background is forced in expert info dialogs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25211 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoIgnore generated (on OSX) rdps.dSYM directory.
stig [Thu, 1 May 2008 17:47:48 +0000 (17:47 +0000)]
Ignore generated (on OSX) rdps.dSYM directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25210 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoWhile playing with a dark theme I found it much nicer to use the
stig [Thu, 1 May 2008 17:46:03 +0000 (17:46 +0000)]
While playing with a dark theme I found it much nicer to use the
selected background color from the packet list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25209 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoTry to track SIP responses back to their requests.
martinm [Thu, 1 May 2008 15:23:54 +0000 (15:23 +0000)]
Try to track SIP responses back to their requests.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25208 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Frederic Peters (bug 1735):
stig [Thu, 1 May 2008 11:02:14 +0000 (11:02 +0000)]
From Frederic Peters (bug 1735):
Force foreground when background is forced.

From me:
Do the same for expert info's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25207 f5534014-38df-0310-8fa8-9805f1628bb7

12 years ago...but not with a comment inside a comment, as that might cause a
guy [Thu, 1 May 2008 07:21:15 +0000 (07:21 +0000)]
...but not with a comment inside a comment, as that might cause a
warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25206 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoGet rid of C++/C99 comment.
guy [Thu, 1 May 2008 07:18:58 +0000 (07:18 +0000)]
Get rid of C++/C99 comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25205 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoNow with EAP dissector safety valve.
jake [Wed, 30 Apr 2008 10:59:48 +0000 (10:59 +0000)]
Now with EAP dissector safety valve.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25204 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom cfreeer:
jake [Wed, 30 Apr 2008 09:15:50 +0000 (09:15 +0000)]
From cfreeer:
There is no EAP decoder to decode EAP messages packed in Wimax PKM messages.
I called the EAP decoder found in the Wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25203 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoGet rid of extra blank lines at the end of the file.
guy [Wed, 30 Apr 2008 07:59:26 +0000 (07:59 +0000)]
Get rid of extra blank lines at the end of the file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25202 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUse report_failure() to report failures in capture_sync.c; that will do
guy [Wed, 30 Apr 2008 07:58:57 +0000 (07:58 +0000)]
Use report_failure() to report failures in capture_sync.c; that will do
the right thing in Wireshark and TShark, as both of them call
epan_init() to set the appropriate "report an error" function.

That obviates the need to have TShark have its own private version of
simple_dialog().

Have cmdarg_err() just call failure_message() instead of duplicating the
code in failure_message().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25201 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoadd some cygwin clarifications
ulfl [Wed, 30 Apr 2008 07:35:25 +0000 (07:35 +0000)]
add some cygwin clarifications

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25200 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoChange an option menu (deprecated in GTK+ 2.4) to a combo box (GTK+ 2.4+).
sfisher [Tue, 29 Apr 2008 19:14:44 +0000 (19:14 +0000)]
Change an option menu (deprecated in GTK+ 2.4) to a combo box (GTK+ 2.4+).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25199 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoReplace an option menu (deprecated as of GTK+ 2.4) with a combo box
sfisher [Tue, 29 Apr 2008 18:46:10 +0000 (18:46 +0000)]
Replace an option menu (deprecated as of GTK+ 2.4) with a combo box
(GTK+ 2.4+).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25198 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAll versions of GLib 2.x come with g_ascii_strcasecmp(), and we require
guy [Tue, 29 Apr 2008 16:24:22 +0000 (16:24 +0000)]
All versions of GLib 2.x come with g_ascii_strcasecmp(), and we require
GLib 2.x; we don't have to check for its presence and supply a
replacement if it's missing.

Get rid of an unremoved reference in epan/dtd_parse.l.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25197 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoCall se_free_all() in epan_cleanup() so that we will detect per-session (se_)
morriss [Tue, 29 Apr 2008 15:29:02 +0000 (15:29 +0000)]
Call se_free_all() in epan_cleanup() so that we will detect per-session (se_)
memory corruption in tshark (and Wireshark when exiting the program instead
of loading a new file?).

Why this wasn't always here I don't know.

This may give us a pile of buildbot fuzz failures but that's a Good Thing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25196 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1513 : don't tvb_memcpy()...
morriss [Tue, 29 Apr 2008 15:20:19 +0000 (15:20 +0000)]
Fix bugs.wireshark.org/bugzilla/show_bug.cgi?id=1513 : don't tvb_memcpy() more bytes than are in the (se_alloc()'d) buffer.  tvb_memcpy()ing more bytes than are the TVB is okay (it'll except out).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25195 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Abhik Sarkar, fixed bug #2477.
martinm [Tue, 29 Apr 2008 14:24:16 +0000 (14:24 +0000)]
From Abhik Sarkar, fixed bug #2477.
Change ftype of ssh-padding-string to FT_BYTES.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25194 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoMove minimum byte count test from dissect_scsi_smc_element() up into the calling...
morriss [Tue, 29 Apr 2008 12:27:32 +0000 (12:27 +0000)]
Move minimum byte count test from dissect_scsi_smc_element() up into the calling dissect_scsi_smc_elements() so we can break out of the loop if we're not advancing through the packet.  This fixes the infinite loop reported in bugs.wireshark.org/bugzilla/show_bug.cgi?id=2508

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25193 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoGet rid of old GLib 1.2[.x] stuff, as we now require GLib 2.x.
guy [Tue, 29 Apr 2008 08:44:57 +0000 (08:44 +0000)]
Get rid of old GLib 1.2[.x] stuff, as we now require GLib 2.x.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25192 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoHave the error for not finding GTK+ indicate that we require GTK+ 2.4 or
guy [Tue, 29 Apr 2008 08:30:39 +0000 (08:30 +0000)]
Have the error for not finding GTK+ indicate that we require GTK+ 2.4 or
later.  Do the same for the GLib error messages, having them indicate
that we require GLib 2.x.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25191 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoCorrect AVP name.
etxrab [Tue, 29 Apr 2008 05:51:22 +0000 (05:51 +0000)]
Correct AVP name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25190 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix minor typo in comment
wmeier [Mon, 28 Apr 2008 20:32:06 +0000 (20:32 +0000)]
Fix minor typo in comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25189 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdded flag i new recent file to determine where to get values now
stig [Mon, 28 Apr 2008 13:27:25 +0000 (13:27 +0000)]
Added flag i new recent file to determine where to get values now
moved to recent_common.  This will convert old recent file to new.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25188 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoReopen the recent file when reading older common settings.
stig [Mon, 28 Apr 2008 13:00:49 +0000 (13:00 +0000)]
Reopen the recent file when reading older common settings.
This will be optimized later.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25187 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoSplit the recent file in two, one for the configuration profile
stig [Mon, 28 Apr 2008 12:35:03 +0000 (12:35 +0000)]
Split the recent file in two, one for the configuration profile
and one common for all profiles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25186 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix test for unlimited credits value in new alloc format.
martinm [Mon, 28 Apr 2008 10:23:25 +0000 (10:23 +0000)]
Fix test for unlimited credits value in new alloc format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25185 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Alon Tal:
jake [Sun, 27 Apr 2008 11:10:57 +0000 (11:10 +0000)]
From Alon Tal:
RTP header extensions that are longer than 4 bytes (rtp.ext.len > 1)
get dissected incorrectly. The first 4 bytes of the header extension are
repeated rtp.ext.len times, and the remaining bytes are ignored.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25184 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd adns_dll.dep and adns_dll.rc to the tarball, as requested by Sake
stig [Sun, 27 Apr 2008 10:54:25 +0000 (10:54 +0000)]
Add adns_dll.dep and adns_dll.rc to the tarball, as requested by Sake
and indicated by Anders.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25183 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoRemove all GTK+ < 2.4 code and minimum version checks.
sfisher [Sun, 27 Apr 2008 07:01:58 +0000 (07:01 +0000)]
Remove all GTK+ < 2.4 code and minimum version checks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25182 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoChanged to display NCP connection, as in conversations.
stig [Fri, 25 Apr 2008 19:42:27 +0000 (19:42 +0000)]
Changed to display NCP connection, as in conversations.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25181 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoRegister dissector by name.
stig [Fri, 25 Apr 2008 19:25:49 +0000 (19:25 +0000)]
Register dissector by name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25180 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoRegister dissector by name.
stig [Fri, 25 Apr 2008 19:25:22 +0000 (19:25 +0000)]
Register dissector by name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25179 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd comment explaining that case is safe.
martinm [Fri, 25 Apr 2008 19:12:57 +0000 (19:12 +0000)]
Add comment explaining that case is safe.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25178 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd cast to avoid Windows warning.
martinm [Fri, 25 Apr 2008 19:09:07 +0000 (19:09 +0000)]
Add cast to avoid Windows warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25177 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Márton Németh:
jake [Fri, 25 Apr 2008 19:04:52 +0000 (19:04 +0000)]
From Márton Németh:
Cleanup ident of epan/wslua/init_wslua.c: use spaces instead of tabs.
cleanup the ident of generator scripts and for template-init.lua
Spaces used instead of tabs for indent. Removed spaces placed by generator
script just before a newline.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25176 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom: Márton Németh:
jake [Fri, 25 Apr 2008 18:59:20 +0000 (18:59 +0000)]
From: Márton Németh:
The luaL_reg structure consists of two pointers: char* and a pointer to a function.
The last entry should also reflect this: it should be { NULL, NULL } instead of { 0, 0 }.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25175 f5534014-38df-0310-8fa8-9805f1628bb7

12 years ago Bug 2493: Fix (Part 3 of 3):
wmeier [Fri, 25 Apr 2008 18:26:54 +0000 (18:26 +0000)]
 Bug 2493: Fix (Part 3 of 3):
  To prevent Windows compiler errors when using flex 2.5.35.
  Ignore 'signed /unsigned mismatch' warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25174 f5534014-38df-0310-8fa8-9805f1628bb7

12 years ago Bug 2493: Fix (Part 2):
wmeier [Fri, 25 Apr 2008 17:40:29 +0000 (17:40 +0000)]
 Bug 2493: Fix (Part 2):
 To prevent Windows compiler errors when using flex 2.5.35.
 Fixes "missing unistd.h" and yywrap "mismatched parameter" warnings
 [Upcoming Part 3: ignore 'signed /unsigned mismatch' errors]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25173 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoBug 2493: Fix (Part 1):
wmeier [Fri, 25 Apr 2008 17:24:29 +0000 (17:24 +0000)]
Bug 2493: Fix (Part 1):
-TEXT_FUNC (const char *text) --> -TEXT_FUNC (char *text)
To prevent Windows compiler error when using flex 2.5.35.
(This also compiles OK for *NIX flex and for windows flex 2.5.4)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25172 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFixed some old problems found while starting to add R7 support.
martinm [Fri, 25 Apr 2008 17:20:28 +0000 (17:20 +0000)]
Fixed some old problems found while starting to add R7 support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25171 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFlex (v 2.5.35) uses this symbol to "exclude" unistd.h
etxrab [Fri, 25 Apr 2008 06:42:37 +0000 (06:42 +0000)]
Flex (v 2.5.35) uses this symbol to "exclude" unistd.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25170 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix for bug #2480: Custom column, wrong display of 802.11 Sleep mode status
sfisher [Fri, 25 Apr 2008 05:16:23 +0000 (05:16 +0000)]
Fix for bug #2480: Custom column, wrong display of 802.11 Sleep mode status

Changed the tfstring to use integer variable instead of value variable.  The
integer value has had its "irrelevant portions" masked out and has been bit-
shifted whereas value hasn't.  This led to unpredictable results when using
a true false string for a single bit of a byte.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25169 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Mohan (bug 2501):
stig [Thu, 24 Apr 2008 21:51:14 +0000 (21:51 +0000)]
From Mohan (bug 2501):
Add a missing break statement.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25168 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoGet rid of CR's at the ends of lines, give it an NL at the end, and set
guy [Thu, 24 Apr 2008 21:07:23 +0000 (21:07 +0000)]
Get rid of CR's at the ends of lines, give it an NL at the end, and set
the svn:keywords and svn:eol-style properties appropriately.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25167 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd missing dissector from the makefile:
etxrab [Thu, 24 Apr 2008 19:57:41 +0000 (19:57 +0000)]
Add missing dissector from the makefile:
packet-gsm_bsslap.c
 Routines for Location Services (LCS) Serving Mobile Location Centre - Base Station System (SMLC-BSS) dissection - 3GPP TS 48.071 version 7.2.0 Release 7

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25166 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUse cairo-1.6.4-1 and pango-dev-1.20.2
etxrab [Thu, 24 Apr 2008 19:45:29 +0000 (19:45 +0000)]
Use cairo-1.6.4-1 and pango-dev-1.20.2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25165 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoremove superfluous declaration struct srtp_info *dummy_srtp_info
kukosa [Thu, 24 Apr 2008 06:36:42 +0000 (06:36 +0000)]
remove superfluous declaration struct srtp_info *dummy_srtp_info

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25164 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoExpand and clean up the descriptions of the new WTAP_ENCAP values.
guy [Thu, 24 Apr 2008 00:14:18 +0000 (00:14 +0000)]
Expand and clean up the descriptions of the new WTAP_ENCAP values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25163 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoClean up indentation. There is no guarantee that tabs will appear
guy [Thu, 24 Apr 2008 00:08:19 +0000 (00:08 +0000)]
Clean up indentation.  There is no guarantee that tabs will appear
every 4 spaces or every 8 spaces, so just use spaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25162 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoMartin Peylo <wireshark@izac.de>:
jmayer [Wed, 23 Apr 2008 23:15:00 +0000 (23:15 +0000)]
Martin Peylo <wireshark@izac.de>:
    PKIXCMP: fix new plain TCP transport style, add OID and preferences
    (The previous checkin forgot to check in the changed source files.)

Me:
- Fix a warning about an 'incompatible pointer type'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25161 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jim Young:
jake [Wed, 23 Apr 2008 23:12:18 +0000 (23:12 +0000)]
From Jim Young:
Small patch to gtk/expert_dlg.c to test for the existance of the etd->label
before use.  This patch stops GTK assertion on Linux.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25160 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoThe constants are there, now they need real names.
jake [Wed, 23 Apr 2008 21:35:36 +0000 (21:35 +0000)]
The constants are there, now they need real names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25159 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoDon't skip ahead in time when looking for a conversation.
jake [Wed, 23 Apr 2008 21:31:50 +0000 (21:31 +0000)]
Don't skip ahead in time when looking for a conversation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25158 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom : Martin Peylo:
etxrab [Wed, 23 Apr 2008 20:49:54 +0000 (20:49 +0000)]
From :  Martin Peylo:
PKIXCMP: fix new plain TCP transport style, add OID and preferences

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2499

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25157 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom bboissin:
etxrab [Wed, 23 Apr 2008 20:42:02 +0000 (20:42 +0000)]
From   bboissin:
fix RFC4191 handling
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2498

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25156 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jon Larimer:
etxrab [Wed, 23 Apr 2008 20:28:30 +0000 (20:28 +0000)]
From   Jon Larimer:
NTLMSSP protocol dissector doesn't parse NTLMSSP in DCERPC packets with packet level auth
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2444

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25155 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Hannes Kälber:
etxrab [Wed, 23 Apr 2008 20:23:09 +0000 (20:23 +0000)]
From   Hannes Kälber:
new WTAP_ENCAP files(X2E Xoraya serial frame and X2E Xoraya frame )
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2418

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25154 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Gerhard Olsson :
etxrab [Wed, 23 Apr 2008 19:49:40 +0000 (19:49 +0000)]
From   Gerhard Olsson :
X25 reassembly when presenting out of order packets.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2091

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25153 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoRequire at least version 2.4.0 of GTK
jmayer [Wed, 23 Apr 2008 18:19:01 +0000 (18:19 +0000)]
Require at least version 2.4.0 of GTK

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25152 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoRename "Taps/Statistics" preference group to be simply "Statistics".
martinm [Wed, 23 Apr 2008 16:49:34 +0000 (16:49 +0000)]
Rename "Taps/Statistics" preference group to be simply "Statistics".
"Tap" is a term likely only to be known to developers, and
"Statistics" matches the Menu item under which all of the affected
windows are launched.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25151 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Peter Fuller:
jake [Wed, 23 Apr 2008 06:51:15 +0000 (06:51 +0000)]
From Peter Fuller:
If a UDP packet is submitted to the RTP heuristic dissector with either odd src
or dst ports, the heuristic will correctly return FALSE.  However, that
interferes with the next few lines of code that can potentially treat version 0
RTP packets as either STUN or T38 depending on preference settings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25150 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Vasil Velichkov:
etxrab [Wed, 23 Apr 2008 05:16:53 +0000 (05:16 +0000)]
From   Vasil Velichkov:
Fix dissection of Location and Generic Number in CAMEL
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2494

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25149 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix Dissector bug, protocol SNMP: proto.c:932: failed assertion
etxrab [Tue, 22 Apr 2008 19:31:03 +0000 (19:31 +0000)]
Fix Dissector bug, protocol SNMP: proto.c:932: failed assertion
From LEGO:
DISSECTOR_ASSERT_NOT_REACHED() is a Bug regardless, it is triggered because we
are proto_add_item()ing an FT_UINT32 of 5 bytes in length.

IF-MIB:ifInOctets is a Counter32 so the value should (and is) application
encoded using tag 41.

the value's value (!) is  H'00d49e69fa (D'3567151610).

the assertion is triggered because there's an error in oids.c:59
where states the ft_type as being an FT_UINT32 with a length of 1 to 4 bytes,
It should be FT_UINT64 and the length from 1 to 5 bytes considering that
integers bigger than 2^31 will be ber encoded in 5 bytes.

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2468

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25148 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUse Libsmi 0.4.8
etxrab [Tue, 22 Apr 2008 19:28:44 +0000 (19:28 +0000)]
Use Libsmi 0.4.8

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25147 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix for bug 2481:
jake [Tue, 22 Apr 2008 06:36:15 +0000 (06:36 +0000)]
Fix for bug 2481:
Remove debug code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25146 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Chris:
stig [Tue, 22 Apr 2008 05:27:28 +0000 (05:27 +0000)]
From Chris:
Correct some typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25145 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoClarify where these L1 event messages come from.
guy [Tue, 22 Apr 2008 02:13:31 +0000 (02:13 +0000)]
Clarify where these L1 event messages come from.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25144 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoRename prefs_rtp_player files to prefs_taps.
martinm [Mon, 21 Apr 2008 21:56:45 +0000 (21:56 +0000)]
Rename prefs_rtp_player files to prefs_taps.
(see rev 25133)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25143 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Alex deVries (bug 2486):
stig [Mon, 21 Apr 2008 21:36:11 +0000 (21:36 +0000)]
From Alex deVries (bug 2486):
This adds fpSyncFork and fpSyncDir functionality to the AFP dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25142 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Gael Breard:
jake [Mon, 21 Apr 2008 21:10:19 +0000 (21:10 +0000)]
From Gael Breard:
this is an update to the STUN2 dissector using the last draft,
draft-ietf-behave-rfc3489bis-15
- add TURN extension support (probably incomplete) from
draft-ietf-behave-turn-07
- add some descriptive text for attributes upper in tree (it avoids developing
the tree completely to see essential attributes values)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25138 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd "tpncp." before all filter names so we don't crash with others.
stig [Mon, 21 Apr 2008 20:25:50 +0000 (20:25 +0000)]
Add "tpncp." before all filter names so we don't crash with others.

This fixes solution 1 from bug 2402.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25137 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUse latest Glib version.
etxrab [Mon, 21 Apr 2008 19:16:22 +0000 (19:16 +0000)]
Use latest Glib version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25136 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoTimeTicks ::= [APPLICATION 3] IMPLICIT INTEGER (0..4294967295)
etxrab [Mon, 21 Apr 2008 18:38:01 +0000 (18:38 +0000)]
TimeTicks ::= [APPLICATION 3] IMPLICIT INTEGER (0..4294967295)
  If the BER encoding should not have the top bit set as to not become a negative number
  the ber encoding may take 5 octets to encode.
Fixes BUG:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2253

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25135 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoTimeStamp are derived from timeticks_type (See SNMPv2-TC).
etxrab [Mon, 21 Apr 2008 18:23:23 +0000 (18:23 +0000)]
TimeStamp are derived from timeticks_type (See SNMPv2-TC).
Fixes Bug:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2442

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25134 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAllow configuration of tap update interval.
martinm [Mon, 21 Apr 2008 10:57:32 +0000 (10:57 +0000)]
Allow configuration of tap update interval.
- rename rtp_player config group to taps/statistics
- will rename prefs_rtp_player files later
  (svn didn't seem keen to rename with changes present,
   and output says its just a copy/delete anyway...)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25133 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Marton Nemeth (bug 2484):
stig [Mon, 21 Apr 2008 08:58:50 +0000 (08:58 +0000)]
From Marton Nemeth (bug 2484):
The variables ep_canary[], se_canary[], ep_packet_mem and se_packet_mem are
only used in emem.c, so the visibility can be file local (static).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25132 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Martin Peylo:
etxrab [Mon, 21 Apr 2008 05:25:38 +0000 (05:25 +0000)]
From   Martin Peylo:
PKIXCMP: update TCP transport style, add OIDs and content types

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2460

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25131 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agofix build on GTK 2.0/2.2 and some other code cleanup
ulfl [Mon, 21 Apr 2008 01:49:53 +0000 (01:49 +0000)]
fix build on GTK 2.0/2.2 and some other code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25130 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoremove no longer required parameters from toolbar_item() macro
ulfl [Mon, 21 Apr 2008 00:54:46 +0000 (00:54 +0000)]
remove no longer required parameters from toolbar_item() macro

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25129 f5534014-38df-0310-8fa8-9805f1628bb7