sfisher [Thu, 13 Jan 2011 17:54:30 +0000 (17:54 +0000)]
Add "break;" to end of last case statement.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35522
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 13 Jan 2011 17:39:54 +0000 (17:39 +0000)]
Wrap include file in extern "C" { ... } for __cplusplus
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35521
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 13 Jan 2011 17:25:22 +0000 (17:25 +0000)]
Add some of my changes since 1.4 was released
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35520
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 13 Jan 2011 15:53:30 +0000 (15:53 +0000)]
Introduce, and start using, tvb_ip_to_str() and tvb_ip6_to_str(). These
do the same as the non-tvb equivalents but take a TVB and an offset instead
of a pointer to an array of bytes.
Their purpose is to prevent (many) dissectors from doing:
ip_to_str(tvb_get_ptr(...)).
(About the names and the location: I like the names as they are but the names
imply that they should live in tvbuff.c. That would make some sense but
I didn't want to pull to_str.h into tvbuff.c...)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35519
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Thu, 13 Jan 2011 15:16:45 +0000 (15:16 +0000)]
Getting ready for R9 versions of some LTE protocols.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35518
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 13 Jan 2011 15:03:55 +0000 (15:03 +0000)]
Use value_string_ext.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35517
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 13 Jan 2011 14:36:40 +0000 (14:36 +0000)]
Remove an unused variable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35516
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 13 Jan 2011 14:07:34 +0000 (14:07 +0000)]
Make it possible to dissect the part pressent in short frames.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35515
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Thu, 13 Jan 2011 08:35:29 +0000 (08:35 +0000)]
Added a couple of my new features
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35514
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 13 Jan 2011 06:32:23 +0000 (06:32 +0000)]
From Pascal Quantin:
Fix dissection of protocol ID.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35513
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 13 Jan 2011 00:52:32 +0000 (00:52 +0000)]
More 1.5 updates.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35512
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 12 Jan 2011 23:20:03 +0000 (23:20 +0000)]
Start updating the release notes for 1.5.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35511
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 12 Jan 2011 21:36:11 +0000 (21:36 +0000)]
Set gsm_a_dtap_pinfo->link_dir to get proper dissection of PCO.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35510
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 12 Jan 2011 20:25:36 +0000 (20:25 +0000)]
There's no need to call tvb_get_ptr() in here: just call ensure_contiguous() directly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35509
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 12 Jan 2011 17:20:52 +0000 (17:20 +0000)]
Fix the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5574 :
The first time a value_string_ext() is accessed, _match_strval_ext_init() is
used before the real match function is called. This function was not expanded
to take an idx parameter (in rev 35451). It compiled only because the function:
a) previously did not match _value_string_match_t
b) and the difference was being cast away when assigning _match_strval to it
(So the fact that the index parameter was not added was also ignored.)
To fix the problem, give _match_strval_ext_init() and index parameter and use
it instead of a dummy variable when calling the real match function. That way
the first call to match_strval_ext_idx() will return an actual (initialized)
index.
To prevent the problem in the future, make the vse argument to
_match_strval_ext_init() const *and then cast away the constness* so the
function can modify the vse.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35508
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 12 Jan 2011 17:05:58 +0000 (17:05 +0000)]
Mark a parameter as unused.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35507
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 12 Jan 2011 16:43:59 +0000 (16:43 +0000)]
Enhance IE dissection.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35506
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 12 Jan 2011 16:43:19 +0000 (16:43 +0000)]
Update dissection of Protocol configuration options.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35505
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 12 Jan 2011 07:46:46 +0000 (07:46 +0000)]
From Eliad:
Add dissector for P2P Group BSSID attribute (of p2p).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35504
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 12 Jan 2011 07:42:18 +0000 (07:42 +0000)]
From Steve Karg:
Added a display filter on BACnet WhoIs Low Limit and High Limit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35503
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 12 Jan 2011 07:39:54 +0000 (07:39 +0000)]
Update a value_string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35502
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 12 Jan 2011 07:36:55 +0000 (07:36 +0000)]
Use value_string_ext in a couple of places.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35501
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 12 Jan 2011 07:31:49 +0000 (07:31 +0000)]
From Fulko Hew:
Improved the decoding of OID search ranges in AgentX dissector:
1/ OID highlighting on first OID of a range was too long.
The code incorrectly used the length of the printable string instead
of the length of the source data.
2/ Added bitwise dissection of the 'include' field of an OID decoding.
3/ Added corrected 'start/end' range information to SearchRange decoding to
discriminate between an 'end' indicator (old way) and the new way that
shows both an inclusive/exclusive indicator as well as a start/end range
indicator. (applicable to getnext/getbulk requests).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35500
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 12 Jan 2011 07:25:34 +0000 (07:25 +0000)]
Document and export:
tvb_bcd_dig_to_ep_str();
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35499
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 12 Jan 2011 07:18:57 +0000 (07:18 +0000)]
TCAP- Application context name not been decoded correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5573
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35498
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 12 Jan 2011 03:35:14 +0000 (03:35 +0000)]
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_string(): just use proto_tree_add_item().
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.
In a couple of places an hf variable was being used as the length in a call to
proto_tree_add_*(). Use the appropriate variable instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35497
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 12 Jan 2011 03:27:32 +0000 (03:27 +0000)]
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_string(): just use proto_tree_add_item().
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.
In a couple of places an hf variable was being used as the length in a call to
proto_tree_add_*(). Use the appropriate variable instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35496
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 12 Jan 2011 03:19:07 +0000 (03:19 +0000)]
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_string(): just use proto_tree_add_item().
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.
In a couple of places an hf variable was being used as the length in a call to
proto_tree_add_*(). Use the appropriate variable instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35495
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 12 Jan 2011 03:08:05 +0000 (03:08 +0000)]
Replace some uses of tvb_get_ptr() with tvb_get_ephemeral_string().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35494
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 12 Jan 2011 02:25:08 +0000 (02:25 +0000)]
Introduce, and start using, tvb_get_const_stringz(). This function returns a
pointer to a NULL-terminated string in the TVB. It is no safer than dissectors
which call tvb_get_strsize() and then tvb_get_ptr() but it makes it clear that
this usage of tvb_get_ptr() is safe.
This function is slightly more efficient than tvb_get_ephemeral_stringz()--but
only as long as we're not using composite TVBs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35493
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 11 Jan 2011 22:41:19 +0000 (22:41 +0000)]
Don't attempt to reassemble short (reported_len > len) chunks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35486
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 11 Jan 2011 22:36:31 +0000 (22:36 +0000)]
Don't store message fragments whose length is 0: there's no point. (Otherwise
fragment->len was left unitialized.)
Also (unrelated): save a couple of calls to tvb_reported_length() since the
value is already stored in a variable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35485
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 11 Jan 2011 20:15:04 +0000 (20:15 +0000)]
Use value_string_ext and friends.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35484
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 11 Jan 2011 20:02:30 +0000 (20:02 +0000)]
Complement to
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35477
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35483
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 11 Jan 2011 17:06:38 +0000 (17:06 +0000)]
Improve dissection of UE Time Zone.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35477
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 11 Jan 2011 11:41:03 +0000 (11:41 +0000)]
ldap.cnf:782: warning: ISO C90 forbids mixed declarations and code
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35476
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Tue, 11 Jan 2011 08:22:16 +0000 (08:22 +0000)]
From Slava K:
FCoIB – Fibre Channel over InfiniBand. The protocol enables transmission of
Fibre Channel frames over InfiniBand networks. It is based on encapsulation of
Fibre Channel frames over InfiniBand UD transport. The discovery protocol is
based on the FIP protocol (not supported by this patch).
This patch adds an FCoIB dissector to Wireshark. It is based in large part on
the existing FCoE dissection code.
This code is submitted on behalf of Mellanox Technologies Ltd.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35475
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 11 Jan 2011 02:27:41 +0000 (02:27 +0000)]
From Matthieu Patou <mat@samba.org>
Dissect LDAP DirSyncFlags to show the bits of this bitmap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35474
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Mon, 10 Jan 2011 23:29:54 +0000 (23:29 +0000)]
Complete the chapter on popup menus.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35467
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 10 Jan 2011 22:31:05 +0000 (22:31 +0000)]
Add a missing procedure name for NFS-ACL
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35466
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 10 Jan 2011 21:23:25 +0000 (21:23 +0000)]
Stop gcc warning about type-punned pointer breaks strict anti-aliasing
rules. (Is this the right fix? I had to remove a now meaningless
comparison of psm > 0x1000 (4096) since psm is now a guint8 not a guint16.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35463
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 10 Jan 2011 20:23:21 +0000 (20:23 +0000)]
Add 2869 to the list of HTTP ports: support.microsoft.com/kb/886257
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35461
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 10 Jan 2011 19:48:15 +0000 (19:48 +0000)]
Add an expert item about not dissected IE's
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35460
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 10 Jan 2011 17:34:00 +0000 (17:34 +0000)]
Shorten long winded strings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35456
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 10 Jan 2011 16:27:09 +0000 (16:27 +0000)]
Revert back to NSIS from NSIS Unicode to resolve bug 5558.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35455
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 10 Jan 2011 15:19:18 +0000 (15:19 +0000)]
Move some DISSECTOR_SRC & DISSECTOR_INCLUDES entries so they are (more or less) in alpha order.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35454
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 10 Jan 2011 14:43:29 +0000 (14:43 +0000)]
Revert 35447 and 35364: remove comments and strings in one regex (so it doesn't get confused by things like /* inside a string). And don't remove comments+strings before checking the hf's.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35453
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 10 Jan 2011 14:40:10 +0000 (14:40 +0000)]
Give a couple commented-out hf's abbreviations (to keep checkAPIs happy).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35452
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 10 Jan 2011 14:31:33 +0000 (14:31 +0000)]
Introduce match_strval_idx_ext()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35451
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 10 Jan 2011 12:28:56 +0000 (12:28 +0000)]
Add application/vnd.3gpp.cw+xml
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35450
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Mon, 10 Jan 2011 07:39:15 +0000 (07:39 +0000)]
Clean up the blurbs indicated by checkAPIs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35449
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 10 Jan 2011 07:01:23 +0000 (07:01 +0000)]
Simplified a #ifdef __WIN32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35448
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 10 Jan 2011 03:04:26 +0000 (03:04 +0000)]
Remove the comments and strings separately so that we can check the hf's when the comments are gone but the strings are not.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35447
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 10 Jan 2011 03:02:43 +0000 (03:02 +0000)]
Give CSID an abbreviation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35446
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 9 Jan 2011 22:34:20 +0000 (22:34 +0000)]
Make comment a real comment, trying to fix the buildbot.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35445
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 9 Jan 2011 22:17:14 +0000 (22:17 +0000)]
Add the graphic files to the distribution.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35444
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 9 Jan 2011 21:59:00 +0000 (21:59 +0000)]
Update the pop-up menu screen shots.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35443
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 9 Jan 2011 20:41:19 +0000 (20:41 +0000)]
Update value_strings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35442
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 9 Jan 2011 19:44:21 +0000 (19:44 +0000)]
Update the menu screenshots and descriptions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35441
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 9 Jan 2011 19:37:35 +0000 (19:37 +0000)]
More field related fixes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35440
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 9 Jan 2011 19:17:39 +0000 (19:17 +0000)]
Fix:
20:15:19 Err Field 'Link-local Address' (pmip6.lila_lla) is an FT_IPv6
but is being displayed as BASE_HEX instead of BASE_NONE
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35439
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 9 Jan 2011 19:15:11 +0000 (19:15 +0000)]
Fix:
packet-mip6.c:801: warning: 'hf_pmip6_opt_ipack' defined but not used
packet-mip6.c:802: warning: 'hf_pmip6_opt_ipack_res' defined but not used
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35438
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 9 Jan 2011 17:49:31 +0000 (17:49 +0000)]
Add 26 Link-local Address Option.
Comments and whitespace changes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35436
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 9 Jan 2011 16:03:37 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-01-09]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35434
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 9 Jan 2011 13:50:41 +0000 (13:50 +0000)]
Put sgsap in the right place.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35433
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 9 Jan 2011 13:50:03 +0000 (13:50 +0000)]
Get rid of check_col().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35432
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 8 Jan 2011 20:26:35 +0000 (20:26 +0000)]
Try to fix:
packet-gtpv2.c:2648: warning: return type defaults to 'int'
packet-gtpv2.c: In function 'dissect_udp_s_port_nr':
packet-gtpv2.c:2690: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_fq_csid':
packet-gtpv2.c:2845: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_emlpp_pri':
packet-gtpv2.c:2927: warning: implicit declaration of function 'be_emlpp_prio'
packet-gtpv2.c: At top level:
packet-gtpv2.c:3056: warning: initialization from incompatible pointer type
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35431
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 8 Jan 2011 20:09:29 +0000 (20:09 +0000)]
Further IE dissection updates.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35430
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Jan 2011 18:46:01 +0000 (18:46 +0000)]
From H.sivank:
-A patch to fix configure with cmake with macports libs.
(gdk-pixbuf has now its own port. Location of headers has
changed.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35429
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Jan 2011 18:44:21 +0000 (18:44 +0000)]
From H.sivank:
-A patch to allow drag and drop on wireshark icon doc.
It does not require old(Carbon) ScriptExec.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35428
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Jan 2011 17:06:04 +0000 (17:06 +0000)]
Use report_failure() to report problems reading the RADIUS dictionary,
so it shows up in the GUI in Wireshark.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35427
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Jan 2011 16:40:46 +0000 (16:40 +0000)]
If the lack of a peer conversation is a bug, use one of the
dissector-bug macros. If it's just that we're missing some packets, we
should handle that as best we can and, if there's stuff we can't do,
maybe put something into the protocol summary or tree saying "not enough
information". Don't just spit out a warning message which the user
might not even see.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35426
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Sat, 8 Jan 2011 15:51:38 +0000 (15:51 +0000)]
Add "tcp.window_size_value" and "tcp.window_size_scalefactor" conform
the discussion in bug 5541. Since we now have the window size value as
well as the scaled window size, there is no need anymore for the
tcp preference "tcp_window_scaling".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35425
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 7 Jan 2011 19:22:09 +0000 (19:22 +0000)]
Append text to INFO column. Closes out bug 4472.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35423
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 7 Jan 2011 19:01:17 +0000 (19:01 +0000)]
Don't try to display a string in BASE_DEC. Also delete duplicate registration of hf_gtpv2_pti.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35422
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 7 Jan 2011 18:32:17 +0000 (18:32 +0000)]
declare_wslua.h is built, so we need to also search in the wslua build directory for it. (This fixes out-of-source-tree builds with Lua.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35421
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 7 Jan 2011 18:04:03 +0000 (18:04 +0000)]
** (process:23326): WARNING **: Field 'Reserved bit(s)' does not have an
abbreviation
** ERROR **: Field 'IPv4 Address' (gtpv2.ipv4_addr) is an FT_IPv4 but is being
displayed as BASE_DEC instead of BASE_NONE
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35420
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 7 Jan 2011 16:12:01 +0000 (16:12 +0000)]
Fix buildbot.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35419
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 7 Jan 2011 15:59:26 +0000 (15:59 +0000)]
Fix the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5554 :
Don't assume that g_strsplit() found and returned 3 strings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35418
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 7 Jan 2011 15:21:23 +0000 (15:21 +0000)]
Add dissection of more IE:s
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35417
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Jan 2011 00:26:57 +0000 (00:26 +0000)]
If we get an unknown reply status, don't print a g_warning message -
just put the reply body, if any, into the protocol tree as a blob. The
protocol tree will note that it's an unknown status.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35414
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 7 Jan 2011 00:19:28 +0000 (00:19 +0000)]
From Alexis La Goutte:
- Update RFC Draft (draft-vida-mld-v2-08.txt) to Final RFC
(RFC 3810)
- Make MLD field filterable
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5552
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35413
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 6 Jan 2011 23:34:46 +0000 (23:34 +0000)]
Tell the user about the Q&A site.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35412
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 6 Jan 2011 23:28:58 +0000 (23:28 +0000)]
On Windows, convert all of our command-line arguments from UTF-16 to
UTF-8 where we don't already do so. In Wireshark use g_utf16_to_utf8
instead of utf_16to8. This should fix bug 5520.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35411
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 6 Jan 2011 23:23:28 +0000 (23:23 +0000)]
Prohibit strtoull(): Windows doesn't have it. (Putting this in just saves waiting for the buildbot to complain.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35410
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Jan 2011 23:04:48 +0000 (23:04 +0000)]
Let's discourage the use of g_warning in dissectors. Either use one of
the dissector-bug macros, or try your best to dissect a packet that's
"wrong".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35409
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Jan 2011 22:52:40 +0000 (22:52 +0000)]
Don't use g_warning() - either you have a dissector bug, and should use
one of the macros to report that, or you have a problem with the packet,
in which case you should note that in the protocol tree, or you have
something you don't understand, in which case you should dissect
whatever of it you do understand and put something appropriate, if
possible, into the protocol tree for the rest.
(And, if the length isn't right, there's not much you can do about it -
you have to trust the length, and manage to fail somewhere else.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35408
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 6 Jan 2011 22:24:10 +0000 (22:24 +0000)]
More misc. CLDAP improvements for Active Directory including updating
field names and adding descriptions, changing the Domain GUID in the "LDAP
ping" response to a FT_GUID instead of FT_BYTES, etc.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35407
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 6 Jan 2011 21:07:58 +0000 (21:07 +0000)]
Fix the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5550 :
In dissect_amqp_0_10_array() if the 'type' is unknown, don't loop (for
potentially a very long time) adding the same element over and over again
(since the type is unknown, we don't know how much to increase the offset so
an exception is never thrown).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35406
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 6 Jan 2011 20:29:05 +0000 (20:29 +0000)]
Add URL to Lua website. Whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35405
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 6 Jan 2011 18:50:39 +0000 (18:50 +0000)]
More minor cleanup/fixes for MS Active Directory's use of CLDAP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35404
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 6 Jan 2011 18:08:14 +0000 (18:08 +0000)]
Minor corrections to NtVer dissection for NETLOGON_NT_VERSION Options Bits
in MSCLDAP packets per Microsoft's MS-ADTS specification, section 7.3.1.1,
revision 26 (11/19/2010). Also re-format code a bit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35403
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 6 Jan 2011 17:19:20 +0000 (17:19 +0000)]
GEOIP_COUNTRY_EDITION_V6 isn't guaranteed to be defined.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35402
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 6 Jan 2011 17:15:50 +0000 (17:15 +0000)]
When showing a DNS query response containing a SRV record, display items
in the tree of the service record broken out. For example,
"_ldap._tcp.domain.com" shows:
Service: ldap
Protocol: tcp
Name: domain.com
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35401
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 6 Jan 2011 16:08:56 +0000 (16:08 +0000)]
(After discussion on -dev) revert 35393: the old code is faster (and it is safe).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35400
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 6 Jan 2011 15:02:46 +0000 (15:02 +0000)]
strtoull() doesn't exist on Windows, use g_ascii_strtoull() instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35399
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 6 Jan 2011 03:08:03 +0000 (03:08 +0000)]
Use tvb_memeql() instead of memcmp()+tvb_get_ptr().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35398
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 6 Jan 2011 02:58:26 +0000 (02:58 +0000)]
Actually use proto_tree_add_item().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35397
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 6 Jan 2011 02:56:10 +0000 (02:56 +0000)]
There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_string: just use proto_tree_add_item().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35396
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 6 Jan 2011 02:52:00 +0000 (02:52 +0000)]
There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_string: just use proto_tree_add_item().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35395
f5534014-38df-0310-8fa8-
9805f1628bb7