obnox/wireshark/wip.git
10 years agoCMake:
jmayer [Mon, 21 Sep 2009 00:19:07 +0000 (00:19 +0000)]
CMake:

- Add opcua to the list of plugins to build
- Link the gtk stuff statically into wireshark
- Beginnings of "make install"
- Change a few things about install paths

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30029 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Gerasimos Dimitriadis:
etxrab [Sun, 20 Sep 2009 21:54:39 +0000 (21:54 +0000)]
From Gerasimos Dimitriadis:
DTAP decoding of Notification Indicator IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4029

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30028 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoTry to fix(take II):
etxrab [Sun, 20 Sep 2009 21:41:02 +0000 (21:41 +0000)]
Try to fix(take II):
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened:
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30027 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Kjell Hultman:
jake [Sun, 20 Sep 2009 21:08:04 +0000 (21:08 +0000)]
From Kjell Hultman:
IEC104 Signal dissection added - not complete (only implemented what I needed for the moment).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30026 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Jim Young via bug 4033:
krj [Sun, 20 Sep 2009 19:39:54 +0000 (19:39 +0000)]
From Jim Young via bug 4033:

With the "old" list if keyboard focus was initially in the details pane, the
use of the <F7>/<F8> keys will restore focus to details pane after the
prev/next move.   Without this patch "new" packet list prev/next moves simply
moves focus to summary pane.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30025 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFix return type for frame_data_init()
krj [Sun, 20 Sep 2009 19:01:23 +0000 (19:01 +0000)]
Fix return type for frame_data_init()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30024 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoIntroduce frame_data_cleanup() and start using it
krj [Sun, 20 Sep 2009 18:18:29 +0000 (18:18 +0000)]
Introduce frame_data_cleanup() and start using it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30023 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse frame_data_init() instead of the locally defined fill_in_fdata(), which will...
krj [Sun, 20 Sep 2009 18:02:22 +0000 (18:02 +0000)]
Use frame_data_init() instead of the locally defined fill_in_fdata(), which will be removed as part of this change

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30022 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoIntroduce frame_data_init() and get rid of fill_in_fdata() in tshark.c
krj [Sun, 20 Sep 2009 17:51:16 +0000 (17:51 +0000)]
Introduce frame_data_init() and get rid of fill_in_fdata() in tshark.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30021 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoMove verbose banner output to show_version() and tighten scope of some variables
krj [Sun, 20 Sep 2009 17:45:17 +0000 (17:45 +0000)]
Move verbose banner output to show_version() and tighten scope of some variables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30020 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoMake cf_mark_frame() an empty stub in tshark.c. We only need it to satisfy a linker...
krj [Sun, 20 Sep 2009 16:48:52 +0000 (16:48 +0000)]
Make cf_mark_frame() an empty stub in tshark.c. We only need it to satisfy a linker dependency. Add a comment in tap-rtp-common.c indicating that is is wrong to refer to cf_mark_frame() which is only applicable for the GTK UI backend.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30019 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoRemove unused cf_unmark_frame() function
krj [Sun, 20 Sep 2009 16:30:12 +0000 (16:30 +0000)]
Remove unused cf_unmark_frame() function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30018 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoMove verbose banner output to show_version() and tighten scope of some variables
krj [Sun, 20 Sep 2009 16:16:15 +0000 (16:16 +0000)]
Move verbose banner output to show_version() and tighten scope of some variables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30017 f5534014-38df-0310-8fa8-9805f1628bb7

10 years ago[Automatic manuf and enterprise-numbers update for 2009-09-20]
gerald [Sun, 20 Sep 2009 15:03:29 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-09-20]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30014 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoOnly duplicate string the first time around, i.e. 'pinfo->fd->flags.visited == FALSE...
krj [Sun, 20 Sep 2009 13:36:16 +0000 (13:36 +0000)]
Only duplicate string the first time around, i.e. 'pinfo->fd->flags.visited == FALSE' or else we end up leaking memory

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30013 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse ep_verify_pointer() in col_set_str() to verify that the caller hasn't passed...
krj [Sun, 20 Sep 2009 12:09:25 +0000 (12:09 +0000)]
Use ep_verify_pointer() in col_set_str() to verify that the caller hasn't passed us something from the ephemeral pool

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30012 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd ep_verify_pointer()/se_verify_pointer() which checks whether the given pointer...
krj [Sun, 20 Sep 2009 12:02:40 +0000 (12:02 +0000)]
Add ep_verify_pointer()/se_verify_pointer() which checks whether the given pointer belongs in the seasonal/ephemeral pool.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30011 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAssert on null string in col_set_str(). This is reasonable behaviour since the caller...
krj [Sun, 20 Sep 2009 10:19:37 +0000 (10:19 +0000)]
Assert on null string in col_set_str(). This is reasonable behaviour since the caller is expeceted to pass in a constant string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30010 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoRemove unused/dead code
krj [Sun, 20 Sep 2009 09:32:52 +0000 (09:32 +0000)]
Remove unused/dead code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30009 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoMake se_trees static in emem.c
krj [Sun, 20 Sep 2009 09:28:55 +0000 (09:28 +0000)]
Make se_trees static in emem.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30008 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoBump version number after release of first development snapshot.
jake [Sun, 20 Sep 2009 09:19:59 +0000 (09:19 +0000)]
Bump version number after release of first development snapshot.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30007 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd myself and Kovarththanan Rajaratnam as co authors.
etxrab [Sun, 20 Sep 2009 09:12:56 +0000 (09:12 +0000)]
Add myself and Kovarththanan Rajaratnam as co authors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30006 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse g_new()
krj [Sun, 20 Sep 2009 09:03:02 +0000 (09:03 +0000)]
Use g_new()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30005 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd NEW_PACKET_LIST guard
krj [Sun, 20 Sep 2009 08:51:30 +0000 (08:51 +0000)]
Add NEW_PACKET_LIST guard

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30004 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse tvb_get_ephemeral_string() to avoid memleak (should have been part of r29994.
krj [Sun, 20 Sep 2009 08:42:51 +0000 (08:42 +0000)]
Use tvb_get_ephemeral_string() to avoid memleak (should have been part of r29994.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30003 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse tvb_get_ephemeral_stringz() instead of tvb_get_stringz()
krj [Sun, 20 Sep 2009 08:40:01 +0000 (08:40 +0000)]
Use tvb_get_ephemeral_stringz() instead of tvb_get_stringz()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30002 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse tvb_get_ephemeral_string() to avoid memleak.
krj [Sun, 20 Sep 2009 08:35:49 +0000 (08:35 +0000)]
Use tvb_get_ephemeral_string() to avoid memleak.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30001 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse tvb_get_ephemeral_string() instead of tvb_get_string()
krj [Sun, 20 Sep 2009 08:31:24 +0000 (08:31 +0000)]
Use tvb_get_ephemeral_string() instead of tvb_get_string()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30000 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse tvb_get_ephemeral_string() instead of tvb_get_string()
krj [Sun, 20 Sep 2009 08:28:04 +0000 (08:28 +0000)]
Use tvb_get_ephemeral_string() instead of tvb_get_string()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29999 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse ep_alloc() instead of g_malloc() for packet scoped allocations
krj [Sun, 20 Sep 2009 08:24:35 +0000 (08:24 +0000)]
Use ep_alloc() instead of g_malloc() for packet scoped allocations

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29998 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFix for:
etxrab [Sun, 20 Sep 2009 08:22:00 +0000 (08:22 +0000)]
Fix for:
Columns Lazy initialization clobbers cinfo packet buffer. Open a file, goto packet 1000, menu View->Show packet in a new window, the wrong packet is decoded (it's the last displayed in the packet list pane). gtk/packet_win.c:new_window_cb() should call wtap_seek_reread().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29997 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse tvb_get_ephemeral_string() to avoid memleak.
krj [Sun, 20 Sep 2009 08:15:51 +0000 (08:15 +0000)]
Use tvb_get_ephemeral_string() to avoid memleak.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29996 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse ep_alloc() instead of g_malloc() for packet scoped allocations
krj [Sun, 20 Sep 2009 08:09:40 +0000 (08:09 +0000)]
Use ep_alloc() instead of g_malloc() for packet scoped allocations

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29995 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse tvb_get_ephemeral_string() to avoid memleak.
krj [Sun, 20 Sep 2009 08:06:20 +0000 (08:06 +0000)]
Use tvb_get_ephemeral_string() to avoid memleak.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29994 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse tvb_get_ephemeral_string() instead of tvb_get_string()
krj [Sun, 20 Sep 2009 07:56:16 +0000 (07:56 +0000)]
Use tvb_get_ephemeral_string() instead of tvb_get_string()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29993 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd a couple of g_asserts
krj [Sun, 20 Sep 2009 07:48:33 +0000 (07:48 +0000)]
Add a couple of g_asserts

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29992 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse G_STRLOC
krj [Sun, 20 Sep 2009 07:46:12 +0000 (07:46 +0000)]
Use G_STRLOC

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29991 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse tvb_get_ephemeral_string() to avoid memleak.
krj [Sun, 20 Sep 2009 07:44:34 +0000 (07:44 +0000)]
Use tvb_get_ephemeral_string() to avoid memleak.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29990 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoTry to fix:
etxrab [Sun, 20 Sep 2009 07:35:55 +0000 (07:35 +0000)]
Try to fix:
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened:
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29989 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoRemove 'type' formal parameter from tvb_new_with_subset()
krj [Sun, 20 Sep 2009 07:35:39 +0000 (07:35 +0000)]
Remove 'type' formal parameter from tvb_new_with_subset()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29988 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd support for opening separate packet window when you double-click on
guy [Sat, 19 Sep 2009 22:51:42 +0000 (22:51 +0000)]
Add support for opening separate packet window when you double-click on
a row in the packet list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29987 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom yami<yamisoe At ...>: Fix Bug #3542: get_dfs_referral referral entry is not...
wmeier [Fri, 18 Sep 2009 22:41:04 +0000 (22:41 +0000)]
From  yami<yamisoe At ...>: Fix Bug #3542: get_dfs_referral referral entry is not dissected corectly.

(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3542)

The current get_dfs_referral response code is based on old protocol specs,
which are unofficial, erroneous.

I modify packet-smb.c to be confirm to protocol's official spec. Some
changes are:

  1. handle referral entry version 2, 3, 4 separately. The current code does
not distinguish v3 from v2, however they are not same.
  2. change server type, referral flags etc.
  3. refactor some code, such as string dissecting.

Also: From me: a small change to handle possible overflow
when subtracting from a guint16.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29986 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoTry again...
martinm [Fri, 18 Sep 2009 22:01:30 +0000 (22:01 +0000)]
Try again...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29985 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoChange type to try to fix win64 build breakage.
martinm [Fri, 18 Sep 2009 17:10:35 +0000 (17:10 +0000)]
Change type to try to fix win64 build breakage.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29984 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse a UAT table to map from LCIDs 3-10 to RLC drb channel.
martinm [Fri, 18 Sep 2009 16:27:02 +0000 (16:27 +0000)]
Use a UAT table to map from LCIDs 3-10 to RLC drb channel.
Call RLC dissector for mapped LCIDs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29983 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd coments.
etxrab [Fri, 18 Sep 2009 14:03:45 +0000 (14:03 +0000)]
Add coments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29982 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoSet focus to packet list when a row is selected.
etxrab [Fri, 18 Sep 2009 14:01:10 +0000 (14:01 +0000)]
Set focus to packet list when a row is selected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29981 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Thomas Dreibholz:
jake [Fri, 18 Sep 2009 06:32:43 +0000 (06:32 +0000)]
From Thomas Dreibholz:
Added support for decoding the Info field in the SSP Ready message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29980 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Harald Welte:
jake [Fri, 18 Sep 2009 06:29:00 +0000 (06:29 +0000)]
From Harald Welte:
Errors occur which means decrypted_len - esp_iv len will render a negative value and thus
cause the problem. This patch prevents the crash. Not sure if this is a proper fix. At least it
looks like a sane check to do.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29979 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoIndicate if "with new_packet_list" in version info (for now to minimize any confusion).
wmeier [Fri, 18 Sep 2009 00:31:27 +0000 (00:31 +0000)]
Indicate if "with new_packet_list" in version info (for now to minimize any confusion).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29978 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoInstall the CRT DLLs using the Visual C++ Redistributable Package
gerald [Thu, 17 Sep 2009 21:54:52 +0000 (21:54 +0000)]
Install the CRT DLLs using the Visual C++ Redistributable Package
(vcredist_x64.exe) on Win64. This should fix bug 4024.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29977 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd new IANA registered AVP:s as comments.
etxrab [Thu, 17 Sep 2009 19:46:16 +0000 (19:46 +0000)]
Add new IANA registered AVP:s as comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29976 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoMinor ASN1 update.
etxrab [Thu, 17 Sep 2009 19:45:00 +0000 (19:45 +0000)]
Minor ASN1 update.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29975 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoRemove a cast.
gerald [Thu, 17 Sep 2009 16:52:42 +0000 (16:52 +0000)]
Remove a cast.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29974 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd some missing files to the distribution.
gerald [Thu, 17 Sep 2009 16:39:23 +0000 (16:39 +0000)]
Add some missing files to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29973 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFix the Freetype DLL name on Win64.
gerald [Thu, 17 Sep 2009 15:33:34 +0000 (15:33 +0000)]
Fix the Freetype DLL name on Win64.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29972 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoChange ENUM:s
etxrab [Thu, 17 Sep 2009 15:09:26 +0000 (15:09 +0000)]
Change ENUM:s

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29971 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse a value_string for Mobility options, update the value string with values from...
etxrab [Thu, 17 Sep 2009 13:54:54 +0000 (13:54 +0000)]
Use a value_string for Mobility options, update the value string with values from IANA.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29970 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFix bug in IE decoding.
etxrab [Thu, 17 Sep 2009 13:53:52 +0000 (13:53 +0000)]
Fix bug in IE decoding.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29969 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoRemove debug printout.
etxrab [Thu, 17 Sep 2009 13:53:06 +0000 (13:53 +0000)]
Remove debug printout.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29968 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoTry to get the win64 build going.
etxrab [Thu, 17 Sep 2009 13:49:34 +0000 (13:49 +0000)]
Try to get the win64 build going.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29967 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoTry to get the Solaris build going...
etxrab [Thu, 17 Sep 2009 13:43:43 +0000 (13:43 +0000)]
Try to get the Solaris build going...
(Google is your friend)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29966 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFix handling of new-packet-list.
tuexen [Thu, 17 Sep 2009 09:41:59 +0000 (09:41 +0000)]
Fix handling of new-packet-list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29965 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoMake the new packet list the default build choice.
etxrab [Thu, 17 Sep 2009 08:29:10 +0000 (08:29 +0000)]
Make the new packet list the default build choice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29964 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Gerasimos Dimitriadis:
jake [Thu, 17 Sep 2009 06:41:44 +0000 (06:41 +0000)]
From Gerasimos Dimitriadis:
Add decoding support for the codec bitmap in DTAP Supported Codec List IE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29963 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse latest GTK suport libs.
etxrab [Thu, 17 Sep 2009 06:16:24 +0000 (06:16 +0000)]
Use latest GTK suport libs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29962 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Steve via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3781 :
morriss [Thu, 17 Sep 2009 03:01:26 +0000 (03:01 +0000)]
From Steve via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3781 :

In ntp_fmt_ts() in packet-ntp.c time stamps are displayed to 4 digits (0.1
msec).   More digits may be significant (e.g., if GPS local clocks are used).

Change time stamp format in g_snprintf() from
  %07.4f
to
  %09.6f

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29961 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoWe pass the file handle to snoop_read_shomiti_wireless_pseudoheader();
guy [Thu, 17 Sep 2009 03:00:20 +0000 (03:00 +0000)]
We pass the file handle to snoop_read_shomiti_wireless_pseudoheader();
use that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29960 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoWe need an err_info argument to snoop_read_shomiti_wireless_pseudoheader,
guy [Thu, 17 Sep 2009 02:59:26 +0000 (02:59 +0000)]
We need an err_info argument to snoop_read_shomiti_wireless_pseudoheader,
as it might fill that in.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29959 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoDo *NOT* skip the rest of the header by reading into a fixed-size buffer
guy [Thu, 17 Sep 2009 02:42:31 +0000 (02:42 +0000)]
Do *NOT* skip the rest of the header by reading into a fixed-size buffer
on the stack! There is no guarantee that the header length won't cause a
buffer overflow - there could be a bug in some version of Surveyor
generating a bad file, there could be a future version of Surveyor that
has a really big pseudo-header, the file could've been written by
something other than Surveyor that has a bug in it, there could be a
file that's corrupted in transit, or there could be a deliberately
malformed packet trying to cause *Shark to execute arbitrary code.

Also, explicitly check for a too-short header length and fail with
WTAP_ERR_BAD_RECORD in that case.

Add some comments asking some questions about the header.

(The previous change was for bug 3856:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3856

not bug 3865.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29958 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom zeemon via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3848 :
morriss [Thu, 17 Sep 2009 02:37:57 +0000 (02:37 +0000)]
From zeemon via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3848 :

epan\dissectors\packet-edonkey.c
In the fuction dissect_emule_sourceOBFU(): the line

ti = proto_tree_add_item(tree, hf_emule_sourceOBFU, tvb, offset, 7 + ((settings & 0x08) ? 16 : 0), FALSE);

should be

ti = proto_tree_add_item(tree, hf_emule_sourceOBFU, tvb, offset, 7 + ((settings & 0x80) ? 16 : 0), FALSE);

and, the line:

if (settings & 0x08)

should be:

if (settings & 0x80)

That is, 0x08 should be revised to 0x80.

reference: the eMule0.49c source code, file PartFile.cpp, line 2730, in the
function CPartFile::AddSources().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29957 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Clay Jones via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3865 :
morriss [Thu, 17 Sep 2009 02:12:08 +0000 (02:12 +0000)]
From Clay Jones via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3865 :

The Shomiti Wireless head was modified in a recent release such that wireshark
can no longer read Shomiti wireless capture files.

This new format is backwards compatible with the old format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29956 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFix typo in comment.
guy [Thu, 17 Sep 2009 02:02:21 +0000 (02:02 +0000)]
Fix typo in comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29955 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Don Chirieleison via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3914 :
morriss [Thu, 17 Sep 2009 01:49:55 +0000 (01:49 +0000)]
From Don Chirieleison via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3914 :

SDNVs are theoretically unlimited in size.  The value of most SDNVs in the
Bundle Protocol is practically limited to far less than a 32 bit number. The
initial dissector included only 1 SDNV evaluation routine which returned a 32
bit number. SDNV fields that evaluated to greater than a 32 bit number were
considered in error. One BP implementation chose to add some syntax to one of
the SDNV fields that extends it to more than 32 bits. The patch included here
adds an evaluation routine that will return a 64 bit number. That routine is
called to evaluate the field where it makes sense to have a value in excess of
32 bits.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29954 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Gregor Jasny via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3921 :
morriss [Thu, 17 Sep 2009 01:39:15 +0000 (01:39 +0000)]
From Gregor Jasny via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3921 :

Improved AIM protocol dissector:

* Decodes more values acording to official Oscar spec
* Renamed clientautoresp to client_err (as written in spec)
* Fix decoding orror on rendezvous channel
* Other small improvements

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29953 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoTry to fix the build.
gerald [Thu, 17 Sep 2009 01:18:51 +0000 (01:18 +0000)]
Try to fix the build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29952 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFix a typo.
wmeier [Wed, 16 Sep 2009 23:24:31 +0000 (23:24 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29951 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd info as to 32/64 bit and also if "Windows 7" to runtime version info.
wmeier [Wed, 16 Sep 2009 23:13:34 +0000 (23:13 +0000)]
Add info as to 32/64 bit and also if "Windows 7" to runtime version info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29950 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoMake sure we don't fetch too much data from the registry.
gerald [Wed, 16 Sep 2009 20:29:00 +0000 (20:29 +0000)]
Make sure we don't fetch too much data from the registry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29949 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoCheck for TCP Chimney offloading as described at
gerald [Wed, 16 Sep 2009 19:23:15 +0000 (19:23 +0000)]
Check for TCP Chimney offloading as described at
http://support.microsoft.com/kb/912222. Print a warning on the welcome
page if it's present and enabled.

This hasn't yet been tested on a chimney-enabled machine, but it should
work.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29948 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Florian Forster:
jake [Wed, 16 Sep 2009 19:02:51 +0000 (19:02 +0000)]
From Florian Forster:
Version 4.8.0 of collectd introduced two new data source types: DERIVE and ABSOLUTE.
With this patch support for the new data source types is added so they are displayed correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29947 f5534014-38df-0310-8fa8-9805f1628bb7

10 years ago(Trivial) Update a comment and an error message.
wmeier [Wed, 16 Sep 2009 16:27:37 +0000 (16:27 +0000)]
(Trivial) Update a comment and an error message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29946 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Gerasimos Dimitriadis via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id...
morriss [Wed, 16 Sep 2009 13:45:58 +0000 (13:45 +0000)]
From Gerasimos Dimitriadis via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4020 :

Associated Radio Capability 1 should not be added to a subtree, but to the IE
tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29945 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd a couple of new hf_ entries to deal with the different bit positions
morriss [Wed, 16 Sep 2009 13:39:37 +0000 (13:39 +0000)]
Add a couple of new hf_ entries to deal with the different bit positions
for the MS Power Level and FPC in the L1 Information and MS Power IEs.

This should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4017

(though I don't have a sample capture to verify the fix and that I didn't
break anything.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29944 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoUse the latest GTK packages.
etxrab [Wed, 16 Sep 2009 13:34:37 +0000 (13:34 +0000)]
Use the latest GTK packages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29943 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoBuild a few more plugins
jmayer [Wed, 16 Sep 2009 06:30:03 +0000 (06:30 +0000)]
Build a few more plugins

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29942 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoMove some of the -I stuff from top level to epan.
jmayer [Wed, 16 Sep 2009 04:20:58 +0000 (04:20 +0000)]
Move some of the -I stuff from top level to epan.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29941 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd a couple of updates.
gerald [Tue, 15 Sep 2009 19:57:51 +0000 (19:57 +0000)]
Add a couple of updates.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29938 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoSave some memory: Don't statically allocate ett[] arrays used "dynamically".
wmeier [Tue, 15 Sep 2009 18:20:56 +0000 (18:20 +0000)]
Save some memory: Don't statically allocate ett[] arrays used "dynamically".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29934 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAdd more summary to top-level item.
martinm [Tue, 15 Sep 2009 17:49:58 +0000 (17:49 +0000)]
Add more summary to top-level item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29931 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoSave some memory: Don't statically allocate ett[] arrays used "dynamically".
wmeier [Tue, 15 Sep 2009 17:37:54 +0000 (17:37 +0000)]
Save some memory: Don't statically allocate ett[] arrays used "dynamically".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29929 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoAlso mark tree as an unmarked parameter.
martinm [Tue, 15 Sep 2009 17:07:54 +0000 (17:07 +0000)]
Also mark tree as an unmarked parameter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29928 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Ivan Sy via bug #3931: Add Ivan to the list of authors
sfisher [Tue, 15 Sep 2009 17:01:57 +0000 (17:01 +0000)]
From Ivan Sy via bug #3931: Add Ivan to the list of authors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29927 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoif (proto_... == -1) not req'd.
wmeier [Tue, 15 Sep 2009 16:52:07 +0000 (16:52 +0000)]
if (proto_... == -1) not req'd.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29926 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoRemove now unused variables.
etxrab [Tue, 15 Sep 2009 16:46:30 +0000 (16:46 +0000)]
Remove now unused variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29925 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoBearer Context not dissected correctly.
etxrab [Tue, 15 Sep 2009 15:54:06 +0000 (15:54 +0000)]
Bearer Context not dissected correctly.
Use the built in IE decoding by calling dissect_gtpv2_ie_common() for
the grouped IE:s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29924 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoSwitch back to normal versioning.
gerald [Tue, 15 Sep 2009 15:46:44 +0000 (15:46 +0000)]
Switch back to normal versioning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29923 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoDon't call check_col(). Add a space at the end of each COL_INFO entry to make the...
morriss [Tue, 15 Sep 2009 15:16:15 +0000 (15:16 +0000)]
Don't call check_col().  Add a space at the end of each COL_INFO entry to make the column more readable when SCTP bundles multiple messages together.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29922 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFrom Jakub Zawadzki:
krj [Tue, 15 Sep 2009 14:01:40 +0000 (14:01 +0000)]
From Jakub Zawadzki:

Fix copy/paste error wrt. fdata->col_text_len

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29921 f5534014-38df-0310-8fa8-9805f1628bb7

10 years agoFix:
etxrab [Tue, 15 Sep 2009 13:18:13 +0000 (13:18 +0000)]
Fix:
cleanup_dissection() calls se_free_all(); And after that fdata->col_text (which is allocated using se_alloc0()) no longer points to valid memory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29920 f5534014-38df-0310-8fa8-9805f1628bb7