obnox/wireshark/wip.git
11 years agoMake the document icon brighter and clean it up.
gerald [Sat, 15 Mar 2008 19:46:26 +0000 (19:46 +0000)]
Make the document icon brighter and clean it up.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24641 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCheck in the OS X packaging patch from bug 2341, since I've had
gerald [Sat, 15 Mar 2008 18:31:52 +0000 (18:31 +0000)]
Check in the OS X packaging patch from bug 2341, since I've had
confirmation that the OS X package works on at least one system
other than my laptop.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24640 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix trivial spelling error
wmeier [Sat, 15 Mar 2008 18:17:52 +0000 (18:17 +0000)]
Fix trivial spelling error

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24639 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd register_ber_oid_dissector to the exported functions.
etxrab [Sat, 15 Mar 2008 11:40:49 +0000 (11:40 +0000)]
Add register_ber_oid_dissector to the exported functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24638 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoTry to fix distcheck again.
gerald [Sat, 15 Mar 2008 00:21:02 +0000 (00:21 +0000)]
Try to fix distcheck again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24637 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix distcheck.
gerald [Fri, 14 Mar 2008 23:43:35 +0000 (23:43 +0000)]
Fix distcheck.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24636 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdates and fixes.
gerald [Fri, 14 Mar 2008 22:06:05 +0000 (22:06 +0000)]
Updates and fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24635 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake sure the Infiniband plugin is properly built and packaged.
gerald [Fri, 14 Mar 2008 21:53:16 +0000 (21:53 +0000)]
Make sure the Infiniband plugin is properly built and packaged.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24634 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Dustin D. Trammell:
jake [Fri, 14 Mar 2008 21:36:01 +0000 (21:36 +0000)]
From Dustin D. Trammell:
The FIX protocol dissector uses the 6 byte string "8=FIX." at the beginning of
the data to match the beginning of a FIX version string of the format
"8=FIX.x.x" in order to determine if the data is the FIX protocol or not.
With FIX 5.x and beyond, the beginning of the data will have a version string
of the format "8=FIXT.x.x" to indicate the FIX Transport (FIXT) version.

A simple solution is to update the current FIX dissector to only match the
first 5 bytes of the version string (see attached patch).  This will cause a
match for FIX version 4.x and prior (8=FIX.x.x) as well as 5.x and beyond
(8=FIXT.x.x).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24633 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded missing Id keywords, eol-style and ignore targets.
stig [Fri, 14 Mar 2008 19:48:49 +0000 (19:48 +0000)]
Added missing Id keywords, eol-style and ignore targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24632 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake infiniband plugin compile.
stig [Fri, 14 Mar 2008 19:35:54 +0000 (19:35 +0000)]
Make infiniband plugin compile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24631 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded check for length in heuristic check so we don't dissect unknown
stig [Fri, 14 Mar 2008 19:03:56 +0000 (19:03 +0000)]
Added check for length in heuristic check so we don't dissect unknown
TCP packets with less than 5 bytes data as a malformed XCSL packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24630 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoTry out a new Windows document icon.
gerald [Fri, 14 Mar 2008 17:57:38 +0000 (17:57 +0000)]
Try out a new Windows document icon.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24629 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Stephen Donnelly via bug 2235:
gerald [Fri, 14 Mar 2008 17:47:53 +0000 (17:47 +0000)]
From Stephen Donnelly via bug 2235:
This plugin implements a dissector for Infiniband. It is released
under the GPL v2.

Rather than using say libpcap to capture raw (unframed) IP packets
from near the top of an IPoIB stack, this plugin dissects link level
Infiniband frames.

Infiniband trace files can be read from Endace ERF format trace
files, or from libpcap DLT_ERF files containing ERF TYPE_INFINIBAND
records. There is currently no native DLT_INFINIBAND in libpcap.

Each record contains a hardware timestamp, capture metadata such as
port Id, and a complete link level Infiniband frame starting from
the Local Route Header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24628 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Dan Messinger:
jake [Fri, 14 Mar 2008 07:45:30 +0000 (07:45 +0000)]
From Dan Messinger:
The OSD APPEND command does not use the sort order field. Wireshark is decoding it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24627 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAttribute Xcsl dissector.
jake [Fri, 14 Mar 2008 07:10:07 +0000 (07:10 +0000)]
Attribute Xcsl dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24626 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix bug #1143 - Can't read packet details....bad color scheme forced
sfisher [Fri, 14 Mar 2008 06:15:06 +0000 (06:15 +0000)]
Fix bug #1143 - Can't read packet details....bad color scheme forced

Change the code so we don't force a white background in the protocol tree
area, instead just unset it so it goes back to its natural background.  This
matters with color schemes that have a black background.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24625 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate documentation information.
guy [Fri, 14 Mar 2008 03:28:12 +0000 (03:28 +0000)]
Update documentation information.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24624 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate documentation links.
guy [Fri, 14 Mar 2008 03:23:36 +0000 (03:23 +0000)]
Update documentation links.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24623 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Hannes Kalber:
gerald [Fri, 14 Mar 2008 00:01:51 +0000 (00:01 +0000)]
From Hannes Kalber:

This patch adds some new ENCAP and FILE types for wiretap. It also adds new
entries to pcap_to_wtap_map[] to provide a mapping of the new types to some
pcap DLTs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24622 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Hariharan Ananthakrishnan:
gerald [Thu, 13 Mar 2008 23:45:48 +0000 (23:45 +0000)]
From Hariharan Ananthakrishnan:

I have added two new display filters to support filtering based on LSP-ID and
hostname for ISIS protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24621 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake the SMI preference a little more verbose. In the COPS and SNMP
gerald [Thu, 13 Mar 2008 22:17:11 +0000 (22:17 +0000)]
Make the SMI preference a little more verbose. In the COPS and SNMP
preferences, tell the user where they can change the SMI settings. In
the 802.11 preferences, fix a tooltip.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24620 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoPartial fix for bug 2153
jake [Thu, 13 Mar 2008 18:32:10 +0000 (18:32 +0000)]
Partial fix for bug 2153
AMF object ID is in the lower 6 bits of the octet

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24619 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemove leftover debug code.
gerald [Thu, 13 Mar 2008 14:45:52 +0000 (14:45 +0000)]
Remove leftover debug code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24618 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake SABP work over registered ports.
martinm [Thu, 13 Mar 2008 11:54:06 +0000 (11:54 +0000)]
Make SABP work over registered ports.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24617 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix a minor memory leak.
sfisher [Thu, 13 Mar 2008 06:25:53 +0000 (06:25 +0000)]
Fix a minor memory leak.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24616 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agosscanf() apparently handles negative input values, even when your
gerald [Thu, 13 Mar 2008 05:24:21 +0000 (05:24 +0000)]
sscanf() apparently handles negative input values, even when your
target is an unsigned int.  Adjust our bogus value check to match
the recent int -> guint change. Fixes bug 2355.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24615 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSave about 1MB of RAM that was wasted for the entire Wireshark session.
sfisher [Thu, 13 Mar 2008 04:49:37 +0000 (04:49 +0000)]
Save about 1MB of RAM that was wasted for the entire Wireshark session.
This is done by using dynamically allocated memory for tpncp field names
instead of relying on a static array of 256 bytes.  This makes a noticeable
difference because there are so many entries in tpncp/tpncp.dat.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24614 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed uint -> guint.
stig [Wed, 12 Mar 2008 21:43:37 +0000 (21:43 +0000)]
Fixed uint -> guint.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24613 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2344:
jake [Wed, 12 Mar 2008 21:25:42 +0000 (21:25 +0000)]
Fix for bug 2344:
AMF number if a double, not a uint16.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24612 f5534014-38df-0310-8fa8-9805f1628bb7

11 years ago+ DHCP overload option parsing changes (triggered by bug 2194):
jmayer [Wed, 12 Mar 2008 21:00:00 +0000 (21:00 +0000)]
+ DHCP overload option parsing changes (triggered by bug 2194):
  - The overloaded options are displayed at the same level as other options
  - The bootp file and server name options are displayed as overloaded if
    appropriate. To achieve this the bootp header parsing code needed to be
    moved to a later point.
+ Some signedness warning fixes.
+ Make a global variable (novell_string) static

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24611 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed server and client packet count in C Array variables in
stig [Wed, 12 Mar 2008 08:50:09 +0000 (08:50 +0000)]
Fixed server and client packet count in C Array variables in
Follow TCP/UDP/SSL Stream.  This error was introduced when merging
duplicate code between TCP & SSL stream functions, r22869.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24610 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Nathan Jennings (bug 2350):
stig [Wed, 12 Mar 2008 07:16:25 +0000 (07:16 +0000)]
From Nathan Jennings (bug 2350):
Highlight the selected interface in the edit interfaces list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24609 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix some texts in the file types list.
stig [Tue, 11 Mar 2008 22:50:17 +0000 (22:50 +0000)]
Fix some texts in the file types list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24608 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDisable the "Packet Format" when save as "C Arrays".
stig [Tue, 11 Mar 2008 21:06:56 +0000 (21:06 +0000)]
Disable the "Packet Format" when save as "C Arrays".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24607 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded "C Arrays" to list of file types to export.
stig [Tue, 11 Mar 2008 19:35:53 +0000 (19:35 +0000)]
Added "C Arrays" to list of file types to export.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24606 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoIf we haven't found a handshake packet, say so.
gerald [Tue, 11 Mar 2008 18:32:20 +0000 (18:32 +0000)]
If we haven't found a handshake packet, say so.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24605 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Francesco Fondelli (bug 2349):
stig [Tue, 11 Mar 2008 18:23:16 +0000 (18:23 +0000)]
From Francesco Fondelli (bug 2349):
Attached is a patch to export packets data as "C Arrays".  I often have
the need to [re]send data captured with wireshark using a raw/pf_packet socket.
Output format is one char[] per packet, it looks like almost the same as
the one produced by "Follow TCP stream".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24604 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd check for gtk 2.4 when calling gtk_tree_view_column_set_expand.
stig [Tue, 11 Mar 2008 17:27:41 +0000 (17:27 +0000)]
Add check for gtk 2.4 when calling gtk_tree_view_column_set_expand.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24603 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix a typo.
etxrab [Mon, 10 Mar 2008 20:28:21 +0000 (20:28 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24602 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Dick Gooris:
jake [Mon, 10 Mar 2008 19:28:03 +0000 (19:28 +0000)]
From Dick Gooris:
The protocol is called Xcsl a TCP based and ASCII based protocol that is used
to control call generators. The Xcsl dissector decodes the Call Specification
Language.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24601 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate comments.
jake [Mon, 10 Mar 2008 17:33:53 +0000 (17:33 +0000)]
Update comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24600 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoChange the BSD-licensed written by CACE to BSD+GPL.
gerald [Mon, 10 Mar 2008 17:20:15 +0000 (17:20 +0000)]
Change the BSD-licensed written by CACE to BSD+GPL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24599 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2328.
martinm [Mon, 10 Mar 2008 15:36:44 +0000 (15:36 +0000)]
Fix for bug 2328.

I can see this function is used in limited places.
I'm not sure if BASE_RANGE_STRING needs to masked out
of hfinfo->display in various other functions in proto.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24598 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoved an unused variable.
stig [Mon, 10 Mar 2008 09:31:49 +0000 (09:31 +0000)]
Removed an unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24597 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Sami Farin:
jake [Mon, 10 Mar 2008 07:53:46 +0000 (07:53 +0000)]
From Sami Farin:
Reads EMEM_CANARY_DATA_SIZE (15) bytes, compares return value to EMEM_CANARY_SIZE (8).
Also, I also added setbuf call in patch so it reads 15 bytes instead of 4096 or 8192.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24596 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix bug #2343: Huge increase in Wireshark runtime memory foot print ...
sfisher [Mon, 10 Mar 2008 07:37:14 +0000 (07:37 +0000)]
Fix bug #2343: Huge increase in Wireshark runtime memory foot print ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24595 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoComplete binary tree description with string keys.
jake [Sun, 9 Mar 2008 19:48:50 +0000 (19:48 +0000)]
Complete binary tree description with string keys.
Update some entries in developer doc.
Add some preference description in POD.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24594 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2009 : if the dissector told...
morriss [Sun, 9 Mar 2008 14:50:14 +0000 (14:50 +0000)]
Fix bugs.wireshark.org/bugzilla/show_bug.cgi?id=2009 : if the dissector told us how to format the representation of an item then indicate if we truncated it (we were already doing this if we formatted the representation).  Do the same for FT_BYTES.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24593 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd a const.
stig [Sun, 9 Mar 2008 14:20:28 +0000 (14:20 +0000)]
Add a const.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24592 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoShow VarBind OIDs and trap enterprise OID in info column.
stig [Sun, 9 Mar 2008 13:58:58 +0000 (13:58 +0000)]
Show VarBind OIDs and trap enterprise OID in info column.

Initialize pdu_type in dissect_snmp_PDUs() and param_tvb in
dissect_snmp_SnmpEngineID() to avoid potential crashes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24591 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate almost year out of date file, with over 150 changes and over 1800 additions.
jake [Sun, 9 Mar 2008 12:33:43 +0000 (12:33 +0000)]
Update almost year out of date file, with over 150 changes and over 1800 additions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24590 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCorrected a typo: octestring -> octetstring.
stig [Sun, 9 Mar 2008 11:24:37 +0000 (11:24 +0000)]
Corrected a typo: octestring -> octetstring.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24589 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDisplay agent-addr as IPv4 address.
stig [Sun, 9 Mar 2008 10:54:55 +0000 (10:54 +0000)]
Display agent-addr as IPv4 address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24588 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWarn if a file does not have an SVN Id tag in it.
morriss [Sat, 8 Mar 2008 21:23:14 +0000 (21:23 +0000)]
Warn if a file does not have an SVN Id tag in it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24587 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=383 : show multiple (pipelined...
morriss [Sat, 8 Mar 2008 21:17:43 +0000 (21:17 +0000)]
Fix bugs.wireshark.org/bugzilla/show_bug.cgi?id=383 : show multiple (pipelined) HTTP packets in the Info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24586 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake some text verbatim.
gerald [Fri, 7 Mar 2008 23:44:40 +0000 (23:44 +0000)]
Make some text verbatim.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24585 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd Id tag
morriss [Fri, 7 Mar 2008 23:12:05 +0000 (23:12 +0000)]
Add Id tag

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24584 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdjust the RTP heuristic dissector:
martinm [Fri, 7 Mar 2008 18:15:46 +0000 (18:15 +0000)]
Adjust the RTP heuristic dissector:
- loosen by accpepting dynamic payload type range
- tighten by only accepting even-numbered ports

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24583 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdated to Version 2.0 Draft 6.
stig [Fri, 7 Mar 2008 12:22:20 +0000 (12:22 +0000)]
Updated to Version 2.0 Draft 6.
Removed unofficial port numbers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24582 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Ben B.: Correct the info as to dissector integration using idl2wrs
wmeier [Fri, 7 Mar 2008 05:10:18 +0000 (05:10 +0000)]
From Ben B.: Correct the info as to dissector integration using idl2wrs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24581 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded an option to uat_new() to set if configuration shall be saved in the
stig [Thu, 6 Mar 2008 22:13:24 +0000 (22:13 +0000)]
Added an option to uat_new() to set if configuration shall be saved in the
selected profile.

Don't save SMI Paths and SMI Modules in the profiles because reloading
currently doesn't work (bug 2309).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24580 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Florian Lohoff via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2320 ...
morriss [Thu, 6 Mar 2008 20:09:34 +0000 (20:09 +0000)]
From Florian Lohoff via bugs.wireshark.org/bugzilla/show_bug.cgi?id=2320 : A new (heuristic) dissector for the RedBack Lawful Intercept Packet header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24579 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake this dissector (which runs on a non-IANA-assigned port) a new-style dissector...
morriss [Thu, 6 Mar 2008 19:39:26 +0000 (19:39 +0000)]
Make this dissector (which runs on a non-IANA-assigned port) a new-style dissector.  Change some fprintf's to expert infos.  Also reindent.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24578 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFree another allocated string.
stig [Thu, 6 Mar 2008 18:26:09 +0000 (18:26 +0000)]
Free another allocated string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24577 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded yet another free().
stig [Thu, 6 Mar 2008 17:54:53 +0000 (17:54 +0000)]
Added yet another free().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24576 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix some typos; Fix some indenting to be at least locally consistent
wmeier [Thu, 6 Mar 2008 15:51:44 +0000 (15:51 +0000)]
Fix some typos; Fix some indenting to be at least locally consistent

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24575 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSmall fix for heuristic: it missed a tapa packet
jmayer [Thu, 6 Mar 2008 14:05:22 +0000 (14:05 +0000)]
Small fix for heuristic: it missed a tapa packet

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24574 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSet default port of Unistim from 5000 to 0: It grabs the TAPA
jmayer [Thu, 6 Mar 2008 12:54:08 +0000 (12:54 +0000)]
Set default port of Unistim from 5000 to 0: It grabs the TAPA
packets that I need.
The Unistim dissector should be made a heuristic dissector that
is willing to coexist with other dissectors. Until such a time
the port should remain 0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24573 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix the declaration of a true_false_string
sfisher [Wed, 5 Mar 2008 22:28:51 +0000 (22:28 +0000)]
Fix the declaration of a true_false_string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24572 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMark a couple of variables volatile
sfisher [Wed, 5 Mar 2008 22:28:29 +0000 (22:28 +0000)]
Mark a couple of variables volatile
Remove two unused dissector handles
Comment out a function declaration labeled as "TODO"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24571 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix typos.
etxrab [Wed, 5 Mar 2008 21:04:42 +0000 (21:04 +0000)]
Fix typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24570 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFree return value from smiRenderType, smiRenderOID, smiGetPath,
stig [Wed, 5 Mar 2008 20:55:56 +0000 (20:55 +0000)]
Free return value from smiRenderType, smiRenderOID, smiGetPath,
get_datafile_path and get_persconffile_path.

This was reported by Valgrind.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24569 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agofrom Andrew Feren :
etxrab [Wed, 5 Mar 2008 20:47:36 +0000 (20:47 +0000)]
from   Andrew Feren  :
Trivial agreement problem in documentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24568 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Peter Johansson :
etxrab [Wed, 5 Mar 2008 20:44:02 +0000 (20:44 +0000)]
From   Peter Johansson  :
Support for EtherCAT subdissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24567 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Peter Johansson :
etxrab [Wed, 5 Mar 2008 20:42:58 +0000 (20:42 +0000)]
From   Peter Johansson  :
Support for EtherCAT subdissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24566 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Andrew Feren :
etxrab [Wed, 5 Mar 2008 20:33:19 +0000 (20:33 +0000)]
From Andrew Feren :
Decoding extended gateway information not implemented for sFlow

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24565 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Owen Kirby :
etxrab [Wed, 5 Mar 2008 20:30:03 +0000 (20:30 +0000)]
From   Owen Kirby  :
IEEE 802.15.4 dissector and DLT_ type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24564 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDon't add newline before LIBCAP, as this is done correct in end_string().
stig [Wed, 5 Mar 2008 09:59:15 +0000 (09:59 +0000)]
Don't add newline before LIBCAP, as this is done correct in end_string().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24563 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMove the contents of AirPDcapCleanKeys() into AirPDcapInitContext()
gerald [Wed, 5 Mar 2008 00:57:30 +0000 (00:57 +0000)]
Move the contents of AirPDcapCleanKeys() into AirPDcapInitContext()
and call AirPDcapInitContext() where we were previously calling
AirPDcapCleanKeys(). If we're resetting our keys, we should reset our
SA list and other associated data as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24562 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd a POSIX capabilities blurb to get_compiled_version_info().
gerald [Tue, 4 Mar 2008 23:57:55 +0000 (23:57 +0000)]
Add a POSIX capabilities blurb to get_compiled_version_info().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24561 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFree the allocated range if not using it.
stig [Tue, 4 Mar 2008 23:15:11 +0000 (23:15 +0000)]
Free the allocated range if not using it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24560 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd a inflateEnd() call to free up the stream in the re-init block.
stig [Tue, 4 Mar 2008 22:56:26 +0000 (22:56 +0000)]
Add a inflateEnd() call to free up the stream in the re-init block.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24559 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoget_persconffile_path() return malloc'd memory,
stig [Tue, 4 Mar 2008 22:02:24 +0000 (22:02 +0000)]
get_persconffile_path() return malloc'd memory,
free it when we're done with the file name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24558 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agomatch_strval() may return NULL so don't blindly pass its return value into col_add_...
morriss [Tue, 4 Mar 2008 21:05:21 +0000 (21:05 +0000)]
match_strval() may return NULL so don't blindly pass its return value into col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24557 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd an item for Roofnet.
gerald [Tue, 4 Mar 2008 21:03:43 +0000 (21:03 +0000)]
Add an item for Roofnet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24556 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2331 : Replace match_strval...
morriss [Tue, 4 Mar 2008 20:11:50 +0000 (20:11 +0000)]
Fix bugs.wireshark.org/bugzilla/show_bug.cgi?id=2331 : Replace match_strval() with val_to_str() returning "Unknown" if no match was found.  This prevents us from passing a NULL pointer (which should replace a %s in the format string) which was causing g_vsnprintf() to core (at least on Solaris and, apparently, Windows).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24555 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Sven Meier: update the PRP dissector to the newest version of the standard....
morriss [Tue, 4 Mar 2008 19:13:06 +0000 (19:13 +0000)]
From Sven Meier: update the PRP dissector to the newest version of the standard.  There is also now a Wiki page for this protocol: wiki.wireshark.org/PRP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24554 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInitialize ipv6_addr before we use it.
stig [Tue, 4 Mar 2008 18:55:36 +0000 (18:55 +0000)]
Initialize ipv6_addr before we use it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24553 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUps, this free was not so smart...
stig [Tue, 4 Mar 2008 12:47:36 +0000 (12:47 +0000)]
Ups, this free was not so smart...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24552 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded default svn:ignore targets.
stig [Tue, 4 Mar 2008 12:15:53 +0000 (12:15 +0000)]
Added default svn:ignore targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24551 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFree allocated data.
stig [Tue, 4 Mar 2008 12:13:25 +0000 (12:13 +0000)]
Free allocated data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24550 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFree compiled dfilter after usage.
stig [Tue, 4 Mar 2008 12:12:41 +0000 (12:12 +0000)]
Free compiled dfilter after usage.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24549 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix fields that are passed to proto_tree_add_uint64_format_value() to be
guy [Tue, 4 Mar 2008 09:27:14 +0000 (09:27 +0000)]
Fix fields that are passed to proto_tree_add_uint64_format_value() to be
FT_UINT64 fields.

Partially clean up indentation (it is *NOT* guaranteed that tabs will be
set every 4 spaces!).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24548 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFor the "cigi.3_2_los_ext_response" field, use the variable that was
guy [Tue, 4 Mar 2008 08:58:08 +0000 (08:58 +0000)]
For the "cigi.3_2_los_ext_response" field, use the variable that was
intended for it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24547 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSpoted by ChrisMaynard:
etxrab [Tue, 4 Mar 2008 05:55:11 +0000 (05:55 +0000)]
Spoted by ChrisMaynard:
Duplicated names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24546 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom ChrisMaynard:
etxrab [Tue, 4 Mar 2008 05:39:21 +0000 (05:39 +0000)]
From ChrisMaynard:
packet-ptp.c(2183) : error C2220: warning treated as error - no object file generated
packet-ptp.c(2183) : warning C4244: 'function' : conversion from
'__int64 ' to 'double ', possible loss of data

patch to correct the problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24545 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake sure we initialize a TVB. Fixes bug 2329.
gerald [Mon, 3 Mar 2008 22:28:35 +0000 (22:28 +0000)]
Make sure we initialize a TVB. Fixes bug 2329.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24543 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd section IDs.
gerald [Mon, 3 Mar 2008 22:05:25 +0000 (22:05 +0000)]
Add section IDs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24542 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd missing parts of the PCAP dissector.
gerald [Mon, 3 Mar 2008 22:03:05 +0000 (22:03 +0000)]
Add missing parts of the PCAP dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24541 f5534014-38df-0310-8fa8-9805f1628bb7