krj [Fri, 9 Oct 2009 16:39:34 +0000 (16:39 +0000)]
Use register_dissector_files in the plugins dissectors
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30435
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 16:33:16 +0000 (16:33 +0000)]
Use register_dissector_files in asn1 plugin
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30434
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 16:24:22 +0000 (16:24 +0000)]
Add register_dissector_files macro
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30433
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 9 Oct 2009 15:46:39 +0000 (15:46 +0000)]
hf[]: Use NULL for "blurb" instead of dup or empty test string;
hf[]: Add note about dup filter names;
#include <stdio.h>, <stdlib.h> & <string.h> not needed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30432
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 9 Oct 2009 15:36:20 +0000 (15:36 +0000)]
hf[]: Use NUL for "blurb" instead of empty text string;
#include <stdio.h> & <stdlib.h> not needed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30431
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 9 Oct 2009 15:30:32 +0000 (15:30 +0000)]
hf[]: Use NULL for "blurb" instead of dup or empty text string;
#include <stdio.h> & <stdlib.h> not needed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30430
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 9 Oct 2009 15:22:38 +0000 (15:22 +0000)]
hf[]: Use NULL for "blurb" instead of dup or empty text string;
#include <stdio.h>, <stdlib.h> not needed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30429
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 11:21:22 +0000 (11:21 +0000)]
Also capitalize wireshark_BINARY_DIR since this variable is automatically defined by cmake according to the project name
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30428
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 10:47:02 +0000 (10:47 +0000)]
Capitalize project name
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30427
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 9 Oct 2009 10:14:00 +0000 (10:14 +0000)]
From Gerasimos Dimitriadis:
DTAP: Wrong decoding of ITC in Bearer Capability IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4108
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30426
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 9 Oct 2009 09:56:16 +0000 (09:56 +0000)]
Remove code guarded by #ifdef USE_CONVERSATION_GRAPH
as this eems to newer have been fully implemented and the old clist is replaced now.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30425
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 09:34:07 +0000 (09:34 +0000)]
Add common include file (boiler plate)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30424
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 09:16:58 +0000 (09:16 +0000)]
Update makefiles to use new template names
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30423
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 09:12:59 +0000 (09:12 +0000)]
Give the template filenames more uniqueness
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30422
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 9 Oct 2009 09:06:22 +0000 (09:06 +0000)]
From Didier Gautheron:
- memory leak, free the list after walking it, ie free a NULL list, ie free nothing. I've only fixed bugs introduced by me with GTKCList to TreeView modifs, it seems there's the same bug in gtk/dlg_utils.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30421
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 9 Oct 2009 09:01:04 +0000 (09:01 +0000)]
From Didier Gautheron:
Treeview for hostlist.
Notes:
- tested without and with geoip lib but only with the free DB (no lat/long data) thus 'open_as_map_cb' is not really tested.
- It changes the sorting of addresses if 'resolve names' is set and uses the same sorting than conversations. The old way may make more sense for ethernet though.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30420
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 08:57:52 +0000 (08:57 +0000)]
Introduce intermediate variables: PROTOCOL_NAME and IDL2WRS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30419
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 08:57:10 +0000 (08:57 +0000)]
Introduce intermediate variables: PROTOCOL_NAME and IDL2WRS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30418
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Fri, 9 Oct 2009 08:55:59 +0000 (08:55 +0000)]
Introduce intermediate variables: PROTOCOL_NAME and IDL2WRS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30417
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 9 Oct 2009 08:52:36 +0000 (08:52 +0000)]
From Didier Gautheron:
- Display number with a space as thousand separator.
- Move functions use both by conversations and hostlist in gui_utils.c, they may be useful for other taps too.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30416
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 9 Oct 2009 07:24:33 +0000 (07:24 +0000)]
From Didier Gautheron:
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30415
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 9 Oct 2009 06:37:48 +0000 (06:37 +0000)]
From Tobias Witek:
New protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321).
This does not currently compile cleanly but checking it in to be worked on.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30414
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 9 Oct 2009 04:31:21 +0000 (04:31 +0000)]
update pidl to the current samba version so we can generate ndr64
compatible dissectors
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30413
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 9 Oct 2009 04:19:45 +0000 (04:19 +0000)]
explicitely cast a guin64 to int to avoid compile warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30412
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 9 Oct 2009 04:11:36 +0000 (04:11 +0000)]
mark the dcerpc 1632 and 3264 type dissectors exportable for windows
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30411
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 8 Oct 2009 21:26:26 +0000 (21:26 +0000)]
Tighten header field checks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30410
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Thu, 8 Oct 2009 17:26:57 +0000 (17:26 +0000)]
Remove unused NEED_PACKET_PROTO_H variable
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30409
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Thu, 8 Oct 2009 16:54:20 +0000 (16:54 +0000)]
Remove FindWSWIN32.cmake. It was only a temporary hack I introduced. We should add Windows support in a more clean fashion.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30408
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Thu, 8 Oct 2009 16:35:58 +0000 (16:35 +0000)]
Don't attempt to fill custom columns if we don't have a valid column expression.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30407
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 8 Oct 2009 16:13:53 +0000 (16:13 +0000)]
Fix code so it actually pads a length to an 8 byte boundary.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30406
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Thu, 8 Oct 2009 15:10:43 +0000 (15:10 +0000)]
calculate_crc32c -> crc32c_calculate for proper 'namespacing'
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30405
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Thu, 8 Oct 2009 15:01:25 +0000 (15:01 +0000)]
Add DISSECTOR_ASSERT() before dereferencing a possible NULL pointer
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30404
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Thu, 8 Oct 2009 14:48:43 +0000 (14:48 +0000)]
Call emem_canary() immediately
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30403
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Thu, 8 Oct 2009 14:40:23 +0000 (14:40 +0000)]
From Harald Welte via bug 4106:
Fix 'cast from pointer to integer of different size'
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30402
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 8 Oct 2009 14:28:23 +0000 (14:28 +0000)]
As requested by Gregory Seidman on -dev: add CRC32 functions to libwireshark.def. Use consistent indentation in crc32.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30401
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 8 Oct 2009 13:57:19 +0000 (13:57 +0000)]
Use a "String pool" in the new packet list to reduce memory usage.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30400
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Thu, 8 Oct 2009 13:24:03 +0000 (13:24 +0000)]
Remove debug g_warning()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30399
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Thu, 8 Oct 2009 13:17:51 +0000 (13:17 +0000)]
From Gerasimos Dimitriadis via. bug 4104:
When dissecting a h248 message, col_set_str is called with a string from the ephemeral pool and an assertion fails.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30398
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 8 Oct 2009 11:46:15 +0000 (11:46 +0000)]
Dont use canaries for SE allocated memory as a default the owerhead
is to big when allocating lot's of memory. EP memory does not suffer as much as we seems to only allocate one chunk for EP memory.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30397
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 8 Oct 2009 07:56:48 +0000 (07:56 +0000)]
From Didier Gautheron:
conversations table leaks hash keys memory on close.
Modified by me to use g_hash_table_new_full().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30396
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 8 Oct 2009 05:43:19 +0000 (05:43 +0000)]
Clean up header fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30395
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 7 Oct 2009 23:08:22 +0000 (23:08 +0000)]
Cleanup header fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30394
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 7 Oct 2009 22:36:33 +0000 (22:36 +0000)]
Fix some LLP64 issues.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30393
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 7 Oct 2009 21:00:14 +0000 (21:00 +0000)]
Get it compiling when we don't have kerberos libraries.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30392
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 7 Oct 2009 19:46:28 +0000 (19:46 +0000)]
From Gregor Jasny via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4073 :
This patch adds the functionality to decode short capabilies.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30391
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 7 Oct 2009 15:41:13 +0000 (15:41 +0000)]
Reverting previous patch as requested by Ronnie.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30390
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 7 Oct 2009 10:00:26 +0000 (10:00 +0000)]
From : Didier Gautheron
gtktreeview patch for stat(not well tested, no traces).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30389
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 7 Oct 2009 09:47:45 +0000 (09:47 +0000)]
Make the windows build compile again.
(Probably not the right fix).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30388
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 7 Oct 2009 08:37:18 +0000 (08:37 +0000)]
Removed a redundant prototype.
Made wrs_count_bitshift static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30387
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 7 Oct 2009 07:59:11 +0000 (07:59 +0000)]
Switch to using tvb_new_subset_remaining() in .cnf files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30386
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 7 Oct 2009 07:47:41 +0000 (07:47 +0000)]
Made dissect_pres() static.
Added changes from r29446 to .cnf file:
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30385
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 7 Oct 2009 07:03:33 +0000 (07:03 +0000)]
add a new function read_keytab_file_from_preferences(void)
that can be called by dissectoirs using kerberos keytab files.
This function will load a new keytab file on demand, if it is changed in
the preferences.
The previous code had you save the preferences and then restart
wireshark which is suboptimal from a user friendly perspective
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30384
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 7 Oct 2009 07:01:55 +0000 (07:01 +0000)]
new samr compiled as a test by the samba4 pidl compiler from mainline
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30383
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 7 Oct 2009 06:28:36 +0000 (06:28 +0000)]
Don't include config.h in header files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30382
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 7 Oct 2009 05:03:16 +0000 (05:03 +0000)]
From Jim Young:
Add "Drag and Drop entries..." message on Columns preferences page.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4099
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30381
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 7 Oct 2009 01:08:13 +0000 (01:08 +0000)]
Fix indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30380
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 7 Oct 2009 00:45:39 +0000 (00:45 +0000)]
malloc() and free() are prohibited APIs, use the glib equivalents instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30379
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Tue, 6 Oct 2009 22:59:33 +0000 (22:59 +0000)]
From Andreas Becker:
Add a subdissector Table for BACnet MSTP Frames.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30378
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 6 Oct 2009 19:21:29 +0000 (19:21 +0000)]
Avoid dereference of null pointer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30377
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 6 Oct 2009 19:15:58 +0000 (19:15 +0000)]
From Didier Gautheron:
ep memory can't be used for tvbs defined as data_source.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4054
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30376
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 6 Oct 2009 19:04:29 +0000 (19:04 +0000)]
From Gerasimos Dimitriadis:
GSM MAP: an-APDU not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4095
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30375
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 6 Oct 2009 19:03:32 +0000 (19:03 +0000)]
Bump Kovarththanan Rajaratnam up a notch :-)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30374
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 6 Oct 2009 18:58:09 +0000 (18:58 +0000)]
Build plugins with cmake on OSX.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30373
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 6 Oct 2009 18:51:11 +0000 (18:51 +0000)]
From Gerasimos Dimitriadis:
Mobile Classmark3 wrong dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4082
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30372
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 6 Oct 2009 16:20:26 +0000 (16:20 +0000)]
Add some SE allocation statistics (if SHOW_MEM_STATS is defined).
Add print_alloc_stats() will show some (hopefully useful) statistics about the
memory we have allocated, the average allocation size, the amount of
overhead/waste, etc.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30371
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 6 Oct 2009 16:01:18 +0000 (16:01 +0000)]
Invert check for getopt: NEED_GETOPT_H -> HAVE_GETOPT_H
Rename getopt.[ch] -> wsgetopt.[ch] to avoid name collision.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30370
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Tue, 6 Oct 2009 15:07:52 +0000 (15:07 +0000)]
Cleanup rcsids
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30369
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Tue, 6 Oct 2009 14:56:43 +0000 (14:56 +0000)]
Remove $Id$
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30368
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Tue, 6 Oct 2009 14:20:59 +0000 (14:20 +0000)]
Use ep_alloc()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30367
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Tue, 6 Oct 2009 14:02:01 +0000 (14:02 +0000)]
Remove superfluous cast
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30366
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Tue, 6 Oct 2009 13:58:17 +0000 (13:58 +0000)]
Use G_SEARCHPATH_SEPARATOR_S
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30365
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Tue, 6 Oct 2009 13:54:32 +0000 (13:54 +0000)]
Make splash_destroy() return a gboolean
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30364
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Tue, 6 Oct 2009 13:51:56 +0000 (13:51 +0000)]
Guard icon_list_create()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30363
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 6 Oct 2009 13:26:00 +0000 (13:26 +0000)]
Mark some functions static.
Removed an unused tooltips.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30362
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 6 Oct 2009 13:23:07 +0000 (13:23 +0000)]
Removed unnecessary assignment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30361
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Tue, 6 Oct 2009 13:21:44 +0000 (13:21 +0000)]
Don't include unistd.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30360
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 6 Oct 2009 13:21:15 +0000 (13:21 +0000)]
Removed unused variable thdr.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30359
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 6 Oct 2009 13:20:40 +0000 (13:20 +0000)]
Removed unused sortable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30358
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 6 Oct 2009 11:54:08 +0000 (11:54 +0000)]
Make it compile on windows.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30357
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 6 Oct 2009 10:10:33 +0000 (10:10 +0000)]
Increase EMEM_ALLOCS_PER_CHUNK to avoid memory waist.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30356
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 6 Oct 2009 09:13:57 +0000 (09:13 +0000)]
From Matthieu Patou,
add code to decrypt ntlmv1 and v2 traffic
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30355
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 6 Oct 2009 08:07:17 +0000 (08:07 +0000)]
more updates to samr to harmonize it with samba
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30354
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 6 Oct 2009 07:44:48 +0000 (07:44 +0000)]
From : Didier Gautheron
gtktreeview for conversations:
- use a garray rather than g_realloc memory for conversations list.
- use a hashtable for finding conversation rather than a linear search.
Notes:
- sorting is too slow, I disabled it.
- the dialog box is really a big problem because it's also empty the idle event queue, slow down a lot.
- Test on a 1.5M packets with hundred thousands conversations capture, slow but bearable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30353
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 6 Oct 2009 06:54:18 +0000 (06:54 +0000)]
Use IANA assigned port number as default UDP port.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30352
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 6 Oct 2009 06:50:39 +0000 (06:50 +0000)]
Update the services file from IANA's port-numbers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30351
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 5 Oct 2009 21:41:35 +0000 (21:41 +0000)]
Regenerated to match spec files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30350
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 5 Oct 2009 21:39:47 +0000 (21:39 +0000)]
Fixed offset_from_real_beginning() -> tvb_offset_from_real_beginning()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30349
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 5 Oct 2009 21:39:07 +0000 (21:39 +0000)]
Return from dissect_snmp_VarBind() when detecting invalid oid.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30348
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 5 Oct 2009 19:18:09 +0000 (19:18 +0000)]
Use g_free() (should have been part of r30342)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30347
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 5 Oct 2009 18:52:46 +0000 (18:52 +0000)]
Move dissector add sanity check to separate function
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30346
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 5 Oct 2009 18:45:03 +0000 (18:45 +0000)]
Add DISSECTOR_ASSERT before dereferencing pointer
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30345
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 5 Oct 2009 18:38:50 +0000 (18:38 +0000)]
GetModuleFileName expects the size of the passed buffer to be expressed in TCHAR. We currently pass the size expressed in bytes. In other words, we incorrectly state that the buffer is twice as big as it really is.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30344
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 5 Oct 2009 18:24:59 +0000 (18:24 +0000)]
se_alloc returns a non NULL pointer so we don't have to check for NULL
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30343
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 5 Oct 2009 18:20:38 +0000 (18:20 +0000)]
Use g_malloc()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30342
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 5 Oct 2009 18:13:23 +0000 (18:13 +0000)]
Return from dissect_snmp_VarBind() when detecting invalid oid.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30341
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 5 Oct 2009 18:12:16 +0000 (18:12 +0000)]
Add null pointer guard
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30340
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 5 Oct 2009 18:07:59 +0000 (18:07 +0000)]
Allocate 64K buffer from heap
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30339
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 5 Oct 2009 17:52:23 +0000 (17:52 +0000)]
Return from sctp_stat_on_select_row() if nothing selected.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30338
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 5 Oct 2009 17:43:27 +0000 (17:43 +0000)]
Cleanup comments wrt. /MP
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30337
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 5 Oct 2009 17:19:39 +0000 (17:19 +0000)]
From Didier Gautheron:
Sorting wasn't working right for time columns.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30336
f5534014-38df-0310-8fa8-
9805f1628bb7