cmaynard [Tue, 5 Apr 2011 17:27:30 +0000 (17:27 +0000)]
Fix a few more typos and reformat some of the comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36477
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 5 Apr 2011 16:14:19 +0000 (16:14 +0000)]
Remove the manifest as a prerequisite for packaging.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36476
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 5 Apr 2011 15:49:56 +0000 (15:49 +0000)]
Compile fix: camel_obj_id -> obj_id.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36475
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 5 Apr 2011 15:43:15 +0000 (15:43 +0000)]
Actually get the oid string ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36474
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 5 Apr 2011 15:33:56 +0000 (15:33 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 858;
Fix two cases where items appear to be added to the wrong tree: Coverioty 856 & 857.
Also: remove some unneeded #includes& do some whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36473
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 5 Apr 2011 15:09:32 +0000 (15:09 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 882;
Also: #include <string.h> not req'd
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36472
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Tue, 5 Apr 2011 14:28:33 +0000 (14:28 +0000)]
Fix a typo in the help message.
Reported by Matthias Wellmeyer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36471
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 5 Apr 2011 05:50:45 +0000 (05:50 +0000)]
From Jose Pedro Oliveira:
#ifdef HAVE_LIBGCRYPT block includes a line too many.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5803
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36470
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 5 Apr 2011 02:35:32 +0000 (02:35 +0000)]
Remove some unused hf_ variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36469
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 5 Apr 2011 02:18:28 +0000 (02:18 +0000)]
From Felix Kraemer: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5694 :
This patch adds the capability to create BACnet statistics trees.
Find the respective menu items under 'Statistics->BACnet'.
Packets can be sorted by different criteria:
- Src/Dst IP adresses
- Instance ID
- Object Type
- Service
From me:
- Don't use C++/C99-style comments.
- Name variables for tick_stat_node() don't need to be static.
- Change updateBacnetInfoValue() to require 'data' to be ep_ allocated. Change
the couple of calls that did not send in ep_ allocated data to do so.
- Change one or two functions to be static.
- Do not use (memory-unsafe) g_sprintf().
- Use ep_strconcat() instead of leaking memory with g_strconcat().
- Put back one if(tree) that doesn't appear to do any harm.
- Remove variable declarations and #includes from the header file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36468
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 5 Apr 2011 01:21:19 +0000 (01:21 +0000)]
Set BIN_DIR to . by default. Use tr to replace colons with newlines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36467
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 20:03:27 +0000 (20:03 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 850;
Also: remove some unneeded #includes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36466
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 19:41:51 +0000 (19:41 +0000)]
Fix "MISSING_BREAK"; Coverity 436.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36465
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 19:23:39 +0000 (19:23 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 846 & 848;
Also: remove some unneeded #includes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36464
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 4 Apr 2011 19:15:31 +0000 (19:15 +0000)]
More console tweaks. But how to prevent prompt from being displayed before
command finishes without requiring, "start /wait <command>"?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36463
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 4 Apr 2011 19:10:30 +0000 (19:10 +0000)]
Based on idea from Bill Meier:
A little script to extract the protocols used in given capture files.
(Just so I don't have to remember how to do it again.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36462
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 4 Apr 2011 18:43:59 +0000 (18:43 +0000)]
Fix up indentation
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36461
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 18:41:49 +0000 (18:41 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 836;
Also: remove some unneeded #includes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36460
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 18:13:22 +0000 (18:13 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 832-834.
Also: white space cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36459
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 4 Apr 2011 18:03:24 +0000 (18:03 +0000)]
More console tweaks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36458
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 4 Apr 2011 17:56:16 +0000 (17:56 +0000)]
Fix Coverity 1137, 1138, 1139: UNUSED_VALUE
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36457
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 17:49:32 +0000 (17:49 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 829 & 830;
Fix a minor bug wherein a number of proto_tree_add_...() used the wrong tree: Coverity 831;
Remove some unneeded #includes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36456
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 4 Apr 2011 17:48:07 +0000 (17:48 +0000)]
Only call destroy_console() when we create a console (pointed out by
Chris Maynard).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36455
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 4 Apr 2011 17:42:37 +0000 (17:42 +0000)]
Fix compilation error:
packet-amqp.c:5617:5: error: "/*" within comment
Cause:
Previous comment wasn't terminated right
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36454
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 17:24:17 +0000 (17:24 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 827;
Comment out some currently unused code: Coverity 828.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36453
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 4 Apr 2011 17:11:56 +0000 (17:11 +0000)]
On Windows, try to use an existing console for our messages. Create one if
it doesn't exist.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36452
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 16:54:02 +0000 (16:54 +0000)]
Don't assign to a variable if the value won't be used: Coverity 826;
Also: Remove some uneeded #includes & use consistent indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36451
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 4 Apr 2011 16:15:27 +0000 (16:15 +0000)]
Fix some typos.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36450
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 16:13:42 +0000 (16:13 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 823 & 824;
Fix a minor bug wherein a proto_tree_add_text used the wrong tree: Coverity 825;
Remove some unneeded #includes;
Use consistent indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36449
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 4 Apr 2011 15:41:07 +0000 (15:41 +0000)]
Don't build a manifest if we don't need one.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36448
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 15:38:19 +0000 (15:38 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 820/821;
Also: #include <stdio.h> & <string.h> not required;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36447
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 4 Apr 2011 15:31:33 +0000 (15:31 +0000)]
Don't assign to a variable if the value won't be used: Coverity 817-821.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36446
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 4 Apr 2011 15:09:22 +0000 (15:09 +0000)]
Mark pinfo as unused.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36445
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 4 Apr 2011 14:49:14 +0000 (14:49 +0000)]
Get rid of gsm_a_dtap_pinfo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36444
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 4 Apr 2011 14:37:25 +0000 (14:37 +0000)]
Change the signature of elem_fcn():ns to include pinfo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36443
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 4 Apr 2011 14:35:21 +0000 (14:35 +0000)]
From Vincent Helfre:
updated the script that extracts the asn1 from the specification (we modified it after noticing that it currently fails to take the IMPORT section). It should also work now to extract the WCDMA RRC (TS 25.331).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36442
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 4 Apr 2011 07:45:34 +0000 (07:45 +0000)]
Change the msg_fcn() signature to include pinfo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36441
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 4 Apr 2011 05:48:06 +0000 (05:48 +0000)]
From jakub Zawadzki:
I've fixed composite tests #0 and #2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36440
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 3 Apr 2011 15:39:01 +0000 (15:39 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 885-889
Also: Significant code rework including:
- Fix bug wherein a timestamp was incorrectly reported as being an Error;
- Replace many proto_tree_add_text()/proto_item_set_text() sequences each by a
single proto_tree_add_text().
- remove unneeded #include <string.h>
- Whitespace clanup including replacing mixed space/tab indentation by spaces.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36437
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 3 Apr 2011 15:03:50 +0000 (15:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-04-03]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36436
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 2 Apr 2011 09:18:18 +0000 (09:18 +0000)]
-Whitespace fix in gsm_map-template(no need to regenerate).
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36435
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 1 Apr 2011 20:48:56 +0000 (20:48 +0000)]
Add some info as to the determination of the length of a FT_STRINGZ item.
Add a note not leaving trailing whitespace on a line.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36434
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 1 Apr 2011 19:50:50 +0000 (19:50 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
Patch 6 :
Enhance the MySQL collation
Patch 7 :
Enhance MySQL : add dissection of command Binlog Dump (replicate command).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36433
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 1 Apr 2011 18:16:47 +0000 (18:16 +0000)]
Avoid potential buffer overruns when sscanf'ing strings.
Should resolve CID's 656 and 657.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36432
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 1 Apr 2011 16:55:59 +0000 (16:55 +0000)]
Don't use pParser->yyidx as an index into pParser->yystack[] until after it is
verified that it is non-negative. Should resolve CID 619.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36431
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 1 Apr 2011 16:30:59 +0000 (16:30 +0000)]
Remove const type qualifier from cast. Resolves CID's 582-585.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36430
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Fri, 1 Apr 2011 13:41:08 +0000 (13:41 +0000)]
Take care not to append RLC mode to proto_item twice.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36429
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 31 Mar 2011 20:57:40 +0000 (20:57 +0000)]
Rename local 'pipe_input' so it doesn't shadow global 'pipe_input';
Use consistent indentation and remove trailing whitespace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36428
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 31 Mar 2011 20:50:13 +0000 (20:50 +0000)]
Memory leak in lemon.c
coverity 1177
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36427
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 19:17:06 +0000 (19:17 +0000)]
Fix 11 occurrences of returned pointer never used. Fixes CID's 1064-1067.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36426
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 18:28:52 +0000 (18:28 +0000)]
Check return value of file_seek(). Fixes CID 338.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36425
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 18:00:26 +0000 (18:00 +0000)]
Don't dereference a NULL pointer. Fixes CID 426.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36424
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 17:27:48 +0000 (17:27 +0000)]
separator will never be NULL, but sep_len could be 0, so test for that instead.
Fixes CID 620.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36423
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 16:46:16 +0000 (16:46 +0000)]
Use BSWAP16 instead of BSWAP32 for 16-bit values. Fixes CID's 1179 and 1180.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36422
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 16:23:07 +0000 (16:23 +0000)]
Use a common function, higher_priority_status_level() to determine whether or
not messages should be pushed onto the statusbar. Should fix CID 270.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36421
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 15:41:23 +0000 (15:41 +0000)]
Clear the entire contents of ctx at the end of md5_finish(). Fixes CID 712.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36420
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 15:17:49 +0000 (15:17 +0000)]
From Alexis La Goutte via bug 5790: Fix 8 clang warnings, all of which were:
"warning: Value stored to 'offset' is never read". The 'offset' is now used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36419
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 14:35:40 +0000 (14:35 +0000)]
Delete unused header fields found by running tools/checkhf.pl.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36418
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 31 Mar 2011 14:30:38 +0000 (14:30 +0000)]
(Trivial) Fix some typos; do some whitespace cleanup & rewording of comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36417
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 14:23:07 +0000 (14:23 +0000)]
From Yair via bug 5779: Add option to leave AAL5 in unspecified format.
(... with whitepsace changes by me.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36416
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 31 Mar 2011 14:03:23 +0000 (14:03 +0000)]
From Andrew Feren via bug 5775: Correct types on several info elements.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36415
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 31 Mar 2011 12:18:14 +0000 (12:18 +0000)]
Register tcp by name.
To be used in User DLT's and Lua scripts.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36414
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 31 Mar 2011 12:16:41 +0000 (12:16 +0000)]
Use correct functions to fetch protocol name for a dissector registered
by register_dissector().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36413
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 31 Mar 2011 12:14:59 +0000 (12:14 +0000)]
Added dissector_handle_get_long_name().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36412
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 31 Mar 2011 11:01:06 +0000 (11:01 +0000)]
Use correct length for clientaddr4 callback address entry.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36411
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 30 Mar 2011 15:54:28 +0000 (15:54 +0000)]
Fix a couple of typos.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36410
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 30 Mar 2011 14:53:09 +0000 (14:53 +0000)]
From: wireshark.org/lists/wireshark-dev/201103/msg00157.html
Change RTT references to SRT. (This should have been checked in with r36297.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36409
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 30 Mar 2011 14:44:18 +0000 (14:44 +0000)]
Wrap all text lines of help at column 80.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36408
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 30 Mar 2011 04:36:09 +0000 (04:36 +0000)]
remove two pointless const in casts
coverity 580 and 581
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36407
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 30 Mar 2011 03:39:58 +0000 (03:39 +0000)]
remove some assignments we dont use
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36406
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 29 Mar 2011 21:40:54 +0000 (21:40 +0000)]
Change TCP_PORT_MANGO to TCP_PORT_MONGO.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36405
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 29 Mar 2011 21:39:15 +0000 (21:39 +0000)]
Don't put a 65536 byte variable on the stack: instead, malloc/free it.
Coverity 760-761.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36404
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 21:20:36 +0000 (21:20 +0000)]
Add a missing break.
CID 487
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36403
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 21:11:26 +0000 (21:11 +0000)]
Add a missing break.
CID 488
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36402
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 21:08:34 +0000 (21:08 +0000)]
Add a missing break.
CID 490
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36401
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 21:05:29 +0000 (21:05 +0000)]
Added FALLTHRU comment to avoid a "missing break" warning.
CID 489
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36400
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 29 Mar 2011 20:58:57 +0000 (20:58 +0000)]
From Alexis La Goutte via bug 5790: Add partial bit flag in query.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36399
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 29 Mar 2011 20:05:33 +0000 (20:05 +0000)]
Grab URL from frame info value instead of from tvb. Fixes bug 5780.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36398
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 29 Mar 2011 14:29:45 +0000 (14:29 +0000)]
Don't put a 196808 byte variable on the stack: instead, malloc/free it.
Coverity 789-790.
Since we've been keeping track of how many bytes we put in the buffer,
use that value instead of calling strlen() find it again.
Also, some white space/indentation cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36397
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 14:23:21 +0000 (14:23 +0000)]
Remove check_col().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36396
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 29 Mar 2011 14:23:13 +0000 (14:23 +0000)]
Don't assign proto_item pointers that are not used.
Coverity 1174
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36395
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 29 Mar 2011 14:05:28 +0000 (14:05 +0000)]
Don't put a 65536 byte variable on the stack: instead, malloc/free it.
Coverity 791-794.
Also, some white space/indentation cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36394
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 29 Mar 2011 11:09:59 +0000 (11:09 +0000)]
Guard against NULL return from find_protocol_by_id().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36393
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 29 Mar 2011 11:08:15 +0000 (11:08 +0000)]
From Pascal Quantin:
Added guard against proto_name's not resolved as protocols.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36392
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Tue, 29 Mar 2011 10:56:30 +0000 (10:56 +0000)]
RTP: display payload type name from dynamic payload type table
H.223: use just one protocol for bot dissectors for more clear protocol disabling
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36391
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 29 Mar 2011 01:27:20 +0000 (01:27 +0000)]
Prohibit (memory-unsafe) g_sprintf() and g_vsprintf().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36390
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 22:22:05 +0000 (22:22 +0000)]
Cast to guint to avoid a Windows compiler warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36389
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 22:12:53 +0000 (22:12 +0000)]
Move -D option into "pre-scan" group as there's no need to start gtk+ for it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36388
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 22:10:41 +0000 (22:10 +0000)]
Use fprintf_stderr() instead of printf() so "wireshark -D" works (on Windows).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36387
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 28 Mar 2011 20:53:20 +0000 (20:53 +0000)]
Fix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36386
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 28 Mar 2011 19:44:41 +0000 (19:44 +0000)]
Use g_ascii_strdown instead of g_strdown
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36385
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 28 Mar 2011 17:23:06 +0000 (17:23 +0000)]
More updates to the wtap_open_offline() comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36384
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 17:04:58 +0000 (17:04 +0000)]
Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36383
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 16:42:25 +0000 (16:42 +0000)]
Don't use prohibited strncpy(). In this case, use g_strlcat() instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36382
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 28 Mar 2011 15:28:03 +0000 (15:28 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5522 :
Fix a Clang warning, add email address, and add some stuff to COL_INFO.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36381
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 28 Mar 2011 15:23:27 +0000 (15:23 +0000)]
From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 :
Register the reload-framing dissector by name. Needed when RELOAD is not used
over udp/tcp (but tls, for example)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36380
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 28 Mar 2011 15:20:16 +0000 (15:20 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
Patch 5
Enchance MySQL :
* Add expert info of when undecoded data
* Fix some white space
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36379
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 14:53:35 +0000 (14:53 +0000)]
Make ip.fragments an FT_BYTES field so a PDML Export will display the bytes in
the value="..." attribute. Fixes bug 1520.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36378
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 28 Mar 2011 14:18:29 +0000 (14:18 +0000)]
Added payload, header and trailer information to the DLT tree entry.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36377
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 28 Mar 2011 13:09:47 +0000 (13:09 +0000)]
Update a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36376
f5534014-38df-0310-8fa8-
9805f1628bb7