16 years agoFrom Chris Wilson:
obiot [Tue, 27 Jan 2004 00:20:37 +0000 (00:20 +0000)]
From Chris Wilson:

Separate the GSM SMS User Data dissector from the SMPP dissector.

Rename the protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9872 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd application/smil to the registered line-based text media dissector.
obiot [Mon, 26 Jan 2004 23:49:43 +0000 (23:49 +0000)]
Add application/smil to the registered line-based text media dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9871 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRename "dissect_t38_tcp()" to "dissect_t38_tcp_pdu()" to make it
guy [Mon, 26 Jan 2004 22:52:22 +0000 (22:52 +0000)]
Rename "dissect_t38_tcp()" to "dissect_t38_tcp_pdu()" to make it
clearer what it does (dissect a single T.38-over-TCP or T.38-over-TPKT

Have "dissect_t38_udp()" that does T.38-over-UDP dissection and
"dissect_t38_tcp()" that does T.38-over-TCP dissection; register handles
for them for the appropriate protocols, rather than having a single
dissector that checks the IP protocol type.

Use -1 rather than "tvb_length(tvb)" as the length for top-level
protocol tree items.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9870 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoNewlines in filter strings are a Bad Idea, as they don't display well in
guy [Mon, 26 Jan 2004 22:34:55 +0000 (22:34 +0000)]
Newlines in filter strings are a Bad Idea, as they don't display well in
the title or contents of the filtering progress bar window and don't
work very well in files such as "recent" or "dfilters".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9869 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Martin Regner:
obiot [Mon, 26 Jan 2004 22:16:43 +0000 (22:16 +0000)]
From Martin Regner:

- support both T.38IFP/TCP and T38IFP/TPKT/TCP

There is one new preference setting tpkt_usage where you can specify if TPKT
header is used. With the default setting (tpkt_usage=Maybe) the dissector
will look on the first four octets and try to determine if TPKT is used or
not. This setting seems to work well with the captures I have tried,
but there might be some scenarios where it will be better to set the value
to 'Always' or 'Never' dependant on if TPKT header is used or not.

There is also a new preference setting regarding TCP desegmentation. TCP
desegmentation is currently only supported when TPKT header
is used.
You will need to set the preference setting "Allow subdisectors to desegment
TCP streams" for TCP and also the "Desegment all TPKT
messages spanning multiple TCP segments" for TPKT if you want to use this
feature. I don't have any T.38 captures with segmented packets
so I have not been able to test this so much.

- Support for T.38 (2002) ASN.1 specification
 Note: This ASN.1 specification is incompatible with the Pre-Corigendum T.38
ASN.1 specification (1998) so you will need to set the preference setting

- When there are extra octets after the T.38 UDPTL packet you will now see
[Malformed?] in the Info-column. I thought that it
was quite irritating that non-T.38 packets could look like they were
correctly coded T.38 packets.

- There might be several T.38 IFP packets in a TCP packet for the T.38
directly over TCP scenario. There is now at least some support for this, but
TCP desegmentation is only supported for the TPKT scenario this will not
work if an IFP packet is splitted into several TCP packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9868 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a compiler warning.
guy [Mon, 26 Jan 2004 21:26:52 +0000 (21:26 +0000)]
Fix a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9867 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdated NSIS generation to build GTK version 1 or 2,
ulfl [Mon, 26 Jan 2004 21:12:41 +0000 (21:12 +0000)]
updated NSIS generation to build GTK version 1 or 2,
added new target "packaging" to root Makefile.nmake,
which will generate version 1 or 2 or both,
depending on config.nmake GTK?_DIR setting

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9866 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd support for the "matches" operator if HAVE_LIBPCRE is defined.
obiot [Mon, 26 Jan 2004 21:02:36 +0000 (21:02 +0000)]
Add support for the "matches" operator if HAVE_LIBPCRE is defined.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9865 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a dissector table for LAPD SAPIs, and move the #defines for them
guy [Mon, 26 Jan 2004 20:48:39 +0000 (20:48 +0000)]
Add a dissector table for LAPD SAPIs, and move the #defines for them
into "lapd_sapi.h".  Use that to register the Q.931 dissector atop LAPD.

From Rolf Fiedler: ISDN TEI management frame support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9864 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Lars Ruoff:
obiot [Mon, 26 Jan 2004 19:16:30 +0000 (19:16 +0000)]
From Lars Ruoff:

- made streams list sortable by column
- added a button "Find Reverse" that finds the reverse stream to the
  selected forward stream. (If different reverse streams available,
  pushing the button repeatedly will cycle through all of them,
  one after the other.)
- tidied up lots of superflous code.

Also get rid of a const pointer cast warning, and remove the _U_ attribute
from rtpstream_reset().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9863 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadded a tooltip to explain the behaviour of the syntax check in the filter string
ulfl [Mon, 26 Jan 2004 18:51:04 +0000 (18:51 +0000)]
added a tooltip to explain the behaviour of the syntax check in the filter string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9862 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadded a tooltip to explain the behaviour of the syntax check in the filter toolbar
ulfl [Mon, 26 Jan 2004 18:40:44 +0000 (18:40 +0000)]
added a tooltip to explain the behaviour of the syntax check in the filter toolbar

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9861 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoslightly changed the menuitem names in View->Show->Packet xy
ulfl [Mon, 26 Jan 2004 18:35:56 +0000 (18:35 +0000)]
slightly changed the menuitem names in View->Show->Packet xy

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9860 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOn Windows OT, interface names *can* have spaces in them; to find the
guy [Mon, 26 Jan 2004 09:05:59 +0000 (09:05 +0000)]
On Windows OT, interface names *can* have spaces in them; to find the
interface name, look forward in the interface string for "\Device\", not
backwards for a space, on Windows.  (Continue to look backwards for a
space on UNIX; names don't start with "\Device\", or even "/dev/", and
don't have spaces in them on any UNIX-flavored OS I know of.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9859 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofilter_packets: don't refilter all the packets,
ulfl [Mon, 26 Jan 2004 06:43:00 +0000 (06:43 +0000)]
filter_packets: don't refilter all the packets,
if the new filter string is identical to the old one (as it's useless then)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9858 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't muck with the Ethernet pseudo-header if we have an 802.11 capture.
guy [Sun, 25 Jan 2004 23:50:48 +0000 (23:50 +0000)]
Don't muck with the Ethernet pseudo-header if we have an 802.11 capture.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9857 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't use "cf_read_error_message()" when reporting errors not from
guy [Sun, 25 Jan 2004 22:27:12 +0000 (22:27 +0000)]
Don't use "cf_read_error_message()" when reporting errors not from

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9856 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFree the error info string after using it.
guy [Sun, 25 Jan 2004 22:21:39 +0000 (22:21 +0000)]
Free the error info string after using it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9855 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of an unused variable.
guy [Sun, 25 Jan 2004 22:21:01 +0000 (22:21 +0000)]
Get rid of an unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9854 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIn "main_filter_packets()", use the "cf" argument rather than always
guy [Sun, 25 Jan 2004 22:20:21 +0000 (22:20 +0000)]
In "main_filter_packets()", use the "cf" argument rather than always
passing "&cfile" to "filter_packets()".

Mark the "w" argument to "filter_activate_cb()" as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9853 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHave the Wiretap open, read, and seek-and-read routines return, in
guy [Sun, 25 Jan 2004 21:55:17 +0000 (21:55 +0000)]
Have the Wiretap open, read, and seek-and-read routines return, in
addition to an error code, an error info string, for
WTAP_ERR_BAD_RECORD errors.  Replace the error messages logged with
"g_message()" for those errors with g_strdup()ed or g_strdup_printf()ed
strings returned as the error info string, and change the callers of
those routines to, for those errors, put the info string into the
printed message or alert box for the error.

Add messages for cases where those errors were returned without printing
an additional message.

Nobody uses the error code from "cf_read()" - "cf_read()" puts up the
alert box itself for failures; get rid of the error code, so it just
returns a success/failure indication.

Rename "file_read_error_message()" to "cf_read_error_message()", as it
handles read errors from Wiretap, and have it take an error info string
as an argument.  (That handles a lot of the work of putting the info
string into the error message.)

Make some variables in "ascend-grammar.y" static.

Check the return value of "erf_read_header()" in "erf_seek_read()".

Get rid of an unused #define in "i4btrace.c".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9852 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadding a function to the help dialog, showing a specific topic (context help),
ulfl [Sun, 25 Jan 2004 21:27:16 +0000 (21:27 +0000)]
adding a function to the help dialog, showing a specific topic (context help),
beautifying the placement of the help button in the button_row,
using the context help for the filter dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9851 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDelete generated files during distclean instead of maintainerclean, so
gerald [Sun, 25 Jan 2004 18:52:33 +0000 (18:52 +0000)]
Delete generated files during distclean instead of maintainerclean, so
that we pass distcheck.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9850 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoapply automatically generated filters strings to the recent dropdown list,
ulfl [Sun, 25 Jan 2004 18:51:26 +0000 (18:51 +0000)]
apply automatically generated filters strings to the recent dropdown list,
e.g. when applying a "Follow TCP stream",
fix a bug in the recent function, discarding the newest entries when
saving a full list (now discarding the oldest).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9849 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix some filter dialog things
ulfl [Sun, 25 Jan 2004 18:39:55 +0000 (18:39 +0000)]
fix some filter dialog things

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9848 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake the definition of tvb_format_text() match what's in tvbuff.h.
gerald [Sun, 25 Jan 2004 17:53:55 +0000 (17:53 +0000)]
Make the definition of tvb_format_text() match what's in tvbuff.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9847 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCapitalize "Ethereal.icns" to fix a distclean error. Add its description
gerald [Sun, 25 Jan 2004 17:51:54 +0000 (17:51 +0000)]
Capitalize "Ethereal.icns" to fix a distclean error.  Add its description
to README.image.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9846 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix 'warning: cast discards qualifiers from pointer target type' by removing cast
jmayer [Sun, 25 Jan 2004 17:33:20 +0000 (17:33 +0000)]
Fix 'warning: cast discards qualifiers from pointer target type' by removing cast

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9845 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove the cast again and do the proper fix (add right type to union)
jmayer [Sun, 25 Jan 2004 17:22:57 +0000 (17:22 +0000)]
Remove the cast again and do the proper fix (add right type to union)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9844 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a cast to avoid a signedness warning
jmayer [Sun, 25 Jan 2004 17:07:57 +0000 (17:07 +0000)]
Add a cast to avoid a signedness warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9843 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChange the first arg to hex_str_to_bytes from guchar* -> char*
jmayer [Sun, 25 Jan 2004 16:58:25 +0000 (16:58 +0000)]
Change the first arg to hex_str_to_bytes from guchar* -> char*

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9842 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoA few signedness warning fixes
jmayer [Sun, 25 Jan 2004 15:56:04 +0000 (15:56 +0000)]
A few signedness warning fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9841 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe octets in an ip address are unsigned
jmayer [Sun, 25 Jan 2004 15:35:45 +0000 (15:35 +0000)]
The octets in an ip address are unsigned

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9840 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd syntax check and an "Add Expression" button to the filter toolbar
ulfl [Sun, 25 Jan 2004 15:10:36 +0000 (15:10 +0000)]
add syntax check and an "Add Expression" button to the filter toolbar

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9839 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadded/changed some tooltips
ulfl [Sun, 25 Jan 2004 13:47:09 +0000 (13:47 +0000)]
added/changed some tooltips

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9838 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agochanged the behaviour of the edit buttons to make more sense,
ulfl [Sun, 25 Jan 2004 12:25:57 +0000 (12:25 +0000)]
changed the behaviour of the edit buttons to make more sense,
removed the no longer needed "Edit and "Copy" buttons,
do a lot of code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9837 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomake resized prefs_dlg look better
ulfl [Sun, 25 Jan 2004 12:22:20 +0000 (12:22 +0000)]
make resized prefs_dlg look better

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9836 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agominor GTK2 layout change
ulfl [Sun, 25 Jan 2004 12:10:27 +0000 (12:10 +0000)]
minor GTK2 layout change

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9835 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a warning by using a function typedef
jmayer [Sun, 25 Jan 2004 09:49:50 +0000 (09:49 +0000)]
Fix a warning by using a function typedef

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9834 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoReport open errors when saving the contents of an RTP stream. Check for
guy [Sun, 25 Jan 2004 02:24:44 +0000 (02:24 +0000)]
Report open errors when saving the contents of an RTP stream.  Check for
and report write errors as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9833 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCheck for write errors when writing CSV data as well.
guy [Sun, 25 Jan 2004 02:14:05 +0000 (02:14 +0000)]
Check for write errors when writing CSV data as well.

Check for write errors when opening the CSV file to write the reverse
data information.

For some reason (perhaps having to do with the sort indicators in
titles, the column titles don't show up in the GtkCList structure, so
they don't get printed; just directly use the table of column titles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9832 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCheck whether the "fopen()" that creates a CSV file fails and, if so,
guy [Sun, 25 Jan 2004 01:58:58 +0000 (01:58 +0000)]
Check whether the "fopen()" that creates a CSV file fails and, if so,
report the error and don't dismiss the file selection dialog box.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9831 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't have "follow_print_text()" display the error message, leave that
guy [Sun, 25 Jan 2004 01:53:24 +0000 (01:53 +0000)]
Don't have "follow_print_text()" display the error message, leave that
up to its caller.

Show errors as such, not as warnings, and show the right error message
for failures to open/create output files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9830 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd another check for output errors when printing.
guy [Sun, 25 Jan 2004 01:19:48 +0000 (01:19 +0000)]
Add another check for output errors when printing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9829 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThere's no need to keep a "FILE *" for the file being printed to in a
guy [Sun, 25 Jan 2004 00:58:13 +0000 (00:58 +0000)]
There's no need to keep a "FILE *" for the file being printed to in a
"capture_file" structure.  Keep it locally, instead.

Check for errors when printing packets.

Report failure to open a print destination and failure to write to a
print destination differently.

Don't have the "print preamble" and "print final" routines return
success/failure indications - revert to the old scheme where they
didn't, and have the callers use "ferror()" to check for errors.

Report write errors when printing dissections in Tethereal.

Report print errors as errors, not warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9828 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded the ability to compile both GTK versions 1 and 2 at the same time.
ulfl [Sat, 24 Jan 2004 20:01:36 +0000 (20:01 +0000)]
Added the ability to compile both GTK versions 1 and 2 at the same time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9827 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix all fixable warnings
jmayer [Sat, 24 Jan 2004 16:48:12 +0000 (16:48 +0000)]
Fix all fixable warnings

Move addional warnings from extra-gcc-checks to normal compilation flags

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9826 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAs with "file_write_error_message()", so with
guy [Sat, 24 Jan 2004 10:53:25 +0000 (10:53 +0000)]
As with "file_write_error_message()", so with
"file_close_error_message()" - but just use "file_write_error_message()"
for UNIX-style errors, under the assumption that a close will only fail
because a buffer-flushing write fails or because "close()" itself fails
when, for example, pushing unsynced NFS client-side writes out over the

Make several routines in "print.c" return success/failure indications.

Check for write errors when printing "Follow TCP Stream" stuff or saving
it to a file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9825 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoTrivial signed/unsigned warning fixes
jmayer [Sat, 24 Jan 2004 02:07:05 +0000 (02:07 +0000)]
Trivial signed/unsigned warning fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9824 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAs with "cf_open_error_message()"/"file_open_error_message()", so with
guy [Sat, 24 Jan 2004 02:01:44 +0000 (02:01 +0000)]
As with "cf_open_error_message()"/"file_open_error_message()", so with

Use "file_open_error_message()" instead of "cf_open_error_message()" in
some places we missed in the previous checkin.

Catch ENOSPC and EDQUOT in "file_open_error_message()".

Use "file_open_error_message()" rather than "file_write_error_message()"
to report errors when creating the file to which we're saving the
"Follow TCP Stream" data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9823 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoTrivial warning fixes
jmayer [Sat, 24 Jan 2004 01:53:59 +0000 (01:53 +0000)]
Trivial warning fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9822 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a new "file_open_error_message()" routine in "epan/filesystem.c", to
guy [Sat, 24 Jan 2004 01:44:29 +0000 (01:44 +0000)]
Add a new "file_open_error_message()" routine in "epan/filesystem.c", to
translate UNIX errno values to a somewhat friendly message format

Rename "file_open_error_message()" in "file.c" to
"cf_open_error_message()", make "cf_open_error_message()" use the new
"file_open_error_message()" for UNIX errno values, have "do_capture()"
in "capture.c" use "file_open_error_message()" to report errors from
"open()", and make "cf_open_error_message()" static as nothing outside
"file.c" uses it.

Do similar stuff in "tethereal.c".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9821 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove extra , at end of enum, change C++ style comment
jmayer [Sat, 24 Jan 2004 01:30:20 +0000 (01:30 +0000)]
Remove extra , at end of enum, change C++ style comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9820 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Lars Ruoff (who also contributed the previous change; my apologies
guy [Sat, 24 Jan 2004 01:15:24 +0000 (01:15 +0000)]
From Lars Ruoff (who also contributed the previous change; my apologies
to both Larses):

- Comfort noise (CN) packets and packets following them
  immediately are excluded from maximum delay calculation (as
  well as marked packets are)
- Payload changes between CN and regular packets are ignored.
- Added a "Marker missing?" status warning for packets following
  CN that don't have the marker bit set (cf. RFC1890 4.1)
- Changed status "Ok" to "[ Ok ]", so that when sorting by status
  column, all non-Oks are grouped together.
- Minor GUI updates: reduced size of box, borders, spacing,
  changed highlight colors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9819 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHave "font_apply()" return an indication as to whether it succeeded or
guy [Sat, 24 Jan 2004 01:02:54 +0000 (01:02 +0000)]
Have "font_apply()" return an indication as to whether it succeeded or
failed and, if it failed, how it failed.  Have it leave up to its caller
the job of reporting that it couldn't load the requested font; have its
callers do that, and have them set the zoom level on failure so that we
have a zoom level that is at least more likely to work.  Make the alert
boxes for "font_apply()" failures be error boxes, not warning boxes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9818 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDo the font loading code as two larger sections of code, one for GTK+
guy [Fri, 23 Jan 2004 21:22:18 +0000 (21:22 +0000)]
Do the font loading code as two larger sections of code, one for GTK+
1.2[.x] and one for GTK+ 2.x, rather than as one section peppered with

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9817 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInclude the AddStyleName information in the zoomed font name.
guy [Fri, 23 Jan 2004 20:34:11 +0000 (20:34 +0000)]
Include the AddStyleName information in the zoomed font name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9816 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIf we call "font_apply()", we don't need to call
guy [Fri, 23 Jan 2004 20:13:23 +0000 (20:13 +0000)]
If we call "font_apply()", we don't need to call

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9815 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIf the zoom factor is zero, don't construct a new font name - the
guy [Fri, 23 Jan 2004 20:11:59 +0000 (20:11 +0000)]
If the zoom factor is zero, don't construct a new font name - the
supplied font name is correct.  That lets us handle fonts whose size we
can't change because this is GTK+ 1.2[.x] and the name isn't an XLFD
name so we don't know where the size is.

In "font_zoom()", remove some code from the GTK+ 1.2[.x] vs. GTK+ 2.x

Fix the comment for "font_zoom()".

Get rid of a no-longer-used "simple_dialog()" argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9814 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoClean up indentation.
guy [Fri, 23 Jan 2004 19:53:10 +0000 (19:53 +0000)]
Clean up indentation.

Make "font_zoom()" static - it's not used outside gtk/main.c.

Use "g_strdup()" rather than "strdup()", as we use "g_free()" to free
the result.

Put in a little more information when "font_zoom()" fails due to the
font name not being an XLFD font name, and don't continue if it fails.

Don't continue if the attempt to load the fonts fails, either.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9813 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Akira Endoh: support for labeled IPv6 unicast in the MP-BGP
guy [Fri, 23 Jan 2004 19:19:44 +0000 (19:19 +0000)]
From Akira Endoh: support for labeled IPv6 unicast in the MP-BGP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9812 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom David Fort: NSEC RRs aren't the same as NXT RRs - dissect them
guy [Fri, 23 Jan 2004 19:16:52 +0000 (19:16 +0000)]
From David Fort: NSEC RRs aren't the same as NXT RRs - dissect them

Remove a redundant "break" statement.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9811 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremoved line breaks to be able to compile again
ulfl [Fri, 23 Jan 2004 18:18:19 +0000 (18:18 +0000)]
removed line breaks to be able to compile again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9810 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofixed various things in "View" menu
ulfl [Fri, 23 Jan 2004 16:10:09 +0000 (16:10 +0000)]
fixed various things in "View" menu

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9809 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadded a comment
ulfl [Fri, 23 Jan 2004 16:08:38 +0000 (16:08 +0000)]
added a comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9808 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix assert, when failed loading zoomed font,
ulfl [Fri, 23 Jan 2004 16:07:37 +0000 (16:07 +0000)]
fix assert, when failed loading zoomed font,
prepare possibility to put filter toolbar just below the main toolbar

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9807 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"sprint_realloc_value()" takes a "u_char **" as an argument - pass it
guy [Fri, 23 Jan 2004 10:25:08 +0000 (10:25 +0000)]
"sprint_realloc_value()" takes a "u_char **" as an argument - pass it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9806 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yuriy Sidelnikov: call ACSE dissector for any presentation context.
guy [Fri, 23 Jan 2004 10:15:37 +0000 (10:15 +0000)]
From Yuriy Sidelnikov: call ACSE dissector for any presentation context.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9805 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yuriy Sidelnikov: call ACSE dissector for any presentation context.
guy [Fri, 23 Jan 2004 09:53:18 +0000 (09:53 +0000)]
From Yuriy Sidelnikov: call ACSE dissector for any presentation context.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9804 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"%.*" requires an "int" argument for the length.
guy [Fri, 23 Jan 2004 09:50:47 +0000 (09:50 +0000)]
"%.*" requires an "int" argument for the length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9803 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChange msg from guint8* to gchar* (because of tvb_format_text change)
jmayer [Fri, 23 Jan 2004 09:47:39 +0000 (09:47 +0000)]
Change msg from guint8* to gchar* (because of tvb_format_text change)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9802 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChange return type of tvb_format_text from guint8* to gchar*.
jmayer [Fri, 23 Jan 2004 09:40:38 +0000 (09:40 +0000)]
Change return type of tvb_format_text from guint8* to gchar*.
Remove now unnecessary casts in two files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9801 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate manuf
jmayer [Fri, 23 Jan 2004 09:24:38 +0000 (09:24 +0000)]
Update manuf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9800 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to GLib 2.2.3-20040116 and gettext 0.13.1.
gerald [Fri, 23 Jan 2004 02:38:03 +0000 (02:38 +0000)]
Update to GLib 2.2.3-20040116 and gettext 0.13.1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9799 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoImprove some comments.
guy [Fri, 23 Jan 2004 02:09:18 +0000 (02:09 +0000)]
Improve some comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9798 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agotrivial signed/unsigned warning fixes
jmayer [Fri, 23 Jan 2004 01:51:38 +0000 (01:51 +0000)]
trivial signed/unsigned warning fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9797 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMove struct tcp_frag from follow.h to follow.c as it wasn't used anywere
jmayer [Fri, 23 Jan 2004 01:42:45 +0000 (01:42 +0000)]
Move struct tcp_frag from follow.h to follow.c as it wasn't used anywere
Fix a trivial signed/unsigned warning in follow.c by changing tcp_frag.data
from guchar* to gchar*

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9796 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agogtk_font_selection_set_filter doesn't work when run before appending
ulfl [Fri, 23 Jan 2004 01:12:46 +0000 (01:12 +0000)]
gtk_font_selection_set_filter doesn't work when run before appending
the font selection widget to the notebook.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9795 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agocode cleanup
ulfl [Fri, 23 Jan 2004 01:10:24 +0000 (01:10 +0000)]
code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9794 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom David Fort: add support for RFC2535bis records.
guy [Fri, 23 Jan 2004 00:51:47 +0000 (00:51 +0000)]
From David Fort: add support for RFC2535bis records.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9793 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomake some of the new menuitems insensitive,
ulfl [Fri, 23 Jan 2004 00:43:29 +0000 (00:43 +0000)]
make some of the new menuitems insensitive,
if no capture file/data is available

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9792 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agotrivial signed/unsigned warning fixes
jmayer [Fri, 23 Jan 2004 00:43:15 +0000 (00:43 +0000)]
trivial signed/unsigned warning fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9791 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agosigned/unsigned warning fixes
jmayer [Fri, 23 Jan 2004 00:40:00 +0000 (00:40 +0000)]
signed/unsigned warning fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9790 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Pierre Juhen: add "find_protocol_by_id()" to the list of functions
guy [Fri, 23 Jan 2004 00:36:30 +0000 (00:36 +0000)]
From Pierre Juhen: add "find_protocol_by_id()" to the list of functions
exported to plugins.

Fix some author list glitches.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9789 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Lars Roland:
guy [Fri, 23 Jan 2004 00:29:52 +0000 (00:29 +0000)]
From Lars Roland:

- "Refresh" button is back again.  Everything should work fine now
  with multiple windows on the same streams.
- made packet list sortable by column.
- show a warning when user chooses "RTP Streams/Analyze"
  without having a RTP packet selected instead of displaying the
  streams box.
- minor GUI updates, renamed button "Next" to "Next non-Ok" for
  more clarity.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9788 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yaniv Kaul: register multipart/form-data.
obiot [Thu, 22 Jan 2004 23:47:59 +0000 (23:47 +0000)]
From Yaniv Kaul: register multipart/form-data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9787 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSlight formatting change
jmayer [Thu, 22 Jan 2004 23:09:55 +0000 (23:09 +0000)]
Slight formatting change
Reorder lists alphabetically

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9786 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix the RCS ID.
guy [Thu, 22 Jan 2004 21:32:54 +0000 (21:32 +0000)]
Fix the RCS ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9785 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWe can't save "child_process" as a HANDLE on UNIX - save it as an "int",
guy [Thu, 22 Jan 2004 20:47:37 +0000 (20:47 +0000)]
We can't save "child_process" as a HANDLE on UNIX - save it as an "int",
and cast it in the "GetExitCodeProcess()" call (rather than converting
it when assigning it).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9784 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse "fork_child" rather than "child_process" - on Win32, "child_process"
guy [Thu, 22 Jan 2004 20:45:49 +0000 (20:45 +0000)]
Use "fork_child" rather than "child_process" - on Win32, "child_process"
tracks "fork_child", and, on UNIX, "child_process" doesn't exist.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9783 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse the length field in the UDP header:
guy [Thu, 22 Jan 2004 20:43:17 +0000 (20:43 +0000)]
Use the length field in the UDP header:

if it's < 8, don't dissect anything past the length field (the
length must be >= 8);

otherwise, if it's less than the data or reported length from
the tvbuff, use the length from the header;

otherwise, don't checksum the packet (if it's greater than the
reported length, and the packet isn't fragmented, we should
somehow report that as an error).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9782 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a typo.
guy [Thu, 22 Jan 2004 20:33:21 +0000 (20:33 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9781 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMove the list of headers to "Makefile.am" (it's not used by
guy [Thu, 22 Jan 2004 20:31:44 +0000 (20:31 +0000)]
Move the list of headers to "Makefile.am" (it's not used by
"Makefile.nmake"), and rename it to "noinst_HEADERS", as that's what
automake requires.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9780 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoepan don't need GTK_CFLAGS as GTK isn't used,
ulfl [Thu, 22 Jan 2004 19:27:59 +0000 (19:27 +0000)]
epan don't need GTK_CFLAGS as GTK isn't used,
GLIB_CFLAGS are just enough

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9779 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobugfix: wrong parameter name
ulfl [Thu, 22 Jan 2004 19:25:36 +0000 (19:25 +0000)]
bugfix: wrong parameter name

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9778 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomoved GTK specific parts from capture.c to ui_util.c,
ulfl [Thu, 22 Jan 2004 18:13:57 +0000 (18:13 +0000)]
moved GTK specific parts from capture.c to ui_util.c,
implemented Win32 "Capture Stop" when using
"update list of packets in realtime" while capturing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9777 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadded new Makefile.common just like in root,
ulfl [Thu, 22 Jan 2004 18:08:58 +0000 (18:08 +0000)]
added new Makefile.common just like in root,
including sources common in Makefile.am and Makefile.nmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9776 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd RCS ID with "$Id: $" (colon was missing).
obiot [Thu, 22 Jan 2004 07:14:36 +0000 (07:14 +0000)]
Add RCS ID with "$Id: $" (colon was missing).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9775 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe progressbar had a parameter to specify the text of the Cancel/Stop button.
ulfl [Wed, 21 Jan 2004 22:00:28 +0000 (22:00 +0000)]
The progressbar had a parameter to specify the text of the Cancel/Stop button.
As this will always be a Cancel of a running operation, this parameter was removed.
This makes us also able to use a stock button for this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9774 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agothis dialog isn't used any longer.
ulfl [Wed, 21 Jan 2004 21:56:12 +0000 (21:56 +0000)]
this dialog isn't used any longer.
All setting moved to direct menuitems under View

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9773 f5534014-38df-0310-8fa8-9805f1628bb7