guy [Sat, 1 Jan 2005 12:32:28 +0000 (12:32 +0000)]
Throw in a cast to squelch an (unavoidable, and probably harmless -
GTK+'s function signatures aren't necessarily what they should be)
warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12912
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 1 Jan 2005 12:29:26 +0000 (12:29 +0000)]
"address_to_str()" and "address_to_str_buf()" don't modify the "address"
structure pointed to them by reference, so make the argument a "const"
pointer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12911
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 1 Jan 2005 02:57:02 +0000 (02:57 +0000)]
As we've made the tap_specific_data field of a tap_packet_t structure a
const pointer (so that we don't get complaints when we make the
tap-specific data argument to "tap_queue_packet()" a const pointer,
allowing dissectors to hand const data to a tap without a complaint), we
should make the tap per-packet function take a const pointer as an
argument as well. Do so.
In some taps, use _U_, or actually use the argument, rather than
sticking in dummy "X = X" assignments to fake use of parameters. (This
means that the tap functions in question no longer have the notion that
they act on a particular static structure wired in.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12910
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 22:00:44 +0000 (22:00 +0000)]
Note what Fibre Channel spec documents this protocol.
Don't assign the const pointers passed to hash routines to non-const
pointers.
In "zonenm_to_str()", don't assume there's a null terminator in the
packet - use "tvb_get_string()" so that the buffer into which it's
copied is explicitly null-terminated.
Put the Domain & Port into the protocol tree as a "0xXXXXXXXX" string,
rather than as a string with one blank in it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12909
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 21:40:22 +0000 (21:40 +0000)]
Don't bother copying the switch name to a buffer - we can just use
"tvb_get_ptr()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12908
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 21:36:08 +0000 (21:36 +0000)]
Fix a bug introduced in the previous checkin.
Make the names for list record types match the names used before the
previous checkin.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12907
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 21:20:46 +0000 (21:20 +0000)]
FC-over-IP is now covered by RFCs; update the specification references.
Make the protcol/version information an array of 8 bytes, not 2 guints;
not all the world's a (little-endian) PC!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12906
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 20:58:23 +0000 (20:58 +0000)]
Note what Fibre Channel spec documents this protocol.
Don't assign the const pointers passed to hash routines to non-const
pointers.
Don't use "tvb_get_ptr()" to get a pointer to a data structure, and
dereference that pointer - there's no guarantee that the structure in
question will be located on an appropriate boundary in the data from the
packet (regardless of whether it's properly aligned within the data for
the protocol being dissected).
Put the record length for an EFP request into the protocol tree.
Check the sanity of the payload length for that request.
In "zonenm_to_str()", don't assume there's a null terminator in the
packet - use "tvb_get_string()" so that the buffer into which it's
copied is explicitly null-terminated.
Put the Domain & Port into the protocol tree as a "0xXXXXXXXX" string,
rather than as a string with one blank in it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12905
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 20:35:55 +0000 (20:35 +0000)]
Note what Fibre Channel spec documents this protocol.
Don't assign the const pointers passed to hash routines to non-const
pointers.
Don't assume that strings the spec says are null-terminated are
necessarily null-terminated in the packet - use "tvb_strsize()" to find
the length of the purported null-terminated string; it'll throw the
appropriate exception if no null is found.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12904
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Fri, 31 Dec 2004 14:53:17 +0000 (14:53 +0000)]
Update some function declarations in the plugin api
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12903
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Fri, 31 Dec 2004 14:27:38 +0000 (14:27 +0000)]
From Luis Ontanon for Mate:
- moved gop and gog indexes into gopcfgs, which is a propedeutic
change for upcoming changes in the way gops are to be grouped
- changed the way gog-keys are kept in memory
- every gopkey attribute is copied into the gop->extras to avoid
redundancy in the configuration
- added timers to gogs mate.gog_type.StartTime and mate.gog_type.Time
- fixed a bug in scs_subscribe that mangled some strings
- minor interface improvement to scs propedeutic to having types avp
values in a future
- changed medium and large into mate_medium and mate_large in the
scs_collection
- fixed Mode=Replace in Transforms, now it works
- fixed a crash at reinit due to impropper initialization of mate_items
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12902
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Fri, 31 Dec 2004 14:14:44 +0000 (14:14 +0000)]
Fix from Luis Ontanon:
Bring tap-h225counter.c in sync with newest revision of the h225 dissector
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12901
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 03:18:13 +0000 (03:18 +0000)]
Use "proto_tree_add_item()" to add a chunk of bytes to the protocol
tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12900
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 03:17:00 +0000 (03:17 +0000)]
Don't assign const pointers to non-const pointers, especially if the
object pointed to by the non-const pointer won't be modified.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12899
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 03:14:18 +0000 (03:14 +0000)]
"string_to_hex()" doesn't modify its first argument, so make it a
"const" pointer, and don't cast away the constness of "tvb_get_ptr()"s
result when passing it to "string_to_hex()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12898
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 03:12:51 +0000 (03:12 +0000)]
Don't cast away the constness of pointers passed to "ip_to_str()" -
"ip_to_str()" takes a "const guint8 *" argument.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12897
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 03:10:11 +0000 (03:10 +0000)]
There are no guarantees that "strncasecmp()" works with
non-null-terminated strings, so be safe and fetch the metatag string
with "tvb_get_string()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12896
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 02:48:53 +0000 (02:48 +0000)]
Use "tvb_memeql()" to check whether specified bytes in a packet have a
specified value.
Make a constant array "const".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12895
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 02:16:05 +0000 (02:16 +0000)]
Don't cast away the constness of argument pointers.
Don't supply our own definition of AF_INET or our own declaration of
"inet_pton()" - use the system ones if they're available.
"mkipv4_address()" doesn't modify the string passed to it - make it a
const pointer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12894
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 02:13:42 +0000 (02:13 +0000)]
Don't roll our own code to display IPv4 or IPv6 addresses, use
"ip_to_str()" and "ip6_to_str()".
Check the length of items for IPv4 and IPv6 addresses before displaying
them as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12893
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 02:11:13 +0000 (02:11 +0000)]
Don't assign the const pointers passed to hash routines to non-const
pointers.
Now that "col_set_str()" takes a "const char *" as the second argument,
we don't have to cast away the constness of strings passed to it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12892
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 02:09:48 +0000 (02:09 +0000)]
Don't assign a const pointer argument to a non-const pointer variable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12891
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 02:08:01 +0000 (02:08 +0000)]
Don't assign the const pointers passed to hash routines to non-const
pointers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12890
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 02:03:16 +0000 (02:03 +0000)]
Properly cast the pointer assigned to col_info->col_data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12889
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 02:02:19 +0000 (02:02 +0000)]
"proto_registrar_get_byname()" doesn't modify its argument, so make it
"const char *".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12888
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 02:01:03 +0000 (02:01 +0000)]
Make arguments "const *" if the routine doesn't modify the object to
which they point.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12887
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 31 Dec 2004 01:56:22 +0000 (01:56 +0000)]
Make sure print_buff is \0-terminated
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12886
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 31 Dec 2004 01:37:54 +0000 (01:37 +0000)]
As pointed out by Guy: We should be able to filter on the original SSID,
so use a copy of the existing one for printing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12885
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 00:33:54 +0000 (00:33 +0000)]
In column sort routines, make the row pointers "const" pointers, as the
arguments passed in corresponding to those pointers are gconstpointers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12884
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 00:32:00 +0000 (00:32 +0000)]
As "get_persconffile_path()" doesn't return a "const char *", neither
does "get_plugins_pers_dir()" - and "get_plugins_global_dir()" doesn't
return one either. Both of them return mallocated data, and making them
return a "const char *" just causes compiler whining when you try to
free them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12883
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 00:29:09 +0000 (00:29 +0000)]
"get_persconffile_path()" doesn't return a "const char *", it just
returns a "char *", so don't assign its return value to a "const char *".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12882
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 00:26:36 +0000 (00:26 +0000)]
"gtk_entry_get_text()" returns a "const char *" - assign the result to
one.
"get_basename()" doesn't modify its argument, and its callers don't
modify the substring pointed to by the result, so make it take a "const
char *" as an argument and return a "const char *".
"find_last_pathname_separator()" doesn't modify its argument, so make it
a "const char *" - but some of its callers pass a non-"const" "char *"
and modify the result, so don't make its return value a "const char *".
And, as none of its callers are outside "filesystem.c", make it static.
In "about_folders_page_new()", have separate variables for pathnames
returned as "const char *" (which are cached by the routine that returns
them, so you can't modify them - and can't free them, so get rid of the
commented-out "g_free()" calls for them) and pathnames returned as "char
*" (which are allocated anew for each call, and can be modified, but
have to be freed).
Clean up white space.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12881
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 00:12:25 +0000 (00:12 +0000)]
Make the "col_data" field in a "column_info" structure a pointer to an
array of "const char *" rather than to an array of "char *", and make
the second argument of "col_set_str()" a "const char *" - there's no
guarantee that "col_data" points to something you're allowed to modify.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12880
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Dec 2004 00:05:22 +0000 (00:05 +0000)]
Add a "tvb_bytes_to_str_punct()" routine, which wraps
"bytes_to_str_punct()", and use it instead of extracting the bytes and
formatting them by hand.
Also, export "bytes_to_str_punct()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12879
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 23:57:29 +0000 (23:57 +0000)]
Make the "col_data" field in a "column_info" structure a pointer to an
array of "const char *" rather than to an array of "char *", and make
the second argument of "col_set_str()" a "const char *" - there's no
guarantee that "col_data" points to something you're allowed to modify.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12878
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 23:56:12 +0000 (23:56 +0000)]
The first argument to "adler32_bytes()" is only passed on to
"update_adler32()", and the corresponding argument is a "const unsigned
char *", so that argument can be a "const unsigned char *".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12877
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 23:47:52 +0000 (23:47 +0000)]
Add a "tvb_bytes_to_str_punct()" routine, which wraps
"bytes_to_str_punct()", and use it instead of extracting the bytes and
formatting them by hand.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12876
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 23:42:02 +0000 (23:42 +0000)]
Make the "col_data" field in a "column_info" structure a pointer to an
array of "const char *" rather than to an array of "char *", and make
the second argument of "col_set_str()" a "const char *" - there's no
guarantee that "col_data" points to something you're allowed to modify.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12875
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 23:19:17 +0000 (23:19 +0000)]
We now require gint64/guint64 support to build Ethereal, so get rid of
the #ifdefs.
Don't use "%ll[doux]" - not all platforms use "ll" as the length
specifier for 64-bit integers in formats. Use PRI[doux]64 instead, to
handle platforms where some other length specifier is used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12874
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 30 Dec 2004 22:40:21 +0000 (22:40 +0000)]
Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12873
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 30 Dec 2004 22:39:28 +0000 (22:39 +0000)]
Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12872
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 30 Dec 2004 22:38:59 +0000 (22:38 +0000)]
Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12871
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 18:34:11 +0000 (18:34 +0000)]
Regenerate.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12870
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 18:33:14 +0000 (18:33 +0000)]
Fix the declaration of "tap_queue_packet()" to match its new signature.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12869
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 30 Dec 2004 16:45:37 +0000 (16:45 +0000)]
From Vincent Jardin: Fix the dissection of relayed messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12868
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 03:32:38 +0000 (03:32 +0000)]
Add "get_addr_name()" to the list of items exported by libethereal.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12867
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 02:28:50 +0000 (02:28 +0000)]
Fix some cut-and-pasteos.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12866
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 02:27:00 +0000 (02:27 +0000)]
In the "capture_null()" routine, handle IPv6.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12865
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 02:21:33 +0000 (02:21 +0000)]
Update a URL.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12864
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Dec 2004 02:10:24 +0000 (02:10 +0000)]
Add a "get_addr_name()" routine that takes an "address *" and attempts
to resolve it to a name.
Fix up some const-pointer-to-non-const-pointer, and
function-pointer-to-void-*, conversions.
Fix some comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12863
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 29 Dec 2004 22:31:56 +0000 (22:31 +0000)]
From Albert Chin: not all compilers support a comma after the last value
in an enum.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12862
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 29 Dec 2004 22:17:04 +0000 (22:17 +0000)]
From Albert Chin: get rid of C99/GCCisms (initializing automatic
structures with non-constant values).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12861
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 29 Dec 2004 21:31:18 +0000 (21:31 +0000)]
From Albert Chin: "config.h" should always be included first first when
using AC_SYS_LARGEFILE.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12860
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 29 Dec 2004 21:29:53 +0000 (21:29 +0000)]
Pass "capture_opts" to "capture_loop_dispatch()", as
"capture_loop_dispatch()" uses it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12859
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 29 Dec 2004 21:20:42 +0000 (21:20 +0000)]
Fix it to compile on systems without "pcap_datalink_val_to_name()" (or
with "pcap_datalink_val_to_name()" but without a declaration of it in
"pcap.h" *cough* Software Update *cough*).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12858
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 29 Dec 2004 16:25:06 +0000 (16:25 +0000)]
Remove some unneeded backslashes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12857
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 29 Dec 2004 15:54:55 +0000 (15:54 +0000)]
If we can't find the "svn" executable in the current path, look in
"c:/cygwin/lib/subversion/bin/", which is the current default location
for Subversion 1.1.1 under Cygwin. If we still can't find "svn", simply
return instead of exiting.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12856
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 29 Dec 2004 12:37:06 +0000 (12:37 +0000)]
move global capture_child flag into capture_options
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12855
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Wed, 29 Dec 2004 12:28:16 +0000 (12:28 +0000)]
- new optional parameter ETH_VAR for #.EXPORTS directive
- few fixes for last changes
Summary of changes during last three revisions
- NULL can be used in #.PDU or #.REGISTER directive
- fix in cyclic dependency handling
- keep <proto>-exp.cnf file regardless of '-k' option
- handling of negative values in SingleValue or ValueRange constraints
- handling of all SEQUONCE/SET (OF) types including SIZE constraint
- rename ber_sequence->ber_sequence_t and ber_choice->ber_choice_t
- rename dissect_ber_integer_new()->dissect_ber_integer()
- fix number of parameters for dissect_per_GeneralString()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12854
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 29 Dec 2004 09:09:35 +0000 (09:09 +0000)]
Don't use a global capture_opts in the capturing engine (this isn't a good idea). Do some more "housekeeping" in the capturing part.
Hopefully the unspecified forward declaration of capture_options_t in main.h is portable, but buildbot will tell me. This way I need the internals of that struct only at the places I really use it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12853
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 29 Dec 2004 01:08:20 +0000 (01:08 +0000)]
Make the tone of the error messages a bit less formal, by using
contractions. (Safari does, at least when you're trying to open a file
to which you don't have read access.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12852
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 29 Dec 2004 00:51:29 +0000 (00:51 +0000)]
Use the "errmsg_len" argument to "capture_loop_open_output()" -
"sizeof(errmsg)', when "errmsg" is a "char *", doesn't give the size of
the string to which "errmsg" points, it gives the size of the pointer
itself, which is too small.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12851
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 29 Dec 2004 00:44:45 +0000 (00:44 +0000)]
Add Ethernet type for DEC Local Area Systems Transport.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12850
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 28 Dec 2004 19:59:50 +0000 (19:59 +0000)]
Remove some macros that were making the "splint" utility throw a fit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12849
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 28 Dec 2004 00:36:06 +0000 (00:36 +0000)]
some code cleanup (comments changed)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12848
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 28 Dec 2004 00:10:04 +0000 (00:10 +0000)]
add a more detailed description, how to add a new dissector file
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12847
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 27 Dec 2004 22:04:49 +0000 (22:04 +0000)]
a lot of code cleanup/refactoring
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12846
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 27 Dec 2004 21:35:09 +0000 (21:35 +0000)]
fix a freebsd buildbot compile error, caused by myself :-(
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12845
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 27 Dec 2004 16:11:08 +0000 (16:11 +0000)]
fix a solaris buildbot compile error
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12844
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 27 Dec 2004 14:27:27 +0000 (14:27 +0000)]
location of cygwin's docbook xml changed
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12843
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 27 Dec 2004 13:17:20 +0000 (13:17 +0000)]
Again, some warnings removed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12842
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 27 Dec 2004 10:11:28 +0000 (10:11 +0000)]
Again, another warning (hopefully) removed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12841
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 26 Dec 2004 22:52:16 +0000 (22:52 +0000)]
From Jouni Malinen: use a length field from the packet to determine how
much data is available, rather than using "tvb_length_remaining()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12840
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 26 Dec 2004 22:26:02 +0000 (22:26 +0000)]
From Yaniv Kaul: add Ethernet address-to-name (or, at least, address-to-
vendor-name-and-next-three-bytes-in-hex) resolution for Ethernet/802.x
hardware addresses.
Move the ARP hardware types into a header file, for use by dissectors
other than the ARP dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12839
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 26 Dec 2004 18:58:52 +0000 (18:58 +0000)]
From Vincent Jardin:
- support for new DHCPv6 options
- fix for the support of OPTION_RELAY_MSG
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12838
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 26 Dec 2004 10:11:42 +0000 (10:11 +0000)]
Again, some warnings removed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12837
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 26 Dec 2004 00:28:47 +0000 (00:28 +0000)]
From Jouni Malinen: dissect TLS extensions (RFC 3546) for ClientHello
and ServerHello.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12836
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 26 Dec 2004 00:22:16 +0000 (00:22 +0000)]
From Luis Ontanon: add more filterable fields to DNS, PGM, GTP, and RADIUS.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12835
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 25 Dec 2004 18:35:21 +0000 (18:35 +0000)]
Again, some warnings removed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12834
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 25 Dec 2004 14:46:40 +0000 (14:46 +0000)]
Fix a core dump causing the buildbot test menagerie to fail. It was caused by incorrectly trying to proto_tree_add_item() with a very huge length. However, someone with more SQL knowledge than me should have a qualified look at that place and do a better fix.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12833
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 25 Dec 2004 13:49:30 +0000 (13:49 +0000)]
a lot of warnings removed, most of them about pointer to int casts without using the appropriate GLib macros
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12832
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 25 Dec 2004 10:30:58 +0000 (10:30 +0000)]
Again, some warnings removed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12831
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 24 Dec 2004 23:17:38 +0000 (23:17 +0000)]
use GLib's pointer to int conversion macros to prevent compiler warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12830
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 24 Dec 2004 22:21:23 +0000 (22:21 +0000)]
Note the RFC that describes VJ compression.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12829
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 24 Dec 2004 12:39:21 +0000 (12:39 +0000)]
New protocol RFC2510 PKIXCMP Certificate Management Protocol
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12828
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 24 Dec 2004 12:22:52 +0000 (12:22 +0000)]
export ResonFlags from pkix1implicit
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12827
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 24 Dec 2004 12:16:27 +0000 (12:16 +0000)]
export Certificate and CertificateList from pkix1explicit
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12826
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 24 Dec 2004 11:32:13 +0000 (11:32 +0000)]
New "protocol" the support functions from RFC2511 Certificate Request Message Format CRMF
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12825
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 24 Dec 2004 11:24:35 +0000 (11:24 +0000)]
export EnvelopedData
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12824
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 23 Dec 2004 19:56:29 +0000 (19:56 +0000)]
RST segmetns are never WindowFull segments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12823
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 23 Dec 2004 19:53:24 +0000 (19:53 +0000)]
add another error code to dcerpc
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12822
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 23 Dec 2004 13:34:02 +0000 (13:34 +0000)]
show a simple_dialog, if we use glib 1.x and trying to open a webbrowser (not implemented). This will prevent another compiler warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12821
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Thu, 23 Dec 2004 08:27:30 +0000 (08:27 +0000)]
Fixes for Mate from Luis Ontanon:
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- scs_subscribe doesn't use g_malloc anymore. it uses GMemChunks
(I had to rename two GMemChunks to make MSVC happy)
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- fixed few things at reinit:
- reset last_id
- remove the nodes in the items hash tables
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12820
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 23 Dec 2004 00:27:20 +0000 (00:27 +0000)]
Again, some warnings removed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12819
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Wed, 22 Dec 2004 19:44:42 +0000 (19:44 +0000)]
Clean up one more instance of 8-byte timestamps in SMB. Have to work on
the 4-byte ones soon.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12818
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Dec 2004 19:27:09 +0000 (19:27 +0000)]
RFC 2868 says that the length of a "tagged string" field must be at
least 3 - 2 for type+length and 1 for the tag - so treat a "tagged
string" field as bad if there isn't at least one byte of data. (It's a
bit odd that the RFC says that the tag must be in the range 0x01-0x1F -
that sounds suspiciously as if they're saying "printable characters
aren't valid tags", to allow untagged strings, which might suggest that
a field with a length of 2 should be interpreted as an empty string.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12817
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Dec 2004 10:44:20 +0000 (10:44 +0000)]
Check for all bogus ACE lengths, i.e. all lengths < 4.
Clean up indentation.
Add a comment asking whether the revision in an ACL is *really* 2 bytes
and the ACE count is *really* 4 bytes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12816
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Dec 2004 09:58:28 +0000 (09:58 +0000)]
Add only one protocol tree item for the "weak IV" flag - add it as a
non-hidden Boolean, and use "proto_tree_add_boolean_format()" to add it
to include the key byte.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12815
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Dec 2004 09:46:14 +0000 (09:46 +0000)]
Change the RCS ID - it's not getting expanded when it's "$Id $".
Fix a comment in conversations_wlan.c.
Refer to "WLAN" in hostlist_wlan.c, just as we do in
conversations_wlan.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12814
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Dec 2004 09:19:01 +0000 (09:19 +0000)]
From Brett Kuskie: recalculate the ranges every time an export dialog is
opened, not just the first time, so that if the packet counts change
up-to-date values are displayed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12813
f5534014-38df-0310-8fa8-
9805f1628bb7