obnox/wireshark/wip.git
16 years agoEmbedding EAP inside wimaxasncp.
martinm [Fri, 16 Nov 2007 23:03:09 +0000 (23:03 +0000)]
Embedding EAP inside wimaxasncp.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23474 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSome comments and formatting.
martinm [Fri, 16 Nov 2007 22:56:56 +0000 (22:56 +0000)]
Some comments and formatting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23473 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix trivial typo.
martinm [Fri, 16 Nov 2007 22:53:18 +0000 (22:53 +0000)]
Fix trivial typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23472 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen reassembly is off, catch ReportedBoundsError when calling a subdissector
morriss [Fri, 16 Nov 2007 22:04:27 +0000 (22:04 +0000)]
When reassembly is off, catch ReportedBoundsError when calling a subdissector
on the first fragment of a fragmented message.  This allows us to continue
dissecting chunks even if one of the first chunks in the frame was fragmented.
(It's useful to keep doing this partial dissection just so we have some idea
what's in that chunk.)

(One could rightfully argue that you should only see a fragmented chunk
bundled with another chunk when retransmitting but, well, I'm staring at
traces of an implementation--to remain nameless to protect the guilty--which
is sometimes fragmenting and then bundling the fragments into one packet.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23471 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd changes up to r23464.
gerald [Fri, 16 Nov 2007 20:00:00 +0000 (20:00 +0000)]
Add changes up to r23464.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23470 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen reassembly is turned off don't pass non-first fragments to subdissectors: they...
morriss [Fri, 16 Nov 2007 19:32:59 +0000 (19:32 +0000)]
When reassembly is turned off don't pass non-first fragments to subdissectors: they will have no idea what they're getting and will exception out anyway.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23469 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd {} to some IF statements.
etxrab [Fri, 16 Nov 2007 09:00:14 +0000 (09:00 +0000)]
Add {} to some IF statements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23468 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Martin Gignac:
etxrab [Fri, 16 Nov 2007 08:22:50 +0000 (08:22 +0000)]
From Martin Gignac:
Add comments and comment out an obsolete AVP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23467 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Harmeet Sawhney:
etxrab [Fri, 16 Nov 2007 08:18:30 +0000 (08:18 +0000)]
From Harmeet Sawhney:
Parse MGCP over TCP with ASCII TPKT header
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1964

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23466 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yaniv Kaul :
bondolo [Thu, 15 Nov 2007 23:59:54 +0000 (23:59 +0000)]
From Yaniv Kaul :

Adds application/rss+xml mime type as a recognized XML type. It is used by some RSS servers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23465 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded correct svn propset settings to wiretap/netscreen.[ch]
sake [Thu, 15 Nov 2007 19:46:25 +0000 (19:46 +0000)]
Added correct svn propset settings to wiretap/netscreen.[ch]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23464 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't try to reassemble a huge number of fragments.
gerald [Thu, 15 Nov 2007 19:38:04 +0000 (19:38 +0000)]
Don't try to reassemble a huge number of fragments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23463 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a generated lapd.direction field/filter.
martinm [Thu, 15 Nov 2007 18:37:50 +0000 (18:37 +0000)]
Add a generated lapd.direction field/filter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23462 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew t125 dissector
sahlberg [Thu, 15 Nov 2007 10:39:16 +0000 (10:39 +0000)]
new t125 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23461 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoonly dissect it as t125 if it looks like t125
sahlberg [Thu, 15 Nov 2007 10:38:43 +0000 (10:38 +0000)]
only dissect it as t125 if it looks like t125

dissect_ber_choice() returns the index of the choice taken   not the
tag value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23460 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew ldap dissector
sahlberg [Thu, 15 Nov 2007 10:32:45 +0000 (10:32 +0000)]
new ldap dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23459 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodissect_ber_choice() returns the index of the taken arm not the tag
sahlberg [Thu, 15 Nov 2007 10:32:10 +0000 (10:32 +0000)]
dissect_ber_choice() returns the index of the taken arm   not the tag
value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23458 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew x411 dissector
sahlberg [Thu, 15 Nov 2007 10:11:09 +0000 (10:11 +0000)]
new x411 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23457 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodissect_ber_choice returns a gint that is the index of the choice taken,
sahlberg [Thu, 15 Nov 2007 10:10:22 +0000 (10:10 +0000)]
dissect_ber_choice returns a gint that is the index of the choice taken,
not the tag value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23456 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdated snmp dissector
sahlberg [Thu, 15 Nov 2007 09:50:36 +0000 (09:50 +0000)]
updated snmp dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23455 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodissect_ber_choice() returns the index of the choice, not the tag of the
sahlberg [Thu, 15 Nov 2007 09:49:55 +0000 (09:49 +0000)]
dissect_ber_choice() returns the index of the choice, not the tag of the
choice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23454 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdated mms dissector
sahlberg [Thu, 15 Nov 2007 09:42:21 +0000 (09:42 +0000)]
updated mms dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23453 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobranch_taken that is returned by dissect_ber_choice() is the index of
sahlberg [Thu, 15 Nov 2007 09:41:32 +0000 (09:41 +0000)]
branch_taken that is returned by dissect_ber_choice() is the index of
of the branch and not the tag value   so one cant use it with
val_to_str()
(well one can in this instance since by luck the tag values match the
indices)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23452 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix "Diameter Dictionary: No Vendor: 3GPPDiameter Dictionary: No Vendor: 3GPP".
etxrab [Thu, 15 Nov 2007 06:03:53 +0000 (06:03 +0000)]
Fix "Diameter Dictionary: No Vendor: 3GPPDiameter Dictionary: No Vendor: 3GPP".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23451 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChanged to use the the packet-ber EXTERNAL decoding (into the ASN1 context).
gal [Wed, 14 Nov 2007 20:57:55 +0000 (20:57 +0000)]
Changed to use the the packet-ber EXTERNAL decoding (into the ASN1 context).
Uses the ber_callback mechanism to call the rtse oid callbacks, rather than the default ber oid callback list.
A couple of fixes to packet-ber.c to mark [in]direct references as present and call the ber_callback if it has been specified.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23450 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoKeep the MEGACO dissector from looping on a malformed events descriptor.
gerald [Wed, 14 Nov 2007 19:28:29 +0000 (19:28 +0000)]
Keep the MEGACO dissector from looping on a malformed events descriptor.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23449 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Valery Sigalov via bug #1853: Fix the following console error when
sfisher [Wed, 14 Nov 2007 17:39:21 +0000 (17:39 +0000)]
From Valery Sigalov via bug #1853: Fix the following console error when
starting Wireshark:

Duplicate field detected in call to proto_register_field_array: channel_id is
already registered

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23448 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded some parentheses to clarify the gint64 cast.
stig [Wed, 14 Nov 2007 10:15:20 +0000 (10:15 +0000)]
Added some parentheses to clarify the gint64 cast.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23447 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Shiang-Ming Huang:
stig [Wed, 14 Nov 2007 09:37:44 +0000 (09:37 +0000)]
From Shiang-Ming Huang:
Removed unnecessary parentheses that make the average packets size
calculated as an integer instead of a float.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23446 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom didier:
sfisher [Wed, 14 Nov 2007 06:39:58 +0000 (06:39 +0000)]
From didier:

Fix for bug #1876: Resizing columns changes the currently-selected packet

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23445 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Dejan Bucar:
etxrab [Tue, 13 Nov 2007 22:05:43 +0000 (22:05 +0000)]
From Dejan Bucar:
Updated dissector for LINX protocols

* Linx Ethernet Connection Manager protocol is updated from version 2 to
version 3.
* Linx RLNH protocol has been updated from version 1 to version 2.

The updated dissector is backwards-compatible allowing correct dissection of
all versions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23444 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCorrect assorted typos and copy-past errors.
etxrab [Tue, 13 Nov 2007 22:00:46 +0000 (22:00 +0000)]
Correct assorted typos and copy-past errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23443 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Florent DROUIN:
etxrab [Tue, 13 Nov 2007 21:59:53 +0000 (21:59 +0000)]
From Florent DROUIN:
Since the use of the function 'dissect_ber_tagged_type' for DialoguePortion,
the file tcap.cnf must be updated to remove the decoding of the tag and length.
This decoding is now done in the new function 'dissect_ber_tagged_type'.

The file tcap.cnf has been updated to take into account this change.
But this leads to a change in tcap.asn too, for the definition of the
ExternalPDU.
I think this part of the ASN1 file is specific to Wireshark and can be
modified.

In the meantime, I did update the DEBUG part for packet_ber.c  for the function
(dissect_ber_tagged_type)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23442 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMark some generated items in ROS.
stig [Tue, 13 Nov 2007 10:26:30 +0000 (10:26 +0000)]
Mark some generated items in ROS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23441 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse glib-2.14.3
etxrab [Tue, 13 Nov 2007 06:11:24 +0000 (06:11 +0000)]
Use glib-2.14.3

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23440 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd AVP info.
etxrab [Mon, 12 Nov 2007 21:14:53 +0000 (21:14 +0000)]
Add AVP info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23439 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't dereference a NULL pointer.
gerald [Mon, 12 Nov 2007 20:02:24 +0000 (20:02 +0000)]
Don't dereference a NULL pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23438 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrint the pass number periodically as a convenience for running the script
gerald [Mon, 12 Nov 2007 19:47:15 +0000 (19:47 +0000)]
Print the pass number periodically as a convenience for running the script
on a large number of trace files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23437 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInitialize var_list in dissect_smux(), so that we don't use previously
gerald [Mon, 12 Nov 2007 18:44:29 +0000 (18:44 +0000)]
Initialize var_list in dissect_smux(), so that we don't use previously
ep_freed() memory and abort.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23436 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoReplace strcpy()+strcat() with g_snprintf(). Make sure a string isn't
gerald [Mon, 12 Nov 2007 17:02:46 +0000 (17:02 +0000)]
Replace strcpy()+strcat() with g_snprintf().  Make sure a string isn't
NULL before we try to use it.  This fixes a crash found during fuzzing
and a possible buffer overrun.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23435 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd various files of PortableApps packaging
ulfl [Mon, 12 Nov 2007 07:35:21 +0000 (07:35 +0000)]
add various files of PortableApps packaging

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23434 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdate various other places, where WinPcap version 4.0.1 was used
ulfl [Mon, 12 Nov 2007 07:34:32 +0000 (07:34 +0000)]
update various other places, where WinPcap version 4.0.1 was used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23433 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd various files of PortableApps packaging
ulfl [Mon, 12 Nov 2007 07:33:30 +0000 (07:33 +0000)]
add various files of PortableApps packaging

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23432 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdate various other places, where WinPcap version 4.0.1 was used
ulfl [Mon, 12 Nov 2007 07:31:38 +0000 (07:31 +0000)]
update various other places, where WinPcap version 4.0.1 was used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23431 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove forgotten debug code.
etxrab [Mon, 12 Nov 2007 07:03:09 +0000 (07:03 +0000)]
Remove forgotten debug code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23430 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdate WinPcap installer to recent 4.0.2
ulfl [Sun, 11 Nov 2007 20:36:41 +0000 (20:36 +0000)]
update WinPcap installer to recent 4.0.2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23429 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Valery Sigalov:
etxrab [Sun, 11 Nov 2007 13:23:17 +0000 (13:23 +0000)]
From Valery Sigalov:
New dissector for TPNCP protocol.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1853

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23428 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOpen the coloring rule edit dialog when the coloring rule is
sake [Sun, 11 Nov 2007 00:59:19 +0000 (00:59 +0000)]
Open the coloring rule edit dialog when the coloring rule is
double-clicked.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23427 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake the enable/disable buttons on the coloring rule list follow
sake [Sat, 10 Nov 2007 23:05:35 +0000 (23:05 +0000)]
Make the enable/disable buttons on the coloring rule list follow
the selection. There is a little difference between the behaviour
in GTK1 and GTK2 (As long as either one row or a block of rows with
the same status is selected, GTK1 and GTK2 behave the same way):

GTK1:
- if the last selected row is disabled, grey out the disable button
- if the last selected row is enabled, grey out the enable button

GTK2:
- grey out both buttons when no rule is selected
- grey out the enable button when *all* selected rules are enabled
- grey out the disable button when *all* selected rules are disabled
- leave both buttons active if there is a mix of disabled and enabled
  rules

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23426 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoEnsure we pop any previous loaded filename from the statusbar
stig [Sat, 10 Nov 2007 21:59:20 +0000 (21:59 +0000)]
Ensure we pop any previous loaded filename from the statusbar
when loading a new file with a file already loaded.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23425 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Sat, 10 Nov 2007 17:06:49 +0000 (17:06 +0000)]
Apply yet another set of the optimization patches:
move TRY block in its own function.
 __attribute__((noinline)) does not compile with MS VC 6
nor does __declspec(noinline)
Applied the patch without it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23424 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Sat, 10 Nov 2007 16:09:10 +0000 (16:09 +0000)]
Apply yet another set of the optimization patches:
there's two structures with the same name conversation_t, change one to conv_t

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23423 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Sat, 10 Nov 2007 16:08:14 +0000 (16:08 +0000)]
Apply yet another set of the optimization patches:
Use O(1) logic for the fast path when adding fragments (ie fragments are in order).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23422 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThis patch makes it possible to disable individual coloring rules
sake [Sat, 10 Nov 2007 15:18:49 +0000 (15:18 +0000)]
This patch makes it possible to disable individual coloring rules
without having to delete them. The patch has been tested on
Fedora-7 with GTK+ 1.2.10 and GTK+ 2.10.11.

Since I don't know how to use "strikethrough" in clists in GTK1
there is a little difference in how the disabled coloring rules
are displayed. In GTK2 they are striked through and in GTK1
they are shown in lightgrey on a white background.

Any info on how to use strikthrough in clists within GTK1 is more
than welcome :-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23421 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoQuote a "Checking for" message.
guy [Sat, 10 Nov 2007 02:39:19 +0000 (02:39 +0000)]
Quote a "Checking for" message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23420 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate comment, clean up message.
guy [Sat, 10 Nov 2007 02:18:18 +0000 (02:18 +0000)]
Update comment, clean up message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23419 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd MacOS X version next to the Darwin version in version outputs.
sfisher [Sat, 10 Nov 2007 00:57:41 +0000 (00:57 +0000)]
Add MacOS X version next to the Darwin version in version outputs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23418 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCast "char"s to "unsigned char" before handing them to <ctype.h> macros.
guy [Sat, 10 Nov 2007 00:36:01 +0000 (00:36 +0000)]
Cast "char"s to "unsigned char" before handing them to <ctype.h> macros.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23417 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a newline.
gerald [Fri, 9 Nov 2007 20:05:44 +0000 (20:05 +0000)]
Add a newline.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23416 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't call tvb_set_child_real_data_tvbuff() + add_new_data_source() twice
gerald [Fri, 9 Nov 2007 20:04:40 +0000 (20:04 +0000)]
Don't call tvb_set_child_real_data_tvbuff() + add_new_data_source() twice
for the same tvb.  This keeps us from freeing the same memory twice and
crashing on some systems.

This might be the same bug Brian Vandenberg was looking for in
http://www.wireshark.org/lists/wireshark-dev/200705/msg00406.html .

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23415 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Stephen Croll.
martinm [Fri, 9 Nov 2007 14:41:04 +0000 (14:41 +0000)]
From Stephen Croll.

Dynamically register filter fields from TLV definitions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23414 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Fri, 9 Nov 2007 06:07:30 +0000 (06:07 +0000)]
Apply yet another set of the optimization patches:
move the case where pinfo->in_error_pkt is true in its own function:
- it's not the common case.
- it needs a TRY block. ==> slow volatile and big stack footprint.
- call_dissector_work is called a lot and recursively.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23413 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Fri, 9 Nov 2007 06:01:18 +0000 (06:01 +0000)]
Apply yet another set of the optimization patches:
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length().

On the other hand
if (tvb_bytes_exist(tvb, 0, 20)
is more readable than
if (tvb_length(tvb) >= 20

so only do it in heuristic function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23412 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Fri, 9 Nov 2007 05:57:45 +0000 (05:57 +0000)]
Apply yet another set of the optimization patches:
janitor work, replace col_add_fstr/ col_set_fstr.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23411 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Fri, 9 Nov 2007 05:56:42 +0000 (05:56 +0000)]
Apply yet another set of the optimization patches:
Only call get_hostname once.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23410 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Fri, 9 Nov 2007 05:55:33 +0000 (05:55 +0000)]
Apply yet another set of the optimization patches:
Don't use g_snprintf for temporary unsigned int to ascii conversion.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23409 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Fri, 9 Nov 2007 05:54:16 +0000 (05:54 +0000)]
Apply yet another set of the optimization patches:
small memory leak when freeing compiled filter insns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23408 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBack out part of revision 23395 - leave the toolbar arrow, but remove the
sfisher [Fri, 9 Nov 2007 02:08:00 +0000 (02:08 +0000)]
Back out part of revision 23395 - leave the toolbar arrow, but remove the
preference to turn it on / off per discussion on -dev list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23407 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Thu, 8 Nov 2007 22:49:03 +0000 (22:49 +0000)]
Apply yet another set of the optimization patches:
-set_str2add_str_val_to_str

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23406 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Thu, 8 Nov 2007 22:40:20 +0000 (22:40 +0000)]
Apply yet another set of the optimization patches:
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length().
non heuristic dissectors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23405 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Thu, 8 Nov 2007 22:39:01 +0000 (22:39 +0000)]
Apply yet another set of the optimization patches:
if tree is not NULL then proto_xxx_add_yyy functions can't return NULL.
Remove always true tests.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23404 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Thu, 8 Nov 2007 22:38:06 +0000 (22:38 +0000)]
Apply yet another set of the optimization patches:
- Move proto_tree_add_xxxx calls inside 'if (tree) {}' block

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23403 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChange dissecton of address type for AVP < 256 (RADIUS address).
etxrab [Thu, 8 Nov 2007 22:36:19 +0000 (22:36 +0000)]
Change dissecton of address type for AVP < 256 (RADIUS address).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23402 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't cast pinfo->src.data to (const mtp3_addr_pc_t *) unless we *know* it's
morriss [Thu, 8 Nov 2007 19:13:51 +0000 (19:13 +0000)]
Don't cast pinfo->src.data to (const mtp3_addr_pc_t *) unless we *know* it's
an MTP3 PC in there (else we get a bus error on SPARC systems).
If we don't have MTP3 PC addresses hash on address_to_str(&pinfo->src).  This
makes TCAP statistics work over SUA.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23401 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- "Location-Information" is grouped.
etxrab [Thu, 8 Nov 2007 17:24:17 +0000 (17:24 +0000)]
- "Location-Information" is grouped.
- Add TS 183 033 V1.2.0 (2007-10) AVP:s

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23400 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMove SKIP_CAPTURE from suite-capture.sh to config.sh so that we can use it
gerald [Thu, 8 Nov 2007 16:59:30 +0000 (16:59 +0000)]
Move SKIP_CAPTURE from suite-capture.sh to config.sh so that we can use it
in suite-clopts as well.  Allow it to be set externally.  This should fix
the "test" failure in the Solairs builder.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23399 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a couple of integer underflows.
gerald [Thu, 8 Nov 2007 05:54:29 +0000 (05:54 +0000)]
Fix a couple of integer underflows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23398 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix Windows builds that cannot find gtk/gtk.h from epan/prefs.c. Write out
sfisher [Thu, 8 Nov 2007 02:29:18 +0000 (02:29 +0000)]
Fix Windows builds that cannot find gtk/gtk.h from epan/prefs.c.  Write out
toolbar arrow preference even in GTK < 2.4 and just don't use it unless
running GTK 2.4+.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23397 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd more TCP analysis struct checks.
gerald [Thu, 8 Nov 2007 00:58:38 +0000 (00:58 +0000)]
Add more TCP analysis struct checks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23396 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd an arrow with drop-down menu including any toolbar buttons that do not
sfisher [Wed, 7 Nov 2007 21:50:48 +0000 (21:50 +0000)]
Add an arrow with drop-down menu including any toolbar buttons that do not
fit on the top of the screen.  This only works in GTK 2.4+ and there is
a layout preference setting to disable it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23395 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T asn2wrs flags.
etxrab [Wed, 7 Nov 2007 21:22:25 +0000 (21:22 +0000)]
Update to use the -X and -T asn2wrs flags.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23394 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBack out r23308 for the time being, since it's making hhc.exe on the Windows
gerald [Wed, 7 Nov 2007 20:13:40 +0000 (20:13 +0000)]
Back out r23308 for the time being, since it's making hhc.exe on the Windows
builder crash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23393 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCreate a subset tvb for dissect_x411_ORName so it doesn't eat too much data.
stig [Wed, 7 Nov 2007 20:03:29 +0000 (20:03 +0000)]
Create a subset tvb for dissect_x411_ORName so it doesn't eat too much data.
Removed some unnecessary int casts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23392 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd VID VID_draft_ietf_ipsec_nat_t_ike_01, move
jmayer [Wed, 7 Nov 2007 18:35:00 +0000 (18:35 +0000)]
Add VID VID_draft_ietf_ipsec_nat_t_ike_01, move
VID_draft_ietf_ipsec_nat_t_ike_03 a bit down.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23391 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T asn2wrs flags.
etxrab [Wed, 7 Nov 2007 17:55:57 +0000 (17:55 +0000)]
Update to use the -X and -T asn2wrs flags.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23390 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDelete obsolete dissectors.
etxrab [Wed, 7 Nov 2007 17:55:06 +0000 (17:55 +0000)]
Delete obsolete dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23389 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrint VendorID string in payload summary line
jmayer [Wed, 7 Nov 2007 17:23:28 +0000 (17:23 +0000)]
Print VendorID string in payload summary line

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23388 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd two sentences clarifying the license statement on pidl:
jmayer [Tue, 6 Nov 2007 22:01:20 +0000 (22:01 +0000)]
Add two sentences clarifying the license statement on pidl:

As a notable exception the pidl utility at tools/pidl is covered by a
"GPL version 3 or later" LICENSE. Note that only the tool itself
is covered by this license, not the source code generated by it. The
pidl authors do not consider that code a derived work of pidl.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23387 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoas2wrs now handles EXTERNAL(direct-reference requires no special handling).
etxrab [Tue, 6 Nov 2007 21:52:26 +0000 (21:52 +0000)]
as2wrs now handles EXTERNAL(direct-reference requires no special handling).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23386 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen checking to see if we should install WinPcap, check the installed
gerald [Tue, 6 Nov 2007 20:32:30 +0000 (20:32 +0000)]
When checking to see if we should install WinPcap, check the installed
version directly instead of trying to divine it from its name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23385 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoas2wrs now handles EXTERNAL(direct-reference requires no special handling).
etxrab [Tue, 6 Nov 2007 20:26:13 +0000 (20:26 +0000)]
as2wrs now handles EXTERNAL(direct-reference requires no special handling).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23384 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoas2wrs now handles EXTERNAL(direct-reference requires no special handling).
etxrab [Tue, 6 Nov 2007 20:21:09 +0000 (20:21 +0000)]
as2wrs now handles EXTERNAL(direct-reference requires no special handling).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23383 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoas2wrs now handles EXTERNAL(direct-reference requires no special handling).
etxrab [Tue, 6 Nov 2007 20:16:59 +0000 (20:16 +0000)]
as2wrs now handles EXTERNAL(direct-reference requires no special handling).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23382 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a remark that the code under tools/pidl/ is covered
jmayer [Tue, 6 Nov 2007 20:03:22 +0000 (20:03 +0000)]
Add a remark that the code under tools/pidl/ is covered
by GPLv3 (inside the files it only says GPL).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23381 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Keith Mercer:
etxrab [Tue, 6 Nov 2007 19:47:38 +0000 (19:47 +0000)]
From Keith Mercer:
CFM dissector bugfixes and code update for ITU inclusion

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23380 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Florent Drouin:
etxrab [Tue, 6 Nov 2007 19:22:51 +0000 (19:22 +0000)]
From Florent Drouin:
Fix bug Some Toshiba format files with LAPD cannot be open
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1711

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23379 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate from samba tree revision 25306 to 25880
jmayer [Tue, 6 Nov 2007 18:31:26 +0000 (18:31 +0000)]
Update from samba tree revision 25306 to 25880
============================ Samba log start ============
------------------------------------------------------------------------
r25453 | jelmer | 2007-10-01 23:38:15 +0200 (Mon, 01 Oct 2007) | 1 line

Fix include for NTSTATUS.
------------------------------------------------------------------------
r25457 | jelmer | 2007-10-02 06:45:25 +0200 (Tue, 02 Oct 2007) | 1 line

use different location for out-of-tree builds
------------------------------------------------------------------------
r25674 | metze | 2007-10-17 10:26:55 +0200 (Wed, 17 Oct 2007) | 13 lines

fix crash bug in pidl generated client code, this
could have happend with [in,out,unique] pointers
when the clients sends a valid pointer, but the server
reponse with a NULL pointer (as samba-3.0.26a do for some calls).

I've tested with midl to see how windows handles this situation
and also the reverse case where the client sends NULL and
the server reposnse with non-NULL.

It appears that midl generated code just ignores this
and only copies the result if both pointers are non-NULL.

metze
------------------------------------------------------------------------
r25700 | jra | 2007-10-19 02:40:51 +0200 (Fri, 19 Oct 2007) | 3 lines

Now BOOL no longer exists in Samba 3.2, use bool instead.
Jeremy.

------------------------------------------------------------------------
r25745 | metze | 2007-10-27 11:57:09 +0200 (Sat, 27 Oct 2007) | 6 lines

[pidl] ndr_pull/push_error(ndr, NDR_ERR_INVALID_POINTER,..)

instead NT_STATUS_INVALID_PARAMETER_MIX

metze

------------------------------------------------------------------------
r25751 | metze | 2007-10-30 07:24:43 +0100 (Tue, 30 Oct 2007) | 4 lines

use EJS_CHECK() instead of NDR_CHECK() in ejs code

metze

------------------------------------------------------------------------
r25765 | metze | 2007-10-31 17:25:44 +0100 (Wed, 31 Oct 2007) | 3 lines

pidl: fix compiler warning in ndr_align test

metze
------------------------------------------------------------------------
r25766 | metze | 2007-10-31 17:27:21 +0100 (Wed, 31 Oct 2007) | 3 lines

pidl: fix bugs in ndr_tagtype tests found by compiler warnings

metze
------------------------------------------------------------------------
r25767 | metze | 2007-10-31 17:29:32 +0100 (Wed, 31 Oct 2007) | 5 lines

pidl: make it easier to debug errors in pidl tests

we now print the C program that we tried to compile

metze
------------------------------------------------------------------------
r25768 | metze | 2007-10-31 17:44:42 +0100 (Wed, 31 Oct 2007) | 5 lines

pidl: NT_STATUS_IS_ERR() is NOT the same as !NT_STATUS_IS_OK()

Everything but success should be handled as error in the tests.

metze
------------------------------------------------------------------------
r25795 | metze | 2007-11-02 11:35:09 +0100 (Fri, 02 Nov 2007) | 3 lines

whitespace cleanup...

metze
------------------------------------------------------------------------
r25804 | metze | 2007-11-02 14:02:25 +0100 (Fri, 02 Nov 2007) | 4 lines

move including ndr_compression.h into HeaderInterface()

metze

------------------------------------------------------------------------
r25805 | metze | 2007-11-02 14:05:43 +0100 (Fri, 02 Nov 2007) | 4 lines

pidl: include libndr.h as first header in ndr_foo.h

metze

------------------------------------------------------------------------
r25806 | metze | 2007-11-02 14:48:11 +0100 (Fri, 02 Nov 2007) | 5 lines

let libndr.h include needed stuff and remove pidl magic
for choosing common required headers

metze

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23378 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSet up RTP conversation when PORT is known.
etxrab [Tue, 6 Nov 2007 18:11:20 +0000 (18:11 +0000)]
Set up RTP conversation when PORT is known.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23377 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix some typos.
etxrab [Tue, 6 Nov 2007 18:10:34 +0000 (18:10 +0000)]
Fix some typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23376 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix bug 1956 - make the bitwise-AND routine treat its arguments as being
guy [Tue, 6 Nov 2007 09:19:59 +0000 (09:19 +0000)]
Fix bug 1956 - make the bitwise-AND routine treat its arguments as being
IPv4 addresses.  Also, rename that routine to cmp_bitwise_and(), as it's
not working on bit strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23375 f5534014-38df-0310-8fa8-9805f1628bb7