obnox/wireshark/wip.git
8 years agoUpdate the User Interface chapter of the User's Guide.
jake [Fri, 21 Jan 2011 23:37:46 +0000 (23:37 +0000)]
Update the User Interface chapter of the User's Guide.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35614 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRe-arrange help menu a bit to group website and wiki links.
jake [Fri, 21 Jan 2011 23:24:08 +0000 (23:24 +0000)]
Re-arrange help menu a bit to group website and wiki links.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35613 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoStart update for 1.5 version of User's Guide.
jake [Fri, 21 Jan 2011 20:57:24 +0000 (20:57 +0000)]
Start update for 1.5 version of User's Guide.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35612 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5604 :
morriss [Fri, 21 Jan 2011 17:12:02 +0000 (17:12 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5604 :

A small patch to add color rules for ICMPv6 Error (some error as ICMP(v4)..)

With this patch, Wireshark is ready for IPv6 Day ;)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35611 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5603 :
morriss [Fri, 21 Jan 2011 17:08:35 +0000 (17:08 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5603 :

Following the discussion on the dev mailing list about ett_ value in subtree
http://www.wireshark.org/lists/wireshark-dev/201101/msg00039.html

a small to update the Readme Developer Guide !

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35610 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago- Wrong element type used.
etxrab [Fri, 21 Jan 2011 14:03:42 +0000 (14:03 +0000)]
- Wrong element type used.
- Use match_strval_idx_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35609 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse EXTRANEOUS_DATA_CHECK_EXPERT
etxrab [Fri, 21 Jan 2011 09:31:25 +0000 (09:31 +0000)]
Use EXTRANEOUS_DATA_CHECK_EXPERT

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35608 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMove sgsap_elem_idx_t to packet-gsm_a_common.h
etxrab [Fri, 21 Jan 2011 09:26:29 +0000 (09:26 +0000)]
Move sgsap_elem_idx_t to packet-gsm_a_common.h
Dissect Global-CN-Id

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35607 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCN-Id is two bytes.
etxrab [Fri, 21 Jan 2011 09:24:43 +0000 (09:24 +0000)]
CN-Id is two bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35606 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Tobias Klauser:
etxrab [Fri, 21 Jan 2011 06:30:55 +0000 (06:30 +0000)]
From Tobias Klauser:
Fix standard to IEC62439 Part 3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5599

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35605 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix typos
etxrab [Fri, 21 Jan 2011 06:27:08 +0000 (06:27 +0000)]
Fix typos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35604 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoThere's no need to pass the result of tvb_get_ptr() as the 'value' in
morriss [Fri, 21 Jan 2011 03:00:31 +0000 (03:00 +0000)]
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35603 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoIntroduce, and start using, tvb_eth_to_str().
morriss [Fri, 21 Jan 2011 02:48:55 +0000 (02:48 +0000)]
Introduce, and start using, tvb_eth_to_str().

Export tvb_*_to_str() and put them in alphabetical order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35602 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse tvb_ip_to_str()
morriss [Fri, 21 Jan 2011 02:25:30 +0000 (02:25 +0000)]
Use tvb_ip_to_str()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35601 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdress => Address corrections (also in comments).
sake [Fri, 21 Jan 2011 00:19:03 +0000 (00:19 +0000)]
Adress => Address corrections (also in comments).

(see bug 5600)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35600 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAllow presentation of Gauge32 values larger than 0x7FFFFFFF.
jake [Thu, 20 Jan 2011 20:04:39 +0000 (20:04 +0000)]
Allow presentation of Gauge32 values larger than 0x7FFFFFFF.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35599 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix the dead initialization warnings found by clang's static analysis
sfisher [Thu, 20 Jan 2011 18:56:11 +0000 (18:56 +0000)]
Fix the dead initialization warnings found by clang's static analysis
("Value stored to 'xxx' during its initialization is never read")

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35598 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix typos
etxrab [Thu, 20 Jan 2011 14:03:13 +0000 (14:03 +0000)]
Fix typos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35597 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUpdate a comment.
etxrab [Thu, 20 Jan 2011 13:19:26 +0000 (13:19 +0000)]
Update a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35596 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoIn MM context the container contains IE:s not a complete
etxrab [Thu, 20 Jan 2011 13:05:17 +0000 (13:05 +0000)]
In MM context the container contains IE:s not a complete
DTAP message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5598

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35595 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAllow for expert items to be actually attached somewhere.
jake [Thu, 20 Jan 2011 08:58:03 +0000 (08:58 +0000)]
Allow for expert items to be actually attached somewhere.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35594 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRoll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (instead
morriss [Thu, 20 Jan 2011 03:49:44 +0000 (03:49 +0000)]
Roll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (instead
of going through a temporary variable).  This just makes it more obvious which
add_bytes_format() calls are or are not being given pointers into the TVB.

Use tvb_ip_to_str() and tvb_ip6_to_str() in a couple spots.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35593 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd a note to the top about r35589's change of the ADDCARRY(x) macro.
sfisher [Wed, 19 Jan 2011 22:57:19 +0000 (22:57 +0000)]
Add a note to the top about r35589's change of the ADDCARRY(x) macro.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35592 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't stop calling subdissectors when there's no tree.
jake [Wed, 19 Jan 2011 22:55:53 +0000 (22:55 +0000)]
Don't stop calling subdissectors when there's no tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35591 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse Wireshark standard marking for unused parameters.
jake [Wed, 19 Jan 2011 22:53:46 +0000 (22:53 +0000)]
Use Wireshark standard marking for unused parameters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35590 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoChange the ADDCARRY(x) macro to eliminate clang warning about unused
sfisher [Wed, 19 Jan 2011 22:53:38 +0000 (22:53 +0000)]
Change the ADDCARRY(x) macro to eliminate clang warning about unused
result from the ADDCARRY portion of the REDUCE macro.

-#define ADDCARRY(x)  (x > 65535 ? x -= 65535 : x)
+#define ADDCARRY(x)  {if ((x) > 65535) (x) -= 65535;}

The new code is from in_cksum.c in the Tahoe/CGI port of 4.4BSD-Lite2 (we're
using the "Portable Version" copy otherwise).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35589 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoSimply this:
sfisher [Wed, 19 Jan 2011 21:51:30 +0000 (21:51 +0000)]
Simply this:

    #define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN ((gint)strlen (SIP2_HDR))

To this:

    #define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN 7

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35588 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix warning found by clang...
sfisher [Wed, 19 Jan 2011 21:45:54 +0000 (21:45 +0000)]
Fix warning found by clang...

packet-dcerpc.c:4056:19: error: comparison of integers of different signs:
      'guint32' (aka 'unsigned int') and 'int' [-Wsign-compare]
    for (i = 0; i < (int) commands_nb; ++i) {
                ~ ^ ~~~~~~~~~~~~~~~~~

... by removing the "(int)" cast

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35587 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte:
jake [Wed, 19 Jan 2011 20:57:39 +0000 (20:57 +0000)]
From Alexis La Goutte:
A patch to enhance the ICMPv6 dissector
- Make ICMP Type (sub)field filterable
- Add Inverse Neighbor Discovery (RFC 3122)
- Remove dependency to packet-ipv6.h
- Cleanup packet-ipv6.h
- Update RFC Draft to draft-ietf-roll-rpl-17 (with make a sub dissector
  for RPL Control and add Secure RPL...)
- Replace tvb_get_ipv6/ip6_to_str by new function tvb_ip6_to_str
- and other enchancements.....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35586 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCast the returned value from strlen() to an int to make the Windows 64-bit
sfisher [Wed, 19 Jan 2011 19:42:00 +0000 (19:42 +0000)]
Cast the returned value from strlen() to an int to make the Windows 64-bit
buildbot happy.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35585 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Cal Turney via enhancement bug #5587: In hex or string searches of the
sfisher [Wed, 19 Jan 2011 18:21:21 +0000 (18:21 +0000)]
From Cal Turney via enhancement bug #5587: In hex or string searches of the
packet data highlight the target rather than the entire field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35584 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Cal Turney via bug #5585: When searching in packet bytes, the field and
sfisher [Wed, 19 Jan 2011 17:58:53 +0000 (17:58 +0000)]
From Cal Turney via bug #5585: When searching in packet bytes, the field and
bytes are not immediately shown.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35583 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix the broken Edit Menu when UImanager is used.
etxrab [Wed, 19 Jan 2011 14:55:15 +0000 (14:55 +0000)]
Fix the broken Edit Menu when UImanager is used.
(UnmarkAllDisplayedPackets)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35582 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agopacket-bssgp.c:6916: warning: 'bssgp_tree' may be used uninitialized in this function
etxrab [Wed, 19 Jan 2011 09:49:36 +0000 (09:49 +0000)]
packet-bssgp.c:6916: warning: 'bssgp_tree' may be used uninitialized in this function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35581 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCleaned up splitt between old and new dissection style.
etxrab [Wed, 19 Jan 2011 09:35:34 +0000 (09:35 +0000)]
Cleaned up splitt between old and new dissection style.
A lot of conversion still needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35580 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd the RAI value to "add_string"
etxrab [Wed, 19 Jan 2011 06:43:28 +0000 (06:43 +0000)]
Add the RAI value to "add_string"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35579 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoTry to enhance output at ValueError to ease debugging.
etxrab [Wed, 19 Jan 2011 06:33:33 +0000 (06:33 +0000)]
Try to enhance output at ValueError to ease debugging.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35578 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUpdated to OMA-TS-ULP-V2_0-20100806-D
etxrab [Wed, 19 Jan 2011 06:27:50 +0000 (06:27 +0000)]
Updated to OMA-TS-ULP-V2_0-20100806-D
with asn1 files from eyimjia.
Files hand edited to pass as2wrs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5593
(Does not fix the bug)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35577 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoIntroduce EXTRANEOUS_DATA_CHECK_EXPERT
etxrab [Tue, 18 Jan 2011 20:16:56 +0000 (20:16 +0000)]
Introduce EXTRANEOUS_DATA_CHECK_EXPERT
which adds an expert item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35576 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agodumpcap failed to link - add glib2 and wsutil libraries to fix this.
jmayer [Tue, 18 Jan 2011 17:49:41 +0000 (17:49 +0000)]
dumpcap failed to link - add glib2 and wsutil libraries to fix this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35575 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd another item.
gerald [Mon, 17 Jan 2011 22:23:35 +0000 (22:23 +0000)]
Add another item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35574 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoHandle two length octets correctly in TELV.
etxrab [Mon, 17 Jan 2011 21:12:30 +0000 (21:12 +0000)]
Handle two length octets correctly in TELV.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35573 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago- append TLLI value.
etxrab [Mon, 17 Jan 2011 21:10:54 +0000 (21:10 +0000)]
- append TLLI value.
- Whitespace changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35572 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago(Until Anders comletes work): use #if 0 instead of //; init a variable;
wmeier [Mon, 17 Jan 2011 16:51:31 +0000 (16:51 +0000)]
(Until Anders comletes work): use #if 0 instead of //; init a variable;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35571 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRemove redundant test for a non-null pointer;
wmeier [Mon, 17 Jan 2011 16:36:52 +0000 (16:36 +0000)]
Remove redundant test for a non-null pointer;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35570 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoActually use proto_tree_add_item() instead of proto_tree_add_ether(). I hope I didn...
morriss [Mon, 17 Jan 2011 15:22:11 +0000 (15:22 +0000)]
Actually use proto_tree_add_item() instead of proto_tree_add_ether().  I hope I didn't miss more of these...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35569 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago- Use correct data pointer during a comparison.
martinm [Mon, 17 Jan 2011 15:01:22 +0000 (15:01 +0000)]
- Use correct data pointer during a comparison.
- Add expert info to show when DRX command is received
- Get rid of some tabs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35568 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRestore dissection of Mobile Identity(revert the code).
etxrab [Mon, 17 Jan 2011 14:18:54 +0000 (14:18 +0000)]
Restore dissection of Mobile Identity(revert the code).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35567 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago- Remove debug printout.
etxrab [Mon, 17 Jan 2011 13:09:08 +0000 (13:09 +0000)]
- Remove debug printout.
- Enhance dissection a bit.
- add new true_false_strings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35566 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDo Windows compile with /WX flag: treat warnings as errors.
wmeier [Sun, 16 Jan 2011 23:47:05 +0000 (23:47 +0000)]
Do Windows compile with /WX flag: treat warnings as errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35565 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCompile text2pcap.c,mergecap.c,capinfos.c,editcap.c, & version_info.c with -WX;
wmeier [Sun, 16 Jan 2011 23:24:15 +0000 (23:24 +0000)]
Compile text2pcap.c,mergecap.c,capinfos.c,editcap.c, & version_info.c with -WX;
(Treat warnings as errors);
Done by simplifing the dependency line for the objects so that the
 default .c.obj inference rule is used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35564 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix a Windows compiler warning;
wmeier [Sun, 16 Jan 2011 23:04:33 +0000 (23:04 +0000)]
Fix a Windows compiler warning;
Minor whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35563 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoActually use proto_tree_add_item instead of proto_tree_add_bytes. Fixes bug 5588.
morriss [Sun, 16 Jan 2011 22:52:17 +0000 (22:52 +0000)]
Actually use proto_tree_add_item instead of proto_tree_add_bytes.  Fixes bug 5588.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35562 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoSwitch to using proto_add_bits_item in a couple of places and fix
etxrab [Sun, 16 Jan 2011 22:32:22 +0000 (22:32 +0000)]
Switch to using proto_add_bits_item in a couple of places and fix
missing stepping of bit_offset.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35561 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix Windows comiler warning: remove unused 'wsadata' variable.
wmeier [Sun, 16 Jan 2011 22:10:03 +0000 (22:10 +0000)]
Fix Windows comiler warning: remove unused 'wsadata' variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35560 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Vaibhav Katkade:
jake [Sun, 16 Jan 2011 21:32:39 +0000 (21:32 +0000)]
From Vaibhav Katkade:
Add support for newly defined LLDP Four-wire Power-via-MDI and
CDP Spare Pair PoE TLVs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35559 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoThere's no need to pass the result of tvb_get_ptr() as the 'value' in
morriss [Sun, 16 Jan 2011 20:51:21 +0000 (20:51 +0000)]
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or
tvb_get_const_stringz().

Use tvb_memeql() & tvb_memcmp().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35558 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse tvb_fc_to_str() and tvb_fcwwm_to_str().
morriss [Sun, 16 Jan 2011 18:37:56 +0000 (18:37 +0000)]
Use tvb_fc_to_str() and tvb_fcwwm_to_str().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35557 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Porus Mehta:
etxrab [Sun, 16 Jan 2011 18:36:17 +0000 (18:36 +0000)]
From Porus Mehta:
Corrections to ANSI MAP ASN.1 specifications.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5584

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35556 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago<shortcut> doesn't appear to be a valid element.
morriss [Sun, 16 Jan 2011 18:36:04 +0000 (18:36 +0000)]
<shortcut> doesn't appear to be a valid element.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35555 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago[Automatic manuf, services and enterprise-numbers update for 2011-01-16]
gerald [Sun, 16 Jan 2011 16:03:51 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-01-16]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35552 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agor35546 Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
etxrab [Sun, 16 Jan 2011 08:24:11 +0000 (08:24 +0000)]
r35546 Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.
Make the change also in the .cnf file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35551 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMove assignment of 'oct' outside of if(tree)--it is used outside of the if block.
morriss [Sun, 16 Jan 2011 04:38:59 +0000 (04:38 +0000)]
Move assignment of 'oct' outside of if(tree)--it is used outside of the if block.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35550 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoIntroduce, and start using, tvb_fc_to_str() and tvb_fcwwm_to_str(): these
morriss [Sun, 16 Jan 2011 04:33:42 +0000 (04:33 +0000)]
Introduce, and start using, tvb_fc_to_str() and tvb_fcwwm_to_str(): these
functions act like their non-tvb counterparts except that they take a tvb and
and offset instead of a pointer to a byte array.

This basically saves the dissectors from having to call tvb_get_ptr()--which in
this case eliminates a couple of typos in the length given to tvb_get_ptr().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35549 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoReplace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
morriss [Sun, 16 Jan 2011 03:57:12 +0000 (03:57 +0000)]
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35548 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse tvb_memeql().
morriss [Sun, 16 Jan 2011 03:46:16 +0000 (03:46 +0000)]
Use tvb_memeql().

Use tvb_ip_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35547 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse tvb_memeql() and tvb_memcpy().
morriss [Sun, 16 Jan 2011 03:35:29 +0000 (03:35 +0000)]
Use tvb_memeql() and tvb_memcpy().

Use tvb_ip_to_str() and tvb_ip6_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35546 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse tvb_ip_to_str().
morriss [Sun, 16 Jan 2011 03:29:03 +0000 (03:29 +0000)]
Use tvb_ip_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35545 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoComitting work in progress to fix the linking problem.
etxrab [Sat, 15 Jan 2011 23:13:28 +0000 (23:13 +0000)]
Comitting work in progress to fix the linking problem.
>Linking fails now:
>epan/.libs/libwireshark.so: undefined reference to `hf_bssgp_elem_id'
>epan/.libs/libwireshark.so: undefined reference to `bssgp_elem_fcn'
>epan/.libs/libwireshark.so: undefined reference to `ett_bssgp_elem'
>epan/.libs/libwireshark.so: undefined reference to >`bssgp_elem_strings'
>Did you miss packet-bssgp.c in that commit?

I'll try to clean this up in the next few days.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35544 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoReplace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
morriss [Sat, 15 Jan 2011 19:01:53 +0000 (19:01 +0000)]
Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35543 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't (blindly) pass the result of match_strval() into proto_tree_add_*():
morriss [Sat, 15 Jan 2011 18:58:42 +0000 (18:58 +0000)]
Don't (blindly) pass the result of match_strval() into proto_tree_add_*():
some OS (like Solaris) don't like NULL pointers to strings in (s)printf
formats; use val_to_str() instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35542 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoReplace some duplicate blurbs with NULL
morriss [Sat, 15 Jan 2011 18:18:13 +0000 (18:18 +0000)]
Replace some duplicate blurbs with NULL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35541 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoReplace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
morriss [Sat, 15 Jan 2011 03:25:43 +0000 (03:25 +0000)]
Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35540 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago- Add TELV to dissct IE's with an extention bit in the length vallue.
etxrab [Fri, 14 Jan 2011 21:43:31 +0000 (21:43 +0000)]
- Add TELV to dissct IE's with an extention bit in the length vallue.
- Add a BSSGP PDU type
- Put IE name in the top tree for ELEM_V

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35539 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd tvb_get_[n|le]toh[40|48|56]() accessors. Addresses bug 5082.
cmaynard [Fri, 14 Jan 2011 19:02:38 +0000 (19:02 +0000)]
Add tvb_get_[n|le]toh[40|48|56]() accessors.  Addresses bug 5082.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35538 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Cal Turney via bug 4964: Round & display 6 decimal places in tshark SRTs.
cmaynard [Fri, 14 Jan 2011 17:06:53 +0000 (17:06 +0000)]
From Cal Turney via bug 4964: Round & display 6 decimal places in tshark SRTs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35537 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRemoved redundant comparison that caused compilation failure on OSX
grahamb [Fri, 14 Jan 2011 14:39:40 +0000 (14:39 +0000)]
Removed redundant comparison that caused compilation failure on OSX

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35536 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoWhen looking for previous frame for UL/DL retx, use harq-id + ndi bit.
martinm [Fri, 14 Jan 2011 14:25:24 +0000 (14:25 +0000)]
When looking for previous frame for UL/DL retx, use harq-id + ndi bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35535 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded ignore for *.pkl build artefacts
grahamb [Fri, 14 Jan 2011 12:16:59 +0000 (12:16 +0000)]
Added ignore for *.pkl build artefacts

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35534 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUpdated dissector:
grahamb [Fri, 14 Jan 2011 12:15:10 +0000 (12:15 +0000)]
Updated dissector:
Additional function codes: Disable unsolicited messages, Open\Close\Delete file
Additional data objects: Analog output events, File objects and Octet string events.
Improved Info column display for reassembled fragments.
Changed all event timestamps to be UTC as per protocol spec.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35533 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMove MAC and RLC stats menu items into a common LTE subtree.
martinm [Fri, 14 Jan 2011 11:32:58 +0000 (11:32 +0000)]
Move MAC and RLC stats menu items into a common LTE subtree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35532 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRather than repairing out-of-range subframe numbers, make sure error gets reported...
martinm [Fri, 14 Jan 2011 11:21:28 +0000 (11:21 +0000)]
Rather than repairing out-of-range subframe numbers, make sure error gets reported (and then are not used to access beyond subframe arrays).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35531 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Hadar Shoham:
jake [Fri, 14 Jan 2011 07:20:31 +0000 (07:20 +0000)]
From Hadar Shoham:
bootp option 123 has 2 chooses - coordinate based location RFC 3825 or
CableLabs DSS_ID. Add better support for having 2 DSS_ID with dynamic
size (up to 32 byte each)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35530 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoReplace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
morriss [Fri, 14 Jan 2011 03:44:58 +0000 (03:44 +0000)]
Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.

Replace some memcpy()+tvb_get_ptr() with tvb_memcpy().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35529 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoVMS → HP OpenVMS.
gerald [Thu, 13 Jan 2011 22:45:27 +0000 (22:45 +0000)]
VMS → HP OpenVMS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35528 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd the TCP scaling graph.
gerald [Thu, 13 Jan 2011 22:43:01 +0000 (22:43 +0000)]
Add the TCP scaling graph.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35527 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't (blindly) pass the result of match_strval() into proto_tree_add_*():
morriss [Thu, 13 Jan 2011 22:18:30 +0000 (22:18 +0000)]
Don't (blindly) pass the result of match_strval() into proto_tree_add_*():
some OS (like Solaris) don't like NULL pointers to strings in (s)printf
formats; use val_to_str() instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35526 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd keyboard shortcuts.
gerald [Thu, 13 Jan 2011 22:08:26 +0000 (22:08 +0000)]
Add keyboard shortcuts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35525 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Clemens Auer:
jake [Thu, 13 Jan 2011 21:22:57 +0000 (21:22 +0000)]
From Clemens Auer:
This patch adds support for the following fields in Meta protocol:
- Deciphered
- Local Device ID,
- Remote Device ID,
- Tap Group ID,
- TLLI,
- Calling Station ID,
- Called Station ID

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35524 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMention another RTP player feature.
jake [Thu, 13 Jan 2011 21:17:24 +0000 (21:17 +0000)]
Mention another RTP player feature.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35523 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd "break;" to end of last case statement.
sfisher [Thu, 13 Jan 2011 17:54:30 +0000 (17:54 +0000)]
Add "break;" to end of last case statement.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35522 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoWrap include file in extern "C" { ... } for __cplusplus
sfisher [Thu, 13 Jan 2011 17:39:54 +0000 (17:39 +0000)]
Wrap include file in extern "C" { ... } for __cplusplus

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35521 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd some of my changes since 1.4 was released
sfisher [Thu, 13 Jan 2011 17:25:22 +0000 (17:25 +0000)]
Add some of my changes since 1.4 was released

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35520 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoIntroduce, and start using, tvb_ip_to_str() and tvb_ip6_to_str(). These
morriss [Thu, 13 Jan 2011 15:53:30 +0000 (15:53 +0000)]
Introduce, and start using, tvb_ip_to_str() and tvb_ip6_to_str().  These
do the same as the non-tvb equivalents but take a TVB and an offset instead
of a pointer to an array of bytes.

Their purpose is to prevent (many) dissectors from doing:
ip_to_str(tvb_get_ptr(...)).

(About the names and the location: I like the names as they are but the names
imply that they should live in tvbuff.c.  That would make some sense but
I didn't want to pull to_str.h into tvbuff.c...)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35519 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoGetting ready for R9 versions of some LTE protocols.
martinm [Thu, 13 Jan 2011 15:16:45 +0000 (15:16 +0000)]
Getting ready for R9 versions of some LTE protocols.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35518 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse value_string_ext.
etxrab [Thu, 13 Jan 2011 15:03:55 +0000 (15:03 +0000)]
Use value_string_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35517 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRemove an unused variable.
etxrab [Thu, 13 Jan 2011 14:36:40 +0000 (14:36 +0000)]
Remove an unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35516 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMake it possible to dissect the part pressent in short frames.
etxrab [Thu, 13 Jan 2011 14:07:34 +0000 (14:07 +0000)]
Make it possible to dissect the part pressent in short frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35515 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a couple of my new features
sake [Thu, 13 Jan 2011 08:35:29 +0000 (08:35 +0000)]
Added a couple of my new features

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35514 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Pascal Quantin:
etxrab [Thu, 13 Jan 2011 06:32:23 +0000 (06:32 +0000)]
From Pascal Quantin:
Fix dissection of  protocol ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35513 f5534014-38df-0310-8fa8-9805f1628bb7