19 years agoFix to TCP reassembly code for retransmitted data, from Edgar Iglesias.
guy [Thu, 24 May 2001 23:07:41 +0000 (23:07 +0000)]
Fix to TCP reassembly code for retransmitted data, from Edgar Iglesias.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3447 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAppletalk Data Stream Interface (used by AFP-over-TCP) support, from
guy [Thu, 24 May 2001 20:25:25 +0000 (20:25 +0000)]
Appletalk Data Stream Interface (used by AFP-over-TCP) support, from
Randy McEoin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3446 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDHCP support for Intel PXEclient DHCP requests, from Joerg Mayer.
guy [Thu, 24 May 2001 19:21:15 +0000 (19:21 +0000)]
DHCP support for Intel PXEclient DHCP requests, from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3445 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMTP3 support, from Michael Tuexen.
guy [Thu, 24 May 2001 08:13:56 +0000 (08:13 +0000)]
MTP3 support, from Michael Tuexen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3444 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf you call AC_MSG_CHECKING, you should always call AC_MSG_RESULT.
guy [Thu, 24 May 2001 04:04:42 +0000 (04:04 +0000)]
If you call AC_MSG_CHECKING, you should always call AC_MSG_RESULT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3443 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdated SSL tests, from Andy Hood.
guy [Wed, 23 May 2001 19:38:07 +0000 (19:38 +0000)]
Updated SSL tests, from Andy Hood.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3442 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf you put an item into the protocol tree with "dissect_rpc_data_tvb()",
guy [Wed, 23 May 2001 19:29:45 +0000 (19:29 +0000)]
If you put an item into the protocol tree with "dissect_rpc_data_tvb()",
it must be FT_BYTES, not FT_STRING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3441 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf you put an item into the protocol tree with "dissect_rpc_data()",
guy [Wed, 23 May 2001 19:13:37 +0000 (19:13 +0000)]
If you put an item into the protocol tree with "dissect_rpc_data()",
it must be FT_BYTES, not FT_STRING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3440 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf you put an item into the protocol tree with "dissect_rpc_data_tvb()",
guy [Wed, 23 May 2001 19:06:55 +0000 (19:06 +0000)]
If you put an item into the protocol tree with "dissect_rpc_data_tvb()",
it must be FT_BYTES, not FT_STRING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3439 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of an extra colon on a field name, and display that field using
guy [Wed, 23 May 2001 18:52:54 +0000 (18:52 +0000)]
Get rid of an extra colon on a field name, and display that field using
that name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3438 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of extra colons, and fix up the display of default metrics, from
guy [Wed, 23 May 2001 18:44:59 +0000 (18:44 +0000)]
Get rid of extra colons, and fix up the display of default metrics, from
Jean-Christian Pennetier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3437 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd tree summary information similar to what's in packet-tcp.c.
gerald [Wed, 23 May 2001 03:33:59 +0000 (03:33 +0000)]
Add tree summary information similar to what's in packet-tcp.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3436 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWin32: build text2pcap doco and package it.
gram [Tue, 22 May 2001 16:19:45 +0000 (16:19 +0000)]
Win32: build text2pcap doco and package it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3435 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAccording to the autoconf documentation, you're not supposed to use
guy [Tue, 22 May 2001 06:43:24 +0000 (06:43 +0000)]
According to the autoconf documentation, you're not supposed to use

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3434 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCleanups to the "--with-ssl" configuration option, and changes to add
guy [Tue, 22 May 2001 06:33:06 +0000 (06:33 +0000)]
Cleanups to the "--with-ssl" configuration option, and changes to add
compiler flags on Solaris with GCC to cope with X11 header file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3433 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a typo in the "product name", and fix the "internal name".
guy [Mon, 21 May 2001 11:01:56 +0000 (11:01 +0000)]
Fix a typo in the "product name", and fix the "internal name".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3432 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix to LDP prefix FEC dissection for IPv4, from Eran Mann.
guy [Mon, 21 May 2001 10:14:37 +0000 (10:14 +0000)]
Fix to LDP prefix FEC dissection for IPv4, from Eran Mann.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3431 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf an RPC opaque datum isn't a string, don't use
guy [Mon, 21 May 2001 08:52:17 +0000 (08:52 +0000)]
If an RPC opaque datum isn't a string, don't use
"proto_tree_add_string_format()" to put in the protocol tree item for
the data, use "proto_tree_add_bytes_format()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3430 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd resource stuff for text2pcap.
guy [Mon, 21 May 2001 05:04:49 +0000 (05:04 +0000)]
Add resource stuff for text2pcap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3429 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoBuild text2pcap on Windows.
guy [Mon, 21 May 2001 03:17:14 +0000 (03:17 +0000)]
Build text2pcap on Windows.

Fix text2pcap.c so that it can be compiled with Microsoft Visual C++

protect some includes with #ifdefs, as not all the header files
in question exist in the MSVC++ build environment;

include <winsock.h> if we have it, to declare "ntohs()" and the

include "getopt.h" if we need it, to declare stuff for

include "config.h" if we have it, so we know whether the header
files in question exist or are needed;

rename "BYTE" to "READ_BYTE", as <winsock.h> defines BYTE as
well, and that definition causes a conflict;

get rid of references to "__FUNCTION__", as MSVC++ doesn't
define it (I suspect at least some UNIX compilers don't define
it, either).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3428 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix up a cast so that it properly sign-extends the server time zone;
guy [Sun, 20 May 2001 22:26:14 +0000 (22:26 +0000)]
Fix up a cast so that it properly sign-extends the server time zone;
from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3427 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRewritten IGMP dissector, from Ronnie Sahlberg.
guy [Sun, 20 May 2001 22:20:33 +0000 (22:20 +0000)]
Rewritten IGMP dissector, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3426 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd the text2pcap generated files to .cvsignore.
guy [Sun, 20 May 2001 22:06:04 +0000 (22:06 +0000)]
Add the text2pcap generated files to .cvsignore.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3425 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDeclare "yylex()" in "text2pcap.h", so that there's a prototype in scope
guy [Thu, 17 May 2001 00:11:37 +0000 (00:11 +0000)]
Declare "yylex()" in "text2pcap.h", so that there's a prototype in scope
when it's used by "text2pcap.c" - and so that the *same* prototype is in
scope when it's defined by "text2pcap-scanner.c".

Define "YY_NO_UNPUT" in "text2pcap.h", so we don't define "yyunput()" in
"text2pcap-scanner.c"; it's not used, so some compilers whine about it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3424 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDocumentation fix to generalize 'text2pcap -e' for all L3 packets instead of just IP.
ashokn [Wed, 16 May 2001 22:50:36 +0000 (22:50 +0000)]
Documentation fix to generalize 'text2pcap -e' for all L3 packets instead of just IP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3423 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agotext2pcap.1 was not being installed due to an omission in Makefile.am. Fixed this.
ashokn [Wed, 16 May 2001 22:04:53 +0000 (22:04 +0000)]
text2pcap.1 was not being installed due to an omission in Makefile.am. Fixed this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3422 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdded 'text2pcap', a utility to convert text hexdumps into pcap
ashokn [Wed, 16 May 2001 21:32:05 +0000 (21:32 +0000)]
Added 'text2pcap', a utility to convert text hexdumps into pcap
files. See text2pcap.1 (built from doc/text2pcap.pod) for details.

Changed 'tethereal -x' output to match hex dump format of text2pcap,
Ethereal and others.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3421 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdate hte entry for the Cisco-proprietary capabilities in BGP to give
guy [Wed, 16 May 2001 20:02:51 +0000 (20:02 +0000)]
Update hte entry for the Cisco-proprietary capabilities in BGP to give
the name of the person who submitted that change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3419 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPut in the name for <bgp4news@yahoo.com>.
guy [Wed, 16 May 2001 20:00:13 +0000 (20:00 +0000)]
Put in the name for <bgp4news@yahoo.com>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3418 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdate NEWS file for release 8.18
jfoster [Wed, 16 May 2001 18:57:47 +0000 (18:57 +0000)]
Update NEWS file for release 8.18

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3417 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSupport for Cisco-proprietary capabilities in BGP, from
guy [Wed, 16 May 2001 18:52:37 +0000 (18:52 +0000)]
Support for Cisco-proprietary capabilities in BGP, from

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3416 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdate files for release 8.18
jfoster [Wed, 16 May 2001 16:17:52 +0000 (16:17 +0000)]
Update files for release 8.18

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3415 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoStop depending on the order in which operations are performed by
guy [Tue, 15 May 2001 18:58:15 +0000 (18:58 +0000)]
Stop depending on the order in which operations are performed by
generated code, as per Chris Foulds' note.

Also, when constructing the system ID or area string, always append the
four-octet groups, rather than overwriting them, as we had been doing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3414 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoVarious ISIS improvements (ISIS IPv6 routing TLV dissection, ISIS
guy [Mon, 14 May 2001 18:40:17 +0000 (18:40 +0000)]
Various ISIS improvements (ISIS IPv6 routing TLV dissection, ISIS
traffic engineering TLV dissection, IS neighbor and IP reachability TLVs
given their own subtree types), from Jean-Christian Pennetier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3413 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdates to OSPF for the changes between drafts 3 and 4 of
guy [Mon, 14 May 2001 18:25:34 +0000 (18:25 +0000)]
Updates to OSPF for the changes between drafts 3 and 4 of
draft-katz-yeung-ospf-traffic, from Michael Rozhavsky.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3412 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a bug reported by Christopher McAvaney in
gerald [Sat, 12 May 2001 19:45:37 +0000 (19:45 +0000)]
Fix a bug reported by Christopher McAvaney in
In the display filter help window, the height of the text widget
can easily exceed the maximum height of an X window, which results
in a nonfunctioning vertical scroll bar.  This fix disables the
GtkScrolledWindow vertical scroll bar, and creates a new scroll bar
attached directly to the GtkText widget.

The layout is a little off - the horizontal scroll bar now occupies the
full height of the GtkScrolledWindow widget.  There doesn't seem to be
an easy way to grab the height of the horizontal scroll bar in order to
pad out the are underneath the vertical scroll bar.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3411 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPassive FTP support, from Juan Toledo.
guy [Fri, 11 May 2001 23:24:10 +0000 (23:24 +0000)]
Passive FTP support, from Juan Toledo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3410 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdates for the current CVS version of autoconf, from Nathan Neulinger
guy [Fri, 11 May 2001 01:09:59 +0000 (01:09 +0000)]
Updates for the current CVS version of autoconf, from Nathan Neulinger
(without those updates, I'm not even certain it was doing the right
thing even with autoconf 2.13, as it was sticking "dnl" into the program
it was handing to the C preprocessor, although, as it was only handing
it to the preprocessor, the extra "dnl" may have been harmless).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3409 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAutomake updates, from Nathan Neulinger, to handle the current CVS
guy [Fri, 11 May 2001 00:39:57 +0000 (00:39 +0000)]
Automake updates, from Nathan Neulinger, to handle the current CVS
version of automake (which will probably eventually become the next
release of automake) - it assumes variables that end with _SOURCES are
of the form "target_SOURCES", where "target" must be a target that the
Makefile builds.

Rename "DISSECTOR_SOURCES" to "DISSECTOR_SRC" in "Makefile.nmake", as
well, so that part of "Makefile.nmake" exactly matches that part of

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3408 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPatch from Chris Jepeway to use, in NetXRay 2.x captures, a field from
guy [Wed, 9 May 2001 04:42:27 +0000 (04:42 +0000)]
Patch from Chris Jepeway to use, in NetXRay 2.x captures, a field from
the file header to specify the time units; different files appear to
have different time stamp units.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3407 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen generating a filter expression to match a protocol tree line not
guy [Wed, 9 May 2001 01:22:46 +0000 (01:22 +0000)]
When generating a filter expression to match a protocol tree line not
corresponding to a named field, by matching stuff at a particular offset
in the frame, don't treat a length of 1 byte specially - the syntax for
a one-byte byte string is the same as for longer byte strings, with no
leading "0x" allowed.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3406 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoOnly set the Info column to an error indication if we haven't already
guy [Tue, 8 May 2001 19:50:29 +0000 (19:50 +0000)]
Only set the Info column to an error indication if we haven't already
put a packet description there.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3405 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdditional LDAP checks for invalid packets, from Scott Renfro.
guy [Tue, 8 May 2001 19:46:32 +0000 (19:46 +0000)]
Additional LDAP checks for invalid packets, from Scott Renfro.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3404 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix one remaining "NIS" to be "NIS+".
guy [Mon, 7 May 2001 21:11:42 +0000 (21:11 +0000)]
Fix one remaining "NIS" to be "NIS+".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3403 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf "proto_item_set_len()" is passed a null pointer as its first
guy [Mon, 7 May 2001 21:06:59 +0000 (21:06 +0000)]
If "proto_item_set_len()" is passed a null pointer as its first
argument, have it just return; this allows dissectors that don't
explicitly check for a null protocol-tree argument to pass the
protocol-tree argument to "proto_tree_add_XXX()" routines - which means
they'll get a null pointer back if the protocol-tree argument is null
because we're not constructing a protocol tree - and then later use
"proto_item_set_len()" without having to check for a null
protocol-tree-item pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3402 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNIS+ support, from Ronnie Sahlberg.
guy [Mon, 7 May 2001 20:49:48 +0000 (20:49 +0000)]
NIS+ support, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3401 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSupport for dissecting XDR arrays, from Ronnie Sahlberg.
guy [Mon, 7 May 2001 20:36:39 +0000 (20:36 +0000)]
Support for dissecting XDR arrays, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3400 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPIM enhancements and fixes, from Heikki Vatiainen.
guy [Mon, 7 May 2001 20:26:25 +0000 (20:26 +0000)]
PIM enhancements and fixes, from Heikki Vatiainen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3399 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIPX SAP over IPX EIGRP support, and IP EIGRP authentication updates,
guy [Thu, 3 May 2001 22:50:33 +0000 (22:50 +0000)]
IPX SAP over IPX EIGRP support, and IP EIGRP authentication updates,
from Paul Ionescu.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3398 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agouint8_t changed to guint8
girlich [Thu, 3 May 2001 07:02:50 +0000 (07:02 +0000)]
uint8_t changed to guint8

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3397 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdates from Alexandre P. Ferreira.
guy [Wed, 2 May 2001 22:37:06 +0000 (22:37 +0000)]
Updates from Alexandre P. Ferreira.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3396 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdditional OSPF LSA types and opaque-options flag, from Michael
guy [Wed, 2 May 2001 18:12:46 +0000 (18:12 +0000)]
Additional OSPF LSA types and opaque-options flag, from Michael

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3395 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPut in a comment warning that
guy [Tue, 1 May 2001 21:39:41 +0000 (21:39 +0000)]
Put in a comment warning that

1) "tvb_get_ntohll()" isn't available on all platforms (e.g.,
   with at least some compilers on Siemens' Sinix)


2) "%ll{d,o,x}" won't necessarily print a "long long int"
   quantity (e.g., on FreeBSD and Digital UNIX).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3394 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoBugfix: Removed an unnecessary and potentially spurious include from RSVP.
ashokn [Tue, 1 May 2001 18:33:06 +0000 (18:33 +0000)]
Bugfix: Removed an unnecessary and potentially spurious include from RSVP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3393 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- Added support for RSVP Refresh Reduction Extensions
ashokn [Tue, 1 May 2001 18:19:04 +0000 (18:19 +0000)]
- Added support for RSVP Refresh Reduction Extensions

- Added one-line summary of each RSVP object in the object line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3392 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdded support for DHCP Authentication extensions specified in
ashokn [Tue, 1 May 2001 03:54:04 +0000 (03:54 +0000)]
Added support for DHCP Authentication extensions specified in

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3391 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoBase HAVE_PLUGINS on whether "g_module_supported()" returns TRUE, not on
guy [Tue, 1 May 2001 02:44:52 +0000 (02:44 +0000)]
Base HAVE_PLUGINS on whether "g_module_supported()" returns TRUE, not on
whether there's a "dlfcn.h" header file; that lets us support plugins on

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3390 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"-l" command-line option to turn on automatic scrolling in "Update list
guy [Tue, 1 May 2001 00:41:46 +0000 (00:41 +0000)]
"-l" command-line option to turn on automatic scrolling in "Update list
of captures in real time" captures, from Christian Lacunza.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3389 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"prefs.capture_real_time", not "prefs.capture_auto_scroll", should
guy [Tue, 1 May 2001 00:18:48 +0000 (00:18 +0000)]
"prefs.capture_real_time", not "prefs.capture_auto_scroll", should
control whether we have a child process do the capturing; a user might
want the packet list to be updated as packets arrive but *not* want it
to scroll so that the most recently arrived packets are shown.

"prefs.capture_auto_scroll", not "auto_scroll_live", should control
whether we scroll a real-time-update capture's packet list;
"auto_scroll_live" isn't set by the capture dialog box,
"prefs_capture_auto_scroll" is.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3388 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the "pktsize" argument to "dissect_icqv5Server()" an "int", as it
guy [Fri, 27 Apr 2001 01:38:19 +0000 (01:38 +0000)]
Make the "pktsize" argument to "dissect_icqv5Server()" an "int", as it
can either be a 16-bit unsigned) packet size, or -1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3387 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMore signed-vs-unsigned changes from Joerg Mayer.
guy [Fri, 27 Apr 2001 01:27:37 +0000 (01:27 +0000)]
More signed-vs-unsigned changes from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3386 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of support for non-tvbuffified plugin dissectors.
guy [Wed, 25 Apr 2001 08:41:22 +0000 (08:41 +0000)]
Get rid of support for non-tvbuffified plugin dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3385 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake "col_set_str()" and "tvb_reported_length_remaining()" available in
guy [Wed, 25 Apr 2001 08:31:32 +0000 (08:31 +0000)]
Make "col_set_str()" and "tvb_reported_length_remaining()" available in

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3384 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf the SNMP headers were found but we failed to find "sprint_objid()" in
guy [Wed, 25 Apr 2001 07:51:36 +0000 (07:51 +0000)]
If the SNMP headers were found but we failed to find "sprint_objid()" in
the SNMP library, fail rather than driving on and letting the build

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3383 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFail if both UCD and CMU SNMP headers are found; we have no idea which
guy [Wed, 25 Apr 2001 07:44:04 +0000 (07:44 +0000)]
Fail if both UCD and CMU SNMP headers are found; we have no idea which
of the two libraries is installed - or, if both are installed in
different directories, or if a shared library for one and an unshared
library for another are installed in the same directory, which one we'll
get if we link with "-lsnmp" - so we have no idea whether the header
files with which we compile will match the library with which we link.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3382 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUndefine "isprint()" before re-defining it, to squelch a compiler
guy [Wed, 25 Apr 2001 06:33:41 +0000 (06:33 +0000)]
Undefine "isprint()" before re-defining it, to squelch a compiler

Put in a comment indicating that non-ASCII characters may well pass

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3381 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTvbuffify the Gryphon dissector.
guy [Wed, 25 Apr 2001 06:14:53 +0000 (06:14 +0000)]
Tvbuffify the Gryphon dissector.

Make all the routines for dissecting particular requests and responses

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3380 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWrap "VALS()" around pointers to "value_string" arrays, to suppress GCC
guy [Wed, 25 Apr 2001 05:32:16 +0000 (05:32 +0000)]
Wrap "VALS()" around pointers to "value_string" arrays, to suppress GCC

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3379 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoClearing a column before adding text to it with "col_add_fstr()" is
guy [Tue, 24 Apr 2001 23:22:03 +0000 (23:22 +0000)]
Clearing a column before adding text to it with "col_add_fstr()" is
unnecessary.  Clearing it before fetching anything from the packet with
a call that might throw an exception, however, is a Good Idea.

The Modbus/TCP dissector is called from a dissector table, so it doesn't
have to check if the protocol is enabled, or set "pinfo->current_proto"
- that's done for it by the dissector-table code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3378 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet the "." out of the URL for the Modbus/TCP home page.
guy [Tue, 24 Apr 2001 19:31:33 +0000 (19:31 +0000)]
Get the "." out of the URL for the Modbus/TCP home page.

Fix Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3377 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoModbus/TCP support, from Riaan Swart.
guy [Tue, 24 Apr 2001 19:29:14 +0000 (19:29 +0000)]
Modbus/TCP support, from Riaan Swart.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3376 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRANAP support, from Martin Held.
guy [Tue, 24 Apr 2001 19:18:03 +0000 (19:18 +0000)]
RANAP support, from Martin Held.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3375 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTvbuffify the RIPng dissector.
guy [Tue, 24 Apr 2001 02:50:00 +0000 (02:50 +0000)]
Tvbuffify the RIPng dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3374 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSigned vs. unsigned fixes from Joerg Mayer.
guy [Tue, 24 Apr 2001 00:28:21 +0000 (00:28 +0000)]
Signed vs. unsigned fixes from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3373 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSigned vs. unsigned fixes from Joerg Mayer.
guy [Mon, 23 Apr 2001 23:45:35 +0000 (23:45 +0000)]
Signed vs. unsigned fixes from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3372 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of some unnecessary includes.
guy [Mon, 23 Apr 2001 18:19:03 +0000 (18:19 +0000)]
Get rid of some unnecessary includes.

Fix up Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3371 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of an unnecessary include.
guy [Mon, 23 Apr 2001 18:11:01 +0000 (18:11 +0000)]
Get rid of an unnecessary include.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3370 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix Gerald's address.
guy [Mon, 23 Apr 2001 18:10:28 +0000 (18:10 +0000)]
Fix Gerald's address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3369 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of unnecessary includes.
guy [Mon, 23 Apr 2001 18:05:19 +0000 (18:05 +0000)]
Get rid of unnecessary includes.

Fix up Gerald's e-mail address in some files while we're at it, and fix
up Michael T�xen's name in one file as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3368 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of unnecessary include.
guy [Mon, 23 Apr 2001 17:56:42 +0000 (17:56 +0000)]
Get rid of unnecessary include.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3367 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove the declarations of IP protocol numbers to "ipproto.h" from
guy [Mon, 23 Apr 2001 17:51:37 +0000 (17:51 +0000)]
Move the declarations of IP protocol numbers to "ipproto.h" from

Fix Gerald's address in some files while we're at it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3366 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of BYTES_ARE_IN_FRAME references.
guy [Mon, 23 Apr 2001 04:35:39 +0000 (04:35 +0000)]
Get rid of BYTES_ARE_IN_FRAME references.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3365 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of END_OF_FRAME references in tvbuffified dissectors.
guy [Mon, 23 Apr 2001 04:29:54 +0000 (04:29 +0000)]
Get rid of END_OF_FRAME references in tvbuffified dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3364 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of NullTVB references.
guy [Mon, 23 Apr 2001 04:19:40 +0000 (04:19 +0000)]
Get rid of NullTVB references.

Don't check in the dissector for OSI options whether we've run past the
end of the captured data in the frame - the dissector is tvbuffified, so
the checks are done by the tvbuff accessors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3363 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of NullTVB references.
guy [Mon, 23 Apr 2001 04:12:51 +0000 (04:12 +0000)]
Get rid of NullTVB references.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3362 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNow that the IPv6 dissector has been tvbuffified, we can register it; do
guy [Mon, 23 Apr 2001 03:56:57 +0000 (03:56 +0000)]
Now that the IPv6 dissector has been tvbuffified, we can register it; do
so, make it static, and call it only through a handle.

In the ICMPv6 dissector, when we dissect the invoking packet in an
ICMPv6 error or in a redirected header option, make the columns
non-writable, so the summary line for the packet shows it as an ICMPv6
packet, not as the packet included in the ICMPv6 packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3361 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTvbuffification of the IPv6 and ICMPv6 dissectors, and some bug fixes
guy [Mon, 23 Apr 2001 03:37:31 +0000 (03:37 +0000)]
Tvbuffification of the IPv6 and ICMPv6 dissectors, and some bug fixes
and an update to draft 7 of ICMPv6 name lookups, from Heikki Vatiainen.

Fix some formats in the ICMPv6 dissector to use %u, rather than %d, for
unsigned quantities.

Show various type and code values in ICMPv6 as decimal, not hexadecimal
(they're decimal in the RFCs).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3360 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen registering numeric fields, check that a base other than BASE_NONE
guy [Mon, 23 Apr 2001 01:19:39 +0000 (01:19 +0000)]
When registering numeric fields, check that a base other than BASE_NONE
was specified.

This should obviate the need to handle BASE_NONE specially in the
formatting routines, so revert to the previous version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3359 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd support for comments in "process-x11-fields.pl", and add a copyright
guy [Sat, 21 Apr 2001 08:04:43 +0000 (08:04 +0000)]
Add support for comments in "process-x11-fields.pl", and add a copyright
notice/RCS ID/credit to Christophe to "x11-fields" as a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3358 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agorquota support completed by Ronnie Sahlberg.
guy [Sat, 21 Apr 2001 08:00:12 +0000 (08:00 +0000)]
rquota support completed by Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3357 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSPRAY support, from Ronnie Sahlberg.
guy [Sat, 21 Apr 2001 07:57:23 +0000 (07:57 +0000)]
SPRAY support, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3356 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdate the reassembly item to note that IPv4 fragments are now
guy [Sat, 21 Apr 2001 07:49:24 +0000 (07:49 +0000)]
Update the reassembly item to note that IPv4 fragments are now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3355 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIn ANSI C (and in pre-ANSI UNIX implementations), if you return from
guy [Fri, 20 Apr 2001 22:35:19 +0000 (22:35 +0000)]
In ANSI C (and in pre-ANSI UNIX implementations), if you return from
"main()", the program exits, and exits with an exit status equal to the
return value of "main()", so "return 0;" is sufficient at the end of

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3354 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "%u", not "%d", to print unsigned quantities.
guy [Fri, 20 Apr 2001 22:31:25 +0000 (22:31 +0000)]
Use "%u", not "%d", to print unsigned quantities.

Remove an extra space from one format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3353 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoExplain BASE_{DEC,HEX,OCT,BIN} a bit more, note that BASE_BIN is for
guy [Fri, 20 Apr 2001 22:00:27 +0000 (22:00 +0000)]
Explain BASE_{DEC,HEX,OCT,BIN} a bit more, note that BASE_BIN is for
binary but currently is just decimal, and note that you may not use
BASE_NONE for integers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3352 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen displaying the numeric value for the value_string string that was
guy [Fri, 20 Apr 2001 21:57:55 +0000 (21:57 +0000)]
When displaying the numeric value for the value_string string that was
selected in the filter-construction GUI, treat BASE_BIN like BASE_DEC,
as that's currently how it's treated elsewhere.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3351 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIn ANSI C (and in pre-ANSI UNIX implementations), if you return from
guy [Fri, 20 Apr 2001 21:50:06 +0000 (21:50 +0000)]
In ANSI C (and in pre-ANSI UNIX implementations), if you return from
"main()", the program exits, and exits with an exit status equal to the
return value of "main()", so "return 0;" is sufficient at the end of

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3350 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoInclude "process-x11-fields.pl" and "x11-fields" in the source
guy [Fri, 20 Apr 2001 21:29:02 +0000 (21:29 +0000)]
Include "process-x11-fields.pl" and "x11-fields" in the source

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3349 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix Gerald's e-mail address - and fix it in "README.developer", so
guy [Fri, 20 Apr 2001 20:34:31 +0000 (20:34 +0000)]
Fix Gerald's e-mail address - and fix it in "README.developer", so
people don't blindly insert the old address into new dissectors, which
is probably how it got into the dissectors being fixed here.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3348 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a "return 0;" at the end of main() to pacify MSVC 5 (and probably
gram [Fri, 20 Apr 2001 19:41:42 +0000 (19:41 +0000)]
Add a "return 0;" at the end of main() to pacify MSVC 5 (and probably
other compilers, too.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3347 f5534014-38df-0310-8fa8-9805f1628bb7