obnox/wireshark/wip.git
13 years agoHave separate proto_construct_match_selected_string() and
guy [Fri, 24 Nov 2006 18:25:23 +0000 (18:25 +0000)]
Have separate proto_construct_match_selected_string() and
proto_can_match_selected() routines, to more clearly separate the two
functions - but have them both call the same underlying routine, so
they both make the same decisions as to whether a match-selected string
can be constructed or not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19976 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAnother fix for Win32 build: add scsi_osd_vals
wmeier [Fri, 24 Nov 2006 17:41:09 +0000 (17:41 +0000)]
Another fix for Win32 build: add scsi_osd_vals

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19975 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Peter Johansson:
jake [Fri, 24 Nov 2006 11:07:39 +0000 (11:07 +0000)]
From Peter Johansson:
The attached patch corrects the Win32 compilation problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19974 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd some missing commandsets to the preference for default commandset and to the...
sahlberg [Fri, 24 Nov 2006 08:22:30 +0000 (08:22 +0000)]
add some missing commandsets to the preference for default commandset and to the scsi srt statistics

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19973 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Patrick vd Lageweg:
jake [Fri, 24 Nov 2006 07:28:02 +0000 (07:28 +0000)]
From Patrick vd Lageweg:
This patch fixes a simple typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19972 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Stefan Metzmacher:
jake [Fri, 24 Nov 2006 07:16:06 +0000 (07:16 +0000)]
From Stefan Metzmacher:
This patch fixes some problems with encrypted DCERPC traffic

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19971 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Stefan Metzmacher:
jake [Fri, 24 Nov 2006 07:09:38 +0000 (07:09 +0000)]
From Stefan Metzmacher:
I created two patches:
1.) move the handling of the compressed strings in CLDAP 'netlogon' replies into a generic place.
2.) implement dissection of SMB_NETLOGON cmd's 0x17 and 0x19

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19970 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug #940. Convert HSRP to a new-style dissector so that it can
sfisher [Fri, 24 Nov 2006 06:04:01 +0000 (06:04 +0000)]
Fix for bug #940.  Convert HSRP to a new-style dissector so that it can
reject datagrams that don't have both the source and destination port
of UDP_PORT_HSRP (1985).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19969 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug #646: show the end of HTTP chunked encoding (a chunk with size 0)
sfisher [Fri, 24 Nov 2006 02:59:43 +0000 (02:59 +0000)]
Fix for bug #646: show the end of HTTP chunked encoding (a chunk with size 0)
as described in RFC 2616.

-This line, and those below, will be ignored--

M    packet-http.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19968 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRename proto_construct_dfilter_string() to
guy [Thu, 23 Nov 2006 21:16:46 +0000 (21:16 +0000)]
Rename proto_construct_dfilter_string() to
proto_construct_match_selected_string() to indicate what it does - and
have it return a Boolean indication of whether the string could be
built, returning the string through a pointer, and, if that pointer is
null, have it just return the Boolean and not construct the string.

Get rid of proto_can_match_selected() -
proto_construct_match_selected_string() can be used for that, which
means we have only one piece of code that knows whether a "match
selected" string can be constructed or not.

Have proto_construct_match_selected_string() support matching
zero-length FT_NONE (and FT_PCRE, but that shouldn't happen) fields even
if there's no epan_dissect_t, as such a match just checks whether the
field is present.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19967 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoShow the header size as number of bytes.
etxrab [Thu, 23 Nov 2006 20:17:58 +0000 (20:17 +0000)]
Show the header size as number of bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19966 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoErrase the lua plugin, its not longer in use.
lego [Thu, 23 Nov 2006 12:58:58 +0000 (12:58 +0000)]
Errase the lua plugin, its not longer in use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19965 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agobreak the SCSI SMC commandset out into its own dissector
sahlberg [Thu, 23 Nov 2006 09:21:16 +0000 (09:21 +0000)]
break the SCSI SMC commandset out into its own dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19964 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoBack out most of r19878; it was making the 802.11 dissector overwrite the
gerald [Thu, 23 Nov 2006 01:49:18 +0000 (01:49 +0000)]
Back out most of r19878; it was making the 802.11 dissector overwrite the
RSSI column with the wrong value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19963 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug #1211. Patch from Joshua Wright to add -S option to tshark's
sfisher [Thu, 23 Nov 2006 01:45:51 +0000 (01:45 +0000)]
Fix for bug #1211.  Patch from Joshua Wright to add -S option to tshark's
usage description (-h).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19962 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoWhen checking whether a field supports "match selected", do the same
guy [Thu, 23 Nov 2006 00:15:49 +0000 (00:15 +0000)]
When checking whether a field supports "match selected", do the same
checks that we do when we try to construct the filter expression for
"match selected" - this means we don't just assert that all FT_NONEs are
filterable, as they aren't.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19961 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Cyril Margaria:
etxrab [Wed, 22 Nov 2006 23:20:11 +0000 (23:20 +0000)]
From Cyril Margaria:
Patch to support RSVP notify and added a few error codes, with some more objectcodes
added.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19960 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake the "standard" case in proto_can_match_selected() and
guy [Wed, 22 Nov 2006 22:11:38 +0000 (22:11 +0000)]
Make the "standard" case in proto_can_match_selected() and
proto_construct_dfilter_string() the default, so you add explicit cases
only when the type needs to be treated specially, so we don't end up
with types where we forget to have a case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19959 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix Win32 build: scsi_ssc2_vals -> scsi_ssc_vals
ulfl [Wed, 22 Nov 2006 20:52:40 +0000 (20:52 +0000)]
fix Win32 build: scsi_ssc2_vals -> scsi_ssc_vals

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19958 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agobreak the SCSI SSC commandset out into its own dissector
sahlberg [Wed, 22 Nov 2006 10:12:59 +0000 (10:12 +0000)]
break the SCSI SSC commandset out into its own dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19957 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agossc space6 count is a signed integer
sahlberg [Wed, 22 Nov 2006 09:00:36 +0000 (09:00 +0000)]
ssc space6 count is a signed integer

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19956 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Michael Lum
etxrab [Wed, 22 Nov 2006 06:39:24 +0000 (06:39 +0000)]
From Michael Lum

1)
A small change in the number of teleservices recognized

2)
Finally finished a lot of the changes for IOS 5 support.

The attached files must be used together.

Built in Windows XP Pro using Visual Studio C++ with the latest repository.

packet-ansi_map.c.gz

packet-ansi_a.gz
    This file contains both packet-ansi_a.c and packet-ansi_a.h changes.

libwireshark.def.gz

ansi_a_stat.c.gz

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19955 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRevert changes to have named bits in the bitstring of unknown length.
etxrab [Tue, 21 Nov 2006 22:18:12 +0000 (22:18 +0000)]
Revert changes to have named bits in the bitstring of unknown length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19954 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix pluralization of "bytes" so it doesn't say "1 bytes".
guy [Tue, 21 Nov 2006 21:49:58 +0000 (21:49 +0000)]
Fix pluralization of "bytes" so it doesn't say "1 bytes".

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19953 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix for bug 1226:
sahlberg [Tue, 21 Nov 2006 21:11:18 +0000 (21:11 +0000)]
fix for bug 1226:
reported by Benjamin Meyer

WireShark marks DCE RPC FACKs as "malformed" if they do not have a body.
According to DCE RPC Spec. 1.1 FACKs "may contain" a body PTU.

I am unable to build WireShark (lack of time to install all neccessary stuff)
but I looked at the SourceCode. I think, at least this has to be fixed:

file: epan/dissectors/packet-dcerpc.c
function: static gboolean dissect_dcerpc_dg (tvbuff_t *tvb, packet_info *pinfo,
proto_tree *tree)

*snip*
case PDU_FACK
dissect_dcerpc_dg_fack (tvb, offset, pinfo, dcerpc_tree, &hdr);
break;
*snap*

I guess, it should look like "case PDU_NOCALL:" directly above.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19952 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Bill Florac:
etxrab [Tue, 21 Nov 2006 21:00:25 +0000 (21:00 +0000)]
From Bill Florac:
Here is a patch for the ACN dissector. It fixes a bug in
acn_add_expiry() and cleans up some cosmetic things.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19951 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoIf you're doing TCP reassembly by hand rather than with
guy [Tue, 21 Nov 2006 20:10:10 +0000 (20:10 +0000)]
If you're doing TCP reassembly by hand rather than with
tcp_dissect_pdus(), pinfo->desegment_len indicates whether your
dissector needs more data from TCP or not - the return value doesn't
indicate that.

Fix typo.

It appears that the Id keyword is one of the case-insensitive ones in
the svn:keywords property, so if you set it to "ID" it still expands
"$Id$"; it also appears not to expand "$ID$".  We use Revision, Date,
and Author in the document to indicate the revision, and don't expand
Id, so that references to "$Id$" get left alone.

Rewrap paragraphs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19950 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoCorrect comments and examples on get_pdu_len().
jake [Tue, 21 Nov 2006 14:18:46 +0000 (14:18 +0000)]
Correct comments and examples on get_pdu_len().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19949 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd Japan SS7 variant to list of things I contributed (and verify this whole commit...
morriss [Tue, 21 Nov 2006 13:37:13 +0000 (13:37 +0000)]
Add Japan SS7 variant to list of things I contributed (and verify this whole commit thing works :-))

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19948 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPatrick vd Lageweg <patrick@bitwizard.nl>
sahlberg [Tue, 21 Nov 2006 09:18:28 +0000 (09:18 +0000)]
Patrick vd Lageweg <patrick@bitwizard.nl>

Hi,

The rease/release commands are also usable on SSC devices. This patch adds them to the valid SSC command.

        Patrick
_______________________________________________

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19947 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom: Burlyga, Alex
sahlberg [Tue, 21 Nov 2006 08:53:11 +0000 (08:53 +0000)]
From: Burlyga, Alex

Hi,

Attached is a patch for packet-rpc.c and packet-rpc.h.
Update support for pseudo-flavors that used in RPCSEC_GSS
Also fixed a problem where rpc.reqframe and rpc.repframe where
reversed.

Alex.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19946 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agothe result code, encoded within the userdata is in network byte order not little...
sahlberg [Tue, 21 Nov 2006 08:44:21 +0000 (08:44 +0000)]
the result code, encoded within the userdata is in network byte order not little endian.

this makes a difference for the cases where the result code is not KPASSWD_SUCCESS == 0x0000

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19945 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoIf a user starts typing text in the main window, append it to the
gerald [Tue, 21 Nov 2006 01:27:29 +0000 (01:27 +0000)]
If a user starts typing text in the main window, append it to the
display filter instead of replacing it.  Check for a valid character
with a simple isprint() instead of a giant boolean expression paragraph.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19944 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agowhile loading a huge capture file, enable the main window to show packets rushing...
ulfl [Tue, 21 Nov 2006 00:45:38 +0000 (00:45 +0000)]
while loading a huge capture file, enable the main window to show packets rushing into the packet list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19943 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoflush out the main event loop at dialog creation, so we don't see an empty dialog...
ulfl [Tue, 21 Nov 2006 00:40:36 +0000 (00:40 +0000)]
flush out the main event loop at dialog creation, so we don't see an empty dialog until the first update

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19942 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse the <name> convention for command-line arguments in the usage
guy [Tue, 21 Nov 2006 00:36:35 +0000 (00:36 +0000)]
Use the <name> convention for command-line arguments in the usage
message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19941 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoWe also need the memory allocation subsystem initialized in anything
guy [Tue, 21 Nov 2006 00:30:36 +0000 (00:30 +0000)]
We also need the memory allocation subsystem initialized in anything
that uses libwireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19940 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoCall guids_init() in epan_init(), so anything that needs libwireshark -
guy [Tue, 21 Nov 2006 00:16:44 +0000 (00:16 +0000)]
Call guids_init() in epan_init(), so anything that needs libwireshark -
including dftest - will get the GUID table initialized (which anything
that needs libwireshark needs to have happen, so dissectors can register
GUIDs in that table).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19939 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSquelch a compiler warning.
guy [Tue, 21 Nov 2006 00:00:26 +0000 (00:00 +0000)]
Squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19938 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug 1235. Elapsed time is in 10ms units.
jake [Mon, 20 Nov 2006 19:39:19 +0000 (19:39 +0000)]
Fix for bug 1235. Elapsed time is in 10ms units.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19937 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake FT_STRINGZ items work as apply/prepare as filter menu items
martinm [Mon, 20 Nov 2006 14:53:22 +0000 (14:53 +0000)]
Make FT_STRINGZ items work as apply/prepare as filter menu items

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19936 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd exclamation and left parenthesis to the display filter keystroke
gerald [Sun, 19 Nov 2006 23:23:53 +0000 (23:23 +0000)]
Add exclamation and left parenthesis to the display filter keystroke
catcher.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19935 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoif the WIRESHARK_LIBS dir isn't already existing, create it
ulfl [Sun, 19 Nov 2006 17:02:31 +0000 (17:02 +0000)]
if the WIRESHARK_LIBS dir isn't already existing, create it

this fixes problems discussed earlier on the list with cygpath

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19934 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix clean_setup target
ulfl [Sun, 19 Nov 2006 16:49:58 +0000 (16:49 +0000)]
fix clean_setup target

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19933 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate to the latest versions from sqlite.
etxrab [Sun, 19 Nov 2006 16:24:18 +0000 (16:24 +0000)]
Update to the latest versions from sqlite.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19932 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug #1126. In the SSL dissector, don't just check if we're allowed
sfisher [Sun, 19 Nov 2006 07:41:25 +0000 (07:41 +0000)]
Fix for bug #1126.  In the SSL dissector, don't just check if we're allowed
to desegment, but also check if we need to before attempting it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19931 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoIf the user starts typing ([a-zA-Z0-9]) anywhere in the main window, start
gerald [Sat, 18 Nov 2006 17:17:28 +0000 (17:17 +0000)]
If the user starts typing ([a-zA-Z0-9]) anywhere in the main window, start
filling in a display filter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19930 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix validity of document
ulfl [Sat, 18 Nov 2006 12:30:58 +0000 (12:30 +0000)]
fix validity of document

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19929 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDon't try to set focus on NULL.
gerald [Sat, 18 Nov 2006 05:19:40 +0000 (05:19 +0000)]
Don't try to set focus on NULL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19928 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoGTK1 doesn't have gtk_window_get_focus.
gerald [Sat, 18 Nov 2006 05:12:55 +0000 (05:12 +0000)]
GTK1 doesn't have gtk_window_get_focus.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19927 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake F8 and F7 move to the next and previous packets, which adds
gerald [Sat, 18 Nov 2006 05:05:18 +0000 (05:05 +0000)]
Make F8 and F7 move to the next and previous packets, which adds
compatibility with a different analyzer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19926 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoboth recent fixes of warnings don't compile on Win32, inttypes.h is not available...
ulfl [Sat, 18 Nov 2006 03:37:34 +0000 (03:37 +0000)]
both recent fixes of warnings don't compile on Win32, inttypes.h is not available and PRId64 is not defined in the config.h.win32.

As discussed in a seperate thread the PRId64 should not be required.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19925 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd additional keyboard navigation: Ctrl+Up & Ctrl+Down (under the "Go"
gerald [Sat, 18 Nov 2006 01:47:49 +0000 (01:47 +0000)]
Add additional keyboard navigation: Ctrl+Up & Ctrl+Down (under the "Go"
menu) move to the previous and next packet even if the packet list isn't
in focus (specifically, the packet detail will stay in focus if that was
already the case).  Make the return and enter keys toggle tree items in
the packet detail and the backspace key jump to the parent node.  Add a
navigation section to the User's Guide.

Make SIGNAL_EMIT_BY_NAME a simple #define, so that we can feed it
multiple arguments.  Fix up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19924 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd the /LARGEADDRESSAWARE to the link process of Wireshark(2) and Tshark. See http...
ulfl [Fri, 17 Nov 2006 22:48:21 +0000 (22:48 +0000)]
add the /LARGEADDRESSAWARE to the link process of Wireshark(2) and Tshark. See msdn.microsoft.com/library/default.asp?url=/library/en-us/memory/base/physical_address_extension.asp how to enable 3GB support on several Windows versions - I will update the OutOfMemory Wiki page accordingly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19923 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd dissection for PROFINET "PTCP Status"
ulfl [Fri, 17 Nov 2006 22:38:34 +0000 (22:38 +0000)]
add dissection for PROFINET "PTCP Status"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19922 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to squash 2 more warnings seen on buildot
martinm [Fri, 17 Nov 2006 16:33:43 +0000 (16:33 +0000)]
Try to squash 2 more warnings seen on buildot

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19921 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate from samba tree revision 19744 to 19759
jmayer [Fri, 17 Nov 2006 09:29:36 +0000 (09:29 +0000)]
Update from samba tree revision 19744 to 19759
============================ Samba log start ============
------------------------------------------------------------------------
r19751 | jelmer | 2006-11-16 23:11:32 +0100 (Thu, 16 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/tests/parse_idl.pl

Add some tests for parsing the "include", "import" and "importlib" statements.

------------------------------------------------------------------------
r19752 | jelmer | 2006-11-16 23:13:44 +0100 (Thu, 16 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/EJS.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Remove support for the `depends' attribute (use "import") instead.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19920 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix build
jake [Fri, 17 Nov 2006 07:44:37 +0000 (07:44 +0000)]
Fix build

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19919 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agocode cleanup
ulfl [Fri, 17 Nov 2006 03:08:09 +0000 (03:08 +0000)]
code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19918 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoImprove the heuristics of the SES dissector some more in response to bug #1229
sfisher [Fri, 17 Nov 2006 01:52:15 +0000 (01:52 +0000)]
Improve the heuristics of the SES dissector some more in response to bug #1229

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19917 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agovarious minor prefs code cleanup
ulfl [Fri, 17 Nov 2006 01:24:03 +0000 (01:24 +0000)]
various minor prefs code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19916 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDavid Young pointed out that we weren't aligning fields according to the
gerald [Thu, 16 Nov 2006 22:27:47 +0000 (22:27 +0000)]
David Young pointed out that we weren't aligning fields according to the
radiotap specification.  Do so.  Add fields for FHSS and Transmit
attenuation (untested).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19915 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoJelmer Vernooij:
jmayer [Thu, 16 Nov 2006 21:57:31 +0000 (21:57 +0000)]
Jelmer Vernooij:

The attached patch replace the use of 'depends()' with "import" (the
latter is a standard IDL statement).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19914 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTemporrary change to force the buildbot to update the libraries as I suspect there...
etxrab [Thu, 16 Nov 2006 21:11:26 +0000 (21:11 +0000)]
Temporrary change to force the buildbot to update the libraries as  I suspect there are left
over old files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19913 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix an annoying behaviour: If we save a capture file, let the default be the current...
ulfl [Thu, 16 Nov 2006 20:13:26 +0000 (20:13 +0000)]
fix an annoying behaviour: If we save a capture file, let the default be the current file format - as we do it in the GTK version. The former implementation just defaulted to libpcap all the time, which is especially ugly if you use a file format that provides nanosecond time resolution - you're losing information :-(

Interestingly the implementation was half way there, but not really working as expected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19912 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago(hopefully) fix the recently discussed warnings where CLAMP() is called with a value...
ulfl [Thu, 16 Nov 2006 20:08:13 +0000 (20:08 +0000)]
(hopefully) fix the recently discussed warnings where CLAMP() is called with a value being 0

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19911 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd comments to the indentation style section.
gerald [Thu, 16 Nov 2006 18:28:09 +0000 (18:28 +0000)]
Add comments to the indentation style section.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19910 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake multipart part a proper field, and append contained content-type to
martinm [Thu, 16 Nov 2006 14:35:52 +0000 (14:35 +0000)]
Make multipart part a proper field, and append contained content-type to
it label to make it easier to find the part you're looking for.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19909 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug 948, "Apply capture preferences not applying." Now when the user
sfisher [Thu, 16 Nov 2006 07:04:02 +0000 (07:04 +0000)]
Fix for bug 948, "Apply capture preferences not applying."  Now when the user
changes a capture option in the preferences, it will show up right away in
the capture options dialog.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19908 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix a warning
ulfl [Wed, 15 Nov 2006 23:48:56 +0000 (23:48 +0000)]
fix a warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19907 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix a warning
ulfl [Wed, 15 Nov 2006 23:43:16 +0000 (23:43 +0000)]
fix a warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19906 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd a "private_data" pointer to the read_prefs_file() function, which will be "tunnel...
ulfl [Wed, 15 Nov 2006 23:33:39 +0000 (23:33 +0000)]
add a "private_data" pointer to the read_prefs_file() function, which will be "tunneled" to the callback function. This seems to be generally a good idea - as a lot of GLib/GTK function doing similiar and I'll need this for the upcoming update mechanisms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19905 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdding ISC Object Management API dissector
jake [Wed, 15 Nov 2006 20:55:46 +0000 (20:55 +0000)]
Adding ISC Object Management API dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19904 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago solve both issues pointed out in:
lego [Wed, 15 Nov 2006 18:40:37 +0000 (18:40 +0000)]
 solve both issues pointed out in:
    http://wireshark.org/lists/ethereal-dev/200605/msg02351.html

- dtd_parse.l:
   be more liberal on what a name can be (a number now can be a name)

- packet-xml.c
  if proto-name is given use it instead of the root element name as prefix for generated fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19903 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPropset
martinm [Wed, 15 Nov 2006 18:20:03 +0000 (18:20 +0000)]
Propset

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19902 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Olivier Jacques:
martinm [Wed, 15 Nov 2006 17:27:04 +0000 (17:27 +0000)]
From Olivier Jacques:

Here is a DTD for the MSCML protocol, draft-07. This implementation is not entirely up-to-date (draft-09 is out), but this is a good base to start from.

I updated the WIKI with info, snapshot and sample capture: http://wiki.wireshark.org/MSCML

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19901 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd OID translation for some more Generic codecs.
etxrab [Wed, 15 Nov 2006 07:04:22 +0000 (07:04 +0000)]
Add OID translation for some more Generic codecs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19900 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix problem reported on -dev list by Frank Maerz with Wireshark crashing
sfisher [Wed, 15 Nov 2006 06:46:11 +0000 (06:46 +0000)]
Fix problem reported on -dev list by Frank Maerz with Wireshark crashing
when it encountered a proxy http connect to port 80.  This was caused by
the dissector calling itself over and over.  Now if the connect to port is
one of the defined http ports, it calls the data dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19899 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoA fix bug #1138: "Follow TCP Streams gets stream direction wrong if started
sfisher [Tue, 14 Nov 2006 22:53:24 +0000 (22:53 +0000)]
A fix bug #1138: "Follow TCP Streams gets stream direction wrong if started
from a server->client frame."

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19898 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoNew feature to automatically highlight the field found when doing a find.
sfisher [Tue, 14 Nov 2006 22:35:22 +0000 (22:35 +0000)]
New feature to automatically highlight the field found when doing a find.
This works for both string and hex searches.  This resolves feature request
bug #776.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19897 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd svn:ignore to tools/TAGS and plugins/TAGS
sfisher [Tue, 14 Nov 2006 21:28:44 +0000 (21:28 +0000)]
Add svn:ignore to tools/TAGS and plugins/TAGS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19896 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agonikai@nikai.net:
jmayer [Tue, 14 Nov 2006 20:32:29 +0000 (20:32 +0000)]
nikai@nikai.net:

Remaining fixes from:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19895 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agonikai@nikai.net:
jmayer [Tue, 14 Nov 2006 20:08:44 +0000 (20:08 +0000)]
nikai@nikai.net:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

Attempting a simple cleanup of duplicated includes, will attach patch.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19894 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agodidier gautheron:
jmayer [Tue, 14 Nov 2006 20:01:41 +0000 (20:01 +0000)]
didier gautheron:
idl2wrs.sh is a generated file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19893 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix possible build error + warnings seen on buildbot
martinm [Tue, 14 Nov 2006 13:45:35 +0000 (13:45 +0000)]
Fix possible build error + warnings seen on buildbot

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19892 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago- Use 64-bit indexes into file for packet locations (was previously casting index...
martinm [Tue, 14 Nov 2006 12:06:11 +0000 (12:06 +0000)]
- Use 64-bit indexes into file for packet locations (was previously casting index to and from void*) - this should allow very large files to be used
- The characters between the timestamp and start of data are almost always " l ", optimise memory usage in this case
- Rename hash table for clarity

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19891 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd SIP application AVP:s.
etxrab [Tue, 14 Nov 2006 06:31:47 +0000 (06:31 +0000)]
Add SIP application AVP:s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19890 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd SIP application AVP:s (Incomplete) and sortmobileipv4 in numerical order.
etxrab [Tue, 14 Nov 2006 06:14:20 +0000 (06:14 +0000)]
Add SIP application AVP:s (Incomplete) and sortmobileipv4 in numerical order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19889 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Simon Munton as pointed out by Stephen Fisher:
etxrab [Tue, 14 Nov 2006 06:00:48 +0000 (06:00 +0000)]
From Simon Munton as pointed out by Stephen Fisher:
patch on bug #220 (to main.c.
the second part to packet_list.c was done separately for bug 1159 in rev 19735).  That patch fixes bug #1205 coincidentally.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19888 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom martin Peylo:
etxrab [Tue, 14 Nov 2006 05:49:59 +0000 (05:49 +0000)]
From martin Peylo:
This patch changes the name of "Link Configuration" Packets to "Neighbour Discovery" - as preferred by the creator of TIPC - and shows the TIPC src/dst in the columns instead of the MAC address for those packages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19887 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Stephen Fisher:
etxrab [Tue, 14 Nov 2006 05:47:57 +0000 (05:47 +0000)]
From Stephen Fisher:
a new more accurate fix for bug #1163.  Thanks to Graeme Lunt for pointing out that the first patch broke a different capture with legitimate SES data in it.  My patch also corrects the check for number of bytes existing from 4 to 2 as the minimum length of an SES PDU is only 2 bytes: 1 byte type, 1 byte length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19886 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThis is Gerrit Renker code which:
etxrab [Tue, 14 Nov 2006 05:45:28 +0000 (05:45 +0000)]
This is Gerrit Renker code which:

       * makes checksum computation dependent
         upon the header CsCov field (cf. RFC 4340, 5.1)
       * removes the case where checksums are zero
         (unlike UDP/packet-udp, from which the code stems,
          zero checksums are illegal in DCCP (as in TCP))
       * fixes a minor typo - missing bitshift of the
         CCVal field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19885 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd support for IPv4-Aggregate session/template/filter types.
ashokn [Mon, 13 Nov 2006 17:30:38 +0000 (17:30 +0000)]
Add support for IPv4-Aggregate session/template/filter types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19884 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSet a transparency threshold for the XPM icons. Have the make-icons script
gerald [Mon, 13 Nov 2006 01:15:56 +0000 (01:15 +0000)]
Set a transparency threshold for the XPM icons.  Have the make-icons script
constify the XPMs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19883 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMark Krochmal says that the class field should be treated in mDNS as a
guy [Sun, 12 Nov 2006 23:42:08 +0000 (23:42 +0000)]
Mark Krochmal says that the class field should be treated in mDNS as a
flag and a 15-bit field even for OPT RRs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19882 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFlag the question as a "QM" question if the QU flag isn't set.
guy [Sun, 12 Nov 2006 22:35:21 +0000 (22:35 +0000)]
Flag the question as a "QM" question if the QU flag isn't set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19881 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate to use the latest gtk 2.8 glib and pango libraries.
etxrab [Sun, 12 Nov 2006 22:18:50 +0000 (22:18 +0000)]
Update to use the latest gtk 2.8 glib and pango libraries.
Note from a mail on gtk dev list:
-rwxr-xr-x    1 tml      Administ   224510 Oct  3 18:35 libpango-1.0-0.dll
-rwxr-xr-x    1 tml      Administ    37952 Oct  3 18:35 libpangocairo-1.0-0.dll
-rwxr-xr-x    1 tml      Administ    58749 Oct  3 18:35 libpangowin32-1.0-0.dll

(That's the relevant DLLs from the "bin" folder in Pango 1.14.5, where
the module(s) are built-in into the DLLs, so no
lib/pango/1.5.0/modules folder is needed.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19880 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agomDNS treats the class field as a flag bit and 15 bits of class; display
guy [Sun, 12 Nov 2006 22:12:39 +0000 (22:12 +0000)]
mDNS treats the class field as a flag bit and 15 bits of class; display
it as such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19879 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a plain "radiotap.channel" field to the radiotap dissector.
gerald [Sun, 12 Nov 2006 00:52:05 +0000 (00:52 +0000)]
Add a plain "radiotap.channel" field to the radiotap dissector.
Check for an invalid channel frequency.  Pass the channel, data rate,
and quality to the 802.11 dissector, so that they show up there
as well.  Clean up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19878 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix so that tcp.pdu.time works again.
sahlberg [Sat, 11 Nov 2006 22:39:25 +0000 (22:39 +0000)]
fix so that tcp.pdu.time works again.
it broken in one of the previous bugfixes to tcp

add a function to print an emem tree to the console for easier emem tree debugging

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19877 f5534014-38df-0310-8fa8-9805f1628bb7