obnox/wireshark/wip.git
18 years agoColumn list pointer became invalid when element was removed from list. Fixes bug...
jake [Mon, 24 Apr 2006 21:27:12 +0000 (21:27 +0000)]
Column list pointer became invalid when element was removed from list. Fixes bug 886.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17983 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPreparations to include ANSI ISUP dissection.
etxrab [Mon, 24 Apr 2006 19:11:33 +0000 (19:11 +0000)]
Preparations to include ANSI ISUP dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17981 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Miha Jemec:
etxrab [Mon, 24 Apr 2006 19:10:36 +0000 (19:10 +0000)]
From Miha Jemec:

With the new feature we can:
1. Measure how big the bursts are for a video streams (it uses sliding window algorithm) 2. Measure how big the output buffer should be that no packet drop will occur (it uses Leaky bucket algorithm)
3. Detect if we have loses inside the MPEG2 video stream (if there are already MPEG2 packets missing) - this part of code is not added yet, see Limitations

The addition is called Multicast streams and works as follows:

- it uses the TAP system
- the main "stream" logic is taken from rtp_strems.* files
- the TAP system checks for UDP packets where the destination MAC address starts with "01:00:5E" (ethernet multicast address)
- it creates an entry for every new multicast stream
- based on sliding window and leaky bucket algorithm it calculates for every stream average BW, max BW, burst size, max buffer needed, some alarms if the limits are exceeded,...
- the same calculation is done for all streams together
- inside the window dialog you can specify the burst interval, the alarm limits and output speeds

To do & limitations:

- Currently the analysis can be done only for multicast streams, it means that VoD (Video on demand) or PayTV streams, which are normally unicast can not be analysed.

- since the MPEG2 is patended I don't know if decoding of MPEG2 packets is allowed? Can we look inside this packets and calculate packets drops based on some counter information inside the payload? Can someone please answer this question? If we can do this, I will post this part of code too.

-  some more flexibility will be added

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17980 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Martin Mathieson:
etxrab [Mon, 24 Apr 2006 19:08:52 +0000 (19:08 +0000)]
From Martin Mathieson:

This patch should hopefully remove any possible buffer overflows in
parse_line() as reported by the current Coverity scan.  I'm not sure
that the error it currently reports is valid (I think its confused by
supposing that a condition that is being tested can be true, whereas it
can't...), but this patch fixes a number of potential problems remaining
in the function.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17979 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake some /******...*/ lines less wide: They make svn-diffs on the web page
jmayer [Mon, 24 Apr 2006 16:43:22 +0000 (16:43 +0000)]
Make some /******...*/ lines less wide: They make svn-diffs on the web page
unreadable unless you have a 2000xsomething display.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17978 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agochange the signature for dissect_scsi_snsinfo() to take itlq and itl structures
sahlberg [Mon, 24 Apr 2006 08:16:18 +0000 (08:16 +0000)]
change the signature for dissect_scsi_snsinfo() to take itlq and itl structures

update the comment in packet-scsi.c   to reflect that it is the transport now that is responsible to track itl and itlq data

make scsi tapable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17974 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUse 2-space indentation.
guy [Mon, 24 Apr 2006 05:04:30 +0000 (05:04 +0000)]
Use 2-space indentation.

Clean up the checks for STP vs. RSTP vs. MSTP.

Show the version 3 length field as a separate field, rather than as the
top-level item for the MSTP stuff.

"Trust" the version 3 length field, so that if it doesn't agree with the
packet length, we report a malformed frame (as we should).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17973 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUse proto_tree_add_item() whenever possible; this simplifies the code,
guy [Sun, 23 Apr 2006 20:14:33 +0000 (20:14 +0000)]
Use proto_tree_add_item() whenever possible; this simplifies the code,
and, in particular, means we don't, for example, use tvb_get_ntohs() to
fetch a 4-byte quantity - that fixes bug 883.

The MST config name is either null-terminated or null-padded; mark it as
such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17972 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoExport tvb_uncompress to plugins; fixes bug 893.
guy [Sun, 23 Apr 2006 19:13:48 +0000 (19:13 +0000)]
Export tvb_uncompress to plugins; fixes bug 893.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17971 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoTry using the new generic plugin Makefile.nmake.
guy [Sun, 23 Apr 2006 18:54:32 +0000 (18:54 +0000)]
Try using the new generic plugin Makefile.nmake.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17970 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Diego Petteno: link the shared libethereal against the ADNS
guy [Sun, 23 Apr 2006 18:50:58 +0000 (18:50 +0000)]
From Diego Petteno: link the shared libethereal against the ADNS
library.  If that's not done, it leaves to ethereal or other binaries
using it the job of linking adns within them.  This behaviour is
unreliable and breaks when using the --as-needed flag for GNU ld
(version 2.16 or better 2.17).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17969 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix CID: 150
etxrab [Sun, 23 Apr 2006 18:05:23 +0000 (18:05 +0000)]
Fix CID: 150

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17968 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUse the PLUGIN_NAME macro, to see if we can minimize the number of
guy [Sun, 23 Apr 2006 17:45:22 +0000 (17:45 +0000)]
Use the PLUGIN_NAME macro, to see if we can minimize the number of
changes needed to Makefile.nmake for a new plugin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17967 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"irda", not "ira".
guy [Sun, 23 Apr 2006 09:13:18 +0000 (09:13 +0000)]
"irda", not "ira".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17966 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoResolve conflicts.
guy [Sun, 23 Apr 2006 08:23:49 +0000 (08:23 +0000)]
Resolve conflicts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17965 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRegistration routines can't be static - they're called from plugin.c
guy [Sun, 23 Apr 2006 03:15:51 +0000 (03:15 +0000)]
Registration routines can't be static - they're called from plugin.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17964 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd the objects built from DISSECTOR_SUPPORT_SRC.
guy [Sun, 23 Apr 2006 02:14:11 +0000 (02:14 +0000)]
Add the objects built from DISSECTOR_SUPPORT_SRC.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17963 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd various OID's and a value_string for all of them
ulfl [Sat, 22 Apr 2006 20:34:14 +0000 (20:34 +0000)]
add various OID's and a value_string for all of them
add output of some MAC_OPTIONS fields
enhance some 802.11 output labels

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17962 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoConvert most other plugin dissectors to use the make-dissector-reg
guy [Sat, 22 Apr 2006 20:26:16 +0000 (20:26 +0000)]
Convert most other plugin dissectors to use the make-dissector-reg
scripts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17961 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoas I've experienced a scrollbar again while having 7 interfaces, I've tried to add...
ulfl [Sat, 22 Apr 2006 20:16:47 +0000 (20:16 +0000)]
as I've experienced a scrollbar again while having 7 interfaces, I've tried to add the number of interfaces to the height formula to fix this

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17960 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agothe "Generic dialup adapter" interface doesn't support any OID's at all, extend the...
ulfl [Sat, 22 Apr 2006 13:44:11 +0000 (13:44 +0000)]
the "Generic dialup adapter" interface doesn't support any OID's at all, extend the tab insensitive mechanism to all tabs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17959 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd a new tab with TCP/IP offloading capabilities
ulfl [Sat, 22 Apr 2006 13:21:39 +0000 (13:21 +0000)]
add a new tab with TCP/IP offloading capabilities
add some debug functions to show available OID's
clarify some 802.11 item labels

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17958 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoput some exchange tracking info in scsi CDBs and DATA pdus
sahlberg [Sat, 22 Apr 2006 10:31:30 +0000 (10:31 +0000)]
put some exchange tracking info in scsi CDBs and DATA pdus

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17957 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd the spc commands to the mmc tables
sahlberg [Sat, 22 Apr 2006 10:15:00 +0000 (10:15 +0000)]
add the spc commands to the mmc tables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17956 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd the spc commands to the smc and ssc tables
sahlberg [Sat, 22 Apr 2006 10:00:05 +0000 (10:00 +0000)]
add the spc commands to the smc and ssc tables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17955 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd all supported SPC commands used by SBC to the SBC tables
sahlberg [Sat, 22 Apr 2006 09:23:52 +0000 (09:23 +0000)]
add all supported SPC commands used by SBC to the SBC tables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17954 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agostart prettifying the dissection
sahlberg [Sat, 22 Apr 2006 04:42:07 +0000 (04:42 +0000)]
start prettifying the dissection

make scsi responses also display the opcode in the info column

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17953 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agothe scsi transports (fc/fcp and iscsi) now track both itl and itlq
sahlberg [Sat, 22 Apr 2006 02:16:52 +0000 (02:16 +0000)]
the scsi transports (fc/fcp and iscsi)    now track both itl and itlq
structures for scsi.

we no longer need the scsi_task_id structure passed by pinfo->private_data   so get rid of it.

we no longer need the (broken by design) scsi_task_data   hash table   since this has been replaced byt hte itl and itlq structures and tracking

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17952 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agochange the HHC setting to HHC_DIR, so we can use it also to call the HtmlHelp function
ulfl [Fri, 21 Apr 2006 22:47:19 +0000 (22:47 +0000)]
change the HHC setting to HHC_DIR, so we can use it also to call the HtmlHelp function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17951 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoprepare to list the IP addresses in the command line interfaces list output
ulfl [Fri, 21 Apr 2006 22:40:33 +0000 (22:40 +0000)]
prepare to list the IP addresses in the command line interfaces list output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17950 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoremover the lun parameter from dissect_scsi_cdb/payload since this is now part...
sahlberg [Fri, 21 Apr 2006 22:00:38 +0000 (22:00 +0000)]
remover the lun parameter from dissect_scsi_cdb/payload   since this is now part of the exchange data in itlq

remove the two fields opcode and devtype from the scsi_task_data structure since these are also part of the itlq and itl structures

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17949 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoslightly rephrase the time zone chapter
ulfl [Fri, 21 Apr 2006 21:09:09 +0000 (21:09 +0000)]
slightly rephrase the time zone chapter

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17948 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Jeff Morris:
etxrab [Fri, 21 Apr 2006 18:11:20 +0000 (18:11 +0000)]
From Jeff Morris:
I tried out the 0.99.0pre1 release and I noticed that all my SCCP management messages (on SSN==1) were getting decoded as TCAP.  Turns out that the INAP dissector (due to a bug) registers to SSN==1 by default (instead of 106 and 241).  Rather than just fix that bug, the attached patch modifies the INAP dissector to use a range preference (like GSM MAP, TCAP, etc.).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17945 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Irene: Fix a bug when searching for an assoc.
tuexen [Fri, 21 Apr 2006 15:48:43 +0000 (15:48 +0000)]
From Irene: Fix a bug when searching for an assoc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17944 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Chris Maynard:
jake [Fri, 21 Apr 2006 15:10:27 +0000 (15:10 +0000)]
From Chris Maynard:
Using the attached patch, this file was generated via "File -> Export -> as XML
- "PDML" (packet details) file ...".  As can be seen in the file, the 1st
packet now contains the value for the "media", whereas previously it did not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17943 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoupdates to get the fc and scsi dissectors
sahlberg [Fri, 21 Apr 2006 11:08:24 +0000 (11:08 +0000)]
updates to get the fc and scsi dissectors
and get rid of some breakage in the design

let the scsi transport keep track of itl (initiator, target, lun) matching
and let it pass a itl structure to scsi   that is persistent across packets.

let scsi use this itl structure to track device type for a specific itl instead of the (must have been) broken hashtable.

update both iscsi and fc to track the itl structure for scsi and schange the scsi signature to accept itl as a parameter.

more to come.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17942 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agouse a CSS stylesheet for HTML output. This seems to be the official way to format...
ulfl [Fri, 21 Apr 2006 02:18:24 +0000 (02:18 +0000)]
use a CSS stylesheet for HTML output. This seems to be the official way to format a sidebar to look different than normal floating text

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17941 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoenhance the "File Sets" page (e.g. add a screenshot)
ulfl [Fri, 21 Apr 2006 00:44:40 +0000 (00:44 +0000)]
enhance the "File Sets" page (e.g. add a screenshot)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17940 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom: Shashidhar Bhandare
jake [Thu, 20 Apr 2006 21:17:18 +0000 (21:17 +0000)]
From: Shashidhar Bhandare
I have added ISUP dissector support for decoding four ANSI ISUP messages for decoding: CRM, CRA, CVT and CVR

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17939 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix help button settings
ulfl [Thu, 20 Apr 2006 20:40:29 +0000 (20:40 +0000)]
fix help button settings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17938 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoif HHC_DIR is defined in config.nmake, link Ethereal with the required htmlhelp.lib
ulfl [Thu, 20 Apr 2006 20:35:58 +0000 (20:35 +0000)]
if HHC_DIR is defined in config.nmake, link Ethereal with the required htmlhelp.lib

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17937 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoif HHC_DIR is defined in config.nmake, include the user-guide.chm file into the Win32...
ulfl [Thu, 20 Apr 2006 20:33:04 +0000 (20:33 +0000)]
if HHC_DIR is defined in config.nmake, include the user-guide.chm file into the Win32 installer

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17936 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd a Help button to the Preferences dialog
ulfl [Thu, 20 Apr 2006 20:31:05 +0000 (20:31 +0000)]
add a Help button to the Preferences dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17935 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Mark C. Brown:
jake [Thu, 20 Apr 2006 20:29:57 +0000 (20:29 +0000)]
From Mark C. Brown:
Small patch to set the direction correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17934 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix a very minor bug if ETHEREAL_EUG_DIR is set (which is barely the case)
ulfl [Thu, 20 Apr 2006 20:29:48 +0000 (20:29 +0000)]
fix a very minor bug if ETHEREAL_EUG_DIR is set (which is barely the case)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17933 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoif HHC_DIR is defined in config.nmake, use the Win32 HTMLHELP system (using the user...
ulfl [Thu, 20 Apr 2006 20:27:44 +0000 (20:27 +0000)]
if HHC_DIR is defined in config.nmake, use the Win32 HTMLHELP system (using the user-guide.chm file)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17932 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd a help button to the "Follow TCP Stream" dialog (and use standard button row...
ulfl [Thu, 20 Apr 2006 19:58:50 +0000 (19:58 +0000)]
add a help button to the "Follow TCP Stream" dialog (and use standard button row for it too)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17931 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago(on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland):
ulfl [Thu, 20 Apr 2006 19:49:12 +0000 (19:49 +0000)]
(on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland):
add Precision Time Control Protocol dissector (PTCP)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17930 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some more Media types.
etxrab [Thu, 20 Apr 2006 15:24:04 +0000 (15:24 +0000)]
Add some more Media types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17927 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix bugs:
etxrab [Thu, 20 Apr 2006 15:23:17 +0000 (15:23 +0000)]
Fix bugs:
883 checkIMEIres dissection Error in GSM MAP - branch needed for v1,v2 on Response as well
884 The "absentSubscriberParam" can not be dissected in gsm-map - missing IMPLICIT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17926 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Hannes Gredler:
jake [Thu, 20 Apr 2006 10:55:06 +0000 (10:55 +0000)]
From Hannes Gredler:
attached a patch to display LMP bandwith values in Mbps format
rather than the Byte/s format which is IMO a bit awkward to read.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17923 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agorename hte itlq structures to itlq
sahlberg [Thu, 20 Apr 2006 09:43:56 +0000 (09:43 +0000)]
rename hte itlq structures to itlq

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17922 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agorename the fc_exchange_data structure to the more appropriate itlq_nexus_t
sahlberg [Thu, 20 Apr 2006 09:16:09 +0000 (09:16 +0000)]
rename the fc_exchange_data structure to the more appropriate itlq_nexus_t

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17921 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate to reflect the way the DOCSIS plugin is done; that's easier (you
guy [Thu, 20 Apr 2006 02:39:04 +0000 (02:39 +0000)]
Update to reflect the way the DOCSIS plugin is done; that's easier (you
only list the files in one place, Makefile.common; make-dissector-reg
will generate the init routines and other boilerplate for you).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17920 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRename "make-reg-dotc" to "make-dissector-reg", and do the same for the
guy [Thu, 20 Apr 2006 02:21:28 +0000 (02:21 +0000)]
Rename "make-reg-dotc" to "make-dissector-reg", and do the same for the
Python versions, as it no longer makes only "register.c", it can also
make a "plugin.c" file for a plugin.

When making "plugin.c", there's no need to include "register.h", as it's
not defining any functions declared there.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17919 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a typo.
guy [Wed, 19 Apr 2006 21:43:48 +0000 (21:43 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17918 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix the register and register-handoff routines to have the standard
guy [Wed, 19 Apr 2006 21:42:39 +0000 (21:42 +0000)]
Fix the register and register-handoff routines to have the standard
format, so the script that generates plugin.c will generate code to call
them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17917 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Martin mathieson:
etxrab [Wed, 19 Apr 2006 19:45:56 +0000 (19:45 +0000)]
From Martin mathieson:
While looking at bug 882 (which seems to have been fixed since 0.10.14) I noticed the RTCP heuristic dissector wasn't picking up the frame.

This patch fixes the parenthesis to test the packet-type properly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17914 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Karsten P. Hoffmann:
etxrab [Wed, 19 Apr 2006 19:28:11 +0000 (19:28 +0000)]
From Karsten P. Hoffmann:
The 'info'-part should display the invoke id of confirmed service as well, since it is much easier to match request and reply without typeing any filter rules or so.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17913 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAnd the .py script
etxrab [Wed, 19 Apr 2006 19:10:00 +0000 (19:10 +0000)]
And the .py script

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17912 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoHandle 64bits signed/unsigned integers and get rid of some extra LF:s.
etxrab [Wed, 19 Apr 2006 18:59:29 +0000 (18:59 +0000)]
Handle 64bits signed/unsigned integers and get rid of some extra LF:s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17911 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some applications
etxrab [Wed, 19 Apr 2006 18:58:13 +0000 (18:58 +0000)]
Add some applications

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17910 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Martin Mathieson:
etxrab [Wed, 19 Apr 2006 18:57:25 +0000 (18:57 +0000)]
From Martin Mathieson:
Fix coverity bugs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17909 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoregister.c and register.obj are no longer used.
guy [Wed, 19 Apr 2006 16:02:09 +0000 (16:02 +0000)]
register.c and register.obj are no longer used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17908 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThe rule makes plugin.c, not register.c.
guy [Wed, 19 Apr 2006 10:44:11 +0000 (10:44 +0000)]
The rule makes plugin.c, not register.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17907 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoregister.c isn't generated any more, plugin.c is.
guy [Wed, 19 Apr 2006 10:23:49 +0000 (10:23 +0000)]
register.c isn't generated any more, plugin.c is.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17906 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix bugs in the previous checkin.
guy [Wed, 19 Apr 2006 10:21:55 +0000 (10:21 +0000)]
Fix bugs in the previous checkin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17905 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate comments.
guy [Wed, 19 Apr 2006 09:52:23 +0000 (09:52 +0000)]
Update comments.

Fix the Makefile.nmake files to pass the output type argument to
make-reg-dotc or make-reg-dotc.py.

Make tools/make-reg-dotc executable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17904 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoHave make-reg-dotc and make-reg-dotc.py generate either a register.c for
guy [Wed, 19 Apr 2006 09:26:16 +0000 (09:26 +0000)]
Have make-reg-dotc and make-reg-dotc.py generate either a register.c for
libetheral or a plugin.c for a plugin, rather than having plugin.c for a
dissector call the routines from register.c.  This means we don't ahve
multiple register_all_protocols() and register_all_protocol_handoffs()
routines, and that all the plugin boilerplate is automatically
generated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17903 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom W.Borgert:
etxrab [Wed, 19 Apr 2006 05:17:46 +0000 (05:17 +0000)]
From W.Borgert:

this patch leads to a more condensed representation of strings in the GIOP module, e.g. in Parlay instead of having:

length = 42
TpAddress_AddrString = sip:anyone@somebody.thehost.whose.es:5432

you have now:

TpAddress_AddrString (42) = sip:anyone@somebody.thehost.whose.es:5432

The former was not as concise, if you have a lot of strings (as in CosNaming) and it was not clear whether the protocol had a explicit field named "length" in the IDL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17902 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThe first item in the network load EIP appears to be the network
guy [Wed, 19 Apr 2006 03:42:06 +0000 (03:42 +0000)]
The first item in the network load EIP appears to be the network
utilization, in units of .1%.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17901 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix Bug http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=677 megaco.dll can not...
etxrab [Tue, 18 Apr 2006 21:08:14 +0000 (21:08 +0000)]
Fix Bug bugs.ethereal.com/bugzilla/show_bug.cgi?id=677 megaco.dll can not handle lowcase descriptor

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17900 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix for bug 875. Adding description for groups 19-26.
jake [Tue, 18 Apr 2006 11:52:28 +0000 (11:52 +0000)]
Fix for bug 875. Adding description for groups 19-26.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17895 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom W. Borgert:
jake [Tue, 18 Apr 2006 10:04:18 +0000 (10:04 +0000)]
From W. Borgert:
Currently, the filename IOR.txt is hardcoded into ethereal.
The patch allows the user to change it. Thanks for applying!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17894 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agonote that the stream content of the follow TCP stream dialog won't be updated while...
ulfl [Tue, 18 Apr 2006 08:34:08 +0000 (08:34 +0000)]
note that the stream content of the follow TCP stream dialog won't be updated while doing a live capture

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17893 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix a make display bug
ulfl [Tue, 18 Apr 2006 00:55:06 +0000 (00:55 +0000)]
fix a make display bug

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17892 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix a syntax error
ulfl [Tue, 18 Apr 2006 00:42:52 +0000 (00:42 +0000)]
fix a syntax error

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17891 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomove all the incomplete chapters to the end of the file
ulfl [Tue, 18 Apr 2006 00:40:10 +0000 (00:40 +0000)]
move all the incomplete chapters to the end of the file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17890 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agovarious enhancements and modifications to clarify the advanced topics
ulfl [Tue, 18 Apr 2006 00:38:57 +0000 (00:38 +0000)]
various enhancements and modifications to clarify the advanced topics

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17889 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGive more information about time zones - several capture file formats
guy [Mon, 17 Apr 2006 21:44:26 +0000 (21:44 +0000)]
Give more information about time zones - several capture file formats
use local time, not UTC.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17888 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix capitalization to follow GNOME HIG
ulfl [Mon, 17 Apr 2006 21:13:09 +0000 (21:13 +0000)]
fix capitalization to follow GNOME HIG

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17887 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Martin Mathieson:
etxrab [Mon, 17 Apr 2006 18:46:14 +0000 (18:46 +0000)]
From Martin Mathieson:

These patches:
- fix the bounds errors reported by coverity in bug 879
- fix a couple of other potential bounds errors (length checking 1st & 2nd lines in file)
- reorder catapult_dct2000_phdr so that normal protocol pseudo-header info is at the start.  This means that the stub dissector can avoid the nasty
(overlapped) memcpy
- a little whitespace fixing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17886 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom W. Borgert:
etxrab [Mon, 17 Apr 2006 18:10:23 +0000 (18:10 +0000)]
From W. Borgert:
- Regenerated files.
- Use .sort() on one or two of the lists in ethereal_gen.py to make generated files
  more diff-friendly in the future.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17885 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Thomas Anders:
jake [Mon, 17 Apr 2006 08:38:08 +0000 (08:38 +0000)]
From Thomas Anders:
- allow DHCP option 43 suboption 8 (OUI) for CableLabs clients to be a 6-byte string (as required for DOCSIS CMs) to
  account for inconsistencies in different CableLabs specifications
- add new DHCP option 60 fields 0x0d (IP Filters Support) and 0x0e (LLC Filters Support) for CableLabs DOCSIS 2.0 CMs
- rename PKT_CM_* variables to have a DOCS_CM prefix instead (overdue, as indicated by an existing comment)
- update specification references

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17884 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPull the plugin-specific code into "plugin.c", and generate a
guy [Mon, 17 Apr 2006 05:44:00 +0000 (05:44 +0000)]
Pull the plugin-specific code into "plugin.c", and generate a
"register.c" with "make-reg-dotc"/"make-reg-dotc.py".

Pull the lists of dissector .c and .h files into Makefile.common and
have Makefile.am and Makefile.nmake use it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17883 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomake-reg-dotc and make-reg-dotc.py were moved.
guy [Mon, 17 Apr 2006 02:11:04 +0000 (02:11 +0000)]
make-reg-dotc and make-reg-dotc.py were moved.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17882 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMove "make-reg-dotc" and "make-reg-dotc.py" to the "tools" directory, so
guy [Mon, 17 Apr 2006 00:41:54 +0000 (00:41 +0000)]
Move "make-reg-dotc" and "make-reg-dotc.py" to the "tools" directory, so
that it can more easily be used when building plugins.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17881 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom W. Borgert:
etxrab [Sun, 16 Apr 2006 23:16:46 +0000 (23:16 +0000)]
From W. Borgert:
the attached patch enables the explicit GIOP dissection. This fixes erronous decoding, if methods of two different CORBA interfaces have the same name, which happens frequently.

The generated GIOP plugins (CosEvent, CosNaming, Parlay, Tango) need to be re-generated to make use of the fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17880 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRe-UTF-8-ify.
guy [Sun, 16 Apr 2006 22:58:12 +0000 (22:58 +0000)]
Re-UTF-8-ify.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17879 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCalculate Timezone correctly fixes http://bugs.ethereal.com/bugzilla/show_bug.cgi...
etxrab [Sun, 16 Apr 2006 22:48:47 +0000 (22:48 +0000)]
Calculate Timezone correctly fixes bugs.ethereal.com/bugzilla/show_bug.cgi?id=876

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17878 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Steve Karg:
jake [Sun, 16 Apr 2006 22:03:04 +0000 (22:03 +0000)]
From Steve Karg:
1) BACnet signed values were being decoded incorrectly for negative
values since BACnet tries to be clever and minimizes the number of bytes
sent on the wire and drops the leading FF on negative values.  For
example, -200 is passed as FF 38 on the wire, but would display as 65336.
2) Since the BACnet unsigned values were decoded using a 64-bit entity,
I changed the decoding such that allows all 8 bytes to be decoded.  The
function can now decode 5, 6, and 7 byte values.
3) Corrected warning about signed/unsigned in a pointer parameter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17877 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSquelch a compiler warning.
guy [Sun, 16 Apr 2006 22:00:11 +0000 (22:00 +0000)]
Squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17876 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agobssgp - handle LLC PDU of 0 length.
etxrab [Sun, 16 Apr 2006 19:14:21 +0000 (19:14 +0000)]
bssgp - handle LLC PDU of 0 length.
Gsm_a - radio pri included in Modify PDP context request.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17875 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThe code to read hcidump files sets the p2p pseudo-header for
guy [Sun, 16 Apr 2006 10:54:32 +0000 (10:54 +0000)]
The code to read hcidump files sets the p2p pseudo-header for
WTAP_ENCAP_BLUETOOTH_H4.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17874 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of the unused WTAP_ENCAP value - holes in the number space cause
guy [Sun, 16 Apr 2006 10:38:47 +0000 (10:38 +0000)]
Get rid of the unused WTAP_ENCAP value - holes in the number space cause
ugly printouts for "editcap -T".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17873 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some missing little-endianizing.
guy [Sun, 16 Apr 2006 02:59:49 +0000 (02:59 +0000)]
Add some missing little-endianizing.

Get rid of some unnecessary casts.

Multiply seconds by 10^9, not 10^6, to get nanoseconds.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17872 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd a loop to process TLVs in the file header.
guy [Sun, 16 Apr 2006 02:04:42 +0000 (02:04 +0000)]
Add a loop to process TLVs in the file header.

Advertise nanosecond resolution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17871 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMove file format definitions to the header file.
guy [Sun, 16 Apr 2006 00:52:36 +0000 (00:52 +0000)]
Move file format definitions to the header file.

Put the code to read the packet header and the packet data into routines
(which also fixes some places where observer_seek_read() was using the
sequential file handle rather than the random file handle), make the
packet header reader skip over the TLVs,

Do some additional sanity checking.

Wiretap supports nanosecond resolution; provide nanosecond resolution
time stamps.

Rename some structure members to match their purpose (they're TLV
counts, not flags).

Remove the TLV header from the TLV structures (and eliminate TLV
structures if we don't have the contents or they're just a string); if
we process them, we'll probably end up reading the header and data
separately.

Add some information about some of the TLVs in expert information packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17870 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSake Blok wrote....
jake [Sat, 15 Apr 2006 19:00:42 +0000 (19:00 +0000)]
Sake Blok wrote....
I have taken a look at the trace myself and calculated the TpS to be
20000000.0 for this particular trace. If I also discard the start_timestamp
like it has been done for other versions of the netxray format, then I get
the proper results.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17869 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some missing commands.
etxrab [Sat, 15 Apr 2006 18:41:39 +0000 (18:41 +0000)]
Add some missing commands.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17868 f5534014-38df-0310-8fa8-9805f1628bb7