14 years agoDon't remove a preference, make it obsolete instead.
jake [Mon, 6 Nov 2006 11:41:02 +0000 (11:41 +0000)]
Don't remove a preference, make it obsolete instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19818 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosome compilers dont like unnamed unions and structs
sahlberg [Mon, 6 Nov 2006 09:30:15 +0000 (09:30 +0000)]
some compilers dont like unnamed unions and structs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19817 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix the return value of file_seek, as noted by Steve
ulfl [Mon, 6 Nov 2006 00:24:24 +0000 (00:24 +0000)]
fix the return value of file_seek, as noted by Steve

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19816 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19553 to 19565
jmayer [Sun, 5 Nov 2006 23:33:28 +0000 (23:33 +0000)]
Update from samba tree revision 19553 to 19565
============================ Samba log start ============
r19553 | jelmer | 2006-11-04 16:40:05 +0100 (Sat, 04 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm

Add check for correct API usage.

r19557 | jelmer | 2006-11-04 21:24:35 +0100 (Sat, 04 Nov 2006) | 3 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Fix lookup table for WERROR.
Fix perl warnings when using NTSTATUS as return type.

r19559 | jelmer | 2006-11-04 22:53:00 +0100 (Sat, 04 Nov 2006) | 3 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Fix handling of types where the name isn't prefixed by the interface name.
Based on patch by Julien Kerihuel.

r19560 | jelmer | 2006-11-05 01:03:44 +0100 (Sun, 05 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Fix handling of PARAM_VALUE.

r19561 | jelmer | 2006-11-05 01:08:39 +0100 (Sun, 05 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Remove debug statement.

r19562 | jelmer | 2006-11-05 01:26:44 +0100 (Sun, 05 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Support returning simple scalars.

============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19815 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange all file offsets from long to gint64 so we can - theoretically - handle files...
ulfl [Sun, 5 Nov 2006 22:46:44 +0000 (22:46 +0000)]
change all file offsets from long to gint64 so we can - theoretically - handle files > 2GB correct.

Please distclean Win32 builds!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19814 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Albert Chin
jake [Sun, 5 Nov 2006 22:31:57 +0000 (22:31 +0000)]
From Albert Chin
The IBM C compiler on AIX 4.3.3 doesn't accept a trailing comma after
the last enum definition. Patch attached for stat_menu.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19813 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd HP Switch Protocol SAP value
jake [Sun, 5 Nov 2006 18:26:21 +0000 (18:26 +0000)]
Add HP Switch Protocol SAP value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19812 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix svn728: don't scroll down packet list while capturing, if no packets are newly...
ulfl [Sun, 5 Nov 2006 13:47:17 +0000 (13:47 +0000)]
fix svn728: don't scroll down packet list while capturing, if no packets are newly displayed (happens when a display filter is active)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19811 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTidy up of information column for NTLM authentication.
gal [Sun, 5 Nov 2006 12:15:52 +0000 (12:15 +0000)]
Tidy up of information column for NTLM authentication.
Related to Bug 1148.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19810 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowe used the wrong offset for attribute lists, fixed
sahlberg [Sun, 5 Nov 2006 11:19:46 +0000 (11:19 +0000)]
we used the wrong offset for attribute lists,   fixed

add decoding for attribute lists for another instance where these blobs appear in the data in/out buffers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19809 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago add a framework to manage dissection of osd attribute pages, attribute number and...
sahlberg [Sun, 5 Nov 2006 10:48:53 +0000 (10:48 +0000)]
 add a framework to manage dissection of osd attribute pages, attribute number and name and dissectors for them.

implement the dissector for attribute page 1 (user object info) number 82 (logical length) as an example.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19808 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodissect the Get Attributes List Offset according to the really weird encoding in...
sahlberg [Sun, 5 Nov 2006 07:59:20 +0000 (07:59 +0000)]
dissect the Get Attributes List Offset according to the really weird encoding in 4.12.5

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19807 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoregenerate NSPI using the latest version of pidl
sahlberg [Sun, 5 Nov 2006 06:12:24 +0000 (06:12 +0000)]
regenerate NSPI using the latest version of pidl

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19806 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoupdate the Makefile to point to the new path after the svn move
sahlberg [Sun, 5 Nov 2006 06:00:01 +0000 (06:00 +0000)]
update the Makefile to point to the new path after the svn move

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19805 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agorename the nspi dissector from idl (where the idl2wrs dissectors live) ro epan/dissec...
sahlberg [Sun, 5 Nov 2006 05:56:27 +0000 (05:56 +0000)]
rename the nspi dissector from idl (where the idl2wrs dissectors live) ro epan/dissector/pidl  (where the pidl generated dce/rpc dissectors live)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19804 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd tracking of policy handles to the efs dissector
sahlberg [Sun, 5 Nov 2006 05:35:06 +0000 (05:35 +0000)]
add tracking of policy handles to the efs dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19803 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd packet-dcerpc-nspi.h to the distribution.
gerald [Sun, 5 Nov 2006 05:33:53 +0000 (05:33 +0000)]
Add packet-dcerpc-nspi.h to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19802 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd tracking of policy_handles to the eventlog dissector
sahlberg [Sun, 5 Nov 2006 05:21:33 +0000 (05:21 +0000)]
add tracking of policy_handles to the eventlog dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19801 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agotesting out latest pidl where PARAM values can be used to track policy handles properly
sahlberg [Sun, 5 Nov 2006 04:49:20 +0000 (04:49 +0000)]
testing out latest pidl where PARAM values can be used to track policy handles properly

winreg now tracks also where policy handles were closed    which previously didnt work properly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19800 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoit is GtkText in gtk-1.x not GtkTextView
sahlberg [Sun, 5 Nov 2006 04:38:47 +0000 (04:38 +0000)]
it is GtkText in gtk-1.x   not GtkTextView

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19799 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake the routines that manipulate the hex/text display window take a
guy [Sun, 5 Nov 2006 00:54:17 +0000 (00:54 +0000)]
Make the routines that manipulate the hex/text display window take a
GtkWidget * as an argument, rather than a version-of-GTK+-dependent
pointer; that way, we need fewer #ifdefs.

Use WIDGET_SET_SIZE() instead of #ifdeffed code using
gtk_widget_set_usize() or gtk_widget_set_size_request() -
WIDGET_SET_SIZE() was created to encapsulate that GTK+ 1.2[.x] vs. 2.x

Make some variables not used outside gtk/main.c static.

Clean up white space.

Clean up handling of return value from load_airpcap() a bit.

Use one big #ifdef HAVE_AIRPCAP/#endif for all the AirPcap stuff in

Attach _U_ to the unused arguments to driver_warning_dialog_cb(), not to
the arguments that are being used - and don't include it at all if
HAVE_AIRPCAP isn't defined, as it's not used in that case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19798 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Dave Richards
sahlberg [Sat, 4 Nov 2006 21:19:14 +0000 (21:19 +0000)]
from Dave Richards

Here is a patch to fix a problem with notification parameters.  Fix is:

Remove premature return statements from fNotificationParameters.

The real problem is that the original code is inconsistent about putting
a break in all cases of the switch blocks and some were falling through
to the default case where there was a return.  I took the simple route
and removed the unnecessary returns - they were OK for default case but
not for the fall through.

Is there a standard about having breaks?  If it is desired to have a
consistent coding style I will further update the code to conform.
Otherwise, could someone please commit this change as it does fix the bug?


Dave Richards

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19797 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoxxx_PROGRAMS variables have the name of the program without $(EXEEXT).
guy [Sat, 4 Nov 2006 20:37:16 +0000 (20:37 +0000)]
xxx_PROGRAMS variables have the name of the program without $(EXEEXT).

Update Gerald's address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19796 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agopropset...
jmayer [Sat, 4 Nov 2006 18:00:29 +0000 (18:00 +0000)]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19795 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoJulien Kerihuel:
jmayer [Sat, 4 Nov 2006 17:44:37 +0000 (17:44 +0000)]
Julien Kerihuel:

The new version of the dissector will compile without any patches to apply to
Wireshark/NDR.pm. Jelmer has improved the patch and pidl now support enums as
return type. Regarding the nspi.cnf file, it won't be useful anymore.

Regarding the dissector, I've noticed a bug in NspiGetMatches which isn't
dumped correctly. I'm currently investigating the problem and I'll notify the
list when a fixed version is available.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19794 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19540 to 19553
jmayer [Sat, 4 Nov 2006 16:57:21 +0000 (16:57 +0000)]
Update from samba tree revision 19540 to 19553
============================ Samba log start ============
r19541 | jelmer | 2006-11-03 20:55:17 +0100 (Fri, 03 Nov 2006) | 3 lines

Explicitly segfault when the API is being used incorrectly. Previously
this would've caused a silent premature return.

r19544 | jelmer | 2006-11-04 00:08:33 +0100 (Sat, 04 Nov 2006) | 2 lines

Fix case of 'warning'.

r19545 | jelmer | 2006-11-04 02:53:29 +0100 (Sat, 04 Nov 2006) | 2 lines

Allow enums as return types in code generated for wireshark. Originally based on a patch by Julien Kerihuel.

r19546 | jelmer | 2006-11-04 03:51:03 +0100 (Sat, 04 Nov 2006) | 3 lines

fix number of bytes pushed when using switch_type() set to enum types.
die() on invalid used of enum_type_fn()

r19547 | jelmer | 2006-11-04 03:54:24 +0100 (Sat, 04 Nov 2006) | 2 lines

Fix use of v1_enum on enums used in return types.

r19553 | jelmer | 2006-11-04 16:40:05 +0100 (Sat, 04 Nov 2006) | 2 lines

Add check for correct API usage.

============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19793 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGeneral updates to:
gal [Sat, 4 Nov 2006 09:14:54 +0000 (09:14 +0000)]
General updates to:
*) Remove maximum LDAP PDU size check - they can get large with either large attributes (e.g. CRLs, SPIFs) or with lots of results (see http://www.wireshark.org/lists/wireshark-users/200610/msg00197.html). The max size preference is also removed.
*) Support for dissecting LDAP controls including server side sorting and paged results. A new BER function is introduced to see if there is a dissector for a given OID.
*) Remove reference to removed BER preference in the LDAP reassembly preference.
*) Mark a LDAPURL as a URL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19792 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom SF
sahlberg [Sat, 4 Nov 2006 08:54:45 +0000 (08:54 +0000)]
From SF

Attached is a fix for bug #1156: "If a dissector depends on a new
datasource created by a new tvb, that dissector's protocol can't be
filtered on."


I change the code slightly to avoid dereferenceing a NULL pointer.
While the original code was fine and safe on unix   dereferencing a null pointer in this way would be unsafe and cause a segmentation violation on windows   if tree is NULL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19791 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to U3 packaging to:
gal [Sat, 4 Nov 2006 08:01:44 +0000 (08:01 +0000)]
Update to U3 packaging to:
*) Assign a new UUID for version 0.99.5 (so different versions of Wireshark can be installed on one U3 device)
*) Include version number in U3 program name to allow user to differentiate versions
*) Catch up with packaging changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19790 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix distcheck.
gerald [Sat, 4 Nov 2006 00:35:04 +0000 (00:35 +0000)]
Fix distcheck.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19789 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosplit subversion into command line and GUI (TortoiseSVN) client
ulfl [Fri, 3 Nov 2006 22:39:28 +0000 (22:39 +0000)]
split subversion into command line and GUI (TortoiseSVN) client

update various version infos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19788 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't forget to uninstall pango\1.5.0, we might want to have something like this...
ulfl [Fri, 3 Nov 2006 22:12:57 +0000 (22:12 +0000)]
don't forget to uninstall pango\1.5.0, we might want to have something like this checked by the buildbot to prevent such problems

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19787 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDissect h324ext_h223lcparm.
etxrab [Fri, 3 Nov 2006 20:15:17 +0000 (20:15 +0000)]
Dissect h324ext_h223lcparm.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19786 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd $(EXEXT) after references to the Lemon executable.
guy [Fri, 3 Nov 2006 18:39:03 +0000 (18:39 +0000)]
Add $(EXEXT) after references to the Lemon executable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19785 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate the Windows icons. Use the document icon for capture files.
gerald [Fri, 3 Nov 2006 15:54:12 +0000 (15:54 +0000)]
Update the Windows icons.  Use the document icon for capture files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19784 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 18675 to 19540
jmayer [Fri, 3 Nov 2006 15:10:17 +0000 (15:10 +0000)]
Update from samba tree revision 18675 to 19540
============================ Samba log start ============
svn: When specifying working copy paths, only one target may be given
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19783 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFixes ./autogen.sh on Mac OS X...
tuexen [Fri, 3 Nov 2006 10:12:36 +0000 (10:12 +0000)]
Fixes ./autogen.sh on Mac OS X...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19782 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBump the version to 0.99.5.
gerald [Fri, 3 Nov 2006 06:55:30 +0000 (06:55 +0000)]
Bump the version to 0.99.5.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19781 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTouch up the glossy highlight in the main icon. Split "wsiconcap" into
gerald [Fri, 3 Nov 2006 06:30:52 +0000 (06:30 +0000)]
Touch up the glossy highlight in the main icon.  Split "wsiconcap" into
"capture-in-progress" and "document" icons.  Update the highlight in
each of them as well.  Resize and rename the 200-pixel icons to 256.
Add a script to generate icons from their canonical sources.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19780 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nicolas Dichtel:
jake [Thu, 2 Nov 2006 16:47:13 +0000 (16:47 +0000)]
From Nicolas Dichtel:
here is a patch that transforms "valid lifetime" and "prefered lifetime" in a prefix option (in RA)
in human readable format. Following the RFC2461 Section 4.6.2, if the value is 0xffffffff, this means lifetime
is infinity.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19779 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't try to report -ve roundtrip delays
martinm [Thu, 2 Nov 2006 11:51:09 +0000 (11:51 +0000)]
Don't try to report -ve roundtrip delays

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19778 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrederic Heem:
jmayer [Thu, 2 Nov 2006 09:45:12 +0000 (09:45 +0000)]
Frederic Heem:
 Fix some memleaks and overflows.

I haven't committed the changes that are not bug fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19777 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowe don't support 95/98/ME any longer, and indeed WS doesn't work on these versions.
ulfl [Thu, 2 Nov 2006 09:36:47 +0000 (09:36 +0000)]
we don't support 95/98/ME any longer, and indeed WS doesn't work on these versions.

Give a hint that the last known working version was Ethereal 0.99.0 and quit the installer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19776 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd idl2wrs.sh to svn:ignore
jmayer [Thu, 2 Nov 2006 09:30:12 +0000 (09:30 +0000)]
add idl2wrs.sh to svn:ignore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19775 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoZhu Yi:
jmayer [Thu, 2 Nov 2006 09:26:38 +0000 (09:26 +0000)]
Zhu Yi:

ieee80211e dissect patch

Fix signedness warnings regarding ssid and ccode.
(in the old code, not in the 11e code)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19774 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to fix bug 1043.
jmayer [Thu, 2 Nov 2006 08:52:25 +0000 (08:52 +0000)]
Try to fix bug 1043.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19773 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBug 1053: New SNMP filtering is broken
kukosa [Thu, 2 Nov 2006 08:48:58 +0000 (08:48 +0000)]
Bug 1053: New SNMP filtering is broken
Do not try to parse OID as hexbytes string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19772 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a warning: "airpcap_loader.c(2287) : warning C4700: local variable 'ad' used...
ulfl [Wed, 1 Nov 2006 23:22:13 +0000 (23:22 +0000)]
fix a warning: "airpcap_loader.c(2287) : warning C4700: local variable 'ad' used without having been initialized"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19771 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd h324_muxtbl_out
etxrab [Wed, 1 Nov 2006 23:01:14 +0000 (23:01 +0000)]
Add h324_muxtbl_out

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19770 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHandle RFC 3267 Bandwidth-efficient mode.
etxrab [Wed, 1 Nov 2006 22:58:41 +0000 (22:58 +0000)]
Handle RFC 3267 Bandwidth-efficient mode.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19769 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd same license info as in Check64BitFormat.cmake
jmayer [Wed, 1 Nov 2006 22:22:27 +0000 (22:22 +0000)]
Add same license info as in Check64BitFormat.cmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19768 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThrow an exception if we try to add more than a million items to the tree.
gerald [Wed, 1 Nov 2006 20:32:23 +0000 (20:32 +0000)]
Throw an exception if we try to add more than a million items to the tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19767 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoupdate the list of defined application classes and list all the official ones from...
sahlberg [Wed, 1 Nov 2006 09:54:48 +0000 (09:54 +0000)]
update the list of defined application classes and list all the official ones from usb.org

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19766 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoconsole.lua missing from the svn tarball preventing making a package. I hope this
etxrab [Tue, 31 Oct 2006 22:28:50 +0000 (22:28 +0000)]
console.lua missing from the svn tarball preventing making a package. I hope this
is the right way to fix it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19764 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen processing '-G fields', ignore the "proto_tree_add_text"
gram [Tue, 31 Oct 2006 22:00:41 +0000 (22:00 +0000)]
When processing '-G fields', ignore the "proto_tree_add_text"
pseudo-field by looking at the ID for hf_text_only. Apparently
some fields really don't have 'name' fields, but we still want
their info to be dumped out.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19763 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agovalue_string arrays need to be terminated with a {0, NULL}.
gram [Tue, 31 Oct 2006 21:43:48 +0000 (21:43 +0000)]
value_string arrays need to be terminated with a {0, NULL}.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19762 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoProvide field names for fields with true/false values so they
gram [Tue, 31 Oct 2006 21:29:34 +0000 (21:29 +0000)]
Provide field names for fields with true/false values so they
can be searched on.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19761 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoshow "Disconnect request" in the info column for disconnects
sahlberg [Tue, 31 Oct 2006 21:25:31 +0000 (21:25 +0000)]
show "Disconnect request" in the info column for disconnects

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19760 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe protocol must be registered before its fields, so that
gram [Tue, 31 Oct 2006 21:15:38 +0000 (21:15 +0000)]
The protocol must be registered before its fields, so that
proto_registrar_dump_fields() knows the relationship.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19759 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoprettify the info column and add a generated item for the type (read/write) to respon...
sahlberg [Tue, 31 Oct 2006 21:13:46 +0000 (21:13 +0000)]
prettify the info column and add a generated item for the type (read/write) to response packets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19758 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix another typowq
jmayer [Tue, 31 Oct 2006 14:49:11 +0000 (14:49 +0000)]
Fix another typowq

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19756 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRepeat after me: Test submission before sending.
jmayer [Tue, 31 Oct 2006 14:47:34 +0000 (14:47 +0000)]
Repeat after me: Test submission before sending.
Repeat after me: Test patches before committing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19755 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOrder ethertypes by number - no other changes
jmayer [Tue, 31 Oct 2006 14:36:32 +0000 (14:36 +0000)]
Order ethertypes by number - no other changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19754 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRobert Schwebel:
jmayer [Tue, 31 Oct 2006 11:35:55 +0000 (11:35 +0000)]
Robert Schwebel:
  Fix for http://bugs.wireshark.org/bugzilla/attachment.cgi?id=419&action=view
  cross compilation fails

With the following change: Use only AC_CANONICAL_TARGET

From the autoconf manual:
     The user is encouraged to use either `AC_CANONICAL_BUILD', or
     `AC_CANONICAL_HOST', or `AC_CANONICAL_TARGET', depending on the
     needs.  Using `AC_CANONICAL_TARGET' is enough to run the two other

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19753 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago new protocol NBD NetworkBlockDevice
sahlberg [Tue, 31 Oct 2006 11:16:01 +0000 (11:16 +0000)]
 new protocol NBD   NetworkBlockDevice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19752 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange the signature for the get_pdu_len() function pointer passed to tcp_dissect_pdu...
sahlberg [Tue, 31 Oct 2006 09:29:07 +0000 (09:29 +0000)]
change the signature for the get_pdu_len() function pointer passed to tcp_dissect_pdus() to also include a packet_info pointer.

there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19751 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoEscape non-ASCII characters in the client and server protocol version strings.
gerald [Tue, 31 Oct 2006 01:46:59 +0000 (01:46 +0000)]
Escape non-ASCII characters in the client and server protocol version strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19748 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Giorgio Tino: Add a "Don't show this message again" option to an
gerald [Tue, 31 Oct 2006 01:44:11 +0000 (01:44 +0000)]
From Giorgio Tino:  Add a "Don't show this message again" option to an
AirPcap warning dialog.  Fix a callback bug in simple_dialog.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19747 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake sure we round up to the nearest 4-byte boundary before trying to process
gerald [Tue, 31 Oct 2006 01:28:29 +0000 (01:28 +0000)]
Make sure we round up to the nearest 4-byte boundary before trying to process
the FCS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19746 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrederic heem:
jmayer [Mon, 30 Oct 2006 18:38:14 +0000 (18:38 +0000)]
frederic heem:

Please find the patch that adds copyrights.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19744 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gennady Feldman:
jake [Mon, 30 Oct 2006 18:25:44 +0000 (18:25 +0000)]
From Gennady Feldman:
Here is an updated patch. Should be pretty safe. Just added a couple of constants and changed some strings to be cleaner and easier to read.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19743 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agocarsten.prescher@eads.com:
jmayer [Mon, 30 Oct 2006 18:17:10 +0000 (18:17 +0000)]

Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1114
@SHELL@ not replaced in idl2wrs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19742 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 1164 from Stephen Fisher: In the coloring rules edit dialog, set
gerald [Mon, 30 Oct 2006 16:01:40 +0000 (16:01 +0000)]
Fix for bug 1164 from Stephen Fisher: In the coloring rules edit dialog, set
the foreground color correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19740 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoA little prettifying:
martinm [Mon, 30 Oct 2006 15:36:40 +0000 (15:36 +0000)]
A little prettifying:
- Most Router Advertisement fields are now properly filterable
- Option tree has improved label, length set, fixed fields filterable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19739 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agostart splitting the monolitic scsi dissector up into commandset dissectors
sahlberg [Mon, 30 Oct 2006 12:18:29 +0000 (12:18 +0000)]
start splitting the monolitic scsi dissector up into commandset dissectors

split the MMC commandset out of the main scsi dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19738 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for (already-closed) bug 1180
martinm [Mon, 30 Oct 2006 09:50:39 +0000 (09:50 +0000)]
Fix for (already-closed) bug 1180

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19737 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Giorgio Tino: Add support for version 2.0 of the AirPcap driver,
gerald [Mon, 30 Oct 2006 06:34:31 +0000 (06:34 +0000)]
From Giorgio Tino: Add support for version 2.0 of the AirPcap driver,
which has an updated API for WEP key handling.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19736 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #1159 from Jim Young (should go into 0.99.4):
ulfl [Mon, 30 Oct 2006 02:09:59 +0000 (02:09 +0000)]
fix #1159 from Jim Young (should go into 0.99.4):
I think I have a fix for this problem.   The procedure
packet_list_set_selected_row()would do a clist freeze but not a corresponding
clist thaw if the list was empty.  A one line fix to gtk/packet_list.c appears
to fix this problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19735 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom sake blok
sahlberg [Sun, 29 Oct 2006 21:01:57 +0000 (21:01 +0000)]
from sake blok


The attached file is a patch to packet-bpdu.c so that Wireshark is
able to dissect the Cisco MST BPDU's that I encountered last week.



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19734 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Stephen fischer
sahlberg [Sun, 29 Oct 2006 20:56:00 +0000 (20:56 +0000)]
from Stephen fischer

Attached is a patch to fix bug #1163: "Dissector bug. ISO8073 COTP
protocol."  The SES dissector was incorrectly believing it had PDUs
within the COTP PDUs.  I added an additional heuristic check to see if
the length of the SES PDU is 0, then return false since it can't be zero


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19733 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a typo in the recent change to the hhc.exe command line, so the chm files compile...
ulfl [Sun, 29 Oct 2006 19:47:59 +0000 (19:47 +0000)]
fix a typo in the recent change to the hhc.exe command line, so the chm files compile again - took me more than an hour to find out and reproduce :-(

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19732 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Roger Gottsponer:
jake [Sun, 29 Oct 2006 19:14:31 +0000 (19:14 +0000)]
From Roger Gottsponer:
During troubleshooting an ARP problem, I found an issue with wireshark
to properly recognise Gratuitous ARP packets. Gratuitous ARP packets
can be made with ARP request or ARP reply packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19731 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoput every python script name into "" so the call won't fail on Win32 native python.
ulfl [Sun, 29 Oct 2006 17:19:52 +0000 (17:19 +0000)]
put every python script name into "" so the call won't fail on Win32 native python.

The problem is the slash in e.g.:

 @$(PYTHON) ../../tools/make-dissector-reg.py

is interpreted as an option instead of being part of the path.

I didn't wanted to use backslashes as this might introduce new problems with cygwin's python port.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19730 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Sake Blok:
ulfl [Sun, 29 Oct 2006 17:14:13 +0000 (17:14 +0000)]
from Sake Blok:

While I was reading the development guide I noticed a few typo's.
The attached patch fixes them (the patch is against revision 19724).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19729 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange the default GTK version from GTK2.6 to GTK2.8
ulfl [Sun, 29 Oct 2006 14:41:16 +0000 (14:41 +0000)]
change the default GTK version from GTK2.6 to GTK2.8

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19728 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomake the checksum fields visible for TCP and UDP
ulfl [Sun, 29 Oct 2006 13:53:07 +0000 (13:53 +0000)]
make the checksum fields visible for TCP and UDP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19727 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #1188: scroll the packet list to the bottom (in a running capture) *after* thawin...
ulfl [Sun, 29 Oct 2006 12:51:15 +0000 (12:51 +0000)]
fix #1188: scroll the packet list to the bottom (in a running capture) *after* thawing the list - otherwise the scrolling won't be done correctly

this one should go into 0.99.4 IMHO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19726 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher:
jake [Sun, 29 Oct 2006 11:50:30 +0000 (11:50 +0000)]
From Stephen Fisher:
Attached is a patch to allow the disabling of the UDP/UDPlite checksum
verification for cards that offload it and report it incorrectly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19725 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a glossy highlight.
gerald [Sun, 29 Oct 2006 05:55:04 +0000 (05:55 +0000)]
Add a glossy highlight.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19724 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe TCP options data is a byte array, not a character string.
guy [Sun, 29 Oct 2006 00:06:02 +0000 (00:06 +0000)]
The TCP options data is a byte array, not a character string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19723 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBased on RFC3488. This is a setup for RGMP dissection, a simple protocol bolted on...
jake [Sat, 28 Oct 2006 21:52:38 +0000 (21:52 +0000)]
Based on RFC3488. This is a setup for RGMP dissection, a simple protocol bolted on IGMP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19722 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Pierre Juhen:
jake [Sat, 28 Oct 2006 21:32:38 +0000 (21:32 +0000)]
From Pierre Juhen:
I would like to have a tcp.options field with a name for PMDL output;
I include a patch to packet-tcp.c to provide that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19721 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet AirpcapLoaded to TRUE if we've successfully loaded our DLL and obtained
gerald [Fri, 27 Oct 2006 20:33:19 +0000 (20:33 +0000)]
Set AirpcapLoaded to TRUE if we've successfully loaded our DLL and obtained
our addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19720 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAllow each program called by the Docbook Makefile to be specified using
gerald [Fri, 27 Oct 2006 19:15:57 +0000 (19:15 +0000)]
Allow each program called by the Docbook Makefile to be specified using
the environment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19719 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCast away most remaining warnings.
martinm [Fri, 27 Oct 2006 14:36:48 +0000 (14:36 +0000)]
Cast away most remaining warnings.
2 will remain, because the 'needle' arg in tvb_pbrk_guint8() isn't const...  Should it be?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19717 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore warnings
martinm [Fri, 27 Oct 2006 13:03:38 +0000 (13:03 +0000)]
More warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19716 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix the GTK-WIMP paths for GTK2.8 - both source and destination paths completely...
ulfl [Fri, 27 Oct 2006 12:06:13 +0000 (12:06 +0000)]
fix the GTK-WIMP paths for GTK2.8 - both source and destination paths completely changed from 2.6 to 2.8 due to the integration of Wimp into the main GTK repository

remove settings for GTK2.2 and 2.4 in config.nmake - as no one uses it IMHO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19715 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen key length wrong, show expected value.
martinm [Fri, 27 Oct 2006 10:16:22 +0000 (10:16 +0000)]
When key length wrong, show expected value.
Fix Preference label where %d was missing from specifier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19714 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a lot of sanity checks, particularly to get_airpcap_interface_list(),
gerald [Thu, 26 Oct 2006 21:53:30 +0000 (21:53 +0000)]
Add a lot of sanity checks, particularly to get_airpcap_interface_list(),
which should fix bug 1176.  Fix up whitespace and indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19712 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix more Ubuntu warnings.
etxrab [Thu, 26 Oct 2006 21:31:48 +0000 (21:31 +0000)]
Fix more Ubuntu warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19711 f5534014-38df-0310-8fa8-9805f1628bb7