obnox/wireshark/wip.git
14 years agothe buildbot has a problem not knowing sa_family_t, define eth_sa_family_t and use...
ulfl [Tue, 20 Sep 2005 02:10:48 +0000 (02:10 +0000)]
the buildbot has a problem not knowing sa_family_t, define eth_sa_family_t and use it here (ok, this *is* a dirty hack)

don't know why the last commit compiled on my machine and not on the buildbot.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15887 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoenhance simple dialog: add the possibility to use no buttons at all and add a stop...
ulfl [Tue, 20 Sep 2005 01:53:38 +0000 (01:53 +0000)]
enhance simple dialog: add the possibility to use no buttons at all and add a stop icon (similar to the splash_window, but with a slightly different layout and a way to choose the icon shown)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15886 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a new stop icon 48x48 for (simple) dialogs (derived from the openoffice stock...
ulfl [Tue, 20 Sep 2005 01:45:35 +0000 (01:45 +0000)]
add a new stop icon 48x48 for (simple) dialogs (derived from the openoffice stock icons and slightly enlarged using the Gimp)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15885 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago avoid freeing the last location twice.
lego [Tue, 20 Sep 2005 00:31:53 +0000 (00:31 +0000)]
 avoid freeing the last location twice.

add some #ifed out code to help debugging the parser

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15884 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd svn:ignore from samba
jmayer [Mon, 19 Sep 2005 23:33:45 +0000 (23:33 +0000)]
Add svn:ignore from samba

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15883 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRevert back to local copy: The samba svn server does not support svn
jmayer [Mon, 19 Sep 2005 23:31:47 +0000 (23:31 +0000)]
Revert back to local copy: The samba svn server does not support svn
over http - this was a much requested feature for Ethereals svn server.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15882 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agopidl: Revert back to local copy. The samba svn server does not support svn
jmayer [Mon, 19 Sep 2005 23:29:03 +0000 (23:29 +0000)]
pidl: Revert back to local copy. The samba svn server does not support svn
over http - this was a much requested feature for Ethereal's svn server.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15881 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate faq
jmayer [Mon, 19 Sep 2005 21:24:46 +0000 (21:24 +0000)]
Update faq

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15880 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoJim Young: LLDP improvements
jmayer [Mon, 19 Sep 2005 21:24:07 +0000 (21:24 +0000)]
Jim Young: LLDP improvements

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15879 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #340: define the missing sockaddr_storage struct to be able to use Packet32.h...
ulfl [Mon, 19 Sep 2005 20:59:50 +0000 (20:59 +0000)]
fix #340: define the missing sockaddr_storage struct to be able to use Packet32.h even with WinPcap 3.1 and without the platform SDK

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15878 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSmall whitespace cleanup.
gerald [Mon, 19 Sep 2005 20:50:51 +0000 (20:50 +0000)]
Small whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15877 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThrow an exception instead of trying to read past the end of a buffer.
gerald [Mon, 19 Sep 2005 20:50:10 +0000 (20:50 +0000)]
Throw an exception instead of trying to read past the end of a buffer.
Fixes bug 455.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15876 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodisplay something useful in the radius VSA item
lego [Mon, 19 Sep 2005 19:48:55 +0000 (19:48 +0000)]
display something useful in the radius VSA item

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15875 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't dereference a null pointer. Fixes bug 460.
gerald [Mon, 19 Sep 2005 19:46:25 +0000 (19:46 +0000)]
Don't dereference a null pointer.  Fixes bug 460.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15874 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange "Value" into "VSA" for Vendor SPecific Attributes
lego [Mon, 19 Sep 2005 19:36:32 +0000 (19:36 +0000)]
Change "Value" into "VSA" for Vendor SPecific Attributes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15873 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a preference to decode different types of AMR payload.
etxrab [Mon, 19 Sep 2005 19:11:50 +0000 (19:11 +0000)]
Add a preference to decode different types of AMR payload.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15872 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThrow an exception if our ACL length is flat-out wrong.
gerald [Mon, 19 Sep 2005 17:50:38 +0000 (17:50 +0000)]
Throw an exception if our ACL length is flat-out wrong.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15871 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- allow multiple attributes inside one VSA (fixes bug 438)
lego [Mon, 19 Sep 2005 17:42:02 +0000 (17:42 +0000)]
- allow multiple attributes inside one VSA (fixes bug 438)
- preference to choose whether to add the AVP's payload length items
- preference to add an alternate UDP port

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15870 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn the SPNEGO dissector, don't call a subdissector if we don't have a TVB.
gerald [Mon, 19 Sep 2005 16:23:05 +0000 (16:23 +0000)]
In the SPNEGO dissector, don't call a subdissector if we don't have a TVB.
Fixes bugs 448, 449, 451, 452, 454, 456, and 461.

Add similar TVB checks to the BER dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15869 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange README to reflect the fact that tools/pidl is now a
jmayer [Mon, 19 Sep 2005 14:59:32 +0000 (14:59 +0000)]
Change README to reflect the fact that tools/pidl is now a
svn:externals reference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15868 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd svn:externals for pidl: That way svn up will pull the pidl sources
jmayer [Mon, 19 Sep 2005 14:53:46 +0000 (14:53 +0000)]
Add svn:externals for pidl: That way svn up will pull the pidl sources
directly from the samba svn instead of keeping a copy of them in the
Ethereal svn.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15867 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange pidl to svn:externals
jmayer [Mon, 19 Sep 2005 14:50:23 +0000 (14:50 +0000)]
Change pidl to svn:externals

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15866 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd idl_types.h from samba to fix warning
jmayer [Mon, 19 Sep 2005 13:26:49 +0000 (13:26 +0000)]
Add idl_types.h from samba to fix warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15865 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPoint to tools/pidl/README.ethereal
jmayer [Mon, 19 Sep 2005 09:23:52 +0000 (09:23 +0000)]
Point to tools/pidl/README.ethereal

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15864 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a typo.
guy [Mon, 19 Sep 2005 08:09:41 +0000 (08:09 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15863 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosometimes it seems that we have the text based h248/megaco running ontop of
sahlberg [Mon, 19 Sep 2005 08:06:25 +0000 (08:06 +0000)]
sometimes it seems that we have the text based h248/megaco running ontop of
m3ua  and not the binary one.

make the binary dissector check if it is really the text based one to be used and if so
call that dissector instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15862 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove unused parameter 'name' from dissect_per_choice()
kukosa [Mon, 19 Sep 2005 07:35:05 +0000 (07:35 +0000)]
remove unused parameter 'name' from dissect_per_choice()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15861 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSmall update
jmayer [Sun, 18 Sep 2005 21:58:39 +0000 (21:58 +0000)]
Small update

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15860 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate README.ethereal and sync with current samba tree
jmayer [Sun, 18 Sep 2005 21:57:59 +0000 (21:57 +0000)]
Update README.ethereal and sync with current samba tree

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15859 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoassert that tvb is not NULL
ulfl [Sun, 18 Sep 2005 20:11:54 +0000 (20:11 +0000)]
assert that tvb is not NULL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15858 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange some of the asn1 functions to use packet-ber ones.
etxrab [Sun, 18 Sep 2005 20:04:04 +0000 (20:04 +0000)]
Change some of the asn1 functions to use packet-ber ones.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15857 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf the tag field is a bitfield, always show it as such, otherwise always
guy [Sun, 18 Sep 2005 16:54:00 +0000 (16:54 +0000)]
If the tag field is a bitfield, always show it as such, otherwise always
show the value of 1 1111 as "Continued" in the bitfield and the actual
tag value in the following bytes.

Show the BER identifier data before an OID if we're showing internal BER
fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15856 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoas discussed in the Users list: replace "Short Frame" by "Packet size limited during...
ulfl [Sun, 18 Sep 2005 11:18:42 +0000 (11:18 +0000)]
as discussed in the Users list: replace "Short Frame" by "Packet size limited during capture" message

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15855 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd dtds to EXTRA_DIST
lego [Sun, 18 Sep 2005 09:10:03 +0000 (09:10 +0000)]
add dtds to EXTRA_DIST

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15854 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf unkown Tag's are found in a set add length.
etxrab [Sat, 17 Sep 2005 21:02:51 +0000 (21:02 +0000)]
If unkown Tag's are found in a set add length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15853 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet the first few dtds installed.
lego [Sat, 17 Sep 2005 17:17:42 +0000 (17:17 +0000)]
Get the first few dtds installed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15852 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBecause there's more than just text in XML...
lego [Sat, 17 Sep 2005 17:05:46 +0000 (17:05 +0000)]
Because there's more than just text in XML...

DTDs are imported to create fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15851 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agousing heur_dissector_add("cotp_is") doesn't seem to be enough, if H1 is used over...
ulfl [Sat, 17 Sep 2005 14:14:24 +0000 (14:14 +0000)]
using heur_dissector_add("cotp_is") doesn't seem to be enough, if H1 is used over TCP/TPKT (RFC1006). Add heur_dissector_add("cotp") so it will be dissected correctly, hopefully this won't introduce new problems with other "cotp" heuristics ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15850 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove some strcpy()
sahlberg [Sat, 17 Sep 2005 12:16:11 +0000 (12:16 +0000)]
remove some strcpy()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15849 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove some strcpy()
sahlberg [Sat, 17 Sep 2005 12:09:36 +0000 (12:09 +0000)]
remove some strcpy()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15848 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix Gerald's e-mail address (and possibly provoke a copy of the main
guy [Sat, 17 Sep 2005 02:14:44 +0000 (02:14 +0000)]
Fix Gerald's e-mail address (and possibly provoke a copy of the main
repository to the anonymous repository - the current anonymous
repository appears to be out-of-date, which is breaking the buildbot).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15847 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMark some unused and unremovable arguments as unused.
guy [Sat, 17 Sep 2005 00:39:52 +0000 (00:39 +0000)]
Mark some unused and unremovable arguments as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15846 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove some headers for stuff defined by a dissector into epan/dissectors
guy [Sat, 17 Sep 2005 00:31:15 +0000 (00:31 +0000)]
Move some headers for stuff defined by a dissector into epan/dissectors
- and rename smb.h to packet-smb.h, as it's packet-smb.c's header file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15845 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove a pile of protocol-related headers from the top-level source
guy [Sat, 17 Sep 2005 00:02:31 +0000 (00:02 +0000)]
Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15844 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd an expert info based on QualityCode and a COL_INFO output
ulfl [Fri, 16 Sep 2005 22:17:50 +0000 (22:17 +0000)]
add an expert info based on QualityCode and a COL_INFO output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15843 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoslightly shrink COL_INFO output
ulfl [Fri, 16 Sep 2005 22:14:33 +0000 (22:14 +0000)]
slightly shrink COL_INFO output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15842 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosplit call id's with a #, if more than one DCE/RPC call is in a data PDU
ulfl [Fri, 16 Sep 2005 22:05:50 +0000 (22:05 +0000)]
split call id's with a #, if more than one DCE/RPC call is in a data PDU

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15841 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSort each conversation column numerically. Fix up whitespace.
gerald [Fri, 16 Sep 2005 16:25:53 +0000 (16:25 +0000)]
Sort each conversation column numerically.  Fix up whitespace.

It looks like we can't put "COPYCMD=/Y" in config.nmake and expect nmake
to do the right thing.  Add a comment, and set COPYCMD explicitly in the
root Makefile.nmake.  The rest of the occurrences of xcopy will have to
be taken care of at some point.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15840 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAargh - undo r15838 as I missed jmayer's commit of r15835.
tpot [Fri, 16 Sep 2005 12:30:33 +0000 (12:30 +0000)]
Aargh - undo r15838 as I missed jmayer's commit of r15835.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15839 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoComment out pidl dissectors for the moment to get the win32 build
tpot [Fri, 16 Sep 2005 12:11:17 +0000 (12:11 +0000)]
Comment out pidl dissectors for the moment to get the win32 build
going again.  I have most of a patch to get it working but I don't
think it will be finished tonight.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15838 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf we've enabled the display of BER encapsulation tokens, only put them
guy [Fri, 16 Sep 2005 09:47:18 +0000 (09:47 +0000)]
If we've enabled the display of BER encapsulation tokens, only put them
into the protocol tree once.

Fix the offsets and lengths used to put the variable binding values into
the protocol tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15837 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a local copy of pidl, add a README.ethereal to include
jmayer [Fri, 16 Sep 2005 09:31:05 +0000 (09:31 +0000)]
Add a local copy of pidl, add a README.ethereal to include
minimalistic building and usage instructions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15836 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove the packet-dcerpc-*.[hc] from pidl/ back to dissectors.
jmayer [Fri, 16 Sep 2005 08:55:51 +0000 (08:55 +0000)]
Move the packet-dcerpc-*.[hc] from pidl/ back to dissectors.
This makes Ethereal build again - there's no real reason that
ethereal fails to build for such a long time on so many platforms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15835 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowka.tmpl:
jmayer [Fri, 16 Sep 2005 08:40:08 +0000 (08:40 +0000)]
wka.tmpl:
        Show MS NLB Adresses individually
manuf:
        Update

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15834 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoNote problems with some values that appear in, for example, some SNMP
guy [Fri, 16 Sep 2005 08:30:35 +0000 (08:30 +0000)]
Note problems with some values that appear in, for example, some SNMP
captures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15833 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a type.
guy [Fri, 16 Sep 2005 07:50:02 +0000 (07:50 +0000)]
Fix a type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15832 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd conformance file used for building winreg dissector.
tpot [Fri, 16 Sep 2005 04:25:12 +0000 (04:25 +0000)]
Add conformance file used for building winreg dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15831 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofixing the fix, it's time to go to bed ...
ulfl [Fri, 16 Sep 2005 00:02:31 +0000 (00:02 +0000)]
fixing the fix, it's time to go to bed ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15830 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobugfix: don't crash (assert), if jumping to the first packet and packet_list is curre...
ulfl [Thu, 15 Sep 2005 23:44:07 +0000 (23:44 +0000)]
bugfix: don't crash (assert), if jumping to the first packet and packet_list is currently empty. Can happen at capture start.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15829 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't use u_char - not all platforms define it, and even those that do
guy [Thu, 15 Sep 2005 23:39:08 +0000 (23:39 +0000)]
Don't use u_char - not all platforms define it, and even those that do
might require other files to be included to get it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15828 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a Makefile.
guy [Thu, 15 Sep 2005 23:17:42 +0000 (23:17 +0000)]
Add a Makefile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15827 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd more information regarding call legs.
lego [Thu, 15 Sep 2005 19:30:44 +0000 (19:30 +0000)]
Add more information regarding call legs.
Make the release cause value filterable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15826 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoleak fix
lego [Thu, 15 Sep 2005 19:26:05 +0000 (19:26 +0000)]
leak fix

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15825 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix fragment length checks. Fixes bugs 440 and 442-446.
gerald [Thu, 15 Sep 2005 18:42:04 +0000 (18:42 +0000)]
Fix fragment length checks.  Fixes bugs 440 and 442-446.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15824 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove some redundant strcpy()
sahlberg [Thu, 15 Sep 2005 13:41:56 +0000 (13:41 +0000)]
remove some redundant strcpy()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15823 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove some redundant strcpy()
sahlberg [Thu, 15 Sep 2005 13:36:31 +0000 (13:36 +0000)]
remove some redundant strcpy()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15822 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove a whole bunch of strcpy() fix minor bug where whe checked the wrong string...
sahlberg [Thu, 15 Sep 2005 13:31:05 +0000 (13:31 +0000)]
remove a whole bunch of strcpy()     fix minor bug where whe checked the wrong string before we display it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15821 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoupdate for ospf from Senthil Kumar Nagappan
sahlberg [Thu, 15 Sep 2005 13:20:32 +0000 (13:20 +0000)]
update for ospf from Senthil Kumar Nagappan

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15820 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodelete the old dissector
sahlberg [Thu, 15 Sep 2005 10:20:08 +0000 (10:20 +0000)]
delete the old dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15819 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodelete the old dissector and point the makefile to the new dissector
sahlberg [Thu, 15 Sep 2005 10:19:25 +0000 (10:19 +0000)]
delete the old dissector and point the makefile to the new dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15818 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agonew pidl generated atsvc dissector and its conformance file
sahlberg [Thu, 15 Sep 2005 10:18:08 +0000 (10:18 +0000)]
new  pidl generated atsvc dissector and its conformance file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15817 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of a no-longer-used variable.
guy [Thu, 15 Sep 2005 09:09:00 +0000 (09:09 +0000)]
Get rid of a no-longer-used variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15816 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove OUIs from LLDP dissector to oui.h.
guy [Thu, 15 Sep 2005 08:57:51 +0000 (08:57 +0000)]
Move OUIs from LLDP dissector to oui.h.

Get rid of remaining sprintf'ing into on-the-stack buffers.

Note where some items came from.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15815 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse ep_strdup_printf() to generate the "not found in value_string table"
guy [Thu, 15 Sep 2005 08:55:43 +0000 (08:55 +0000)]
Use ep_strdup_printf() to generate the "not found in value_string table"
string for val_to_str().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15814 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTag ep_strdup_printf() and se_strdup_printf() as printf-like functions,
guy [Thu, 15 Sep 2005 08:54:56 +0000 (08:54 +0000)]
Tag ep_strdup_printf() and se_strdup_printf() as printf-like functions,
so we get compile-time checking of arguments when possible.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15813 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoA first go at importing some pidl generated code into ethereal. This
tpot [Thu, 15 Sep 2005 07:34:52 +0000 (07:34 +0000)]
A first go at importing some pidl generated code into ethereal.  This
commit replaces the hand written dcerpc initshutdown and winreg
interfaces with autogenerated ones.

The pidl generated code is still a bit rought around the edges but will
hopefully improve with time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15812 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd PRIX64, as we now use it.
guy [Thu, 15 Sep 2005 06:04:33 +0000 (06:04 +0000)]
Add PRIX64, as we now use it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15811 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoReplace the spnego dissector with an asn2eth generated one.
etxrab [Thu, 15 Sep 2005 05:38:37 +0000 (05:38 +0000)]
Replace the spnego dissector with an asn2eth generated one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15810 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRename TLV_INFO_MASK to TLV_INFO_LEN_MASK, to match TLV_TYPE_MASK.
guy [Thu, 15 Sep 2005 05:22:20 +0000 (05:22 +0000)]
Rename TLV_INFO_MASK to TLV_INFO_LEN_MASK, to match TLV_TYPE_MASK.

Use "tvb_format_stringzpad()" rather than "tvb_format_text()" on
strings, as some of them are null-padded.  (XXX - are they null-padded
or null-terminated?)

Clean up the TLV length checks, and do many more such checks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15809 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWe already define ETHERTYPE_LLDP in "etypes.h" - use that, don't define
guy [Thu, 15 Sep 2005 04:08:53 +0000 (04:08 +0000)]
We already define ETHERTYPE_LLDP in "etypes.h" - use that, don't define
our own.

Get rid of MAC_to_str() - ether_to_str() suffices.

Don't copy to on-the-stack fixed-size string buffers, just save the
results of various formatting calls as pointers.

Use tvb_format_text() to get displayable versions of text strings.

Use tvb_get_ipv4() and tvb_get_ipv6().

Don't put an item into the protocol tree as text and then put in a
hidden item that, if unhidden, would display the same or almost exactly
the same; just put the item into the tree unhidden.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15808 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoProperly handle 64-bit integer constants (they don't happen by magic,
guy [Thu, 15 Sep 2005 03:09:40 +0000 (03:09 +0000)]
Properly handle 64-bit integer constants (they don't happen by magic,
and the stuff you have to do is compiler-dependent, so use
G_GINT64_CONSTANT()).

Properly handle formatting 64-bit quantities (they don't format
correctly by magic, and the stuff you have to do is compiler-dependent,
so use PRI[duoxX]64).

Don't copy the result of tvb_bytes_to_str() to a string buffer and then
only use it as an argument to a "%s" - just use the result directly.

Don't copy constant strings to a buffer - just use the strings directly.

Fetch 64-bit integral quantities with tvb_get_ntoh64(); they're
presumably in a standard byte order, which is probably big-endian for
Internet-family protocols, and using tvb_memcpy() is *guaranteed* to be
wrong on some platforms.

Fix up a format string.

Fix up indentation a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15807 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch some warnings, fix some typoes.
guy [Thu, 15 Sep 2005 03:03:29 +0000 (03:03 +0000)]
Squelch some warnings, fix some typoes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15806 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix wtap_dump_flush function name and don't check for it's return value. We don't...
ulfl [Wed, 14 Sep 2005 23:15:12 +0000 (23:15 +0000)]
fix wtap_dump_flush function name and don't check for it's return value. We don't do this check in Ethereal either and we will recognize problems at next write anyway ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15805 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadded compression support for capture file output. The Save/As dialog now has a check...
ulfl [Wed, 14 Sep 2005 21:57:30 +0000 (21:57 +0000)]
added compression support for capture file output. The Save/As dialog now has a checkbox "Compress with gzip"

currently limited to Ethereal and all the variants of libpcap filetypes only.

We might want to add output compression support to the other tools as well (tethereal, mergecap, ...).

We might also want to add support for the other filetypes, but this is only possible if the filetype functions doesn't use special output operations like fseek.

One bug is still left: if the input and output filetypes while saving are the same, Ethereal currently optimizes this by simply copy the binary file instead of using wiretap (so it will be faster but it will ignore the compress setting).

Don't know a good workaround for this, as I don't know a way to find out if the input file is currently compressed or not. One idea might be to use a heuristic on the filesize (compared to the packet size summmary). Another workaround I see is to remove this optimization, which is of course not the way I like to do it ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15804 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd E_OUTOFMEMORY
ulfl [Wed, 14 Sep 2005 20:09:17 +0000 (20:09 +0000)]
add E_OUTOFMEMORY

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15803 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Peter Johansson
etxrab [Wed, 14 Sep 2005 19:14:23 +0000 (19:14 +0000)]
From Peter Johansson
I added a description for the call to DISSECTOR_ASSERT in proto.c to be
printed to stderr.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15802 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a warning.
etxrab [Wed, 14 Sep 2005 19:11:23 +0000 (19:11 +0000)]
Fix a warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15801 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Brian Bogora:
etxrab [Wed, 14 Sep 2005 19:06:54 +0000 (19:06 +0000)]
From Brian Bogora:
Our company (Mitel) has developed an LLDP-MED plug-in for Ethereal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15800 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Dinesh G Dutt
etxrab [Wed, 14 Sep 2005 18:40:16 +0000 (18:40 +0000)]
From Dinesh G Dutt

Support some new messages and fix a couple of bugs.

packet-fc.h - Added a #define for a Cisco MDS-specific frame called OHMS (online health mgmt srv) packet-fc.c - Support for OHMS frame, fixed an incorrect "malformed frame" error caused on ACK1 frames (they
                   don't contain anything but (encap hdr + FC hdr + encap trailer), fixed incorrect detection of
                   last-data-frame

packet-fcct.h - Support for new service type, "Fabric Controller", used in conjunction with FC-SW3 ESS message,
                     exported the service name value string definitions and
packet-fcct.c - Support for recognizing "Fabric Controller" service type and "vendor-specific" service

packet-fcswils.h - Support for ESS & MRRA messages, defined as part of FC-SW3 packet-fcswils.c - Support for ESS & MRRA messages, defined as part of FC-SW3

packet-scsi.c - Support for Verify and Write&Verify SBC commands.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15799 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDo the variable binding with dissect_ber_x() routines rather than asn1 ones.
etxrab [Wed, 14 Sep 2005 17:08:41 +0000 (17:08 +0000)]
Do the variable binding with dissect_ber_x() routines rather than asn1 ones.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15798 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDont't carsh if dissect_ber_null() isn't passed a hf_id.
etxrab [Wed, 14 Sep 2005 17:04:36 +0000 (17:04 +0000)]
Dont't carsh if dissect_ber_null() isn't passed a hf_id.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15797 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAllow dissection of dcerpc of short frames instead of aborting as soon as it is...
sahlberg [Wed, 14 Sep 2005 16:06:11 +0000 (16:06 +0000)]
Allow dissection of dcerpc of short frames   instead of aborting as soon as it is detected the pdu is "short"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15796 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofor octet strings that span beyond the end of a "short" tvb, create a new subset...
sahlberg [Wed, 14 Sep 2005 16:04:59 +0000 (16:04 +0000)]
for octet strings that span beyond the end of a "short" tvb,   create a new subset tvb of what we have and use that  instead of bailing out completely.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15795 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowhen we have raw keberos inside the spnego blob, pass it as is over to
sahlberg [Wed, 14 Sep 2005 16:02:54 +0000 (16:02 +0000)]
when we have raw keberos inside the spnego blob,   pass it as is over to
the kerberos dissector  and do not strip the ber tag and lengths off

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15794 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHave cf_retap_packets() take an argument that indicates whether to
guy [Wed, 14 Sep 2005 08:59:41 +0000 (08:59 +0000)]
Have cf_retap_packets() take an argument that indicates whether to
generate columns; use cf_retap_packets instead of cf_redissect_packets()
when running taps (the general flow graph stat uses the Info column).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15793 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix #388: add /desktopicon and /quicklaunchicon command line options to the NSIS...
ulfl [Wed, 14 Sep 2005 02:07:20 +0000 (02:07 +0000)]
fix #388: add /desktopicon and /quicklaunchicon command line options to the NSIS installer

update the User's Guide accordingly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15792 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove "Expert Info" from "Statistics" to "Analyze" menu item.
ulfl [Tue, 13 Sep 2005 23:46:42 +0000 (23:46 +0000)]
Move "Expert Info" from "Statistics" to "Analyze" menu item.

*significantly* improve performance (100000 infos from ~5min to 25sec!)

Add a simple severity based filter mechanism.

replace // style comments by /**/

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15791 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTurn around the sequence of PATH, so the former PATH will be in front of the newly...
ulfl [Tue, 13 Sep 2005 19:01:08 +0000 (19:01 +0000)]
Turn around the sequence of PATH, so the former PATH will be in front of the newly added things.

This way, the cygwin link.exe command will be behind the link.exe from MSVC.

Also added a definition of the docbook dir, floating around in my personal file for a while. This will be needed if the User's Guide is included in the NSIS installer later.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15790 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn smb_trans_defragment(), throw an exception if we encounter a too-large
gerald [Tue, 13 Sep 2005 19:01:01 +0000 (19:01 +0000)]
In smb_trans_defragment(), throw an exception if we encounter a too-large
fragment size.  The limit is conservatively set at 65536 bytes.  It may
have to be increased.  Fixes bug 421.

Add an entry to the release notes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15789 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoimplement a way to add menu items to the "Analyze" menu
ulfl [Tue, 13 Sep 2005 18:45:52 +0000 (18:45 +0000)]
implement a way to add menu items to the "Analyze" menu

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15788 f5534014-38df-0310-8fa8-9805f1628bb7