14 years agoFrom Mark C Brown,:
etxrab [Tue, 17 May 2005 19:50:38 +0000 (19:50 +0000)]
From Mark C Brown,:
Fixes for LAP-B (SX25L2) and X.25 (SX25L3) nettl trace records.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14385 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Yuriy Sidelnikov:
etxrab [Tue, 17 May 2005 19:21:45 +0000 (19:21 +0000)]
From Yuriy Sidelnikov:
A perfectly good tvb_bytes_to_str() has been used instead of string_to_hex.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14384 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some more AVP:s.
etxrab [Tue, 17 May 2005 19:15:31 +0000 (19:15 +0000)]
Add some more AVP:s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14383 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some more media types to be dissected as xml.
etxrab [Tue, 17 May 2005 19:13:05 +0000 (19:13 +0000)]
Add some more media types to be dissected as xml.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14382 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- change the state label OUT to OUTSIDE to avoid a name collision with a macro define...
lego [Tue, 17 May 2005 13:29:36 +0000 (13:29 +0000)]
- change the state label OUT to OUTSIDE to avoid a name collision with a macro defined in the windows system headers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14381 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd get_items_before(), to help analyze in the presence of
gram [Tue, 17 May 2005 01:47:04 +0000 (01:47 +0000)]
Add get_items_before(), to help analyze in the presence of
tunneled protocols.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14380 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd get_hide() to return the value of the "hide" tag
gram [Mon, 16 May 2005 23:21:01 +0000 (23:21 +0000)]
Add get_hide() to return the value of the "hide" tag
in field attributes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14379 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd TCP port for "radan-http 8088/tcp Radan HTTP" from IANA.
etxrab [Mon, 16 May 2005 18:24:27 +0000 (18:24 +0000)]
Add TCP port for "radan-http      8088/tcp    Radan HTTP" from IANA.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14378 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some more media types.
etxrab [Mon, 16 May 2005 18:15:33 +0000 (18:15 +0000)]
Add some more media types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14377 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTransforms and Pdus are working already, Gops start to work.
lego [Mon, 16 May 2005 17:16:52 +0000 (17:16 +0000)]
Transforms and Pdus are working already, Gops start to work.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14376 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agolet's get things right, we are in plugins/mate not epan/dfilter (from which I stole...
lego [Mon, 16 May 2005 15:10:50 +0000 (15:10 +0000)]
let's get things right, we are in plugins/mate not epan/dfilter (from which I stole the nmake rules)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14375 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoForgot this one in the last checkin!
lego [Mon, 16 May 2005 14:59:14 +0000 (14:59 +0000)]
Forgot this one in the last checkin!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14374 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMATE has a grammar.
lego [Mon, 16 May 2005 13:28:35 +0000 (13:28 +0000)]
MATE has a grammar.

Although not yet fully implemented I want this version as a reference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14373 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Martin Mathieson:
etxrab [Mon, 16 May 2005 06:16:45 +0000 (06:16 +0000)]
From Martin Mathieson:
new version of the RDT dissector.  It turns out that
specs are available for this protocol on www.helixcommunity.org  - this
version was written by myself and Tom Marshall of RealNetworks, Inc.

I Changed stream_id and asm_rule_number to be guint16 to fix compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14372 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago From Tim Endean:
etxrab [Sun, 15 May 2005 21:17:29 +0000 (21:17 +0000)]
 From Tim Endean:
 Ss-code is Optional in some cases.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14371 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Tim Endean:
etxrab [Sun, 15 May 2005 21:15:53 +0000 (21:15 +0000)]
From Tim Endean:
Ss-code is Optional in some cases.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14370 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom martin m
sahlberg [Sat, 14 May 2005 22:05:56 +0000 (22:05 +0000)]
from martin m

prettify dcerpc

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14369 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen we catch an exception, make sure we don't throw the same exception again
gerald [Sat, 14 May 2005 21:13:07 +0000 (21:13 +0000)]
When we catch an exception, make sure we don't throw the same exception again
(and catch it again in the process).  Fixes bug 170.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14368 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom dinesh
sahlberg [Sat, 14 May 2005 21:08:20 +0000 (21:08 +0000)]
from dinesh
fix to make Zone_Alias objects decode properly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14367 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Guillaume Chazarain
sahlberg [Sat, 14 May 2005 21:00:43 +0000 (21:00 +0000)]
From   Guillaume Chazarain
New protocol : ARMAGETRONAD    dissector for the protcol used by the game of the same name

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14366 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThrow an exception if AndXOffset is less than the current offset. Fixes bug
gerald [Sat, 14 May 2005 19:13:02 +0000 (19:13 +0000)]
Throw an exception if AndXOffset is less than the current offset.  Fixes bug
163.  I'm not sure if this fix is entirely correct, but it doesn't appear to
have affected any SMB captures here adversely.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14365 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd decoding of teh REMOVABLE bit in inquiry data
sahlberg [Sat, 14 May 2005 17:41:07 +0000 (17:41 +0000)]
add decoding of teh REMOVABLE bit in inquiry data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14364 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a missing field to the REPORT LUNS datain pdu
sahlberg [Sat, 14 May 2005 17:12:45 +0000 (17:12 +0000)]
add a missing field to the REPORT LUNS datain pdu

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14363 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd WTAP_GCOM_TIE1 and WTAP_GCOM_SERIAL for
gram [Fri, 13 May 2005 19:44:25 +0000 (19:44 +0000)]
Oolan Zimmer <ethereal@gcom.com>

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14362 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- make sure contextId and transactionId are added to the tree as filterable fields...
lego [Fri, 13 May 2005 11:16:05 +0000 (11:16 +0000)]
- make sure contextId and transactionId are added to the tree as filterable fields even if they are larger than 4 octets
- set COL_INFO to something useful

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14361 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoForgott the lex.py file
etxrab [Fri, 13 May 2005 05:50:26 +0000 (05:50 +0000)]
Forgott the lex.py file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14360 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd the asn2eth related files to extra-dist (I hope this is the right thing to do...
etxrab [Fri, 13 May 2005 05:47:56 +0000 (05:47 +0000)]
Add the asn2eth related files to extra-dist (I hope this is the right thing to do to get them into the SVN tarballs).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14359 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse "pcap_get_selectable_fd()" if we have it, and if it returns -1,
guy [Thu, 12 May 2005 03:31:33 +0000 (03:31 +0000)]
Use "pcap_get_selectable_fd()" if we have it, and if it returns -1,
don't do a "select()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14358 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't include <pcap.h> twice.
guy [Thu, 12 May 2005 03:29:59 +0000 (03:29 +0000)]
Don't include <pcap.h> twice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14357 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf we have libpcap, include <pcap.h>, because "capture.h" requires it.
guy [Thu, 12 May 2005 03:29:26 +0000 (03:29 +0000)]
If we have libpcap, include <pcap.h>, because "capture.h" requires it.

If we *don't* have libpcap, don't include "capture.h", and don't test
whether a capture is in progress.

Clean up a message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14356 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch a compiler warning (GCC 4.0's data flow analysis is
guy [Thu, 12 May 2005 02:55:59 +0000 (02:55 +0000)]
Squelch a compiler warning (GCC 4.0's data flow analysis is
interprocedural, so it knows "sip_parse_line()" doesn't always set
"*token_1_len", but it doesn't know that if it doesn't return OTHER_LINE
it *does* always set it, so it's safe not to set it as long as it's
never used if the return value is OTHER_LINE).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14355 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a routine to return the value it's supposed to return.
guy [Thu, 12 May 2005 02:51:59 +0000 (02:51 +0000)]
Fix a routine to return the value it's supposed to return.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14354 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAlways set "*success" in "ipxnet_addr_lookup()" before returning (thanks
guy [Thu, 12 May 2005 02:50:27 +0000 (02:50 +0000)]
Always set "*success" in "ipxnet_addr_lookup()" before returning (thanks
and a tip of the hat to GCC 4.0's interprocedural data flow analysis for
catching this one!).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14353 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoReinsert Gerards patch (r14342) which was lost.
etxrab [Wed, 11 May 2005 22:20:11 +0000 (22:20 +0000)]
Reinsert Gerards patch (r14342) which was lost.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14352 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoReinsert Gerards patch (r14342) which was lost.
etxrab [Wed, 11 May 2005 22:19:36 +0000 (22:19 +0000)]
Reinsert Gerards patch (r14342) which was lost.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14351 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agopinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection...
etxrab [Wed, 11 May 2005 22:00:50 +0000 (22:00 +0000)]
pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14350 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Viorel Suman:
etxrab [Wed, 11 May 2005 21:59:44 +0000 (21:59 +0000)]
From Viorel Suman:
Enable a proper deconding of an alphanumeric 7-bit encoded SMS TP-Originating-Address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14349 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agopinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection...
etxrab [Wed, 11 May 2005 21:46:16 +0000 (21:46 +0000)]
pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14348 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoavoid a div-by-0
sahlberg [Wed, 11 May 2005 12:37:20 +0000 (12:37 +0000)]
avoid a div-by-0

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14347 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Hannes Gredler
sahlberg [Wed, 11 May 2005 11:24:17 +0000 (11:24 +0000)]
From Hannes Gredler
support for Juniper PPPOE encapsulation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14346 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSome applications do very naughty things like reusing a port for a different protocol...
sahlberg [Wed, 11 May 2005 10:40:53 +0000 (10:40 +0000)]
Some applications do very naughty things like reusing a port for a different protocol during different stages of an application cycle.

This is very naughty and will cause problems when we have assigned a dissector to a dynamic port using conversation_set_dissector().

To make ethereal handle this case I have changed the try_conversation_dissector() to allow it to fail and return 0,   meaning   yes there is indeed a protocol registered for this conversation but that protocol rejected this packet.
(which only happens for "new" style dissectors, "old" style dissectors will never reject a packet that way)

When this happens  the decode_udp_port() helper will still allow other dissectors to be tried, in the hope that the conversation is now used for some other protocol and thus someone else might be able to decode the packet.

Update SNMP and TFTP dissectors to  check that even if there already is a conversation but that conversation does NOT have snmp/tftp registered as the dissector for it, then create a new conversation anyway and attach the proper dissector.

Since ethereal keeps track of which frame number a conversation started in, this actually works really well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14345 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't write a '\0' way the heck past the end of an array. Fixes bug 164.
gerald [Tue, 10 May 2005 23:45:39 +0000 (23:45 +0000)]
Don't write a '\0' way the heck past the end of an array.  Fixes bug 164.

Add a comment asking if we shouldn't use oid_to_str() instead of our own

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14344 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- export Audio Codec modes from isup/bicc
lego [Tue, 10 May 2005 21:54:37 +0000 (21:54 +0000)]
- export Audio Codec modes from isup/bicc
- detailed dissection of GSM/UMTS speech code list ETSI 126 103 (3gpp 26.103 v3.0.0)
- use it for H.248

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14343 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix dissection of mo-forwardSM
etxrab [Tue, 10 May 2005 20:09:09 +0000 (20:09 +0000)]
Fix dissection of mo-forwardSM

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14342 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix dissection of mt-forwardSM.
etxrab [Tue, 10 May 2005 20:06:04 +0000 (20:06 +0000)]
Fix dissection of mt-forwardSM.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14341 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix some field rename errors turned up by the latest asn2eth compiler.
etxrab [Tue, 10 May 2005 20:02:14 +0000 (20:02 +0000)]
fix some field rename errors turned up by the latest asn2eth compiler.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14340 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomake SNMP over UDP a new style dissector and add some heuristics to check if this...
sahlberg [Tue, 10 May 2005 08:49:27 +0000 (08:49 +0000)]
make SNMP over UDP a new style dissector and add some heuristics to check if this is SNMP or not,

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14339 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake a field type check more strict. Remove some unnecessary code.
gerald [Tue, 10 May 2005 03:10:09 +0000 (03:10 +0000)]
Make a field type check more strict.  Remove some unnecessary code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14338 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake sure we don't feed a null string to strncmp(). Fixes bug 161.
gerald [Tue, 10 May 2005 03:08:36 +0000 (03:08 +0000)]
Make sure we don't feed a null string to strncmp().  Fixes bug 161.

Make sure we don't free static memory.  Fix a small memory leak.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14337 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoI just found a packet with an option e. As the value looked very much
jmayer [Mon, 9 May 2005 11:21:16 +0000 (11:21 +0000)]
I just found a packet with an option e. As the value looked very much
like the mac-address of the switch, I added decoding of option e as
mac address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14336 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd another sanity check to the new SIP URI parser.
lroland [Mon, 9 May 2005 01:21:41 +0000 (01:21 +0000)]
Add another sanity check to the new SIP URI parser.
Just to be sure.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14335 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSome fixes for the new SIP contact header parser.
lroland [Mon, 9 May 2005 01:15:45 +0000 (01:15 +0000)]
Some fixes for the new SIP contact header parser.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14334 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoonly lower-case ASCII letters, numbers,
lroland [Mon, 9 May 2005 00:11:03 +0000 (00:11 +0000)]
only lower-case ASCII letters, numbers,
underscores, and dots are allowed in the
preference name.

Fix it the camel dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14333 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMark a function parameter as unused
lroland [Sun, 8 May 2005 23:29:55 +0000 (23:29 +0000)]
Mark a function parameter as unused

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14332 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen saying that I remove the trailing white spaces I should do it, too.
lroland [Sun, 8 May 2005 22:39:38 +0000 (22:39 +0000)]
When saying that I remove the trailing white spaces I should do it, too.

So I do it now and do some more reindentation, too.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14331 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoImprove dissection of SIP contact header and counting of bindings in REGISTER messages.
lroland [Sun, 8 May 2005 22:19:18 +0000 (22:19 +0000)]
Improve dissection of SIP contact header and counting of bindings in REGISTER messages.

Introduce a function for disseting a sip uri in general

- add dissection of contact and uri parameters
- simplify the ugly code for dissecting "to" and "from" headers
      by using the new function for uri dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14330 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoReindent dissect_sip_common() and remove trailing white spaces from packet-sip.c.
lroland [Sun, 8 May 2005 21:17:37 +0000 (21:17 +0000)]
Reindent dissect_sip_common() and remove trailing white spaces from packet-sip.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14329 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Javier Acuna:
etxrab [Sun, 8 May 2005 20:35:44 +0000 (20:35 +0000)]
From Javier Acuna:

Added some code to dissect DateAndTime.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14328 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Javier Acuna:
etxrab [Sun, 8 May 2005 20:34:57 +0000 (20:34 +0000)]
From Javier Acuna:

Added some code to dissect DateAndTime.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14327 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd icons for the "File Set" menu items
ulfl [Sat, 7 May 2005 20:47:39 +0000 (20:47 +0000)]
add icons for the "File Set" menu items

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14326 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIncrease size of an integer to prevent an integer overflow
lroland [Sat, 7 May 2005 00:14:11 +0000 (00:14 +0000)]
Increase size of an integer to prevent an integer overflow

Fixes Bug 162

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14325 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoprettify YPSERV
sahlberg [Fri, 6 May 2005 10:11:08 +0000 (10:11 +0000)]
prettify YPSERV

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14324 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoA fix for the previous fix for the infinite loop in bootp, bug #160.
gram [Fri, 6 May 2005 02:08:30 +0000 (02:08 +0000)]
A fix for the previous fix for the infinite loop in bootp, bug #160.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14323 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCheck the offset delta while we loop through the options.
gram [Fri, 6 May 2005 01:56:40 +0000 (01:56 +0000)]
Check the offset delta while we loop through the options.
Make sure the delta is > 0.
This intends to fix bug 160, although with a capture file
to test it, I can't be totally sure.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14322 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange 802.11f -> F, 802.1d -> D, 802.1x -> X, 802.1q -Q, 802.1P -> p
jmayer [Thu, 5 May 2005 17:07:58 +0000 (17:07 +0000)]
Change 802.11f -> F, 802.1d -> D, 802.1x -> X, 802.1q -Q, 802.1P -> p

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14321 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd GetWindowsVersion.nsh to the additional packaging files
ulfl [Thu, 5 May 2005 15:25:04 +0000 (15:25 +0000)]
add GetWindowsVersion.nsh to the additional packaging files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14320 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomake tethereal compile when plugins are disabled
sahlberg [Thu, 5 May 2005 13:48:34 +0000 (13:48 +0000)]
make tethereal compile when plugins are disabled

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14319 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a call to dereference a pointer (found by a compiler warning).
guy [Thu, 5 May 2005 11:08:20 +0000 (11:08 +0000)]
Fix a call to dereference a pointer (found by a compiler warning).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14318 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't explicitly initialize "h245_labels", as it's hard to initialize
guy [Thu, 5 May 2005 11:07:22 +0000 (11:07 +0000)]
Don't explicitly initialize "h245_labels", as it's hard to initialize
all of it correctly, and as if you don't initialize all of it you get a
compiler warning.

Add an assignment to squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14317 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a test (bug found by a compiler warning).
guy [Thu, 5 May 2005 11:06:08 +0000 (11:06 +0000)]
Fix a test (bug found by a compiler warning).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14316 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange some data types, and add initializations, to squelch compiler
guy [Thu, 5 May 2005 11:05:15 +0000 (11:05 +0000)]
Change some data types, and add initializations, to squelch compiler

Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14315 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange data types to match those of "iconv()", at least on OS X.
guy [Thu, 5 May 2005 11:03:46 +0000 (11:03 +0000)]
Change data types to match those of "iconv()", at least on OS X.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14314 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch a compiler warning.
guy [Thu, 5 May 2005 11:02:31 +0000 (11:02 +0000)]
Squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14313 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRe-parenthesize an expression, to squelch a compiler warning.
guy [Thu, 5 May 2005 10:00:29 +0000 (10:00 +0000)]
Re-parenthesize an expression, to squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14312 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago"oid_to_str()" and "oid_to_str_buf()" don't modify what the "oid"
guy [Thu, 5 May 2005 09:40:24 +0000 (09:40 +0000)]
"oid_to_str()" and "oid_to_str_buf()" don't modify what the "oid"
argument points to, so make it a "const" pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14311 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't try to feed a null pointer to strncmp(). Fixes bug 158.
gerald [Wed, 4 May 2005 17:02:56 +0000 (17:02 +0000)]
Don't try to feed a null pointer to strncmp().  Fixes bug 158.
Shouldn't the number of fuzz bugs decrease asymptotically at some

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14306 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Lars Roland:
gerald [Wed, 4 May 2005 16:40:30 +0000 (16:40 +0000)]
From Lars Roland:

Make sure a hash table exists before trying to access it.  Fixes bug 105.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14305 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't roll our own buffer-overflow-able string_to_hex() routine
gerald [Wed, 4 May 2005 15:35:21 +0000 (15:35 +0000)]
Don't roll our own buffer-overflow-able string_to_hex() routine
when there's a perfectly good tvb_bytes_to_str() lying around, just
_begging_ to be used.

Fix up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14304 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded RPC/ONC SYSTEM_ERROR accept state.
girlich [Wed, 4 May 2005 13:09:46 +0000 (13:09 +0000)]
Added RPC/ONC SYSTEM_ERROR accept state.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14303 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDissect GPRS user data.
etxrab [Tue, 3 May 2005 20:53:21 +0000 (20:53 +0000)]
Dissect GPRS user data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14302 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a *lot* more dissections of the various PN-IO blocks
ulfl [Tue, 3 May 2005 19:58:05 +0000 (19:58 +0000)]
add a *lot* more dissections of the various PN-IO blocks

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14301 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn proto_tree_set_string(), don't set a null fvalue or Ethereal will throw
gerald [Tue, 3 May 2005 19:33:02 +0000 (19:33 +0000)]
In proto_tree_set_string(), don't set a null fvalue or Ethereal will throw
a hissy fit.  Fixes bug 157.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14299 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBack out all of the tvb_ensure_bytes_exist() calls. They shouldn't be
gerald [Tue, 3 May 2005 18:43:06 +0000 (18:43 +0000)]
Back out all of the tvb_ensure_bytes_exist() calls.  They shouldn't be
neccessary any more, and were causing problems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14298 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix two places where we might loop infinitely, including the one found in
gerald [Tue, 3 May 2005 14:36:08 +0000 (14:36 +0000)]
Fix two places where we might loop infinitely, including the one found in
bug 155.  Fix a couple of compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14289 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBase the assoc search on port/vtags only.
tuexen [Tue, 3 May 2005 08:34:11 +0000 (08:34 +0000)]
Base the assoc search on port/vtags only.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14288 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nils O. Sel?sdal:
etxrab [Tue, 3 May 2005 05:22:43 +0000 (05:22 +0000)]
From Nils O. Sel?sdal:

- Decodes all the remaining bitfields in 9P
- Tidies up display a bit (using more subtrees)
- Fixes a few fields that are better off displayed as decimal/octal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14287 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix typos in error messages.
gram [Tue, 3 May 2005 02:07:26 +0000 (02:07 +0000)]
Fix typos in error messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14286 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomove the pn-dcp dissector into the profinet plugin
ulfl [Tue, 3 May 2005 01:39:00 +0000 (01:39 +0000)]
move the pn-dcp dissector into the profinet plugin

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14285 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd the new target "install-plugins" to nmake makefile
lroland [Tue, 3 May 2005 01:03:33 +0000 (01:03 +0000)]
add the new target "install-plugins" to nmake makefile
in the plugins subdirectory. This target will copy all plugins to plugins/$(VERSION), thus (t)ethereal will
find and load the plugins when called from within the source tree.

call this target from the main nmake makefile after
installing other dependencies. call it from the nmake makefile
in the doc subdirectory before calling "tethereal -G".
This way "tethereal -G" will recognize the filterable
fields from the plugins, too.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14284 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd another lenght check in the megaco dissector.
lroland [Tue, 3 May 2005 00:19:08 +0000 (00:19 +0000)]
add another lenght check in the megaco dissector.
Fixes bug 150.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14283 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet profinet compiling on Unix.
tuexen [Mon, 2 May 2005 22:15:00 +0000 (22:15 +0000)]
Get profinet compiling on Unix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14282 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Rich Coe:
gerald [Mon, 2 May 2005 21:56:40 +0000 (21:56 +0000)]
From Rich Coe:

 - fix memory leak when Assoc packet is processed repeatedly in ethereal

 - removed unused partial packet flag

 - added better support for DICOM VR
     - sequences
     - report actual VR in packet display, if supplied by xfer syntax
     - show that we are not displaying entire tag string with '[...]',
       some tags can hold up to 2^32-1 chars

 - remove my goofy attempt at trying to get access to the fragmented packets
   (anyone have an idea on how to fix this ???)

 - process all the data in the Assoc packet even if display is off

 - limit display of data in Assoc packet to defined size of the data even
   if reported size is larger

 - show the last tag in a packet as [incomplete] if we don't have all the data

 - added framework for reporting DICOM async negotiation (not finished)
   (I'm not aware of an implementation which currently supports this)

 - still need to fix display of continuation packets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14280 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoProvide an indication to taps if the verification tag is reflected.
tuexen [Mon, 2 May 2005 20:45:22 +0000 (20:45 +0000)]
Provide an indication to taps if the verification tag is reflected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14278 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBreak out of an infinite loop. Fixes bug 154.
gerald [Mon, 2 May 2005 20:30:56 +0000 (20:30 +0000)]
Break out of an infinite loop.  Fixes bug 154.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14277 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDissect URLC correctly and add dissection of LCC PDU.
etxrab [Mon, 2 May 2005 20:26:56 +0000 (20:26 +0000)]
Dissect URLC correctly and add dissection of LCC PDU.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14276 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn dissect_mgcp_firstline(), throw an exception if tokenlen > 4. This fixes
gerald [Mon, 2 May 2005 20:05:03 +0000 (20:05 +0000)]
In dissect_mgcp_firstline(), throw an exception if tokenlen > 4.  This fixes
bug 145, but may not be the best solution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14275 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd dissection of Q.850 cause.
etxrab [Mon, 2 May 2005 18:32:57 +0000 (18:32 +0000)]
Add dissection of Q.850 cause.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14274 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd dissection of q850 cause.
etxrab [Mon, 2 May 2005 18:32:00 +0000 (18:32 +0000)]
Add dissection of q850 cause.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14273 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCorrect some AVP:s and minor updates from iana.org
etxrab [Mon, 2 May 2005 18:31:15 +0000 (18:31 +0000)]
Correct some AVP:s and minor updates from iana.org

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14272 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse the correct parameters in a function call.
etxrab [Mon, 2 May 2005 18:30:14 +0000 (18:30 +0000)]
Use the correct parameters in a function call.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14271 f5534014-38df-0310-8fa8-9805f1628bb7