stig [Mon, 19 Oct 2009 14:45:10 +0000 (14:45 +0000)]
Made some functions static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30620
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 19 Oct 2009 14:44:37 +0000 (14:44 +0000)]
Removed redundant redeclaration of optind.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30619
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 19 Oct 2009 14:42:10 +0000 (14:42 +0000)]
Removed redundant redeclaration of delete_avpl().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30618
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 19 Oct 2009 14:36:26 +0000 (14:36 +0000)]
Renamed tvb_new -> new_tvb to avoid name collision.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30617
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 19 Oct 2009 14:21:11 +0000 (14:21 +0000)]
Made some functions static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30616
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 19 Oct 2009 13:29:01 +0000 (13:29 +0000)]
Use unsigned int for flags to avoid another warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30615
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 19 Oct 2009 13:24:54 +0000 (13:24 +0000)]
Added cast to (void *) for pointers used in printf format %p.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30614
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 19 Oct 2009 13:22:45 +0000 (13:22 +0000)]
Various code cleanup:
- Added standard copyright boiler plate
- Made all local functions static
- Added several checks for valid pointers
- Fixed some variable shadowing
- Fixed some printf formats (%p)
- Removed unused variables
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30613
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 18 Oct 2009 23:25:33 +0000 (23:25 +0000)]
Neither num_registers nor max_registers in a dfilter_t are ever
negative; make them unsigned.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30612
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sun, 18 Oct 2009 23:19:44 +0000 (23:19 +0000)]
new_octet_aligned_subset_bits(): call tvb_ensure_bytes_exist() before
attmepting to malloc memory to ensure we've been asked to decode a reasonable
number of bits (and thus are asking for a reasonable number of bytes from
malloc()).
That should fix the fuzz failure in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4138
Add a comment to new_octet_aligned_subset() asking why we're resetting the
length to tvb_length()--that means we'll never throw an exception.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30611
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 21:30:39 +0000 (21:30 +0000)]
Fixed a data type and removed a shadowed variable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30610
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 21:29:44 +0000 (21:29 +0000)]
Fixed data type for a buffer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30609
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 21:29:17 +0000 (21:29 +0000)]
Fixed data type for asciibuf.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30608
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 21:27:50 +0000 (21:27 +0000)]
Make it build on glib < 2.10.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30607
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 21:15:37 +0000 (21:15 +0000)]
Removed unused argument in v2_attrval2str().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30606
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 21:14:35 +0000 (21:14 +0000)]
Remove a shadowed variable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30605
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 21:13:53 +0000 (21:13 +0000)]
Use %f for double in printf.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30604
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 21:13:17 +0000 (21:13 +0000)]
Use correct type for udp port preference.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30603
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 20:14:04 +0000 (20:14 +0000)]
Use %f for double in printf.
Made some functions static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30602
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sun, 18 Oct 2009 20:13:56 +0000 (20:13 +0000)]
Don't se_alloc() the conversation structure which contains pointers to two
g_hash_tables that we then try to free in ros_reinit(). Instead, g_malloc()
the conversation structure and free it (along with the hash tables) in the
reinit function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30601
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 20:13:06 +0000 (20:13 +0000)]
Made some functions static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30600
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sun, 18 Oct 2009 19:46:46 +0000 (19:46 +0000)]
dcerpc_fragment_key_copy(): don't se_alloc() the key:
- it contains pointers to a couple malloc()'d addresses
- it is inserted in the fragment table (the contents of which are
g_free()'d in free_all_fragments())
Instead, do like fragment_key_copy() and use a g_slice or g_chunk, depending
on the glib version.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30599
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 18 Oct 2009 15:03:28 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-10-18]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30596
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sun, 18 Oct 2009 14:46:39 +0000 (14:46 +0000)]
Fix an off-by-one error (<= instead of <) that caused the dissector to
reference uninitialized memory, possibly leading to a crash (found by turning
memory scrubbing on).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30595
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 18 Oct 2009 13:36:01 +0000 (13:36 +0000)]
From Kip McAtee:
Suppress spurious packet length error message for LCP or IPCP in PPPoE.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30594
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 18 Oct 2009 12:53:29 +0000 (12:53 +0000)]
From Jouni Malinen:
IEEE 802.11k added a new Action frame category: Public Action. I'm proposing
some initial code to recognize this and to add a placeholder for switch
statement that can be used for processing vendor specific Public Action frames
(they are defined in IEEE 802.11w).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30593
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 18 Oct 2009 10:23:50 +0000 (10:23 +0000)]
Use gtk_combo_box in GTK v 2.4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30592
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Sun, 18 Oct 2009 08:33:40 +0000 (08:33 +0000)]
Default to number of CPUs available
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30591
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 18 Oct 2009 08:02:28 +0000 (08:02 +0000)]
Removed non-ASCII characters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30590
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sat, 17 Oct 2009 21:42:51 +0000 (21:42 +0000)]
Fix memory leak: re-init defragmentation tables each time a capture file is (re) opened.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30589
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 17 Oct 2009 20:56:06 +0000 (20:56 +0000)]
From Marton Nemeth:
Add the ability to open JPEG/JFIF files directly.
From me:
Some code cleanup + add new file to cmake.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30588
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sat, 17 Oct 2009 10:19:18 +0000 (10:19 +0000)]
From Joe Eykholt:
It would be nice to have dissection of the Fibre-Channel FCP
"Sequence retransmission request" (SRR) request.
This is like an FC ELS request, but it has FC type FCP, so it's
a little strange. It seemed like the best place to put it is in
packet-fcp.c but a slight hook is needed in packet-fc.c to
recognize that packet-fcp is the correct dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30587
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 16 Oct 2009 22:28:25 +0000 (22:28 +0000)]
Putting the AC_CANONICAL_xxx macro(s) *after* AC_INIT seems to work, and
could fix cross-compilation problems, according to Jeff Morriss, and
"make dist" seems to build a ustar archive after we do that, so give
that a try. (I don't have any cross-compilers handy to test whether it
fixes cross-compilation or not.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30586
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 16 Oct 2009 22:15:58 +0000 (22:15 +0000)]
Based on an issue presented in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4050 :
Add an item and an expert info (warning) if there's more data in the tvb than the length parameter indicates.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30585
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 22:12:40 +0000 (22:12 +0000)]
Another Oops: #include <stdio.h> *is* required .....
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30584
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 22:05:49 +0000 (22:05 +0000)]
fid_table never used: remove it (Fixes very minor memory leak).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30583
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 22:00:41 +0000 (22:00 +0000)]
Don't init fc_fragment_table twice via registered_init_routines...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30582
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 21:54:17 +0000 (21:54 +0000)]
sna_reassembled_table never used: remove it;
Move register_init_routine call to proto_register as per convention...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30581
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 21:47:48 +0000 (21:47 +0000)]
data_reassembled_table not used: remove it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30580
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 16 Oct 2009 21:36:42 +0000 (21:36 +0000)]
Introduce an optional (ep_ and se_) memory scrubber. When activated (export
WIRESHARK_DEBUG_SCRUB_MEMORY to turn it on) this function initializes all
allocated memory to 0xBADDCAFE and all freed memory to 0xDEADBEEF. (Of course
the allocation functions like ep_alloc0() re-initialize the allocated memory
back to 0.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30579
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 21:35:39 +0000 (21:35 +0000)]
Fix memory leak; init fragment_table & reassembled_table in registered init fcn;
(Tables were being initted only at Wireshark startup in proto_register)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30578
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Fri, 16 Oct 2009 21:26:51 +0000 (21:26 +0000)]
From Joe Eykholt:
The FIP dissector shows the VFID descriptor as a 2-byte string instead of the
correct UINT16 type. Also, the name should be changed to just "VFID".
The "Fabric Name" field of the Fabric descriptor was incorrectly labeled.
Also, some lines grew to longer than 80 columns due to other patches.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30577
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 21:17:57 +0000 (21:17 +0000)]
dtls_fragment_table never used; Remove it.
Remove unneeded #includes.
Adjust some indentation & spacing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30576
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 16:01:20 +0000 (16:01 +0000)]
Oops: #include <stdio.h> *is* required .....
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30575
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 15:28:21 +0000 (15:28 +0000)]
(Trivial) Fix a typo in a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30574
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 14:37:40 +0000 (14:37 +0000)]
#include <stdio.h> not req'd; Fix some typos in text strings;
Adjust some indentation & spacing, reformat some long lines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30573
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 16 Oct 2009 14:22:00 +0000 (14:22 +0000)]
Use GSlice instead of GMemChunks for GLib >= 2.10. Fixes a memory leak.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30572
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 16 Oct 2009 10:38:42 +0000 (10:38 +0000)]
From Gerasimos Dimitriadis:
DTAP: Decoding of Text String in Network Name IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4121
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30571
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 16 Oct 2009 10:32:06 +0000 (10:32 +0000)]
More gtk_option_menu -> gtk_combo_box
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30570
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 16 Oct 2009 07:54:20 +0000 (07:54 +0000)]
Added revision 30561 with changes to make it work.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30569
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 16 Oct 2009 06:17:55 +0000 (06:17 +0000)]
add proper support for infolevel 105 for ff
they are different.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30568
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 16 Oct 2009 05:31:43 +0000 (05:31 +0000)]
add dissection of infolevel 0x105 for findfirst
this is actually identical to infolevel 0x104 in smb while they differ
in smb2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30567
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 15 Oct 2009 22:01:59 +0000 (22:01 +0000)]
Use SE canaries when fuzz testing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30566
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 15 Oct 2009 21:44:07 +0000 (21:44 +0000)]
everted
------------------------------------------------------------------------
r30561 | etxrab | 2009-10-15 18:57:26 +0200 (Do, 15 Okt 2009) | 1 line
gtk_option_menu -> gtk_combo_box
------------------------------------------------------------------------
as it broke compilation on my system and I don't know enough about gtk
to fix it properly.
In file included from /usr/include/gtk-2.0/gtk/gtk.h:224,
from /home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:35:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration isn’t a prototype
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: In function ‘scsistat_program_select’:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:122: error: ‘SCSI_STAT_PROG_LABEL_SBC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:122: error: (Each undeclared identifier is reported only once
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:122: error: for each function it appears in.)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:125: error: ‘SCSI_STAT_PROG_LABEL_SSC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:128: error: ‘SCSI_STAT_PROG_LABEL_MMC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:129: error: ‘SCSI_DEV_MMC’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: In function ‘gtk_scsistat_init’:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:229: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:234: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:239: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:244: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:249: warning: assignment discards qualifiers from pointer target type
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: At top level:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:333: warning: comma at end of enumerator list
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: In function ‘gtk_scsistat_cb’:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:388: error: ‘severity_combo_box’ undeclared (first use in this function)
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:343: warning: unused variable ‘menu_item’
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c: At top level:
/home/jmayer/work/wireshark/svn/trunk/gtk/scsi_stat.c:452: warning: no previous declaration for ‘register_tap_listener_gtkscsistat’
make[2]: *** [gtk/CMakeFiles/ui.dir/scsi_stat.c.o] Error 1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30565
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 15 Oct 2009 21:26:59 +0000 (21:26 +0000)]
The disables features problem was fixed by previous commit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30564
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 15 Oct 2009 21:25:48 +0000 (21:25 +0000)]
The Feature summary of cmake 2.6.2 has a bug that is fixed in
2.8.x (an empty disabled feature list would display all features).
Copy in the version from cmake svn head for now.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30563
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 15 Oct 2009 19:26:00 +0000 (19:26 +0000)]
(Trivial) Fix some typos in a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30562
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 15 Oct 2009 16:57:26 +0000 (16:57 +0000)]
gtk_option_menu -> gtk_combo_box
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30561
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 15 Oct 2009 02:39:06 +0000 (02:39 +0000)]
(Trivial) Fix a typo in a comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30560
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Wed, 14 Oct 2009 14:44:59 +0000 (14:44 +0000)]
Remove (local) build directory that I mistakenly submitted
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30559
f5534014-38df-0310-8fa8-
9805f1628bb7
Kovarththanan Rajaratnam [Wed, 14 Oct 2009 13:07:59 +0000 (13:07 +0000)]
Initial import.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30558
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 14 Oct 2009 10:43:17 +0000 (10:43 +0000)]
Improve DL HARQ resend detection by storing multiple frames per UE.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30557
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 14 Oct 2009 07:22:40 +0000 (07:22 +0000)]
From Matthieu Patou
Update ntlmssp to automatically re-read the keytab file if it changes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30556
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 13 Oct 2009 13:52:23 +0000 (13:52 +0000)]
Status report bitmap can be empty, so add test.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30555
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 13 Oct 2009 13:36:58 +0000 (13:36 +0000)]
Add detection for suspected DL retx (due to HARQ). Needed if logging is done on UE side of link.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30554
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 21:36:54 +0000 (21:36 +0000)]
Use se_alloc instead of GMemChunks.
Fixes memory leak when using GLib v2.10 or later.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30553
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 20:57:01 +0000 (20:57 +0000)]
#include <stdio.h> not req'd;
Adjust some spacing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30552
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 19:27:37 +0000 (19:27 +0000)]
Update comment re freeing circuit-associated memory;
#include <stdio.h>, <string.h> not required.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30551
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 18:27:59 +0000 (18:27 +0000)]
Remove unneeded #includes;
Use consistent indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30550
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 12 Oct 2009 17:28:27 +0000 (17:28 +0000)]
Copy newly generated files to epan/dissectors to make sure whoever runs this target remembers to commit the new changes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30549
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 12 Oct 2009 16:59:12 +0000 (16:59 +0000)]
Make all global variables static
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30548
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 12 Oct 2009 16:57:23 +0000 (16:57 +0000)]
Remove temp files on (clean) exit
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30547
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 15:39:17 +0000 (15:39 +0000)]
Added ENDFOREACH() to close a FOREACH().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30546
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 12 Oct 2009 15:38:16 +0000 (15:38 +0000)]
From Gerasimos Dimitriadis:
DTAP: Facility IE resets PROTOCOL and INFO columns
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4110
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30545
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 12 Oct 2009 15:32:53 +0000 (15:32 +0000)]
From Gerasimos Dimitriadis:
DTAP: Decoding of Emergency Number List IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4111
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30544
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 12 Oct 2009 15:27:37 +0000 (15:27 +0000)]
Option_menu -> combo_box
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30543
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 12 Oct 2009 15:14:43 +0000 (15:14 +0000)]
We have to traverse dissectors/dcerpc unconditionally because that subdirectory needs to tell us which dissectors are autogenerated
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30542
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 15:11:37 +0000 (15:11 +0000)]
Remove unused code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30541
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 12 Oct 2009 15:07:56 +0000 (15:07 +0000)]
Let the pidl subdirectory indicate which protocols it contains
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30540
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 15:04:46 +0000 (15:04 +0000)]
Avoid using uninitialized values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30539
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Mon, 12 Oct 2009 14:48:20 +0000 (14:48 +0000)]
Add back functionality to autogenerate dcerpc dissectors (this is an optional feature which defaults to off)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30538
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 14:43:09 +0000 (14:43 +0000)]
Added a check for num_opts to avoid a theoretical undefined behavior.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30537
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 14:29:48 +0000 (14:29 +0000)]
Initialize variables which may be used uninitialized.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30536
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 14:13:01 +0000 (14:13 +0000)]
Initialize variables which may be used uninitialized.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30535
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 09:13:37 +0000 (09:13 +0000)]
Corrected some return values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30534
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 08:19:30 +0000 (08:19 +0000)]
Return FALSE from proto_tracking_interesting_fields() when no tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30533
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 08:16:50 +0000 (08:16 +0000)]
Check for valid tree in proto_get_finfo_ptr_array() and
proto_tracking_interesting_fields().
This fixes a crash when using Lua script without packet list coloring.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30532
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 08:04:30 +0000 (08:04 +0000)]
Added check for valid column in get_column_title() and
get_column_custom_field().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30531
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 07:56:26 +0000 (07:56 +0000)]
Return from get_column_format() when invalid column requested.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30530
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 12 Oct 2009 07:55:24 +0000 (07:55 +0000)]
Use prefs.col_list when writing recent entries for new packet list.
This is to avoid a mismatch between cfile.cinfo and prefs.col_list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30529
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 01:38:43 +0000 (01:38 +0000)]
Add some comments about GMemChunk usage;
Enable 'deprecated' checking for some GLib functions
Wireshark doesn't currently use.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30528
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 01:31:01 +0000 (01:31 +0000)]
Fix some indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30527
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 01:13:20 +0000 (01:13 +0000)]
Replace GMemChunk usage with se_alloc();
Fixes memory leak for GLib > 2.8.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30526
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 00:54:41 +0000 (00:54 +0000)]
Remove #define which is no longer req'd.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30525
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 12 Oct 2009 00:32:34 +0000 (00:32 +0000)]
Initialize radius_call, so it's null if we don't pass through the code
path that sets it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30524
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 00:31:37 +0000 (00:31 +0000)]
Replace GMemChunks usage with se_alloc();
Remove unneeded #includes;
Fix some spacing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30523
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 12 Oct 2009 00:01:59 +0000 (00:01 +0000)]
Replace use of GMemChunks by se_alloc();
@include <stdlib.h> not req'd;
Use consistent indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30522
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Sun, 11 Oct 2009 17:37:56 +0000 (17:37 +0000)]
Don't col_set_str + col_append_xxx. Just add the string instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30521
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Sun, 11 Oct 2009 17:25:04 +0000 (17:25 +0000)]
Remove more unused variables/forward declarations
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30520
f5534014-38df-0310-8fa8-
9805f1628bb7
krj [Sun, 11 Oct 2009 17:14:19 +0000 (17:14 +0000)]
Make some ett/hf variables static
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30519
f5534014-38df-0310-8fa8-
9805f1628bb7
git.samba.org / obnox / wireshark / wip.git / log