obnox/wireshark/wip.git
21 years agomake-manuf:
jmayer [Sun, 13 Apr 2003 13:51:32 +0000 (13:51 +0000)]
make-manuf:
Don't print Cavebear skipped - it makes the output unusable.
manuf.tmpl:
Remove entries that overwrite identical or similar results from IEEE
manuf:
Rebuild to reflect the changes in manuf.tmpl and add some new IEEE
entries.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7447 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMissing file from previous commit
sahlberg [Sat, 12 Apr 2003 08:14:48 +0000 (08:14 +0000)]
Missing file from previous commit

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7446 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoRewrite the DCERPC over SMB reassembly completely.
sahlberg [Sat, 12 Apr 2003 08:14:02 +0000 (08:14 +0000)]
Rewrite the DCERPC over SMB reassembly completely.

Move the actual reassembly to packet-smb-pipe.c instead of having it inside
the packet-smb.b/Write_andX and ReadAndX dissectors.

Change the dissector to only call dcerpc dissector from the packet where
reassembly was completed instead of always from the first fragment.
Add display fiulter field for the other fragments that display which frame the dcerpc pdu was reassembled in.

This is needed in order to be able to reassemble the type of dcerpc fragments
that are sent between nt4 dc's.
The DCERPC fragment reassembly in the dcerpc layer is still broken though, and
i think it has been broken for quite some time.   That will be addressed shortly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7445 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jeff Morriss: don't put stuff in the Info column if a subdissector
guy [Sat, 12 Apr 2003 07:54:29 +0000 (07:54 +0000)]
From Jeff Morriss: don't put stuff in the Info column if a subdissector
is called, so that we don't get a mix of M3UA and subdissector stuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7444 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoSome packets (the ones I've seen have a datastream type of
guy [Sat, 12 Apr 2003 07:48:36 +0000 (07:48 +0000)]
Some packets (the ones I've seen have a datastream type of
"End-of-Connection Acknolwedgment") have none of the connection control
bits set; describe them as "Data, No Ack Required" rather than
"Unknown".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7443 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAn SPX packet is not a retransmission of an earlier packet unless the
guy [Sat, 12 Apr 2003 07:35:52 +0000 (07:35 +0000)]
An SPX packet is not a retransmission of an earlier packet unless the
two packets have the same sequence number; use the sequence number in
the hash key.

The sequence number is not incremented for system packets, and system
packets probably don't get ACKed and thus presumably don't get
retransmitted, so don't do retransmission checks for system packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7442 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix a typo.
guy [Sat, 12 Apr 2003 05:48:26 +0000 (05:48 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7441 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoYou can't put an FT_FRAMENUM into the tree with a length of -1, so, for
guy [Sat, 12 Apr 2003 05:36:10 +0000 (05:36 +0000)]
You can't put an FT_FRAMENUM into the tree with a length of -1, so, for
a retransmitted SPX frame, just put the number of the original frame in
as an item not referring to any data (offset and length of 0), and, if
there is any remaining data, put it into the tree as a separate item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7440 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jeff Morriss: rather than re-initializing the Info column with each
guy [Fri, 11 Apr 2003 20:19:45 +0000 (20:19 +0000)]
From Jeff Morriss: rather than re-initializing the Info column with each
PDU, just append the message type acronym to the column, so you can see
the message types for all the messages in the frame.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7439 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jeff Morriss: add support for the Chinese ITU variant of SS7.
guy [Thu, 10 Apr 2003 18:52:15 +0000 (18:52 +0000)]
From Jeff Morriss: add support for the Chinese ITU variant of SS7.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7438 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Anders Broman: decode ISUP element User service info as Q.931
guy [Thu, 10 Apr 2003 18:40:38 +0000 (18:40 +0000)]
From Anders Broman: decode ISUP element User service info as Q.931
Bearer capability.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7437 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe NT Security Descriptor revision field is only one byte, not two.
sahlberg [Thu, 10 Apr 2003 08:41:58 +0000 (08:41 +0000)]
The NT Security Descriptor  revision field is only one byte, not two.

Make the dissector decode the first two bytes of the security descriptor as
one byte for the revision and the second byte as nothing/should be zero.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7436 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoSome COL_INFO goodies for SpoolssWritePrinter.
tpot [Thu, 10 Apr 2003 05:38:43 +0000 (05:38 +0000)]
Some COL_INFO goodies for SpoolssWritePrinter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7435 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom David Frascone: use a string constant rather than a global variable
guy [Thu, 10 Apr 2003 01:30:34 +0000 (01:30 +0000)]
From David Frascone: use a string constant rather than a global variable
for the full name of the Diameter protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7434 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake the individual flag bits in the Connection Control field of the SPX
guy [Wed, 9 Apr 2003 22:33:19 +0000 (22:33 +0000)]
Make the individual flag bits in the Connection Control field of the SPX
header be filterable fields.

Don't hand retransmitted SPX frames to subdissectors - just show the
payload as a retransmission of the original frame.

Instead of handing a retransmission indicator to SPX subdissectors, hand
them a structure containing the datastream type (under the assumption
that it's data for the protocol running atop SPX, and that the dissector
for that protocol might use it) and the state of the end-of-message bit
(under the assumption that it's data for the protocol running atop SPX).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7433 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoInstead of using passing the SPX hash value to subdissectors, attach to
guy [Wed, 9 Apr 2003 20:45:04 +0000 (20:45 +0000)]
Instead of using passing the SPX hash value to subdissectors, attach to
frames that are retransmissions a data structure containing the frame
number of the original frame, and pass that to subdissectors (or, if not
present, pass NULL).

That means we can free the hash values when we're done with the first
pass through the packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7432 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate for NSIS 2.0
gerald [Wed, 9 Apr 2003 18:58:37 +0000 (18:58 +0000)]
Update for NSIS 2.0

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7431 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoSquelch a compiler warning - the problem "should not happen", as a
guy [Wed, 9 Apr 2003 18:35:27 +0000 (18:35 +0000)]
Squelch a compiler warning - the problem "should not happen", as a
WriteAndX request should have a full complement of word parameters, but,
just in cast it doesn't....

(Should we somehow arrange to throw an exception if there aren't enough
word or byte parameters in SMBs, i.e. impose a minimum in some cases?)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7430 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Tom Uijldert: properly decode the packet sequence number in WTP
guy [Wed, 9 Apr 2003 18:15:53 +0000 (18:15 +0000)]
From Tom Uijldert: properly decode the packet sequence number in WTP
Negative Ack packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7429 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate to WriteAndX request decoding so it can handle the pipe bits properly.
sahlberg [Wed, 9 Apr 2003 09:35:57 +0000 (09:35 +0000)]
Update to WriteAndX request decoding so it can handle the pipe bits properly.

If both mode bits  MessageStart and WriteRaw are set, then the first two bytes of the byte-field is the total length of the data written to the pipe.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7428 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdded new field reassembled_in to the fragment data structure.
sahlberg [Wed, 9 Apr 2003 09:04:08 +0000 (09:04 +0000)]
Added new field  reassembled_in  to the fragment data structure.

This field gets set to the frame number when this pdu was first completely reassembled.

This is useful since it will allow us to do reassembly properly in say packet-ip.c
instead of printing the full pdu for every fragment and thus making NFSoverUDP  rpc-rtt statistics less than useful.

A dissector using fragment_add() can tehn choose to only dissect the reassembled PDU only for the frame where it was first reassembled.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7427 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix some spelling/punctuation/capitalization/etc. errors.
guy [Wed, 9 Apr 2003 08:51:18 +0000 (08:51 +0000)]
Fix some spelling/punctuation/capitalization/etc. errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7426 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDon't create a protocol tree or do anything to the columns before
guy [Wed, 9 Apr 2003 08:43:53 +0000 (08:43 +0000)]
Don't create a protocol tree or do anything to the columns before
calling "tcp_dissect_pdus()", so that if we don't have the final segment
of a multi-segment packet, we don't change the columns or put in an
empty protocol tree item for NDPS.

Rename "ndps.desegment_ndps" to "ndps.desegment_tcp" - the "ndps." is
sufficient to indicate that it's for desegmenting NDPS, but we now have
a flag for desegmenting NDPS-over-SPX, so we should indicate that the
other flag is for desegmenting NDPS-over-TCP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7425 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoClean up the handling of the completion code.
guy [Wed, 9 Apr 2003 08:36:54 +0000 (08:36 +0000)]
Clean up the handling of the completion code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7424 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd "proto_tree_add_none_format()" to the set of functions exported to
guy [Tue, 8 Apr 2003 17:20:05 +0000 (17:20 +0000)]
Add "proto_tree_add_none_format()" to the set of functions exported to
plugins.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7423 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agomake-manuf:
jmayer [Tue, 8 Apr 2003 16:41:59 +0000 (16:41 +0000)]
make-manuf:
Sometimes printed a \n too much
manuf.tmpl:
Remove most manual Mappings to Cisco because that's what gets used
anyway (all except Racal and Newpoint)
manuf:
Update to represent changes in make-manuf, manuf.tmpl and IEEE

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7422 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWhen dissecting a reply, don't put the frame number of the corresponding
guy [Tue, 8 Apr 2003 03:00:32 +0000 (03:00 +0000)]
When dissecting a reply, don't put the frame number of the corresponding
request into the protocol tree if we haven't seen the request.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7421 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago"ndps_req_hash_cleanup()" doesn't need to do anything (the data
guy [Tue, 8 Apr 2003 02:45:05 +0000 (02:45 +0000)]
"ndps_req_hash_cleanup()" doesn't need to do anything (the data
structure it frees has no pointers to anything), so eliminate it.

The XID argument to "dissect_ndps_request()" isn't used, so eliminate
it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7420 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoGet rid of unused "ddp_dissector_table" variable.
guy [Tue, 8 Apr 2003 02:35:12 +0000 (02:35 +0000)]
Get rid of unused "ddp_dissector_table" variable.

For replies, correctly put the frame number of the corresponding request
into the protocol tree; don't put it in as if it were the XID.  That
means we don't need to pass the XID as an argument to
"dissect_ndps_reply()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7419 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMove the definition of the structure constructed for each SPX
guy [Tue, 8 Apr 2003 02:00:54 +0000 (02:00 +0000)]
Move the definition of the structure constructed for each SPX
transmission (and shared by all retransmissions), and passed to SPX
subdissectors, to "packet-ipx.h", and use the same structure in the SPX
dissector and the NDPS dissector.

Set up conversations and those structures without checking whether we've
seen the packet before or not; just check whether we find the
conversation before creating a new one, and check whether we find a
structure for the packet before creating a new one.  Pass it to the
subdissector regardless of whether we've seen the packet before or not,
and check it in the NDPS dissector regardless of whether we've seen it
before or not.

Don't store a "retransmission" flag in the structure - the initial
transmission and the retransmissions all share a single data structure,
but they don't all have the same value for the "retransmission" flag,
and you can tell whether a packet is a retransmission or not by
comparing its frame number with the frame number from the structure; if
they're different, it's a retransmission.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7418 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris: update the introductory comment, add defragmentation
guy [Tue, 8 Apr 2003 00:56:17 +0000 (00:56 +0000)]
From Greg Morris: update the introductory comment, add defragmentation
support, fix various bugs, and finish up the NDPS decodes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7417 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris: update the introductory comment, fix the handling
guy [Tue, 8 Apr 2003 00:46:15 +0000 (00:46 +0000)]
From Greg Morris: update the introductory comment, fix the handling
of the completion code, and tweak the description of continuation
fragments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7416 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris: update the introductory comment.
guy [Tue, 8 Apr 2003 00:40:37 +0000 (00:40 +0000)]
From Greg Morris: update the introductory comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7415 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris: update the introductory comment, and flag SPX
guy [Tue, 8 Apr 2003 00:39:27 +0000 (00:39 +0000)]
From Greg Morris: update the introductory comment, and flag SPX
retransmissions in the Info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7414 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris: update the introductory comment.
guy [Tue, 8 Apr 2003 00:22:26 +0000 (00:22 +0000)]
From Greg Morris: update the introductory comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7413 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris: level 2 oplock support, add additional error codes,
guy [Tue, 8 Apr 2003 00:07:01 +0000 (00:07 +0000)]
From Greg Morris: level 2 oplock support, add additional error codes,
fix the "Delete a File or Subdirectory" item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7412 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate to reflect the fact that you *HAVE* to have a Windows version of
guy [Mon, 7 Apr 2003 22:39:25 +0000 (22:39 +0000)]
Update to reflect the fact that you *HAVE* to have a Windows version of
Flex in order to build Ethereal, as the UNIX version generates files
that unconditionally include <unistd.h> and thus don't build on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7411 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoGet rid of the other Flex output files, so that they get rebuilt on
guy [Mon, 7 Apr 2003 18:43:03 +0000 (18:43 +0000)]
Get rid of the other Flex output files, so that they get rebuilt on
Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7410 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoChoosing the lower-numbered socket in an IPX packet as the first one to
guy [Sun, 6 Apr 2003 22:50:00 +0000 (22:50 +0000)]
Choosing the lower-numbered socket in an IPX packet as the first one to
try as a port number doesn't always give the right answer, as you might
have a name query packet from an SMB-over-IPX server, meaning it's from
IPX_SOCKET_NWLINK_SMB_SERVER to IPX_SOCKET_NWLINK_SMB_NAMEQUERY, and,
unfortunately, IPX_SOCKET_NWLINK_SMB_SERVER is less than
IPX_SOCKET_NWLINK_SMB_NAMEQUERY and it'll now be dissected as an SMB
packet rather than an NMPI name query packet.

So if the higher-numbered socket is IPX_SOCKET_NWLINK_SMB_NAMEQUERY, we
just try that, we don't try the other port.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7409 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom emre: add a "Filter out this stream" button to the "Follow TCP
guy [Sun, 6 Apr 2003 22:41:34 +0000 (22:41 +0000)]
From emre: add a "Filter out this stream" button to the "Follow TCP
Stream" window, which adds "and !(<filter for the stream>)" to the
display filter in effect before the stream was followed, removing that
stream from the display.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7408 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a dissector for the IPX WAN protocol. "IPX WAN 2" is just some
guy [Sun, 6 Apr 2003 02:32:38 +0000 (02:32 +0000)]
Add a dissector for the IPX WAN protocol.  "IPX WAN 2" is just some
compatible additions to the RFC 1362 IPX WAN protocol, so call it "IPX
WAN", not "IPX WAN 2".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7407 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWe use nothing from "nlpid.h", so we don't need to include it.
guy [Sun, 6 Apr 2003 02:31:35 +0000 (02:31 +0000)]
We use nothing from "nlpid.h", so we don't need to include it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7406 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoSeparate the scan for the BGP header from the scan through the BGP
guy [Sat, 5 Apr 2003 11:20:54 +0000 (11:20 +0000)]
Separate the scan for the BGP header from the scan through the BGP
packets, and mark any stuff before the first BGP header as continuation
data.

Make the main loop for dissecting the BGP packets similar to the loop in
"tcp_dissect_pdus()" (if "tcp_dissect_pdus()" took a starting offset as
an argument, we could use it), so that it handles a BGP header split
between TCP segments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7405 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoClean up white space.
guy [Thu, 3 Apr 2003 23:51:31 +0000 (23:51 +0000)]
Clean up white space.

Don't include "packet-smb-common.h", as there's nothing in it we use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7404 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd some additional fields to SMB-over-IPX dissection, as per what
guy [Thu, 3 Apr 2003 22:58:54 +0000 (22:58 +0000)]
Add some additional fields to SMB-over-IPX dissection, as per what
NetMon 2.x does.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7403 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd support for SMB-over-IPX.
guy [Thu, 3 Apr 2003 09:12:46 +0000 (09:12 +0000)]
Add support for SMB-over-IPX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7402 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWhen dissecting specific rights, pass a name string down so the
tpot [Thu, 3 Apr 2003 05:43:59 +0000 (05:43 +0000)]
When dissecting specific rights, pass a name string down so the
proto item says "foo specific rights" instead of just "specific
rights".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7401 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Laurent Rabret: add support for Multi Topology Reachable IPv4
guy [Thu, 3 Apr 2003 05:22:11 +0000 (05:22 +0000)]
From Laurent Rabret: add support for Multi Topology Reachable IPv4
Prefixes and Multi Topology Reachable IPv6 Prefixes from
draft-ietf-isis-wg-multi-topology-06.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7400 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd an extra argument to get_unicode_string() to optionally
tpot [Thu, 3 Apr 2003 02:57:48 +0000 (02:57 +0000)]
Add an extra argument to get_unicode_string() to optionally
pass back string data.

Start adding some COL_INFO tidbits for NETLOGON PDC query and PDC
query response.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7399 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd an extra argument to get_ms_string() so we can optionally pass
tpot [Thu, 3 Apr 2003 02:22:30 +0000 (02:22 +0000)]
Add an extra argument to get_ms_string() so we can optionally pass
back the value of the string to the caller.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7398 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a new README.developer file for wiretap; it's currently just some
guy [Wed, 2 Apr 2003 20:21:45 +0000 (20:21 +0000)]
Add a new README.developer file for wiretap; it's currently just some
stuff I sent out in a mail message to somebody asking how to add support
for a new file format, but hopefully it'll get improved by various
contributors over time (hint hint).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7397 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWe don't use snprintf, so we don't need to include snprintf.h.
guy [Wed, 2 Apr 2003 08:36:42 +0000 (08:36 +0000)]
We don't use snprintf, so we don't need to include snprintf.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7396 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago"proto_tree_add_text()" takes printf-style arguments; there's no need to
guy [Wed, 2 Apr 2003 08:31:37 +0000 (08:31 +0000)]
"proto_tree_add_text()" takes printf-style arguments; there's no need to
use snprintf to format a string into a buffer and then supply that
string to "proto_tree_add_text()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7395 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd support for WAN Hello packets.
guy [Wed, 2 Apr 2003 08:13:35 +0000 (08:13 +0000)]
Add support for WAN Hello packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7394 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Eric Perie: update to the name for EAP type 15, and some additional
guy [Tue, 1 Apr 2003 19:17:55 +0000 (19:17 +0000)]
From Eric Perie: update to the name for EAP type 15, and some additional
EAP types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7393 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Solomon Peachy: add support for the latest stuff defined in the
guy [Tue, 1 Apr 2003 19:05:55 +0000 (19:05 +0000)]
From Solomon Peachy: add support for the latest stuff defined in the
draft 7.1 of 802.11g, plus a few response codes defined in 802.11b.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7392 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Mike Frisch: NFS_ACL support.
guy [Tue, 1 Apr 2003 04:38:05 +0000 (04:38 +0000)]
From Mike Frisch: NFS_ACL support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7391 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd support for Level 1 Hello packets.
guy [Mon, 31 Mar 2003 23:38:37 +0000 (23:38 +0000)]
Add support for Level 1 Hello packets.

Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7390 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix a typo.
guy [Mon, 31 Mar 2003 23:37:37 +0000 (23:37 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7389 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe units, in non-whizzo-gigabit-pod captures, for hdr.timeunit = 2
guy [Mon, 31 Mar 2003 21:11:49 +0000 (21:11 +0000)]
The units, in non-whizzo-gigabit-pod captures, for hdr.timeunit = 2
aren't 1/1193000.0 second; the code used to use 1/1193180.0 second, but
at least one capture appears to have units of somewhere around
1/3579540.0 second.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7388 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd dissector for NetWare Link Services Protocol.
guy [Mon, 31 Mar 2003 08:10:08 +0000 (08:10 +0000)]
Add dissector for NetWare Link Services Protocol.

Socket 0x9001 is for NLSP - it supports LANs as well as WANs, at least
as I read the specification.

Socket 0x9004 is for "IPX WAN 2".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7387 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDon't use hardwired offsets when dissecting the ISIS header - we're
guy [Mon, 31 Mar 2003 08:09:28 +0000 (08:09 +0000)]
Don't use hardwired offsets when dissecting the ISIS header - we're
already advancing "offset" through the header, so use it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7386 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoHave separate subtree ett_ values for CLVs with LSP entries and for the
guy [Mon, 31 Mar 2003 07:44:09 +0000 (07:44 +0000)]
Have separate subtree ett_ values for CLVs with LSP entries and for the
LSP entries themselves.

The length and structure of an LSP entry isn't fixed, it depends on the
ID length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7385 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe "attached_string" doesn't apply to the attachments, so call it
guy [Mon, 31 Mar 2003 07:37:23 +0000 (07:37 +0000)]
The "attached_string" doesn't apply to the attachments, so call it
"supported_string", instead, as it is used to indicate whether partition
repair is supported.

Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7384 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDo the same for dissect_ndr_char_cvstring.
guy [Mon, 31 Mar 2003 07:26:18 +0000 (07:26 +0000)]
Do the same for dissect_ndr_char_cvstring.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7383 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Didier Gautheron: bug fix plus a new command decoded.
guy [Sun, 30 Mar 2003 22:14:06 +0000 (22:14 +0000)]
From Didier Gautheron: bug fix plus a new command decoded.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7382 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Hannes Gredler:
guy [Sun, 30 Mar 2003 22:10:13 +0000 (22:10 +0000)]
From Hannes Gredler:

- TLV 135 cleanup and support for subTLVs
- a common IP Reach subTLV dissector which dissects
    subTLV 1 & 2 [32 & 64 Bit Admin Tags as per
    draft-ietf-isis-admin-tags-01.txt]
- rework IPv6-related TLVs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7381 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIan Schorr discovered that, for gigabit pod captures, if hdr.timeunit is
guy [Fri, 28 Mar 2003 21:59:12 +0000 (21:59 +0000)]
Ian Schorr discovered that, for gigabit pod captures, if hdr.timeunit is
2 the time stamps are in units of 1/31250000 seconds rather than
nanoseconds - and, by generating Windows Sniffer captures with various
hdr.timeunit values, that for all the non-zero values he tested, the
time stamps for non-gigabit pod captures are in units of 1/1193000
second.

Instead of having a TpS array, just test for the exception value (0 for
non-gigabit pod captures, 2 for gigabit pod captures).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7380 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse FT_FRAMENUM for the "Duplicate to the ACK in frame" and "This is an
guy [Thu, 27 Mar 2003 19:55:59 +0000 (19:55 +0000)]
Use FT_FRAMENUM for the "Duplicate to the ACK in frame" and "This is an
ACK to the segment in frame" fields, so you can use the "Go To
Corresponding Frame" menu item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7379 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Laurent Rabret: fix bugs in ISIS LSP analyses, addi type block
guy [Thu, 27 Mar 2003 19:42:33 +0000 (19:42 +0000)]
From Laurent Rabret: fix bugs in ISIS LSP analyses, addi type block
filters and display the type block byte in a more standard way (bit
fields).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7378 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Olivier Biot: fix quotation of attibute values for the WAP
guy [Thu, 27 Mar 2003 19:23:10 +0000 (19:23 +0000)]
From Olivier Biot: fix quotation of attibute values for the WAP
Provisioning DTD representation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7377 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Olivier Biot:
guy [Thu, 27 Mar 2003 19:15:28 +0000 (19:15 +0000)]
From Olivier Biot:

* Fix the Extended Method PDU mapping (move code some lines down)
* Decode more WSP Parameter entries (now WAP Provisioning Push OK)
* First check whether the PDU content for Post, Reply and Push PDUs
  can be dissected (dissector_try_X function calls), if not then
  display the PDU data as "Data" in the WSP protocol tree.
* Replaced "Unsupported header" by "Undecoded header" for clarity

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7376 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoEnhancement to TCP Sequence Analysis
sahlberg [Thu, 27 Mar 2003 09:40:27 +0000 (09:40 +0000)]
Enhancement to TCP Sequence Analysis

Duplicate ACKs that are detected/suspected are now also flagged
with which frame the original ACK was seen in and the dup ack number.

This is displayed both in the summary pane as well as in the tree pane.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7375 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "gboolean" for Boolean variables.
guy [Wed, 26 Mar 2003 21:47:34 +0000 (21:47 +0000)]
Use "gboolean" for Boolean variables.

Allocate the per-conversation and per-frame data items from a GMemChunk
(which saves memory and CPU time, *and* lets us free all those items
quickly - as opposed to not freeing them at all, as had been the case).

Don't assume that, just because a conversation for the TCP connection
exists, it necessarily has an AJP13 data chunk attached to it; the
conversation might have, for example, been created by the TCP sequence
number analysis code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7374 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Graham Bloice: make the RC_VERSION variable in config.nmake
guy [Wed, 26 Mar 2003 20:17:42 +0000 (20:17 +0000)]
From Graham Bloice: make the RC_VERSION variable in config.nmake
comma-separated, so that the resources will be built correctly and the
version number correctly displayed in the GUI, and make the resources
dependent on "config.nmake" so that they're rebuilt if it's changed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7373 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Olivier Biot: add WSP protocol dissection for extended method PDUs,
guy [Wed, 26 Mar 2003 19:45:21 +0000 (19:45 +0000)]
From Olivier Biot: add WSP protocol dissection for extended method PDUs,
and let the Protocol Options header code page and extended methods calls
refer to hexadecimal representation as used everywhere else in the WSP
dissection code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7372 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFixed a small bug in tcp sequence number analysis.
sahlberg [Wed, 26 Mar 2003 08:00:24 +0000 (08:00 +0000)]
Fixed a small bug in tcp sequence number analysis.

FIN flag would previously only add one to the sequence number if the
FIN packet was empty, i.e. did not carry any payload data.

This caused ethereal to incorrectly flag the ACK to such packets
(FIN+payload data) to be incorrectly flagged as
ACK to previously lost segment.

Change the algorithm to always add 1 to the segment length, and thus the sequence number for all packets with teh FIN bit set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7371 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoPut in a comment about the "to what code does the configuration file
guy [Wed, 26 Mar 2003 00:34:27 +0000 (00:34 +0000)]
Put in a comment about the "to what code does the configuration file
directory belong" issue.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7370 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix up a comment.
guy [Tue, 25 Mar 2003 23:46:04 +0000 (23:46 +0000)]
Fix up a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7369 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "datafiledir" rather than "DATAFILE_DIR" as the name of the variable
guy [Tue, 25 Mar 2003 23:37:54 +0000 (23:37 +0000)]
Use "datafiledir" rather than "DATAFILE_DIR" as the name of the variable
in the configure script for the all-variables-expanded version of the
data file directory.

Don't AC_SUBST "DATAFILE_DIR", as it's not used.

Define DATAFILE_DIR in config.h as the all-variables-expanded version of
$datadir/ethereal, as that's where the global configuration files such
as manuf and the Diameter files are actually installed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7368 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDATAFILE_DIR in the top-level config.h isn't used; don't bother defining
guy [Tue, 25 Mar 2003 23:35:30 +0000 (23:35 +0000)]
DATAFILE_DIR in the top-level config.h isn't used; don't bother defining
it.  (Nothing other than "get_datafile_dir()" should use it - anything
that needs to know whether the configuration files are located should
use "get_datafile_dir()".)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7367 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThere's no need to define "etherealconfdir" - we can just use
guy [Tue, 25 Mar 2003 23:33:38 +0000 (23:33 +0000)]
There's no need to define "etherealconfdir" - we can just use
"pkgdatadir".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7366 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Brad Hards: ACAP support.
guy [Tue, 25 Mar 2003 22:30:19 +0000 (22:30 +0000)]
From Brad Hards: ACAP support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7365 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoNon-void functions must always return a value; the SID snooping tap
guy [Tue, 25 Mar 2003 19:52:56 +0000 (19:52 +0000)]
Non-void functions must always return a value; the SID snooping tap
listener isn't a GUI tap, so it should always return 0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7364 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate FAQ to 2003-03-20
jmayer [Tue, 25 Mar 2003 19:22:56 +0000 (19:22 +0000)]
Update FAQ to 2003-03-20

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7363 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdded SMB option : sid_name_snooping.
sahlberg [Tue, 25 Mar 2003 09:41:42 +0000 (09:41 +0000)]
Added SMB option : sid_name_snooping.

This feature, when enabled through Edit/preferences/protocols/smb,
will look at certain SMB and CIFS related protocols to discover the
mapping between SIDs and their Names.

For those SIDs whose name has been snooped/discovered ethereal will
also add "(<name>)" to the end of the SID when printed in the tree pane
through the function dissect_nt_sid().

Currently the feature is not too exciting since the only thing that packet-smb-sidsnooping.c will look at to build this mapping table is
replies to the LSA/QueryInfoPolicy infolevel 3  packets and thus
discover mappings between a Domain SID and a Domain Name.
In the near future this future will be enhanced to also look at more interesting calls such as LSA/LookupSIDs2 and similar.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7362 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAIX's BPF, and thus its tcpdump, appears to use 24 as the link-layer
guy [Tue, 25 Mar 2003 06:04:54 +0000 (06:04 +0000)]
AIX's BPF, and thus its tcpdump, appears to use 24 as the link-layer
type for loopback devices; map it to DLT_NULL when reading libpcap files
with a major version of 2 and a minor version of 2, and when capturing
from an "loN" device on AIX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7361 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix up the parsing of browser rest messages.
sharpe [Mon, 24 Mar 2003 16:49:10 +0000 (16:49 +0000)]
Fix up the parsing of browser rest messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7360 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd support for decoding Intel ANS probes. Thanks go to Intel for providing
gerald [Sun, 23 Mar 2003 19:32:19 +0000 (19:32 +0000)]
Add support for decoding Intel ANS probes.  Thanks go to Intel for providing
protocol information.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7359 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jeff Morriss fix:
guy [Fri, 21 Mar 2003 23:05:25 +0000 (23:05 +0000)]
From Jeff Morriss fix:

- endianism issues in most multi-octet parameters
- the size of pointers to variable and optional parameters in the LUDT
and LUDTS messages (ITU only)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7358 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd support for the missing ResetBrowserState announcement in
sharpe [Fri, 21 Mar 2003 05:28:04 +0000 (05:28 +0000)]
Add support for the missing ResetBrowserState announcement in
packet-smb-browse.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7357 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agochange dissect_ndr_wchar_cvstring so that it uses the hf_index the dissector has...
sahlberg [Mon, 17 Mar 2003 09:42:12 +0000 (09:42 +0000)]
change dissect_ndr_wchar_cvstring so that it uses the hf_index the dissector has passed to it and not the generic dcerpc_character_buffer.

we need this to be able to filter for various dcerpc related strings such as lsa.domain

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7356 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoTurn SIDs into FT_STRING fields so that we can filter for them using
sahlberg [Mon, 17 Mar 2003 09:02:49 +0000 (09:02 +0000)]
Turn SIDs into FT_STRING fields so that we can filter for them using
display filters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7355 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoRename hf_smb_sid to the more appropriate hf_smb_search_id
sahlberg [Mon, 17 Mar 2003 08:28:56 +0000 (08:28 +0000)]
Rename hf_smb_sid to the more appropriate hf_smb_search_id
since we will need hf_smb_sid for the SID string later

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7354 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Devin Heitmueller: for packets with an unknown family ID, display
guy [Fri, 14 Mar 2003 21:50:19 +0000 (21:50 +0000)]
From Devin Heitmueller: for packets with an unknown family ID, display
the family ID in hex in the summary line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7353 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake sure that we display all the file attributes ...
sharpe [Fri, 14 Mar 2003 00:46:54 +0000 (00:46 +0000)]
Make sure that we display all the file attributes ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7352 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Tomas Kukosa - allow a preference name to begin with the string
guy [Thu, 13 Mar 2003 18:17:59 +0000 (18:17 +0000)]
From Tomas Kukosa - allow a preference name to begin with the string
that's the name of the module, as long as the prefix doesn't end with
"." or "_" (so you can register "tc.tcp.port" or "tc.tcp_port", but not
"tc.tc.port" or "tc.tc_port").

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7351 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWhen fixing up old preferences, check the module for the current
guy [Wed, 12 Mar 2003 19:45:52 +0000 (19:45 +0000)]
When fixing up old preferences, check the module for the current
preference by comparing "module->name" against the module, not by
checking the first part of the preference name - the preference name
might not contain the correct module name, as we've mapped some modules.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7350 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Todd Montgomery: Bring PGM up to date with RFC 3208:
gerald [Wed, 12 Mar 2003 04:04:15 +0000 (04:04 +0000)]
From Todd Montgomery: Bring PGM up to date with RFC 3208:

        - checksum checks for all packets (like UDP, IP, TCP, etc.)
                - this includes adding an option to turn off checking
                  it in the preferences menu (like TCP does).
        - POLL packets
        - POLR packets
        - added PGM options:
                - OPT_FRAGMENT
                - OPT_REDIRECT
                - OPT_NAK_BO_IVL
                - OPT_NAK_BO_RNG
        - fixed a minor offset error in SPMs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7349 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Lars Roland: printf fix.
guy [Wed, 12 Mar 2003 00:36:22 +0000 (00:36 +0000)]
From Lars Roland: printf fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7348 f5534014-38df-0310-8fa8-9805f1628bb7