obnox/wireshark/wip.git
12 years agoAdd DeCount for his contribution in bug 6362.
cmaynard [Tue, 20 Sep 2011 16:42:22 +0000 (16:42 +0000)]
Add DeCount for his contribution in bug 6362.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39062 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom DeCount via bug 6362: Increase maximum allowable number of duplicate filesi...
cmaynard [Tue, 20 Sep 2011 16:28:21 +0000 (16:28 +0000)]
From DeCount via bug 6362: Increase maximum allowable number of duplicate filesi from 10 to 1000.  I modified his patch to avoid appending anything to the first filename, and other minor changes.
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6362

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39061 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Sylvain Munaut:
etxrab [Tue, 20 Sep 2011 11:29:53 +0000 (11:29 +0000)]
From Sylvain Munaut:
Add support for signed types in _proto_tree_add_bits_ret_val

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6363

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39060 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Dirk via bug 6361:
stig [Tue, 20 Sep 2011 10:15:09 +0000 (10:15 +0000)]
From Dirk via bug 6361:
Use File/Directory Dialog as a field type for UAT preferences.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39059 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Dirk via bug 6361:
stig [Tue, 20 Sep 2011 10:14:58 +0000 (10:14 +0000)]
From Dirk via bug 6361:
Add a File/Directory Dialog as a field type for UAT preferences.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39058 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoSince the call to expert_add_info_format() was commented out, 'ti' isn't needed,...
cmaynard [Mon, 19 Sep 2011 20:49:28 +0000 (20:49 +0000)]
Since the call to expert_add_info_format() was commented out, 'ti' isn't needed, so get rid of it.  Fixes Coverity CID's 1260 and 1261.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39057 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoDon't assign the return value of proto_tree_add_text() if it's not going to be used...
cmaynard [Mon, 19 Sep 2011 20:41:17 +0000 (20:41 +0000)]
Don't assign the return value of proto_tree_add_text() if it's not going to be used.  Fixes Coverity CID 1232.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39056 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoSince the call to proto_tree_add_text() was #if 0'd out, there's no need to assign...
cmaynard [Mon, 19 Sep 2011 20:37:20 +0000 (20:37 +0000)]
Since the call to proto_tree_add_text() was #if 0'd out, there's no need to assign the return value of tvb_new_subset to wlan_tvb.  Actually, there's probably no need to call tvb_new_subset() in the first place, but for now let's just tackle the unused value warning and leave the FIXME for someone who knows more about this.  Fixes Coverity CID 864.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39055 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoDon't assign return value of proto_tree_add_text() to rrsc_item if it's not going...
cmaynard [Mon, 19 Sep 2011 20:28:10 +0000 (20:28 +0000)]
Don't assign return value of proto_tree_add_text() to rrsc_item if it's not going to be used.  Fixes Coverity CID 863.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39054 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoMove the return out of the for() loop so all values are freed. Fixes Coverity CID...
cmaynard [Mon, 19 Sep 2011 20:19:43 +0000 (20:19 +0000)]
Move the return out of the for() loop so all values are freed.  Fixes Coverity CID 1277 (loop increment j++ is unreachable).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39053 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoThe change in r37371 fixed the clv_tree unused assignment and pointless use, but...
cmaynard [Mon, 19 Sep 2011 20:09:31 +0000 (20:09 +0000)]
The change in r37371 fixed the clv_tree unused assignment and pointless use, but caused another unused assignment to 'ti'.  Fixed.  (Coverity CID 1233)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39052 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoDon't assign the return value of proto_tree_add_item() if it's not going to be used...
cmaynard [Mon, 19 Sep 2011 19:59:00 +0000 (19:59 +0000)]
Don't assign the return value of proto_tree_add_item() if it's not going to be used.  Fixes Coverity CID's 1278-1280 (UNUSED VALUE).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39051 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoDelete duplicate line of code. Fixes Coverity CID 1281 (UNUSED VALUE).
cmaynard [Mon, 19 Sep 2011 19:49:06 +0000 (19:49 +0000)]
Delete duplicate line of code.  Fixes Coverity CID 1281 (UNUSED VALUE).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39050 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoClose fp before checking if private_key is NULL to avoid memory leak. Fixes Coverity...
cmaynard [Mon, 19 Sep 2011 19:32:46 +0000 (19:32 +0000)]
Close fp before checking if private_key is NULL to avoid memory leak.  Fixes Coverity 597.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39049 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix static overrun bug introduced in r37506. Fixes Coverity CID 1216.
cmaynard [Mon, 19 Sep 2011 19:14:41 +0000 (19:14 +0000)]
Fix static overrun bug introduced in r37506.  Fixes Coverity CID 1216.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39048 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoVarious Cleanups...
wmeier [Mon, 19 Sep 2011 19:13:34 +0000 (19:13 +0000)]
Various Cleanups...
- Don't use 'l' as a variable name;
- Use 'tvb_strsize();proto_tree_add_item();' iso 'tvb_get_ephemeral_stringz(); proto_tree_add_string();'
- Use ENC_NA/ENC_BIG_ENDIAN iso FALSE as appropriate for proto_tree_add_item().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39047 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix compile error: just link to expert_group_vals[] in expert.c (no need for a copy...
wmeier [Mon, 19 Sep 2011 17:59:20 +0000 (17:59 +0000)]
Fix compile error: just link to expert_group_vals[] in expert.c (no need for a copy in tap-expert.c).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39046 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd expert 'Group' to output.
martinm [Mon, 19 Sep 2011 13:53:29 +0000 (13:53 +0000)]
Add expert 'Group' to output.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39045 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUse ENC_NA and ENC_BIG_ENDIAN rather than FALSE in proto_tree_add_item()
guy [Mon, 19 Sep 2011 11:02:35 +0000 (11:02 +0000)]
Use ENC_NA and ENC_BIG_ENDIAN rather than FALSE in proto_tree_add_item()
calls and tvb_get_guid() calls.

For strings, add ENC_UTF_8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39044 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix a crash when zooming into a TSN plot.
tuexen [Mon, 19 Sep 2011 10:23:36 +0000 (10:23 +0000)]
Fix a crash when zooming into a TSN plot.

Provided by Irene Ruengeler.
From me: remove tailing whitespaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39043 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoRFC 4282 says the NAI is UTF-8.
guy [Mon, 19 Sep 2011 10:17:27 +0000 (10:17 +0000)]
RFC 4282 says the NAI is UTF-8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39042 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUse ENC_NA and ENC_LITTLE_ENDIAN rather than TRUE or FALSE in
guy [Mon, 19 Sep 2011 10:10:14 +0000 (10:10 +0000)]
Use ENC_NA and ENC_LITTLE_ENDIAN rather than TRUE or FALSE in
proto_tree_add_item() calls.

For strings, add ENC_UTF_8.  (Yes, the byte order is irrelevant for
those - but they should arguably be FT_UINT_STRING, as they're counted
strings, and the byte order *is* relevant for FT_UINT_STRING.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39041 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoSome probably-erroneous TRUEs as the last argument to
guy [Mon, 19 Sep 2011 09:55:36 +0000 (09:55 +0000)]
Some probably-erroneous TRUEs as the last argument to
proto_tree_add_item(); the items were one byte long, so the byte order
is irrelevant.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39040 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUse ENC_BIG_ENDIAN instead of FALSE in proto_tree_add_item() calls for
guy [Mon, 19 Sep 2011 09:52:37 +0000 (09:52 +0000)]
Use ENC_BIG_ENDIAN instead of FALSE in proto_tree_add_item() calls for
integral values.

For the Network Access Identifier, use ENC_UTF_8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39039 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoMove stuff inside if(tree)
etxrab [Mon, 19 Sep 2011 08:37:59 +0000 (08:37 +0000)]
Move stuff inside if(tree)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39038 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Martin Kaiser:
etxrab [Mon, 19 Sep 2011 08:37:10 +0000 (08:37 +0000)]
From Martin Kaiser:
DVB-CI / CI+ Application MMI version 2

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6352

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39037 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoMake it possiblwe to creare a trime string from frame data.
etxrab [Mon, 19 Sep 2011 05:15:58 +0000 (05:15 +0000)]
Make it possiblwe to creare a trime string from frame data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39036 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoRemove debug code.
etxrab [Mon, 19 Sep 2011 05:13:06 +0000 (05:13 +0000)]
Remove debug code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39035 f5534014-38df-0310-8fa8-9805f1628bb7

12 years ago[Automatic manuf, services and enterprise-numbers update for 2011-09-18]
gerald [Sun, 18 Sep 2011 14:03:28 +0000 (14:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-09-18]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39032 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUpdate sub-object types of XRO to match RFC 5521. Fixes https://bugs.wireshark.org...
cmaynard [Sat, 17 Sep 2011 03:58:41 +0000 (03:58 +0000)]
Update sub-object types of XRO to match RFC 5521.  Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3778.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39031 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Pierre-Marie de Rodat: PostgreSQL Startup message not properly supported by...
wmeier [Fri, 16 Sep 2011 20:08:46 +0000 (20:08 +0000)]
From Pierre-Marie de Rodat: PostgreSQL Startup message not properly supported by the PostgreSQL dissector.

"The PostgreSQL dissector do not fully support the frontend StartupMessage (see
"StartupMessage" in
http://developer.postgresql.org/pgdocs/postgres/protocol-message-formats.html).
The couples parameter name/parameter value in this kind of message are reported
as a block of text ("name: value") by the dissector whereas reporting them as
parameter name/parameter value would be more appropriate.

I've fixed it, so now the username and the database sent by the frontend can be
handled in, for instance, the CSV output of TShark.

I've also added a "val_count" field to contain the number of values (row
descriptions or row data) included in RowDescription/DataRow messages. This
information is useful when analyzing the CSV of TShark since in a CSV row, many
row descriptions or row data may be packed together."

Patch changes from me:
- No need to fetch ephemeral string anymore so just use tvb_strsize()
  to get string length;
- Change field-filtername from pgsql.val.count to pgsql.field.count

See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6343

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39030 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd dissection of router address(R) flag. Fixes https://bugs.wireshark.org/bugzilla...
cmaynard [Fri, 16 Sep 2011 19:23:26 +0000 (19:23 +0000)]
Add dissection of router address(R) flag.  Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6350.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39029 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix a crash when analysing SCTP TSNs.
tuexen [Fri, 16 Sep 2011 15:32:28 +0000 (15:32 +0000)]
Fix a crash when analysing SCTP TSNs.

Provided by Irene Ruengeler.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39028 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoset_abs_time and friends always return 1.
etxrab [Fri, 16 Sep 2011 14:25:50 +0000 (14:25 +0000)]
set_abs_time and friends always return 1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39027 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Sylvain Munaut:
etxrab [Fri, 16 Sep 2011 06:12:12 +0000 (06:12 +0000)]
From Sylvain Munaut:
proto: Use fill_label_xxx helpers in _proto_tree_add_bits_ret_val

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6329

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39026 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoChange encoding type from TRUE/FALSE to ENC_LITTLE_ENDIAN/ ENC_BIG_ENDIAN
etxrab [Fri, 16 Sep 2011 05:36:48 +0000 (05:36 +0000)]
Change encoding type from TRUE/FALSE to ENC_LITTLE_ENDIAN/ ENC_BIG_ENDIAN

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39025 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Fri, 16 Sep 2011 05:16:18 +0000 (05:16 +0000)]
From Jouni Malinen:
If the GAS Query Request/Response Length field is incorrect, the
dissector function may return a value that is larger than the remaining
packet buffer. This results in a Tagged parameters item being added with
-1 byte length since tvb_reported_length_remaining() reports -1 once the
offset goes beyond the end of the packet. Clicking on that item results
in Wireshark dying on Gtk-ERROR. Note: this does not show up in tshark
and as such, cannot apparently be triggered with fuzz-test.sh.

Fix this by refusing to dissect GAS frames that have too large length
field value. In addition, verify that tvb_reported_length_remaining() is
returning a value larger than 0 instead of non-zero (which could be -1)
to make the IEEE 802.11 dissector more robust against this type of
issues.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6345

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39024 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Fri, 16 Sep 2011 05:10:37 +0000 (05:10 +0000)]
From Jouni Malinen:
- Dissect ANQP Network Authentication Type
- Dissect ANQP Domain Name List
- Dissect Interworking element
- Dissect Roaming Consortium element
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39023 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Liam Sharp:
etxrab [Fri, 16 Sep 2011 04:55:58 +0000 (04:55 +0000)]
From Liam Sharp:
In VoIP calls flow/graph display replace GR/GI etc with presentationTokenRequest/Response etc

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6321

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39022 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agowsdg_graphics/toolbar is a directory; fix the rules that weren't already
guy [Fri, 16 Sep 2011 00:21:21 +0000 (00:21 +0000)]
wsdg_graphics/toolbar is a directory; fix the rules that weren't already
fixed to cope with that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39021 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoWell, that wasn't it. Put the dummy file back.
guy [Fri, 16 Sep 2011 00:13:08 +0000 (00:13 +0000)]
Well, that wasn't it.  Put the dummy file back.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39020 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoDelete a dummy file to see if it makes building the docbook stuff with
guy [Thu, 15 Sep 2011 23:32:44 +0000 (23:32 +0000)]
Delete a dummy file to see if it makes building the docbook stuff with
nmake on Windows work again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39019 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Pierre-Marie de Rodat:
etxrab [Thu, 15 Sep 2011 20:11:12 +0000 (20:11 +0000)]
From Pierre-Marie de Rodat:
MySQL’s response for a “prepare statement” command not supported by the MySQL dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6342

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39018 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Pascal Quantin:
etxrab [Thu, 15 Sep 2011 20:02:19 +0000 (20:02 +0000)]
From Pascal Quantin:
Incorrect decoding of BIT STRING type

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6347

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39017 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 19:54:02 +0000 (19:54 +0000)]
From Jouni Malinen:
-Dissect ANQP Roaming Consortium list
-Dissect ANQP IP Address Type Availability
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39016 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 19:49:37 +0000 (19:49 +0000)]
From Jouni Malinen:
Dissect ANQP Capability List
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39015 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 19:46:24 +0000 (19:46 +0000)]
From Jouni Malinen:
Dissect ANQP Venue Name info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39014 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 19:44:08 +0000 (19:44 +0000)]
From Jouni Malinen:
Dissect ANQP Query List
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39013 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 19:41:53 +0000 (19:41 +0000)]
From Jouni Malinen:
Append ANQP information to COL_INFO
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39012 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 19:38:23 +0000 (19:38 +0000)]
From Jouni Malinen:
Remove unnecessary Action subtree
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39011 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd a tap for showing all expert items.
martinm [Thu, 15 Sep 2011 10:30:57 +0000 (10:30 +0000)]
Add a tap for showing all expert items.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39010 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAlphabetical order, please.
guy [Thu, 15 Sep 2011 06:56:57 +0000 (06:56 +0000)]
Alphabetical order, please.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39009 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 06:53:42 +0000 (06:53 +0000)]
From Jouni Malinen:
ieee80211: Support multiple ANQP info elements in response

ANQP Query Response may include multiple ANQP info elements. Parse each
one of these separately. In addition, clean up three ANQP subtrees to
avoid the unnecessary subtree at higher layer and instead, use a
separate subtree for each ANQP info elements.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39008 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 06:50:26 +0000 (06:50 +0000)]
From Jouni Malinen:
ieee80211: Show ANQP adv proto on subtree title line

This makes it easier to get the most significant information from the
Advertisement Protocol element in GAS messages without having to expand
subtrees.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39007 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 06:46:57 +0000 (06:46 +0000)]
From Jouni Malinen:
ieee80211: Do not add duplicate tag number/len for adv proto

dissect_advertisement_protocol() is used both for ANQP and for parsing
IEs. The tag number/length fields need to be added only for ANQP to
avoid adding duplicate entries in the proto tree.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39006 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 06:44:20 +0000 (06:44 +0000)]
From Jouni Malinen:
ieee80211: Verify ANQP info header

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39005 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 06:41:19 +0000 (06:41 +0000)]
From Jouni Malinen:
preparation for adding new dissectors for various ANQP info

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39004 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 06:34:25 +0000 (06:34 +0000)]
From Jouni Malinen:
ieee80211: Update ANQP info ID per P802.11-REVmb/D10.0

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39003 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 06:31:48 +0000 (06:31 +0000)]
From Jouni Malinen:
IEEE 802.11u: Add Element IDs

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39002 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 06:26:51 +0000 (06:26 +0000)]
From Jouni Malinen:
IEEE 802.11u: Add new Extended Capabilities

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39001 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Jouni Malinen:
etxrab [Thu, 15 Sep 2011 06:23:49 +0000 (06:23 +0000)]
From Jouni Malinen:
improvements for IEEE Std 802.11u-2011 dissection.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6339

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39000 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoStore frame_data_t instead of nstime_t, now it should be possible
etxrab [Thu, 15 Sep 2011 05:59:09 +0000 (05:59 +0000)]
Store frame_data_t instead of nstime_t, now it should be possible
to implement using the same time format as chosen in the packetlist.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38999 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoTrivial fix that would create one of the three GDK_DEPRECATED errors.
jmayer [Wed, 14 Sep 2011 21:36:29 +0000 (21:36 +0000)]
Trivial fix that would create one of the three GDK_DEPRECATED errors.
Use the #define instead of "font"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38998 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUpdate based upon latest names "packet-type-codes" list from the IANA:
wmeier [Wed, 14 Sep 2011 18:45:06 +0000 (18:45 +0000)]
Update based upon latest names "packet-type-codes" list from the IANA:
- Change some type-code names to match IANA list;
- Handle additional type-codes as given in the IANA list;
- Don't consider certain "attribute types" to be valid packet-type codes
  See Bug 6335: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6335
- Minor code cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38997 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoMake the network_usb.svg image public domain.
gerald [Wed, 14 Sep 2011 17:39:19 +0000 (17:39 +0000)]
Make the network_usb.svg image public domain.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38996 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd #define guard.
stig [Wed, 14 Sep 2011 14:53:49 +0000 (14:53 +0000)]
Add #define guard.

This fixes bug 6341.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38995 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoShow total ACKs/UE in UE table.
martinm [Wed, 14 Sep 2011 13:32:42 +0000 (13:32 +0000)]
Show total ACKs/UE in UE table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38994 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAdd a dummy file so building the docbook stuff with cmake actually works.
jmayer [Wed, 14 Sep 2011 13:23:10 +0000 (13:23 +0000)]
Add a dummy file so building the docbook stuff with cmake actually works.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38993 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoClose up space between ENC_BIG_ENDIAN) and ;.
guy [Wed, 14 Sep 2011 07:16:26 +0000 (07:16 +0000)]
Close up space between ENC_BIG_ENDIAN) and ;.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38992 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Aaron Schrab:
etxrab [Wed, 14 Sep 2011 07:04:45 +0000 (07:04 +0000)]
From Aaron Schrab:
AMQP dissector support for Exchange Bind method.
- From me simplify writing to column.
- remove deprecated check_col
- Use ENC_BIG_ENDIAN.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6327

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38991 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAlways pass the FCS length to dissect_802_3() and ethertype(), so it
guy [Tue, 13 Sep 2011 21:17:45 +0000 (21:17 +0000)]
Always pass the FCS length to dissect_802_3() and ethertype(), so it
will process the FCS if it's known to be present and will attempt to
guess whether it's present if it's not known not to be present.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38990 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoDon't include files from epan in wsutil.
stig [Tue, 13 Sep 2011 18:36:46 +0000 (18:36 +0000)]
Don't include files from epan in wsutil.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38989 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix a typo in a comment.
gerald [Tue, 13 Sep 2011 17:10:12 +0000 (17:10 +0000)]
Fix a typo in a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38988 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoAs the man said, ports are unsigned.
guy [Tue, 13 Sep 2011 16:39:17 +0000 (16:39 +0000)]
As the man said, ports are unsigned.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38987 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoThe "Uri-Port" option is an unsigned, not signed, integer according to
sfisher [Tue, 13 Sep 2011 16:14:28 +0000 (16:14 +0000)]
The "Uri-Port" option is an unsigned, not signed, integer according to
its hf definition and deraft-ietf-core-coap-04 for example.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38986 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoSet WIRESHARK_ABORT_ON_DISSECTOR_BUG when running test-fuzzed-cap.sh
sfisher [Tue, 13 Sep 2011 15:52:07 +0000 (15:52 +0000)]
Set WIRESHARK_ABORT_ON_DISSECTOR_BUG when running test-fuzzed-cap.sh
to get a stack trace/core dump on dissector bugs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38985 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUse Frame_data also in graph_analysis_item_t, this should ultimately
etxrab [Tue, 13 Sep 2011 12:39:11 +0000 (12:39 +0000)]
Use Frame_data also in graph_analysis_item_t, this should ultimately
make it possible to use absolute time in the graph.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38984 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoSkip extra info if present (IP with LTE PDCP threading info).
martinm [Tue, 13 Sep 2011 12:14:24 +0000 (12:14 +0000)]
Skip extra info if present (IP with LTE PDCP threading info).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38983 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoStore a pointer to frame_data which holds the timing and frame number info rather...
etxrab [Tue, 13 Sep 2011 05:29:56 +0000 (05:29 +0000)]
Store a pointer to frame_data which holds the timing and frame number info rather than making copies. Move a structure only used internaly from voip_calls.h to .c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38982 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoStore a pointer to frame_data which holds the timing and frame number info rather...
etxrab [Mon, 12 Sep 2011 19:32:49 +0000 (19:32 +0000)]
Store a pointer to frame_data which holds the timing and frame number info rather than making copies.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38981 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix a typo
etxrab [Mon, 12 Sep 2011 16:09:36 +0000 (16:09 +0000)]
Fix a typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38978 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Danny Breton: Property name time-synchronization-interval(204) is incorrectly...
wmeier [Mon, 12 Sep 2011 15:44:45 +0000 (15:44 +0000)]
From Danny Breton: Property name time-synchronization-interval(204) is incorrectly shown as time-synchronization-recipents.

See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6336

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38977 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoLeading white space in the field descriptive name is not allowed.
etxrab [Mon, 12 Sep 2011 14:30:41 +0000 (14:30 +0000)]
Leading white space in the field descriptive name is not allowed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38976 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUse the correct name for the airpcap interface.
tuexen [Mon, 12 Sep 2011 13:39:14 +0000 (13:39 +0000)]
Use the correct name for the airpcap interface.
While there, clean up some whitespaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38975 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFix the wireless settings button for AirPCap devices in the
tuexen [Mon, 12 Sep 2011 13:13:08 +0000 (13:13 +0000)]
Fix the wireless settings button for AirPCap devices in the
Edit Interface dialog box.

Obtained from Irene Ruengeler.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38974 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoMove airpcap_wep.c to /wsutil CMakefile changes
etxrab [Mon, 12 Sep 2011 13:07:54 +0000 (13:07 +0000)]
Move airpcap_wep.c to /wsutil CMakefile changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38973 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUpdate to V10.2.0 (2011-06)
etxrab [Mon, 12 Sep 2011 13:00:11 +0000 (13:00 +0000)]
Update to V10.2.0 (2011-06)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38972 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUpdate to V9.6.0 (2011-06)
etxrab [Mon, 12 Sep 2011 12:48:00 +0000 (12:48 +0000)]
Update to  V9.6.0 (2011-06)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38971 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Liam Sharp:
etxrab [Mon, 12 Sep 2011 08:37:36 +0000 (08:37 +0000)]
From Liam Sharp:
VoIP Calls->Graph TCS and OLC display corruption.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6318

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38970 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoMove airpcap_wep.c to /wsutil
etxrab [Mon, 12 Sep 2011 08:23:15 +0000 (08:23 +0000)]
Move airpcap_wep.c to /wsutil

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38969 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agofrom Liam Sharp:
etxrab [Mon, 12 Sep 2011 06:02:43 +0000 (06:02 +0000)]
from Liam Sharp:
Info column to show subMessageIdentifier type strings for H245/H.239 packets

With a change to remove "subMessageIdentifer=" as I think that clutters up the Infocol.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6315

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38968 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Michael Mann:
etxrab [Sun, 11 Sep 2011 19:54:11 +0000 (19:54 +0000)]
From Michael Mann:
Extend 64-bit SDNV decoding to Administrative Records.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4109

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38967 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Martin Kaiser:
etxrab [Sun, 11 Sep 2011 19:16:54 +0000 (19:16 +0000)]
From Martin Kaiser:
DVB-CI / CI+ Specific Application Support (SAS) resource
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6334

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38966 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Martin Kaiser:
etxrab [Sun, 11 Sep 2011 19:13:27 +0000 (19:13 +0000)]
From Martin Kaiser:
DVB-CI / CI+ Application MMI resource.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6332

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38965 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoFrom Pascal Quantin:
etxrab [Sun, 11 Sep 2011 19:09:02 +0000 (19:09 +0000)]
From Pascal Quantin:
Update of 3GPP RRC and LTE RRC dissectors.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6333

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38964 f5534014-38df-0310-8fa8-9805f1628bb7

12 years ago[Automatic manuf, services and enterprise-numbers update for 2011-09-11]
gerald [Sun, 11 Sep 2011 14:03:28 +0000 (14:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-09-11]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38961 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoUpdate some comments.
martinm [Sat, 10 Sep 2011 23:46:49 +0000 (23:46 +0000)]
Update some comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38960 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoGet rid of redundant blurbs.
guy [Sat, 10 Sep 2011 16:33:51 +0000 (16:33 +0000)]
Get rid of redundant blurbs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38959 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoDCE/RPC: FRSRPC: updates to the FRS dissector
sahlberg [Sat, 10 Sep 2011 11:15:20 +0000 (11:15 +0000)]
DCE/RPC: FRSRPC: updates to the FRS dissector

From: Matthieu Patou <mat@matws.net>

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38958 f5534014-38df-0310-8fa8-9805f1628bb7

12 years agoDCE/RPC MGMT: Add dissection of INQ_PRINC_NAME procedure
sahlberg [Sat, 10 Sep 2011 11:04:42 +0000 (11:04 +0000)]
DCE/RPC MGMT: Add dissection of INQ_PRINC_NAME procedure

From: Matthieu Patou <mat@matws.net>

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38957 f5534014-38df-0310-8fa8-9805f1628bb7