obnox/wireshark/wip.git
14 years agoFix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4402 :
morriss [Tue, 26 Jan 2010 01:40:10 +0000 (01:40 +0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4402 :

Escape all non-printable characters so that we generate valid PDML.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31674 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some gcc -Wshadow warnings
wmeier [Tue, 26 Jan 2010 01:00:15 +0000 (01:00 +0000)]
Fix some gcc -Wshadow warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31673 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHandle escape/unescape underscore when read/write the preferences
stig [Mon, 25 Jan 2010 21:45:17 +0000 (21:45 +0000)]
Handle escape/unescape underscore when read/write the preferences
column.format entries.  Also fix a small memory leakage.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31670 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Mon, 25 Jan 2010 20:58:24 +0000 (20:58 +0000)]
From Jakub Zawadzki:
- Create only one marker in packet_hex_print_common.
- Set start & end values in good keys.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4403

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31669 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHandle underscore escaping/unescaping for old packet list; Simplify
dimeg [Mon, 25 Jan 2010 20:30:09 +0000 (20:30 +0000)]
Handle underscore escaping/unescaping for old packet list; Simplify
and make more robust the unescaping function.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31668 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mike Morrin:
etxrab [Mon, 25 Jan 2010 20:14:34 +0000 (20:14 +0000)]
From Mike Morrin:
Empty GPRS LLC S frames cause truncated data exception.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4417

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31667 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a field to allow easy filtering of one SN of interest.
martinm [Mon, 25 Jan 2010 18:32:18 +0000 (18:32 +0000)]
Add a field to allow easy filtering of one SN of interest.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31666 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
dimeg [Mon, 25 Jan 2010 18:26:47 +0000 (18:26 +0000)]
From Jakub Zawadzki:
Remove prepare_bits_string from proto.c; Use
equivalent function decode_bits_in_field in to_str.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31665 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Didier Gautheron via bug 4420:
stig [Mon, 25 Jan 2010 18:24:14 +0000 (18:24 +0000)]
From Didier Gautheron via bug 4420:
Call p_add_proto_data only once.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31664 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Didier Gautheron via bug 4420:
stig [Mon, 25 Jan 2010 18:22:56 +0000 (18:22 +0000)]
From Didier Gautheron via bug 4420:
Use se_alloc rather than g_malloc for proto_data.
Call conversation_add_proto_data only once.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31663 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange the prefix of the underscore escaping/unescaping
dimeg [Mon, 25 Jan 2010 18:14:01 +0000 (18:14 +0000)]
Change the prefix of the underscore escaping/unescaping
functions from g_ to ws_; Insert function names in
libwireshark.def

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31662 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Pascal Quantin: fid some LTE MAC and PDCP typos
martinm [Mon, 25 Jan 2010 16:45:46 +0000 (16:45 +0000)]
From Pascal Quantin: fid some LTE MAC and PDCP typos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31661 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoved gnuc_format_check.h
stig [Mon, 25 Jan 2010 16:21:46 +0000 (16:21 +0000)]
Removed gnuc_format_check.h
Added g_gnuc_malloc.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31660 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange back from tvb_child_uncompress() to tvb_uncompress() when
stig [Mon, 25 Jan 2010 13:58:07 +0000 (13:58 +0000)]
Change back from tvb_child_uncompress() to tvb_uncompress() when
parent is NULL, because this will lead to a DISSECTOR_ASSERT in
tvb_set_child_real_data_tvbuff().

This bug was introduced in revision 31499.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31659 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoparent is not unused in tvb_child_uncompress().
stig [Mon, 25 Jan 2010 13:54:05 +0000 (13:54 +0000)]
parent is not unused in tvb_child_uncompress().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31658 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChanged from using own defined GNUC_FORMAT_CHECK to G_GNUC_PRINTF
stig [Mon, 25 Jan 2010 13:20:53 +0000 (13:20 +0000)]
Changed from using own defined GNUC_FORMAT_CHECK to G_GNUC_PRINTF
defined in GLib.  Removed epan/gnuc_format_check.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31657 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Didier Gautheron via bug 4419:
stig [Mon, 25 Jan 2010 12:50:42 +0000 (12:50 +0000)]
From Didier Gautheron via bug 4419:
Use G_GNUC_MALLOC in emem.h declarations.

From me:
Check for valid G_GNUC_MALLOC from g_gnuc_malloc.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31656 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a header file to check for G_GNUC_MALLOC.
stig [Mon, 25 Jan 2010 12:49:27 +0000 (12:49 +0000)]
Add a header file to check for G_GNUC_MALLOC.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31655 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Didier Gautheron via bug 4419:
stig [Mon, 25 Jan 2010 11:47:39 +0000 (11:47 +0000)]
From Didier Gautheron via bug 4419:
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31654 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoEnsure we don't write outside the pref_str in put_string_list().
stig [Mon, 25 Jan 2010 10:22:00 +0000 (10:22 +0000)]
Ensure we don't write outside the pref_str in put_string_list().

This bug was introduced in revision 31487, when putting each
column.format entry on separate lines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31653 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd nice dissection of the names of the sign/seal algorithms
sahlberg [Mon, 25 Jan 2010 05:58:26 +0000 (05:58 +0000)]
Add nice dissection of the names of the sign/seal algorithms
in the schannel verifier

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31652 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd proper dissection of NL_AUTH_MESSAGE for schannel as described in
sahlberg [Mon, 25 Jan 2010 05:43:12 +0000 (05:43 +0000)]
Add proper dissection of NL_AUTH_MESSAGE for schannel as described in
MS-NRPC 2.2.1.3.1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31651 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExport the dissect_mscldap_string() that is used to dissect
sahlberg [Mon, 25 Jan 2010 05:38:22 +0000 (05:38 +0000)]
Export the  dissect_mscldap_string() that is used to dissect
compressed dns strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31650 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHandle underscore escaping/unescaping of the column titles
dimeg [Sun, 24 Jan 2010 22:25:40 +0000 (22:25 +0000)]
Handle underscore escaping/unescaping of the column titles
under the new packet list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31649 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate the URL of the PDML spec
morriss [Sun, 24 Jan 2010 22:11:31 +0000 (22:11 +0000)]
Update the URL of the PDML spec

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31648 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Hadar Shoham:
jake [Sun, 24 Jan 2010 22:06:29 +0000 (22:06 +0000)]
From Hadar Shoham:
Add Packet Cable 2.0 bootp option 60 support:
sub-option 01 new type value 2 for packet cable 2.0
sub-option 1a new sun-option "Certificate Bootstrapping Support" length 01,
value 1 for support and 0 for not supported.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31647 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoved trailing TAB.
stig [Sun, 24 Jan 2010 21:18:50 +0000 (21:18 +0000)]
Removed trailing TAB.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31646 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alexis La Goutte via bug 4418:
stig [Sun, 24 Jan 2010 20:52:50 +0000 (20:52 +0000)]
From Alexis La Goutte via bug 4418:
Aruba Wireless Controller support a Remote Monitoring of Access Point
The code is based en HP ERM/Cisco ERSPAN dissectors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31645 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen a custom column is added, escape the underscores in the name of
dimeg [Sun, 24 Jan 2010 19:57:21 +0000 (19:57 +0000)]
When a custom column is added, escape the underscores in the name of
the column so that the underscores are printed and the next characters
are not interpreted as accelerators.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31644 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago[Automatic manuf and enterprise-numbers update for 2010-01-24]
gerald [Sun, 24 Jan 2010 16:03:43 +0000 (16:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2010-01-24]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31641 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMinor simplification in length calculation of proto_tree_add_bits
dimeg [Sun, 24 Jan 2010 12:08:14 +0000 (12:08 +0000)]
Minor simplification in length calculation of proto_tree_add_bits
and _format_value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31640 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRewrite IS-801 decoding of Provide GPS Satellite Health
dimeg [Sat, 23 Jan 2010 23:11:49 +0000 (23:11 +0000)]
Rewrite IS-801 decoding of Provide GPS Satellite Health
Information; function ansi_801_tvb_get_bits no longer
needed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31639 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhitespace edits; registration of the ansi_801 dissector
dimeg [Sat, 23 Jan 2010 21:42:01 +0000 (21:42 +0000)]
Whitespace edits; registration of the ansi_801 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31638 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInsert casts to float to make the buildbot happy
dimeg [Sat, 23 Jan 2010 21:34:27 +0000 (21:34 +0000)]
Insert casts to float to make the buildbot happy

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31637 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate IS-801 decoding Provide Location Response;
dimeg [Sat, 23 Jan 2010 20:30:54 +0000 (20:30 +0000)]
Update IS-801 decoding Provide Location Response;
bit structure is shown and values are interpreted.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31636 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 3898:
jake [Sat, 23 Jan 2010 18:21:04 +0000 (18:21 +0000)]
Fix for bug 3898:
Get the states string sorted out. Still room for improvements though...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31635 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4408:
jake [Sat, 23 Jan 2010 16:45:03 +0000 (16:45 +0000)]
Fix for bug 4408:
Make further encapsulation determination between "VC-multiplexed PPP" and "LLC encapsulated PPP". See RFC 2364.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31634 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd _format_value variants of the proto_tree_add_bits function
dimeg [Sat, 23 Jan 2010 16:17:17 +0000 (16:17 +0000)]
Add _format_value variants of the proto_tree_add_bits function
for different header field types; now possible to add bits item
for FT_FLOAT and FT_INT types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31633 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAvoid crash on invalid file name.
jake [Sat, 23 Jan 2010 12:29:57 +0000 (12:29 +0000)]
Avoid crash on invalid file name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31632 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4410:
jake [Sat, 23 Jan 2010 11:58:53 +0000 (11:58 +0000)]
Fix for bug 4410:
Adding two more SSA types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31631 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake compiler happy when kerberos is not enabled...
sake [Fri, 22 Jan 2010 23:26:53 +0000 (23:26 +0000)]
Make compiler happy when kerberos is not enabled...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31629 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a spelling error : entrypted -> encrypted
sake [Fri, 22 Jan 2010 23:09:19 +0000 (23:09 +0000)]
Fix a spelling error : entrypted -> encrypted

(found by Adam Langley in bug 4349)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31628 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn our case, not being able to read the Kerberos configuration file
gerald [Fri, 22 Jan 2010 22:36:03 +0000 (22:36 +0000)]
In our case, not being able to read the Kerberos configuration file
isn't a big deal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31626 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Matthieu Patou <mat+Informatique.Samba@matws.net>
sahlberg [Fri, 22 Jan 2010 22:34:24 +0000 (22:34 +0000)]
From Matthieu Patou <mat+Informatique.Samba@matws.net>

Enhancements to NETLOGON and ability to decrypt SCHANNEL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31625 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago#include stdio & etc not req'd (and remove // lines committed by mistake ...)
wmeier [Fri, 22 Jan 2010 18:13:09 +0000 (18:13 +0000)]
#include stdio & etc not req'd (and remove // lines committed by mistake ...)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31624 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some gcc -Wshadow warnings
wmeier [Fri, 22 Jan 2010 17:41:47 +0000 (17:41 +0000)]
Fix some gcc -Wshadow warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31623 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoShow NACKs in the UE table
martinm [Fri, 22 Jan 2010 17:02:40 +0000 (17:02 +0000)]
Show NACKs in the UE table

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31622 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some counters.
martinm [Fri, 22 Jan 2010 16:40:10 +0000 (16:40 +0000)]
Fix some counters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31621 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a gcc -Wshadow warning.
wmeier [Fri, 22 Jan 2010 16:34:54 +0000 (16:34 +0000)]
Fix a gcc -Wshadow warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31620 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate screenshot after fixing some label issues.
martinm [Fri, 22 Jan 2010 15:39:06 +0000 (15:39 +0000)]
Update screenshot after fixing some label issues.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31619 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some labels, and maintain overall frame count
martinm [Fri, 22 Jan 2010 14:16:49 +0000 (14:16 +0000)]
Fix some labels, and maintain overall frame count

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31618 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a...
wmeier [Fri, 22 Jan 2010 13:56:19 +0000 (13:56 +0000)]
Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a few cases.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31617 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a simple help page for LTE RLC stats.
martinm [Fri, 22 Jan 2010 12:42:53 +0000 (12:42 +0000)]
Add a simple help page for LTE RLC stats.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31616 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoClarify tcpdump's default snapshot length a bit - and recommend 65535 as
guy [Fri, 22 Jan 2010 04:43:07 +0000 (04:43 +0000)]
Clarify tcpdump's default snapshot length a bit - and recommend 65535 as
the argument to "-s" (1500 is too small even for Ethernet, as the
maximum size of packets on Ethernet is 1514 bytes if you don't count the
FCS and 1518 bytes if you do).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31615 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alexandre Forget:
jake [Thu, 21 Jan 2010 21:46:46 +0000 (21:46 +0000)]
From Alexandre Forget:
Fix the ORO suboption offset error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31609 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove comment stating that GTK 2.12 is being used since Wireshark 0.99.7.
sfisher [Thu, 21 Jan 2010 16:53:41 +0000 (16:53 +0000)]
Remove comment stating that GTK 2.12 is being used since Wireshark 0.99.7.
Gerald just changed it from 2.16 to 2.18.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31603 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse the correct GTK_INST_VERSION.
gerald [Thu, 21 Jan 2010 16:41:20 +0000 (16:41 +0000)]
Use the correct GTK_INST_VERSION.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31602 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate the Netscape Certificate Type extension bit-string.
stig [Thu, 21 Jan 2010 11:06:26 +0000 (11:06 +0000)]
Update the Netscape Certificate Type extension bit-string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31599 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd Skein MAC authentication tag types.
jake [Thu, 21 Jan 2010 07:56:21 +0000 (07:56 +0000)]
Add Skein MAC authentication tag types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31598 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alex Lindberg:
etxrab [Thu, 21 Jan 2010 06:39:25 +0000 (06:39 +0000)]
From Alex Lindberg:
resolves all h248V1 differences and provides dissection of V1
instances of Packets, Events, Signals, and Properties.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3999

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31597 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTo check which SIP method we saw, just #define values for the index in
guy [Wed, 20 Jan 2010 21:05:24 +0000 (21:05 +0000)]
To check which SIP method we saw, just #define values for the index in
the sip_methods[] table and check the index's value, don't do a string
comparison.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31595 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Karl Heinz Wolf:
etxrab [Wed, 20 Jan 2010 20:34:45 +0000 (20:34 +0000)]
From Karl Heinz Wolf:
Marking in dialog SIP requests.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3588

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31594 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Wed, 20 Jan 2010 20:26:01 +0000 (20:26 +0000)]
From Jakub Zawadzki:
mmap() actually when fail returns MAP_FAILED (-1) not NULL
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31593 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a test, and make some more functions static.
martinm [Wed, 20 Jan 2010 12:54:57 +0000 (12:54 +0000)]
Fix a test, and make some more functions static.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31592 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded rlc_lte_stat_dlg.c.
stig [Wed, 20 Jan 2010 12:54:39 +0000 (12:54 +0000)]
Added rlc_lte_stat_dlg.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31591 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse correct return value type from dissect_ppdu().
stig [Wed, 20 Jan 2010 12:51:04 +0000 (12:51 +0000)]
Use correct return value type from dissect_ppdu().
Fixed a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31590 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't try decode an empty octetstring as BER.
stig [Wed, 20 Jan 2010 12:47:26 +0000 (12:47 +0000)]
Don't try decode an empty octetstring as BER.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31589 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd initial version of LTE RLC stats dialog.
martinm [Wed, 20 Jan 2010 12:37:26 +0000 (12:37 +0000)]
Add initial version of LTE RLC stats dialog.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31588 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jim Young:
etxrab [Wed, 20 Jan 2010 06:44:03 +0000 (06:44 +0000)]
From Jim Young:
Wireshark GUI not reporting filename after save of new capture file.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4406

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31587 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Wed, 20 Jan 2010 06:37:56 +0000 (06:37 +0000)]
From Jakub Zawadzki:
Fix some bugs after merge.
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31586 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gonzalo Casas:
etxrab [Wed, 20 Jan 2010 06:31:42 +0000 (06:31 +0000)]
From Gonzalo Casas:
The asn1 definition of AlternateAccessSelection of the MMS dissector was wrong.
It didn't allow object access with nested AlternatedAccess.
I changed the definition as in ISO 9506-2 (2003).
I also added MMSString which was not present.

I also added the definition for UtcTime as in the annex G of IEC61850-8-1

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4404

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31585 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gonzalo Casas:
etxrab [Wed, 20 Jan 2010 06:31:11 +0000 (06:31 +0000)]
From Gonzalo Casas:
The asn1 definition of AlternateAccessSelection of the MMS dissector was wrong.
It didn't allow object access with nested AlternatedAccess.
I changed the definition as in ISO 9506-2 (2003).
I also added MMSString which was not present.

I also added the definition for UtcTime as in the annex G of IEC61850-8-1

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4404

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31584 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Julien Kerihuel, add support for
sahlberg [Wed, 20 Jan 2010 06:02:42 +0000 (06:02 +0000)]
From Julien Kerihuel, add support for
unaligned unmarshalling of dissectors generated by PIDL.

This will allow us to use PIDL and additional IDLs from the samba
project since they use "noalign" for certain protocols.

This may also allow us to use PIDL to describe, and machinegenerate
dissectors for normal, non-DCERPC, protocols.

This patch for PIDL is still under review, but the PIDL patch is l;ikely
to be committed soonish.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31583 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove an unusued variable
sahlberg [Wed, 20 Jan 2010 03:55:03 +0000 (03:55 +0000)]
remove an unusued variable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31582 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a few gcc _Wshadow warnings ....
wmeier [Tue, 19 Jan 2010 23:51:27 +0000 (23:51 +0000)]
Fix a few gcc _Wshadow warnings ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31580 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a potential compilation problem with older versions of c-ares.
gerald [Tue, 19 Jan 2010 23:18:23 +0000 (23:18 +0000)]
Fix a potential compilation problem with older versions of c-ares.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31579 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDrop our requirement for MSVCR71.DLL.
gerald [Tue, 19 Jan 2010 22:58:12 +0000 (22:58 +0000)]
Drop our requirement for MSVCR71.DLL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31578 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Tue, 19 Jan 2010 21:28:48 +0000 (21:28 +0000)]
From Jakub Zawadzki:
Embed canary list inside chunk data.
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31577 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Tue, 19 Jan 2010 20:54:27 +0000 (20:54 +0000)]
From Jakub Zawadzki:
Make emem_create_chunk() a function.
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31576 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Tue, 19 Jan 2010 20:53:02 +0000 (20:53 +0000)]
From Jakub Zawadzki:
Cleanup emem_create_chunk() - move common code outside #ifdef's
Part of Bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31575 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOK, I guess those URLs were for a protocol in the process of becoming
guy [Tue, 19 Jan 2010 19:55:43 +0000 (19:55 +0000)]
OK, I guess those URLs were for a protocol in the process of becoming
PIM v2; this appears to be the spec for v1 (Postscript, compressed in
the old "compress" format).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31574 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to V9.1.0 (2009-12)
etxrab [Tue, 19 Jan 2010 19:52:16 +0000 (19:52 +0000)]
Update to V9.1.0 (2009-12)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31573 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse more unique names for certain enum constants.
wmeier [Tue, 19 Jan 2010 19:37:03 +0000 (19:37 +0000)]
Use more unique names for certain enum constants.
(enum constant names are part of the global name space).
(Fixes at least one gcc -Wshadow warning).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31572 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a double-free bug which was causing a crash. Our decryption buffer
gerald [Tue, 19 Jan 2010 19:28:30 +0000 (19:28 +0000)]
Fix a double-free bug which was causing a crash. Our decryption buffer
length doesn't change, so allocate it just once. Add an expert item for
a successful decryption.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31571 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki: get rid of redundant BYTE_VIEW_WIDTH and
guy [Tue, 19 Jan 2010 19:18:51 +0000 (19:18 +0000)]
From Jakub Zawadzki: get rid of redundant BYTE_VIEW_WIDTH and
BIT_VIEW_WIDTH definitions in favor of BYTES_PER_LINE and BITS_PER_LINE.

While we're at it, move the definition of BYTE_VIEW_SEP down among the
other definitions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31570 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki: fix the return type of hex_view_get_byte().
guy [Tue, 19 Jan 2010 19:12:55 +0000 (19:12 +0000)]
From Jakub Zawadzki: fix the return type of hex_view_get_byte().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31569 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of a dead link, use IETF links for what appear to be the last
guy [Tue, 19 Jan 2010 18:53:41 +0000 (18:53 +0000)]
Get rid of a dead link, use IETF links for what appear to be the last
I-Ds for PIMv1 (the next version of the dense-mode draft didn't run on
IGMP).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31568 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove an unused variable. Fixup whitespace.
gerald [Tue, 19 Jan 2010 17:40:52 +0000 (17:40 +0000)]
Remove an unused variable. Fixup whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31567 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove an include.
etxrab [Tue, 19 Jan 2010 17:21:19 +0000 (17:21 +0000)]
Remove an include.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31566 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf user data is xml display it.
etxrab [Tue, 19 Jan 2010 17:20:17 +0000 (17:20 +0000)]
If user data is xml display it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31565 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMoved expert info for bitstring size constraints below bit values.
stig [Tue, 19 Jan 2010 08:54:13 +0000 (08:54 +0000)]
Moved expert info for bitstring size constraints below bit values.
Enabled bitstring minimum length size check.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31564 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange group for "Unknown bit(s)" expert info to Undecoded.
stig [Tue, 19 Jan 2010 08:11:23 +0000 (08:11 +0000)]
Change group for "Unknown bit(s)" expert info to Undecoded.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31563 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoEven better - don't use a global variable in the first place, as its
guy [Tue, 19 Jan 2010 01:16:02 +0000 (01:16 +0000)]
Even better - don't use a global variable in the first place, as its
value isn't used outside dissect_sss_request().

Get rid of some unused value_strings while we're at it; they duplicate
value_strings in packet-ncp-nmas.c, and if they're really needed here,
there should probably be only one instance, in, for example, the NCP
dissector.

Get rid of some unused variables, use -1 for "to the end of the tvbuff",
don't use "subverb" unless we've actually fetched its value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31562 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix gcc -Wshadow warnings
wmeier [Tue, 19 Jan 2010 00:37:39 +0000 (00:37 +0000)]
Fix gcc -Wshadow warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31561 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRewrite the bit about null vs. non-null "tree" dissector arguments a
guy [Mon, 18 Jan 2010 23:21:13 +0000 (23:21 +0000)]
Rewrite the bit about null vs. non-null "tree" dissector arguments a
bit, so as not to imply that there's some form of global "mode"
Wireshark is in when it passes a null or non-null pointer (there isn't),
and to explicitly note that there is *no* guarantee about the value of
"tree" on the first call to the dissector.  (I.e., please do not build a
mental model of how Wireshark works in that regard, and write your
dissector based on that mental model - you *will* be wrong.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31560 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some gcc -Wshadow warnings ....
wmeier [Mon, 18 Jan 2010 23:16:10 +0000 (23:16 +0000)]
Fix some gcc -Wshadow warnings ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31559 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix gcc -Wshadow warnings ....
wmeier [Mon, 18 Jan 2010 21:50:50 +0000 (21:50 +0000)]
Fix gcc -Wshadow warnings ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31558 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a number of gcc _Wshadow warnings
wmeier [Mon, 18 Jan 2010 21:49:47 +0000 (21:49 +0000)]
Fix a number of gcc _Wshadow warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31557 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix gcc -Wshadow warnings.
wmeier [Mon, 18 Jan 2010 21:37:34 +0000 (21:37 +0000)]
Fix gcc -Wshadow warnings.
[And therefore fixing a benign bug where memory was allocated for sizeof(*p) rather than sizeof(p)].

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31556 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse true_false_strings from tfs.c when possible;
wmeier [Mon, 18 Jan 2010 20:51:13 +0000 (20:51 +0000)]
Use true_false_strings from tfs.c when possible;
#include stdio, stdlib & string not req'd;
Fix a gcc -Wshadow warnng

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31555 f5534014-38df-0310-8fa8-9805f1628bb7