13 years agonew Q.932 and QSIG dissectors
kukosa [Fri, 27 Apr 2007 08:10:18 +0000 (08:10 +0000)]
new Q.932 and QSIG dissectors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21602 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agominor formal changes
kukosa [Fri, 27 Apr 2007 07:37:30 +0000 (07:37 +0000)]
minor formal changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21601 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago- new #.Exports parameter VALS_WITH_TABLE which "exports" whole table into header...
kukosa [Fri, 27 Apr 2007 07:35:01 +0000 (07:35 +0000)]
- new #.Exports parameter VALS_WITH_TABLE which "exports" whole table into header file
  /it is only one way how to use it in Windows plugins/
- better handling of imports and definitions if more ASN.1 sources are compiled together
- fix tag handling on top level of PDU
- new -I command line option for path(s) of conformance files including

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21600 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Bingyao Du:
jake [Fri, 27 Apr 2007 06:34:31 +0000 (06:34 +0000)]
From Bingyao Du:
Attachment is a patch for adding a new Juniper NSRP dissector. In this patch, OICQ author email address
<dubingyao@gmail.com> has also been updated to <secfire@gmail.com>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21599 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Jeff Foster: add support for Cisco HDLC captures.
guy [Thu, 26 Apr 2007 20:06:06 +0000 (20:06 +0000)]
From Jeff Foster: add support for Cisco HDLC captures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21598 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAs with other types of extra info, tag the UID extra info. Don't add
guy [Thu, 26 Apr 2007 19:44:18 +0000 (19:44 +0000)]
As with other types of extra info, tag the UID extra info.  Don't add
stuff to the UID tree unless it's UID stuff.

Also, as we appear to allow for null domain and account information in
dissect_smb_uid(), check for null information before trying to add it to
the top-level item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21597 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTiny formatting change
jmayer [Thu, 26 Apr 2007 15:39:41 +0000 (15:39 +0000)]
Tiny formatting change

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21596 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agomtp3_addr_to_str_buf() and mtp3_pc_hash() expect to be passed a pointer
guy [Thu, 26 Apr 2007 07:57:44 +0000 (07:57 +0000)]
mtp3_addr_to_str_buf() and mtp3_pc_hash() expect to be passed a pointer
to a mtp3_addr_pc_t; declare them as such, and pass the argument as

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21595 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoChange the signature of proto_tree_add_bits() and add proto_tree_add_bits_ret_val()
etxrab [Thu, 26 Apr 2007 06:39:29 +0000 (06:39 +0000)]
Change the signature of proto_tree_add_bits() and add proto_tree_add_bits_ret_val()
which will hopefully be more acceptable.
Change name of tvb_get_bits() in ansi_801

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21594 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug 1505. Adding getprinterdriver levels 2, 6, and (partially) 101.
jake [Thu, 26 Apr 2007 06:00:48 +0000 (06:00 +0000)]
Fix for bug 1505. Adding getprinterdriver levels 2, 6, and (partially) 101.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21593 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agomemmove() is needed only if the source and destination might overlap.
guy [Thu, 26 Apr 2007 05:47:34 +0000 (05:47 +0000)]
memmove() is needed only if the source and destination might overlap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21592 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agomemmove() is needed only if the source and destination might overlap.
guy [Thu, 26 Apr 2007 05:43:43 +0000 (05:43 +0000)]
memmove() is needed only if the source and destination might overlap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21591 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agomemmove() is needed only if the source and destination might overlap.
guy [Thu, 26 Apr 2007 05:40:48 +0000 (05:40 +0000)]
memmove() is needed only if the source and destination might overlap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21590 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agomemmove() is needed only if the source and destination might overlap.
guy [Thu, 26 Apr 2007 05:35:04 +0000 (05:35 +0000)]
memmove() is needed only if the source and destination might overlap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21589 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake ADD_ADDRESS_TO_HASH() take a pointer to an address as an argument,
guy [Thu, 26 Apr 2007 04:30:41 +0000 (04:30 +0000)]
Make ADD_ADDRESS_TO_HASH() take a pointer to an address as an argument,
as the other address macros do.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21588 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSee previous comment.
guy [Thu, 26 Apr 2007 03:43:34 +0000 (03:43 +0000)]
See previous comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21587 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUmm, that's *not* how you compare addresses for equality....
guy [Thu, 26 Apr 2007 03:41:44 +0000 (03:41 +0000)]
Umm, that's *not* how you compare addresses for equality....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21586 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoCopy up to 4 bytes from the source address, rather than just copying the
guy [Thu, 26 Apr 2007 03:38:40 +0000 (03:38 +0000)]
Copy up to 4 bytes from the source address, rather than just copying the
first byte; if the goal is to have the address not be fake for IPv4,
that's the way to do it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21585 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFor address types where the address is a bunch of bytes, convert the
guy [Thu, 26 Apr 2007 03:32:38 +0000 (03:32 +0000)]
For address types where the address is a bunch of bytes, convert the
address data pointer from a void * to a guint8 *.

For AT_STRINGZ, convert it to a char *.

Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21584 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFor 1-byte and 2-byte FIDs, convert the void * data pointer in the
guy [Thu, 26 Apr 2007 03:08:23 +0000 (03:08 +0000)]
For 1-byte and 2-byte FIDs, convert the void * data pointer in the
address to a guint8 *, to get at the bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21583 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoGet rid of unused variable.
guy [Thu, 26 Apr 2007 02:36:24 +0000 (02:36 +0000)]
Get rid of unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21582 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse the right local variable.
guy [Thu, 26 Apr 2007 02:35:36 +0000 (02:35 +0000)]
Use the right local variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21581 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoGet rid of no-longer-needed variable.
guy [Thu, 26 Apr 2007 01:35:26 +0000 (01:35 +0000)]
Get rid of no-longer-needed variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21580 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd missing backslash.
guy [Thu, 26 Apr 2007 01:11:24 +0000 (01:11 +0000)]
Add missing backslash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21579 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRename HASH_ADDRESS to ADD_ADDRESS_TO_HASH, to make it clearer what it
guy [Thu, 26 Apr 2007 01:01:27 +0000 (01:01 +0000)]
Rename HASH_ADDRESS to ADD_ADDRESS_TO_HASH, to make it clearer what it
does (i.e., it will add the address bytes to the value that's already
there - it will not initialize the value, so you have to clear it before
doing any hashing).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21578 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a macro for hashing the bytes of an address into a hash value.
guy [Thu, 26 Apr 2007 00:51:33 +0000 (00:51 +0000)]
Add a macro for hashing the bytes of an address into a hash value.

Use it in the IAX2 dissector and in the conversation code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21577 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe data pointer of an address structure is a void *; convert it to a
guy [Thu, 26 Apr 2007 00:03:41 +0000 (00:03 +0000)]
The data pointer of an address structure is a void *; convert it to a
guint8 * in order to look at the raw bytes of the address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21576 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoCheck to make sure the address really *is* an IPv4 address.
guy [Thu, 26 Apr 2007 00:01:29 +0000 (00:01 +0000)]
Check to make sure the address really *is* an IPv4 address.

If it is, convert the "void *" data pointer to a "guint8 *", so we can
look at the first byte.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21575 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe data pointer in an address structure is a void *; if the address is
guy [Wed, 25 Apr 2007 23:58:43 +0000 (23:58 +0000)]
The data pointer in an address structure is a void *; if the address is
a MAC address, convert it to a guint8 * in order to look at the bytes of
the address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21574 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse "address_to_str()" to format an address, rather than assuming it's
guy [Wed, 25 Apr 2007 23:56:46 +0000 (23:56 +0000)]
Use "address_to_str()" to format an address, rather than assuming it's
an IPv4 address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21573 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe data field of an address structure is a void *, so we can't look at
guy [Wed, 25 Apr 2007 23:54:54 +0000 (23:54 +0000)]
The data field of an address structure is a void *, so we can't look at
what it points to.  Stop doing that in the code to check for source

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21572 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix the previous fix.
guy [Wed, 25 Apr 2007 23:31:22 +0000 (23:31 +0000)]
Fix the previous fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21571 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoCheck that the addresses are FC addresses before looking at them.
guy [Wed, 25 Apr 2007 23:11:22 +0000 (23:11 +0000)]
Check that the addresses are FC addresses before looking at them.

If the address is an FC address, convert the data pointer to a guint8 *,
as it's a void *.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21570 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFail if the addresses being checked aren't Ethernet addresses.
guy [Wed, 25 Apr 2007 23:09:58 +0000 (23:09 +0000)]
Fail if the addresses being checked aren't Ethernet addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21569 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse "address_to_str()" to format an address, rather than assuming it's
guy [Wed, 25 Apr 2007 22:33:47 +0000 (22:33 +0000)]
Use "address_to_str()" to format an address, rather than assuming it's
an IPv4 address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21568 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe data field of an address structure is now a void *; convert it as
guy [Wed, 25 Apr 2007 22:04:46 +0000 (22:04 +0000)]
The data field of an address structure is now a void *; convert it as

Also, throw in a check for the types of the addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21567 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe data field of an address structure is now a void *; convert it as
guy [Wed, 25 Apr 2007 21:37:15 +0000 (21:37 +0000)]
The data field of an address structure is now a void *; convert it as

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21566 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe "data" field of an address structure is a "void *"; when looking at
guy [Wed, 25 Apr 2007 20:14:41 +0000 (20:14 +0000)]
The "data" field of an address structure is a "void *"; when looking at
a MAC address, convert it to a "guint8 *".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21565 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Dustin Johnson:
gerald [Wed, 25 Apr 2007 19:38:47 +0000 (19:38 +0000)]
From Dustin Johnson:

  - A-MSDU updates
  - Secondary Channel Offset tag updates
  - A-MPDU parameter updates
  - Lots of string fixes updates

Fixup whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21564 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSome types of addresses are data structures; make the address data
guy [Wed, 25 Apr 2007 19:28:56 +0000 (19:28 +0000)]
Some types of addresses are data structures; make the address data
pointer in an address structure a "void *", to indicate that it can
point to some arbitrary type of object, rather than a "guint8 *", which
indicates that it points to an array of bytes.

For any address type where the address is a structure, this removes some
alignment warnings; the author of the code to handle a particular
address type has the responsibility of making sure you don't set up the
address structure with misaligned data.  (Yes, it matters, at least on

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21563 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Stig Bjørlykke:
gerald [Wed, 25 Apr 2007 17:39:38 +0000 (17:39 +0000)]
From Stig Bjørlykke:

Fix break placement for control frames in dissect_ieee80211_common()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21562 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agonew parameter EXTERN for #.EXPORTS directive
kukosa [Wed, 25 Apr 2007 11:14:14 +0000 (11:14 +0000)]
new parameter EXTERN for #.EXPORTS directive

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21561 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofread() return value can not match file size on Windows due CR/LF conversion - do...
kukosa [Wed, 25 Apr 2007 10:16:33 +0000 (10:16 +0000)]
fread() return value can not match file size on Windows due CR/LF conversion - do not check it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21560 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix bug in handling of tagged type reference
kukosa [Wed, 25 Apr 2007 06:33:24 +0000 (06:33 +0000)]
fix bug in handling of tagged type reference

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21559 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoproto_tree_add_bits -> iuup_proto_tree_add_bits as discussed
jmayer [Tue, 24 Apr 2007 21:26:40 +0000 (21:26 +0000)]
proto_tree_add_bits -> iuup_proto_tree_add_bits as discussed
on wireshark-dev to make it compile again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21558 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoextraInfo was not propperly tagged causing ber decoding errors.
lego [Tue, 24 Apr 2007 19:28:12 +0000 (19:28 +0000)]
extraInfo was not propperly tagged causing ber decoding errors.
Fixes Bug 1554

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21557 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a new proto function proto_tree_add_bits() which adds bits to the tree
etxrab [Tue, 24 Apr 2007 19:24:14 +0000 (19:24 +0000)]
Add a new proto function proto_tree_add_bits() which adds bits to the tree
starting at the bit offset given for the number of bits indicated which wll also return
the value of the bits.
Experimental and for review, documentation to be updated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21556 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix definition of tvb_memcpy() to match declaration.
guy [Tue, 24 Apr 2007 17:12:29 +0000 (17:12 +0000)]
Fix definition of tvb_memcpy() to match declaration.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21555 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago"memcpy()" takes void *'s as arguments and returns a void *; have
guy [Tue, 24 Apr 2007 11:54:18 +0000 (11:54 +0000)]
"memcpy()" takes void *'s as arguments and returns a void *; have
tvb_memcpy() be similar, to avoid unnecessarily alignment warnings.

Do the same with "ep_tvb_memdup()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21554 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd an explicit cast of the callback function in the gtk1 SIGNAL_DISCONNECT_BY_FUNC()
sahlberg [Tue, 24 Apr 2007 06:49:38 +0000 (06:49 +0000)]
add an explicit cast of the callback function in the gtk1 SIGNAL_DISCONNECT_BY_FUNC()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21553 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to squelch an alignment warning (we put "int"s into the array, so we
guy [Tue, 24 Apr 2007 06:43:01 +0000 (06:43 +0000)]
Try to squelch an alignment warning (we put "int"s into the array, so we
know the pointer's aligned appropriately for an array of "int"s).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21552 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDamn qqq-bird. ;)
jake [Tue, 24 Apr 2007 06:16:58 +0000 (06:16 +0000)]
Damn qqq-bird. ;)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21551 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agooncly include capture_details_24.xpm IFF we have pcap and if we have gtk>=2 to supres...
sahlberg [Tue, 24 Apr 2007 05:52:01 +0000 (05:52 +0000)]
oncly include capture_details_24.xpm IFF we have pcap and if we have gtk>=2 to supress a warning if compiling for gtk 1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21550 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoif we compile for gtk1 'text' is no longer referenced in the simple_dialog_check_set...
sahlberg [Tue, 24 Apr 2007 05:46:13 +0000 (05:46 +0000)]
if we compile for gtk1  'text' is no longer referenced in the simple_dialog_check_set() function and a warning arises

mark the text argument as _U_ to suppress the warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21549 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd a missing change from the previous commit
sahlberg [Tue, 24 Apr 2007 05:09:53 +0000 (05:09 +0000)]
add a missing change from the previous commit

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21548 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd tracking of uid->domain/account mappings for SMB by tapping the ntlmssp tap for...
sahlberg [Tue, 24 Apr 2007 05:09:00 +0000 (05:09 +0000)]
Add tracking of uid->domain/account mappings for SMB by tapping the ntlmssp tap for the information from the authentication messages

Improve the tid tracking by putting the host/share information on the tid expansion line so one can see it without opening the expansion

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21547 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAddt'l fixes so suite-unittests will run under windows
wmeier [Tue, 24 Apr 2007 03:43:08 +0000 (03:43 +0000)]
Addt'l fixes so suite-unittests will run under windows

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21546 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse correct install target: 'make ..._install (and not 'make 'install_...')
wmeier [Tue, 24 Apr 2007 02:17:35 +0000 (02:17 +0000)]
Use correct install target: 'make ..._install (and not 'make 'install_...')

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21545 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoNeed to include <epan/pint.h> to get pletohl() defined.
guy [Mon, 23 Apr 2007 22:34:31 +0000 (22:34 +0000)]
Need to include <epan/pint.h> to get pletohl() defined.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21544 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Florent DROUIN:
etxrab [Mon, 23 Apr 2007 21:26:27 +0000 (21:26 +0000)]
From  Florent DROUIN:
I have made some changes to the final patch to have the operation code decoded
as ForwardSM. A change for TCAP is included too, to be sure that the
application context is not overwritten by the User Info OID (this was the case,
when a MAP open dialog was included in the request).
Fix bug:

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21543 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agobyteReverse assumes its argument is aligned on a 32-bit boundary; make
guy [Mon, 23 Apr 2007 21:23:30 +0000 (21:23 +0000)]
byteReverse assumes its argument is aligned on a 32-bit boundary; make
it a pointer to a guint32.  Also, use pletohl() to fetch a 32-bit
little-endian quantity.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21542 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe "in" array in an MD5 context is expected to be aligned on a 4-byte
guy [Mon, 23 Apr 2007 21:12:04 +0000 (21:12 +0000)]
The "in" array in an MD5 context is expected to be aligned on a 4-byte
boundary; make it an array of 16 guint32's rather than 64 guint8's, to
ensure that, and add now-necessary casts and remove now-unnecessary

(Missed on the previous checkin.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21541 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe "in" array in an MD5 context is expected to be aligned on a 4-byte
guy [Mon, 23 Apr 2007 20:47:07 +0000 (20:47 +0000)]
The "in" array in an MD5 context is expected to be aligned on a 4-byte
boundary; make it an array of 16 guint32's rather than 64 guint8's, to
ensure that, and add now-necessary casts and remove now-unnecessary

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21540 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove a relic from experimental code.
etxrab [Mon, 23 Apr 2007 20:30:31 +0000 (20:30 +0000)]
Remove a relic from experimental code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21539 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTCAP: Fix up indentation a bit.
etxrab [Mon, 23 Apr 2007 20:21:31 +0000 (20:21 +0000)]
TCAP: Fix up indentation a bit.
GSM MAP: Add returnResultNotLast from TCAP to the included ROS stuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21538 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTCAP: Fix up indentation a bit.
etxrab [Mon, 23 Apr 2007 20:20:46 +0000 (20:20 +0000)]
TCAP: Fix up indentation a bit.
GSM MAP: Add returnResultNotLast from TCAP to the included ROS stuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21537 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoGet rid of no-longer-needed, and warning-generated, casts.
guy [Mon, 23 Apr 2007 18:30:29 +0000 (18:30 +0000)]
Get rid of no-longer-needed, and warning-generated, casts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21536 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMore const cleanup.
guy [Mon, 23 Apr 2007 18:18:08 +0000 (18:18 +0000)]
More const cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21535 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake Mk16_le() work on both big-endian and little-endian processors and
guy [Mon, 23 Apr 2007 18:11:12 +0000 (18:11 +0000)]
Make Mk16_le() work on both big-endian and little-endian processors and
on processors that don't support unaligned loads - just use pletohs().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21534 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDissector table names should be pointed to by const pointers.
guy [Mon, 23 Apr 2007 17:40:33 +0000 (17:40 +0000)]
Dissector table names should be pointed to by const pointers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21533 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix type cast to match target of assignment.
guy [Mon, 23 Apr 2007 17:38:56 +0000 (17:38 +0000)]
Fix type cast to match target of assignment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21532 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe "needles" argument of guint8_pbrk() needs to be const, as that's
guy [Mon, 23 Apr 2007 17:37:36 +0000 (17:37 +0000)]
The "needles" argument of guint8_pbrk() needs to be const, as that's
what's passed to it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21531 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDon't assume byte pointers can be safely cast to more aligned pointers;
guy [Mon, 23 Apr 2007 17:33:29 +0000 (17:33 +0000)]
Don't assume byte pointers can be safely cast to more aligned pointers;
the compiler now warns of that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21530 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agodecode_as_dt's argument points to a dissector table name, so it should be
guy [Mon, 23 Apr 2007 16:49:24 +0000 (16:49 +0000)]
decode_as_dt's argument points to a dissector table name, so it should be
a const pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21529 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDon't assume a pointer to UCHAR is necessarily aligned; that now
guy [Mon, 23 Apr 2007 16:41:31 +0000 (16:41 +0000)]
Don't assume a pointer to UCHAR is necessarily aligned; that now
generates a warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21528 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Paolo Abeni:
sfisher [Mon, 23 Apr 2007 16:22:34 +0000 (16:22 +0000)]
From Paolo Abeni:

(from -dev list)
On Sun, 2007-04-22 at 23:06 +0200, Joerg Mayer wrote:
> Can someone please have a look at uand fix the following warning:
> cc1: warnings being treated as errors
> packet-ssl.c: In function 'ssl_parse':
> packet-ssl.c:334: warning: ignoring return value of 'fread', declared
> with attribute warn_unused_result

The attached patch fix the issue. It also try to fix a bit the

Me: Move size_t nbytes up to top of function and fix typo expeted->expected

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21527 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd some GCC warnings to the standard set, and add some others to the
guy [Mon, 23 Apr 2007 10:59:26 +0000 (10:59 +0000)]
Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of

Clean up some indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21526 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoJust use -1 to go to the end of a tvbuff.
guy [Mon, 23 Apr 2007 10:57:34 +0000 (10:57 +0000)]
Just use -1 to go to the end of a tvbuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21525 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMark all the items for TCAP statistics as generated
morriss [Mon, 23 Apr 2007 10:45:00 +0000 (10:45 +0000)]
Mark all the items for TCAP statistics as generated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21524 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd request/response matching for ctdb
sahlberg [Mon, 23 Apr 2007 09:44:13 +0000 (09:44 +0000)]
add request/response matching for ctdb

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21523 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoand the missing files ...
etxrab [Mon, 23 Apr 2007 06:50:07 +0000 (06:50 +0000)]
and the missing  files ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21522 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFormating changes and align a bit to spec.
etxrab [Mon, 23 Apr 2007 06:24:39 +0000 (06:24 +0000)]
Formating changes and align a bit to spec.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21521 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoGrr. Flex. Can't make warnings errors yet - we'd have to keep that
guy [Mon, 23 Apr 2007 03:09:23 +0000 (03:09 +0000)]
Grr.  Flex.  Can't make warnings errors yet - we'd have to keep that
from being done on Flex-generated files, or fix the problems that pop up
on some platforms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21520 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake warnings errors when possible.
guy [Mon, 23 Apr 2007 02:48:40 +0000 (02:48 +0000)]
Make warnings errors when possible.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21519 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago"call_ber_syntax_callback()" isn't used outside packet-ber.c, isn't
guy [Mon, 23 Apr 2007 00:32:04 +0000 (00:32 +0000)]
"call_ber_syntax_callback()" isn't used outside packet-ber.c, isn't
declared in any header file, and isn't in epan/libwireshark.def; make it
static, to squelch compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21518 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRestore the casts from svn 21080 (presumably) inadvertantly removed in svn 21495.
wmeier [Mon, 23 Apr 2007 00:31:57 +0000 (00:31 +0000)]
Restore the casts from svn 21080 (presumably) inadvertantly removed in svn 21495.
so windows build doesn't get warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21517 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a couple more warnings to the standard set.
guy [Mon, 23 Apr 2007 00:28:50 +0000 (00:28 +0000)]
Add a couple more warnings to the standard set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21516 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPropagate Joerg's fix to make --enable-extra-gcc-checks turn off
guy [Sun, 22 Apr 2007 23:52:38 +0000 (23:52 +0000)]
Propagate Joerg's fix to make --enable-extra-gcc-checks turn off
--enable-warnings-as-errors (if any tests enabled by
--enable-extra-gcc-checks are safe to treat as errors, they're safe to
turn on by default).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21515 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTurn on almost all warnings for Wiretap - if any of them cause problems
guy [Sun, 22 Apr 2007 23:47:56 +0000 (23:47 +0000)]
Turn on almost all warnings for Wiretap - if any of them cause problems
on some platforms due to unfixable problems (e.g., crappy vendor
headers), we can move them back to the "extra" list.

Put those warnings in the order in which they appear in the GCC man page
on my machine.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21514 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix regression: Automatically disable -Werror in case of extra gcc flags.
jmayer [Sun, 22 Apr 2007 23:01:49 +0000 (23:01 +0000)]
Fix regression: Automatically disable -Werror in case of extra gcc flags.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21513 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAnother fix to allow gtk1 to compile w/o warnings....
wmeier [Sun, 22 Apr 2007 22:23:19 +0000 (22:23 +0000)]
Another fix to allow gtk1 to compile w/o warnings....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21512 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoset #ifndef __USE_XOPEN instead of only #ifndef
standel [Sun, 22 Apr 2007 21:55:39 +0000 (21:55 +0000)]
set #ifndef __USE_XOPEN instead of only #ifndef

should fix rev21508

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21511 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago"struct sack_chunk_header" is presumably just a SACK chunk header
guy [Sun, 22 Apr 2007 20:43:01 +0000 (20:43 +0000)]
"struct sack_chunk_header" is presumably just a SACK chunk header
followed by zero or more gap start/end pairs; fix up the previous fix to
handle that correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21510 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDon't play type-punning games - they cause compiler warnings (not that
guy [Sun, 22 Apr 2007 20:29:31 +0000 (20:29 +0000)]
Don't play type-punning games - they cause compiler warnings (not that
anybody appears to ever *set* sack_header->gaps).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21509 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoOnly #deinfe __USE_XOPEN if not already defined. On my Suse 10.2 it was
jmayer [Sun, 22 Apr 2007 20:04:34 +0000 (20:04 +0000)]
Only #deinfe __USE_XOPEN if not already defined. On my Suse 10.2 it was
already #defined to 1, so this would create a warning/error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21508 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoGet rid of some const warnings.
guy [Sun, 22 Apr 2007 18:26:45 +0000 (18:26 +0000)]
Get rid of some const warnings.

Use the "pnto" macros to fetch 16-bit quantities from a buffer - not
only do they have the right casts to avoid const warnings, they also
work even on platforms (such as SPARC) where you can't dereference
unaligned pointers without a trap.

Similarly, compare a possibly-unaligned (we make no alignment guarantees
in Wireshark) 16-bit quantity against 0 a byte at a time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21507 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoCheck the GLib version number, not the GTK+ version number; it's GLib we
guy [Sun, 22 Apr 2007 18:04:52 +0000 (18:04 +0000)]
Check the GLib version number, not the GTK+ version number; it's GLib we
care about, and this code doesn't use GTK+, so it doesn't include any
GTK+ headers and therefore doesn't get the GTK+ version number defined.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21506 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agomove some headers so that the compile works on gtk1
sahlberg [Sun, 22 Apr 2007 16:44:36 +0000 (16:44 +0000)]
move some headers so that the compile works on gtk1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21505 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agomove include of a few headers down a few lines so the compile works on
sahlberg [Sun, 22 Apr 2007 16:40:34 +0000 (16:40 +0000)]
move include of a few headers down a few lines so the compile works on

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21504 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agocompile fix for gtk1
sahlberg [Sun, 22 Apr 2007 15:49:29 +0000 (15:49 +0000)]
compile fix for gtk1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21503 f5534014-38df-0310-8fa8-9805f1628bb7