From: guy <guy@f5534014-38df-0310-8fa8-9805f1628bb7>
Date: Mon, 27 Feb 2012 21:33:53 +0000 (+0000)
Subject: Give more details in comments.
X-Git-Url: http://git.samba.org/samba.git/?p=obnox%2Fwireshark%2Fwip.git;a=commitdiff_plain;h=5dc4936c892c300538bafaef7e4aeee6165b3cfe

Give more details in comments.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41213 f5534014-38df-0310-8fa8-9805f1628bb7
---

diff --git a/epan/dissectors/packet-gsm_ipa.c b/epan/dissectors/packet-gsm_ipa.c
index ba012a96f4..b5544aee27 100644
--- a/epan/dissectors/packet-gsm_ipa.c
+++ b/epan/dissectors/packet-gsm_ipa.c
@@ -1,5 +1,5 @@
 /* packet-gsm_ipa.c
- * Routines for packet dissection of ip.access GSM over IP
+ * Routines for packet dissection of ip.access GSM A-bis over IP
  * Copyright 2009 by Harald Welte <laforge@gnumonks.org>
  * Copyright 2009, 2010 by Holger Hans Peter Freyther <zecke@selfish.org>
  *
@@ -34,13 +34,43 @@
 #include <epan/ipproto.h>
 #include <epan/prefs.h>
 
-/* http://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xml
+/*
+ * Protocol used by ip.access's nanoBTS GSM picocells to transport the GSM
+ * A-bis interface over TCP and UDP.
+ *
+ * See
+ *
+ *	http://openbsc.osmocom.org/trac/wiki/nanoBTS
+ *
+ * for some information about this protocol determined by reverse-
+ * engineering.
+ */
+
+/*
+ * These ports are also registered for other protocols, as per
+ *
+ * http://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xml
  *
  * exlm-agent     3002
  * cgms           3003
  * ii-admin       3006
  * vrml-multi-use 4200-4299
  * commplex-main  5000
+ *
+ * But, as that document says:
+ *
+ ************************************************************************
+ * PLEASE NOTE THE FOLLOWING:                                           *
+ *                                                                      *
+ * ASSIGNMENT OF A PORT NUMBER DOES NOT IN ANY WAY IMPLY AN             *
+ * ENDORSEMENT OF AN APPLICATION OR PRODUCT, AND THE FACT THAT NETWORK  *
+ * TRAFFIC IS FLOWING TO OR FROM A REGISTERED PORT DOES NOT MEAN THAT   *
+ * IT IS "GOOD" TRAFFIC, NOR THAT IT NECESSARILY CORRESPONDS TO THE     *
+ * ASSIGNED SERVICE. FIREWALL AND SYSTEM ADMINISTRATORS SHOULD          *
+ * CHOOSE HOW TO CONFIGURE THEIR SYSTEMS BASED ON THEIR KNOWLEDGE OF    *
+ * THE TRAFFIC IN QUESTION, NOT WHETHER THERE IS A PORT NUMBER          *
+ * REGISTERED OR NOT.                                                   *
+ ************************************************************************
  */
 #define IPA_TCP_PORTS "3002,3003,3006,4249,4250,5000"
 #define IPA_UDP_PORTS "3006"