Apply the small performance enhancment patches for:
authoretxrab <etxrab@f5534014-38df-0310-8fa8-9805f1628bb7>
Tue, 23 Oct 2007 05:50:00 +0000 (05:50 +0000)
committeretxrab <etxrab@f5534014-38df-0310-8fa8-9805f1628bb7>
Tue, 23 Oct 2007 05:50:00 +0000 (05:50 +0000)
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace
- col_append_fstr() with faster  col_append_str()
- col_add_str() with col_set_str()
when it's safe

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23252 f5534014-38df-0310-8fa8-9805f1628bb7

150 files changed:
asn1/camel/camel.cnf
asn1/camel/packet-camel-template.c
asn1/cdt/cdt.cnf
asn1/cmip/cmip.cnf
asn1/dap/dap.cnf
asn1/dap/packet-dap-template.c
asn1/disp/packet-disp-template.c
asn1/dop/packet-dop-template.c
asn1/dsp/packet-dsp-template.c
asn1/gsmmap/gsmmap.cnf
asn1/ldap/packet-ldap-template.c
asn1/ocsp/packet-ocsp-template.c
asn1/pkixcmp/packet-cmp-template.c
asn1/pkixtsp/packet-pkixtsp-template.c
asn1/rtse/rtse.cnf
asn1/s4406/packet-s4406-template.c
asn1/snmp/snmp.cnf
asn1/t38/packet-t38-template.c
asn1/t38/t38.cnf
asn1/tcap/tcap.cnf
asn1/x411/packet-x411-template.c
asn1/x420/packet-x420-template.c
asn1/x420/x420.cnf
asn1/x509af/packet-x509af-template.c
epan/dissectors/packet-bacapp.c
epan/dissectors/packet-ber.c
epan/dissectors/packet-bgp.c
epan/dissectors/packet-bpdu.c
epan/dissectors/packet-bssgp.c
epan/dissectors/packet-btl2cap.c
epan/dissectors/packet-btrfcomm.c
epan/dissectors/packet-catapult-dct2000.c
epan/dissectors/packet-cigi.c
epan/dissectors/packet-cimd.c
epan/dissectors/packet-cip.c
epan/dissectors/packet-cisco-wids.c
epan/dissectors/packet-clnp.c
epan/dissectors/packet-ctdb.c
epan/dissectors/packet-daap.c
epan/dissectors/packet-dcerpc-spoolss.c
epan/dissectors/packet-dcerpc.c
epan/dissectors/packet-dcom-remunkn.c
epan/dissectors/packet-dcp.c
epan/dissectors/packet-dec-dnart.c
epan/dissectors/packet-diameter.c
epan/dissectors/packet-distcc.c
epan/dissectors/packet-dmp.c
epan/dissectors/packet-dnp.c
epan/dissectors/packet-drda.c
epan/dissectors/packet-dtls.c
epan/dissectors/packet-echo.c
epan/dissectors/packet-edonkey.c
epan/dissectors/packet-enip.c
epan/dissectors/packet-epl.c
epan/dissectors/packet-epl_v1.c
epan/dissectors/packet-ethertype.c
epan/dissectors/packet-fcels.c
epan/dissectors/packet-fcip.c
epan/dissectors/packet-fcoe.c
epan/dissectors/packet-fix.c
epan/dissectors/packet-giop.c
epan/dissectors/packet-h1.c
epan/dissectors/packet-h248_annex_c.c
epan/dissectors/packet-hsrp.c
epan/dissectors/packet-iax2.c
epan/dissectors/packet-icep.c
epan/dissectors/packet-icmpv6.c
epan/dissectors/packet-ieee80211.c
epan/dissectors/packet-igap.c
epan/dissectors/packet-igrp.c
epan/dissectors/packet-imf.c
epan/dissectors/packet-ip.c
epan/dissectors/packet-ipmi.c
epan/dissectors/packet-ipv6.c
epan/dissectors/packet-isakmp.c
epan/dissectors/packet-iscsi.c
epan/dissectors/packet-isis-hello.c
epan/dissectors/packet-isis-lsp.c
epan/dissectors/packet-isis-snp.c
epan/dissectors/packet-isns.c
epan/dissectors/packet-iuup.c
epan/dissectors/packet-jxta.c
epan/dissectors/packet-kink.c
epan/dissectors/packet-ldp.c
epan/dissectors/packet-llc.c
epan/dissectors/packet-loop.c
epan/dissectors/packet-lwapp.c
epan/dissectors/packet-media.c
epan/dissectors/packet-mpls.c
epan/dissectors/packet-mq-pcf.c
epan/dissectors/packet-mq.c
epan/dissectors/packet-mrdisc.c
epan/dissectors/packet-ms-mms.c
epan/dissectors/packet-msn-messenger.c
epan/dissectors/packet-msnip.c
epan/dissectors/packet-msnlb.c
epan/dissectors/packet-mtp3mg.c
epan/dissectors/packet-multipart.c
epan/dissectors/packet-mysql.c
epan/dissectors/packet-nbd.c
epan/dissectors/packet-nbipx.c
epan/dissectors/packet-nbns.c
epan/dissectors/packet-ncp-sss.c
epan/dissectors/packet-ncp.c
epan/dissectors/packet-ncp2222.inc
epan/dissectors/packet-ndps.c
epan/dissectors/packet-netbios.c
epan/dissectors/packet-nhrp.c
epan/dissectors/packet-ntlmssp.c
epan/dissectors/packet-omapi.c
epan/dissectors/packet-p_mul.c
epan/dissectors/packet-pgsql.c
epan/dissectors/packet-portmap.c
epan/dissectors/packet-ppp.c
epan/dissectors/packet-pppoe.c
epan/dissectors/packet-pptp.c
epan/dissectors/packet-ptp.c
epan/dissectors/packet-pvfs2.c
epan/dissectors/packet-rgmp.c
epan/dissectors/packet-rmi.c
epan/dissectors/packet-rmt-norm.c
epan/dissectors/packet-rpc.c
epan/dissectors/packet-rsvp.c
epan/dissectors/packet-rsync.c
epan/dissectors/packet-rtps.c
epan/dissectors/packet-rtsp.c
epan/dissectors/packet-scsi-osd.c
epan/dissectors/packet-sigcomp.c
epan/dissectors/packet-slimp3.c
epan/dissectors/packet-smb.c
epan/dissectors/packet-smb2.c
epan/dissectors/packet-smtp.c
epan/dissectors/packet-sna.c
epan/dissectors/packet-sqloracle.c
epan/dissectors/packet-ssh.c
epan/dissectors/packet-ssl.c
epan/dissectors/packet-starteam.c
epan/dissectors/packet-symantec.c
epan/dissectors/packet-tcp.c
epan/dissectors/packet-telnet.c
epan/dissectors/packet-tftp.c
epan/dissectors/packet-tns.c
epan/dissectors/packet-tuxedo.c
epan/dissectors/packet-usb.c
epan/dissectors/packet-winsrepl.c
epan/dissectors/packet-wsp.c
epan/dissectors/packet-x11.c
epan/dissectors/packet-x29.c
epan/dissectors/packet-xdmcp.c
epan/dissectors/packet-ypserv.c

index 9ee0af45ac12dde285117baed4a1c3635d5480dd..ed4b3c9a0eb8b59d8a64a607161c9e590c491c71 100644 (file)
@@ -199,14 +199,14 @@ static const camel_err_t camel_err_tab[] = {
        if (camel_opcode_type == CAMEL_OPCODE_RETURN_ERROR){
          errorCode = opcode;   
          if (check_col(actx->pinfo->cinfo, COL_INFO)){
-           col_append_fstr(actx->pinfo->cinfo, COL_INFO, 
+           col_append_str(actx->pinfo->cinfo, COL_INFO, 
               val_to_str(errorCode, camel_err_code_string_vals, "Unknown CAMEL error (%%u)"));
            col_append_str(actx->pinfo->cinfo, COL_INFO, " ");
            col_set_fence(actx->pinfo->cinfo, COL_INFO);
          }
        }else{
          if (check_col(actx->pinfo->cinfo, COL_INFO)){
-           col_append_fstr(actx->pinfo->cinfo, COL_INFO, 
+           col_append_str(actx->pinfo->cinfo, COL_INFO, 
               val_to_str(opcode, camel_opr_code_strings, "Unknown CAMEL (%%u)"));
            col_append_str(actx->pinfo->cinfo, COL_INFO, " ");
            col_set_fence(actx->pinfo->cinfo, COL_INFO);
index 945c7dba41e5bc4738cce6f00ceda2fbd7300604..7cf3303d27906e45b7ceb994601774439c5fd7cd 100644 (file)
@@ -339,7 +339,7 @@ dissect_camel_camelPDU(gboolean implicit_tag _U_, tvbuff_t *tvb, int offset, asn
   if (check_col(actx->pinfo->cinfo, COL_INFO)){
     /* Populate the info column with PDU type*/
     col_set_str(actx->pinfo->cinfo, COL_INFO, val_to_str(camel_pdu_type, camel_Component_vals, "Unknown Camel (%u)"));
-    col_append_fstr(actx->pinfo->cinfo, COL_INFO, " ");
+    col_append_str(actx->pinfo->cinfo, COL_INFO, " ");
   }
 
   is_ExtensionField =FALSE;
index 3ec13ff8cec12a3311da8670d54870173cf745af..2502e6a553511ed29e026d190825e347695ec2a3 100644 (file)
@@ -76,7 +76,7 @@ CompressedData    B "1.3.26.0.4406.0.4.2"  "cdt"
     expert_add_info_format (actx->pinfo, tf, PI_UNDECODED, PI_ERROR,
                             "Unable to get compressed content");
     if (check_col (actx->pinfo->cinfo, COL_INFO))
-      col_append_fstr (actx->pinfo->cinfo, COL_INFO, 
+      col_append_str (actx->pinfo->cinfo, COL_INFO, 
                        "[Error: Unable to get compressed content]");
     return offset;
   }
@@ -89,7 +89,7 @@ CompressedData    B "1.3.26.0.4406.0.4.2"  "cdt"
     expert_add_info_format (actx->pinfo, tf, PI_UNDECODED, PI_ERROR,
                             "Unable to uncompress content");
     if (check_col (actx->pinfo->cinfo, COL_INFO))
-      col_append_fstr (actx->pinfo->cinfo, COL_INFO, 
+      col_append_str (actx->pinfo->cinfo, COL_INFO, 
                        "[Error: Unable to uncompress content]");
     return offset;
   }
index a1c120ea0c59dc70e61dbc9ac5e6699de2fa29b8..14874bc913c9c682387ba6968cae448558ca1832 100644 (file)
@@ -220,13 +220,13 @@ RejectProblem
 
 #.FN_HDR CMIPAbortInfo
   if(check_col(actx->pinfo->cinfo, COL_INFO)){
-    col_append_fstr(actx->pinfo->cinfo, COL_INFO, "CMIP-A-ABORT");
+    col_append_str(actx->pinfo->cinfo, COL_INFO, "CMIP-A-ABORT");
   }
 #.END
 
 #.FN_HDR CMIPUserInfo
   if(check_col(actx->pinfo->cinfo, COL_INFO)){
-    col_append_fstr(actx->pinfo->cinfo, COL_INFO, "CMIP-A-ASSOCIATE");
+    col_append_str(actx->pinfo->cinfo, COL_INFO, "CMIP-A-ASSOCIATE");
   }
 #.END
 
index ac7901ddb9be847bbccb3bf36c108e2f7dfa2401..21c7ecbd13abac84bc613210f5db0c20869368b3 100644 (file)
@@ -147,7 +147,7 @@ PagedResultsRequest/queryReference  pagedResultsQueryReference
                proto_tree_add_text(tree, tvb, offset, -1,"Anonymous");
 
                if(check_col(actx->pinfo->cinfo, COL_INFO))
-                       col_append_fstr(actx->pinfo->cinfo, COL_INFO, " anonymous");
+                       col_append_str(actx->pinfo->cinfo, COL_INFO, " anonymous");
 
        }
        /* do the default thing */
index e1b496aefeb129a5374d67f66f0c38ce30cea6a4..d198a05fa191c083d6e5f0a55292baa3771c3271 100644 (file)
@@ -258,7 +258,7 @@ dissect_dap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
 
        if(dap_dissector) {
          if (check_col(pinfo->cinfo, COL_INFO))
-           col_add_str(pinfo->cinfo, COL_INFO, dap_op_name);
+           col_set_str(pinfo->cinfo, COL_INFO, dap_op_name);
 
          while (tvb_reported_length_remaining(tvb, offset) > 0){
            old_offset=offset;
index 5129c83339b041017164c326ae57f4ae2f775dfb..f4d84fa4d1d30f1ff23e8a3b9ea2fb98952d7adf 100644 (file)
@@ -184,7 +184,7 @@ dissect_disp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
 
        if(disp_dissector) {
          if (check_col(pinfo->cinfo, COL_INFO))
-           col_add_str(pinfo->cinfo, COL_INFO, disp_op_name);
+           col_set_str(pinfo->cinfo, COL_INFO, disp_op_name);
 
          while (tvb_reported_length_remaining(tvb, offset) > 0){
            old_offset=offset;
index 69e23ec26119bc7d1d5be796ffddf0da99f7005e..d7c506dd2617ce8e5a9393924b1d8816c99dc481 100644 (file)
@@ -227,7 +227,7 @@ dissect_dop(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
 
        if(dop_dissector) {
          if (check_col(pinfo->cinfo, COL_INFO))
-           col_add_str(pinfo->cinfo, COL_INFO, dop_op_name);
+           col_set_str(pinfo->cinfo, COL_INFO, dop_op_name);
 
          while (tvb_reported_length_remaining(tvb, offset) > 0){
            old_offset=offset;
index a0ebb77d76a013acfa924cba8b3d90321031ae95..4c40eda089b0570fecc8f286819cbafb6f043e22 100644 (file)
@@ -258,7 +258,7 @@ dissect_dsp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
 
        if(dsp_dissector) {
          if (check_col(pinfo->cinfo, COL_INFO))
-           col_add_str(pinfo->cinfo, COL_INFO, dsp_op_name);
+           col_set_str(pinfo->cinfo, COL_INFO, dsp_op_name);
 
          while (tvb_reported_length_remaining(tvb, offset) > 0){
            old_offset=offset;
index 08d54ef03692f7251d0df173681558ee5ec2f7e6..0ffb17e1001c195aecf02a13531f9d440572e275 100644 (file)
@@ -143,7 +143,7 @@ MAP-DialoguePDU                             B "0.4.0.0.1.1.1.1" "map-DialogueAS"
 
 %(DEFAULT_BODY)s 
   if (check_col(actx->pinfo->cinfo, COL_INFO)){
-    col_append_fstr(actx->pinfo->cinfo, COL_INFO, gsm_map_opr_code(opcode));
+    col_append_str(actx->pinfo->cinfo, COL_INFO, gsm_map_opr_code(opcode));
   }
 
 #.FN_PARS  GSMMAPLocalErrorcode
index 16f446173b13ce1fcf9436fca0c6a542bf96b722..783d6b17e9e9f1c1ebd8737eff55206e6c39c235 100644 (file)
@@ -865,8 +865,7 @@ dissect_ldap_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, gboolean i
              * been decrypted; dissect the decrypted LDAP message.
              */
             if (check_col(pinfo->cinfo, COL_INFO)) {
-             col_add_str(pinfo->cinfo, COL_INFO, "SASL GSS-API Privacy (decrypted): ");
-
+                               col_set_str(pinfo->cinfo, COL_INFO, "SASL GSS-API Privacy (decrypted): ");
             }
 
             if (sasl_tree) {
@@ -886,7 +885,7 @@ dissect_ldap_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, gboolean i
             * dissect the plain LDAP message.
              */
             if (check_col(pinfo->cinfo, COL_INFO)) {
-             col_add_str(pinfo->cinfo, COL_INFO, "SASL GSS-API Integrity: ");
+                               col_set_str(pinfo->cinfo, COL_INFO, "SASL GSS-API Integrity: ");
             }
 
            if (sasl_tree) {
index d5bd0a12a0373f1993df31992ae92179234fc0d8..e0f511189892874422f5108ed43aeb2370ebb0e7 100644 (file)
@@ -74,7 +74,7 @@ dissect_ocsp_request(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
        if (check_col(pinfo->cinfo, COL_INFO)) {
                col_clear(pinfo->cinfo, COL_INFO);
                
-               col_add_fstr(pinfo->cinfo, COL_INFO, "Request");
+               col_set_str(pinfo->cinfo, COL_INFO, "Request");
        }
 
 
@@ -101,7 +101,7 @@ dissect_ocsp_response(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree
        if (check_col(pinfo->cinfo, COL_INFO)) {
                col_clear(pinfo->cinfo, COL_INFO);
                
-               col_add_fstr(pinfo->cinfo, COL_INFO, "Response");
+               col_set_str(pinfo->cinfo, COL_INFO, "Response");
        }
 
 
index e53b6f5b4ecf1cca7535ce4f52564aa1dbbd07e8..5a2bf334fcd716a7cc38c3cf0de6e2f7b9a09e4f 100644 (file)
@@ -115,7 +115,7 @@ static void dissect_cmp_tcp_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *p
        if (check_col(pinfo->cinfo, COL_INFO)) {
                col_clear(pinfo->cinfo, COL_INFO);
                
-               col_add_fstr(pinfo->cinfo, COL_INFO, "PKIXCMP");
+               col_set_str(pinfo->cinfo, COL_INFO, "PKIXCMP");
        }
 
 
@@ -240,7 +240,7 @@ dissect_cmp_http(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
        if (check_col(pinfo->cinfo, COL_INFO)) {
                col_clear(pinfo->cinfo, COL_INFO);
                
-               col_add_fstr(pinfo->cinfo, COL_INFO, "PKIXCMP");
+               col_set_str(pinfo->cinfo, COL_INFO, "PKIXCMP");
        }
 
 
index b5f79b02e5110cc05b3e15919a377deb549c05a1..970488a6c9099b4c9386d755fb6f719b630a7c30 100644 (file)
@@ -70,7 +70,7 @@ dissect_timestamp_reply(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tr
        if (check_col(pinfo->cinfo, COL_INFO)) {
                col_clear(pinfo->cinfo, COL_INFO);
                
-               col_add_fstr(pinfo->cinfo, COL_INFO, "Reply");
+               col_set_str(pinfo->cinfo, COL_INFO, "Reply");
        }
 
 
@@ -96,7 +96,7 @@ dissect_timestamp_query(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tr
        if (check_col(pinfo->cinfo, COL_INFO)) {
                col_clear(pinfo->cinfo, COL_INFO);
                
-               col_add_fstr(pinfo->cinfo, COL_INFO, "Query");
+               col_set_str(pinfo->cinfo, COL_INFO, "Query");
        }
 
 
index cc2144b7744ed0ee33d234351a49c0985fa95e0f..d47ab6556d852f4b68e70d9c55b9da2cfea63bdd 100644 (file)
@@ -119,7 +119,7 @@ EXTERNALt
 
 #.FN_BODY SessionConnectionIdentifier
   if(open_request && check_col(actx->pinfo->cinfo, COL_INFO))
-    col_append_fstr(actx->pinfo->cinfo, COL_INFO, "Recover");
+    col_append_str(actx->pinfo->cinfo, COL_INFO, "Recover");
   %(DEFAULT_BODY)s
 
 #.END
index 438ee547396f39eeee5c7c6a6730cc2ed3a512ad..f5e76e4a8cdd2032beda1271b4f890bb7d80ebb3 100644 (file)
@@ -79,7 +79,7 @@ dissect_s4406(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
        if (check_col(pinfo->cinfo, COL_PROTOCOL))
                col_set_str(pinfo->cinfo, COL_PROTOCOL, "S4406");
        if (check_col(pinfo->cinfo, COL_INFO))
-         col_add_str(pinfo->cinfo, COL_INFO, "Military");
+         col_set_str(pinfo->cinfo, COL_INFO, "Military");
 
        dissect_s4406_InformationObject(TRUE, tvb, offset, &asn1_ctx , tree, -1);
 }
index 655736fa76c72fe92206652ba7ee4387a795ae90..94b4a5057c0d3f5426a2cf211402df82754a7a06 100644 (file)
@@ -231,7 +231,7 @@ gint pdu_type;
                                "Failed to decrypt encryptedPDU: %%s", error);
 
                        if (check_col(actx->pinfo->cinfo, COL_INFO))
-                               col_add_str(actx->pinfo->cinfo, COL_INFO, "encryptedPDU: Failed to decrypt");
+                               col_set_str(actx->pinfo->cinfo, COL_INFO, "encryptedPDU: Failed to decrypt");
                                
                        return offset;
                } else {
@@ -246,7 +246,7 @@ gint pdu_type;
                                                                           "Decrypted data not formated as expected");
 
                                if (check_col(actx->pinfo->cinfo, COL_INFO))
-                                       col_add_str(actx->pinfo->cinfo, COL_INFO, "encryptedPDU: Decrypted data not formated as expected");
+                                       col_set_str(actx->pinfo->cinfo, COL_INFO, "encryptedPDU: Decrypted data not formated as expected");
                                
                                return offset;
                        }
@@ -261,7 +261,7 @@ gint pdu_type;
                 }
        } else {
                        if (check_col(actx->pinfo->cinfo, COL_INFO))
-                               col_add_str(actx->pinfo->cinfo, COL_INFO, "encryptedPDU: privKey Unknown");
+                               col_set_str(actx->pinfo->cinfo, COL_INFO, "encryptedPDU: privKey Unknown");
        }
 
 #.FN_BODY SNMPv3Message/msgSecurityParameters
index 61fe14404c371a5fcf5facc478278d5468dfc897..0b2b46e69c387ecc487b0bf0cbb547109dbb6371 100644 (file)
@@ -543,7 +543,7 @@ dissect_t38_udp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        }
 
        if (check_col(pinfo->cinfo, COL_INFO)){
-               col_append_fstr(pinfo->cinfo, COL_INFO, "UDP: UDPTLPacket ");
+               col_append_str(pinfo->cinfo, COL_INFO, "UDP: UDPTLPacket ");
        }
 
        offset = dissect_UDPTLPacket_PDU(tvb, pinfo, tr);
@@ -554,7 +554,7 @@ dissect_t38_udp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                                "[MALFORMED PACKET or wrong preference settings]");
                }
                if (check_col(pinfo->cinfo, COL_INFO)){
-                       col_append_fstr(pinfo->cinfo, COL_INFO, " [Malformed?]");
+                       col_append_str(pinfo->cinfo, COL_INFO, " [Malformed?]");
                }
        }
 }
@@ -592,7 +592,7 @@ dissect_t38_tcp_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        }
 
        if (check_col(pinfo->cinfo, COL_INFO)){
-               col_append_fstr(pinfo->cinfo, COL_INFO, "TCP: IFPPacket");
+               col_append_str(pinfo->cinfo, COL_INFO, "TCP: IFPPacket");
        }
 
        while(tvb_length_remaining(tvb,offset)>0)
@@ -608,7 +608,7 @@ dissect_t38_tcp_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                                                "[MALFORMED PACKET or wrong preference settings]");
                                }
                                if (check_col(pinfo->cinfo, COL_INFO)){
-                                       col_append_fstr(pinfo->cinfo, COL_INFO, " [Malformed?]");
+                                       col_append_str(pinfo->cinfo, COL_INFO, " [Malformed?]");
                                }
                                break;
                        } 
index 9b53052f3fa2e651545048043c6bd24eaf06276e..9e4bf2bae58bccf340f4411d515748b1a882b23b 100644 (file)
@@ -136,7 +136,7 @@ VAL_PTR=&Data_Field_field_type_value
                         "[RECEIVED END OF FRAGMENT W/OUT ANY FRAGMENT DATA]");
                 }
                 if (check_col(actx->pinfo->cinfo, COL_INFO)){
-                    col_append_fstr(actx->pinfo->cinfo, COL_INFO, " [Malformed?]");
+                    col_append_str(actx->pinfo->cinfo, COL_INFO, " [Malformed?]");
                 }
                 actx->pinfo->fragmented = save_fragmented;
             }
index b9069665a6ef955b86ed027998adb8c165156b19..b2eec8da624a08c067a8025e5a9443d3b5a4f641 100644 (file)
@@ -231,10 +231,10 @@ if (parameter_tvb){
        }
 
        if ((len)&&(check_col(actx->pinfo->cinfo, COL_INFO))){
-               col_append_fstr(actx->pinfo->cinfo, COL_INFO, "otid(");
+               col_append_str(actx->pinfo->cinfo, COL_INFO, "otid(");
                for(i=0;i<len;i++)
                          col_append_fstr(actx->pinfo->cinfo, COL_INFO, "%%02x",tvb_get_guint8(parameter_tvb,i));
-               col_append_fstr(actx->pinfo->cinfo, COL_INFO, ") ");
+               col_append_str(actx->pinfo->cinfo, COL_INFO, ") ");
        }
 
 }
@@ -270,10 +270,10 @@ if (parameter_tvb){
        }
 
        if ((len)&&(check_col(actx->pinfo->cinfo, COL_INFO))){
-               col_append_fstr(actx->pinfo->cinfo, COL_INFO, "dtid(");
+               col_append_str(actx->pinfo->cinfo, COL_INFO, "dtid(");
                for(i=0;i<len;i++)
                        col_append_fstr(actx->pinfo->cinfo, COL_INFO, "%%02x",tvb_get_guint8(parameter_tvb,i));
-               col_append_fstr(actx->pinfo->cinfo, COL_INFO, ") ");
+               col_append_str(actx->pinfo->cinfo, COL_INFO, ") ");
           }
 }
 #.FN_HDR Begin
@@ -287,7 +287,7 @@ gp_tcapsrt_info->ope=TC_BEGIN;
  *  put that info there should call col_set_fence() to protect it.
  */
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-               col_add_str(actx->pinfo->cinfo, COL_INFO, "Begin ");
+               col_set_str(actx->pinfo->cinfo, COL_INFO, "Begin ");
 #.END
 
 
@@ -295,7 +295,7 @@ if (check_col(actx->pinfo->cinfo, COL_INFO))
 gp_tcapsrt_info->ope=TC_END;
 
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-               col_add_str(actx->pinfo->cinfo, COL_INFO, "End ");
+               col_set_str(actx->pinfo->cinfo, COL_INFO, "End ");
 #.END
 
 
@@ -303,7 +303,7 @@ if (check_col(actx->pinfo->cinfo, COL_INFO))
 gp_tcapsrt_info->ope=TC_CONT;
 
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-               col_add_str(actx->pinfo->cinfo, COL_INFO, "Continue ");
+               col_set_str(actx->pinfo->cinfo, COL_INFO, "Continue ");
 #.END
 
 
@@ -311,7 +311,7 @@ if (check_col(actx->pinfo->cinfo, COL_INFO))
 gp_tcapsrt_info->ope=TC_ABORT;
 
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-               col_add_str(actx->pinfo->cinfo, COL_INFO, "Abort ");
+               col_set_str(actx->pinfo->cinfo, COL_INFO, "Abort ");
 #.END
 
 
@@ -319,30 +319,30 @@ if (check_col(actx->pinfo->cinfo, COL_INFO))
 gp_tcapsrt_info->ope=TC_ANSI_ABORT;
 
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-               col_add_str(actx->pinfo->cinfo, COL_INFO, "Abort ");
+               col_set_str(actx->pinfo->cinfo, COL_INFO, "Abort ");
 #.END
 
 
 #.FN_HDR TCMessage/ansiqueryWithPerm
 gp_tcapsrt_info->ope=TC_ANSI_ALL;
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-                               col_add_str(actx->pinfo->cinfo, COL_INFO, "QueryWithPerm ");
+                               col_set_str(actx->pinfo->cinfo, COL_INFO, "QueryWithPerm ");
 #.FN_HDR TCMessage/ansiqueryWithoutPerm
 gp_tcapsrt_info->ope=TC_ANSI_ALL;
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-                               col_add_str(actx->pinfo->cinfo, COL_INFO, "QueryWithOutPerm ");
+                               col_set_str(actx->pinfo->cinfo, COL_INFO, "QueryWithOutPerm ");
 #.FN_HDR TCMessage/ansiresponse
 gp_tcapsrt_info->ope=TC_ANSI_ALL;
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-                               col_add_str(actx->pinfo->cinfo, COL_INFO, "Response ");
+                               col_set_str(actx->pinfo->cinfo, COL_INFO, "Response ");
 #.FN_HDR TCMessage/ansiconversationWithPerm
 gp_tcapsrt_info->ope=TC_ANSI_ALL;
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-                               col_add_str(actx->pinfo->cinfo, COL_INFO, "ConversationWithPerm ");
+                               col_set_str(actx->pinfo->cinfo, COL_INFO, "ConversationWithPerm ");
 #.FN_HDR TCMessage/ansiconversationWithoutPerm
 gp_tcapsrt_info->ope=TC_ANSI_ALL;
 if (check_col(actx->pinfo->cinfo, COL_INFO))
-                               col_add_str(actx->pinfo->cinfo, COL_INFO, "ConversationWithoutPerm ");
+                               col_set_str(actx->pinfo->cinfo, COL_INFO, "ConversationWithoutPerm ");
 
 #.END
 
index ace11adfe40ebe163fdbe30a1a241fa0041ef752..d4823f6857d20025c827919d86a99a2f1deb8016 100644 (file)
@@ -190,7 +190,7 @@ dissect_x411(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
        }
 
        if (check_col(pinfo->cinfo, COL_INFO))
-         col_add_str(pinfo->cinfo, COL_INFO, x411_op_name);
+         col_set_str(pinfo->cinfo, COL_INFO, x411_op_name);
 
        while (tvb_reported_length_remaining(tvb, offset) > 0){
                old_offset=offset;
index 41bb46932e3e54fa23bcdbd35ac93e4f827fb229..9c10bf1d946874540014dd1997948b7a37d3da95 100644 (file)
@@ -113,7 +113,7 @@ dissect_x420(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
        if (check_col(pinfo->cinfo, COL_PROTOCOL))
                col_set_str(pinfo->cinfo, COL_PROTOCOL, "P22");
        if (check_col(pinfo->cinfo, COL_INFO))
-         col_add_str(pinfo->cinfo, COL_INFO, "InterPersonal");
+         col_set_str(pinfo->cinfo, COL_INFO, "InterPersonal");
 
        dissect_x420_InformationObject(TRUE, tvb, offset, &asn1_ctx , tree, -1);
 }
index ddbf30e5699e8c5e6bff05b41109d2fb95ff656b..207586d31a9b96f8e27f40b8d7631f21e970d3c3 100644 (file)
@@ -140,7 +140,7 @@ ForwardedContentParameters  B "2.6.1.11.17.1.3.26.0.4406.0.4.1"     "id-ep-content-
 #.FN_BODY IPM
 
  if(check_col(actx->pinfo->cinfo, COL_INFO))
-   col_append_fstr(actx->pinfo->cinfo, COL_INFO, " Message");
+   col_append_str(actx->pinfo->cinfo, COL_INFO, " Message");
 
   %(DEFAULT_BODY)s
 
@@ -148,7 +148,7 @@ ForwardedContentParameters  B "2.6.1.11.17.1.3.26.0.4406.0.4.1"     "id-ep-content-
 #.FN_BODY IPN
 
  if(check_col(actx->pinfo->cinfo, COL_INFO))
-   col_append_fstr(actx->pinfo->cinfo, COL_INFO, " Notification");
+   col_append_str(actx->pinfo->cinfo, COL_INFO, " Notification");
 
   %(DEFAULT_BODY)s
 
index c8954ebd16f56ca6e5bee46edb593f04e88b3ff4..82a41002b9031251cc38cf142ef4081b0e4bfc51 100644 (file)
@@ -81,7 +81,7 @@ dissect_pkix_crl(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
        if (check_col(pinfo->cinfo, COL_INFO)) {
                col_clear(pinfo->cinfo, COL_INFO);
                
-               col_add_fstr(pinfo->cinfo, COL_INFO, "Certificate Revocation List");
+               col_set_str(pinfo->cinfo, COL_INFO, "Certificate Revocation List");
        }
 
 
index a5e099897b3b7a226a63c0f50de7d1e03f71f7a5..4a02fe2ea18c2cde031ee8af81b926a9bcd6f582 100644 (file)
@@ -5449,7 +5449,7 @@ dissect_bacapp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        if (check_col(pinfo->cinfo, COL_PROTOCOL))
                col_set_str(pinfo->cinfo, COL_PROTOCOL, "BACnet-APDU");
        if (check_col(pinfo->cinfo, COL_INFO))
-               col_add_str(pinfo->cinfo, COL_INFO, "BACnet APDU ");
+               col_set_str(pinfo->cinfo, COL_INFO, "BACnet APDU ");
 
        tmp = (gint) tvb_get_guint8(tvb, 0);
        bacapp_type = (tmp >> 4) & 0x0f;
index a42e418083f5d8c2518d1a2d6d6d4c0be1f51523..f5a1b6d67865c45d43b75294055a8943591de1e4 100644 (file)
@@ -3980,7 +3980,7 @@ dissect_ber(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     /* if we got here we couldn't find anything better */
     if (check_col(pinfo->cinfo, COL_INFO)) {
       col_clear(pinfo->cinfo, COL_INFO);
-      col_append_fstr(pinfo->cinfo, COL_INFO, "Unknown BER");
+      col_append_str(pinfo->cinfo, COL_INFO, "Unknown BER");
     }
 
     (void) dissect_unknown_ber(pinfo, tvb, 0, tree);
index db084f79762f750a6f283eb944c4ec44d822333e..94245d166d6cab5ede0a5318d1e819e6cffa9644 100644 (file)
@@ -2636,7 +2636,7 @@ dissect_bgp_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
 
     if (check_col(pinfo->cinfo, COL_INFO)) {
        if (first)
-           col_add_fstr(pinfo->cinfo, COL_INFO, "%s", typ);
+           col_add_str(pinfo->cinfo, COL_INFO, typ);
        else
            col_append_fstr(pinfo->cinfo, COL_INFO, ", %s", typ);
     }
index 37ecd428213014258a965227f66dabb0eafee954..b40fc9d22e101e4744b8bb1ff71d67734c95114d 100644 (file)
@@ -334,7 +334,7 @@ dissect_bpdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
       break;
 
     case BPDU_TYPE_TOPOLOGY_CHANGE:
-      col_add_fstr(pinfo->cinfo, COL_INFO, "Topology Change Notification");
+      col_set_str(pinfo->cinfo, COL_INFO, "Topology Change Notification");
       break;
 
     case BPDU_TYPE_RST:
index 567c33ab4da14a89cbea1109261317262b76de69..20dbac0f6115fbb675b90637072871022c09b60d 100644 (file)
@@ -4121,7 +4121,7 @@ decode_iei_application_error(bssgp_ie_t *ie, build_info_t *bi, int ie_start_offs
     tf = proto_item_add_subtree(ti, ett_bssgp_ran_information_container_unit);
 
     proto_tree_add_item(tf, hf_bssgp_iei_nacc_cause, bi->tvb, bi->offset, 1, FALSE);
-    proto_tree_add_text(tf, bi->tvb, bi->offset, tvb_length_remaining(bi->tvb, 0) - bi->offset , "Erroneous Application Container including IEI and LI");
+    proto_tree_add_text(tf, bi->tvb, bi->offset, tvb_length(bi->tvb) - bi->offset , "Erroneous Application Container including IEI and LI");
 
   } else {
        bi->offset += ie->value_length;
index 036c273aabd1b74536e37a2c6a5307aa12bba93d..e259f9c725b6de14c0ac9e3375329a64c9638a8c 100644 (file)
@@ -458,7 +458,7 @@ static void dissect_btl2cap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        }
        if(check_col(pinfo->cinfo, COL_INFO)){
                col_clear(pinfo->cinfo, COL_INFO);
-               col_add_str(pinfo->cinfo, COL_INFO, pinfo->p2p_dir == P2P_DIR_SENT ? "Sent " : "Rcvd ");
+               col_set_str(pinfo->cinfo, COL_INFO, pinfo->p2p_dir == P2P_DIR_SENT ? "Sent " : "Rcvd ");
        }
 
        if(tree){
index 96c9272bdd547ee279c027aa00ff18b62490218d..2167b1458886b34f64e4cb13d81931877cc20fd0 100644 (file)
@@ -632,7 +632,7 @@ dissect_btrfcomm(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                col_set_str(pinfo->cinfo, COL_PROTOCOL, "RFCOMM");
        if (check_col(pinfo->cinfo, COL_INFO)) {
                col_clear(pinfo->cinfo, COL_INFO);
-               col_add_str(pinfo->cinfo, COL_INFO, pinfo->p2p_dir == P2P_DIR_SENT ? "Sent " : "Rcvd ");
+               col_set_str(pinfo->cinfo, COL_INFO, pinfo->p2p_dir == P2P_DIR_SENT ? "Sent " : "Rcvd ");
        }
 
 
index a70965313a0515185e2dc10a00f6f0fdca671dac..b0c8ebfa300522e1bd2bd0507514839376c40812 100644 (file)
@@ -768,7 +768,7 @@ dissect_catapult_dct2000(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     /* Protocol name */
     if (check_col(pinfo->cinfo, COL_PROTOCOL))
     {
-        col_add_str(pinfo->cinfo, COL_PROTOCOL, "DCT2000");
+        col_set_str(pinfo->cinfo, COL_PROTOCOL, "DCT2000");
     }
 
     /* Info column */
index 725e83ff21eb17737aa65b66dc4a54e989fd392d..fa123158a63ceb707768e787b6666bd843c9d413 100644 (file)
@@ -2091,7 +2091,7 @@ dissect_cigi_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
     if (check_col(pinfo->cinfo, COL_INFO)) {
         col_clear(pinfo->cinfo, COL_INFO);
-        col_add_fstr(pinfo->cinfo, COL_INFO, info_str);
+        col_add_str(pinfo->cinfo, COL_INFO, info_str);
     }
 
     if (tree) {
index 60dda2d45e0563dbb1dca10fe238ce0a111fe112..ea518964b636946c76555d3240a3b936100979ef 100644 (file)
@@ -688,7 +688,7 @@ dissect_cimd(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   {
     col_set_str(pinfo->cinfo, COL_INFO, "");
     if (checksumIsValid)
-      col_append_fstr(pinfo->cinfo, COL_INFO, "%s", match_strval(OC, vals_hdr_OC));
+      col_append_str(pinfo->cinfo, COL_INFO, match_strval(OC, vals_hdr_OC));
     else
       col_append_fstr(pinfo->cinfo, COL_INFO, "%s - %s", match_strval(OC, vals_hdr_OC), "invalid checksum");
   }
index cd9c3a340ade388bd490d3ac855aff4de24f8cc9..236fee2499db3f503c8c626572694fa8ab3ce7df 100644 (file)
@@ -1053,7 +1053,7 @@ dissect_cip_data( proto_tree *item_tree, tvbuff_t *tvb, int offset, int item_len
       /* Add reply status to info column */
       if(check_col(pinfo->cinfo, COL_INFO))
       {
-         col_append_fstr( pinfo->cinfo, COL_INFO, "%s",
+         col_append_str( pinfo->cinfo, COL_INFO, 
                   val_to_str( ( tvb_get_guint8( tvb, offset+2 ) ),
                      cip_gs_vals , "Unknown Response (%x)") );
       }
@@ -1224,7 +1224,7 @@ dissect_cip_data( proto_tree *item_tree, tvbuff_t *tvb, int offset, int item_len
                   */
 
                   if(check_col(pinfo->cinfo, COL_INFO))
-                     col_append_fstr( pinfo->cinfo, COL_INFO, ", ");
+                     col_append_str( pinfo->cinfo, COL_INFO, ", ");
 
                   dissect_cip_data( temp_tree, tvb, offset+serv_offset+4, serv_length, pinfo );
                }
@@ -1304,7 +1304,7 @@ dissect_cip_data( proto_tree *item_tree, tvbuff_t *tvb, int offset, int item_len
       /* Add service to info column */
       if(check_col(pinfo->cinfo, COL_INFO))
       {
-         col_append_fstr( pinfo->cinfo, COL_INFO, "%s",
+         col_append_str( pinfo->cinfo, COL_INFO, 
                   val_to_str( ( tvb_get_guint8( tvb, offset ) & 0x7F ),
                      cip_sc_vals , "Unknown Service (%x)") );
       }
@@ -1520,7 +1520,7 @@ dissect_cip_data( proto_tree *item_tree, tvbuff_t *tvb, int offset, int item_len
               */
 
               if(check_col(pinfo->cinfo, COL_INFO))
-                 col_append_fstr( pinfo->cinfo, COL_INFO, ": ");
+                 col_append_str( pinfo->cinfo, COL_INFO, ": ");
 
               dissect_cip_data( temp_tree, tvb, offset+2+req_path_size+4, msg_req_siz, pinfo );
 
@@ -1583,7 +1583,7 @@ dissect_cip_data( proto_tree *item_tree, tvbuff_t *tvb, int offset, int item_len
                */
 
                if(check_col(pinfo->cinfo, COL_INFO))
-                  col_append_fstr( pinfo->cinfo, COL_INFO, ", ");
+                  col_append_str( pinfo->cinfo, COL_INFO, ", ");
 
                dissect_cip_data( temp_tree, tvb, offset+serv_offset+6, serv_length, pinfo );
             }
index 636a158037b26f1647a49a05544f027152e0885d..66b536826d6a623f4f20fedf2c63a10097857fb9 100644 (file)
@@ -85,7 +85,7 @@ dissect_cwids(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
          col_clear(pinfo->cinfo, COL_INFO);
 
        if (check_col(pinfo->cinfo, COL_INFO)) {
-         col_add_fstr(pinfo->cinfo, COL_INFO, "Cwids: ");
+         col_set_str(pinfo->cinfo, COL_INFO, "Cwids: ");
        }
        /* FIXME: col_set_fence(pinfo->cinfo, all-cols, only addr-cols?); */
 
index a8748a5f9899e0478852f6943a498741c27a9713..256b066b7402b3619b382a014aa33222ffc070b9 100644 (file)
@@ -1740,7 +1740,7 @@ static gboolean dissect_ositp_internal(tvbuff_t *tvb, packet_info *pinfo,
   /* Initialize the COL_INFO field; each of the TPDUs will have its
      information appended. */
   if (check_col(pinfo->cinfo, COL_INFO))
-    col_add_str(pinfo->cinfo, COL_INFO, "");
+    col_set_str(pinfo->cinfo, COL_INFO, "");
 
   while (tvb_offset_exists(tvb, offset)) {
     if (!first_tpdu) {
index fb076251cd494313460f173253a97ec4792b388f..1228466f2c3114469b2e2617c695a6094b40fb68 100644 (file)
@@ -912,7 +912,7 @@ dissect_ctdb_req_call(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree
        }
        if(flags&0x00000001){
                if(check_col(pinfo->cinfo, COL_INFO)){
-                       col_append_fstr(pinfo->cinfo, COL_INFO, " IMMEDIATE");
+                       col_append_str(pinfo->cinfo, COL_INFO, " IMMEDIATE");
                }
        }       
        offset+=4;
index 27afb3eff5d55d20a63be47efad4b4253e06744e..4b924c094be102f5b8d418103d1ce6465ddf4497 100644 (file)
@@ -156,12 +156,12 @@ dissect_daap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     */
    if (check_col(pinfo->cinfo, COL_INFO)) {
       if (is_request) {
-        col_add_str(pinfo->cinfo, COL_INFO, "DAAP Request");
+        col_set_str(pinfo->cinfo, COL_INFO, "DAAP Request");
       } else {
         /* This is done in two functions on purpose. If the tvb_get_xxx()
          * functions fail, at least something will be in the info column
          */
-        col_add_str(pinfo->cinfo, COL_INFO, "DAAP Response");
+        col_set_str(pinfo->cinfo, COL_INFO, "DAAP Response");
         col_append_fstr(pinfo->cinfo, COL_INFO, " [tag: %s, size: %d]",
                 tvb_format_text(tvb, offset, 4), tvb_get_ntohl(tvb, offset+4));
       }
index d226bad2ce3fc67e79bd051a0212218f9c020b36..479f34e6cfc5a6bace6d0e796a41b9803c103425 100644 (file)
@@ -676,7 +676,7 @@ static int dissect_printerdata_data(tvbuff_t *tvb, int offset,
                }
                case DCERPC_REG_BINARY:
                        if (check_col(pinfo->cinfo, COL_INFO))
-                               col_append_fstr(
+                               col_append_str(
                                        pinfo->cinfo, COL_INFO, 
                                        " = <binary data>");
                        break;
index 6989d6c17bd45b058df3fb27a119fa22efedaae5..95af4b7e401fb8c1265c80fc6cfe03c06bcb9e6a 100644 (file)
@@ -3736,7 +3736,7 @@ dissect_dcerpc_cn_fault (tvbuff_t *tvb, gint offset, packet_info *pinfo,
                } else {
                    /* PDU is fragmented and this isn't the first fragment */
                    if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_append_fstr(pinfo->cinfo, COL_INFO,
+                       col_append_str(pinfo->cinfo, COL_INFO,
                                        " [DCE/RPC fragment]");
                    }
                    if (dcerpc_tree) {
@@ -3771,7 +3771,7 @@ dissect_dcerpc_cn_fault (tvbuff_t *tvb, gint offset, packet_info *pinfo,
                             TRUE);
                    }
                    if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_append_fstr(pinfo->cinfo, COL_INFO,
+                       col_append_str(pinfo->cinfo, COL_INFO,
                                        " [DCE/RPC fragment]");
                    }
                } else if(hdr->flags&PFC_LAST_FRAG){  /* LAST fragment */
@@ -3818,7 +3818,7 @@ dissect_dcerpc_cn_fault (tvbuff_t *tvb, gint offset, packet_info *pinfo,
                            /* Reassembly not complete - some fragments
                               are missing */
                            if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_append_fstr(pinfo->cinfo, COL_INFO,
+                               col_append_str(pinfo->cinfo, COL_INFO,
                                                " [DCE/RPC fragment]");
                            }
                        }
@@ -3831,7 +3831,7 @@ dissect_dcerpc_cn_fault (tvbuff_t *tvb, gint offset, packet_info *pinfo,
                             TRUE);
                    }
                    if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_append_fstr(pinfo->cinfo, COL_INFO,
+                       col_append_str(pinfo->cinfo, COL_INFO,
                                        " [DCE/RPC fragment]");
                    }
                }
@@ -4463,7 +4463,7 @@ dissect_dcerpc_dg_stub (tvbuff_t *tvb, int offset, packet_info *pinfo,
        } else {
            /* PDU is fragmented and this isn't the first fragment */
            if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_append_fstr(pinfo->cinfo, COL_INFO, " [DCE/RPC fragment]");
+               col_append_str(pinfo->cinfo, COL_INFO, " [DCE/RPC fragment]");
            }
            if (dcerpc_tree) {
                if (length > 0) {
@@ -4526,7 +4526,7 @@ dissect_dcerpc_dg_stub (tvbuff_t *tvb, int offset, packet_info *pinfo,
        } else {
            /* Reassembly isn't completed yet */
            if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_append_fstr(pinfo->cinfo, COL_INFO, " [DCE/RPC fragment]");
+               col_append_str(pinfo->cinfo, COL_INFO, " [DCE/RPC fragment]");
            }
        }
     }
index a636abe17b881ae96c601b17e86cfb35211c1ee9..4e2a35fe6e73e5bb7b7e26e99bf733376cedb407 100644 (file)
@@ -253,7 +253,7 @@ dissect_remunk_remrelease_rqst(tvbuff_t *tvb, int offset,
                if (u32IntRefs) {
                        col_append_fstr(pinfo->cinfo, COL_INFO, " Cnt=%u Refs=", u32IntRefs);
                } else {
-                       col_append_fstr(pinfo->cinfo, COL_INFO, " Cnt=0");
+                       col_append_str(pinfo->cinfo, COL_INFO, " Cnt=0");
                }
        }
 
index 9a972350dc73d10730b1512ff6fb2ecd2f7599bb..cec47499c3d8e11124991caafae7d576deddf922 100644 (file)
@@ -581,7 +581,7 @@ static void dissect_dcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                if (tree)
                        proto_tree_add_boolean_hidden(dcp_tree, hf_dcp_malformed, tvb, offset, 0, TRUE);
                if (check_col(pinfo->cinfo, COL_INFO))
-                       col_add_fstr(pinfo->cinfo, COL_INFO, "Packet too short");
+                       col_set_str(pinfo->cinfo, COL_INFO, "Packet too short");
                THROW(ReportedBoundsError);
         }
 
index 58aa391448ef413ee9f889b8a247b87105385c17..31901a0b3935b405e5f8b54f7b53d69985b0c0f4 100644 (file)
@@ -560,7 +560,7 @@ dissect_dec_rt(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
         offset += 2;
         if (nsp_msg_type == CONN_ACK_MSG) {
             if (check_col(pinfo->cinfo, COL_INFO)) {
-                col_add_str(pinfo->cinfo, COL_INFO,
+                col_set_str(pinfo->cinfo, COL_INFO,
                   "NSP connect acknowledgement");
                 /* Done with this msg type */
                 return;
@@ -593,7 +593,7 @@ do_initialization_msg(
     guint8  remainder_count;
 
     if (check_col(pinfo->cinfo, COL_INFO)) {
-        col_add_str(pinfo->cinfo, COL_INFO,
+        col_set_str(pinfo->cinfo, COL_INFO,
           "Routing control, initialization message");
     }
     proto_tree_add_item(tree, hf_dec_rt_src_node, tvb,
@@ -636,7 +636,7 @@ do_verification_msg(
     guint8  remainder_count;
 
     if (check_col(pinfo->cinfo, COL_INFO)) {
-      col_add_str(pinfo->cinfo, COL_INFO,
+      col_set_str(pinfo->cinfo, COL_INFO,
           "Routing control, verification message");
     }
     proto_tree_add_item(tree, hf_dec_rt_src_node, tvb,
@@ -663,7 +663,7 @@ do_hello_test_msg(
     guint   remainder_count;
 
     if (check_col(pinfo->cinfo, COL_INFO)) {
-      col_add_str(pinfo->cinfo, COL_INFO,
+      col_set_str(pinfo->cinfo, COL_INFO,
           "Routing control, hello/test message");
     }
     proto_tree_add_item(tree, hf_dec_rt_src_node, tvb,
@@ -705,7 +705,7 @@ do_routing_msg(
         rtginfo = tvb_get_letohs(tvb, my_offset + 4);
         if (msg == 3) {
             if (check_col(pinfo->cinfo, COL_INFO)) {
-              col_add_str(pinfo->cinfo, COL_INFO,
+              col_set_str(pinfo->cinfo, COL_INFO,
                   "Routing control, Level 1 routing message");
             }
             proto_tree_add_none_format(tree, hf_dec_rt_segment, tvb,
@@ -714,7 +714,7 @@ do_routing_msg(
                 count, startid, (rtginfo & 0x7c00) >> 10, rtginfo & 0x3ff);
         } else {
             if (check_col(pinfo->cinfo, COL_INFO)) {
-              col_add_str(pinfo->cinfo, COL_INFO,
+              col_set_str(pinfo->cinfo, COL_INFO,
                   "Routing control, Level 2 routing message");
             }
             proto_tree_add_none_format(tree, hf_dec_rt_segment, tvb,
@@ -799,7 +799,7 @@ do_hello_msg(
         /* Ethernet router hello message
            Has a 'priority' field in this position */
         if (check_col(pinfo->cinfo, COL_INFO)) {
-            col_add_str(pinfo->cinfo, COL_INFO,
+            col_set_str(pinfo->cinfo, COL_INFO,
                  "Routing control, Ethernet Router Hello  message");
         }
         priority = tvb_get_guint8(tvb, my_offset);
@@ -814,7 +814,7 @@ do_hello_msg(
         guint8  seed;
 
         if (check_col(pinfo->cinfo, COL_INFO)) {
-            col_add_str(pinfo->cinfo, COL_INFO,
+            col_set_str(pinfo->cinfo, COL_INFO,
                 "Routing control, Endnode Hello message");
         }
         seed = tvb_get_guint8(tvb, my_offset);
@@ -984,7 +984,7 @@ handle_nsp_msg(
             break;
         case INTERRUPT_MSG:        /* "Interrupt message" */
             if (check_col(pinfo->cinfo, COL_INFO)) {
-              col_add_str(pinfo->cinfo, COL_INFO,
+              col_set_str(pinfo->cinfo, COL_INFO,
                   "NSP interrupt message");
             }
             ack_num = tvb_get_letohs(tvb, my_offset);
@@ -1027,7 +1027,7 @@ handle_nsp_msg(
             break;
         case LINK_SERVICE_MSG:     /* "Link service message" */
             if (check_col(pinfo->cinfo, COL_INFO)) {
-              col_add_str(pinfo->cinfo, COL_INFO,
+              col_set_str(pinfo->cinfo, COL_INFO,
                   "NSP link control message");
             }
             ack_num = tvb_get_letohs(tvb, my_offset);
@@ -1127,7 +1127,7 @@ handle_nsp_msg(
             break;
         case OTHER_DATA_ACK_MSG:   /* "Other data acknowledgement message" */
             if (check_col(pinfo->cinfo, COL_INFO)) {
-              col_add_str(pinfo->cinfo, COL_INFO,
+              col_set_str(pinfo->cinfo, COL_INFO,
                   "NSP other data ACK message");
             }
             ack_num = tvb_get_letohs(tvb, my_offset);
@@ -1155,7 +1155,7 @@ handle_nsp_msg(
         case CONN_CONFIRM_MSG:     /* "Connect confirm" */
         case CONN_INITIATE_MSG:    /* "Connect initiate" */
             if (check_col(pinfo->cinfo, COL_INFO)) {
-              col_add_str(pinfo->cinfo, COL_INFO,
+              col_set_str(pinfo->cinfo, COL_INFO,
                   "NSP connect confirm/initiate message");
             }
             services = tvb_get_guint8(tvb, my_offset);
@@ -1177,7 +1177,7 @@ handle_nsp_msg(
         case DISCONN_INITIATE_MSG: /* "Disconnect initiate" */
         case DISCONN_CONFIRM_MSG:  /* "Disconnect confirm" */
             if (check_col(pinfo->cinfo, COL_INFO)) {
-              col_add_str(pinfo->cinfo, COL_INFO,
+              col_set_str(pinfo->cinfo, COL_INFO,
                   "NSP disconnect initiate/confirm message");
             }
             reason = tvb_get_letohs(tvb, my_offset);
index 0f455496474a6d023bbed62800c2ad4342813564..0d22a966bde9c4964ce7e17dbf5b59b3da5a58a7 100644 (file)
@@ -408,7 +408,7 @@ static int dissect_diameter_avp(diam_ctx_t* c, tvbuff_t* tvb, int offset) {
 static const char* address_rfc_avp(diam_ctx_t* c, diam_avp_t* a, tvbuff_t* tvb) {
        char* label = ep_alloc(ITEM_LABEL_LENGTH+1);
        address_avp_t* t = a->type_data;
-       proto_item* pi = proto_tree_add_item(c->tree,a->hf_value,tvb,0,tvb_length_remaining(tvb,0),FALSE);
+       proto_item* pi = proto_tree_add_item(c->tree,a->hf_value,tvb,0,tvb_length(tvb),FALSE);
        proto_tree* pt = proto_item_add_subtree(pi,t->ett);
        guint32 addr_type = tvb_get_ntohs(tvb,0);
        guint32 len = tvb_length_remaining(tvb,2);
@@ -459,7 +459,7 @@ static const char* proto_avp(diam_ctx_t* c, diam_avp_t* a, tvbuff_t* tvb)
 }
 
 static const char* time_avp(diam_ctx_t* c, diam_avp_t* a, tvbuff_t* tvb) {
-       int len = tvb_length_remaining(tvb,0);
+       int len = tvb_length(tvb);
        guint8 ntptime[8] = {0,0,0,0,0,0,0,0};
        char* label;
        proto_item* pi;
@@ -482,9 +482,9 @@ static const char* time_avp(diam_ctx_t* c, diam_avp_t* a, tvbuff_t* tvb) {
 static const char* address_v16_avp(diam_ctx_t* c, diam_avp_t* a, tvbuff_t* tvb) {
        char* label = ep_alloc(ITEM_LABEL_LENGTH+1);
        address_avp_t* t = a->type_data;
-       proto_item* pi = proto_tree_add_item(c->tree,a->hf_value,tvb,0,tvb_length_remaining(tvb,0),FALSE);
+       proto_item* pi = proto_tree_add_item(c->tree,a->hf_value,tvb,0,tvb_length(tvb),FALSE);
        proto_tree* pt = proto_item_add_subtree(pi,t->ett);
-       guint32 len = tvb_length_remaining(tvb,0);
+       guint32 len = tvb_length(tvb);
        
        switch (len) {
                case 4:
@@ -509,7 +509,7 @@ static const char* address_v16_avp(diam_ctx_t* c, diam_avp_t* a, tvbuff_t* tvb)
 
 static const char* simple_avp(diam_ctx_t* c, diam_avp_t* a, tvbuff_t* tvb) {
        char* label = ep_alloc(ITEM_LABEL_LENGTH+1);
-       proto_item* pi = proto_tree_add_item(c->tree,a->hf_value,tvb,0,tvb_length_remaining(tvb,0),FALSE);
+       proto_item* pi = proto_tree_add_item(c->tree,a->hf_value,tvb,0,tvb_length(tvb),FALSE);
        proto_item_fill_label(pi->finfo, label);
        label = strstr(label,": ")+2;
        return label;
@@ -542,7 +542,7 @@ static const char* unsigned32_avp(diam_ctx_t* c, diam_avp_t* a, tvbuff_t* tvb) {
 
 static const char* grouped_avp(diam_ctx_t* c, diam_avp_t* a, tvbuff_t* tvb) {
        int offset = 0;
-       int len = tvb_length_remaining(tvb,0);
+       int len = tvb_length(tvb);
        proto_item* pi = proto_tree_add_item(c->tree, a->hf_value, tvb , 0 , -1, FALSE);
        proto_tree* pt = c->tree;
 
index f39a5cf89ba450fab019225b07e42293be3ab37b..38f0c0ca1881a8b0963f441f0efa2ae4aaf3b0ac 100644 (file)
@@ -71,7 +71,7 @@ extern void proto_reg_handoff_distcc(void);
        if(parameter>tvb_length_remaining(tvb, offset) || parameter < 1){\
                len=tvb_length_remaining(tvb, offset);\
                if (check_col(pinfo->cinfo, COL_INFO)) {\
-                       col_append_fstr(pinfo->cinfo, COL_INFO, "[Short" x " PDU]");\
+                       col_append_str(pinfo->cinfo, COL_INFO, "[Short" x " PDU]");\
                }\
        } \
        tvb_ensure_bytes_exist(tvb, offset, len);
@@ -248,7 +248,7 @@ dissect_distcc_doti(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, int off
        DESEGMENT_TCP("DOTI");
 
        if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_append_fstr(pinfo->cinfo, COL_INFO, "DOTI source ");
+               col_append_str(pinfo->cinfo, COL_INFO, "DOTI source ");
        }
 
        proto_tree_add_item(tree, hf_distcc_doti_source, tvb, offset, len, FALSE);
@@ -270,7 +270,7 @@ dissect_distcc_doto(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, int off
        DESEGMENT_TCP("DOTO");
 
        if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_append_fstr(pinfo->cinfo, COL_INFO, "DOTO object ");
+               col_append_str(pinfo->cinfo, COL_INFO, "DOTO object ");
        }
 
        proto_tree_add_item(tree, hf_distcc_doto_object, tvb, offset, len, FALSE);
index b77c6330808c0135042f034f1f3ffe45028d382b..caf58132cd08bf2225a24d78bcbf9883cbfb71a0 100644 (file)
@@ -3377,7 +3377,7 @@ static void dissect_dmp (tvbuff_t *tvb, packet_info *pinfo _U_ ,
     if (dmp_align) {
       col_append_fstr (pinfo->cinfo, COL_INFO, "%-30.30s", msg_type_to_str ());
     } else {
-      col_append_fstr (pinfo->cinfo, COL_INFO, "%s", msg_type_to_str ());
+      col_append_str (pinfo->cinfo, COL_INFO, msg_type_to_str ());
     }
     if ((dmp.msg_type == STANAG) || (dmp.msg_type == IPM) ||
        (dmp.msg_type == REPORT) || (dmp.msg_type == NOTIF))
@@ -3390,7 +3390,7 @@ static void dissect_dmp (tvbuff_t *tvb, packet_info *pinfo _U_ ,
       } else if (dmp.msg_type == ACK) {
       if (dmp_align) {
        /* Append spaces to align subj_id */
-       col_append_fstr (pinfo->cinfo, COL_INFO, "              ");
+       col_append_str (pinfo->cinfo, COL_INFO, "              ");
       }
     }
     if ((dmp.msg_type == REPORT) || (dmp.msg_type == NOTIF) ||
@@ -3413,7 +3413,7 @@ static void dissect_dmp (tvbuff_t *tvb, packet_info *pinfo _U_ ,
       }
     }
     if (dmp.checksum && (checksum1 != checksum2)) {
-      col_append_fstr (pinfo->cinfo, COL_INFO, ", Checksum incorrect");
+      col_append_str (pinfo->cinfo, COL_INFO, ", Checksum incorrect");
     }
   }
 
index 84ba32cf92c53515b3e9045082ca037b10e0c205..57203760b4b55efc00761ebc0e3cd908f0d3ffff 100644 (file)
@@ -2547,7 +2547,7 @@ get_dnp3_message_len(packet_info *pinfo _U_, tvbuff_t *tvb, int offset)
 static int
 dissect_dnp3_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {
-  gint length = tvb_length_remaining(tvb, 0);
+  gint length = tvb_length(tvb);
 
   /* Check for a dnp packet.  It should begin with 0x0564 */
   if(length < DNP_HDR_LEN || tvb_get_ntohs(tvb, 0) != 0x0564) {
@@ -2564,7 +2564,7 @@ dissect_dnp3_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 static int
 dissect_dnp3_udp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {
-  gint length = tvb_length_remaining(tvb, 0);
+  gint length = tvb_length(tvb);
   /* Check for a dnp packet.  It should begin with 0x0564 */
   if(length < DNP_HDR_LEN || tvb_get_ntohs(tvb, 0) != 0x0564) {
     /* Not a DNP 3.0 packet, just happened to use the same port */
index f4abea6f9dd99dc0b6bb3c107617a22b35a9777e..d4a95f1919b92c37626d2d5e9b80e6c7c87a2f5f 100644 (file)
@@ -693,7 +693,7 @@ dissect_drda(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
                if (check_col(pinfo->cinfo, COL_INFO)) 
                {
-                       col_append_fstr(pinfo->cinfo, COL_INFO, "%s", val_to_str(iCommand, drda_opcode_abbr, "Unknown (0x%02x)"));
+                       col_append_str(pinfo->cinfo, COL_INFO, val_to_str(iCommand, drda_opcode_abbr, "Unknown (0x%02x)"));
                }
 
                if (tree)
index 8ac915a18b704325590c3e6e9748519d79ca805a..dd5e261ba65506bfe9bfd915a123da6b89b1c307 100644 (file)
@@ -960,14 +960,14 @@ dissect_dtls_handshake(tvbuff_t *tvb, packet_info *pinfo,
       if (!first_iteration)
         {
          if (check_col(pinfo->cinfo, COL_INFO))
-           col_append_fstr(pinfo->cinfo, COL_INFO, ", ");
+           col_append_str(pinfo->cinfo, COL_INFO, ", ");
         }
 
       /*
        * Update our info string
        */
       if (check_col(pinfo->cinfo, COL_INFO))
-       col_append_fstr(pinfo->cinfo, COL_INFO, "%s", (msg_type_str != NULL)
+       col_append_str(pinfo->cinfo, COL_INFO, (msg_type_str != NULL)
                        ? msg_type_str : "Encrypted Handshake Message");
 
       if (tree)
index 4ecb7ff1a729ab19c885e8a51e1884db71b8b10b..4883adc15f97a3aad61c0ec8680f1df599485e0e 100644 (file)
@@ -60,11 +60,11 @@ static void dissect_echo(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   }
 
   if (check_col(pinfo->cinfo, COL_PROTOCOL)) {
-    col_add_str(pinfo->cinfo, COL_PROTOCOL, "ECHO");
+    col_set_str(pinfo->cinfo, COL_PROTOCOL, "ECHO");
   }
 
   if (check_col(pinfo->cinfo, COL_INFO)) {
-    col_add_fstr(pinfo->cinfo, COL_INFO, "%s"
+    col_set_str(pinfo->cinfo, COL_INFO
                 (request) ? "Request" : "Response");
   }
   
index fd4e830052fbbd1951fb159a92c65975fdfcf619..73864b35e8c1a585e6d221c577ad237bcab750ae 100644 (file)
@@ -1773,7 +1773,7 @@ static void dissect_edonkey_tcp_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tre
     if (protocol_name == NULL) {
         /* Not a recognized eDonkey protocol - probably a continuation */
         if (check_col(pinfo->cinfo, COL_INFO))
-            col_add_str(pinfo->cinfo, COL_INFO, "eDonkey Continuation");
+            col_set_str(pinfo->cinfo, COL_INFO, "eDonkey Continuation");
         if (edonkey_tree) {
             bytes = tvb_length_remaining(tvb, offset);
             proto_tree_add_text(edonkey_tree, tvb, 0, -1, "Continuation data (%d bytes)", bytes);
index 59daefc5c675c4b0feebae979d1a50f2438f1bcb..3ce7246721feb36c8b96d497c1d791e5c42c0843 100644 (file)
@@ -308,7 +308,7 @@ dissect_cpf( int command, tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, i
                                        /* Call dissector for interface */
                                        next_tvb = tvb_new_subset( tvb, offset+6, item_length, item_length );
 
-               if( tvb_length_remaining(next_tvb, 0) == 0 || !dissector_try_port(subdissector_srrd_table, ifacehndl, next_tvb, pinfo, g_tree) )
+               if( tvb_length(next_tvb) == 0 || !dissector_try_port(subdissector_srrd_table, ifacehndl, next_tvb, pinfo, g_tree) )
                {
                   /* Show the undissected payload */
                    if( tvb_length_remaining(tvb, offset) > 0 )
@@ -332,7 +332,7 @@ dissect_cpf( int command, tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, i
                   /* Call dissector for interface */
                   next_tvb = tvb_new_subset (tvb, offset+8, item_length-2, item_length-2);
 
-                  if( tvb_length_remaining(next_tvb, 0) == 0 || !dissector_try_port(subdissector_sud_table, ifacehndl, next_tvb, pinfo, g_tree) )
+                  if( tvb_length(next_tvb) == 0 || !dissector_try_port(subdissector_sud_table, ifacehndl, next_tvb, pinfo, g_tree) )
                   {
                      /* Show the undissected payload */
                       if( tvb_length_remaining(tvb, offset) > 0 )
index 1a9597b3f54dabfb706aaaf1be78bc7cb5a58fd0..47b0ada34d7bf82f61e8c222f454e924ac1581d6 100644 (file)
@@ -245,7 +245,7 @@ dissect_epl(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     proto_tree *epl_tree = NULL, *epl_src_item, *epl_dest_item;
     gint offset = 0;
 
-    if (tvb_length_remaining(tvb, offset) < 3)
+    if (tvb_length(tvb) < 3)
     {
         /* Not enough data for an EPL header; don't try to interpret it */
         return FALSE;
@@ -294,7 +294,7 @@ dissect_epl(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
         {
             case EPL_SOC:
                 /* source and destination NodeID are fixed according to the spec */
-                col_add_str(pinfo->cinfo, COL_INFO, "SoC    ");
+                col_set_str(pinfo->cinfo, COL_INFO, "SoC    ");
                 break;
 
             case EPL_PREQ:
@@ -309,13 +309,13 @@ dissect_epl(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
             case EPL_SOA:
                 /* source and destination NodeID are fixed according to the spec */
-                col_add_str(pinfo->cinfo, COL_INFO, "SoA    ");
+                col_set_str(pinfo->cinfo, COL_INFO, "SoA    ");
                 break;
 
             case EPL_ASND:
                 if (udpencap)
                 {
-                    col_add_str(pinfo->cinfo, COL_INFO, "ASnd   ");
+                    col_set_str(pinfo->cinfo, COL_INFO, "ASnd   ");
                 }
                 else
                 {
@@ -728,7 +728,7 @@ dissect_epl_asnd_nmtreq(proto_tree *epl_tree, tvbuff_t *tvb, packet_info *pinfo,
 
     if (check_col(pinfo->cinfo, COL_INFO))
     {
-        col_append_fstr(pinfo->cinfo, COL_INFO, "%s",
+        col_append_str(pinfo->cinfo, COL_INFO, 
                         match_strval(rcid, asnd_cid_vals));
     }
 
@@ -772,7 +772,7 @@ dissect_epl_asnd_nmtcmd(proto_tree *epl_tree, tvbuff_t *tvb, packet_info *pinfo,
 
     if (check_col(pinfo->cinfo, COL_INFO))
     {
-        col_append_fstr(pinfo->cinfo, COL_INFO, "%s",
+        col_append_str(pinfo->cinfo, COL_INFO, 
                         match_strval(epl_asnd_nmtcommand_cid, asnd_cid_vals));
     }
 
@@ -907,7 +907,7 @@ dissect_epl_asnd_ires(proto_tree *epl_tree, tvbuff_t *tvb, packet_info *pinfo, g
 
     if (check_col(pinfo->cinfo, COL_INFO))
     {
-        col_append_fstr(pinfo->cinfo, COL_INFO, "%s", val_to_str(profile, epl_device_profiles, "Device Profile %d"));
+        col_append_str(pinfo->cinfo, COL_INFO, val_to_str(profile, epl_device_profiles, "Device Profile %d"));
     }
 
     return offset;
index a3d339611e5fc76035ab64951141fab53f0c00de..f7523b167fa0405d38f03ffe6c6d03f0cf599505 100644 (file)
@@ -245,16 +245,16 @@ dissect_epl_v1(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        proto_item *ti=NULL;
        proto_tree *epl_v1_tree=NULL;
 
-       offset = 0;
-
-       info_str = ep_alloc(200);
-       info_str[0] = 0;
 
-       if(tvb_length_remaining(tvb, offset) < 3){
+       if(tvb_length(tvb) < 3){
                /* Not enough data for an EPL_V1 header; don't try to interpret it */
                return FALSE;
        }
 
+       offset = 0;
+       info_str = ep_alloc(200);
+       info_str[0] = 0;
+
        /* make entries in Protocol column and Info column on summary display */
        if(check_col(pinfo->cinfo, COL_PROTOCOL)){
                col_set_str(pinfo->cinfo, COL_PROTOCOL, "EPL_V1");
index 0943ca43541579246b8be34433d74e94d557178b..34f6e862e2d450bbbe354cd49682dfb29149989d 100644 (file)
@@ -261,7 +261,7 @@ ethertype(guint16 etype, tvbuff_t *tvb, int offset_after_etype,
                if (check_col(pinfo->cinfo, COL_INFO)) {
                        description = match_strval(etype, etype_vals);
                        if (description) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+                               col_add_str(pinfo->cinfo, COL_INFO, 
                                    description);
                        }
                }
index 2499b23d4ad0b1335f5948380f63fee7987d20c9..8f083fbfaa126aac2c51ecf29e39825f0fe02458 100644 (file)
@@ -1732,7 +1732,7 @@ dissect_fcels_cbind (tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree,
         proto_tree_add_item (cbind_tree, hf_fcels_opcode, tvb, offset, 1, FALSE);
     }
     if (check_col (pinfo->cinfo, COL_INFO)) {
-        col_add_str (pinfo->cinfo, COL_INFO, "CBIND ");
+        col_set_str (pinfo->cinfo, COL_INFO, "CBIND ");
     }
 
     proto_tree_add_item (cbind_tree, hf_fcels_cbind_liveness, tvb, offset+4, 2, FALSE);
@@ -1775,7 +1775,7 @@ dissect_fcels_unbind (tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree,
         proto_tree_add_item (cbind_tree, hf_fcels_opcode, tvb, offset, 1, FALSE);
     }
     if (check_col (pinfo->cinfo, COL_INFO)) {
-        col_add_str (pinfo->cinfo, COL_INFO, "UNBIND ");
+        col_set_str (pinfo->cinfo, COL_INFO, "UNBIND ");
     }
 
     proto_tree_add_item (cbind_tree, hf_fcels_cbind_userinfo, tvb, offset+4, 4, FALSE);
index 8838c8db20d311bfa77ca2a2d1ce92d7f28353ac..c234a6da6d77477006bf639bb128d8749bd62fbf 100644 (file)
@@ -374,7 +374,7 @@ dissect_fcip (tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
     gint offset = 0,
          start  = 0,
          frame_len = 0;
-    gint bytes_remaining = tvb_length_remaining (tvb, offset);
+    gint bytes_remaining = tvb_length (tvb);
     guint8 pflags, sof = 0, eof = 0;
    /* Set up structures needed to add the protocol subtree and manage it */
     proto_item *ti;
index bf2a0819062da675d056aa1f20e0b1006646f46b..8cdf0f4a91e716946b4fbcb9ad6b8a5776051fa7 100644 (file)
@@ -120,7 +120,7 @@ dissect_fcoe(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     guint version;
     char *ver;
     guint16  len_sof;
-    gint bytes_remaining = tvb_length_remaining(tvb, 0);
+    gint bytes_remaining = tvb_length(tvb);
     guint8 sof = 0;
     guint8 eof = 0;
     const char *eof_str;
index 00b39999b6a62926005a04145deda1d871a7e95c..374f2de0e21f6730ba408d37b6b090bb062c4473 100644 (file)
@@ -3027,7 +3027,7 @@ dissect_fix(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     if (check_col(pinfo->cinfo, COL_INFO)) {
         if (msg_count > 1)
             g_string_sprintfa(summary_label, " (%d)", msg_count);
-        col_add_fstr(pinfo->cinfo, COL_INFO, "%s", summary_label->str);
+        col_add_str(pinfo->cinfo, COL_INFO, summary_label->str);
         g_string_free(summary_label, TRUE);
     }
 
index c5d3fe28b2b30a008f6eaefc03627908419b6a75..8b4859719ec8732214e0b2ef291fb419516582ee 100644 (file)
@@ -4039,7 +4039,7 @@ dissect_giop_heur (tvbuff_t * tvb, packet_info * pinfo, proto_tree * tree) {
 
   /*define END_OF_GIOP_MESSAGE (offset - first_offset - GIOP_HEADER_SIZE) */
 
-  tot_len = tvb_length_remaining(tvb, 0);
+  tot_len = tvb_length(tvb);
 
   if (tot_len < GIOP_HEADER_SIZE) /* tot_len < 12 */
     {
index f0a77819f05a04215fd86a37bd1207453b74dff7..c088f83fe696e0a61d45b4b97f3a7846890e9e7e 100644 (file)
@@ -110,7 +110,7 @@ static gboolean dissect_h1(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   unsigned int position = 3;
   unsigned int offset=0;
 
-  if (tvb_length_remaining(tvb, 0) < 2)
+  if (tvb_length(tvb) < 2)
     {
       /* Not enough data captured to hold the "S5" header; don't try
          to interpret it as H1. */
@@ -125,7 +125,7 @@ static gboolean dissect_h1(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   if (check_col (pinfo->cinfo, COL_PROTOCOL))
     col_set_str (pinfo->cinfo, COL_PROTOCOL, "H1");
   if (check_col (pinfo->cinfo, COL_INFO))
-    col_add_str (pinfo->cinfo, COL_INFO, "S5: ");
+    col_set_str (pinfo->cinfo, COL_INFO, "S5: ");
   if (tree)
     {
       ti = proto_tree_add_item (tree, proto_h1, tvb, offset, 16, FALSE);
index e2df0f6056098cd6c425896db18ca9891b9e3465..98348f39d0459de0eac9c286a189a866303315de 100644 (file)
@@ -776,7 +776,7 @@ static void dissect_h248_annexc_NSAP(proto_tree* tree,
        asn1_ctx_init(&asn1_ctx, ASN1_ENC_BER, TRUE, pinfo);
        dissect_ber_octet_string(implicit_p ? *((gboolean*)implicit_p) : FALSE, &asn1_ctx, tree, tvb, 0, hfid, &new_tvb);
        if (new_tvb) {
-               dissect_nsap(new_tvb, 0,tvb_length_remaining(new_tvb, 0), tree);
+               dissect_nsap(new_tvb, 0,tvb_length(new_tvb), tree);
                if ( h248_info->term && ! h248_info->term->nsap) {
                        h248_info->term->nsap = se_strdup(tvb_bytes_to_str(new_tvb,0,tvb_length(new_tvb)));
                }
index 1ccee09c887a990d8fb883ad9f50cc0e3ed4fe23..a6bf8beb85ca76bf57d85364a173a7338e2bec78 100644 (file)
@@ -351,7 +351,7 @@ dissect_hsrp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
                 opcode = tvb_get_guint8(tvb, 1);
                 if (check_col(pinfo->cinfo, COL_INFO)) {
-                        col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+                        col_add_str(pinfo->cinfo, COL_INFO, 
                                      val_to_str(opcode, hsrp_opcode_vals, "Unknown"));
                }
                if (opcode < 3) {
index 03218dda9cbaaf58f698c3d8447a914f42ca4534..3b271e764f73d744e67de600b1bfd5463e7d64d7 100644 (file)
@@ -1575,7 +1575,7 @@ dissect_fullpacket (tvbuff_t * tvb, guint32 offset,
     }
 
     if( rtp_marker && check_col (pinfo->cinfo, COL_INFO))
-      col_append_fstr (pinfo->cinfo, COL_INFO, ", Mark" );
+      col_append_str (pinfo->cinfo, COL_INFO, ", Mark" );
 
 
     dissect_payload(tvb, offset, pinfo, iax2_tree, main_tree, ts, TRUE, iax_packet);
@@ -1958,7 +1958,7 @@ static void dissect_payload(tvbuff_t *tvb, guint32 offset,
 
   if( offset >= tvb_reported_length (tvb)) {
     if (check_col (pinfo->cinfo, COL_INFO))
-      col_append_fstr (pinfo->cinfo, COL_INFO, ", empty frame" );
+      col_append_str (pinfo->cinfo, COL_INFO, ", empty frame" );
     return;
   }
 
@@ -1973,7 +1973,7 @@ static void dissect_payload(tvbuff_t *tvb, guint32 offset,
                                   iax_dataformats, "unknown (0x%02x)"));
 #if 0
       if( out_of_order )
-       col_append_fstr (pinfo->cinfo, COL_INFO, " (out-of-order packet)");
+       col_append_str (pinfo->cinfo, COL_INFO, " (out-of-order packet)");
 #endif
     } else {
       col_append_fstr (pinfo->cinfo, COL_INFO, ", %s",
index 4ff5f58e33abb4d30d6f8b1fa68267a261b27b23..66fd241e24bd066afe3d86c389e67f34119d9588 100644 (file)
@@ -928,7 +928,7 @@ static void dissect_icep_batch_request(tvbuff_t *tvb, guint32 offset,
                        proto_tree_add_text(icep_tree, tvb, offset, -1,
                                            "empty batch requests sequence");
                if ( check_col(mypinfo->cinfo, COL_INFO) ) {
-                       col_append_fstr(mypinfo->cinfo, COL_INFO, 
+                       col_append_str(mypinfo->cinfo, COL_INFO, 
                                        " (empty batch requests sequence)");
                }
                
@@ -937,7 +937,7 @@ static void dissect_icep_batch_request(tvbuff_t *tvb, guint32 offset,
        
        
        if ( check_col(mypinfo->cinfo, COL_INFO) ) {
-               col_append_fstr(mypinfo->cinfo, COL_INFO, 
+               col_append_str(mypinfo->cinfo, COL_INFO, 
                                ":");
        }
        
@@ -961,7 +961,7 @@ static void dissect_icep_batch_request(tvbuff_t *tvb, guint32 offset,
                }
                        
                if ( check_col(mypinfo->cinfo, COL_INFO) && (i != 0) ) {
-                       col_append_fstr(mypinfo->cinfo, COL_INFO,
+                       col_append_str(mypinfo->cinfo, COL_INFO,
                                        ",");
                }
                
@@ -1125,7 +1125,7 @@ static void dissect_icep_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree
                col_set_str(pinfo->cinfo, COL_PROTOCOL, "ICEP");
        
        if ( check_col(pinfo->cinfo, COL_INFO) ) {
-               col_add_fstr(pinfo->cinfo, COL_INFO, "%s"
+               col_add_str(pinfo->cinfo, COL_INFO
                             val_to_str(tvb_get_guint8(tvb, 8),
                                        icep_msgtype_vals,
                                        "Unknown Message Type: 0x%02x"));
index 6deef857f883c7ee6ae6efc431c514a00f30865f..613066eaa8204881632f6cefad89bd2283fc6c8e 100644 (file)
@@ -1459,7 +1459,7 @@ dissect_icmpv6(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        if (colcodename) {
            col_add_fstr(pinfo->cinfo, COL_INFO, "%s (%s)", coltypename, colcodename);
        } else {
-           col_add_fstr(pinfo->cinfo, COL_INFO, "%s", coltypename);
+           col_add_str(pinfo->cinfo, COL_INFO, coltypename);
        }
     }
 
index abbeb91265dd737a23cc8b7b70326031eaf911bc..c56ecc1d47b26ed9274e49325dd4651d163f10c9 100644 (file)
@@ -2810,7 +2810,7 @@ static void
 dissect_vendor_ie_wpawme(proto_tree * ietree, proto_tree * tree, tvbuff_t * tag_tvb)
 {
   gint tag_off = 0;
-  gint tag_len = tvb_length_remaining(tag_tvb, 0);
+  gint tag_len = tvb_length(tag_tvb);
   gchar out_buff[SHORT_STR];
   guint i, byte1, byte2;
 
@@ -2997,7 +2997,7 @@ static void
 dissect_vendor_ie_rsn(proto_tree * ietree, proto_tree * tree, tvbuff_t * tag_tvb)
 {
   guint tag_off = 0;
-  guint tag_len = tvb_length_remaining(tag_tvb, 0);
+  guint tag_len = tvb_length(tag_tvb);
   guint pmkid_len = tag_len - 4;
   char out_buff[SHORT_STR], valid_str[SHORT_STR] = "";
 
@@ -3095,7 +3095,7 @@ static void
 dissect_rsn_ie(proto_tree * tree, tvbuff_t * tag_tvb)
 {
   guint tag_off = 0;
-  guint tag_len = tvb_length_remaining(tag_tvb, 0);
+  guint tag_len = tvb_length(tag_tvb);
   guint16 rsn_capab;
   char out_buff[SHORT_STR];
   int i, count;
@@ -3771,7 +3771,7 @@ dissect_frame_control(proto_tree * tree, tvbuff_t * tvb, gboolean wlan_broken_fc
 static void
 dissect_vendor_ie_ht(proto_tree * ietree, proto_tree * tree, tvbuff_t * tag_tvb)
 {
-  gint tag_len = tvb_length_remaining(tag_tvb, 0);
+  gint tag_len = tvb_length(tag_tvb);
   gchar out_buff[SHORT_STR];
 
   g_snprintf(out_buff, SHORT_STR, "802.11n (Pre) OUI");
@@ -3918,7 +3918,7 @@ add_tagged_field (packet_info * pinfo, proto_tree * tree, tvbuff_t * tvb, int of
             col_append_fstr(pinfo->cinfo, COL_INFO, ", SSID=\"%s\"",
                             format_text(ssid, tag_len));
           } else {
-            col_append_fstr(pinfo->cinfo, COL_INFO, ", SSID=Broadcast");
+            col_append_str(pinfo->cinfo, COL_INFO, ", SSID=Broadcast");
           }
         }
         if (tag_len > 0) {
@@ -5350,8 +5350,7 @@ set_src_addr_cols(packet_info *pinfo, const guint8 *addr, const char *type)
     col_add_fstr(pinfo->cinfo, COL_RES_DL_SRC, "%s (%s)",
         get_ether_name(addr), type);
   if (check_col(pinfo->cinfo, COL_UNRES_DL_SRC))
-    col_add_fstr(pinfo->cinfo, COL_UNRES_DL_SRC, "%s",
-        ether_to_str(addr));
+    col_add_str(pinfo->cinfo, COL_UNRES_DL_SRC, ether_to_str(addr));
 }
 
 static void
@@ -5361,8 +5360,7 @@ set_dst_addr_cols(packet_info *pinfo, const guint8 *addr, const char *type)
     col_add_fstr(pinfo->cinfo, COL_RES_DL_DST, "%s (%s)",
         get_ether_name(addr), type);
   if (check_col(pinfo->cinfo, COL_UNRES_DL_DST))
-    col_add_fstr(pinfo->cinfo, COL_UNRES_DL_DST, "%s",
-        ether_to_str(addr));
+    col_add_str(pinfo->cinfo, COL_UNRES_DL_DST, ether_to_str(addr));
 }
 
 static guint32
index 85b29d7ae0373ef54e01c9e6962370b4510d18ce..1241bd43cdb528f3b9e1fcce1ee626c6f342206a 100644 (file)
@@ -155,7 +155,7 @@ dissect_igap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree, int off
 
     type = tvb_get_guint8(tvb, offset);
     if (check_col(pinfo->cinfo, COL_INFO)) {
-       col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+       col_add_str(pinfo->cinfo, COL_INFO, 
                     val_to_str(type, igap_types, "Unknown Type: 0x%02x"));
     }
     proto_tree_add_uint(tree, hf_type, tvb, offset, 1, type);
index fc95252a8be679acbb95d89a0fe4b48371c224ed..44affe05274c9cc319f8fca53c780ed2754aed04 100644 (file)
@@ -74,13 +74,13 @@ static void dissect_igrp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   if (check_col(pinfo->cinfo, COL_INFO)) {
     switch (ver_and_opcode) {
     case 0x11:
-       col_add_fstr(pinfo->cinfo, COL_INFO, "Response" );
+       col_set_str(pinfo->cinfo, COL_INFO, "Response" );
        break;
     case 0x12:
-       col_add_fstr(pinfo->cinfo, COL_INFO, "Request" );
+       col_set_str(pinfo->cinfo, COL_INFO, "Request" );
         break;
     default:
-        col_add_fstr(pinfo->cinfo, COL_INFO, "Unknown version or opcode");
+        col_set_str(pinfo->cinfo, COL_INFO, "Unknown version or opcode");
     }
   }
 
index 7c2cb96b8de3bcf8f70eaf3eebc15c915205b6d8..5b98b5348a5c130ebb723c5f8a1ccd80e5c99af7 100644 (file)
@@ -487,7 +487,7 @@ static void dissect_imf(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     tree = proto_item_add_subtree(item, ett_imf);
   }
 
-  max_length = tvb_length_remaining(tvb, 0);
+  max_length = tvb_length(tvb);
   /* first go through the tvb until we find a blank line and extract the content type if
      we find one */
 
index 2b70df4835d5796fc3073d0b4b65f8c7257658a8..4c28cf69f05a06c66736b121df3d754f762dfe21 100644 (file)
@@ -2145,7 +2145,7 @@ dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   }
 
   if (check_col(pinfo->cinfo, COL_INFO)) {
-    col_add_str(pinfo->cinfo, COL_INFO, type_str);
+    col_set_str(pinfo->cinfo, COL_INFO, type_str);
     if (code_str[0] != '\0')
       col_append_fstr(pinfo->cinfo, COL_INFO, " %s", code_str);
   }
index 0462e90fb7e4f1f223ac125b48045af68ec72335..5ffa34e164deb7a54dc64fedd52cd610d2f54e6d 100644 (file)
@@ -4259,7 +4259,7 @@ dissect_ipmi(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                                tvb, offset, 1, TRUE);
                offset++;
                if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+                       col_add_str(pinfo->cinfo, COL_INFO, 
                                val_to_str(payloadtype, ipmi_payload_vals,      "Unknown (0x%02x)"));
                }
 
index fbbbe4b8f6c41f578d0dbef39c8318739c588add..9b3e04b836fb8cecfa63e5d4090ee359fdf3c283 100644 (file)
@@ -1119,7 +1119,7 @@ static void ipv6_shim6_checkum_additional_info(tvbuff_t * tvb, packet_info * pin
        if (!is_cksum_correct) {
          expert_add_info_format(pinfo, item, PI_CHECKSUM, PI_ERROR, "Bad checksum");
          if (check_col(pinfo->cinfo, COL_INFO))
-           col_append_fstr(pinfo->cinfo, COL_INFO, " [Shim6 CHECKSUM INCORRECT]");
+           col_append_str(pinfo->cinfo, COL_INFO, " [Shim6 CHECKSUM INCORRECT]");
        }
 }
 
@@ -1480,7 +1480,7 @@ again:
             }
             if (shim6) {
                if (stype & SHIM6_BITMASK_P) {
-                 col_append_fstr(pinfo->cinfo, COL_INFO, "Shim6 (Payload)");
+                 col_append_str(pinfo->cinfo, COL_INFO, "Shim6 (Payload)");
                }
                else {
                  col_append_fstr(pinfo->cinfo, COL_INFO, "Shim6 (%s)", 
index 79cfc006375cac6ba5378e215ce4ad96f4cf8a4a..f3ff67dfbcaf26c474fe68be7356cf4adc0a40e1 100644 (file)
@@ -867,7 +867,7 @@ dissect_isakmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
    */
   if( (tvb_length(tvb)==1) && (tvb_get_guint8(tvb, offset)==0xff) ){
     if (check_col(pinfo->cinfo, COL_INFO)){
-      col_add_str(pinfo->cinfo, COL_INFO, "NAT Keepalive");
+      col_set_str(pinfo->cinfo, COL_INFO, "NAT Keepalive");
     }
     proto_tree_add_item(isakmp_tree, hf_isakmp_nat_keepalive, tvb, offset, 1, FALSE);
     return;
index c5c5dd2cdc3c5781f1b6d23f892f131b89cb3b85..140f3908d8ba5de9a623d760f163b31c064cc3ad 100644 (file)
@@ -1703,7 +1703,7 @@ dissect_iscsi(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, gboolean chec
     /* Set up structures needed to add the protocol subtree and manage it */
     guint iSCSIPdusDissected = 0;
     guint offset = 0;
-    guint32 available_bytes = tvb_length_remaining(tvb, offset);
+    guint32 available_bytes = tvb_length(tvb);
     int digestsActive = 1;
     conversation_t *conversation = NULL;
     iscsi_session_t *iscsi_session=NULL;
index 1520e9aed911b2920814377ca3eb1c4d00313d1b..bd70860289a81ca376f888f079e53e9f53d07b74 100644 (file)
@@ -646,7 +646,7 @@ dissect_hello_checksum_clv(tvbuff_t *tvb,
                        case DATA_MISSING :
                                isis_dissect_unknown(tvb, tree, offset,
                                                      "[packet length %d went beyond packet]",
-                                                     tvb_length_remaining(tvb, 0));
+                                                     tvb_length(tvb));
                        break;
                        case CKSUM_NOT_OK :
                                 proto_tree_add_text ( tree, tvb, offset, length,
index d80c41e3b84c883cb53f23fd03005b9d3babf273..d37425dd778eb33a66a6297fbc584e9998a58aa0 100644 (file)
@@ -1746,7 +1746,7 @@ static void isis_lsp_checkum_additional_info(tvbuff_t * tvb, packet_info * pinfo
        if (!is_cksum_correct) {
          expert_add_info_format(pinfo, item, PI_CHECKSUM, PI_ERROR, "Bad checksum");
          if (check_col(pinfo->cinfo, COL_INFO))
-           col_append_fstr(pinfo->cinfo, COL_INFO, " [ISIS CHECKSUM INCORRECT]");
+           col_append_str(pinfo->cinfo, COL_INFO, " [ISIS CHECKSUM INCORRECT]");
        }
 }
 
index 363712859e2357d4f158295a08affd8d6b48868c..7c6bcd53c0e2cda3e304a667933fa68b97137afb 100644 (file)
@@ -509,7 +509,7 @@ dissect_snp_checksum_clv(tvbuff_t *tvb,
                        case DATA_MISSING :
                                isis_dissect_unknown(tvb, tree, offset,
                                                      "[packet length %d went beyond packet]",
-                                                     tvb_length_remaining(tvb, 0));
+                                                     tvb_length(tvb));
                        break;
                        case CKSUM_NOT_OK :
                                 proto_tree_add_text ( tree, tvb, offset, length,
index 8308c4faca81da5b5a3faff6a42cad913511c083..7aab96710562a3317ed4377c7905ad21a922c06d 100644 (file)
@@ -607,7 +607,7 @@ dissect_isns_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     guint offset = 0;
     guint16 function_id;
     guint16 isns_protocol_version;
-    guint32 packet_len = tvb_length_remaining(tvb, offset);
+    guint32 packet_len = tvb_length(tvb);
     /* Set up structures needed to add the protocol subtree and manage it */
     proto_item *ti = NULL;
     proto_tree *isns_tree = NULL;
@@ -784,7 +784,7 @@ get_isns_pdu_len(packet_info *pinfo _U_, tvbuff_t *tvb, int offset)
 static int
 dissect_isns_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {      
-       gint length = tvb_length_remaining(tvb, 0);
+       gint length = tvb_length(tvb);
        guint16 isns_protocol_version;
        guint16 function_id;
 
@@ -815,7 +815,7 @@ dissect_isns_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 static int
 dissect_isns_udp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {      
-       gint length = tvb_length_remaining(tvb, 0);
+       gint length = tvb_length(tvb);
        guint16 isns_protocol_version;
        guint16 function_id;
 
index dd7becbb2e566961855b4ffcb658c9dbbed4dd05..9d256ce7c789dbff9fdef75a584d5492f59aea14 100644 (file)
@@ -803,7 +803,7 @@ static void dissect_iuup(tvbuff_t* tvb_in, packet_info* pinfo, proto_tree* tree)
 
 
 static gboolean dissect_iuup_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) {
-       int len = tvb_length_remaining(tvb,0);
+       int len = tvb_length(tvb);
        
        guint8 first_octet =  tvb_get_guint8(tvb,0);
        guint8 second_octet =  tvb_get_guint8(tvb,1);
@@ -834,7 +834,7 @@ static gboolean dissect_iuup_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree
 
 
 static void find_iuup(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) {
-       int len = tvb_length_remaining(tvb,0);
+       int len = tvb_length(tvb);
        int offset = 0;
        
        while (len > 3) {
index 0b392d6cb68b211e839708a6ff1af1d0265895f3..55ee55b5b6c6d81f0f027d3d3ec88f64f380ca32 100644 (file)
@@ -1052,7 +1052,7 @@ static int dissect_jxta_welcome(tvbuff_t * tvb, packet_info * pinfo, proto_tree
     }
 
     if (check_col(pinfo->cinfo, COL_INFO)) {
-        col_add_str(pinfo->cinfo, COL_INFO, "Welcome");
+        col_set_str(pinfo->cinfo, COL_INFO, "Welcome");
     }
 
     {
index 66324174c790837fed8a80e192e5f4ed2aaad949..22c876a2b1dd8f80b0ef7abad0fa4da47640b209 100644 (file)
@@ -203,7 +203,7 @@ dissect_kink(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree){
     
   /* It shows kink type by the type value. */
   if(check_col(pinfo->cinfo, COL_INFO)){
-    col_add_fstr(pinfo->cinfo, COL_INFO, "%s", val_to_str(type, kink_type_vals, "unknown"));
+    col_add_str(pinfo->cinfo, COL_INFO,  val_to_str(type, kink_type_vals, "unknown"));
   }
   /* Make the kink tree */
   if(tree){
index 2e62f22ddc3f1e5c5a36774ee18437e93c30cac5..b382fdec3dd1de5bdd7d64667e289efb738cf84c 100644 (file)
@@ -2264,7 +2264,7 @@ dissect_msg(tvbuff_t *tvb, guint offset, packet_info *pinfo, proto_tree *tree)
 
        if( rem < 8 ) {/*chk for minimum header = type + length + msg_id*/
                if( check_col(pinfo->cinfo, COL_INFO) )
-                       col_append_fstr(pinfo->cinfo, COL_INFO, "Bad Message");
+                       col_append_str(pinfo->cinfo, COL_INFO, "Bad Message");
                if(tree)
                        proto_tree_add_text(tree, tvb, offset, rem,
                            "Error processing Message: length is %d, should be >= 8",
@@ -2287,7 +2287,7 @@ dissect_msg(tvbuff_t *tvb, guint offset, packet_info *pinfo, proto_tree *tree)
 
        if( (length = tvb_get_ntohs(tvb, offset + 2)) < (4+extra) ) {/*not enough data for type*/
                if( check_col(pinfo->cinfo, COL_INFO) )
-                       col_append_fstr(pinfo->cinfo, COL_INFO, "Bad Message Length ");
+                       col_append_str(pinfo->cinfo, COL_INFO, "Bad Message Length ");
                if(tree)
                        proto_tree_add_text(tree, tvb, offset, rem,
                            "Error processing Message Length: length is %d, should be >= %u",
index 51e3f90b04e385537365628db00461cd249ebe17..726883fb998ecd39e4ff5f0ebcf969145325bf96 100644 (file)
@@ -420,7 +420,7 @@ dissect_basicxid(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        } else
                xid_tree = NULL;
        if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_append_fstr(pinfo->cinfo, COL_INFO,
+               col_append_str(pinfo->cinfo, COL_INFO,
                    "Basic Format");
        }
 
index 264244ae611418d5747c01c91e1cfd523a2d3fc3..ed296f068f8a9b7acdebe8bbd73db05a4e3c9ef6 100644 (file)
@@ -118,7 +118,7 @@ dissect_loop(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   } while (more_function);
 
   if (set_info && check_col(pinfo->cinfo, COL_INFO)) {
-    col_add_str(pinfo->cinfo, COL_INFO, "No valid function found");
+    col_set_str(pinfo->cinfo, COL_INFO, "No valid function found");
   }
 
   if (tvb_length_remaining(tvb, offset) > 0)
index 5ce768f6bc599343fc7d733e00ddf5293d3e8e73..cf202a73ce389ae6cc44cca36f2b0f47445e9d0a 100644 (file)
@@ -275,7 +275,7 @@ static void dissect_control(tvbuff_t *tvb, packet_info *pinfo,
        col_set_str(pinfo->cinfo, COL_PROTOCOL, "LWAPP");
     if (check_col(pinfo->cinfo, COL_INFO)) {
        col_clear(pinfo->cinfo, COL_INFO);
-        col_add_str(pinfo->cinfo, COL_INFO,
+        col_set_str(pinfo->cinfo, COL_INFO,
                     "CNTL ");
     }
 
@@ -339,7 +339,7 @@ static void dissect_lwapp_l3(tvbuff_t *tvb, packet_info *pinfo,
        col_set_str(pinfo->cinfo, COL_PROTOCOL, "LWAPP-L3");
     if (check_col(pinfo->cinfo, COL_INFO)) {
        col_clear(pinfo->cinfo, COL_INFO);
-        col_add_str(pinfo->cinfo, COL_INFO, "802.3 Packets over Layer 3");
+        col_set_str(pinfo->cinfo, COL_INFO, "802.3 Packets over Layer 3");
     }
 
     if (tree) {
@@ -383,7 +383,7 @@ static void dissect_lwapp(tvbuff_t *tvb, packet_info *pinfo,
        col_set_str(pinfo->cinfo, COL_PROTOCOL, "LWAPP");
     if (check_col(pinfo->cinfo, COL_INFO)) {
        col_clear(pinfo->cinfo, COL_INFO);
-        col_add_str(pinfo->cinfo, COL_INFO,
+        col_set_str(pinfo->cinfo, COL_INFO,
                     "LWAPP IP or Layer 2");
     }
 
index ad7591ccc68855e59d5f8eda8cc62eb99675fbbf..1e776a90af51fa4901f9ee082f3b65e4e0ab5c73 100644 (file)
@@ -59,7 +59,7 @@ dissect_media(tvbuff_t *tvb, packet_info *pinfo , proto_tree *tree)
     }
 
     if (tree) {
-        if ( (bytes = tvb_length_remaining(tvb, 0)) > 0 )
+        if ( (bytes = tvb_length(tvb)) > 0 )
         {
             ti = proto_tree_add_item(tree, proto_media, tvb, 0, -1, FALSE);
             media_tree = proto_item_add_subtree(ti, ett_media);
index b3490cb939371d2a6244246de217922fea367db5..69398c5a53128fcd92efd73d3f46bfdb2f2b5d08 100644 (file)
@@ -481,7 +481,7 @@ dissect_mpls(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     }
 
     if (check_col(pinfo->cinfo,COL_INFO)) {
-       col_add_fstr(pinfo->cinfo,COL_INFO,"MPLS Label Switched Packet");
+       col_set_str(pinfo->cinfo,COL_INFO,"MPLS Label Switched Packet");
     }
 
     /* Start Decoding Here. */
index 128a19515c6a6babd3b0bd33c1890e548b5276ef..4de3dcd8015e189c52872fd962ed859b6c98b74d 100644 (file)
@@ -226,7 +226,7 @@ dissect_mqpcf(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
                if (check_col(pinfo->cinfo, COL_INFO)) 
                {
-                       col_append_fstr(pinfo->cinfo, COL_INFO, "%s", val_to_str(iCommand, mqpcf_opcode_vals, "Unknown (0x%02x)"));
+                       col_append_str(pinfo->cinfo, COL_INFO, val_to_str(iCommand, mqpcf_opcode_vals, "Unknown (0x%02x)"));
                }
 
                if (tree)
index 8718572ec9bf45b117c9a23fd0bb0692bcad64ab..545d6c49fafa1aafcd8d9a42e3f448dd2b462dc8 100644 (file)
@@ -1272,7 +1272,7 @@ dissect_mq_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
                        if (check_col(pinfo->cinfo, COL_INFO))
                        {
-                               col_append_fstr(pinfo->cinfo, COL_INFO, "%s", val_to_str(opcode, mq_opcode_vals, "Unknown (0x%02x)"));
+                               col_append_str(pinfo->cinfo, COL_INFO, val_to_str(opcode, mq_opcode_vals, "Unknown (0x%02x)"));
                        }
 
                        if (tree)
index dd8413adaf2d0d60402da734a14d17befeeb3a13..36a7efba8816a9b6fbd0ef25c4de592ae450987e 100644 (file)
@@ -213,8 +213,8 @@ dissect_mrdisc(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree, int o
 
        type = tvb_get_guint8(tvb, offset);
        if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_add_fstr(pinfo->cinfo, COL_INFO,
-                       "%s",val_to_str(type, mrdisc_types,
+               col_add_str(pinfo->cinfo, COL_INFO,
+                       val_to_str(type, mrdisc_types,
                                "Unknown Type:0x%02x"));
        }
 
index 3c089d732160b1742c5f8f58881b9e010d238e90..7ce282ac7b4feb719018a3b7dc1ac8fbc7a1f4e6 100644 (file)
@@ -322,7 +322,7 @@ static gint dissect_msmms_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tre
     /* Work out what type of packet this is and dissect it as such */
 
     /* Just don't dissect if can't even read command signature */
-    if (tvb_length_remaining(tvb, 0) < 8)
+    if (tvb_length(tvb) < 8)
     {
         return 0;
     }
@@ -612,7 +612,7 @@ gint dissect_msmms_data_udp_command(tvbuff_t *tvb, packet_info *pinfo, proto_tre
 
     if (check_col(pinfo->cinfo, COL_INFO))
     {
-        col_add_str(pinfo->cinfo, COL_INFO, "Request to resend packet(s):");
+        col_set_str(pinfo->cinfo, COL_INFO, "Request to resend packet(s):");
     }
 
     /* Show list of packets to resend */
index d68c107790c5d966d46b6416d7b7a3d402390037..a4d31b5ef5e7cb090eaf37f2a7b29efb12d35545 100644 (file)
@@ -96,7 +96,7 @@ dissect_msnms(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                /*
                 * Put the first line from the buffer into the summary.
                 */
-               col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+               col_add_str(pinfo->cinfo, COL_INFO, 
                            format_text(line, linelen));
        }
 
index 775083aa06f2df32988e411465ff7925f7bc47d6..f3af65c908c8a48523659dd55b43e23292c47138 100644 (file)
@@ -243,8 +243,8 @@ dissect_msnip(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree, int of
 
        type = tvb_get_guint8(tvb, offset);
        if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_add_fstr(pinfo->cinfo, COL_INFO,
-                       "%s",val_to_str(type, msnip_types,
+               col_add_str(pinfo->cinfo, COL_INFO,
+                       val_to_str(type, msnip_types,
                                "Unknown Type:0x%02x"));
        }
 
index 512166bd8403905047d443af2f653d06b7038dcc..aa9c806e6e90a575df1f9130dadab0a022979c28 100644 (file)
@@ -60,7 +60,7 @@ dissect_msnlb(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
   if (check_col(pinfo->cinfo, COL_INFO)) {
     col_clear(pinfo->cinfo, COL_INFO);
-    col_append_fstr(pinfo->cinfo, COL_INFO, "MS NLB heartbeat");
+    col_append_str(pinfo->cinfo, COL_INFO, "MS NLB heartbeat");
   }
 
   if (tree) {
index 86e449b431dc9ebc342d15a54038b4c33e5abc6b..6dd8bffbdbab21491d347df4dcfff0aadcb7ecf3 100644 (file)
@@ -456,7 +456,7 @@ dissect_mtp3mg_unknown_message(tvbuff_t *tvb, proto_tree *tree)
 {
     guint8 message_length;
 
-    message_length = tvb_length_remaining(tvb, 0);
+    message_length = tvb_length(tvb);
     proto_tree_add_text(tree, tvb, 0, message_length,
                        "Unknown message (%u byte%s)", message_length,
                        plurality(message_length, "", "s"));
@@ -1109,7 +1109,7 @@ dissect_mtp3mg(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
            default:
                if (check_col(pinfo->cinfo, COL_INFO))
-                   col_add_fstr(pinfo->cinfo, COL_INFO, "Unknown ");
+                   col_set_str(pinfo->cinfo, COL_INFO, "Unknown ");
 
                dissect_mtp3mg_unknown_message(tvb, mtp3mg_tree);
            } /* switch */
@@ -1203,7 +1203,7 @@ dissect_mtp3mg(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        default:
            if (check_col(pinfo->cinfo, COL_INFO))
-               col_add_fstr(pinfo->cinfo, COL_INFO, "Unknown ");
+               col_set_str(pinfo->cinfo, COL_INFO, "Unknown ");
 
            dissect_mtp3mg_unknown_message(tvb, mtp3mg_tree);
        } /* switch */
index a71b69f295317502d80e5d5193186fb72380995a..fe2ceb393c5ea0d19434b3ad4588ae4779f75c3a 100644 (file)
@@ -182,7 +182,7 @@ base64_decode(packet_info *pinfo, tvbuff_t *b64_tvb, char *name)
        char *data;
        size_t len;
 
-       data = g_strdup(tvb_get_ephemeral_string(b64_tvb, 0, tvb_length_remaining(b64_tvb, 0)));
+       data = g_strdup(tvb_get_ephemeral_string(b64_tvb, 0, tvb_length(b64_tvb)));
 
        len = epan_base64_decode(data);
        tvb = tvb_new_real_data((const guint8 *)data, len, len);
index 5f89a3f4f52a45b2bdd0bc31bf8a49ca4b816490..d6bbc930ad848fb38bd82f8f085b4b006e2cf0ac 100644 (file)
@@ -1044,13 +1044,13 @@ static void dissect_mysql_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tre
        if (is_response) {
                if (packet_number == 0) {
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_str(pinfo->cinfo, COL_INFO, "Server Greeting" );
+                               col_set_str(pinfo->cinfo, COL_INFO, "Server Greeting" );
                        }
                        offset= mysql_dissect_greeting(tvb, pinfo, offset,
                                                       mysql_tree, conn_data);
                } else {
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_str(pinfo->cinfo, COL_INFO, "Response" );
+                               col_set_str(pinfo->cinfo, COL_INFO, "Response" );
                        }
                        offset= mysql_dissect_response(tvb, pinfo, offset,
                                                       mysql_tree, conn_data);
@@ -1058,13 +1058,13 @@ static void dissect_mysql_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tre
        } else {
                if (packet_number == 1) {
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_str(pinfo->cinfo, COL_INFO, "Login Request");
+                               col_set_str(pinfo->cinfo, COL_INFO, "Login Request");
                        }
                        offset= mysql_dissect_login(tvb, pinfo, offset,
                                                    mysql_tree, conn_data);
                } else {
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_str(pinfo->cinfo, COL_INFO, "Request");
+                               col_set_str(pinfo->cinfo, COL_INFO, "Request");
                        }
                        offset= mysql_dissect_request(tvb, pinfo, offset,
                                                      mysql_tree, conn_data);
index abfa1035609588878cf3bda0f1350bb7e08dd84b..c3d150055d3c5ffedced2bcee4f69fd54ace2500 100644 (file)
@@ -364,7 +364,7 @@ dissect_nbd_tcp_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
                                col_add_fstr(pinfo->cinfo, COL_INFO, "Read Request  Offset:0x%" G_GINT64_MODIFIER "x Length:%d", from, nbd_trans->datalen);
                                break;
                        case NBD_CMD_DISC:
-                               col_add_str(pinfo->cinfo, COL_INFO, "Disconnect Request");
+                               col_set_str(pinfo->cinfo, COL_INFO, "Disconnect Request");
                                break;
                        }
                }
index 24d67e64889543135159c362465caa9120eacfc6..917686bd20ec0eadcc6c5dc1eed63ea1737a1efd 100644 (file)
@@ -334,7 +334,7 @@ dissect_nbipx(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        case NBIPX_SESSION_END:
        case NBIPX_SESSION_END_ACK:
                if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+                       col_add_str(pinfo->cinfo, COL_INFO,
                                val_to_str(packet_type, nbipx_data_stream_type_vals, "Unknown"));
                }
                dissect_conn_control(tvb, offset, nbipx_tree);
@@ -407,7 +407,7 @@ dissect_nbipx(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        case NBIPX_DIRECTED_DATAGRAM:
                if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+                       col_add_str(pinfo->cinfo, COL_INFO, 
                                val_to_str(packet_type, nbipx_data_stream_type_vals, "Unknown"));
                }
                dissect_conn_control(tvb, offset, nbipx_tree);
@@ -434,7 +434,7 @@ dissect_nbipx(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        default:
                if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+                       col_add_str(pinfo->cinfo, COL_INFO, 
                                val_to_str(packet_type, nbipx_data_stream_type_vals, "Unknown"));
                }
 
index 3af5691d2271f62152ec8e565c7e4db09077a2d5..791874b020d08ffded39acfa6b60e93621d67e7f 100644 (file)
@@ -1785,7 +1785,7 @@ dissect_nbss(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        }
 
        if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_add_fstr(pinfo->cinfo, COL_INFO,
+               col_add_str(pinfo->cinfo, COL_INFO,
                    val_to_str(msg_type, message_types, "Unknown (%02x)"));
        }
 
@@ -1815,7 +1815,7 @@ continuation:
         * It looks like a continuation.
         */
        if (check_col(pinfo->cinfo, COL_INFO))
-               col_add_fstr(pinfo->cinfo, COL_INFO, "NBSS Continuation Message");
+               col_set_str(pinfo->cinfo, COL_INFO, "NBSS Continuation Message");
 
        if (tree) {
                ti = proto_tree_add_item(tree, proto_nbss, tvb, 0, -1, FALSE);
index 9583c43c525497df995b9d6761b53cbd817679d9..0aa3b0479ad14653ba6fd33533ff6fb60e8db075 100644 (file)
@@ -684,7 +684,7 @@ dissect_sss_request(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ncp_tree, ncp
         else
         {
             if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_add_fstr(pinfo->cinfo, COL_INFO, "C SecretStore - fragment");
+               col_set_str(pinfo->cinfo, COL_INFO, "C SecretStore - fragment");
                proto_tree_add_text(ncp_tree, tvb, foffset, 4, "Fragment");
             }
             /* Fragments don't really carry a subverb so store 0xff as the subverb number */
index c71eeab184e7773b550f987da45feed791533493..0f5978a2f1ba85aea73fdf4beee1117fd1e24353 100644 (file)
@@ -465,8 +465,7 @@ dissect_ncp_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
        tap_queue_packet(ncp_tap.hdr, pinfo, ncp_hdr);
 
        if (check_col(pinfo->cinfo, COL_INFO)) {
-           col_add_fstr(pinfo->cinfo, COL_INFO,
-                   "%s",
+           col_add_str(pinfo->cinfo, COL_INFO,
                    val_to_str(header.type, ncp_type_vals, "Unknown type (0x%04x)"));
        }
 
index 8ef5902c3c7010d867f89177c264abb560c847d4..2336f5fe7420b48531fd3cb9aca9a179f018efcf 100644 (file)
@@ -12039,7 +12039,7 @@ dissect_ping_req(tvbuff_t *tvb, packet_info *pinfo,
                 {
                         
                        col_set_str(pinfo->cinfo, COL_PROTOCOL, "NDS");
-                        col_add_fstr(pinfo->cinfo, COL_INFO, "C Ping for NDS");
+                        col_set_str(pinfo->cinfo, COL_INFO, "C Ping for NDS");
                        }
                 
         }
index c306645a525af3eacd0d327b2538770f4b68ff5a..51188c5fb8799f26b71e6d23acb1e021151a9c78 100644 (file)
@@ -4186,7 +4186,7 @@ dissect_ndps(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ndps_tree)
     if (ndps_packet_type != 0 && ndps_packet_type != 1) {     /* Packet Type */
         if (check_col(pinfo->cinfo, COL_INFO))
             col_set_str(pinfo->cinfo, COL_INFO, "(Continuation Data)");
-        proto_tree_add_text(ndps_tree, tvb, 0, tvb_length_remaining(tvb, 0), "Data - (%d Bytes)", tvb_length_remaining(tvb, 0));
+        proto_tree_add_text(ndps_tree, tvb, 0, tvb_length(tvb), "Data - (%d Bytes)", tvb_length(tvb));
         return;
     }
     foffset = 0;
@@ -4438,7 +4438,7 @@ ndps_defrag(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                     {
                       if (!spx_info->eom)
                       {
-                        col_append_fstr(pinfo->cinfo, COL_INFO, "[NDPS Fragment]");
+                        col_append_str(pinfo->cinfo, COL_INFO, "[NDPS Fragment]");
                       }
                     }
                 }
@@ -4450,7 +4450,7 @@ ndps_defrag(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                 {
                   if (!spx_info->eom)
                   {
-                    col_append_fstr(pinfo->cinfo, COL_INFO, "[NDPS Fragment]");
+                    col_append_str(pinfo->cinfo, COL_INFO, "[NDPS Fragment]");
                   }
                 }
                 next_tvb = NULL;
@@ -6743,7 +6743,7 @@ ndps_error(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ndps_tree, int foffset
 
     ndps_problem_type = tvb_get_ntohl(tvb, foffset);
     if (check_col(pinfo->cinfo, COL_INFO))
-        col_add_fstr(pinfo->cinfo, COL_INFO, "R NDPS - Error");
+        col_set_str(pinfo->cinfo, COL_INFO, "R NDPS - Error");
     expert_item = proto_tree_add_uint(ndps_tree, hf_ndps_problem_type, tvb, foffset, 4, ndps_problem_type);
     expert_add_info_format(pinfo, expert_item, PI_RESPONSE_CODE, PI_ERROR, "Fault: %s", val_to_str(ndps_problem_type, error_type_enum, "Unknown NDPS Error (0x%08x)"));
     foffset += 4;
@@ -6947,7 +6947,7 @@ return_code(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ndps_tree, int foffse
     }
     foffset += 4;
     if (check_col(pinfo->cinfo, COL_INFO) && tvb_get_ntohl(tvb, foffset-4) != 0)
-        col_add_fstr(pinfo->cinfo, COL_INFO, "R NDPS - Error");
+        col_set_str(pinfo->cinfo, COL_INFO, "R NDPS - Error");
     if (tvb_get_ntohl(tvb, foffset-4) == 0)
     {
         return foffset;
@@ -7965,7 +7965,7 @@ dissect_ndps_reply(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ndps_tree, int
             proto_tree_add_item(ndps_tree, hf_ndps_return_code, tvb, foffset, 4, FALSE);
             foffset += 4;
             if (check_col(pinfo->cinfo, COL_INFO) && tvb_get_ntohl(tvb, foffset-4) != 0)
-                col_add_fstr(pinfo->cinfo, COL_INFO, "R NDPS - Error");
+                col_set_str(pinfo->cinfo, COL_INFO, "R NDPS - Error");
             if (tvb_get_ntohl(tvb, foffset-4) != 0)
             {
                 break;
@@ -8219,7 +8219,7 @@ dissect_ndps_reply(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ndps_tree, int
             proto_tree_add_item(ndps_tree, hf_ndps_return_code, tvb, foffset, 4, FALSE);
             foffset += 4;
             if (check_col(pinfo->cinfo, COL_INFO) && tvb_get_ntohl(tvb, foffset-4) != 0)
-                col_add_fstr(pinfo->cinfo, COL_INFO, "R NDPS - Error");
+                col_set_str(pinfo->cinfo, COL_INFO, "R NDPS - Error");
             if (tvb_get_ntohl(tvb, foffset-4) != 0)
             {
                 break;
@@ -8234,7 +8234,7 @@ dissect_ndps_reply(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ndps_tree, int
             proto_tree_add_item(ndps_tree, hf_ndps_return_code, tvb, foffset, 4, FALSE);
             foffset += 4;
             if (check_col(pinfo->cinfo, COL_INFO) && tvb_get_ntohl(tvb, foffset-4) != 0)
-                col_add_fstr(pinfo->cinfo, COL_INFO, "R NDPS - Error");
+                col_set_str(pinfo->cinfo, COL_INFO, "R NDPS - Error");
             if (tvb_get_ntohl(tvb, foffset-4) != 0)
             {
                 break;
@@ -8258,7 +8258,7 @@ dissect_ndps_reply(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ndps_tree, int
             proto_tree_add_item(ndps_tree, hf_ndps_return_code, tvb, foffset, 4, FALSE);
             foffset += 4;
             if (check_col(pinfo->cinfo, COL_INFO) && tvb_get_ntohl(tvb, foffset-4) != 0)
-                col_add_fstr(pinfo->cinfo, COL_INFO, "R NDPS - Error");
+                col_set_str(pinfo->cinfo, COL_INFO, "R NDPS - Error");
             if (tvb_get_ntohl(tvb, foffset-4) != 0)
             {
                 break;
@@ -8277,7 +8277,7 @@ dissect_ndps_reply(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ndps_tree, int
             proto_tree_add_item(ndps_tree, hf_ndps_return_code, tvb, foffset, 4, FALSE);
             foffset += 4;
             if (check_col(pinfo->cinfo, COL_INFO) && tvb_get_ntohl(tvb, foffset-4) != 0)
-                col_add_fstr(pinfo->cinfo, COL_INFO, "R NDPS - Error");
+                col_set_str(pinfo->cinfo, COL_INFO, "R NDPS - Error");
             break;
         case 0x00000002:    /* Delivery Unbind */
             /* NoOp */
@@ -8287,7 +8287,7 @@ dissect_ndps_reply(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ndps_tree, int
             proto_tree_add_item(ndps_tree, hf_ndps_return_code, tvb, foffset, 4, FALSE);
             foffset += 4;
             if (check_col(pinfo->cinfo, COL_INFO) && tvb_get_ntohl(tvb, foffset-4) != 0)
-                col_add_fstr(pinfo->cinfo, COL_INFO, "R NDPS - Error");
+                col_set_str(pinfo->cinfo, COL_INFO, "R NDPS - Error");
             if (tvb_get_ntohl(tvb, foffset-4) != 0)
             {
                 break;
index e8cd689e1292eb71e7dcf7835c48729a4aa1be27..196b3287ef1fc1e68536c1010f7101e6a276103a 100644 (file)
@@ -1149,7 +1149,7 @@ dissect_netbios(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                         break;
 
                default:
-                       col_add_fstr( pinfo->cinfo, COL_INFO, "%s",
+                       col_add_str( pinfo->cinfo, COL_INFO, 
                            command_name);
                        break;
                }
index 2d1ce2663ac3cc3fefa59dfc4c8b13dc7206c63b..4015cd435ea27fdd4f56d4e3d49416dc1e092947 100644 (file)
@@ -586,7 +586,7 @@ void dissect_nhrp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                hdr.ar_op_type = tvb_get_guint8(tvb, 17);
                
                if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+                       col_add_str(pinfo->cinfo, COL_INFO,
                                                 val_to_str(hdr.ar_op_type, nhrp_op_type_vals,
                                                                        "0x%02X - unknown"));
                }
index 565a6f85fc59b3ec40f4897e75d6a3bd759999dc..84c83bb723800b7eebf9db543e9a739eae8f220d 100644 (file)
@@ -1384,7 +1384,7 @@ dissect_ntlmssp_verf(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   guint32 verifier_length;
   guint32 encrypted_block_length;
 
-  verifier_length = tvb_length_remaining (tvb, offset);
+  verifier_length = tvb_length (tvb);
   encrypted_block_length = verifier_length - 4;
 
   if (encrypted_block_length < 12) {
index 9a495ce110d6d461dcb8aa052259d278bd400b1e..dfef66c9cc7c191593f5cf2dd1e9feebf0c448df 100644 (file)
@@ -136,7 +136,7 @@ dissect_omapi(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
     if (check_col(pinfo->cinfo, COL_INFO)) 
     {
-      col_add_fstr(pinfo->cinfo, COL_INFO, "Status message");
+      col_set_str(pinfo->cinfo, COL_INFO, "Status message");
     }
     proto_item_append_text(ti, ", Status message"); 
 
@@ -149,7 +149,7 @@ dissect_omapi(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
   if (check_col(pinfo->cinfo, COL_INFO)) 
   {
-    col_add_fstr(pinfo->cinfo, COL_INFO, 
+    col_add_str(pinfo->cinfo, COL_INFO, 
       val_to_str(tvb_get_ntohl(tvb, ptvcursor_current_offset(cursor)), omapi_opcode_vals, "Unknown opcode (0x%04x)"));
   }
   proto_item_append_text(ti, ", Opcode: %s", 
index 7c747ef57ee7172e1866ce0c8355620f01d30da1..15b7efb9b5a1dcc1c63496803d240b1b7dad54ee 100644 (file)
@@ -254,7 +254,7 @@ static void dissect_p_mul (tvbuff_t *tvb, packet_info *pinfo _U_,
   p_mul_tree = proto_item_add_subtree (ti, ett_p_mul);
 
   if (check_col (pinfo->cinfo, COL_INFO))
-    col_append_fstr (pinfo->cinfo, COL_INFO, "%s", get_type (pdu_type));
+    col_append_str (pinfo->cinfo, COL_INFO, get_type (pdu_type));
 
   /* Length of PDU */
   pdu_length = tvb_get_ntohs (tvb, offset);
@@ -469,7 +469,7 @@ static void dissect_p_mul (tvbuff_t *tvb, packet_info *pinfo _U_,
                                           &p_mul_frag_items, NULL, tree);
 
       if (check_col (pinfo->cinfo, COL_INFO) && frag_msg)
-        col_append_fstr (pinfo->cinfo, COL_INFO, " (Message Reassembled)");
+        col_append_str (pinfo->cinfo, COL_INFO, " (Message Reassembled)");
 
       if (new_tvb) {
         dissect_reassembled_data (new_tvb, pinfo, tree);
index 477e369672637dcefc3a792e8be10d4c093c667d..2be28a394d12d12df7f2bb71279a2ebd4cdc3c21 100644 (file)
@@ -376,7 +376,7 @@ dissect_pgsql(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     if (check_col(pinfo->cinfo, COL_PROTOCOL))
         col_set_str(pinfo->cinfo, COL_PROTOCOL, "PGSQL");
     if (check_col(pinfo->cinfo, COL_INFO))
-        col_add_str(pinfo->cinfo, COL_INFO,
+        col_set_str(pinfo->cinfo, COL_INFO,
                     (pinfo->match_port == pinfo->destport) ?
                      ">" : "<");
 
index f360bf8f79c492859b17feb900b62cf8a1185314..e0ea1f750eee64c058fba3df8ee4f51ab3329f25 100644 (file)
@@ -168,7 +168,7 @@ dissect_getport_reply(tvbuff_t *tvb, int offset, packet_info *pinfo _U_,
                proto_item_append_text(tree, " Port:%d", port);
        } else {
                if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_append_fstr(pinfo->cinfo, COL_INFO,  " PROGRAM_NOT_AVAILABLE");
+                       col_append_str(pinfo->cinfo, COL_INFO,  " PROGRAM_NOT_AVAILABLE");
                }
                proto_item_append_text(tree, " PROGRAM_NOT_AVAILABLE");
        }
index 8a82c5a362211d31138607a2c5037d75c4a56e2d..8fa857ff85f6286174d41632c631a7b59775f280 100644 (file)
@@ -3135,7 +3135,7 @@ dissect_iphc_crtp_fh(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     col_set_str(pinfo->cinfo,COL_PROTOCOL, "CRTP");
 
   if (check_col(pinfo->cinfo, COL_INFO))
-    col_add_str(pinfo->cinfo, COL_INFO, "Full Header");
+    col_set_str(pinfo->cinfo, COL_INFO, "Full Header");
 
   /* only dissect IPv4 and UDP */
   ip_version = tvb_get_guint8(tvb, 0) >> 4;
@@ -3223,7 +3223,7 @@ dissect_iphc_crtp_cudp16(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     col_set_str(pinfo->cinfo,COL_PROTOCOL, "CRTP");
 
   if (check_col(pinfo->cinfo, COL_INFO))
-    col_add_str(pinfo->cinfo, COL_INFO, "Compressed UDP 16");
+    col_set_str(pinfo->cinfo, COL_INFO, "Compressed UDP 16");
 
   length = tvb_reported_length(tvb);
 
@@ -3260,7 +3260,7 @@ dissect_iphc_crtp_cudp8(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     col_set_str(pinfo->cinfo,COL_PROTOCOL, "CRTP");
 
   if (check_col(pinfo->cinfo, COL_INFO))
-    col_add_str(pinfo->cinfo, COL_INFO, "Compressed UDP 8");
+    col_set_str(pinfo->cinfo, COL_INFO, "Compressed UDP 8");
 
   length = tvb_reported_length(tvb);
 
@@ -3298,7 +3298,7 @@ dissect_iphc_crtp_cs(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     col_set_str(pinfo->cinfo,COL_PROTOCOL, "CRTP");
 
   if (check_col(pinfo->cinfo, COL_INFO))
-    col_add_str(pinfo->cinfo, COL_INFO, "Context State");
+    col_set_str(pinfo->cinfo, COL_INFO, "Context State");
 
   if (tree) {
     
@@ -3608,7 +3608,7 @@ dissect_ppp_raw_hdlc( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree )
           * packet and continued in a later packet.
           */
          if (check_col(pinfo->cinfo, COL_INFO)){
-                 col_add_str(pinfo->cinfo, COL_INFO,"PPP Fragment");
+                 col_set_str(pinfo->cinfo, COL_INFO,"PPP Fragment");
          }
          if (tree)
                  proto_tree_add_text(bs_tree, tvb, offset, -1, "PPP Fragment");
@@ -3627,7 +3627,7 @@ dissect_ppp_raw_hdlc( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree )
           * mark it as a PPP fragment.
           */
          if(check_col(pinfo->cinfo, COL_INFO)){
-                 col_add_str(pinfo->cinfo, COL_INFO,"PPP Fragment");
+                 col_set_str(pinfo->cinfo, COL_INFO,"PPP Fragment");
          }
          length = offset;
          if (tree)
@@ -3652,7 +3652,7 @@ dissect_ppp_raw_hdlc( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree )
                   */
                  if (first) {
                          if(check_col(pinfo->cinfo, COL_INFO)){
-                                 col_add_str(pinfo->cinfo, COL_INFO,"PPP Fragment");
+                                 col_set_str(pinfo->cinfo, COL_INFO,"PPP Fragment");
                          }
                  }
                  if (tree)
index 4cd245f93c367ba8844069b3fbd27127899d05c6..0ddc43bb43d2802395f48f8d4dada9ed739bb866 100644 (file)
@@ -256,7 +256,7 @@ static void dissect_pppoed(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        if (check_col(pinfo->cinfo,COL_INFO))
        {
-               col_add_fstr(pinfo->cinfo,COL_INFO, val_to_str(pppoe_code, code_vals, "Unknown"));
+               col_add_str(pinfo->cinfo,COL_INFO, val_to_str(pppoe_code, code_vals, "Unknown"));
        }
 
        /* Read length of payload */
@@ -444,7 +444,7 @@ static void dissect_pppoes(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        if (check_col(pinfo->cinfo,COL_INFO))
        {
-               col_add_fstr(pinfo->cinfo, COL_INFO,
+               col_add_str(pinfo->cinfo, COL_INFO,
                             val_to_str(pppoe_code, code_vals, "Unknown"));
        }
 
index 4af93ea5c7ae682812c0da1b6cee156a883e1369..841eab9a71aab4a783ac520e0fa9e6ce8fda425b 100644 (file)
@@ -244,7 +244,7 @@ dissect_pptp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   cntrl_type = tvb_get_ntohs(tvb, offset + 8);
 
   if (check_col(pinfo->cinfo, COL_INFO))
-    col_add_fstr(pinfo->cinfo, COL_INFO, "%s", cntrltype2str(cntrl_type));
+    col_add_str(pinfo->cinfo, COL_INFO, cntrltype2str(cntrl_type));
 
   if (tree) {
     guint32            cookie;
index 9557cb15783d0b84a6bba01a2c1e83577e247779..b3127853fd54baea1bd17d3ee991d87e6e4d7312 100644 (file)
@@ -1112,7 +1112,7 @@ dissect_ptp_v1(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                }
                default:{
                        if (check_col(pinfo->cinfo, COL_INFO))
-                               col_add_str(pinfo->cinfo, COL_INFO, "Unknown Message");
+                               col_set_str(pinfo->cinfo, COL_INFO, "Unknown Message");
                        break;
                }
        }
index 6cb9b48be3c53ed21e50a4b94493c14b20f45bfa..23478d160077617b9da01061efe1ee53b7e4a2ad 100644 (file)
@@ -267,7 +267,7 @@ dissect_pvfs_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        guint64 size;
 
        /* verify that this is indeed PVFS and that it looks sane */
-       if(tvb_length_remaining(tvb,0)<24){
+       if(tvb_length(tvb)<24){
                /* too few bytes remaining to verify the header */
                return 0;
        }
@@ -3205,7 +3205,7 @@ dissect_pvfs_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree,
                col_set_str(pinfo->cinfo, COL_INFO, 
                                val_to_str(server_op, names_pvfs_server_op, "%u (unknown)"));
 
-               col_append_fstr(pinfo->cinfo, COL_INFO, 
+               col_append_str(pinfo->cinfo, COL_INFO, 
                                (mode == TCP_MODE_UNEXP)? " (request)": " (response)");
        }
 
index a8b48cf2afabcae488e5e29901830eaf8596a3ba..916c5a1cd04ae5e4c39b7d830f11a89b4b1b943f 100644 (file)
@@ -86,7 +86,7 @@ dissect_rgmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree, int off
 
     type = tvb_get_guint8(tvb, offset);
     if (check_col(pinfo->cinfo, COL_INFO)) {
-       col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+       col_add_str(pinfo->cinfo, COL_INFO, 
                     val_to_str(type, rgmp_types, "Unknown Type: 0x%02x"));
     }
     proto_tree_add_uint(tree, hf_type, tvb, offset, 1, type);
index 1dadd6510be2a44c807922a78df2e1ca2d03a991..5ca84f724511b879f0bb45146ef9ab40b144c0cd 100644 (file)
@@ -153,7 +153,7 @@ dissect_rmi(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
            break;
        case RMI_OUTPUTMESSAGE:
            message = tvb_get_guint8(tvb,0);
-           col_add_str(pinfo->cinfo, COL_INFO,
+           col_set_str(pinfo->cinfo, COL_INFO,
                        "JRMI, ");
            col_append_str(pinfo->cinfo, COL_INFO,
                           val_to_str(message, rmi_output_message_str,
@@ -161,7 +161,7 @@ dissect_rmi(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
            break;
        case RMI_INPUTSTREAM:
            message = tvb_get_guint8(tvb,0);
-           col_add_str(pinfo->cinfo, COL_INFO,
+           col_set_str(pinfo->cinfo, COL_INFO,
                        "JRMI, ");
            col_append_str(pinfo->cinfo, COL_INFO,
                           val_to_str(message, rmi_input_message_str,
index f0c570b3fd56dbb904f075a793b364c654096279..0f68c400060066a44cfe70acb08958e1a543af9e 100644 (file)
@@ -662,7 +662,7 @@ dissect_norm_heur(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        if (hi_nibble(byte1) != 1) return FALSE;
        if (lo_nibble(byte1) < 1 || lo_nibble(byte1) > 6) return FALSE;
        if (tvb_get_guint8(tvb, 1) > 20) return FALSE;
-       if (tvb_length_remaining(tvb, 0) < 12)
+       if (tvb_length(tvb) < 12)
                return FALSE;
        dissect_norm(tvb, pinfo, tree);
        return TRUE; /* appears to be a NORM packet */
index 3350f5d90746f810a13e7546fd033a9eb4de64a2..68d90ab110ab42aa108237969ace3cb69bee9f04 100644 (file)
@@ -2081,7 +2081,7 @@ dissect_rpc_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                        if (first_pdu)
                                col_clear(pinfo->cinfo, COL_INFO);
                        else
-                               col_append_fstr(pinfo->cinfo, COL_INFO, "  ; ");
+                               col_append_str(pinfo->cinfo, COL_INFO, "  ; ");
                        col_append_fstr(pinfo->cinfo, COL_INFO,"V%u %s %s",
                                vers,
                                procname,
@@ -2289,7 +2289,7 @@ dissect_rpc_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                        if (first_pdu)
                                col_clear(pinfo->cinfo, COL_INFO);
                        else
-                               col_append_fstr(pinfo->cinfo, COL_INFO, "  ; ");
+                               col_append_str(pinfo->cinfo, COL_INFO, "  ; ");
                        col_append_fstr(pinfo->cinfo, COL_INFO,"V%u %s %s",
                                vers,
                                procname,
index eedd364a93ea7206c78d88a89e91d1cd844fbeee..3c05eacad010aac7ec3a6fa9d9a6fa31f3582d5f 100644 (file)
@@ -5327,7 +5327,7 @@ dissect_rsvp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        col_add_str(pinfo->cinfo, COL_INFO,
                    val_to_str(message_type, message_type_vals, "Unknown (%u). "));
        if (message_type == RSVP_MSG_BUNDLE) {
-           col_add_str(pinfo->cinfo, COL_INFO,
+           col_set_str(pinfo->cinfo, COL_INFO,
                        rsvp_bundle_dissect ?
                        "Component Messages Dissected" :
                        "Component Messages Not Dissected");
index 41c49b91d0e114be368395781d078415811850b1..29c146e12a1af73d1cc1b7334b23f854c9d4b616 100644 (file)
@@ -191,7 +191,7 @@ dissect_rsync_encap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
        proto_tree_add_item(rsync_tree, hf_rsync_motd_string, tvb, offset, -1, TRUE);
 
         if (check_col(pinfo->cinfo, COL_INFO)) {
-         col_append_fstr(pinfo->cinfo, COL_INFO, "Server MOTD");
+         col_append_str(pinfo->cinfo, COL_INFO, "Server MOTD");
        }
 
        conversation_data->state = RSYNC_SERV_RESPONSE;
@@ -216,7 +216,7 @@ dissect_rsync_encap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
          proto_tree_add_item(rsync_tree, hf_rsync_response_string, tvb, offset, -1, TRUE);
 
          if (check_col(pinfo->cinfo, COL_INFO)) {
-           col_append_fstr(pinfo->cinfo, COL_INFO, "Module list");
+           col_append_str(pinfo->cinfo, COL_INFO, "Module list");
          }
 
          /* we need to check the end of the buffer for magic string */
index 3e41b0265852787746d80cf0ef631aef3d00743f..ad5790e7ed08920cd2d2ae72e4dc6325c196c8b1 100644 (file)
@@ -480,7 +480,7 @@ dissect_rtps(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        g_snprintf(buff+buff_len, 200-buff_len, "vendor specific(%d) ",count_msg_type[10]);
    }
 
-   col_add_fstr(pinfo->cinfo, COL_INFO, buff);
+   col_add_str(pinfo->cinfo, COL_INFO, buff);
 
   }
 
index 29085f55cd56e478326e77297bbe99dc66917a7f..3ba3631080fbb7022ea58864b08f0e2bee5144f8 100644 (file)
@@ -655,7 +655,7 @@ dissect_rtspmessage(tvbuff_t *tvb, int offset, packet_info *pinfo,
                line = tvb_get_ptr(tvb, offset, first_linelen);
                if (is_request_or_reply)
                        if ( rtsp_type == RTSP_REPLY ) {
-                               col_add_str(pinfo->cinfo, COL_INFO, "Reply: ");
+                               col_set_str(pinfo->cinfo, COL_INFO, "Reply: ");
                                col_append_str(pinfo->cinfo, COL_INFO,
                                        format_text(line, first_linelen));
                        }
index be3acea50f4081a91d186fbde454ff0c042a6775..186319d7e7df88bc56fa2125a12324ede42c9f62 100644 (file)
@@ -2635,7 +2635,7 @@ dissect_osd_opcode(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
 
 
                if(check_col(pinfo->cinfo, COL_INFO)){
-                       col_append_fstr(pinfo->cinfo, COL_INFO, "%s",
+                       col_append_str(pinfo->cinfo, COL_INFO, 
                                val_to_str(svcaction, scsi_osd_svcaction_vals, "Unknown OSD Serviceaction"));
                }
                dissector=find_svcaction_dissector(svcaction);
@@ -2653,7 +2653,7 @@ dissect_osd_opcode(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                svcaction=extra_data->svcaction;
        }
        if(check_col(pinfo->cinfo, COL_INFO)){
-               col_append_fstr(pinfo->cinfo, COL_INFO, "%s",
+               col_append_str(pinfo->cinfo, COL_INFO, 
                        val_to_str(svcaction, scsi_osd_svcaction_vals, "Unknown OSD Serviceaction"));
        }
        if(svcaction){
index 5b8b5155618b922e42596e8762b8ab674dc067c5..2a120877d9d7078ce0abf451357211509e0be292 100644 (file)
@@ -668,7 +668,7 @@ dissect_sigcomp_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *sigcomp_tr
                 * Message format 1
                 */
                if (check_col(pinfo->cinfo, COL_INFO))
-                       col_add_fstr(pinfo->cinfo, COL_INFO, "Msg format 1");
+                       col_set_str(pinfo->cinfo, COL_INFO, "Msg format 1");
 
                if ( tbit == 1 ) {
                        /*
@@ -816,7 +816,7 @@ dissect_sigcomp_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *sigcomp_tr
                 * Message format 2
                 */
        if (check_col(pinfo->cinfo, COL_INFO))
-               col_add_fstr(pinfo->cinfo, COL_INFO, "Msg format 2");
+               col_set_str(pinfo->cinfo, COL_INFO, "Msg format 2");
                if ( tbit == 1 ) {
                        /*
                         * Returned feedback item exists
index 149399172105be537317156c449702b3139c292c..a31a58e1d91bc37e831cc10ca01e1c311efe30cb 100644 (file)
@@ -257,7 +257,7 @@ dissect_slimp3(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
     if (check_col(pinfo->cinfo, COL_INFO)) {
 
-       col_add_fstr(pinfo->cinfo, COL_INFO, "%s", opcode_str);
+       col_add_str(pinfo->cinfo, COL_INFO, opcode_str);
 
     }
 
@@ -512,9 +512,9 @@ dissect_slimp3(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        if (check_col(pinfo->cinfo, COL_INFO)) {
            if (to_server) {
-               col_append_fstr(pinfo->cinfo, COL_INFO, ", Response");
+               col_append_str(pinfo->cinfo, COL_INFO, ", Response");
            } else {
-               col_append_fstr(pinfo->cinfo, COL_INFO, ", Request");
+               col_append_str(pinfo->cinfo, COL_INFO, ", Request");
            }
        }
        break;
index ef8c05780fd77e69c491386dea12be53c2f5d2e3..34671f9e308ff8a78c1de8ff3c36dc0c94d3e055 100644 (file)
@@ -6955,10 +6955,10 @@ dissect_session_setup_andx_request(tvbuff_t *tvb, packet_info *pinfo, proto_tree
                COUNT_BYTES(dn_len);
 
                if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_append_fstr(pinfo->cinfo, COL_INFO, ", User: ");
+                       col_append_str(pinfo->cinfo, COL_INFO, ", User: ");
 
                        if (!dn[0] && !an[0])
-                               col_append_fstr(pinfo->cinfo, COL_INFO,
+                               col_append_str(pinfo->cinfo, COL_INFO,
                                                "anonymous");
                        else
                                col_append_fstr(pinfo->cinfo, COL_INFO,
@@ -8590,7 +8590,7 @@ dissect_nt_transaction_request(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree
        } else {
                /* secondary request */
                if(check_col(pinfo->cinfo, COL_INFO)){
-                       col_append_fstr(pinfo->cinfo, COL_INFO, " (secondary request)");
+                       col_append_str(pinfo->cinfo, COL_INFO, " (secondary request)");
                }
        }
        offset += 2;
@@ -9051,7 +9051,7 @@ dissect_nt_transaction_response(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tre
                proto_tree_add_text(tree, tvb, offset, 0,
                        "Function: <unknown function - could not find matching request>");
                if(check_col(pinfo->cinfo, COL_INFO)){
-                       col_append_fstr(pinfo->cinfo, COL_INFO, ", <unknown>");
+                       col_append_str(pinfo->cinfo, COL_INFO, ", <unknown>");
                }
        }
 
@@ -14277,7 +14277,7 @@ dissect_transaction2_response_data(tvbuff_t *tvb, packet_info *pinfo,
             break;
         }
                if (count && check_col(pinfo->cinfo, COL_INFO)) {
-                       col_append_fstr(pinfo->cinfo, COL_INFO,
+                       col_append_str(pinfo->cinfo, COL_INFO,
                        ", Files:");
                }
 
@@ -14296,7 +14296,7 @@ dissect_transaction2_response_data(tvbuff_t *tvb, packet_info *pinfo,
             break;
         }
                if (count && check_col(pinfo->cinfo, COL_INFO)) {
-                       col_append_fstr(pinfo->cinfo, COL_INFO,
+                       col_append_str(pinfo->cinfo, COL_INFO,
                        ", Files:");
                }
 
@@ -14695,7 +14695,7 @@ dissect_transaction_response(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *
                        proto_tree_add_text(tree, tvb, 0, 0,
                                "Subcommand: <UNKNOWN> since request packet wasn't seen");
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_append_fstr(pinfo->cinfo, COL_INFO, "<unknown>");
+                               col_append_str(pinfo->cinfo, COL_INFO, "<unknown>");
                        }
                } else {
                        si->info_level = t2i->info_level;
@@ -14709,7 +14709,7 @@ dissect_transaction_response(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *
                                proto_tree_add_text(tree, tvb, 0, 0,
                                        "Subcommand: <UNKNOWN> since transaction code wasn't found in request packet");
                                if (check_col(pinfo->cinfo, COL_INFO)) {
-                                       col_append_fstr(pinfo->cinfo, COL_INFO, "<unknown>");
+                                       col_append_str(pinfo->cinfo, COL_INFO, "<unknown>");
                                }
                        } else {
                                proto_tree_add_uint(tree, hf_smb_trans2_subcmd, tvb, 0, 0, t2i->subcmd);
index 0f911e417f5f5da2f66b974e753a1700f915a982..e65fdb6aa4424fb6895ab613ca92898c09f947ca 100644 (file)
@@ -546,7 +546,7 @@ dissect_smb2_olb_string(packet_info *pinfo, proto_tree *parent_tree, tvbuff_t *t
                                    "Invalid offset/length. Malformed packet");
 
                if (check_col(pinfo->cinfo, COL_INFO)){
-                       col_append_fstr(pinfo->cinfo, COL_INFO, " [Malformed packet]");
+                       col_append_str(pinfo->cinfo, COL_INFO, " [Malformed packet]");
                }
 
                return NULL;
@@ -625,7 +625,7 @@ dissect_smb2_olb_buffer(packet_info *pinfo, proto_tree *parent_tree, tvbuff_t *t
                                    "Invalid offset/length. Malformed packet");
 
                if (check_col(pinfo->cinfo, COL_INFO)){
-                       col_append_fstr(pinfo->cinfo, COL_INFO, " [Malformed packet]");
+                       col_append_str(pinfo->cinfo, COL_INFO, " [Malformed packet]");
                }
 
                return;
@@ -3280,7 +3280,7 @@ dissect_smb2_MxAc_buffer(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree
                item = proto_tree_get_parent(tree);
        }
 
-       if (tvb_length_remaining(tvb, offset) == 0) {
+       if (tvb_length(tvb) == 0) {
                if (item) {
                        proto_item_append_text(item, ": NO DATA");
                }
index 2de26ca2bee42fdc033be2004e96c6012a680e8f..e6d3cd7f4061751fd9cfe5a52c9d04407702e81c 100644 (file)
@@ -528,7 +528,7 @@ dissect_smtp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
            frag_msg = fragment_add_seq_next (tvb, 0, pinfo, frame_data->conversation_id, 
                                              smtp_data_segment_table, smtp_data_reassembled_table, 
-                                             tvb_length_remaining(tvb,0), frame_data->more_frags);
+                                             tvb_length(tvb), frame_data->more_frags);
          } else {
            
            /*
index 8835870694abba1ccf27c1d3200ccdb0c781bbfb..a76881572d6c6bde02e7c0f422ada1fbc179eb48 100644 (file)
@@ -899,11 +899,11 @@ dissect_optional_0e(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        }
        if (bits & 0x40) {
                if (check_col(pinfo->cinfo, COL_INFO))
-                       col_add_str(pinfo->cinfo, COL_INFO,
+                       col_set_str(pinfo->cinfo, COL_INFO,
                            "HPR Idle Message");
        } else {
                if (check_col(pinfo->cinfo, COL_INFO))
-                       col_add_str(pinfo->cinfo, COL_INFO,
+                       col_set_str(pinfo->cinfo, COL_INFO,
                            "HPR Status Message");
        }
 }
@@ -1217,7 +1217,7 @@ dissect_nlp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
        nhdr_1 = tvb_get_guint8(tvb, index+1);
 
        if (check_col(pinfo->cinfo, COL_INFO))
-               col_add_str(pinfo->cinfo, COL_INFO, "HPR NLP Packet");
+               col_set_str(pinfo->cinfo, COL_INFO, "HPR NLP Packet");
 
        if (tree) {
                /* Don't bother setting length. We'll set it later after we
@@ -1372,7 +1372,7 @@ dissect_nlp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
        index += (thdr_len << 2);
        if (((thdr_8 & 0x20) == 0) && thdr_dlf) {
                if (check_col(pinfo->cinfo, COL_INFO))
-                       col_add_str(pinfo->cinfo, COL_INFO, "HPR Fragment");
+                       col_set_str(pinfo->cinfo, COL_INFO, "HPR Fragment");
                if (tvb_offset_exists(tvb, index)) {
                        call_dissector(data_handle,
                            tvb_new_subset(tvb, index, -1, -1), pinfo,
@@ -1390,7 +1390,7 @@ dissect_nlp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                        if (tvb_get_ntohs(tvb, index+2) == 0x12ce) {
                                /* Route Setup */
                                if (check_col(pinfo->cinfo, COL_INFO))
-                                       col_add_str(pinfo->cinfo, COL_INFO,
+                                       col_set_str(pinfo->cinfo, COL_INFO,
                                            "HPR Route Setup");
                                dissect_gds(tvb_new_subset(tvb, index, -1, -1),
                                    pinfo, tree, parent_tree);
index c2bb11c0c3263e02ee4a2c878f7c048e8d09b5f0..d631f58e3ed601081ae099b1eea57af6b2adb242 100644 (file)
@@ -497,7 +497,7 @@ static gboolean ParseCommand(proto_tree *tree,tvbuff_t *tvb, int offset, packet_
     if (check_col(pinfo->cinfo, COL_INFO))
         col_clear(pinfo->cinfo, COL_INFO);
            if (check_col(pinfo->cinfo, COL_INFO))
-                  col_add_fstr(pinfo->cinfo, COL_INFO, "%s",m_pCurQuery );
+                  col_add_str(pinfo->cinfo, COL_INFO, m_pCurQuery );
                return TRUE;
        }
        return FALSE;
@@ -544,7 +544,7 @@ static gboolean ParseNewCommand( proto_tree *tree,tvbuff_t *tvb, int offset, pac
     if (check_col(pinfo->cinfo, COL_INFO))
         col_clear(pinfo->cinfo, COL_INFO);
            if (check_col(pinfo->cinfo, COL_INFO))
-                  col_add_fstr(pinfo->cinfo, COL_INFO, "%s",m_pCurQuery );
+                  col_add_str(pinfo->cinfo, COL_INFO, m_pCurQuery );
                proto_tree_add_text(tree, tvb, offset+amount-sqlamount, sqlamount,
                            "SQL statement = %s",m_pCurQuery);
                return TRUE;
@@ -633,7 +633,7 @@ dissect_sqloracle(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                                                if (ParseCommand(sqloracle_tree,tvb, offset + 0x14, pinfo,dataLen - 0x14) == TRUE)
                                                {
                                                        if (check_col(pinfo->cinfo, COL_INFO))
-                                                               col_add_fstr(pinfo->cinfo, COL_INFO, "%s",m_pCurQuery );
+                                                               col_add_str(pinfo->cinfo, COL_INFO, m_pCurQuery );
                                                        break;
                                                }
                                                else
index 8e3ceb8348ba1ad85bcaf6624eedd16ab556d1ab..7322e94c6e95bffb125afc38a0cf91848e7d2ce1 100644 (file)
@@ -450,7 +450,7 @@ ssh_dissect_ssh1(tvbuff_t *tvb, packet_info *pinfo,
                                msg_code);
                }
                if (check_col(pinfo->cinfo, COL_INFO)) {
-                       col_append_fstr(pinfo->cinfo, COL_INFO, "%s",
+                       col_append_str(pinfo->cinfo, COL_INFO, 
                        val_to_str(msg_code, ssh1_msg_vals, "Unknown (%u)"));
                }
                offset += 1;
@@ -554,7 +554,7 @@ ssh_dissect_key_exchange(tvbuff_t *tvb, packet_info *pinfo,
 
        }
        if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_append_fstr(pinfo->cinfo, COL_INFO, "%s",
+               col_append_str(pinfo->cinfo, COL_INFO, 
                        val_to_str(msg_code, ssh2_msg_vals, "Unknown (%u)"));
        }
        offset += 1;
index c4b60da5cb6218a06cecf2b929809714bd72437f..780af152cca0c4448dc10f7dc7d00af2b87674d0 100644 (file)
@@ -1713,14 +1713,14 @@ dissect_ssl3_handshake(tvbuff_t *tvb, packet_info *pinfo,
         if (!first_iteration)
         {
             if (check_col(pinfo->cinfo, COL_INFO))
-                col_append_fstr(pinfo->cinfo, COL_INFO, ", ");
+                col_append_str(pinfo->cinfo, COL_INFO, ", ");
         }
 
         /*
          * Update our info string
          */
         if (check_col(pinfo->cinfo, COL_INFO))
-            col_append_fstr(pinfo->cinfo, COL_INFO, "%s", (msg_type_str != NULL)
+            col_append_str(pinfo->cinfo, COL_INFO, (msg_type_str != NULL)
                             ? msg_type_str : "Encrypted Handshake Message");
 
         if (tree)
index e445940e127ca082ee52efcf92100a6a868acea2..b710a5b4ab6d96bb489822e9ce375aba4836415d 100755 (executable)
@@ -516,7 +516,7 @@ dissect_starteam(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                                iCommand = tvb_get_letohl(tvb, offset + 62);
                        }
                        if(check_col(pinfo->cinfo, COL_INFO)){
-                               col_append_fstr(pinfo->cinfo, COL_INFO, "%s", val_to_str(iCommand, starteam_opcode_vals, "Unknown (0x%02x)"));
+                               col_append_str(pinfo->cinfo, COL_INFO, val_to_str(iCommand, starteam_opcode_vals, "Unknown (0x%02x)"));
                        }
                }
 
index c2bf929d5a7f023627ea95a20745f841f02d5ff3..d247be63ef5fbbe33ef004b2680703e292bb1737 100644 (file)
@@ -79,11 +79,11 @@ dissect_symantec(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                return;
                
        if (check_col(pinfo->cinfo, COL_PROTOCOL))
-               col_add_str(pinfo->cinfo, COL_PROTOCOL, "Symantec");
+               col_set_str(pinfo->cinfo, COL_PROTOCOL, "Symantec");
                
        if (etypev3 == 0) {     /* SEF and SGS v2 processing */
                if (check_col(pinfo->cinfo, COL_INFO))
-                       col_add_str(pinfo->cinfo, COL_INFO, "Symantec Enterprise Firewall");
+                       col_set_str(pinfo->cinfo, COL_INFO, "Symantec Enterprise Firewall");
                if (tree) {
                        ti = proto_tree_add_protocol_format(tree, proto_symantec, tvb,
                                0, 44, "Symantec firewall");
@@ -102,7 +102,7 @@ dissect_symantec(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        if (etypev2 == 0) {     /* SGS v3 processing */
                if (check_col(pinfo->cinfo, COL_INFO))
-                       col_add_str(pinfo->cinfo, COL_INFO, "Symantec SGS v3");
+                       col_set_str(pinfo->cinfo, COL_INFO, "Symantec SGS v3");
                if (tree) {
                        ti = proto_tree_add_protocol_format(tree, proto_symantec, tvb,
                                0, 56, "Symantec SGSv3");
index 9b30e98417f17c922601dcaed61e35a5aa29ad1c..6c99c36f03e7055e3cc337c419373d811d9c7d3e 100644 (file)
@@ -2842,7 +2842,7 @@ dissect_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
         expert_add_info_format(pinfo, item, PI_CHECKSUM, PI_WARN, "TCP Checksum 0xffff instead of 0x0000 (see RFC 1624)");
 
         if (check_col(pinfo->cinfo, COL_INFO))
-          col_append_fstr(pinfo->cinfo, COL_INFO, " [TCP CHECKSUM 0xFFFF]");
+          col_append_str(pinfo->cinfo, COL_INFO, " [TCP CHECKSUM 0xFFFF]");
 
         /* Checksum is treated as valid on most systems, so we're willing to desegment it. */
         desegment_ok = TRUE;
@@ -2891,7 +2891,7 @@ dissect_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
         expert_add_info_format(pinfo, item, PI_CHECKSUM, PI_ERROR, "Bad checksum");
 
         if (check_col(pinfo->cinfo, COL_INFO))
-          col_append_fstr(pinfo->cinfo, COL_INFO, " [TCP CHECKSUM INCORRECT]");
+          col_append_str(pinfo->cinfo, COL_INFO, " [TCP CHECKSUM INCORRECT]");
 
         /* Checksum is invalid, so we're not willing to desegment it. */
         desegment_ok = FALSE;
index 4a67f6fd7314eee4fe9d1616fc0d8c711d49e21a..994d3d93c9a08babf05efae38c51535b87c9c5d9 100644 (file)
@@ -1605,7 +1605,7 @@ dissect_telnet(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                col_set_str(pinfo->cinfo, COL_PROTOCOL, "TELNET");
 
        if (check_col(pinfo->cinfo, COL_INFO))
-               col_add_fstr(pinfo->cinfo, COL_INFO, "Telnet Data ...");
+               col_set_str(pinfo->cinfo, COL_INFO, "Telnet Data ...");
 
        if (tree) {
          gint offset = 0;
index 779e6b03b1eee3e5e5b12f528b3e2f3c4e969519..29ec49183f5bee6b4284815ba380713238773dea 100644 (file)
@@ -216,7 +216,7 @@ dissect_tftp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        if (check_col(pinfo->cinfo, COL_INFO)) {
 
-         col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+         col_add_str(pinfo->cinfo, COL_INFO, 
            val_to_str(opcode, tftp_opcode_vals, "Unknown (0x%04x)"));
 
        }
index 538355de5bb0d1fa1b0d2e9f9d2d782f31d4c433..5bfb3cf04ffedf530dd9c4c3f98ec842a4531446 100644 (file)
@@ -298,11 +298,11 @@ static void dissect_tns_data(tvbuff_t *tvb, int offset, packet_info *pinfo,
        {
                if ( is_sns )
                {
-                       col_append_fstr(pinfo->cinfo, COL_INFO, ", SNS");
+                       col_append_str(pinfo->cinfo, COL_INFO, ", SNS");
                }
                else
                {
-                       col_append_fstr(pinfo->cinfo, COL_INFO, ", Data");
+                       col_append_str(pinfo->cinfo, COL_INFO, ", Data");
                }
        }
 
@@ -894,7 +894,7 @@ dissect_tns_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        if (check_col(pinfo->cinfo, COL_INFO))
        {
-               col_add_str(pinfo->cinfo, COL_INFO,
+               col_set_str(pinfo->cinfo, COL_INFO,
                        (pinfo->match_port == pinfo->destport) ? "Request" : "Response");
        }
 
index d0268a9f0cc69aa261aebe52fedcedd8051c0c28..92572a0fca4b8295d23080f3879ee7be9703af9c 100644 (file)
@@ -119,7 +119,7 @@ dissect_tuxedo(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
                        if (check_col(pinfo->cinfo, COL_INFO)) 
                        {                                       
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "%s", val_to_str(opcode, tuxedo_opcode_vals, "Unknown (0x%02x)"));         
+                               col_add_str(pinfo->cinfo, COL_INFO, val_to_str(opcode, tuxedo_opcode_vals, "Unknown (0x%02x)"));                
                        }
 
                        if (tree)
index 4fc7c8f77c0ab59427d22c79f3d033a30649f2af..4d749aff6ab76247d7e4a220d40a2d20ef75a314 100644 (file)
@@ -942,7 +942,7 @@ dissect_linux_usb(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent)
     type = pinfo->pseudo_header->linux_usb.transfer_type;
     proto_tree_add_uint(tree, hf_usb_transfer_type, tvb, 0, 0, type);
     if (check_col(pinfo->cinfo, COL_INFO)) {
-        col_append_fstr(pinfo->cinfo, COL_INFO, "%s",
+        col_append_str(pinfo->cinfo, COL_INFO, 
             val_to_str(type, usb_transfer_type_vals, "Unknown type %x"));
     }
 
index 67a200acf54e29f1adfdc5d365e23794d3a1102d..648fe589b6e33486b448e7563f649848788cde28 100644 (file)
@@ -579,7 +579,7 @@ dissect_winsrepl_replication(tvbuff_t *winsrepl_tvb, packet_info *pinfo,
        switch (command) {
                case WREPL_REPL_TABLE_QUERY:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_REPL_TABLE_QUERY");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_REPL_TABLE_QUERY");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_REPL_TABLE_QUERY");
                        proto_item_append_text(repl_item, ", WREPL_REPL_TABLE_QUERY");
@@ -588,7 +588,7 @@ dissect_winsrepl_replication(tvbuff_t *winsrepl_tvb, packet_info *pinfo,
                        break;
                case WREPL_REPL_TABLE_REPLY:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_REPL_TABLE_REPLY");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_REPL_TABLE_REPLY");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_REPL_TABLE_REPLY");
                        proto_item_append_text(repl_item, ", WREPL_REPL_TABLE_REPLY");
@@ -597,7 +597,7 @@ dissect_winsrepl_replication(tvbuff_t *winsrepl_tvb, packet_info *pinfo,
                        break;
                case WREPL_REPL_SEND_REQUEST:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_REPL_SEND_REQUEST");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_REPL_SEND_REQUEST");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_REPL_SEND_REQUEST");
                        proto_item_append_text(repl_item, ", WREPL_REPL_SEND_REQUEST");
@@ -606,7 +606,7 @@ dissect_winsrepl_replication(tvbuff_t *winsrepl_tvb, packet_info *pinfo,
                        break;
                case WREPL_REPL_SEND_REPLY:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_REPL_SEND_REPLY");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_REPL_SEND_REPLY");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_REPL_SEND_REPLY");
                        proto_item_append_text(repl_item, ", WREPL_REPL_SEND_REPLY");
@@ -615,7 +615,7 @@ dissect_winsrepl_replication(tvbuff_t *winsrepl_tvb, packet_info *pinfo,
                        break;
                case WREPL_REPL_UPDATE:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_REPL_UPDATE");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_REPL_UPDATE");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_REPL_UPDATE");
                        proto_item_append_text(repl_item, ", WREPL_REPL_UPDATE");
@@ -624,7 +624,7 @@ dissect_winsrepl_replication(tvbuff_t *winsrepl_tvb, packet_info *pinfo,
                        break;
                case WREPL_REPL_UPDATE2:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_REPL_UPDATE2");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_REPL_UPDATE2");
                        }
                        proto_item_append_text(winsrepl_item, ",WREPL_REPL_UPDATE2");
                        proto_item_append_text(repl_item, ",WREPL_REPL_UPDATE2");
@@ -633,7 +633,7 @@ dissect_winsrepl_replication(tvbuff_t *winsrepl_tvb, packet_info *pinfo,
                        break;
                case WREPL_REPL_INFORM:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_REPL_INFORM");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_REPL_INFORM");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_REPL_INFORM");
                        proto_item_append_text(repl_item, ", WREPL_REPL_INFORM");
@@ -642,7 +642,7 @@ dissect_winsrepl_replication(tvbuff_t *winsrepl_tvb, packet_info *pinfo,
                        break;
                case WREPL_REPL_INFORM2:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_REPL_INFORM2");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_REPL_INFORM2");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_REPL_INFORM2");
                        proto_item_append_text(repl_item, ", WREPL_REPL_INFORM2");
@@ -694,7 +694,7 @@ dissect_winsrepl_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
        switch (mess_type) {
                case WREPL_START_ASSOCIATION:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_START_ASSOCIATION");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_START_ASSOCIATION");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_START_ASSOCIATION");
                        offset = dissect_winsrepl_start(tvb, pinfo,
@@ -702,7 +702,7 @@ dissect_winsrepl_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
                        break;
                case WREPL_START_ASSOCIATION_REPLY:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_START_ASSOCIATION_REPLY");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_START_ASSOCIATION_REPLY");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_START_ASSOCIATION_REPLY");
                        offset = dissect_winsrepl_start(tvb, pinfo,
@@ -710,7 +710,7 @@ dissect_winsrepl_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree)
                        break;
                case WREPL_STOP_ASSOCIATION:
                        if (check_col(pinfo->cinfo, COL_INFO)) {
-                               col_add_fstr(pinfo->cinfo, COL_INFO, "WREPL_STOP_ASSOCIATION");
+                               col_set_str(pinfo->cinfo, COL_INFO, "WREPL_STOP_ASSOCIATION");
                        }
                        proto_item_append_text(winsrepl_item, ", WREPL_STOP_ASSOCIATION");
                        offset = dissect_winsrepl_stop(tvb, pinfo,
index 6f3758ec9cfc4e976a472d2fa6543f1b3ca7f1c7..e5a6f410c0e833bd4a65503a94d93a680fcb65ef 100644 (file)
@@ -4874,7 +4874,7 @@ dissect_sir(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
        if (check_col(pinfo->cinfo, COL_INFO))
        { /* Append status code to INFO column */
-               col_append_fstr(pinfo->cinfo, COL_INFO,
+               col_append_str(pinfo->cinfo, COL_INFO,
                                ": WAP Session Initiation Request");
        }
 
index 590c4b8029470bd5f49cf2e8ff7761f6e247cebd..d6393104873e8475d150717dd9b9ade00f9b3014 100644 (file)
@@ -1219,7 +1219,7 @@ static const value_string zero_is_none_vals[] = {
                                                                        \
        if (sep == NULL) {                                              \
           if (check_col(pinfo->cinfo, COL_INFO))                       \
-                  col_add_str(pinfo->cinfo, COL_INFO, str);            \
+                  col_set_str(pinfo->cinfo, COL_INFO, str);            \
           sep = ":";                                                   \
        }                                                               \
                                                                        \
@@ -4289,7 +4289,7 @@ static void dissect_x11_requests(tvbuff_t *tvb, packet_info *pinfo,
                         * We haven't set the column yet; set it.
                         */
                        if (check_col(pinfo->cinfo, COL_INFO))
-                             col_add_str(pinfo->cinfo, COL_INFO, "Requests");
+                             col_set_str(pinfo->cinfo, COL_INFO, "Requests");
 
                        /*
                         * Initialize the separator.
index 8271431d21119022773d9e961cdd95c350c2f95a..92c8e11a58593d9f3814711c640efc1baf500f98 100644 (file)
@@ -219,7 +219,7 @@ dissect_x29(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                 * Q bit not set - this is data.
                 */
                if (check_col(pinfo->cinfo, COL_INFO))
-                       col_add_fstr(pinfo->cinfo, COL_INFO, "Data ...");
+                       col_set_str(pinfo->cinfo, COL_INFO, "Data ...");
 
                if (tree) {
                        while (tvb_offset_exists(tvb, offset)) {
index aeb1ccfd4d1636c37687cc8842c61d469cd57299..0bd6bb41433854f90b42cd1cfdf57adf4bf0c2d6 100644 (file)
@@ -219,7 +219,7 @@ static void dissect_xdmcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   }
   offset += 2;
   if (check_col(pinfo->cinfo, COL_INFO)) {
-    col_add_fstr(pinfo->cinfo, COL_INFO, "%s",
+    col_add_str(pinfo->cinfo, COL_INFO, 
                  val_to_str(opcode, opcode_vals, "Unknown (0x%04x)"));
 
   }
index ab6755e6583f9b04c31620aaae24451de999baa9..aea967bae47be5d6521ca0b824a5212140cdfa21 100644 (file)
@@ -408,7 +408,7 @@ dissect_order_call(tvbuff_t *tvb, int offset, packet_info *pinfo _U_, proto_tree
        /*map*/
        offset = dissect_rpc_string(tvb, tree, hf_ypserv_map, offset, &str);
        if (check_col(pinfo->cinfo, COL_INFO)) {
-               col_append_fstr(pinfo->cinfo, COL_INFO,"%s", str);
+               col_append_str(pinfo->cinfo, COL_INFO, str);
        }
        proto_item_append_text(tree, "%s", str);