NETLOGON: Fix bugs with netlogon decryption not working in some cases
authorsahlberg <sahlberg@f5534014-38df-0310-8fa8-9805f1628bb7>
Sat, 11 Feb 2012 02:09:20 +0000 (02:09 +0000)
committersahlberg <sahlberg@f5534014-38df-0310-8fa8-9805f1628bb7>
Sat, 11 Feb 2012 02:09:20 +0000 (02:09 +0000)
If there is only one Authenticatex in the file, decryption is not
working.

from Matthieu Patou <mat@matws.net>

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40960 f5534014-38df-0310-8fa8-9805f1628bb7

epan/dissectors/packet-dcerpc-netlogon.c

index c75ca45903f2b7d95e657815c234637323d8e16d..6af34dd286c8c2428bbc014eb19b38bea6c21b7a 100644 (file)
@@ -2538,11 +2538,12 @@ netlogon_dissect_netrserverreqchallenge_rqst(tvbuff_t *tvb, int offset,
         g_hash_table_insert(netlogon_auths, key, vars);
     }
     else {
-        while(existing_vars->next != NULL && existing_vars->start <= vars->start) {
+        while(existing_vars->next != NULL && existing_vars->start < vars->start) {
+            debugprintf("Looping to find existing vars ...\n");
             existing_vars = existing_vars->next;
         }
-        if(existing_vars->next != NULL || existing_vars == vars) {
-            debugprintf("It seems that I already record this vars %d\n",vars->start);
+        if(existing_vars->next != NULL || existing_vars->start == vars->start) {
+            debugprintf("It seems that I already record this vars start packet = %d\n",vars->start);
         }
         else {
             debugprintf("Adding a new entry with this start packet = %d\n",vars->start);