Free our flow graph strings when we're done with them. Add a note about

flow graphs to the release notes, along with other stuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15928 f5534014-38df-0310-8fa8-9805f1628bb7

diff --git a/docbook/release-notes.xml b/docbook/release-notes.xml
index a0e39ccfc2ad7c6a7a2e1859168d67da9f3e61f8..f81f8c44fa913c7ab4a489667555f9d18ac2729a 100644 (file)
--- a/docbook/release-notes.xml
+++ b/docbook/release-notes.xml
@@ -67,7 +67,8 @@ Gnu info
   <section id="WhatsNew"><title>What's New</title>
     <section><title>Bugfixes</title>
     <para>
-      The following bugs have been fixed since the previous release:
+      The following security vulnerabilities have been fixed since the
+      previous release:
       <itemizedlist>
 
        <listitem><para>
@@ -167,6 +168,10 @@ Gnu info
       </itemizedlist>
     </para>
 
+    <para>
+      When trying to save a flow graph, Ethereal could crash.
+    </para>
+
     <para>
       The PCRE library that ships with the Windows installer has been upgraded
       from version 4.4 to 6.3 in response to a
@@ -215,6 +220,10 @@ Gnu info
          by Ethereal.
        </para></listitem>
 
+        <listitem><para>
+          Ethereal's memory managment has been greatly improved.
+        </para></listitem>
+
       </itemizedlist>
     </para>
     </section>
@@ -258,11 +267,12 @@ Gnu info
 
   </section>
 
+  <!-- XXX needs to be written 
   <section id="RemovingEthereal"><title>Removing Ethereal</title>
     <para>
-  <!-- XXX needs to be written -->
     </para>
   </section>
+  -->
 
   <section id="FileLocations"><title>File Locations</title>
     <para>
@@ -285,13 +295,21 @@ Gnu info
 
   <section id="GettingHelp"><title>Getting Help</title>
     <para>
-  <!-- XXX needs to be written -->
+    Community support is available on the ethereal-users mailing list.
+    Subscription information and archives for all of Ethereal's mailing
+    lists can be found on <ulink url="http://www.ethereal.com/lists">the
+    web site</ulink>. There is also an <ulink url="irc://irc.freenode.net/ethereal">IRC channel dedicated to Ethereal</ulink>.
+    </para>
+    <para>
+    Commercial support, training, and development services are available
+    from <ulink url="http://www.etherealsoft.com/">Ethereal Software</ulink>.
     </para>
   </section>
 
   <section id="FAQ"><title>Frequently Asked Questions</title>
     <para>
-  <!-- XXX needs to be written -->
+    A complete FAQ is available on the
+    <ulink url="http://www.ethereal.com/faq.html">Ethereal web site</ulink>.
     </para>
   </section>
 

diff --git a/gtk/graph_analysis.c b/gtk/graph_analysis.c
index f8dfa0a418f1d9c9d09b3d8cffa6b6e8a0fb00de..2e1e4a046b5be5ed6e3eb6c16fa1f75ed7e8a164 100644 (file)
--- a/gtk/graph_analysis.c
+++ b/gtk/graph_analysis.c
@@ -261,6 +261,11 @@ static void overwrite (GString *gstr, char *text_to_insert, guint32 p1, guint32
 }
 
 
+/*
+ * XXX - We might want to refactor this to write the graph data directly to
+ * the file instead of loading everything into strings first.
+ */
+
 /****************************************************************************/
 static gboolean dialog_graph_dump_to_file(graph_analysis_data_t* user_data)
 {
@@ -447,6 +452,12 @@ static gboolean dialog_graph_dump_to_file(graph_analysis_data_t* user_data)
                fprintf(of,"%s\n",tmp_str->str);
        }
 
+       g_string_free(label_string, TRUE);
+       g_string_free(empty_line, TRUE);
+       g_string_free(separator_line, TRUE);
+       g_string_free(tmp_str, TRUE);
+       g_string_free(tmp_str2, TRUE);
+
        fclose (of);
        return TRUE;